From nobody Wed Feb 11 22:54:23 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6407763F1; Wed, 19 Jun 2024 07:31:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718782315; cv=none; b=q/Fr+laF9ChKSm8aPumKAMI7oTEEAWbLh9RwoiS+6iDXZ50kTjd7mAldL2oTQFNFUGhUA+fHnTeRV8PAOdDwRlu4XWexKGyO0dL2Z0AKbGLnKzxxTCC8alHYdjEyJ98LOrRKMV4lkshT7C+7jTSCvChE86DKbp8bM1jpY8vQ8G0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718782315; c=relaxed/simple; bh=XTCI3kDrpbBg4Lfz1ZdVs0Sn3hc3Wsh1jH1Bj8wlh68=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=nsVWWh4wL/MAfNS96ZS1nNwFZTkHpKLMRbgHBEdiXtholGYtuQdq9fWw/meIPunS06dM5v8PNzzTF+J9iMOosJcz5eNfWnA+YwnsvpVVhZ4nMjRdQ6WYOat5m3wDtiO1L687vqrGmkg2GkDKg6a1j0RpAJq/kGONTx18fVm5IB0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=arG4GsNk; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="arG4GsNk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0884AC2BBFC; Wed, 19 Jun 2024 07:31:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718782315; bh=XTCI3kDrpbBg4Lfz1ZdVs0Sn3hc3Wsh1jH1Bj8wlh68=; h=From:To:Cc:Subject:Date:From; b=arG4GsNkTijnjq5fIHD9G1mf6WI1/AQwv0wo6LycvxqJ7mLKtrPd7im/qxHA1nz4p dLPyCoDZ89WoftflAwGgofukr1Dhyp0SNenEF39J2C+CM+ltVsIeYn4+bx057Lkfw3 rmssGAVf5VprJemTIVFgZWKSAf/+Soa+H26ApwjJHfxNQgIZo71ehVPRag18Dbhrow BsnG3FFfJpixRwISpDzPe24FOzkyZZt0Miy3b4iRQyM1q+vG0jMCV222dw5+Y0Gv+k 9ZSG4LHcAdOJpF4w0GJTRAZ/FGstrIjc3VffnzRpbTP5670QySnmkc4vTOGz8bjF+l 6gh8m1YpxCx8A== From: Puranjay Mohan To: Guo Ren , Steven Rostedt , linux-csky@vger.kernel.org, linux-kernel@vger.kernel.org Cc: puranjay12@gmail.com Subject: [PATCH] csky: stacktrace: fix usage of ftrace_graph_ret_addr() Date: Wed, 19 Jun 2024 07:31:40 +0000 Message-Id: <20240619073140.48817-1-puranjay@kernel.org> X-Mailer: git-send-email 2.40.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ftrace_graph_ret_addr() now returns the passed in return address when NULL is passed for the 'idx' paramenter. This breaks the current usage in csky's walk_stackframe() Fix this by passing a valid integer pointer to ftrace_graph_ret_addr() Signed-off-by: Puranjay Mohan Reviewed-by: Guo Ren --- arch/csky/kernel/stacktrace.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/csky/kernel/stacktrace.c b/arch/csky/kernel/stacktrace.c index 27ecd63e321b..1d72f18064c2 100644 --- a/arch/csky/kernel/stacktrace.c +++ b/arch/csky/kernel/stacktrace.c @@ -17,6 +17,7 @@ void notrace walk_stackframe(struct task_struct *task, st= ruct pt_regs *regs, bool (*fn)(unsigned long, void *), void *arg) { unsigned long fp, sp, pc; + int graph_idx =3D 0; =20 if (regs) { fp =3D frame_pointer(regs); @@ -50,7 +51,7 @@ void notrace walk_stackframe(struct task_struct *task, st= ruct pt_regs *regs, frame =3D (struct stackframe *)fp; sp =3D fp; fp =3D frame->fp; - pc =3D ftrace_graph_ret_addr(current, NULL, frame->ra, + pc =3D ftrace_graph_ret_addr(current, &graph_idx, frame->ra, (unsigned long *)(fp - 8)); } } --=20 2.40.1