From nobody Thu Feb 12 00:27:51 2026 Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E3A116631B for ; Tue, 18 Jun 2024 13:37:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718717873; cv=none; b=oxWFLyfdADLbM+gsUBXLZskVyClqxXYS7TmDcd/yqr3TndW6chb0C9ks7Tf0JnT0HoBa/VKZ6JuJtF1cN03YDce3Cj6vx6kqoviMk1PodKgd4m/mIM/PwhJt5o3U7VToqGif4DnlT/Ac0IwUcM7+pGtO7cSAtJh2ANdaq9dWH+4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718717873; c=relaxed/simple; bh=GoXx+LUbk1pIIGrnFwGZ+D3NCJxZwtQES8xRkbwieRw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EaZ2RsQdmc/Q06hVQYhDrWWVzhY4wVRRttHNte4gYiIzANWqTpp67JiaeJjUWqJik/+VXn9n4Al0UtGi4HCnU2ULOBnZ4CCyp8WeZexL0es6KjkR6w9Hx6Jnn0KSWSwX695O8ufmdBkimeyWOmz028mVy0LvBuWN9iX/UFirn3s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=PBtoONjp; arc=none smtp.client-ip=209.85.167.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="PBtoONjp" Received: by mail-oi1-f178.google.com with SMTP id 5614622812f47-3c9cc681ee0so2599572b6e.0 for ; Tue, 18 Jun 2024 06:37:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1718717871; x=1719322671; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=lyFYwbZ5CJhnsT3ZAVEp/WPT2f72YwpJexmvGlup3eA=; b=PBtoONjpp8Yb95gX83yBzyI7CvzCNSeoVGBBPcj6lD59IVcw5ZuHqMMtoqLk3TvMh8 xY67HKSF+dC/akFDVRQR8ffSCvOh8iWrlzSoIeqsp7dfIipF6w7g/FMJybboJWc17tHy PGYdqjEVwHDttgsoqmUSLhELBcQPT/re3guf4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718717871; x=1719322671; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lyFYwbZ5CJhnsT3ZAVEp/WPT2f72YwpJexmvGlup3eA=; b=gNVhKtURUDfn/R83MknvphxMzCqRkwgYevaXhot46bespvsHb2lyk7Hy9WumM24sJI UtEJ1EJtU2D3tKqe2ETKJS9NYiaI4lSEK0znQdM6Hk1WaKxZz+dLA0jsF0ZaMMszh3CX fMcu5uOB6b4VobjzTg9hBLyQgw11uc7/nbyCtIUFp0SGwAB5hVkRq6wOlNaTdWCdA67t oyUDPwQpHdBZln3FDAFeq7UQeT68NnndsFpiGA8r58/SQTfeBqQNf/iPw5YvzS7nMJ+p aA2CGRXuYUqV5lPR35/GGrCsnTVubBnekAjQUy+HB9X6e/nnKlWrXUcljFLbgKMZ8fZc BNmw== X-Forwarded-Encrypted: i=1; AJvYcCU0AchZJqM5Hx+v3z1fqR6paIilfj/06nHTrcsKWNYz/OIkOMyAhkgsleLO0dSi6dV9/ELutCeMUg+YIR9SJrKwwU/7UrjMqFtfp3Co X-Gm-Message-State: AOJu0Yzu3oxjaKvDo9A8MxY3XBqVrz4nXQjV6wK1tNDSZnt0CModUsP5 WGygkG3sgwshUfdicVHoZqUNF1f9G/CNnHTaWYIoW/ICaWdUFcGFXVtkwTZ+Iw== X-Google-Smtp-Source: AGHT+IEmRQPni9rlDK9KsV2t5smDWQkyDsQQTzI4m1+U7VAK4E1oD11JY+8S6sqxF/BUxo0nnLHy7A== X-Received: by 2002:a05:6808:1a18:b0:3d2:21c8:e1d5 with SMTP id 5614622812f47-3d24e8fb77bmr15257913b6e.25.1718717871081; Tue, 18 Jun 2024 06:37:51 -0700 (PDT) Received: from denia.c.googlers.com (123.178.145.34.bc.googleusercontent.com. [34.145.178.123]) by smtp.gmail.com with ESMTPSA id af79cd13be357-798abc06e93sm521666385a.82.2024.06.18.06.37.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jun 2024 06:37:50 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 18 Jun 2024 13:37:44 +0000 Subject: [PATCH v5 01/10] media: venus: Remove unused structs Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240618-cocci-flexarray-v5-1-6a8294942f48@chromium.org> References: <20240618-cocci-flexarray-v5-0-6a8294942f48@chromium.org> In-Reply-To: <20240618-cocci-flexarray-v5-0-6a8294942f48@chromium.org> To: Mauro Carvalho Chehab , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.13.0 This structures are not used, and have a single element array at the end of them. Remove them. This fix the following cocci warnings: drivers/media/platform/qcom/venus/hfi_helper.h:764:5-15: WARNING use flexib= le-array member instead (https://www.kernel.org/doc/html/latest/process/dep= recated.html#zero-length-and-one-element-arrays) drivers/media/platform/qcom/venus/hfi_helper.h:1041:5-15: WARNING use flexi= ble-array member instead (https://www.kernel.org/doc/html/latest/process/de= precated.html#zero-length-and-one-element-arrays) drivers/media/platform/qcom/venus/hfi_helper.h:1088:39-51: WARNING use flex= ible-array member instead (https://www.kernel.org/doc/html/latest/process/d= eprecated.html#zero-length-and-one-element-arrays) drivers/media/platform/qcom/venus/hfi_helper.h:1093:5-22: WARNING use flexi= ble-array member instead (https://www.kernel.org/doc/html/latest/process/de= precated.html#zero-length-and-one-element-arrays) drivers/media/platform/qcom/venus/hfi_helper.h:1144:4-8: WARNING use flexib= le-array member instead (https://www.kernel.org/doc/html/latest/process/dep= recated.html#zero-length-and-one-element-arrays) drivers/media/platform/qcom/venus/hfi_helper.h:1239:4-8: WARNING use flexib= le-array member instead (https://www.kernel.org/doc/html/latest/process/dep= recated.html#zero-length-and-one-element-arrays) drivers/media/platform/qcom/venus/hfi_helper.h:1272:4-13: WARNING use flexi= ble-array member instead (https://www.kernel.org/doc/html/latest/process/de= precated.html#zero-length-and-one-element-arrays) drivers/media/platform/qcom/venus/hfi_cmds.h:85:5-16: WARNING use flexible-= array member instead (https://www.kernel.org/doc/html/latest/process/deprec= ated.html#zero-length-and-one-element-arrays) drivers/media/platform/qcom/venus/hfi_cmds.h:180:5-9: WARNING use flexible-= array member instead (https://www.kernel.org/doc/html/latest/process/deprec= ated.html#zero-length-and-one-element-arrays) drivers/media/platform/qcom/venus/hfi_cmds.h:189:5-9: WARNING use flexible-= array member instead (https://www.kernel.org/doc/html/latest/process/deprec= ated.html#zero-length-and-one-element-arrays) Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/hfi_cmds.h | 26 --------------- drivers/media/platform/qcom/venus/hfi_helper.h | 46 ----------------------= ---- 2 files changed, 72 deletions(-) diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.h b/drivers/media/p= latform/qcom/venus/hfi_cmds.h index 20acd412ee7b..41f765eac4d9 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.h +++ b/drivers/media/platform/qcom/venus/hfi_cmds.h @@ -77,14 +77,6 @@ struct hfi_sys_get_property_pkt { u32 data[1]; }; =20 -struct hfi_sys_set_buffers_pkt { - struct hfi_pkt_hdr hdr; - u32 buffer_type; - u32 buffer_size; - u32 num_buffers; - u32 buffer_addr[1]; -}; - struct hfi_sys_ping_pkt { struct hfi_pkt_hdr hdr; u32 client_data; @@ -171,24 +163,6 @@ struct hfi_session_empty_buffer_uncompressed_plane0_pk= t { u32 data[1]; }; =20 -struct hfi_session_empty_buffer_uncompressed_plane1_pkt { - u32 flags; - u32 alloc_len; - u32 filled_len; - u32 offset; - u32 packet_buffer2; - u32 data[1]; -}; - -struct hfi_session_empty_buffer_uncompressed_plane2_pkt { - u32 flags; - u32 alloc_len; - u32 filled_len; - u32 offset; - u32 packet_buffer3; - u32 data[1]; -}; - struct hfi_session_fill_buffer_pkt { struct hfi_session_hdr_pkt shdr; u32 stream_id; diff --git a/drivers/media/platform/qcom/venus/hfi_helper.h b/drivers/media= /platform/qcom/venus/hfi_helper.h index e4c05d62cfc7..f61295819cc1 100644 --- a/drivers/media/platform/qcom/venus/hfi_helper.h +++ b/drivers/media/platform/qcom/venus/hfi_helper.h @@ -759,11 +759,6 @@ struct hfi_multi_stream_3x { u32 enable; }; =20 -struct hfi_multi_view_format { - u32 views; - u32 view_order[1]; -}; - #define HFI_MULTI_SLICE_OFF 0x1 #define HFI_MULTI_SLICE_BY_MB_COUNT 0x2 #define HFI_MULTI_SLICE_BY_BYTE_COUNT 0x3 @@ -1036,11 +1031,6 @@ struct hfi_codec_supported { u32 enc_codecs; }; =20 -struct hfi_properties_supported { - u32 num_properties; - u32 properties[1]; -}; - struct hfi_max_sessions_supported { u32 max_sessions; }; @@ -1076,23 +1066,6 @@ struct hfi_resource_ocmem { u32 mem; }; =20 -struct hfi_resource_ocmem_requirement { - u32 session_domain; - u32 width; - u32 height; - u32 size; -}; - -struct hfi_resource_ocmem_requirement_info { - u32 num_entries; - struct hfi_resource_ocmem_requirement requirements[1]; -}; - -struct hfi_property_sys_image_version_info_type { - u32 string_size; - u8 str_image_version[1]; -}; - struct hfi_codec_mask_supported { u32 codecs; u32 video_domains; @@ -1135,15 +1108,6 @@ struct hfi_index_extradata_config { u32 index_extra_data_id; }; =20 -struct hfi_extradata_header { - u32 size; - u32 version; - u32 port_index; - u32 type; - u32 data_size; - u8 data[1]; -}; - struct hfi_batch_info { u32 input_batch_count; u32 output_batch_count; @@ -1234,11 +1198,6 @@ static inline void hfi_bufreq_set_count_min_host(str= uct hfi_buffer_requirements req->count_min =3D val; }; =20 -struct hfi_data_payload { - u32 size; - u8 data[1]; -}; - struct hfi_enable_picture { u32 picture_type; }; @@ -1267,11 +1226,6 @@ struct hfi_buffer_alloc_mode_supported { u32 data[1]; }; =20 -struct hfi_mb_error_map { - u32 error_map_size; - u8 error_map[1]; -}; - struct hfi_metadata_pass_through { int enable; u32 size; --=20 2.45.2.627.g7a2c4fd464-goog From nobody Thu Feb 12 00:27:51 2026 Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com [209.85.167.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0B621667FA for ; Tue, 18 Jun 2024 13:37:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718717874; cv=none; b=ojPp+OKyinlb2YxGFX48Yc1pSGKIxaYc15y4aTPSEU1Wbn1roHujz2gUO0BHNDBArW5vZKngw0dMAkAz592mnTsYOia//HizdCTaDoRxNkJZ3cQH61ELNmPLHPulwdXHdND2HnJ7i9WLqMkipnLFqoTuOfeEbs2+yZQDb0BAHCI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718717874; c=relaxed/simple; bh=vg4N3vHUM1NcfIbzq9vLahhTUasyDZ1bYNx+7yaEx7k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bzuhMwEqi91UkunwxInf2y82grhmTkbR9SU2YppRZ2obcgpNX2gS3Gn5u84rr/F/0JLbB9tmw5CyEecmTAF88gIy94kVVNzHeevAuldGlmqCfBFVsUwGu1rL55dMQRG5hFYN7U9NrnKNV/RcaXeZH2YN6mn9sbjZ4sRnfqmglvY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=LVvpOfA/; arc=none smtp.client-ip=209.85.167.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="LVvpOfA/" Received: by mail-oi1-f182.google.com with SMTP id 5614622812f47-3cabac56b38so3183423b6e.3 for ; Tue, 18 Jun 2024 06:37:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1718717872; x=1719322672; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=iBlrdaaQBMTsb4IyivLP+IImA8pYTXHtea9bJPgetqc=; b=LVvpOfA/p38b9lHM8K/FCUwLLBHVbdmWK/2m1cwXvO21gnad89zy58f7ksG62Jd/o1 WI7WQVMyp4+2l1B8IIqauw/AYOAnZbb2ys3o4PhPYIP6QPtIwUbeqbs6kpdQC4UA67C/ XDZYCkddpxPHrZ9WjKkdWJcjWcF9YAVSqzmHM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718717872; x=1719322672; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iBlrdaaQBMTsb4IyivLP+IImA8pYTXHtea9bJPgetqc=; b=XMKwxqn0uNQyAZ4K4v56o2anEMj6xkWGmz4z6FE+Kmwf1uSxPBfgFL9lSD9WRnRcgg rGo++4d071PiBvR/mBgQkmpcRHjrrX4caOosNVVnc4X564RX7G2GMYnsOAMlFE94ASrv OOpl9H2URagn0t5HC72kShyxXm43F0xcKcTtDYMVqv2xICc1ejuVIvT18pirEY4rZ+RY BtH/0ISGEZhJy7p+tsRjAiT0GlNt2X4TY2bl5ZFsW45o6BED8FbAKfAd0gPSAPJ7C7l1 6VEee2ymMQHKXfSG0twC8j7XZommU1Mv9N45hJY2FNYcU/dWLjA04rdkwqPXJiK8QZ3/ 5xmg== X-Forwarded-Encrypted: i=1; AJvYcCWlnTz0RGIqo+lySEWDB+ndfAJRNKxv3Xs3S0OCIsRUgwTFgb0b1G/O0wpTvyFYnMI3R08zQ/XSr/gfFlYjRLXMrerxHBVd+3qQPe2y X-Gm-Message-State: AOJu0YzT55xoxKPaROTkwPx6rX2v9jNZVhatrkLzkXE4J5WDFXEbsWEg +K844UmbFTzgGl6DCr4ZwDFMsLaW6/OP3GPVzQF8lrVU0Z6A84jmoMa4n9hQbg== X-Google-Smtp-Source: AGHT+IGAbmA+QOT2T92r/tmWOvvfxvs5SSBY51LP38a381c8Nq7cxwS5jqWGmNHK7iqs+JxA0IQXeA== X-Received: by 2002:a05:6808:128b:b0:3d2:2b1d:7bd9 with SMTP id 5614622812f47-3d24e9085e7mr15725342b6e.33.1718717872024; Tue, 18 Jun 2024 06:37:52 -0700 (PDT) Received: from denia.c.googlers.com (123.178.145.34.bc.googleusercontent.com. [34.145.178.123]) by smtp.gmail.com with ESMTPSA id af79cd13be357-798abc06e93sm521666385a.82.2024.06.18.06.37.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jun 2024 06:37:51 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 18 Jun 2024 13:37:45 +0000 Subject: [PATCH v5 02/10] media: venus: Use flex array for hfi_session_release_buffer_pkt Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240618-cocci-flexarray-v5-2-6a8294942f48@chromium.org> References: <20240618-cocci-flexarray-v5-0-6a8294942f48@chromium.org> In-Reply-To: <20240618-cocci-flexarray-v5-0-6a8294942f48@chromium.org> To: Mauro Carvalho Chehab , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.13.0 Replace the old style single element array with a flex array. We do not allocate this structure, so the size change should not be an issue. This fixes the following cocci warning: drivers/media/platform/qcom/venus/hfi_cmds.h:204:5-16: WARNING use flexible= -array member instead (https://www.kernel.org/doc/html/latest/process/depre= cated.html#zero-length-and-one-element-arrays) Reviewed-by: Bryan O'Donoghue Acked-by: Vikash Garodia Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/hfi_cmds.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.h b/drivers/media/p= latform/qcom/venus/hfi_cmds.h index 41f765eac4d9..6dff949c4402 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.h +++ b/drivers/media/platform/qcom/venus/hfi_cmds.h @@ -201,7 +201,7 @@ struct hfi_session_release_buffer_pkt { u32 extradata_size; u32 response_req; u32 num_buffers; - u32 buffer_info[1]; + u32 buffer_info[]; }; =20 struct hfi_session_release_resources_pkt { --=20 2.45.2.627.g7a2c4fd464-goog From nobody Thu Feb 12 00:27:51 2026 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6A76168491 for ; Tue, 18 Jun 2024 13:37:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718717876; cv=none; b=ZZ8ZUiAtm/1zQOaXqkheg6e/s0/26dBact1gZZv2FHXXSpLB9VV1yvxQaQbFA0xjmuW+Q6ihMuswDB/b7EpD24ux81EhjBteDwAMPECf4ihDuKrFZw0jLdIt/Rpzxazh5WSxpXWr8cOi5ccH4lVDrOTcg9jSB3tWA+FYmPT8TPw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718717876; c=relaxed/simple; bh=JCwRzQfJUN4DIo72lM4nWjkcyF1hZtywYkiYbZ3Wb1g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZJWxTX5ffaS/30IaUnjceNiWRLFavAtEa2Ap4uhfFPZQN5fHNcse6duCnm3oDh6B3U4b2/nc30wpEkwH5CdNV0SY648VrXcXajJIN4ET+MUPY6sH+sz/0+EjgvLoPgg1hKisIY4hw5mZmILVXze/Uh/ionNZxqIpy+1IJgkCwNM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=aEnGINkc; arc=none smtp.client-ip=209.85.222.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="aEnGINkc" Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-797dcb558ebso353021785a.2 for ; Tue, 18 Jun 2024 06:37:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1718717874; x=1719322674; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=NfmzknDlhP7JVdeMuBVj3S4t4ocBYNX2DjumHrcLghk=; b=aEnGINkci36kajF9DwTSi7/Gsy0zU3fBpt589MxJAI34CBMzb7rxpXvXc0/Hqgh3JN NFtFBDVI90y7ssk9J6m/pO8+qJqL4UR4OdUKoyo3XynsewHPml48Hi+Lvdws2QSqO7A2 RIMxG5c1Q3XTqtEGDsad/TUa7LXMQB4jeb6w0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718717874; x=1719322674; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NfmzknDlhP7JVdeMuBVj3S4t4ocBYNX2DjumHrcLghk=; b=gn0ItA9/HBC58S9AbFTRXUdwI7LTWAGODkLbhm2i2J1BefxtGbEbLmci0m2Aduik4x IhDd0sWdE9zhYYlEk6qMmzlJP05C1rFC2PilGf5U2wkAbuEvcbQ1utid/FghY9qR53iU SoO8OvoY1z3O5pzLt3B0Io1KZD5q+LNHwnlN6d3+h4IbACrfb9obYJpuw4CvgXc3xyYJ vOZxD1IhIxWplBQRVm5k0hqVX3kR/tzRkM1EDbvBziR/QNePbtVAiowc1okAw3vt/8CX uUBSTTiXj/A1idsV3LfFGDsq+CW98dvRURmIFBMmmJ7ceT8Dgu+LXo4AygkpuAvc32kf n3VA== X-Forwarded-Encrypted: i=1; AJvYcCUUUhP4oEGMVY71F7MhHQ3zfZqO+f3eGOlvnXHJy67TXa7Oez9yjD25TGA39K4AvBJPas5LEUPM/XdmUTVXPPEp2IDi07rZykxy/jIx X-Gm-Message-State: AOJu0Yz2RVwwwcCcGoyy/YDaIDcYRsZvjodbMSwEcB6bJcyLyJX7cnst 6gue1EskefQuXu+OKIiMT4frboNfUQXpwktWLmidkp0lc0x7PUVBDUTTWDL1HA== X-Google-Smtp-Source: AGHT+IGEfL8XeSfOM4jwm81aDULa50VWwdKgHpsA+y9HEy95/tn/hw5XDbDctHO+xTMeAiPX0ksKzA== X-Received: by 2002:a05:620a:28d3:b0:795:5ad3:87ce with SMTP id af79cd13be357-798d2438227mr1412816285a.34.1718717873897; Tue, 18 Jun 2024 06:37:53 -0700 (PDT) Received: from denia.c.googlers.com (123.178.145.34.bc.googleusercontent.com. [34.145.178.123]) by smtp.gmail.com with ESMTPSA id af79cd13be357-798abc06e93sm521666385a.82.2024.06.18.06.37.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jun 2024 06:37:53 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 18 Jun 2024 13:37:46 +0000 Subject: [PATCH v5 03/10] media: venus: Refactor struct hfi_uncompressed_plane_info Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240618-cocci-flexarray-v5-3-6a8294942f48@chromium.org> References: <20240618-cocci-flexarray-v5-0-6a8294942f48@chromium.org> In-Reply-To: <20240618-cocci-flexarray-v5-0-6a8294942f48@chromium.org> To: Mauro Carvalho Chehab , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.13.0 This field is never used, but if we remove it we would change the size of the struct and can lead to behavior change. Stay on the safe side by replacing the single element array with a single element field. This fixes the following cocci warning: drivers/media/platform/qcom/venus/hfi_helper.h:1003:43-60: WARNING use flex= ible-array member instead (https://www.kernel.org/doc/html/latest/process/d= eprecated.html#zero-length-and-one-element-arrays) Reviewed-by: Bryan O'Donoghue Acked-by: Vikash Garodia Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/hfi_helper.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/venus/hfi_helper.h b/drivers/media= /platform/qcom/venus/hfi_helper.h index f61295819cc1..c53e2fb2d42c 100644 --- a/drivers/media/platform/qcom/venus/hfi_helper.h +++ b/drivers/media/platform/qcom/venus/hfi_helper.h @@ -1000,7 +1000,7 @@ struct hfi_uncompressed_plane_constraints { struct hfi_uncompressed_plane_info { u32 format; u32 num_planes; - struct hfi_uncompressed_plane_constraints plane_constraints[1]; + struct hfi_uncompressed_plane_constraints plane_constraints; }; =20 struct hfi_uncompressed_format_supported { --=20 2.45.2.627.g7a2c4fd464-goog From nobody Thu Feb 12 00:27:51 2026 Received: from mail-ua1-f49.google.com (mail-ua1-f49.google.com [209.85.222.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22E5416B387 for ; Tue, 18 Jun 2024 13:37:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718717877; cv=none; b=iSC9nMa9LQkOSb7LRke99XloVidJoUqKP/D48YPCIyLvF8I3oz5gt5yI4MQn+SmIEV2vLYwAy6T3po59IH0D5xFAzGPbOZ6kM92FAyi2/J6+J4aFf3i1vxo5LLvsqp766Lvlhyp4Hm6wzUl2xoz2IVfcbkCEAUD9CXJTyaacekQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718717877; c=relaxed/simple; bh=Kx34urW1bu83x+FpRH2PjWtCHfI81fNXdP9esvIj2lg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NF338OHjeISWKy6xRXyVcwscuJYXUsFHothut4hjqkfFggSDzs9bEICQqAmzQ4+5K4FK8FBqNupcM+mdoQSYmnzima2+fnaUPAc2jnOoYocOgEsj04lmASp+oYdKStLwerW9ZJthokbRUUScZGK9QPuvyCzwaoERJ1JEIba92YY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=ED+Mf5PM; arc=none smtp.client-ip=209.85.222.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ED+Mf5PM" Received: by mail-ua1-f49.google.com with SMTP id a1e0cc1a2514c-80b821f3dd6so1380510241.2 for ; Tue, 18 Jun 2024 06:37:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1718717875; x=1719322675; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=uSxpnRMMBh3XAQOKvAUYOjxDrEUAAE5bMiw0Qh3Ul94=; b=ED+Mf5PMUM9of7URCeAn7RNQyecPKy1WZT9ZXXKfINjlYKnJS4TTjPujbIoucX9y9v rIkowdH+aHrbVgCph+ZcuOjYR8l6lU8OIhUB0z1AGCe1G3zqPXcP+oeIdo8n8pOHUUJ1 5lmFQ6fRFXcnZEKnN2BqIsojaiULo27kjpej8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718717875; x=1719322675; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uSxpnRMMBh3XAQOKvAUYOjxDrEUAAE5bMiw0Qh3Ul94=; b=G2eSCeMHYxvpdEsF/8H8ikjjBhqmDD8D8kZweCQL8PmkgBItyehCSQraVLO+LZG52d JHGxgBXpPTq/UmjAqErKtCHRc66mdktW7IXt/BUmW0kcQen6ycw/gXL8cccgbaH/V3EC Agk/ScZs8QPYuLWS267mi69wF9+drgzBNMBIr3XNyeXSvqqmIZCq+I3PsQ5g8XVPnSIC /CoiQsHWe3e+BgrZKqpMna7r5aBK7C6anNrcVO7x368xezlK08KEBWzsLiJ8w2wsHrgD 4sdXOmXS25eNyV7IjrN5afvJ4B4LBNnssOWAnz6UhUHYT438yL1etNID/WSXEQn9LlAp Hj5A== X-Forwarded-Encrypted: i=1; AJvYcCW6u6xqAfd2hncrVECW7sUg2cSbDEn0ql5hc85xJYOnSt1cVC8pl1kicOBGDhjEhZRjFtos6TkYMMKzhPiJt1EJ+iIffdYzX1OTtj8J X-Gm-Message-State: AOJu0YznzE6Ov/tYKsGg+mKkvgtQqgmNsji08CltfVtHQmJo7+YaOq9i /05mCO+ozcZNxzJY9OP+0rmnnuFpjiB5SgjSITmGWuNsBtfsQzkb5T0dX5ic6Q== X-Google-Smtp-Source: AGHT+IHAODVjmf2y7hxDr47vyEGKr+vtIgOCrnudAO3YuibggEVox0Hp/ospxqFRpHhKmeRWGN0DcQ== X-Received: by 2002:a05:6122:c97:b0:4d3:cff6:79f0 with SMTP id 71dfb90a1353d-4ee3e9808e5mr12164963e0c.4.1718717874707; Tue, 18 Jun 2024 06:37:54 -0700 (PDT) Received: from denia.c.googlers.com (123.178.145.34.bc.googleusercontent.com. [34.145.178.123]) by smtp.gmail.com with ESMTPSA id af79cd13be357-798abc06e93sm521666385a.82.2024.06.18.06.37.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jun 2024 06:37:54 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 18 Jun 2024 13:37:47 +0000 Subject: [PATCH v5 04/10] media: venus: Refactor struct hfi_session_get_property_pkt Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240618-cocci-flexarray-v5-4-6a8294942f48@chromium.org> References: <20240618-cocci-flexarray-v5-0-6a8294942f48@chromium.org> In-Reply-To: <20240618-cocci-flexarray-v5-0-6a8294942f48@chromium.org> To: Mauro Carvalho Chehab , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.13.0 The struct hfi_session_get_property_pkt is always used to fetch a single property. Make that explicit in the code and avoid a single element array at the end of the struct. This change fixes the following cocci warning: drivers/media/platform/qcom/venus/hfi_cmds.h:194:5-9: WARNING use flexible-= array member instead (https://www.kernel.org/doc/html/latest/process/deprec= ated.html#zero-length-and-one-element-arrays) Reviewed-by: Bryan O'Donoghue Acked-by: Vikash Garodia Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/hfi_cmds.c | 4 ++-- drivers/media/platform/qcom/venus/hfi_cmds.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.c b/drivers/media/p= latform/qcom/venus/hfi_cmds.c index 3418d2dd9371..75f4a3d3e748 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.c +++ b/drivers/media/platform/qcom/venus/hfi_cmds.c @@ -402,7 +402,7 @@ static int pkt_session_get_property_1x(struct hfi_sessi= on_get_property_pkt *pkt, pkt->shdr.hdr.pkt_type =3D HFI_CMD_SESSION_GET_PROPERTY; pkt->shdr.session_id =3D hash32_ptr(cookie); pkt->num_properties =3D 1; - pkt->data[0] =3D ptype; + pkt->data =3D ptype; =20 return 0; } @@ -1110,7 +1110,7 @@ pkt_session_get_property_3xx(struct hfi_session_get_p= roperty_pkt *pkt, =20 switch (ptype) { case HFI_PROPERTY_CONFIG_VDEC_ENTROPY: - pkt->data[0] =3D HFI_PROPERTY_CONFIG_VDEC_ENTROPY; + pkt->data =3D HFI_PROPERTY_CONFIG_VDEC_ENTROPY; break; default: ret =3D pkt_session_get_property_1x(pkt, cookie, ptype); diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.h b/drivers/media/p= latform/qcom/venus/hfi_cmds.h index 6dff949c4402..f5708fdfb197 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.h +++ b/drivers/media/platform/qcom/venus/hfi_cmds.h @@ -191,7 +191,7 @@ struct hfi_session_resume_pkt { struct hfi_session_get_property_pkt { struct hfi_session_hdr_pkt shdr; u32 num_properties; - u32 data[1]; + u32 data; }; =20 struct hfi_session_release_buffer_pkt { --=20 2.45.2.627.g7a2c4fd464-goog From nobody Thu Feb 12 00:27:51 2026 Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 629E116B38D for ; Tue, 18 Jun 2024 13:37:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718717878; cv=none; b=TbkP65hqzgLPvlCvqjhikPBg8lu1ZrNT/H0mTMrGftowqXipnD9po/gJsZoD8owUd35wQLwJCuC2w3G8x8CI9azU0gJoWj/tuTk16w8meKDSHuXKzw6IJyEOMPVhB8BSGZkY8Y+oh8HEcz0uXJlTEZ5cMoGZlgRBGR6+GLd3wBA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718717878; c=relaxed/simple; bh=w3DHP4p4643nKW5OrdOfOxfbPI1T7mPQssl6ldJECKo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PQkVPkJ3wGlVHdj1pTgCcr7Z0e8yWUc2vYARFBJE0JevUWmc5ZcHjIFJn6ci0FMzlasBvqTuUmG4zu5PrugHtOZh/sNcnLcdnVJchduVsq/yR+yyStkxN9+RdLD+brl42T5oxYfK7bS/nYUhIuUf4q0N4OpXOyMGoUn9SKlG9kQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=V7OZe8z5; arc=none smtp.client-ip=209.85.222.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="V7OZe8z5" Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-797b24b8944so516950285a.0 for ; Tue, 18 Jun 2024 06:37:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1718717875; x=1719322675; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=zSnUXEZtxSx3BYm4BCVxhmYch12bVybwuYwnU/i/Z5U=; b=V7OZe8z5aThjADq3yKVV7PgW7gt1/y8zN+5CVDQG1T3urnC8ITxBj+dQlYrSZklzrG usKeswnZ+2PTX37povjfrmivhR/fjkSJp3U6NdWwq9SQQDc0IQK4qEUiTeUcNZ8ZcV12 6nfFykFBL2K3zwJOkwMKdCJcuK2RoLlGLo8sg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718717875; x=1719322675; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zSnUXEZtxSx3BYm4BCVxhmYch12bVybwuYwnU/i/Z5U=; b=pcEJXxwW/LlQdGCZooMpvdwwTfvq8wAePQLeFeouaPjjXoEje36MQUfIGprge/sHeB yRTV94qdGRDEaJt8/BFQZ4042DdBPD0fQaiHCp7V/R8NOy+kjYflOASIadBFS9WLopCF gvhdqRYZtoVeNmmLQftsmAKcmSMKkXeGFlVnh5jUBv/IOOvT7TPhJD1XFp+gY8/H8iCn d5K86G8CL72JyCeJZ9cTs1J8D1aDnYIUBFofCoKkO3pgCc8qr8k8/jOp5aHG4nziQJng f52vyuqeM2SoRt5Mw7zJHfOd6n88riow0nFJhASuCKgCL7JDAJLxv5oSwqElVJFtVvgw UsyA== X-Forwarded-Encrypted: i=1; AJvYcCUpv1VmPE6YECeB9BPyJPNKnMCRFCUMe2fX8jO7ZrtUhgVFRCIF8SbqWLBlmj0UGq66zCV3lQfgD4KjuRuXZrA9yqX3KPGWSKcK7A+y X-Gm-Message-State: AOJu0YxPQAe5q52LzosIjwbuluHR4h/P201c4QN96L83tD5BBM6YLlDB VRtHXIIgPDLukS3rzmfjztqmjH4xQ2vOQ5o3u+KsuSr3XGY8p+IbOuRwUMQOZA== X-Google-Smtp-Source: AGHT+IFosDDClF84gGgSRj5dHMhRBg9h/CZLMI1/BJ04L5j1+KPNuSW/Ol/HXseq/SYmSspuibOWHA== X-Received: by 2002:a05:620a:444f:b0:795:5815:2f9f with SMTP id af79cd13be357-798d241d00fmr1513504185a.25.1718717875384; Tue, 18 Jun 2024 06:37:55 -0700 (PDT) Received: from denia.c.googlers.com (123.178.145.34.bc.googleusercontent.com. [34.145.178.123]) by smtp.gmail.com with ESMTPSA id af79cd13be357-798abc06e93sm521666385a.82.2024.06.18.06.37.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jun 2024 06:37:55 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 18 Jun 2024 13:37:48 +0000 Subject: [PATCH v5 05/10] media: venus: Refactor struct hfi_uncompressed_format_supported Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240618-cocci-flexarray-v5-5-6a8294942f48@chromium.org> References: <20240618-cocci-flexarray-v5-0-6a8294942f48@chromium.org> In-Reply-To: <20240618-cocci-flexarray-v5-0-6a8294942f48@chromium.org> To: Mauro Carvalho Chehab , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.13.0 plane_info is not a typical array, the data is not contiguous: pinfo =3D (void *)pinfo + sizeof(*constr) * num_planes + 2 * sizeof(u32); Replace the single element array with a single element field. This fixes the following cocci warning: drivers/media/platform/qcom/venus/hfi_helper.h:1009:36-46: WARNING use flex= ible-array member instead (https://www.kernel.org/doc/html/latest/process/d= eprecated.html#zero-length-and-one-element-arrays) Reviewed-by: Bryan O'Donoghue Acked-by: Vikash Garodia Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/hfi_helper.h | 2 +- drivers/media/platform/qcom/venus/hfi_parser.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/qcom/venus/hfi_helper.h b/drivers/media= /platform/qcom/venus/hfi_helper.h index c53e2fb2d42c..6202dcfc467a 100644 --- a/drivers/media/platform/qcom/venus/hfi_helper.h +++ b/drivers/media/platform/qcom/venus/hfi_helper.h @@ -1006,7 +1006,7 @@ struct hfi_uncompressed_plane_info { struct hfi_uncompressed_format_supported { u32 buffer_type; u32 format_entries; - struct hfi_uncompressed_plane_info plane_info[1]; + struct hfi_uncompressed_plane_info plane_info; }; =20 struct hfi_uncompressed_plane_actual { diff --git a/drivers/media/platform/qcom/venus/hfi_parser.c b/drivers/media= /platform/qcom/venus/hfi_parser.c index c43839539d4d..3df241dc3a11 100644 --- a/drivers/media/platform/qcom/venus/hfi_parser.c +++ b/drivers/media/platform/qcom/venus/hfi_parser.c @@ -157,7 +157,7 @@ static void parse_raw_formats(struct venus_core *core, u32 codecs, u32 domain, void *d= ata) { struct hfi_uncompressed_format_supported *fmt =3D data; - struct hfi_uncompressed_plane_info *pinfo =3D fmt->plane_info; + struct hfi_uncompressed_plane_info *pinfo =3D &fmt->plane_info; struct hfi_uncompressed_plane_constraints *constr; struct raw_formats rawfmts[MAX_FMT_ENTRIES] =3D {}; u32 entries =3D fmt->format_entries; --=20 2.45.2.627.g7a2c4fd464-goog From nobody Thu Feb 12 00:27:51 2026 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79CFE16B3B7 for ; Tue, 18 Jun 2024 13:37:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718717879; cv=none; b=fnq6HDKaomklX+dEYSrvRxaMYCvZ0h9uX4whhz+bts3Bw/EDHs2FWZD80wBfeeZ5S0uao3axWdvYQyPVnX4yzsWxmM+HR1GUssMTDHVb1n5lDlcTDVwhYD+FylY9hzddHtcxeQnCIrXvYE0KlS1tDz3dkBcSkwYz7kM1ylFY7Cc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718717879; c=relaxed/simple; bh=iELnSY5gu3MPwTWIlT31gap3UcK/8g4Z6s90Q+ubKso=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=inzA2JKK/MEcILW4JhTzzLOYIEwA8Ocx0ofauaDlKOmsimXwVq/RgcUGzuxMY9VsJyT8B/RcBU4AX/M4gusCDdgqusP9guXTND/XrdGCpDhehJwFSUL3MAqFmjCDeigemxEsg1s0AcULVT3Pq2VUZ0OvSri6TTvXUcKh/ynnkvU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=SFXobsN7; arc=none smtp.client-ip=209.85.222.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="SFXobsN7" Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-797fb0b4832so269354585a.0 for ; Tue, 18 Jun 2024 06:37:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1718717876; x=1719322676; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=MW9bvh2bp76Of1yyIbqQelf17GV+Jkv7epwXCqKgstg=; b=SFXobsN7Y6qcPfXteidGdyqryJ6i8m4cGzKjTwpBzq723v/hKxWvLJVMJXsvJ/NfY/ Rks9t35kGa4vZhavMRJK7XsX2Unhz6aiZigj1eoiowFBgs4t44czVOlB+IFfZslA1CtK 7VHHA+tKaSB68PEB5xEUwFVN8nNkYmd9PlAUI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718717876; x=1719322676; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MW9bvh2bp76Of1yyIbqQelf17GV+Jkv7epwXCqKgstg=; b=mVgwdGSjHSnsEXqSDwc+9XSUGUdNmPJxMYnR+8Lz2s6x+jEJ8A+k5LAjyIV1OzOLbP 7URS6vEJ6byg1eejhsfLsBUmX49ifJkrjOUCb/ixfiv1vxeUFnp65YEe3/FqsVxnTJ2e KqwyvbirVhWTKXn82BRU4Q/aP7434cJ6pwnFBkeszRubxEMYf3q0eWjPmuHNLklIVPI/ wVL9ufyRhTPIpZXdj5WNji/zToXCkyRfea8c0PB3TH52dLyaoOq6rY7hL3rx4FJEvf18 gh2lTjpOnQmwnmnD92UOsde/RQD+ggg76LTh56m+j7jmt0d4EoJ/jJKEbHtKpchI7+dM /N2A== X-Forwarded-Encrypted: i=1; AJvYcCVMIfTcp9GUdVBnOzpq1YqlCoTri151NZqFcAwlG5nUZVI/jyr1+t6wEfrFqYcQSEauViKt+rtfDVDdqzmy0O9va8GAyXJwpIi0uFKn X-Gm-Message-State: AOJu0YyRPsaT6HUjXweeBfGl8xnsiCFMIXs2uCr5/9cxSUSg4OIiUpPE Xw5RB+SU3jNA++DpKGL3+DHcblj+YrCvc5OWgnstFX3b2s51eM2FZ9tjRL29pw== X-Google-Smtp-Source: AGHT+IHUPkEjN1Rk4xvtyWc0bLx9LlZNTQuD6SlnDrxbm7CEFP8MpAyoWDysNL5JPs/xrPrkaHldpg== X-Received: by 2002:a05:620a:2586:b0:797:5765:b844 with SMTP id af79cd13be357-798d242f63bmr1493021685a.37.1718717876400; Tue, 18 Jun 2024 06:37:56 -0700 (PDT) Received: from denia.c.googlers.com (123.178.145.34.bc.googleusercontent.com. [34.145.178.123]) by smtp.gmail.com with ESMTPSA id af79cd13be357-798abc06e93sm521666385a.82.2024.06.18.06.37.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jun 2024 06:37:55 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 18 Jun 2024 13:37:49 +0000 Subject: [PATCH v5 06/10] media: venus: Refactor hfi_session_empty_buffer_uncompressed_plane0_pkt Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240618-cocci-flexarray-v5-6-6a8294942f48@chromium.org> References: <20240618-cocci-flexarray-v5-0-6a8294942f48@chromium.org> In-Reply-To: <20240618-cocci-flexarray-v5-0-6a8294942f48@chromium.org> To: Mauro Carvalho Chehab , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.13.0 The single element array data[1] is never used. Replace it with a padding field of the same size. This fixes the following cocci error: drivers/media/platform/qcom/venus/hfi_cmds.h:163:5-9: WARNING use flexible-= array member instead (https://www.kernel.org/doc/html/latest/process/deprec= ated.html#zero-length-and-one-element-arrays) Acked-by: Vikash Garodia Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/hfi_cmds.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.h b/drivers/media/p= latform/qcom/venus/hfi_cmds.h index f5708fdfb197..8768ee052adc 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.h +++ b/drivers/media/platform/qcom/venus/hfi_cmds.h @@ -160,7 +160,7 @@ struct hfi_session_empty_buffer_uncompressed_plane0_pkt= { u32 input_tag; u32 packet_buffer; u32 extradata_buffer; - u32 data[1]; + u32 data; }; =20 struct hfi_session_fill_buffer_pkt { --=20 2.45.2.627.g7a2c4fd464-goog From nobody Thu Feb 12 00:27:51 2026 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 611CF16ABC6 for ; Tue, 18 Jun 2024 13:37:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718717881; cv=none; b=P8AqCLbeG1G0eotfzKlcK5AJPL2/xd3AzK1HtXHJ5hqEIqqsRuLbVjWce72N/cJk0GGjO19tFpRXzntoA0gBzYxHl8eozgHJXcoh3E5x3e39amdP4eX2yDgEjzBZR01Dj8OZZ7be3lJJms/zHvQqAxgxSkooM7urjvJJx6sC3js= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718717881; c=relaxed/simple; bh=REbIhZEglYBHgb7HJlMZ2r2p8w/k8dfgexAVenpfyQc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Jh01HY0OjC34+zlVtCKWUfMZ0iKUgIvDSj5TbKVJ6yDvcuTUw9EKxoIPFG506Qa2T30hIcO7rC86BAuv2QTK+kxkPwm0dDUGmT+zI+hzQFrzcDVL9KUKpqz4sl3Uiq3Je9Hr8FzmCCLWIAIOQ9SO7q1mtAxVJwXgh8aUbHcNCOo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Tnq1i92+; arc=none smtp.client-ip=209.85.222.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Tnq1i92+" Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-7955dfce860so337923885a.2 for ; Tue, 18 Jun 2024 06:37:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1718717877; x=1719322677; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=y1nLEejg3OHGtJ31ylvTDCmBSO7HiCAKQK04IWdzamU=; b=Tnq1i92+KnHk0CCFsddSU200F1hHQ2BkaVO8D3dkBksKv1jDl1umQ9/o51sHqlNlAm ku5vPJ0suCEALBDIm4LeWga/3CwmpJA83pcvarAPbFNLLdWukIfp//wLl0ZXrxwZkNZ5 hCDs0jCUnbrMlO/vQW3PsZeoa4qBB2wXQwP60= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718717877; x=1719322677; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=y1nLEejg3OHGtJ31ylvTDCmBSO7HiCAKQK04IWdzamU=; b=DEjoS5M+pKfYcgnCEyfZxq0YgGITiLWDY99+Ao8WHBl+wjujEuaSIn1XZOzrl6NvMZ xa6zPJPZZYrHP9R66L+x4z+4xfi37O6kfNcu5uEkSF1/hoZgHFrUD2FknyABwZ8Srvpi ai117+NCShNOfr9HPyNLuAY1hEYc5oLiIUGNHD889777n297K4gpUrTipbtXXtFUi+bO ZvYKaQL/W5vc0H1FylLMeqlngPlUHKh86GJdo1sdc2ceCEBphd5K5VfCrhBFHMx/815c +WpusoCf+U5UncOzKoqzhEVhQYCild/ElDQkae96kaf9PkNHWgnXUMn6yz/yw6s+gU5t p1Ug== X-Forwarded-Encrypted: i=1; AJvYcCUjHRuuw6poRWxlh5iyLs5z+1o5hYgofgRo1cN8ZjljSuPgzBCDD5qrE/Sxzpnneftd7dcCT1CeItnBQyT1X7ht26gYiVPTB1asFlAw X-Gm-Message-State: AOJu0YwNLwEPGubdIl2gMUt9AUyGuu8ZkaEloXcHcD7iS3j/U/7JQPct CX4Z2OHE899zdEiu9qagKrKxO6opXZNb0ZDcV0f4XraQEDe+bHmyTYDoOLWOLg== X-Google-Smtp-Source: AGHT+IGjdUxmekTm73uUT+ZjPzTRtV+1glujlLe9BtgDyl3oT+EM2OHrXsRD2H0jaRmgr/dPXg3V0g== X-Received: by 2002:a05:620a:298c:b0:795:575c:5bb7 with SMTP id af79cd13be357-798d26ae16cmr1247186685a.74.1718717877269; Tue, 18 Jun 2024 06:37:57 -0700 (PDT) Received: from denia.c.googlers.com (123.178.145.34.bc.googleusercontent.com. [34.145.178.123]) by smtp.gmail.com with ESMTPSA id af79cd13be357-798abc06e93sm521666385a.82.2024.06.18.06.37.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jun 2024 06:37:56 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 18 Jun 2024 13:37:50 +0000 Subject: [PATCH v5 07/10] media: venus: Refactor hfi_session_empty_buffer_compressed_pkt Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240618-cocci-flexarray-v5-7-6a8294942f48@chromium.org> References: <20240618-cocci-flexarray-v5-0-6a8294942f48@chromium.org> In-Reply-To: <20240618-cocci-flexarray-v5-0-6a8294942f48@chromium.org> To: Mauro Carvalho Chehab , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.13.0 The single element array data[1] is never used. Replace it with a padding field of the same size. This fixes the following cocci warning: drivers/media/platform/qcom/venus/hfi_cmds.h:146:5-9: WARNING use flexible-= array member instead (https://www.kernel.org/doc/html/latest/process/deprec= ated.html#zero-length-and-one-element-arrays) Reviewed-by: Bryan O'Donoghue Acked-by: Vikash Garodia Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/hfi_cmds.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.h b/drivers/media/p= latform/qcom/venus/hfi_cmds.h index 8768ee052adc..2c56ae303989 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.h +++ b/drivers/media/platform/qcom/venus/hfi_cmds.h @@ -143,7 +143,7 @@ struct hfi_session_empty_buffer_compressed_pkt { u32 input_tag; u32 packet_buffer; u32 extradata_buffer; - u32 data[1]; + u32 data; }; =20 struct hfi_session_empty_buffer_uncompressed_plane0_pkt { --=20 2.45.2.627.g7a2c4fd464-goog From nobody Thu Feb 12 00:27:51 2026 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03F0F16CD33 for ; Tue, 18 Jun 2024 13:37:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718717880; cv=none; b=sCul+fsnIOPkatM2cjEAOa6iArlgLchVE44Sz8aqrBOweMb1F1Du0uZSiYg/dEeyQnP6LrwQIcpRaO2iw8SWjIb0YmqQQHQF4mPn9MmDN1iGNSi9mRdaVm1vp4FQwYktYIt7t0wbun/UGNMUF3dJWnA/szJ6ayjMy2zqqK5+qMo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718717880; c=relaxed/simple; bh=LrbREgccmp+ApJP/aOqmOoRz76Y1lEsELda3PHy44H0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DvYGotiFuxhASzj8uloiw2grcKizOnvyTIzJffTO5Dy+PmEPtFcO0DuzhF+F4oufP+mTIgm5X7JPkwPNDw2ojGtiND+v+XUvKkNbNZmmNOQVo284cX3IsD+EtPVI5I394iQvh0M80of5WR7cr9MxlBPPVyfYxZQb8V6pJDCaGXk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Vhcezod9; arc=none smtp.client-ip=209.85.222.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Vhcezod9" Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-7955f3d4516so567619985a.1 for ; Tue, 18 Jun 2024 06:37:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1718717878; x=1719322678; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=yg6dOdrePmQkedMibhUOvsYt1qJByOG1v6bUXQRrIc0=; b=Vhcezod9bTjHhu5dqi2/RMzSrpi/ALRIrD13HlMTNDime5k71fOYHpXqTA0EAzSTOF ibk6ZrbAFsxebknblBSyrY8gFdd8P+sBG7eAkQEU1IySvLTS8osLtrxzors5DvQwtf3o 3XUgD72NIfh8x5K1dQ4L+Br3iGldTXf0z4HmI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718717878; x=1719322678; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yg6dOdrePmQkedMibhUOvsYt1qJByOG1v6bUXQRrIc0=; b=lWsxHnDRrrcN2cTdYno4pynqvdlRO8aWCjpOYjQUl1Hc2ifnBO/b7X83ZOjwGoD+p2 XdNXZq5AcMz8Kra3b2AZlEE+W831P+Ea+1K9i+h+bzNaRIyeEu8Ox4f13DOt6Pb4ay5R Seiz2/Dt2tad1akjcKg2abSC7Qz9QId8TXbu1Obd6y9RGrBaj3lAX9iDByMp/FO5VMZ4 hHGB/zVZwxN4pKFuQYa0d4qaRQKGQufJjluw4OO79cZjUxEDG+rEO2m4vaglLxqOfhRI NL501g9jLKsRG7o7FOB/sFCTzyfqysBtO+smtASUhOyyrLxl6yCGwuoaDkMvCA2tPu7u kbYA== X-Forwarded-Encrypted: i=1; AJvYcCWpx9geCFPB8I6kr2AIgYs6LQFhiiqmXwa/oDSU4UXrqja6dJEocCo3SiBptVNsyV5ONT75YpugBpR6Pm0HP5nO8PfqtsxIUGrTzdPo X-Gm-Message-State: AOJu0Yz6STVfLG3Oaznq9ltSt+si8eV0ZT75HOhsZvZNviEqdpxyk8dA E49zMgbMuv6ospGw9gORut8A6QnA6+aP4YCnmORLkeTYGt8R8s0No96bfXpMvA== X-Google-Smtp-Source: AGHT+IGAgj3YnsFss9qEjXgsxLbOwfO0PDliSTE4TcCbevE5n9KjJc7F+p+/GujvK9mbnLR+t5wqXQ== X-Received: by 2002:a05:620a:4308:b0:798:5598:bdff with SMTP id af79cd13be357-79ba75e14e3mr450019785a.0.1718717878028; Tue, 18 Jun 2024 06:37:58 -0700 (PDT) Received: from denia.c.googlers.com (123.178.145.34.bc.googleusercontent.com. [34.145.178.123]) by smtp.gmail.com with ESMTPSA id af79cd13be357-798abc06e93sm521666385a.82.2024.06.18.06.37.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jun 2024 06:37:57 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 18 Jun 2024 13:37:51 +0000 Subject: [PATCH v5 08/10] media: venus: Refactor hfi_sys_get_property_pkt Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240618-cocci-flexarray-v5-8-6a8294942f48@chromium.org> References: <20240618-cocci-flexarray-v5-0-6a8294942f48@chromium.org> In-Reply-To: <20240618-cocci-flexarray-v5-0-6a8294942f48@chromium.org> To: Mauro Carvalho Chehab , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.13.0 Replace a single length element array with an element. This fixes the following cocci warning: drivers/media/platform/qcom/venus/hfi_cmds.h:77:5-9: WARNING use flexible-a= rray member instead (https://www.kernel.org/doc/html/latest/process/depreca= ted.html#zero-length-and-one-element-arrays) Acked-by: Vikash Garodia Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/hfi_cmds.c | 2 +- drivers/media/platform/qcom/venus/hfi_cmds.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.c b/drivers/media/p= latform/qcom/venus/hfi_cmds.c index 75f4a3d3e748..0a4de8ca1df5 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.c +++ b/drivers/media/platform/qcom/venus/hfi_cmds.c @@ -156,7 +156,7 @@ void pkt_sys_image_version(struct hfi_sys_get_property_= pkt *pkt) pkt->hdr.size =3D sizeof(*pkt); pkt->hdr.pkt_type =3D HFI_CMD_SYS_GET_PROPERTY; pkt->num_properties =3D 1; - pkt->data[0] =3D HFI_PROPERTY_SYS_IMAGE_VERSION; + pkt->data =3D HFI_PROPERTY_SYS_IMAGE_VERSION; } =20 int pkt_session_init(struct hfi_session_init_pkt *pkt, void *cookie, diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.h b/drivers/media/p= latform/qcom/venus/hfi_cmds.h index 2c56ae303989..f91bc9087643 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.h +++ b/drivers/media/platform/qcom/venus/hfi_cmds.h @@ -74,7 +74,7 @@ struct hfi_sys_set_property_pkt { struct hfi_sys_get_property_pkt { struct hfi_pkt_hdr hdr; u32 num_properties; - u32 data[1]; + u32 data; }; =20 struct hfi_sys_ping_pkt { --=20 2.45.2.627.g7a2c4fd464-goog From nobody Thu Feb 12 00:27:51 2026 Received: from mail-oa1-f53.google.com (mail-oa1-f53.google.com [209.85.160.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D006B16A937 for ; Tue, 18 Jun 2024 13:37:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718717881; cv=none; b=rmUuhNkJ/stptnsQCr7Ch8Ru54FgfgboReqkVcX/tCPVyYKlogcz4ChHkpeRQN0yjtEQS5cbljbogZfzozi9gnEjAWEE17rqbhCKt2AL3I9f5f1s/KwkIxaVEo/suSDPD5usbvA++vg8wksjH60m2U4AoLoHQbPfXaEBO6porIc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718717881; c=relaxed/simple; bh=DZjQ6FV3T2FW/P5dZ/rmnh+9n/L8e1/dcKMQojAHidA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SPftZlRa/rB0rvOjh4iJGvhHVOyBBdWuG+X5vZUMGuSkDUirlJ4cSz1sL2aqDmqLJ2QgI4KcAXXkdy3I4U5X/FFufVMCO+zc7CFgSAOAbdqmBlRN0amC8JgRF7q5AkPgQPEf0pz+Hn5NGuE25vK4SlYP+2Iye6A5rIB7n36lQRw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=h/q7QLM6; arc=none smtp.client-ip=209.85.160.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="h/q7QLM6" Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-250671a1bc7so2597350fac.3 for ; Tue, 18 Jun 2024 06:37:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1718717879; x=1719322679; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=A2IFt2EVdi+gZJF4jowtvIlbB+KtHxr9PizWbsBiOL8=; b=h/q7QLM6kNjjkD99jkS7jDZvS4Ma4njXAHHAZcMhibE7R4o4NN/sCtPdmK51Lk7snj YlOalbEqWwDmgiwNUnPbBuP/m4fW7QNTRocFM7XWxEMNvYUPvc8U8Hm1uboUpxuBebR5 pyL5NN6H3hpIm/vX6VhE4NaWq7fd3SWlsRqCU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718717879; x=1719322679; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A2IFt2EVdi+gZJF4jowtvIlbB+KtHxr9PizWbsBiOL8=; b=D/RT0ipsXdoFqI0RN2N4iHufvsfFb2j7RxeXurbFo2saEIAgdvLbCspIh8WqGc0p6C hxd7u684UVzdY76DEySBlSedKeCiKK02o3XiwMb4uAMdtSrIenZr4lzh8beeb108nx66 87/0mJP3QwslFeu9dMmFnMxQ2DOY4UFpzgp+ZK3HP79NgqHrFsWhnxfXaiRlviJn0wHk A9PdfoWTlgM+hcVcMWLl8ucuW7baYnnMb+v53yp/Se2NG0xiDwS3QQ19ThNFGH9RP9fF wplvu++FPPFtQkF4ZCErECiNSC5oIiTZFjtfin/Vo7Y6kATkYd+ww63+rO2mKrocdkYl KVSQ== X-Forwarded-Encrypted: i=1; AJvYcCW91EAbpHgQhSGQLjuo+FK/aXSKoz7ZlWNqr4o0xNuXXCD4+b8m4QzzZpPYDbU4g3wOLxJ2vR07rp7O93uhwa/gjrrm1lp92jX06ixs X-Gm-Message-State: AOJu0YxTVYzR0vhDNATqHzNmClLthMztkucomwiEb4DTcgO6NbSDvFcX rVJum+WH8bLHlFcA/Op1F6WeBzXf3jQiYFjQFf5w+KhI3b7OGnv8ykNm8NSenw== X-Google-Smtp-Source: AGHT+IFGZzzKWBOJ8T4ois2QX+pNAsJoUQREamSXoXS7bchmzONZY4R+JRX9+M2w5xew57/NtISAyA== X-Received: by 2002:a05:6870:7b4c:b0:259:8b4e:e71a with SMTP id 586e51a60fabf-2598b4f0ac6mr606072fac.46.1718717878982; Tue, 18 Jun 2024 06:37:58 -0700 (PDT) Received: from denia.c.googlers.com (123.178.145.34.bc.googleusercontent.com. [34.145.178.123]) by smtp.gmail.com with ESMTPSA id af79cd13be357-798abc06e93sm521666385a.82.2024.06.18.06.37.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jun 2024 06:37:58 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 18 Jun 2024 13:37:52 +0000 Subject: [PATCH v5 09/10] media: venus: Refactor hfi_session_fill_buffer_pkt Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240618-cocci-flexarray-v5-9-6a8294942f48@chromium.org> References: <20240618-cocci-flexarray-v5-0-6a8294942f48@chromium.org> In-Reply-To: <20240618-cocci-flexarray-v5-0-6a8294942f48@chromium.org> To: Mauro Carvalho Chehab , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.13.0 The single data array data[1] is only used to save the extradata_size. Replace it with a single element field. This fixes the following cocci warning: drivers/media/platform/qcom/venus/hfi_cmds.h:175:5-9: WARNING use flexible-= array member instead (https://www.kernel.org/doc/html/latest/process/deprec= ated.html#zero-length-and-one-element-arrays) Reviewed-by: Bryan O'Donoghue Acked-by: Vikash Garodia Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/hfi_cmds.c | 2 +- drivers/media/platform/qcom/venus/hfi_cmds.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.c b/drivers/media/p= latform/qcom/venus/hfi_cmds.c index 0a4de8ca1df5..3ae063094e3e 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.c +++ b/drivers/media/platform/qcom/venus/hfi_cmds.c @@ -331,7 +331,7 @@ int pkt_session_ftb(struct hfi_session_fill_buffer_pkt = *pkt, void *cookie, pkt->alloc_len =3D out_frame->alloc_len; pkt->filled_len =3D out_frame->filled_len; pkt->offset =3D out_frame->offset; - pkt->data[0] =3D out_frame->extradata_size; + pkt->data =3D out_frame->extradata_size; =20 return 0; } diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.h b/drivers/media/p= latform/qcom/venus/hfi_cmds.h index f91bc9087643..daba45720ddc 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.h +++ b/drivers/media/platform/qcom/venus/hfi_cmds.h @@ -172,7 +172,7 @@ struct hfi_session_fill_buffer_pkt { u32 output_tag; u32 packet_buffer; u32 extradata_buffer; - u32 data[1]; + u32 data; }; =20 struct hfi_session_flush_pkt { --=20 2.45.2.627.g7a2c4fd464-goog From nobody Thu Feb 12 00:27:51 2026 Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFF7116EB4E for ; Tue, 18 Jun 2024 13:38:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718717882; cv=none; b=MaUfCG1sQHMPnW4c1jg73RybljqJJgDrpS5DQCS9i2P1nm6X+c9vHb2+ncLhexDV8UMDjytFnpIepiOHOPMBkOD7PgoxwFz0m1oIAj+64+Tbol7T3nR4lilI35LAddqTCLI9I3j+yTINM/XW3Tfr8XQpezsKVUK7R0w0LMzqa4o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718717882; c=relaxed/simple; bh=n7rLzzBBfHOdiSuzszfNn/euo2ePzTmy1Jk7b4uNXQ0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=shk7/ffjzjNfuclSUngJCDKi1n38vdOwotrgCdc8PilFZb/hcbfmYx4xzV7j1Rl6R+XnrHNUTW0knowcscmNIHdJLD+U7xW/ZrujlF1e6LIlSt+4OnteJmfotmPYwlMZOQRRRBorZeT+t7TgRTl3ImMY9Gmg3I32M7+kVpA3jy0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Mq2qWFNO; arc=none smtp.client-ip=209.85.167.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Mq2qWFNO" Received: by mail-oi1-f177.google.com with SMTP id 5614622812f47-3d226aff122so2955410b6e.2 for ; Tue, 18 Jun 2024 06:38:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1718717880; x=1719322680; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=C/eq9KiqE9DhkH+J1pTk62wzUPV+ZFcAncSfE/zn07s=; b=Mq2qWFNOBV+XDeAiig97C0zvDRN7YUgzl+hkOr7jX2lwSGymaMVphRHukfuOOz4hOm 7YClKFW/3PC7hqu+w62Nm2x/19MXN1ZSVwccH1zxJBN1ExGPIDwT59VEPTzPAxInObJP XZ+J/6lbiBavT9y4A7fwHp+q0rnrXF3FbRx8s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718717880; x=1719322680; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=C/eq9KiqE9DhkH+J1pTk62wzUPV+ZFcAncSfE/zn07s=; b=VnuszBQnPSz0pXCYu+rKqxlqO62a7V9Dk+AhFCFqMw0hcurdvbw32U+RqwM42q7YDt Atr/EtlaXO8cKGAWAFgZyHAAaE+G7GP8rMwPbfzunGgZRD2AknLP8CVas1vFn+Q32WP/ afmOlUF9zeNcNmauB16uH68cp5My+LaRoZ59hnhnC3hD9TGmQoPQU4DtvCWYWzyWBtgI haKai7AfXnRGiBGD7B5jyEKA72BB9PezYp21iD1lNt5Qk+GpT5LUh6WGaENSoSrOYGpu sq0JFaZ5g0HnOhOkZqIdJNmZaYcF3jR67nP/22YHK8wP5JC2IXEgR7fWfkMU5oMadOx5 sT+g== X-Forwarded-Encrypted: i=1; AJvYcCVyWPE4AyNJSPW2pCoTicayC+xeW2kT3X3fnNkYiDsE7BzP5U+ZuM6UG75VbtYMHMDuhkTYEXpaDuq0Qx+eHAG9znWMI1eF8c7eN/K2 X-Gm-Message-State: AOJu0YybsYYfdLLlu+prZlLmbAkGFi1+TcR3VILe7QVMEUp0mmpKCiiP d7pojC/C37a4hrsFpCPE53copvADPI5vmPhKiQ0CbDgdhwHHdXapcc5wzVPSdQ== X-Google-Smtp-Source: AGHT+IHK+MUXA9aHTIKx+La/+tL6XuNAxNsBHd2w0eK2r23/Txk8tr8Eu/lANB+LjBHcJGZuZjo8hg== X-Received: by 2002:a05:6808:1520:b0:3d2:2356:d273 with SMTP id 5614622812f47-3d24e8a9973mr15936428b6e.6.1718717880067; Tue, 18 Jun 2024 06:38:00 -0700 (PDT) Received: from denia.c.googlers.com (123.178.145.34.bc.googleusercontent.com. [34.145.178.123]) by smtp.gmail.com with ESMTPSA id af79cd13be357-798abc06e93sm521666385a.82.2024.06.18.06.37.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jun 2024 06:37:59 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 18 Jun 2024 13:37:53 +0000 Subject: [PATCH v5 10/10] media: venus: Refactor hfi_buffer_alloc_mode_supported Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240618-cocci-flexarray-v5-10-6a8294942f48@chromium.org> References: <20240618-cocci-flexarray-v5-0-6a8294942f48@chromium.org> In-Reply-To: <20240618-cocci-flexarray-v5-0-6a8294942f48@chromium.org> To: Mauro Carvalho Chehab , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.13.0 Replace the old style single element array at the end of the struct with a flex array. The code does not allocate this structure, so the size change should not be a problem. This fixes the following cocci warning: drivers/media/platform/qcom/venus/hfi_helper.h:1233:5-9: WARNING use flexib= le-array member instead (https://www.kernel.org/doc/html/latest/process/dep= recated.html#zero-length-and-one-element-arrays) Acked-by: Vikash Garodia Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/hfi_helper.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/venus/hfi_helper.h b/drivers/media= /platform/qcom/venus/hfi_helper.h index 6202dcfc467a..242a3ba94555 100644 --- a/drivers/media/platform/qcom/venus/hfi_helper.h +++ b/drivers/media/platform/qcom/venus/hfi_helper.h @@ -1223,7 +1223,7 @@ struct hfi_interlace_format_supported { struct hfi_buffer_alloc_mode_supported { u32 buffer_type; u32 num_entries; - u32 data[1]; + u32 data[]; }; =20 struct hfi_metadata_pass_through { --=20 2.45.2.627.g7a2c4fd464-goog