From nobody Thu Dec 18 11:22:41 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECDD1157A47 for ; Fri, 14 Jun 2024 15:33:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718379231; cv=none; b=naIztuh0WRs52xdiNdCnB0LYssgWz9Mr0LUiWZBXocu18g0qCuX705IK7oEFCwlzkJt6Z7X+XGYcOQ+OF/mtxpM/21DsdlnEjZrwdmamYvuoFEb0+Vvyoe9JdEAXSWnsPeJC5SbBL/7QI8Zocr3iwR7oACBt2Wp3wwnAr9Z1lAo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718379231; c=relaxed/simple; bh=XPs2SWgcg9zduhMhSD7BO0xKySl3NyBcZQRSGIiEXLg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Dtqe8WpClvFTcHw2pQebdkEErSVnHXTWGx1UkoofR2XdGJQKclAXN0kLD+4ec3btRX+r5xkQWdlr9EY6rI9l/THozGRoA/lCH8y8BTTe3nElDvbEPUr0JJL1MzA6NxoOgF1mRhXpwIuIk3WeXg35JIaK3si/1drdsr1waiNmrcc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TFrW7etl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TFrW7etl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0932CC2BD10; Fri, 14 Jun 2024 15:33:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718379230; bh=XPs2SWgcg9zduhMhSD7BO0xKySl3NyBcZQRSGIiEXLg=; h=From:To:Cc:Subject:Date:From; b=TFrW7etlj0iwXNYY0ftpeIkaSGEDDdSHHhLlHu9RY9Dcy1BKNE6BN709gSW23z6jN 4NYG+TrSA2WzJ768BqsUzeW7070uUkmVza1P4C9v4b0UwxDXgq6W8KyRqp4L3NBlDW XWAkmKLsAEYUrTrcfhiNUBSDwmSkucIAsA3zhs2NssPBxqplshjQNiPnkLAHkiFx/O 7+zW7HUXtP7wdwVyyIoaMXPmUtdy0kgq+CBTyK6dSvJNIBWdnHlkCviB2MvPuEVWHJ C5xJvPfOYAxtUwDQF6ri3dn3Gk0OhHRI2pXJZmsSAvTC/oKFLhrinAnOFuCqS0PELI FFZpS5vYjcNVA== From: Jisheng Zhang To: Anup Patel , Thomas Gleixner , Paul Walmsley , Palmer Dabbelt , Albert Ou Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] irqchip/riscv-intc: Remove asmlinkage Date: Fri, 14 Jun 2024 23:19:55 +0800 Message-ID: <20240614151955.1949-1-jszhang@kernel.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The two functions riscv_intc_aia_irq() and riscv_intc_irq() are only called by C functions. Signed-off-by: Jisheng Zhang Reviewed-by: Anup Patel --- Hi riscv maintainers and all, Related question: I believe the asmlinkage in riscv is a nop, is it OK to remove asmlinkage from all riscv code? Anyway, no matter what will be the decision, it's correct to remove asmlinkage in riscv intc driver as this patch does. thanks drivers/irqchip/irq-riscv-intc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/irq-riscv-intc.c b/drivers/irqchip/irq-riscv-i= ntc.c index 4f3a12383a1e..47f3200476da 100644 --- a/drivers/irqchip/irq-riscv-intc.c +++ b/drivers/irqchip/irq-riscv-intc.c @@ -26,7 +26,7 @@ static unsigned int riscv_intc_nr_irqs __ro_after_init = =3D BITS_PER_LONG; static unsigned int riscv_intc_custom_base __ro_after_init =3D BITS_PER_LO= NG; static unsigned int riscv_intc_custom_nr_irqs __ro_after_init; =20 -static asmlinkage void riscv_intc_irq(struct pt_regs *regs) +static void riscv_intc_irq(struct pt_regs *regs) { unsigned long cause =3D regs->cause & ~CAUSE_IRQ_FLAG; =20 @@ -34,7 +34,7 @@ static asmlinkage void riscv_intc_irq(struct pt_regs *reg= s) pr_warn_ratelimited("Failed to handle interrupt (cause: %ld)\n", cause); } =20 -static asmlinkage void riscv_intc_aia_irq(struct pt_regs *regs) +static void riscv_intc_aia_irq(struct pt_regs *regs) { unsigned long topi; =20 --=20 2.43.0