From nobody Thu Dec 18 11:22:48 2025 Received: from out-176.mta0.migadu.com (out-176.mta0.migadu.com [91.218.175.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6CA8C129 for ; Fri, 14 Jun 2024 14:32:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718375571; cv=none; b=B8BcPu4KmbqzlzgrqUEcrb3I6hn1osFoimT+8K/QUbSLoXEUhdRYd0Pei8xqdr1dEFQsBqENGpj0Rd8Sa4H1ZoUQes6R5r6sYI8EovuB5xrgZHO3D923VulWJUfXQpmh1lwFxLMbBK99dFr1/IAwL/YOdFRy8yD+DVfagFfprfI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718375571; c=relaxed/simple; bh=JGJBAZFgEDVwsfbp8Nm4QSiGVzE0S38UYkGCzfduj4o=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=N+eP1PyCCkRWexswrdtOCBHdxuts8rLfMWkHPwir6H5wkzqzWK/yoj9yB6GGFj9gJehfCVLS/DGmZIqSIJlH+X9g4N9JkxatYHqpfMy9sCaQoqwI7vCFl4lAIedQ+pdrIrz85U7G4lnsROy58sF9oDI/2TxoGEGCFxIh3PXMbFs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=Vog70K8s; arc=none smtp.client-ip=91.218.175.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Vog70K8s" X-Envelope-To: akpm@linux-foundation.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1718375567; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=oKGgulHI+TDI8kNJgxolYwa/zBW01wITWhncfioM0zI=; b=Vog70K8se6pQCOes6SgIF2PL/qN2bK1cf5TB6JsDLVUeDtIz0ZYJD7dEo85/J7yLYLznaJ HTGZZGW3DEcq7zn/muU05dwd7FZkMQtMJ3uq92PJUaAEKp5UVCENwCYuhM0KVF838BPeId 7uO4pMlYht90PiYbs2F2VlyRkJ5YusE= X-Envelope-To: andreyknvl@gmail.com X-Envelope-To: elver@google.com X-Envelope-To: glider@google.com X-Envelope-To: dvyukov@google.com X-Envelope-To: ryabinin.a.a@gmail.com X-Envelope-To: kasan-dev@googlegroups.com X-Envelope-To: linux-mm@kvack.org X-Envelope-To: spender@grsecurity.net X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: stable@vger.kernel.org X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: andrey.konovalov@linux.dev To: Andrew Morton Cc: Andrey Konovalov , Marco Elver , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, linux-mm@kvack.org, Brad Spengler , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v2] kasan: fix bad call to unpoison_slab_object Date: Fri, 14 Jun 2024 16:32:38 +0200 Message-Id: <20240614143238.60323-1-andrey.konovalov@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: Andrey Konovalov Commit 29d7355a9d05 ("kasan: save alloc stack traces for mempool") messed up one of the calls to unpoison_slab_object: the last two arguments are supposed to be GFP flags and whether to init the object memory. Fix the call. Without this fix, __kasan_mempool_unpoison_object provides the object's size as GFP flags to unpoison_slab_object, which can cause LOCKDEP reports (and probably other issues). Fixes: 29d7355a9d05 ("kasan: save alloc stack traces for mempool") Reported-by: Brad Spengler Cc: stable@vger.kernel.org Acked-by: Marco Elver Signed-off-by: Andrey Konovalov --- Changes v1->v2: - Fix typo in commit message. - CC stable. --- mm/kasan/common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/kasan/common.c b/mm/kasan/common.c index e7c9a4dc89f8..85e7c6b4575c 100644 --- a/mm/kasan/common.c +++ b/mm/kasan/common.c @@ -532,7 +532,7 @@ void __kasan_mempool_unpoison_object(void *ptr, size_t = size, unsigned long ip) return; =20 /* Unpoison the object and save alloc info for non-kmalloc() allocations.= */ - unpoison_slab_object(slab->slab_cache, ptr, size, flags); + unpoison_slab_object(slab->slab_cache, ptr, flags, false); =20 /* Poison the redzone and save alloc info for kmalloc() allocations. */ if (is_kmalloc_cache(slab->slab_cache)) --=20 2.25.1