From nobody Thu Dec 18 23:48:31 2025 Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [80.241.56.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09A431957E4; Fri, 14 Jun 2024 10:50:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=80.241.56.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718362241; cv=none; b=jbapkq8+tMNiU4qPCodHwBhpIZjWLKefvYdT6i3/pyiM5EhxHg4KuHwrT8hMH6srmBH3D+YLmNTQbsGaF4PbCx/TifP/sACXRdm/ad9ipAXGlZhtKi6AYaVmWIvit99rkX+S9txQvzZNzJ965kwvpyC1NLQltB7tD+xS/pT2NJs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718362241; c=relaxed/simple; bh=6pfJoYioiO6yA1+m6X4mMuZKZchxbko/MzEz7P3kvic=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XHpS3rgDAHIuUues/ABXDt31FiSJoXRV1Hb4g4hEXLIWMAyN6KEVGam76zuwhIGjJCWHU1QlgkTSA+6yyAm7YLi3GXB+KR4/+wfBN8/u8215ajbqxM6y1bliatJ1Zyy3gDD+M/AyVopmpbCnKHr0hUX+1/S/YeQHFHaNMLw85AA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=pankajraghav.com; spf=pass smtp.mailfrom=pankajraghav.com; dkim=pass (2048-bit key) header.d=pankajraghav.com header.i=@pankajraghav.com header.b=fcuZWeS0; arc=none smtp.client-ip=80.241.56.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=pankajraghav.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pankajraghav.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pankajraghav.com header.i=@pankajraghav.com header.b="fcuZWeS0" Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4W0wzb2c3Hz9tWv; Fri, 14 Jun 2024 12:50:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1718362235; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h9XKge9NpIpH1b33RjGZCWwlvvg3NKJI45iOzjHUY7w=; b=fcuZWeS03H+xn4nyFh2EdSFXGZj3IwNSTmI/lrAcWiXWtYElNMSFGl5YiyVNDgpWoC8aVL UfPUK46C5Pdp6EsuE4NbWTnFaNggiHtVS3lkCPZaI/6aHFXziTi/0bffdjBdYayyccAS0s haMMgf5jO1eO3W/MkwyUb9i3rorWhktujASBpoehLFZvWAAIlDBgyJ8lLhMDo/IZCiIEZx 19EniWiQtk4i/f2RBh+1HR5s2kb94qrOrdWWQKGHuu7Klcl0rUgEuHmj6BkXrNfhw0TgrX Nk9lhKQXKHxrUldkR6ZxhhCAfDrp7fDCu4l49F7fGXYTxy/IaX31qqOh5/YxYA== From: "Pankaj Raghav (Samsung)" To: Brian Foster , Kent Overstreet Cc: linux-bcachefs@vger.kernel.org, willy@infradead.org, linux-kernel@vger.kernel.org, Pankaj Raghav Subject: [PATCH 1/2] bcachefs: use FGP_WRITEBEGIN instead of combining individual flags Date: Fri, 14 Jun 2024 10:50:30 +0000 Message-ID: <20240614105031.57032-2-kernel@pankajraghav.com> In-Reply-To: <20240614105031.57032-1-kernel@pankajraghav.com> References: <20240614105031.57032-1-kernel@pankajraghav.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Pankaj Raghav Use FGP_WRITEBEGIN to avoid repeating the individual FGP flags before starting a buffered write. Signed-off-by: Pankaj Raghav --- fs/bcachefs/fs-io-buffered.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/fs/bcachefs/fs-io-buffered.c b/fs/bcachefs/fs-io-buffered.c index 54873ecc635c..865691dd0173 100644 --- a/fs/bcachefs/fs-io-buffered.c +++ b/fs/bcachefs/fs-io-buffered.c @@ -677,9 +677,8 @@ int bch2_write_begin(struct file *file, struct address_= space *mapping, =20 bch2_pagecache_add_get(inode); =20 - folio =3D __filemap_get_folio(mapping, pos >> PAGE_SHIFT, - FGP_LOCK|FGP_WRITE|FGP_CREAT|FGP_STABLE, - mapping_gfp_mask(mapping)); + folio =3D __filemap_get_folio(mapping, pos >> PAGE_SHIFT, FGP_WRITEBEGIN, + mapping_gfp_mask(mapping)); if (IS_ERR_OR_NULL(folio)) goto err_unlock; =20 @@ -820,9 +819,8 @@ static int __bch2_buffered_write(struct bch_inode_info = *inode, darray_init(&fs); =20 ret =3D bch2_filemap_get_contig_folios_d(mapping, pos, end, - FGP_LOCK|FGP_WRITE|FGP_STABLE|FGP_CREAT, - mapping_gfp_mask(mapping), - &fs); + FGP_WRITEBEGIN, + mapping_gfp_mask(mapping), &fs); if (ret) goto out; =20 --=20 2.44.1 From nobody Thu Dec 18 23:48:31 2025 Received: from mout-p-102.mailbox.org (mout-p-102.mailbox.org [80.241.56.152]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1111E1957F3; Fri, 14 Jun 2024 10:50:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=80.241.56.152 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718362243; cv=none; b=SE8L2w473O0bHwc38sb/V8AtwBd7gnr6HrOlCvrfgQuU+874cJz6D68VYCQVZ7FocQKCEOUmcg2j9PdzZk/F1I+sdTK18/6T2WgdbWimtlfdmP1QmEHsIBr6IY903fZanYJAHN/VgWyhmZqaijJZ06vL8m5fSArPHlL/zXORnbs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718362243; c=relaxed/simple; bh=RvT456eSgnYsXlxc1lkKdAdRmMkX5mVmeOV8t6IuOwg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nx5EhteC7GkVtb6Wpyfwm+s4JLygd4J2QISg/Jdj2lu3WDWDmmFLU3ap8RGnm6Dx1xB86KEBQKzDzRcqFPioqEx/J+AcNyQZkrgjZY3zptOJygCUlIxhnjtxJUP56tih4O1LGGfKv8LFZ37RBKLbFgh002kghEv3jM5H2u2pMTA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=pankajraghav.com; spf=pass smtp.mailfrom=pankajraghav.com; dkim=pass (2048-bit key) header.d=pankajraghav.com header.i=@pankajraghav.com header.b=Q5m1RtaN; arc=none smtp.client-ip=80.241.56.152 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=pankajraghav.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pankajraghav.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pankajraghav.com header.i=@pankajraghav.com header.b="Q5m1RtaN" Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4W0wzd0hGQz9smv; Fri, 14 Jun 2024 12:50:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1718362237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CrPG7rd88hoRsGFAKAqpUnCfo3BYaLv2EBMdGcByx7Q=; b=Q5m1RtaNRYG6C6VXOYfenCnmOjYk5x1yb12ZuGbpAeAZ8Rhui+dg9+0Yr1Vgm+SgpdoAU1 bc+WRZkN4/iEGSA7QPwIoxLd4VZuqwJiiowXy9l6/ue7d+jTdNa7Pu9ESNln4UVw6wASp+ QieShjvS2zhUL11VEDk+FDIJy43SM4HONoQAhG/UXyToM4NhC1lXhL7RTkA3YOxkdxBDmH nIBZPcF0X17uqCaDPbVZb1wSl86Y2iuzK1pLPlNg7i7xo9dF7La2kNC0IUStSBbKYuUxRf 5huoS3H8vkVSdAPASp+LNvVs/CE7oUGtLV8/+0sn0LCo6icl3g2UtAdBnmG83Q== From: "Pankaj Raghav (Samsung)" To: Brian Foster , Kent Overstreet Cc: linux-bcachefs@vger.kernel.org, willy@infradead.org, linux-kernel@vger.kernel.org, Pankaj Raghav Subject: [PATCH 2/2] bcachefs: set fgf order hint before starting a buffered write Date: Fri, 14 Jun 2024 10:50:31 +0000 Message-ID: <20240614105031.57032-3-kernel@pankajraghav.com> In-Reply-To: <20240614105031.57032-1-kernel@pankajraghav.com> References: <20240614105031.57032-1-kernel@pankajraghav.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4W0wzd0hGQz9smv Content-Type: text/plain; charset="utf-8" From: Pankaj Raghav Set the preferred folio order in the fgp_flags by calling fgf_set_order(). Page cache will try to allocate large folio of the preferred order whenever possible instead of allocating multiple 0 order folios. This improves the buffered write performance up to 1.25x with default mount options and up to 1.57x when mounted with no_data_io option with the following fio workload: fio --name=3Dbcachefs --filename=3D/mnt/test --size=3D100G \ --ioengine=3Dio_uring --iodepth=3D16 --rw=3Dwrite --bs=3D128k Signed-off-by: Pankaj Raghav --- fs/bcachefs/fs-io-buffered.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/bcachefs/fs-io-buffered.c b/fs/bcachefs/fs-io-buffered.c index 865691dd0173..1355d618f988 100644 --- a/fs/bcachefs/fs-io-buffered.c +++ b/fs/bcachefs/fs-io-buffered.c @@ -677,7 +677,8 @@ int bch2_write_begin(struct file *file, struct address_= space *mapping, =20 bch2_pagecache_add_get(inode); =20 - folio =3D __filemap_get_folio(mapping, pos >> PAGE_SHIFT, FGP_WRITEBEGIN, + folio =3D __filemap_get_folio(mapping, pos >> PAGE_SHIFT, + FGP_WRITEBEGIN | fgf_set_order(len), mapping_gfp_mask(mapping)); if (IS_ERR_OR_NULL(folio)) goto err_unlock; @@ -819,7 +820,7 @@ static int __bch2_buffered_write(struct bch_inode_info = *inode, darray_init(&fs); =20 ret =3D bch2_filemap_get_contig_folios_d(mapping, pos, end, - FGP_WRITEBEGIN, + FGP_WRITEBEGIN | fgf_set_order(len), mapping_gfp_mask(mapping), &fs); if (ret) goto out; --=20 2.44.1