From nobody Thu Dec 18 21:47:54 2025 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 313E9193099; Fri, 14 Jun 2024 10:25:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718360735; cv=none; b=N63JsGWie5jZskGT2biExPC6JRGethtXyzfMp5NXv1PJAKIZRCxD14Sv3A5S0I+tcWl2KxXl4uc+9ke2GJpa4EBqP6hZJhBgYI7ROv5k5CXAdAzgTvrnso6FKXFjbUCV+YkC8YxQSBy7jLmx5Ht7mpjRLtfs+ut+CkruTfqdgiE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718360735; c=relaxed/simple; bh=VLl+k8iPEfBLhDWavd/hiHQ0FAOPDQexcJcYpnWu1EE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=jWG1OSIr6QXPdwogb7G2OOjzOS0BwE73rfquN7cgBLUixwUr78UsD5mK+T9Yvn76wmTH0qefkfmkNRK5xVO2sAbcyDn0MZ2rCl1P6yZD/GiUNUdpSBIwTslQOhUQYzk6IbsWV0L0aRNrVQjWEDbXJEQ5jMO5FbnoYMrl5X8gQ8U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=UsIXv0Z6; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=WhLb5qfU; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="UsIXv0Z6"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="WhLb5qfU" From: Shivamurthy Shastri DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1718360731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=45Mk+eRZeAjDsGWJIILWPOVpMZA5ab0caJ72F4pCllI=; b=UsIXv0Z6MJhNdCIIR62Q9wUICwGSKLR+bvCg1aasbECMJS2nmQyoXXNsJgntYc3Z+DSCem LERb6hchywRisGb4H5rfWNMSwWTTx7GY98zp5lDI+wLG4C8GfGTv1OoHvZ59uSXkP7emsz eQXQmpGZXykbDFgtt1T3vK5mNF4FnLm4OAdKqzvCBrl0uJMlyf4rK52TZTI4eNr+yd7bzD E8y8qpGqUa+UefFchEw1aOWzmOFKaR28Nwk92nJsIhkOOTon9iPI/e+9Ul0udKucXyfgyS NAfV5Q9LjrocSiCiwxkX8xSu3K/vgESl9krOWtlPTN5CDPxfYsG3LFFrsQk/IQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1718360731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=45Mk+eRZeAjDsGWJIILWPOVpMZA5ab0caJ72F4pCllI=; b=WhLb5qfUaB5Cqy57KEKjJmHZzfc0lNR9KUKG2EWhca5+277G7ndVEBRDpf2LGA5eeQQU97 G6WTOxCEfDvplmCQ== To: linux-kernel@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, maz@kernel.org, tglx@linutronix.de, anna-maria@linutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, bhelgaas@google.com, rdunlap@infradead.org, vidyas@nvidia.com, ilpo.jarvinen@linux.intel.com, apatel@ventanamicro.com, kevin.tian@intel.com, nipun.gupta@amd.com, den@valinux.co.jp, andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, gregkh@linuxfoundation.org, rafael@kernel.org, alex.williamson@redhat.com, will@kernel.org, lorenzo.pieralisi@arm.com, jgg@mellanox.com, ammarfaizi2@gnuweeb.org, robin.murphy@arm.com, lpieralisi@kernel.org, nm@ti.com, kristo@kernel.org, vkoul@kernel.org, okaya@kernel.org, agross@kernel.org, andersson@kernel.org, mark.rutland@arm.com, shameerali.kolothum.thodi@huawei.com, yuzenghui@huawei.com, shivamurthy.shastri@linutronix.de Subject: [PATCH v3 12/24] irqchip/mbigen: Remove platform_msi_create_device_domain() fallback Date: Fri, 14 Jun 2024 12:23:51 +0200 Message-Id: <20240614102403.13610-13-shivamurthy.shastri@linutronix.de> In-Reply-To: <20240614102403.13610-1-shivamurthy.shastri@linutronix.de> References: <20240614102403.13610-1-shivamurthy.shastri@linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Thomas Gleixner Now that ITS provides the MSI parent domain, remove the unused fallback code. Signed-off-by: Thomas Gleixner Signed-off-by: Anna-Maria Behnsen Signed-off-by: Shivamurthy Shastri --- drivers/irqchip/irq-mbigen.c | 74 ++---------------------------------- 1 file changed, 4 insertions(+), 70 deletions(-) diff --git a/drivers/irqchip/irq-mbigen.c b/drivers/irqchip/irq-mbigen.c index db0fa80330d9..093fd42893a7 100644 --- a/drivers/irqchip/irq-mbigen.c +++ b/drivers/irqchip/irq-mbigen.c @@ -180,64 +180,6 @@ static int mbigen_domain_translate(struct irq_domain *= d, struct irq_fwspec *fwsp return -EINVAL; } =20 -/* The following section will go away once ITS provides a MSI parent */ - -static struct irq_chip mbigen_irq_chip =3D { - .name =3D "mbigen-v2", - .irq_mask =3D irq_chip_mask_parent, - .irq_unmask =3D irq_chip_unmask_parent, - .irq_eoi =3D mbigen_eoi_irq, - .irq_set_type =3D mbigen_set_type, - .irq_set_affinity =3D irq_chip_set_affinity_parent, -}; - -static int mbigen_irq_domain_alloc(struct irq_domain *domain, - unsigned int virq, - unsigned int nr_irqs, - void *args) -{ - struct irq_fwspec *fwspec =3D args; - irq_hw_number_t hwirq; - unsigned int type; - struct mbigen_device *mgn_chip; - int i, err; - - err =3D mbigen_domain_translate(domain, fwspec, &hwirq, &type); - if (err) - return err; - - err =3D platform_msi_device_domain_alloc(domain, virq, nr_irqs); - if (err) - return err; - - mgn_chip =3D platform_msi_get_host_data(domain); - - for (i =3D 0; i < nr_irqs; i++) - irq_domain_set_hwirq_and_chip(domain, virq + i, hwirq + i, - &mbigen_irq_chip, mgn_chip->base); - - return 0; -} - -static void mbigen_irq_domain_free(struct irq_domain *domain, unsigned int= virq, - unsigned int nr_irqs) -{ - platform_msi_device_domain_free(domain, virq, nr_irqs); -} - -static const struct irq_domain_ops mbigen_domain_ops =3D { - .translate =3D mbigen_domain_translate, - .alloc =3D mbigen_irq_domain_alloc, - .free =3D mbigen_irq_domain_free, -}; - -static void mbigen_write_msg(struct msi_desc *desc, struct msi_msg *msg) -{ - mbigen_write_msi_msg(irq_get_irq_data(desc->irq), msg); -} - -/* End of to be removed section */ - static void mbigen_domain_set_desc(msi_alloc_info_t *arg, struct msi_desc = *desc) { arg->desc =3D desc; @@ -268,20 +210,12 @@ static const struct msi_domain_template mbigen_msi_te= mplate =3D { static bool mbigen_create_device_domain(struct device *dev, unsigned int s= ize, struct mbigen_device *mgn_chip) { - struct irq_domain *domain =3D dev->msi.domain; - - if (WARN_ON_ONCE(!domain)) + if (WARN_ON_ONCE(!dev->msi.domain)) return false; =20 - if (irq_domain_is_msi_parent(domain)) { - return msi_create_device_irq_domain(dev, MSI_DEFAULT_DOMAIN, - &mbigen_msi_template, size, - NULL, mgn_chip->base); - } - - /* Remove once ITS provides MSI parent */ - return !!platform_msi_create_device_domain(dev, size, mbigen_write_msg, - &mbigen_domain_ops, mgn_chip); + return msi_create_device_irq_domain(dev, MSI_DEFAULT_DOMAIN, + &mbigen_msi_template, size, + NULL, mgn_chip->base); } =20 static int mbigen_of_create_domain(struct platform_device *pdev, --=20 2.34.1