From nobody Thu Dec 18 11:24:30 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32BC8192B90 for ; Fri, 14 Jun 2024 09:43:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718358237; cv=none; b=SfQhLJgBGA5tCCsCASedg/jMh9l7vz2RAdYXuL9WBZ/ac4wQAG/BZ7SHIvF7AIpIubj5IxIW9okKCYYvZL0htowrGmv/uH9JKgqUFMUd/REiQWJqt3sOEKsjLAsouP909VY+7dJ/CCNzjsGIn73JKLHWXZIRLsh8+qDjvn0TnkU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718358237; c=relaxed/simple; bh=kOpVHQ8v8RsfD5nMX+U2u0NgqPZFZdrU4RP0CSCPj1I=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=EDj2kfyd4Qk1lEHrSTJXmNb8WRIUf/t7VYHVlxVjVoWX0aBrFLs5s7/ZRO6KjGytSEyp8XNsn80OCjOVeoIEBv3BVpd6CzwLcV+K5Pv+99X/mbi+QGMPwQHXSOolAB5HbMn9ajaZBpkdkUPBe4wIcpFdzVcQPeZLgyrMQ4chNGw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=OTFhVD5X; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OTFhVD5X" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718358235; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=MfqTN/CbY1HyFIhalUL/iKeJVM9fDG1FDPUMa7yrEEo=; b=OTFhVD5XvMG538y+AcC6eshdzNQstLANFeIQGpwYVw5FOkHMcwhaPSNgJGdv+3rcBTmZa7 uV0+k3qgo3xUTWluSON5m6jRG0KBV+ECZ4aGMzLEu2ZC0hLZKWSjCjXXLOWCQ4cvNfc+0P VzM+SCREyllZ4IcjCd5zZf/q2VfPr38= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-314-ZQfYF44uPSqh_GPFT--fjA-1; Fri, 14 Jun 2024 05:43:51 -0400 X-MC-Unique: ZQfYF44uPSqh_GPFT--fjA-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5FF941956086; Fri, 14 Jun 2024 09:43:49 +0000 (UTC) Received: from swamp.redhat.com (unknown [10.45.224.22]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 07AFC1955E91; Fri, 14 Jun 2024 09:43:44 +0000 (UTC) From: Petr Oros To: netdev@vger.kernel.org Cc: ivecera@redhat.com, przemyslaw.kitszel@intel.com, Petr Oros , Jesse Brandeburg , Tony Nguyen , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Marcin Szycik , Konrad Knitter , Marcin Domagala , intel-wired-lan@lists.osuosl.org (moderated list:INTEL ETHERNET DRIVERS), linux-kernel@vger.kernel.org (open list) Subject: [PATCH net v2] ice: use proper macro for testing bit Date: Fri, 14 Jun 2024 11:43:38 +0200 Message-ID: <20240614094338.467052-1-poros@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Content-Type: text/plain; charset="utf-8" Do not use _test_bit() macro for testing bit. The proper macro for this is one without underline. Fixes: 4da71a77fc3b ("ice: read internal temperature sensor") Signed-off-by: Petr Oros Acked-by: Ivan Vecera Reviewed-by: Alexander Lobakin --- Changes for v2: - added target tree --- drivers/net/ethernet/intel/ice/ice_hwmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ice/ice_hwmon.c b/drivers/net/ether= net/intel/ice/ice_hwmon.c index e4c2c1bff6c086..b7aa6812510a4f 100644 --- a/drivers/net/ethernet/intel/ice/ice_hwmon.c +++ b/drivers/net/ethernet/intel/ice/ice_hwmon.c @@ -96,7 +96,7 @@ static bool ice_is_internal_reading_supported(struct ice_= pf *pf) =20 unsigned long sensors =3D pf->hw.dev_caps.supported_sensors; =20 - return _test_bit(ICE_SENSOR_SUPPORT_E810_INT_TEMP_BIT, &sensors); + return test_bit(ICE_SENSOR_SUPPORT_E810_INT_TEMP_BIT, &sensors); }; =20 void ice_hwmon_init(struct ice_pf *pf) --=20 2.44.2