From nobody Thu Feb 12 09:21:32 2026 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0062D14F106 for ; Thu, 13 Jun 2024 23:32:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718321556; cv=none; b=I1+Kq+jofv0/UmVK8t8T9UYpv4lLpHyI+j3/UyOvgJN81LU5d6VRpOctlpskpoTY1s4n8DgwCSVUcK82woMHmmTEIrjBNZINnDuqlZ1/TQXLB/gP1hym34sD4Il47T/6U4voEKMktVcA+9gvcboGFfW8HIzHu9dhjfolA9pL7PU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718321556; c=relaxed/simple; bh=VDxgFdcnwFPYlYn2nkDfi2MuEKRJ2YBeZsy+PPP1ND8=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=oenwEXQ+rKvQC4ZWHea43D5KiCCAZRwNsylNzXIKYcJwOMRyVgOL1JBFR4QgwgtLVarK1MtiolcliuIb71pn7T+bMkZKGDRQIwqPFDGScQkBz6YIzibnR4T7QuNdDCb9BiS086Y+xSlgnTh85j7YMsLhjSC1JyeV74baxJLDyN8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 951A1FEC; Thu, 13 Jun 2024 16:32:58 -0700 (PDT) Received: from localhost.localdomain (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C4C783F64C; Thu, 13 Jun 2024 16:32:32 -0700 (PDT) From: Andre Przywara To: Lee Jones , Chen-Yu Tsai Cc: Jernej Skrabec , linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, Chris Morgan , Ryan Walklin , Philippe Simons Subject: [PATCH v3] mfd: axp20x: AXP717: Fix missing IRQ status registers range Date: Fri, 14 Jun 2024 00:31:04 +0100 Message-Id: <20240613233104.17529-1-andre.przywara@arm.com> X-Mailer: git-send-email 2.39.4 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" While we list the "IRQ status *and acknowledge*" registers as volatile in the MFD description, they are missing from the writable range array, so acknowledging any interrupts was met with an -EIO error. This error propagates up, leading to the whole AXP717 driver failing to probe, which is fatal to most systems using this PMIC, since most peripherals refer one of the PMIC voltage rails. This wasn't noticed on the initial submission, since the interrupt was completely missing at this point, but the DTs now merged describe the interrupt, creating the problem. Add the five registers that hold those bits to the writable array. This fixes the boot on the Anbernic systems using the AXP717 PMIC. Fixes: b5bfc8ab2484 ("mfd: axp20x: Add support for AXP717 PMIC") Reported-by: Chris Morgan Signed-off-by: Andre Przywara --- Hi, the patch itself is unchanged from v2 sent in April, but the commit message was updated to give rationale for the Fixes: tag. Please take this as a fix into v6.10. Thanks, Andre drivers/mfd/axp20x.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c index f2c0f144c0fc3..dacd3c96c9f57 100644 --- a/drivers/mfd/axp20x.c +++ b/drivers/mfd/axp20x.c @@ -210,6 +210,7 @@ static const struct regmap_access_table axp313a_volatil= e_table =3D { =20 static const struct regmap_range axp717_writeable_ranges[] =3D { regmap_reg_range(AXP717_IRQ0_EN, AXP717_IRQ4_EN), + regmap_reg_range(AXP717_IRQ0_STATE, AXP717_IRQ4_STATE), regmap_reg_range(AXP717_DCDC_OUTPUT_CONTROL, AXP717_CPUSLDO_CONTROL), }; =20 --=20 2.39.4