From nobody Thu Sep 19 23:03:51 2024 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88D33149C62 for ; Thu, 13 Jun 2024 15:06:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.61.82.184 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718291195; cv=none; b=udilmYuBtR+pr5ghNQ9ZaUr5KNIdaUtYfvdaMrVj8iW73wcgiAICdoZrWNuFaJc9t46R3Tj8igOBzS2601WDS2IBLshQqJajNNMKfj/eNEm9IyOmjxHWZIUqVuK84uOPEldYfYapdOi+pn2q9lytE74Hgqo1jIb89iXTYeWiRdE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718291195; c=relaxed/simple; bh=EmO/W1bRIR7nFbwKnLAcdtHikjwoLCMFNoTc8zs7Px8=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=b1is2Jy3Q3zXF8oY5nH7+yrigJLGbU9t3kzX+JKSrJlAcpQGEOG1kJqq6Uhg9vJw5knbPikbt+GyTXt9YbfSij1U7v7nAbu9lKUXkpJ8xvWqNnPkMiVPgpIszuqYW8NfP902mllHNf9mCX/wJfWw2AjqV0kehO3V+1F72aIf8q0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com; spf=pass smtp.mailfrom=mediatek.com; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b=lBR5SeHz; arc=none smtp.client-ip=210.61.82.184 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mediatek.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="lBR5SeHz" X-UUID: 82fff54a299611efa22eafcdcd04c131-20240613 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=uA7Z9OxMyRB+XVGMp9sN4rGExMfX6q4OxVgbMZaA8PA=; b=lBR5SeHzW+ayJWXnDmhz7Y10gYuQ6SHo7rCWY3IczaEq9Xag576ErAyz8QJXYg89CmUp5oNlSKJbbGRQbwTkzedakTNAU+ZjBjVRWb3Ver+DA0TUELCWZhHtm98GiwBXOF6HJcWsTk9I1drxZGAVyGkShyjFGQj8sYDK89JzKmE=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.39,REQID:29e3a514-895f-4cad-a733-d3658ebf310d,IP:0,U RL:0,TC:0,Content:100,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:100 X-CID-META: VersionHash:393d96e,CLOUDID:5ca68a44-4544-4d06-b2b2-d7e12813c598,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:801|102,TC:nil,Content:3,EDM:-3,IP:n il,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LE S:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-UUID: 82fff54a299611efa22eafcdcd04c131-20240613 Received: from mtkmbs10n1.mediatek.inc [(172.21.101.34)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1094695193; Thu, 13 Jun 2024 23:06:29 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by MTKMBS09N2.mediatek.inc (172.21.101.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Thu, 13 Jun 2024 08:06:27 -0700 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Thu, 13 Jun 2024 23:06:27 +0800 From: Jason-JH.Lin To: Jassi Brar , Chun-Kuang Hu , AngeloGioacchino Del Regno CC: Matthias Brugger , "Jason-JH . Lin" , Singo Chang , Nancy Lin , , , , Subject: [PATCH] mailbox: mtk-cmdq: Add unregister mailbox controller in cmdq_remove() Date: Thu, 13 Jun 2024 23:06:26 +0800 Message-ID: <20240613150626.25280-1-jason-jh.lin@mediatek.com> X-Mailer: git-send-email 2.18.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add unregister mailbox controller in cmdq_remove to fix cmdq unbind WARN_ON message from pm_runtime_get_sync() in cmdq_mbox_shutdown(). Fixes: 623a6143a845 ("mailbox: mediatek: Add Mediatek CMDQ driver") Signed-off-by: Jason-JH.Lin --- drivers/mailbox/mtk-cmdq-mailbox.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-= mailbox.c index 4aa394e91109..1399e18a39a4 100644 --- a/drivers/mailbox/mtk-cmdq-mailbox.c +++ b/drivers/mailbox/mtk-cmdq-mailbox.c @@ -371,6 +371,8 @@ static void cmdq_remove(struct platform_device *pdev) { struct cmdq *cmdq =3D platform_get_drvdata(pdev); =20 + devm_mbox_controller_unregister(&pdev->dev, &cmdq->mbox); + if (cmdq->pdata->sw_ddr_en) cmdq_sw_ddr_enable(cmdq, false); =20 --=20 2.18.0