From nobody Thu Feb 12 15:46:21 2026 Received: from mail-40135.protonmail.ch (mail-40135.protonmail.ch [185.70.40.135]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC551210FF for ; Wed, 12 Jun 2024 03:21:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.70.40.135 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162480; cv=none; b=pVMwcQ2+bTfou2Zn0Je8dSvhVR64fOg03Q6BuhmPrV3SmrQU7VkrpyHegPPt2HpdiC3mPSKTT02jI7QYIqLa3wbHfYuZiD6fzf3RIjd/FDxTgUayDzIw8cEVhbQjQWMLkE9Ud6YC8fxOenvPfnczXDxPW+MAl1w6dqKZGJZ1bvE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162480; c=relaxed/simple; bh=4caMDJk1fymacmDutxXRaq4p+OusCKGUepMMnXhyzuE=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=a3p6IZff3j6f3MdYfIB/fXCgRimQfOikpyOQ4TOWq325Mca6OtvQ56MuFp/cocuw+0RuGaLX4iqT/vgwOUdYJmElxSymF2rDa1jwojxsJaEcaBDiighuUDye+mdj21HuWB1x0kNp9HrNDMDDbO/0PxWKCQ6VhggVBl7/k2NspgM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=U1JcTFuB; arc=none smtp.client-ip=185.70.40.135 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="U1JcTFuB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1718162470; x=1718421670; bh=v9+fU/3I0sW3EO1/uEtuQOuAAW/aw8IWkdBocAl5mAU=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=U1JcTFuBUNjJx1tlixm8r0piCpAroBpoKrhEfwDWDo2pa06uw24iozBmrWEqI8weg j2kkSr3299DV3Gq6znNf4PUDER6P6hDby6KdqbOm29tfvsfCs1fqXrwVYHi5WiOVcG +Mm5TvRQbYyl8XXjVKEh8nMi8rPt5m/9CvmFd8QE3RRquXsqODO89ESwYf4O2szwl0 kFGlfwFYU5Feb6Bb0/dR2lBikK7RiSSYajg2O6cnUHPagyRJCjAqrH4xDxhX+IOTed +MkHp0g/uLKGe3cb3/I17fSXGlPY3QujRR8/zbitvmvlKXpTgiSuRvJxszecPm9Id6 AWnpJLqz2OLaw== Date: Wed, 12 Jun 2024 03:21:04 +0000 To: linux-kernel@vger.kernel.org From: Raymond Hackley Cc: Markuss Broks , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stephan Gerhold , Nikita Travkin , linux-input@vger.kernel.org, devicetree@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht Subject: [PATCH 1/3] input/touchscreen: imagis: Clarify the usage of protocol_b Message-ID: <20240612032036.33103-2-raymondhackley@protonmail.com> In-Reply-To: <20240612032036.33103-1-raymondhackley@protonmail.com> References: <20240612032036.33103-1-raymondhackley@protonmail.com> Feedback-ID: 49437091:user:proton X-Pm-Message-ID: 651ef5fd3f41cfde3c3b7171adfecf433ee63de8 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" protocol_b is a property, which tells Imagis panel to use a different format for coordinates. IST30XXC series is known for using protocol B, while the other series aren't. Note this could be confusing, unlike the model name implies. Adjust the usage of protocol_b to avoid confusion. Signed-off-by: Raymond Hackley --- drivers/input/touchscreen/imagis.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/input/touchscreen/imagis.c b/drivers/input/touchscreen= /imagis.c index 074dd6c342ec..886bcfc8497a 100644 --- a/drivers/input/touchscreen/imagis.c +++ b/drivers/input/touchscreen/imagis.c @@ -120,12 +120,12 @@ static irqreturn_t imagis_interrupt(int irq, void *de= v_id) =20 for (i =3D 0; i < finger_count; i++) { if (ts->tdata->protocol_b) - error =3D imagis_i2c_read_reg(ts, - ts->tdata->touch_coord_cmd, &finger_status); - else error =3D imagis_i2c_read_reg(ts, ts->tdata->touch_coord_cmd + (i * 4), &finger_status); + else + error =3D imagis_i2c_read_reg(ts, + ts->tdata->touch_coord_cmd, &finger_status); if (error) { dev_err(&ts->client->dev, "failed to read coordinates for finger %d: %d\n", @@ -394,6 +394,7 @@ static const struct imagis_properties imagis_3032c_data= =3D { .whoami_cmd =3D IST3038C_REG_CHIPID, .whoami_val =3D IST3032C_WHOAMI, .touch_keys_supported =3D true, + .protocol_b =3D true, }; =20 static const struct imagis_properties imagis_3038b_data =3D { @@ -401,7 +402,6 @@ static const struct imagis_properties imagis_3038b_data= =3D { .touch_coord_cmd =3D IST3038B_REG_STATUS, .whoami_cmd =3D IST3038B_REG_CHIPID, .whoami_val =3D IST3038B_WHOAMI, - .protocol_b =3D true, }; =20 static const struct imagis_properties imagis_3038c_data =3D { @@ -409,6 +409,7 @@ static const struct imagis_properties imagis_3038c_data= =3D { .touch_coord_cmd =3D IST3038C_REG_TOUCH_COORD, .whoami_cmd =3D IST3038C_REG_CHIPID, .whoami_val =3D IST3038C_WHOAMI, + .protocol_b =3D true, }; =20 #ifdef CONFIG_OF --=20 2.39.2