From nobody Thu Feb 12 14:10:03 2026 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD0295820E for ; Tue, 11 Jun 2024 17:16:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718126197; cv=none; b=EF8Q/X7y92Ahfex5L4PzCZsnRIWqC98+xELE6Zm/HSve6fXMPX1YML+FXcSStORsu5b+tYfkrxeBkfZqZY5sddfGXl5DfSpF2ES7HY4Bx33VI72WXqnVEXwAFv+xh9cY9+6UJipP3CxthIMtuDrWv4MbTTlS0/Hyt1hSVzRH2gI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718126197; c=relaxed/simple; bh=ItN7sUriAhVplO52bKTv4k3DGMtoiNHzlLUeJevwpTI=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=KAGLxe0IHu9jGWBrwEvm5L/fvBavPQUDA5V351FLoyEAUr2sU61kNbEDrmv5AwP7WDg/HO2dLaqfR3HXlx42GQXEtW4TMRm06bcP5HBEO3REnWhxffq4FuC1tjXF3iB8Hf0KpD1d7y6ldEn10woCqnn9wGcGvSGUTZX1oh61Ark= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aniketmaurya.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=tP5/ARHx; arc=none smtp.client-ip=209.85.128.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aniketmaurya.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="tP5/ARHx" Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-62d032a07a9so23739507b3.2 for ; Tue, 11 Jun 2024 10:16:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1718126195; x=1718730995; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=F/DGU+PznyeuU3c5ytQHTeE+L+VrUtxcZcMVxa+OmY4=; b=tP5/ARHxIaAt3xaPerPVus1vXd0ci7sGFdhoOpF9FVO7U1Gbh70WrwxvM6fIMSKKWF TUS2QWjkk/iTvW4JCVqRQ6IUjdF9GlSfSJNNgw9YuISacDCd7d4DPLt5I8qioNSDm+Gt ZbptIZ8CDUJ5k0tdmlmsdFA90sguo9+wx0t7QJqz1JGr7Fwyi4WJLdqausOT1kpxCKPB DvWydfEDdQHN2kzD6vgCkioKjBhWtZ8XJFecbYbPTDkdPzHNVSjZXh9KPphSSx4VO4dl P+yyZd9vAUrw/jor+pSoSf5ItUMRxvzk7jtT8Eh789rb/Gb6i3XEADm7GgX/VG4RGFh2 v5Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718126195; x=1718730995; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=F/DGU+PznyeuU3c5ytQHTeE+L+VrUtxcZcMVxa+OmY4=; b=kpbFrofE07hJcHDnKMgI/SMe8fwcJOPhwGpmouq5XgKtMywpm2UetTkF/qFe1hRklH iarMjCaeFYfFkCuM0EEstEOK/ykG4AMTCP/AEIAScMrSleutSqoYvs95OccMsZs30bAy qNcX0w9BzQzI7Shzh0h4rDXe3dH+ehiludcNqCQnIL5Tjf5puch7TRPvgW4k7cIOPBvb FY9+TnXwdfJKBss4yy5QGXxYcEhPQXak+q/pJkZwzu9dQ7Il2/NvZM/GFcDFN5V8ybSZ gorgASXmY9tWpR4wV1ktsgiIN7hcfXAM6vKgwNHgt4nGh6uHKARfH/opBMuH7ymuOzzV YELA== X-Forwarded-Encrypted: i=1; AJvYcCUYbivW/RuAP/qeRroYt7INIf8OWqzY/4pXKbz4ifZJUPhX4qXHx4d/sDwJvSXdT8KaaPf+eJBdyS3+DztSBkkUxQKsxr5YTm+vN7Ni X-Gm-Message-State: AOJu0YzrOSG28pxE0GgyspsQDlv2xA/BADpS8BH1jcZNGPmn2TbtjcJN batXcRLqeAl+zvrstUqO5BGDxHy05U/xrA0PovI1TJJjL7OJPHrhv6xDFor2qZ/m+lEkY6HxOPj fuSL5baDA192WA9tkgRP+8UeBQQ== X-Google-Smtp-Source: AGHT+IHBusrZw8MLw8qciIrjtjK+WEfeMpPS8uwfN1BpXvw/8erhWM1AECRWM2Fcvj0GiFs+YyHVKKN4D1UD+9niggI= X-Received: from aniketm.c.googlers.com ([fda3:e722:ac3:cc00:4f:4b78:c0a8:3387]) (user=aniketmaurya job=sendgmr) by 2002:a05:6902:10c1:b0:de5:2694:45ba with SMTP id 3f1490d57ef6-dfaf636bf55mr3809274276.0.1718126194618; Tue, 11 Jun 2024 10:16:34 -0700 (PDT) Date: Tue, 11 Jun 2024 17:15:59 +0000 In-Reply-To: <20240611171600.1105124-1-aniketmaurya@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240611171600.1105124-1-aniketmaurya@google.com> X-Mailer: git-send-email 2.45.2.505.gda0bf45e8d-goog Message-ID: <20240611171600.1105124-2-aniketmaurya@google.com> Subject: [PATCH 1/2] dt-bindings: i3c: dw: Add clock binding From: Aniket To: Alexandre Belloni , Jeremy Kerr , Joel Stanley , Billy Tsai , Rob Herring , Krzysztof Kozlowski Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Aniket Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add dt binding for optional apb clock. Core clock is mandatory. Also add an example. Signed-off-by: Aniket --- .../bindings/i3c/snps,dw-i3c-master.yaml | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml = b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml index c0e805e531be..7e3d4f308477 100644 --- a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml +++ b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml @@ -20,7 +20,16 @@ properties: maxItems: 1 =20 clocks: - maxItems: 1 + minItems: 1 + items: + - description: Core interface clock + - description: APB interface clock + + clock-names: + minItems: 1 + items: + - const: core_clk + - const: pclk =20 interrupts: maxItems: 1 @@ -49,4 +58,12 @@ examples: pagesize =3D <0x8>; }; }; + - | + i3c@10400 { + compatible =3D "snps,dw-i3c-master-1.00a"; + reg =3D <0x10400 0x1000>; + interrupts =3D <8>; + clocks =3D <&i3c0_cclk>,<&i3c0_pclk>; + clock-names =3D "core_clk", "pclk"; + }; ... --=20 2.45.2.505.gda0bf45e8d-goog From nobody Thu Feb 12 14:10:03 2026 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C18543BBFB for ; Tue, 11 Jun 2024 17:16:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718126203; cv=none; b=XsdVAil4/w4wzrX+22pA/oSRTZE/yI+vazOoOD+YUlChx40hvolKNbKMdsey6MyocOL+A86gTC5SWsJ4DsWv9DVSVCmTgkRHulfca1L0sGdeiU6uE9VHkwSUAHYRhoMlhU2RHhqzCSyGO/oIr6YpDFWUVR+cPD/gYCJxFGEOeYs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718126203; c=relaxed/simple; bh=1oz7gki1JBAUNilIN2nJWm3wkdsH+gB30VbNTMLX0iA=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=MXaV2tb/kolKGvNEBqFK8m3TSEvrEmEBDpdZgw3bQVlLo6d72n69uAciTUeImv8r55CxuGKjCw77ZJf+EMxWJaQziSIb1zBvN6lXSM9IRtdXiDwaO1gBYpKeYFhk/EnZ4tjGyXzHAndz+jJ/2YytfKp5gEWf/JPDx39woXioK48= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aniketmaurya.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=slrw+cMz; arc=none smtp.client-ip=209.85.128.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aniketmaurya.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="slrw+cMz" Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-62a083e617aso26463277b3.2 for ; Tue, 11 Jun 2024 10:16:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1718126201; x=1718731001; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=x32GJJg0AlSw6J5DmY/hNwb8LZyaDbs+mRkSRyx7dxM=; b=slrw+cMzaam7oFGE7q2ka4lbuntMgEAvdSFZfRJsV/ZBd3igUTgvSXiLsx8B3XRNt8 M2YV9qnXBQwC/pU5huWwFWnm9bt4v4svGq7b1WsbGLtrBXK8adPxfL+Te0y2Uk+RR4Md T5PyPyMoNX4HcBiGuD0ZRZxoYLoO2naUbWcBDMUgAr6abFLFpMyyLcoSjIos6+6id+mh i3l4KBeHjlDE+9rmIEArrSix6curI5jTVn3lwKsHR8MsSpazBH8nVvMjZRwoXu+vka1z o4tj87FOEpThB8+UX/3ePI2SL0YuexGTyoQdoNI/cIUAA3UJsmL6IVjs+vkz+3UXJ4dE 4ewA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718126201; x=1718731001; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=x32GJJg0AlSw6J5DmY/hNwb8LZyaDbs+mRkSRyx7dxM=; b=aR7O4UH0wIuMDlOLqyVDu+3xHQyKmP21Jgdu0jg/doBW8CaQujEROCldhvcQQxlcC+ jVADsYAZKXLzFakUMiPXs4WicwML5Vo4DaD2exzLwb0NOurjCYo1fenH9J51uNImwiG/ N6t/jDPBee6gTAuuLtsMWTeIOnCQLVGGj7NlEMImFQqyIRfWT5szqeJBdYe48eQiaR9p V2L125PMho/T9mgutnOkU0aH6F1mHksXsN/Dmp9nkeOaRc9s70fTdtDEQ2qI678JjjIe hcrR4r+tBNzIRePvyhxomwHzZrkSLFrhssZRwH6fSQdZpFMqJlFy/W4ygVow3nhKs7J5 WvAA== X-Forwarded-Encrypted: i=1; AJvYcCX3KJ/NGSd7GTTsDGOXE60LMrbxGiEvoFoa6+xNMBu+gpoygisARYn2tT+CJ/ZjCUJmvfPdt6zaRLi4e4NILYI9JviuRJqHoBKxlJFI X-Gm-Message-State: AOJu0Yy7m1Kzv0QbQMeWCd5TpfbXOFD6+b0+Zvv1fVnxpyedHDJmf0zn ari0mhX29UYYUYXtYWpb3RhwxpewgNkJMLMsWK2XIm3SqKIlfBNqIlOH3/OZgONGmLVanMAzL0/ 5AIh1s2XTv8RAd5Uaa2tFfkVJpQ== X-Google-Smtp-Source: AGHT+IFZGNAg9puiuuskmC+xjdohP7kvB0J4VVKVnjwy0UefCG8+X6DP4ehy6KYfVSkTF9cqPe0yp7vlXGzijUCB35k= X-Received: from aniketm.c.googlers.com ([fda3:e722:ac3:cc00:4f:4b78:c0a8:3387]) (user=aniketmaurya job=sendgmr) by 2002:a05:690c:dcf:b0:61b:791a:9850 with SMTP id 00721157ae682-62cd568d31cmr39052507b3.9.1718126200989; Tue, 11 Jun 2024 10:16:40 -0700 (PDT) Date: Tue, 11 Jun 2024 17:16:00 +0000 In-Reply-To: <20240611171600.1105124-1-aniketmaurya@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240611171600.1105124-1-aniketmaurya@google.com> X-Mailer: git-send-email 2.45.2.505.gda0bf45e8d-goog Message-ID: <20240611171600.1105124-3-aniketmaurya@google.com> Subject: [PATCH 2/2] i3c: dw: Add optional apb clock From: Aniket To: Alexandre Belloni , Jeremy Kerr , Joel Stanley , Billy Tsai , Rob Herring , Krzysztof Kozlowski Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Aniket Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Besides the core clock, IP also has an apb interface clock. Add an optional hook for the same and appropriately enable and disable. Signed-off-by: Aniket --- drivers/i3c/master/dw-i3c-master.c | 12 ++++++++++++ drivers/i3c/master/dw-i3c-master.h | 1 + 2 files changed, 13 insertions(+) diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c= -master.c index 77a2a1c3fd1d..41cdfd6741e3 100644 --- a/drivers/i3c/master/dw-i3c-master.c +++ b/drivers/i3c/master/dw-i3c-master.c @@ -1470,12 +1470,20 @@ int dw_i3c_common_probe(struct dw_i3c_master *maste= r, if (IS_ERR(master->core_clk)) return PTR_ERR(master->core_clk); =20 + master->pclk =3D devm_clk_get_optional(&pdev->dev, "pclk"); + if (IS_ERR(master->pclk)) + return PTR_ERR(master->pclk); + master->core_rst =3D devm_reset_control_get_optional_exclusive(&pdev->dev, "core_rst"); if (IS_ERR(master->core_rst)) return PTR_ERR(master->core_rst); =20 ret =3D clk_prepare_enable(master->core_clk); + if (ret) + return ret; + + ret =3D clk_prepare_enable(master->pclk); if (ret) goto err_disable_core_clk; =20 @@ -1520,6 +1528,8 @@ int dw_i3c_common_probe(struct dw_i3c_master *master, err_assert_rst: reset_control_assert(master->core_rst); =20 + clk_disable_unprepare(master->pclk); + err_disable_core_clk: clk_disable_unprepare(master->core_clk); =20 @@ -1533,6 +1543,8 @@ void dw_i3c_common_remove(struct dw_i3c_master *maste= r) =20 reset_control_assert(master->core_rst); =20 + clk_disable_unprepare(master->pclk); + clk_disable_unprepare(master->core_clk); } EXPORT_SYMBOL_GPL(dw_i3c_common_remove); diff --git a/drivers/i3c/master/dw-i3c-master.h b/drivers/i3c/master/dw-i3c= -master.h index 8cb617b8147e..50c38e790c0e 100644 --- a/drivers/i3c/master/dw-i3c-master.h +++ b/drivers/i3c/master/dw-i3c-master.h @@ -36,6 +36,7 @@ struct dw_i3c_master { void __iomem *regs; struct reset_control *core_rst; struct clk *core_clk; + struct clk *pclk; char version[5]; char type[5]; bool ibi_capable; --=20 2.45.2.505.gda0bf45e8d-goog