From nobody Tue Dec 16 22:20:23 2025 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E60C0152526 for ; Mon, 10 Jun 2024 22:25:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718058349; cv=none; b=LaXLQgpzftTy7VyxiH+aJ+O7dWCGBRngneFiJByUD9EArsaWm8KpnUVrW6MsII0/k0n53YY1AJDjWWsP7TpS7jeGcFv2+Y/sIGOSbzI4EtZNoGjwlNNd09q4cdNSquHCRXxux/hV+OdpAKAxLXTodSy3Wa7p+0u2wrRSz67xZLM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718058349; c=relaxed/simple; bh=Ovh+os1hrOCrDiD2AXmjdnbk4SgeS/pEWCXqKaF+Bbk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XqRLCagiA6RYQlSPVIPRCJlUrIgGCQCgnP0DV0v71LRE3gt/Ovjmoga5UkfvVbMirALTNugaTuINkxxLgeozMl/CDzbkjAszPCCyHTMsHV2FvqEcziyMXUyDJ6C1z/atzXv/buZDnwRQYQzOZEMYlWWiT1QLTtKHOjAOBtdGx0Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=L9ESeeFT; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="L9ESeeFT" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-6ff6fe215c6so4342304b3a.3 for ; Mon, 10 Jun 2024 15:25:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1718058347; x=1718663147; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/e81yWihMIIF3LSLYKYQMUC2dNN8trSfh+gNIU5e4Os=; b=L9ESeeFT1Us9TlkOMaFUC8MmywCIeNXIk1aK5wMiifmQFIjd2Fd2afhH6mr3oXZwFE rNN4B8fe+sEM5+5/kmas/cUrrySDYAlL04acZ3NK1sYFuQTKqsJ33Q3YXzKqXEkPYE8P NHb79fXLOfbqWhwnoRqBhTKf+bW00rhO98GkI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718058347; x=1718663147; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/e81yWihMIIF3LSLYKYQMUC2dNN8trSfh+gNIU5e4Os=; b=OMWM1Da/5KYbt4aaD1sP6bqcOTFsNSP3g4rvsooySYcLF4R8/j1hsq44/IZ5LYFqTO dmHyV4WqxmMpp1LMVh9I8OW9nvXW/0/tg31Rqik0Bejg0HRG6Az5zn9JhoD4upilsOhX /Xoyq8UxVB5WbPEFNkjK+QKEWEUF1epDeppRdFaHIOSWJ7pBO1aWpEPtH5/T54YacCYr 5ZL31KghKREweZG7LnSxCNCvSICksjtKO/FitUXtQsuGjAn7W1dNgiIz8ju8a1WHKbyn FZ/FhUdCQf7QYcj9Cy2+NDZm2cAgvjCUlW19XQD3BjObE+f+xDA3V4uTG+n4Fn7zQwv9 lFPQ== X-Forwarded-Encrypted: i=1; AJvYcCU94P/BsVhnn8vXiRlEzTFlFASGsMCkmSXGpP7BsP28DxGR4686RICuBFU+IQCMJwEumNrtIvcWRX0XAXN7GiGk/S4vg01RGbCicwdp X-Gm-Message-State: AOJu0YyWhNSXMSFf3DKP3MqhRbtLjOMwHzUPS7LPab2APLJv4nA7Wdzd tliMYlRqfSqYa+RtB6hZi6ITMwLT3fSXW17brRETh9xw4jq4ZOEbyqELJ7Mo03E1MZi12txUV0w = X-Google-Smtp-Source: AGHT+IH+lrAj2yY4EXnKLpxmaVMU9JPChZlgs48h9rtZLjlN5ZBgV25rBpmsjMuO7Bod3cm1rgi/yg== X-Received: by 2002:a05:6a21:998d:b0:1b6:dffa:d6ec with SMTP id adf61e73a8af0-1b6dffad7a4mr5342931637.46.1718058347194; Mon, 10 Jun 2024 15:25:47 -0700 (PDT) Received: from dianders.sjc.corp.google.com ([2620:15c:9d:2:bba2:69f4:1b51:d0f5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f71029e223sm29212325ad.170.2024.06.10.15.25.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jun 2024 15:25:46 -0700 (PDT) From: Douglas Anderson To: Greg Kroah-Hartman , Jiri Slaby Cc: Yicong Yang , Tony Lindgren , Andy Shevchenko , Johan Hovold , John Ogness , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Konrad Dybcio , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Stephen Boyd , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Douglas Anderson , Vijaya Krishna Nivarthi Subject: [PATCH v4 4/8] serial: qcom-geni: Fix arg types for qcom_geni_serial_poll_bit() Date: Mon, 10 Jun 2024 15:24:22 -0700 Message-ID: <20240610152420.v4.4.I24a0de52dd7336908df180fa6b698e001f3aff82@changeid> X-Mailer: git-send-email 2.45.2.505.gda0bf45e8d-goog In-Reply-To: <20240610222515.3023730-1-dianders@chromium.org> References: <20240610222515.3023730-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The "offset" passed in should be unsigned since it's always a positive offset from our memory mapped IO. The "field" should be u32 since we're anding it with a 32-bit value read from the device. Suggested-by: Stephen Boyd Signed-off-by: Douglas Anderson Reviewed-by: Konrad Dybcio --- (no changes since v2) Changes in v2: - New drivers/tty/serial/qcom_geni_serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qco= m_geni_serial.c index e44edf63db78..db933a1549ad 100644 --- a/drivers/tty/serial/qcom_geni_serial.c +++ b/drivers/tty/serial/qcom_geni_serial.c @@ -265,7 +265,7 @@ static bool qcom_geni_serial_secondary_active(struct ua= rt_port *uport) } =20 static bool qcom_geni_serial_poll_bit(struct uart_port *uport, - int offset, int field, bool set) + unsigned int offset, u32 field, bool set) { u32 reg; unsigned long timeout_us; --=20 2.45.2.505.gda0bf45e8d-goog