From nobody Thu Feb 12 17:27:47 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D0393F9FB for ; Mon, 10 Jun 2024 07:48:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718005703; cv=none; b=Rf71tdTR0jTO1wxtPDeTmfU4mUYhMcNev/1gWTVGlX/uhynq2Xyz5jXd9LdaYzNgLFy+5XkJT3fHM4zoPY+qmqmc5Kbar27ry6dPdaJq35XeBRySX2WG4h13hXPV2UbdFJdGs7dW0+56JpSWxuvQMtsA85dhvKTMSmIY9nhBr2Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718005703; c=relaxed/simple; bh=2qRE8JlGLZ2v3Gb/BpOQHXVYxdux+LqVifqY0jGju70=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=W/8CxYLpLKeIhaVJxRhVuXoz3bMoxcOtjMDVexUHRw50QqL1kZYGhQwfBQectCyExpdPYsWCAEoyEJVMAlGuay2HdL0lEqcXivj3BMoYpxJKYJf2LiSe8BParK75tIlc1f9aMT1TzC3al245QLJyeFRVXM7L+EFiW3cDMa0uCE8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mj89g7jA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mj89g7jA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 397D1C2BBFC; Mon, 10 Jun 2024 07:48:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718005702; bh=2qRE8JlGLZ2v3Gb/BpOQHXVYxdux+LqVifqY0jGju70=; h=From:To:Cc:Subject:Date:From; b=mj89g7jA6W9wPM/LUrs7z1lITBOBj9JdkJyn5HmVzF7a0YuXsYtYjSF3WsiyerHUw R7hkyoVeRAjW9EDb9x22cAXRab275h2U8ZXVgTzu5Mid8+ZOauy6NnHQedcCcMroiW uG+TofcmkVzClfUkFZorMnVk5Apig6fT4ZUxrYCUimC5dhQJYPomMgc3TJvZZDNFpN QV/hQpBDdSS2P4xRlfb6ydgRwi1NYOuFEc2wmhIbCp1EQRV3fggutfYAWA0JONyBpZ WNqg+jpckVETcv9IGdBlIbM73kWAqMG7DVXxuf8bc4pExIkfn53w7hjHTGV7R/TbU+ 7Ee8JLVxzvhQw== From: Michael Walle To: Tudor Ambarus , Pratyush Yadav , Michael Walle , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Linus Walleij Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, e9hack Subject: [PATCH] mtd: spi-nor: winbond: fix w25q128 regression Date: Mon, 10 Jun 2024 09:48:09 +0200 Message-Id: <20240610074809.2180535-1-mwalle@kernel.org> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Commit 83e824a4a595 ("mtd: spi-nor: Correct flags for Winbond w25q128") removed the flags for non-SFDP devices. It was assumed that it wasn't in use anymore. This turned out to be wrong. Add the no_sfdp_flags as well as the size again. Reported-by: e9hack Fixes: 83e824a4a595 ("mtd: spi-nor: Correct flags for Winbond w25q128") Signed-off-by: Michael Walle Reported-by: Hartmut Birr Reviewed-by: Linus Walleij --- Hartmut, Linus, could you please test it on your boards? Also, do you have a real name we should put in the Reported-by tag? This will also need a manual backport to the stable kernels due to the new syntax. But that should be straight forward. --- drivers/mtd/spi-nor/winbond.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c index ca67bf2c46c3..6b6dec6f8faf 100644 --- a/drivers/mtd/spi-nor/winbond.c +++ b/drivers/mtd/spi-nor/winbond.c @@ -105,7 +105,9 @@ static const struct flash_info winbond_nor_parts[] =3D { }, { .id =3D SNOR_ID(0xef, 0x40, 0x18), .name =3D "w25q128", + .size =3D SZ_16M, .flags =3D SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB, + .no_sfdp_flags =3D SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ, }, { .id =3D SNOR_ID(0xef, 0x40, 0x19), .name =3D "w25q256", --=20 2.39.2