From nobody Thu Feb 12 21:45:56 2026 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 010BD15B144 for ; Fri, 7 Jun 2024 08:44:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717749893; cv=none; b=a4rjYvyfCSglX0jD21DTa0zARBrehCFzMb2q43pCuFD3MserA4Wu52j3Mu6BBWF+at9EqKFSN4cPv8wHtd7HF3jwuHzvFZRva61reTW+ymk0XuDi+zUzaqmU4R2Gl3TRBcbIB2yATIltn/RVTiCjsBWhCTsn9LvFcpPDwULjHiU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717749893; c=relaxed/simple; bh=14XoLLXGkugteQS++IsQ79UO0X3PLB2TkFVDwv7Adjs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=j9UBRxV1b0S6cpWXsNAdkmemXmVxsn1AKEPXrGSw9YPSeHZc5ntLWoiOHaIvWQKpqr+IN0wBDD8w9cLXpOmvv26U8PUtYBZt/kgbjOIkxK3Ah7kXjgykdGkzfS/1EtgJ+rbE2GubL1QMqz0oflKKEa69QlJQKfp52ldLMP7aPxQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=LD78OPYK; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="LD78OPYK" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4215f694749so12332945e9.2 for ; Fri, 07 Jun 2024 01:44:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1717749889; x=1718354689; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7q7foaTfDqbpSuC9Ibq8n6gkjkleMa3J/+6fe0Py97k=; b=LD78OPYKBcrjSk/AdEyqNj26XaXjd/AE4gp3en13E4Qytfayr38/chvpIl8+mIM3bK 7wisuMe3L1Y8a237cWK1dqgVGTn6FnsqtPgjAUdv+hhOZJum3GOCF1i1cDDAi4rtWbpo n84flJUrN4+raWiwLTxFUpruc7pwA5IEM0JfHSVbn9badhdSiU7hlsLJhJemhZteyb9G zCAJXIT0+PqoqfjJS8I5T4nu3qYO+T5Rv0I54yS0uUaIF74iD7aufmLUXH9fEa1a09WC 7pFpCY1DX///7mwx9YHOsolLVDuPUm9zqt8wKwtK1l0/pU1wAe+Y0UGjAVWhbygDLG5H fiRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717749889; x=1718354689; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7q7foaTfDqbpSuC9Ibq8n6gkjkleMa3J/+6fe0Py97k=; b=AshGGRu815nGoQIBJu0o7s8pwoRgqB5u7+Ej2cCk0LvnNuAkC1FLtlAjoWTXt0IW3i VrceBzYF2E7YvahVUMRI2VktPJYDabgw5tSgsDgUr1kkMs2BGpp0yjozGLRpiVSsB5MP mcHPVFZkT+JTHHiUo+WdXbcNb35tgwmRmruPbkFYgAxemx0HT47UNVLdQC6vxT2TfQ2g tf8jjgvty+Iu9YXpDt7zRi9P2JVKogzB/C0RHF0OGeVVND1bDqo4QCmsBou6Jl5R+IGc LCPLuez6GNd3hyCb8Kyh3xbfYtN5bN7b55uJ//KsqqI2py0UUPvUhp5SR7WdYclluqxr nFdQ== X-Forwarded-Encrypted: i=1; AJvYcCUNop4f1ClclRaqX2tfHlSdaFD6NvhykeYHfPvpviLfv12X2+l2zVylvEmH2TUA2MUudeigcfncavFk62qjHdjAoEjdCjNwZ7CzndNd X-Gm-Message-State: AOJu0Yz8OqBMWaRwHTGAhqcig2KhlA0XjET+LgB9QEIZFBmYkBFsE5A0 luG4uWMbmz8JM9ZtAqGIFkygorFIZZP8gH/VSlBlClhk6iF3LmCKuhPAA3gJEW4= X-Google-Smtp-Source: AGHT+IEe9+phwxQEu9tnnrIDg4Ni5d7woZbFCLHmXdNQycBCcnpUZYZxG6+gFl3WGlfM7NT25DpIMw== X-Received: by 2002:a05:600c:3aca:b0:41b:f788:8ca6 with SMTP id 5b1f17b1804b1-421649ea031mr16250575e9.8.1717749889331; Fri, 07 Jun 2024 01:44:49 -0700 (PDT) Received: from localhost (p509153eb.dip0.t-ipconnect.de. [80.145.83.235]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42158f30b6fsm74942805e9.10.2024.06.07.01.44.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jun 2024 01:44:48 -0700 (PDT) From: "=?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?=" X-Google-Original-From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Benson Leung Cc: Guenter Roeck , linux-pwm@vger.kernel.org, chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] pwm: cros-ec: Simplify device tree xlation Date: Fri, 7 Jun 2024 10:44:16 +0200 Message-ID: <20240607084416.897777-7-u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240607084416.897777-5-u.kleine-koenig@baylibre.com> References: <20240607084416.897777-5-u.kleine-koenig@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=2725; i=u.kleine-koenig@baylibre.com; h=from:subject; bh=14XoLLXGkugteQS++IsQ79UO0X3PLB2TkFVDwv7Adjs=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBmYshp7ZopTDwjLkhREFWcoeKD2bW+iMngzrmDw 7XS7XCoSPyJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZmLIaQAKCRCPgPtYfRL+ TrqVCACZrlNisihbk7HuvKGftuT5C8DHUxuMDxsWqdZ37JAzsXeI4P21QvllL2Zu1Rs2hkrGhCs QFvS6CnGHJkmyCV9sqjx+6TXtSBR4jurcDqtRxfspMVNdrQK8PRgy0scPY/W8nsDLDamXpOjgeJ DT1x7ZVAl0Mux5twaab9SrRPt3F8lxSg6Reb9twrcRTs53C7nEA7W4rvN6VpRzL/OWttBdcxOfc RS9nHVSagx8nOB8PR0Ex+t9KyKCZ/gJ7EmVFxomvzbFQApkv6gV7C2o1YZ9jW8ih64/r4Xyyo15 q8VeUfZnwM1y4mE8l8mIcT1kGNtafUpXLfXrMq8Ve7HJsUuF X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The cros-ec device tree binding only uses #pwm-cells =3D <1>, and so there is no period provided in the device tree. Up to now this was handled by hardcoding the period to the only supported value in the custom xlate callback. Apart from that, the default xlate callback (i.e. of_pwm_xlate_with_flags()) handles this just fine (and better, e.g. by checking args->args_count >=3D 1 before accessing args->args[0]). To simplify make use of of_pwm_xlate_with_flags(), drop the custom callback and provide the default period in .probe() already. Apart from simplifying the driver this also drops the last non-core user of pwm_request_from_chip() and so makes further simplifications possible. Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by: Tzung-Bi Shih --- drivers/pwm/pwm-cros-ec.c | 32 ++++++++++++-------------------- 1 file changed, 12 insertions(+), 20 deletions(-) diff --git a/drivers/pwm/pwm-cros-ec.c b/drivers/pwm/pwm-cros-ec.c index ba4ee0b507b7..fcc33a2cb878 100644 --- a/drivers/pwm/pwm-cros-ec.c +++ b/drivers/pwm/pwm-cros-ec.c @@ -169,24 +169,6 @@ static int cros_ec_pwm_get_state(struct pwm_chip *chip= , struct pwm_device *pwm, return 0; } =20 -static struct pwm_device * -cros_ec_pwm_xlate(struct pwm_chip *chip, const struct of_phandle_args *arg= s) -{ - struct pwm_device *pwm; - - if (args->args[0] >=3D chip->npwm) - return ERR_PTR(-EINVAL); - - pwm =3D pwm_request_from_chip(chip, args->args[0], NULL); - if (IS_ERR(pwm)) - return pwm; - - /* The EC won't let us change the period */ - pwm->args.period =3D EC_PWM_MAX_DUTY; - - return pwm; -} - static const struct pwm_ops cros_ec_pwm_ops =3D { .get_state =3D cros_ec_pwm_get_state, .apply =3D cros_ec_pwm_apply, @@ -237,7 +219,7 @@ static int cros_ec_pwm_probe(struct platform_device *pd= ev) struct cros_ec_pwm_device *ec_pwm; struct pwm_chip *chip; bool use_pwm_type =3D false; - unsigned int npwm; + unsigned int i, npwm; int ret; =20 if (!ec) @@ -263,7 +245,17 @@ static int cros_ec_pwm_probe(struct platform_device *p= dev) =20 /* PWM chip */ chip->ops =3D &cros_ec_pwm_ops; - chip->of_xlate =3D cros_ec_pwm_xlate; + + /* + * The device tree binding for this device is special as it only uses a + * single cell (for the hwid) and so doesn't provide a default period. + * This isn't a big problem though as the hardware only supports a + * single period length, it's just a bit ugly to make this fit into the + * pwm core abstractions. So initialize the period here, as + * of_pwm_xlate_with_flags() won't do that for us. + */ + for (i =3D 0; i < npwm; ++i) + chip->pwms[i].args.period =3D EC_PWM_MAX_DUTY; =20 dev_dbg(dev, "Probed %u PWMs\n", chip->npwm); =20 --=20 2.43.0