From nobody Thu Feb 12 21:49:24 2026 Received: from mail-oo1-f42.google.com (mail-oo1-f42.google.com [209.85.161.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E1B2195B34 for ; Thu, 6 Jun 2024 13:17:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717679855; cv=none; b=F1XDn82Eoxx19xJNhHyxLFcvyJimwx/QcMwLa1ndcugvDH32lGHx951zk/k3IUdgdDx/uwiJ6yHJ4d8EfSSnM6wbWLHsa6fPG3CELpovd+IOWYsXMVCR5LLBVYOEAhrYfPQGloBcg77M/VRJ3uf5gtxKmjtsltIMUjaLv2zTYHE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717679855; c=relaxed/simple; bh=9Ex/psXstRZqGMxxPJ0VpkCq64t7rGKg+zLLyU8qbQM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=d/ubcXedFIkXevZERYnMYA8q/zBEG7+vk7tmZnyvPFtOlxWdkN2k0CduYDKXY94WcnDQejRi7iua1/xG4uoe2RcpqhYHL3UmznBgWSmPj2/LU4lf26kByMPmAppR9hLtwi1jF6V6+8yKLoEZ3lzSJ+U6gRzZFcXPzT6uMfP0OUw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=NvYMBhPb; arc=none smtp.client-ip=209.85.161.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="NvYMBhPb" Received: by mail-oo1-f42.google.com with SMTP id 006d021491bc7-5ba6c41e1a7so524878eaf.2 for ; Thu, 06 Jun 2024 06:17:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1717679850; x=1718284650; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=AAL4006xAnRJyzvWwdXcDdqMP35ODneV2/4JxIJoTYE=; b=NvYMBhPbL4ddCR1Xdo0TVjY2+0mkBDXcQoJmDaBfuAgBEBD5KBI+0Vy9Ew7LZ3U64g gqGYDYnPcUh6vAl+FOBCQdz9IbPMcv32KFFTjVy5vxB7Y0wv7ovxcZgmcRTNmJFVjL00 7szNGD1s7aojdVbkjcCPwbxa2KzrH/8JTxr2I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717679850; x=1718284650; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AAL4006xAnRJyzvWwdXcDdqMP35ODneV2/4JxIJoTYE=; b=DOcevrhSEmXjDqbwi3jbOxskY+vMhjH0mHd5VU54muxy4s+OI5U8KRVtkWuVPCHvkZ bduPv4X/adugHgwA/iFyq54qc8JhMCW1nr7JdE3ERtE5X3DlG0AQH057AljeXY9j1HtV 3vC20WsAmkkHxuxdrPvl6q2VzYPLf5HXlBAP+OHlIVgDHYR6u0lbgF+/rCDp6mHd3q2n 48ojAwSVgKvo7qGvKFMroWjNCh9vP64xUOdM0mPoTWxfGuucQYGE5QHdjrNu3y1yGaSQ UjVfHYbUzNlPTdThSpst3uQ5bBE1daneJjQ+DSVItNFrNXlX3zN/4BPbQtcGoasyAxSK hBKg== X-Forwarded-Encrypted: i=1; AJvYcCUi9mCqxgDzkm9x8IMLjDM4DWhbBdy8U9Jt2FxAKpaYKT21K2kRGkv5DtfsJCxDV+kWIHLEmn0taxBlM32WnP1SoMuf5DKV0kRGCfLt X-Gm-Message-State: AOJu0YwQ6hnz1jaZ+F89CectVcaHihgdEkYJPu8llhmC3U9JJHG5Sw/o DsQJi8xMGtDnQ5BmHiW6XSCsJpdIqi44qfeelZqJyPKO2tyuIB72oefLV9RfATrADiXD9bWNg+p MOIsJ X-Google-Smtp-Source: AGHT+IFMfHqWudPNwZ7gEE3WDMg2/DCijf/SGmLWSwqmxlW9rIKDz6JeqdjExEkt/BTcjfNpWLogIg== X-Received: by 2002:a05:6358:2609:b0:199:2b63:9f42 with SMTP id e5c5f4694b2df-19c6c68a2femr652957255d.10.1717679850292; Thu, 06 Jun 2024 06:17:30 -0700 (PDT) Received: from denia.c.googlers.com (123.178.145.34.bc.googleusercontent.com. [34.145.178.123]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b04f6607f5sm6118036d6.31.2024.06.06.06.17.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jun 2024 06:17:29 -0700 (PDT) From: Ricardo Ribalda Date: Thu, 06 Jun 2024 13:16:35 +0000 Subject: [PATCH v4 01/11] media: dvb-frontend/mxl5xx: Refactor struct MBIN_FILE_T and MBIN_SEGMENT_T Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240606-cocci-flexarray-v4-1-3379ee5eed28@chromium.org> References: <20240606-cocci-flexarray-v4-0-3379ee5eed28@chromium.org> In-Reply-To: <20240606-cocci-flexarray-v4-0-3379ee5eed28@chromium.org> To: Mauro Carvalho Chehab , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.12.4 Replace the older style one-element array with a flexible array member. There does not seem to be any allocation for these structs in the code, so no more code changes are required. The following cocci warnings are fixed: drivers/media/dvb-frontends/mxl5xx_defs.h:182:4-8: WARNING use flexible-arr= ay member instead (https://www.kernel.org/doc/html/latest/process/deprecate= d.html#zero-length-and-one-element-arrays) drivers/media/dvb-frontends/mxl5xx_defs.h:171:4-8: WARNING use flexible-arr= ay member instead (https://www.kernel.org/doc/html/latest/process/deprecate= d.html#zero-length-and-one-element-arrays) Signed-off-by: Ricardo Ribalda --- drivers/media/dvb-frontends/mxl5xx_defs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/dvb-frontends/mxl5xx_defs.h b/drivers/media/dvb-= frontends/mxl5xx_defs.h index 097271f73740..bf08d82ba2cc 100644 --- a/drivers/media/dvb-frontends/mxl5xx_defs.h +++ b/drivers/media/dvb-frontends/mxl5xx_defs.h @@ -168,7 +168,7 @@ struct MBIN_FILE_HEADER_T { =20 struct MBIN_FILE_T { struct MBIN_FILE_HEADER_T header; - u8 data[1]; + u8 data[]; }; =20 struct MBIN_SEGMENT_HEADER_T { @@ -179,7 +179,7 @@ struct MBIN_SEGMENT_HEADER_T { =20 struct MBIN_SEGMENT_T { struct MBIN_SEGMENT_HEADER_T header; - u8 data[1]; + u8 data[]; }; =20 enum MXL_CMD_TYPE_E { MXL_CMD_WRITE =3D 0, MXL_CMD_READ }; --=20 2.45.2.505.gda0bf45e8d-goog From nobody Thu Feb 12 21:49:24 2026 Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com [209.85.219.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59AC6195B33 for ; Thu, 6 Jun 2024 13:17:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717679854; cv=none; b=J4z5fTH72icv5PPujy6htIS97JzZNCdtilNMIvnoseJkpkKyZLhs7FTdT+FNiVmPFKdZc17uZzi69RF0PZsiWuTLXSb6ya3/AM5v8fVz9zgBBytFggVW47v8ZhHU+jxZLvnSI4ydm11tkdG1cGZGf62sJDkjT4qwb27MsyT4WWg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717679854; c=relaxed/simple; bh=q4cFhQIrNm36IK0wKmtb142H9pZ1e7X8A6hufGU+NQA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=STb/NVB9fC9TTlth5gV8AAXS3uZorWxFF0eBj9CWUNGb77YUTGltZ1aDz3VapmdtL8VBiNaN+hzUnj5/jVG4vhGoM9JKWalt7JNqO1DXDDZ/w97eYOO0iFi/dWCsAnQ43RwRs3scwwsn0WYydV3XtfihEg7o7oPsenRmAzbs1G0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=oFdujwms; arc=none smtp.client-ip=209.85.219.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="oFdujwms" Received: by mail-qv1-f48.google.com with SMTP id 6a1803df08f44-6ae1059a62fso5536136d6.1 for ; Thu, 06 Jun 2024 06:17:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1717679851; x=1718284651; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=VDRaTdfmVls7s4JXTIr052tZZ8CsVVd2h9OYORJYJok=; b=oFdujwmsXFGwYvB6T4Jq5RqxKjkJKijWGA/SBGvV/aBtUgMjL0nFyrsDVUvmyX3IDJ E15h4gACU12nGT8LrNRtbFcixUz8AsJKPX7VMmD+0aOQj23tm0qDp1g7gxSF68/98tBa 5WF9srZy4jkdKcapEU99i9BcRL8mNGtZsvrAM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717679851; x=1718284651; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VDRaTdfmVls7s4JXTIr052tZZ8CsVVd2h9OYORJYJok=; b=rM43ZuVj+mvdYyQa7u/yi7Y+ukc0MpVbCt29rCzCo4WLIvDD9HyTr/YF6ogYGibLzb s4oglOch31WUULc391Y2EtqyEd56ZzmC9R3pjQ9fjwtT2aEZjTsNbrZ0HLR+1QUI1BI3 Pcz4TlayeBJKaWby+m2aR1HWiAKDLteqvQ23/Le78X3HAy7xEggP/Cz+L27wFxDSBFRG 0Bi1VMJIyk91fU/vtedDE2oHWdRHcWOWxq+jwrn6GzUI/rJODKa024yAncN8QcwAODQj ++64rh+JsoW4y8gHfrrgzt2bK8StYgJ+3SzQrKCJegldODdKTe6f0Gx2q0Jhk/0I0bfo lF/g== X-Forwarded-Encrypted: i=1; AJvYcCVAe3JXDxW8qGm9vtK1rmj5ieo3lAS9iRKx1ldsoJu0iNo4++pGGKbuYTmHbDHRtpdyvofAKt3tTpg8U2zErLWZPppw1TpLKUUAom8G X-Gm-Message-State: AOJu0YwtBzBZLc/x2HD+VsRb4N6tJ31JnLueYteJl2Tv+kCOEe8jCnYo aRVQidMLskNv6KRpyCjylT1GYsBbpASNuEwQgSQtlPOWGmtBgiIXKyptR8J9Qw== X-Google-Smtp-Source: AGHT+IElHMEsqGGHpqcblsnwqqLDX7sT+d+kcozCrmBwpsokQJqPWqYJMIGR5jCeUabczgf3kJPYpw== X-Received: by 2002:a05:6214:5505:b0:6b0:3b5:17c9 with SMTP id 6a1803df08f44-6b030a3da36mr80057696d6.39.1717679850970; Thu, 06 Jun 2024 06:17:30 -0700 (PDT) Received: from denia.c.googlers.com (123.178.145.34.bc.googleusercontent.com. [34.145.178.123]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b04f6607f5sm6118036d6.31.2024.06.06.06.17.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jun 2024 06:17:30 -0700 (PDT) From: Ricardo Ribalda Date: Thu, 06 Jun 2024 13:16:36 +0000 Subject: [PATCH v4 02/11] media: venus: Remove unused structs Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240606-cocci-flexarray-v4-2-3379ee5eed28@chromium.org> References: <20240606-cocci-flexarray-v4-0-3379ee5eed28@chromium.org> In-Reply-To: <20240606-cocci-flexarray-v4-0-3379ee5eed28@chromium.org> To: Mauro Carvalho Chehab , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.12.4 This structures are not used, and have a single element array at the end of them. Remove them. This fix the following cocci warnings: drivers/media/platform/qcom/venus/hfi_helper.h:764:5-15: WARNING use flexib= le-array member instead (https://www.kernel.org/doc/html/latest/process/dep= recated.html#zero-length-and-one-element-arrays) drivers/media/platform/qcom/venus/hfi_helper.h:1041:5-15: WARNING use flexi= ble-array member instead (https://www.kernel.org/doc/html/latest/process/de= precated.html#zero-length-and-one-element-arrays) drivers/media/platform/qcom/venus/hfi_helper.h:1088:39-51: WARNING use flex= ible-array member instead (https://www.kernel.org/doc/html/latest/process/d= eprecated.html#zero-length-and-one-element-arrays) drivers/media/platform/qcom/venus/hfi_helper.h:1093:5-22: WARNING use flexi= ble-array member instead (https://www.kernel.org/doc/html/latest/process/de= precated.html#zero-length-and-one-element-arrays) drivers/media/platform/qcom/venus/hfi_helper.h:1144:4-8: WARNING use flexib= le-array member instead (https://www.kernel.org/doc/html/latest/process/dep= recated.html#zero-length-and-one-element-arrays) drivers/media/platform/qcom/venus/hfi_helper.h:1239:4-8: WARNING use flexib= le-array member instead (https://www.kernel.org/doc/html/latest/process/dep= recated.html#zero-length-and-one-element-arrays) drivers/media/platform/qcom/venus/hfi_helper.h:1272:4-13: WARNING use flexi= ble-array member instead (https://www.kernel.org/doc/html/latest/process/de= precated.html#zero-length-and-one-element-arrays) drivers/media/platform/qcom/venus/hfi_cmds.h:85:5-16: WARNING use flexible-= array member instead (https://www.kernel.org/doc/html/latest/process/deprec= ated.html#zero-length-and-one-element-arrays) drivers/media/platform/qcom/venus/hfi_cmds.h:180:5-9: WARNING use flexible-= array member instead (https://www.kernel.org/doc/html/latest/process/deprec= ated.html#zero-length-and-one-element-arrays) drivers/media/platform/qcom/venus/hfi_cmds.h:189:5-9: WARNING use flexible-= array member instead (https://www.kernel.org/doc/html/latest/process/deprec= ated.html#zero-length-and-one-element-arrays) Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/hfi_cmds.h | 26 ----------------- drivers/media/platform/qcom/venus/hfi_helper.h | 39 ----------------------= ---- 2 files changed, 65 deletions(-) diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.h b/drivers/media/p= latform/qcom/venus/hfi_cmds.h index 20acd412ee7b..41f765eac4d9 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.h +++ b/drivers/media/platform/qcom/venus/hfi_cmds.h @@ -77,14 +77,6 @@ struct hfi_sys_get_property_pkt { u32 data[1]; }; =20 -struct hfi_sys_set_buffers_pkt { - struct hfi_pkt_hdr hdr; - u32 buffer_type; - u32 buffer_size; - u32 num_buffers; - u32 buffer_addr[1]; -}; - struct hfi_sys_ping_pkt { struct hfi_pkt_hdr hdr; u32 client_data; @@ -171,24 +163,6 @@ struct hfi_session_empty_buffer_uncompressed_plane0_pk= t { u32 data[1]; }; =20 -struct hfi_session_empty_buffer_uncompressed_plane1_pkt { - u32 flags; - u32 alloc_len; - u32 filled_len; - u32 offset; - u32 packet_buffer2; - u32 data[1]; -}; - -struct hfi_session_empty_buffer_uncompressed_plane2_pkt { - u32 flags; - u32 alloc_len; - u32 filled_len; - u32 offset; - u32 packet_buffer3; - u32 data[1]; -}; - struct hfi_session_fill_buffer_pkt { struct hfi_session_hdr_pkt shdr; u32 stream_id; diff --git a/drivers/media/platform/qcom/venus/hfi_helper.h b/drivers/media= /platform/qcom/venus/hfi_helper.h index e4c05d62cfc7..7c0edef263ae 100644 --- a/drivers/media/platform/qcom/venus/hfi_helper.h +++ b/drivers/media/platform/qcom/venus/hfi_helper.h @@ -759,11 +759,6 @@ struct hfi_multi_stream_3x { u32 enable; }; =20 -struct hfi_multi_view_format { - u32 views; - u32 view_order[1]; -}; - #define HFI_MULTI_SLICE_OFF 0x1 #define HFI_MULTI_SLICE_BY_MB_COUNT 0x2 #define HFI_MULTI_SLICE_BY_BYTE_COUNT 0x3 @@ -1036,11 +1031,6 @@ struct hfi_codec_supported { u32 enc_codecs; }; =20 -struct hfi_properties_supported { - u32 num_properties; - u32 properties[1]; -}; - struct hfi_max_sessions_supported { u32 max_sessions; }; @@ -1083,16 +1073,6 @@ struct hfi_resource_ocmem_requirement { u32 size; }; =20 -struct hfi_resource_ocmem_requirement_info { - u32 num_entries; - struct hfi_resource_ocmem_requirement requirements[1]; -}; - -struct hfi_property_sys_image_version_info_type { - u32 string_size; - u8 str_image_version[1]; -}; - struct hfi_codec_mask_supported { u32 codecs; u32 video_domains; @@ -1135,15 +1115,6 @@ struct hfi_index_extradata_config { u32 index_extra_data_id; }; =20 -struct hfi_extradata_header { - u32 size; - u32 version; - u32 port_index; - u32 type; - u32 data_size; - u8 data[1]; -}; - struct hfi_batch_info { u32 input_batch_count; u32 output_batch_count; @@ -1234,11 +1205,6 @@ static inline void hfi_bufreq_set_count_min_host(str= uct hfi_buffer_requirements req->count_min =3D val; }; =20 -struct hfi_data_payload { - u32 size; - u8 data[1]; -}; - struct hfi_enable_picture { u32 picture_type; }; @@ -1267,11 +1233,6 @@ struct hfi_buffer_alloc_mode_supported { u32 data[1]; }; =20 -struct hfi_mb_error_map { - u32 error_map_size; - u8 error_map[1]; -}; - struct hfi_metadata_pass_through { int enable; u32 size; --=20 2.45.2.505.gda0bf45e8d-goog From nobody Thu Feb 12 21:49:24 2026 Received: from mail-oo1-f50.google.com (mail-oo1-f50.google.com [209.85.161.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 246DC195FD9 for ; Thu, 6 Jun 2024 13:17:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717679855; cv=none; b=d9wIDCYlCgRtMbLbe/0Hf76C5cGmYG0CrCLEGoNIYhnfMgpwTkxcjqd4ilXBwTZ14FI3UDLZ8zlPmoIIrRqeWJbgElCPIOn48fjvdukfraXNWJk/rHaRqQwIa4BZd2+zefCHs3FlCCXQwYhpzIhqvI+pTN+0tB9K9BVwt/CFt6o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717679855; c=relaxed/simple; bh=LKep9+SsMgXIw7N/wwAo5L/YSHeXN3o1qd6elsENQvg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Cvsl39WeOc+YqQenszPPcLhEjLZPA8+Qb3RNKEw+XTvXUO2nk1/1CV1a9q9iKZs5EVm17EAHWC9nPJg/Dy3T7JNIinlNFdDfEC3u/7eBvZCKTOFUUg6kugb3fHR2YB6J9T7qsk9Jq60lNQTYsvCzcP7oJpLdq0Pthml0qnrcfJA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Q8dS9Jfh; arc=none smtp.client-ip=209.85.161.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Q8dS9Jfh" Received: by mail-oo1-f50.google.com with SMTP id 006d021491bc7-5b970e90ab8so506613eaf.3 for ; Thu, 06 Jun 2024 06:17:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1717679852; x=1718284652; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=bZZh27lvax1pQKtebKo1tSyfI2/RfGD2+tRBLkwHpFg=; b=Q8dS9JfhUN0JBhPQ2Pc+v0JQqNI9KiQVlEXPQ4YhjjMFO4vefxSidC2dXIJ2fMT41b 6rUYMQCj/lQSwE5Tmx6gtNRVdD4pkx7Hg5Ex9J8uuMl76DnLrYLyKPulvDvDWrkcFSQ9 WxbuomJvMde3Xv92dEN+InNMT0gFjt8sqnSd0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717679852; x=1718284652; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bZZh27lvax1pQKtebKo1tSyfI2/RfGD2+tRBLkwHpFg=; b=UjAAdulxcqof575dxKpYhEeZz1lqh0eYI2iCBEZQEB8XWmBKyvpsjWJii7aAM6Hff9 nZp42R7VZbk6mBi35zD4wOuG21dAqkCsEuPAd1zPRoD2lyzvk0aVSff1AodBcOSorzkW LGxaW+pjQ4h+Yk+wVnwT0mTDlzF1x+RloOZsiuKuhDvM6hal8M98yMO3u1fuPlxvqk6v tY01Z1XLg9zuXLHW9VFN7wn/m8Q30xWkrXFYBknS3L8zwK7OBGKRKW9v8bWP0Ns/vJbC ryGgShIVAFENNgntTqXTjT1iBX4exGGfNCFK36x1Eh/eLuuRGJkaOUKnvQ3IM72ZF/z6 U1aQ== X-Forwarded-Encrypted: i=1; AJvYcCXb4tiQNszIjaOVbzEf4FmrwEZFIbflVLN99xQonXiwPDZOGwIZTW6G0wAXSATA1Rb31MyLEbMYyn9JVrCVMoXDm74vKNiOT8S4I/r2 X-Gm-Message-State: AOJu0Yw+pkn3JAh/i7flhh+hWqsQZkcTpMiGnAE6YxN/Ehcan38/ZiA6 hkDiOSbA1gvEiBQrE3LySSae6BlrStcJa60LUl0XXuyPzs7Ct9sM0x/SJMQ5mQ== X-Google-Smtp-Source: AGHT+IGNI9HGZGYM1bs7kXBQ+Gzd7oXjy4+AygNfoD1Lq7a40uZ9nWHXC95xkS7mtZToVDJBYIlggA== X-Received: by 2002:a05:6358:9985:b0:19e:e402:4d17 with SMTP id e5c5f4694b2df-19ee4025007mr233623255d.7.1717679852165; Thu, 06 Jun 2024 06:17:32 -0700 (PDT) Received: from denia.c.googlers.com (123.178.145.34.bc.googleusercontent.com. [34.145.178.123]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b04f6607f5sm6118036d6.31.2024.06.06.06.17.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jun 2024 06:17:31 -0700 (PDT) From: Ricardo Ribalda Date: Thu, 06 Jun 2024 13:16:37 +0000 Subject: [PATCH v4 03/11] media: venus: Use flex array for hfi_session_release_buffer_pkt Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240606-cocci-flexarray-v4-3-3379ee5eed28@chromium.org> References: <20240606-cocci-flexarray-v4-0-3379ee5eed28@chromium.org> In-Reply-To: <20240606-cocci-flexarray-v4-0-3379ee5eed28@chromium.org> To: Mauro Carvalho Chehab , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.12.4 Replace the old style single element array with a flex array. We do not allocate this structure, so the size change should not be an issue. This fixes the following cocci warning: drivers/media/platform/qcom/venus/hfi_cmds.h:204:5-16: WARNING use flexible= -array member instead (https://www.kernel.org/doc/html/latest/process/depre= cated.html#zero-length-and-one-element-arrays) Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/hfi_cmds.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.h b/drivers/media/p= latform/qcom/venus/hfi_cmds.h index 41f765eac4d9..6dff949c4402 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.h +++ b/drivers/media/platform/qcom/venus/hfi_cmds.h @@ -201,7 +201,7 @@ struct hfi_session_release_buffer_pkt { u32 extradata_size; u32 response_req; u32 num_buffers; - u32 buffer_info[1]; + u32 buffer_info[]; }; =20 struct hfi_session_release_resources_pkt { --=20 2.45.2.505.gda0bf45e8d-goog From nobody Thu Feb 12 21:49:24 2026 Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE93B196450 for ; Thu, 6 Jun 2024 13:17:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717679856; cv=none; b=drKq+XaSvlcuXBQy072M1lzWopDnln23GI7+aU8dhJ/Yz+049tf4LlK8otTb6wpuYdtS3RrDzbVtAKh1juVvDgFd3MGsuT/KgT4w0HqWntCA3YJuAoO+Ya50I+SuQxeVgk9VdHex2gqLm0lmbzCXdTjhY2p49lD9BU/rE5HeyGQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717679856; c=relaxed/simple; bh=0b1zuE1MbEB0QXjShSrW/hvbjBrNrmRe+hDcjTlyO2c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=duPbTtYdX/jo7iGjubCoiBZRAbFkJ/LEX516f7bsX8OKSJnMO1LgBwghnw6LL10+ONLIlPSbGy3RRtW0dI5nx9FG7VxbAq7iPbL2GC5faAk+R5x1ncwytcRlv0sq/zv1PKkcKRWghRQV1eFgszrazhw1k+RYOKpmftBi+QGza4A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=k0x+fHDm; arc=none smtp.client-ip=209.85.222.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="k0x+fHDm" Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-795310c1698so46812985a.0 for ; Thu, 06 Jun 2024 06:17:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1717679854; x=1718284654; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=6CC1kPEM1QEeXV+54pCQUERgeWC6whHxHJCePKioCow=; b=k0x+fHDmaHogDzg/tqEzGFmB29TaGllQUFT4vOGuoemJaQNuXGtFFcy9MdMXxRXNr1 EZL3UcgEGUCSAP/6oVI2nR5A6VtbyuokqZ36xdLa7lCHb4hKjwPNXQ8FvSqTyiRYkSyD Ok8HuHcsp3My3anUOmD3hmZlSWadiUPPXBA1g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717679854; x=1718284654; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6CC1kPEM1QEeXV+54pCQUERgeWC6whHxHJCePKioCow=; b=xEJO1pMd+RBxXSNQb5QqBdEE/+qDebJcL/d8amIDLdorm+W4NASNbEGXtSH//dVD62 4GFSPgNpOstUxoW2HELYT+dORxXSN9sSUsu0JatpedJifJNHfGtLzTS/a0u2llpwkqxv 0bCKBdGEwZS/VVSJTAGe1svJYcuNAhLego8zK4cmYnH+7bZEkrBVN1BFpwRR/lTyufY/ 3/FLbkVH57o/J3MYVuxA+lH1je8tstaLFEMIgpfBNhQLRsm1LFbOpvCZNWtYlwOTG1Gi I7Vl8a/ukSHTytmXPpI+Iae6UCjwILUArFz/qY43avbde2Tn3sJK6tdzaZFv/m32FEj6 Q5Ag== X-Forwarded-Encrypted: i=1; AJvYcCXApZoqvr8hFua0nox+QwoSvUfZiZYPBU6B2wpXy3I9X8nezMG539Rc3N4CU/nJ5iGhnNwdDgPnh9wGPOwhy3c53JrptdvCYM64L05d X-Gm-Message-State: AOJu0YzT/kakLHWMdx5nG8wBrZ4Y/MrZrsCwTbGADXr9TWc090rQKUSa O3pGnzSUezW7gDWg+QBYaibF2k2uYBpNF9kb8tZfRiC+R73kVA8YrQo67rhXy0vT1goFRt3r2M2 eNgCf X-Google-Smtp-Source: AGHT+IGbbRegP2RzDH+X9svE133yMQUWHCvloWmhh0XtejpJh8/fXunC7mYI78Zn+Xm9usjDEMhazw== X-Received: by 2002:a05:6214:5d81:b0:6af:31cd:f1a3 with SMTP id 6a1803df08f44-6b02bf87f4dmr58276916d6.27.1717679853817; Thu, 06 Jun 2024 06:17:33 -0700 (PDT) Received: from denia.c.googlers.com (123.178.145.34.bc.googleusercontent.com. [34.145.178.123]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b04f6607f5sm6118036d6.31.2024.06.06.06.17.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jun 2024 06:17:32 -0700 (PDT) From: Ricardo Ribalda Date: Thu, 06 Jun 2024 13:16:38 +0000 Subject: [PATCH v4 04/11] media: venus: Refactor struct hfi_uncompressed_plane_info Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240606-cocci-flexarray-v4-4-3379ee5eed28@chromium.org> References: <20240606-cocci-flexarray-v4-0-3379ee5eed28@chromium.org> In-Reply-To: <20240606-cocci-flexarray-v4-0-3379ee5eed28@chromium.org> To: Mauro Carvalho Chehab , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.12.4 This field is never used, but if we remove it we would change the size of the struct and can lead to behavior change. Stay on the safe side by replacing the single element array with a single element field. This fixes the following cocci warning: drivers/media/platform/qcom/venus/hfi_helper.h:1003:43-60: WARNING use flex= ible-array member instead (https://www.kernel.org/doc/html/latest/process/d= eprecated.html#zero-length-and-one-element-arrays) Signed-off-by: Ricardo Ribalda Reviewed-by: Bryan O'Donoghue --- drivers/media/platform/qcom/venus/hfi_helper.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/venus/hfi_helper.h b/drivers/media= /platform/qcom/venus/hfi_helper.h index 7c0edef263ae..eb0a4c64b7ef 100644 --- a/drivers/media/platform/qcom/venus/hfi_helper.h +++ b/drivers/media/platform/qcom/venus/hfi_helper.h @@ -1000,7 +1000,7 @@ struct hfi_uncompressed_plane_constraints { struct hfi_uncompressed_plane_info { u32 format; u32 num_planes; - struct hfi_uncompressed_plane_constraints plane_constraints[1]; + struct hfi_uncompressed_plane_constraints plane_constraints; }; =20 struct hfi_uncompressed_format_supported { --=20 2.45.2.505.gda0bf45e8d-goog From nobody Thu Feb 12 21:49:24 2026 Received: from mail-qv1-f43.google.com (mail-qv1-f43.google.com [209.85.219.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D47E9196C7C for ; Thu, 6 Jun 2024 13:17:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717679857; cv=none; b=AbGm83tfq7JguWePaqgmUEcMVa7/H+k+CwhC7jqZUNhP2BKVr4ar5sFxuVh+fjw9Non8cnZFtIgEw2bLFfApmurj2XQ0HQnqikGU1U1nuWKV1h0KxE370OAPZE+u4L5Q0JX2SqjcHuaiZA7KTLAsxxtB+RB5Ibkni+w4Fn3r+PQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717679857; c=relaxed/simple; bh=q/yIjMSqnXj8v7L7GkQC3K27otk7HPW5heUqxBmLTVc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=isX+32bpoAs/KtLyeMv+GswDxC/Kn3tVhWhKsq3p5Xe4zKQZSE+DsitaNC/kRqCpi3s3WTsSW0ue6jEytsFCjH2FjTgQHCZ+WzHkkQ/MtjA1KxOSvUE6n1qQj02ENKdbl29oyBYOsqOaEroN35FKotAQQ+wlXaksh8b+UyYR/mY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=UkKa/XJl; arc=none smtp.client-ip=209.85.219.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="UkKa/XJl" Received: by mail-qv1-f43.google.com with SMTP id 6a1803df08f44-6afbadc33e8so5163506d6.0 for ; Thu, 06 Jun 2024 06:17:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1717679855; x=1718284655; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=e2AAUOSqY0VuuUiDfECnNkpzmbnAcXOGiikRuWRSAa4=; b=UkKa/XJlLcI5Ssyawo/sbucMPb9oT0FmCygLPm740rx/AcjqYX++l6CaF6nYEkSLZ4 CyxYLm0jWtaboiQXA4KL+w62uvipVV1pstDxFK/us1gRV12IDaLlj8k1OqSp3MWfu8nv Q4WdCbzl9rY85sr8hcO18Mq/E5nB1v0P46+RI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717679855; x=1718284655; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e2AAUOSqY0VuuUiDfECnNkpzmbnAcXOGiikRuWRSAa4=; b=KIo0UrDzEEdD1+N3hjScKghmKiSFE2PaJlNU5PMUZOVdBcEWiRPd9imJNpE2BxWghe NheEENjvjApnhv5OBKegjlj3437E232+S7IGhT1Bk/5r3n1P5cC0auhAPDk546Kw78bk /lSQYixaM/at1oiks8wAjwaQfRPT4M/bpcV3FMnt5vLMG8DKpZwjEsp4wiVIRRbKFWgK gvyhWQWISH9r8PSFm+pSFPGHUGT1zVL6UqGZQPcGHbtZu5MOrlS4NHSTcsCTwBgHlHSo XISC8ZoSsXWCSVq9j91oYIPtULmgejhEkW2C+7J4zX0AfuCfpCPS3btEfLyMDk28aziW HABw== X-Forwarded-Encrypted: i=1; AJvYcCVwIKYrmFNam2+yQASp3mfxjm+BlY2tr9hDSGAN545M/WTltdNtp8Nx41243r1yFzDBn7Xwv5YM4O182+V5emteWZa+BDaY+8cuDO6P X-Gm-Message-State: AOJu0YzYjINEvc3N9TqS7VRIQBRhwXQzdxoJ0w1Rb+ysH2om+QHZG02c Xo/Mg+01gnngL1lwe9vo2lkoH1YFo9fzlLiZ3YhC/VjEC4JToPEY/ipYK6uQwg== X-Google-Smtp-Source: AGHT+IF2SHvoVvYn/P2leNQvN1o8bRfjg6tCknHvek81SGWfjCxGxX7kcfXDgqQa2sakPR4YvGy8vg== X-Received: by 2002:a05:6214:3d8b:b0:6a9:b253:58d5 with SMTP id 6a1803df08f44-6b02bf1eb0amr54587866d6.17.1717679854725; Thu, 06 Jun 2024 06:17:34 -0700 (PDT) Received: from denia.c.googlers.com (123.178.145.34.bc.googleusercontent.com. [34.145.178.123]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b04f6607f5sm6118036d6.31.2024.06.06.06.17.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jun 2024 06:17:34 -0700 (PDT) From: Ricardo Ribalda Date: Thu, 06 Jun 2024 13:16:39 +0000 Subject: [PATCH v4 05/11] media: venus: Refactor struct hfi_session_get_property_pkt Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240606-cocci-flexarray-v4-5-3379ee5eed28@chromium.org> References: <20240606-cocci-flexarray-v4-0-3379ee5eed28@chromium.org> In-Reply-To: <20240606-cocci-flexarray-v4-0-3379ee5eed28@chromium.org> To: Mauro Carvalho Chehab , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.12.4 The struct hfi_session_get_property_pkt is always used to fectch a single property. Make that explicit in the code and avoid a single element array at the end of the struct. This change fixes the following cocci warning: drivers/media/platform/qcom/venus/hfi_cmds.h:194:5-9: WARNING use flexible-= array member instead (https://www.kernel.org/doc/html/latest/process/deprec= ated.html#zero-length-and-one-element-arrays) Reviewed-by: Bryan O'Donoghue Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/hfi_cmds.c | 4 ++-- drivers/media/platform/qcom/venus/hfi_cmds.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.c b/drivers/media/p= latform/qcom/venus/hfi_cmds.c index 3418d2dd9371..75f4a3d3e748 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.c +++ b/drivers/media/platform/qcom/venus/hfi_cmds.c @@ -402,7 +402,7 @@ static int pkt_session_get_property_1x(struct hfi_sessi= on_get_property_pkt *pkt, pkt->shdr.hdr.pkt_type =3D HFI_CMD_SESSION_GET_PROPERTY; pkt->shdr.session_id =3D hash32_ptr(cookie); pkt->num_properties =3D 1; - pkt->data[0] =3D ptype; + pkt->data =3D ptype; =20 return 0; } @@ -1110,7 +1110,7 @@ pkt_session_get_property_3xx(struct hfi_session_get_p= roperty_pkt *pkt, =20 switch (ptype) { case HFI_PROPERTY_CONFIG_VDEC_ENTROPY: - pkt->data[0] =3D HFI_PROPERTY_CONFIG_VDEC_ENTROPY; + pkt->data =3D HFI_PROPERTY_CONFIG_VDEC_ENTROPY; break; default: ret =3D pkt_session_get_property_1x(pkt, cookie, ptype); diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.h b/drivers/media/p= latform/qcom/venus/hfi_cmds.h index 6dff949c4402..f5708fdfb197 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.h +++ b/drivers/media/platform/qcom/venus/hfi_cmds.h @@ -191,7 +191,7 @@ struct hfi_session_resume_pkt { struct hfi_session_get_property_pkt { struct hfi_session_hdr_pkt shdr; u32 num_properties; - u32 data[1]; + u32 data; }; =20 struct hfi_session_release_buffer_pkt { --=20 2.45.2.505.gda0bf45e8d-goog From nobody Thu Feb 12 21:49:24 2026 Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com [209.85.219.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4C4E1974E0 for ; Thu, 6 Jun 2024 13:17:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717679859; cv=none; b=Esu2uuZpD3KDn2BsyfiJJ7iqWWp5ygTvM6gFanTUCYfH3lp5/c7hgK2FwOkJokal8azEu29GgCRDVNE++x3iv5ZzoeeyRXvpgog/FEx7vYrgLnmd4NbdKYI0QY+SQ5gxMDsJfncY1hOwD7tQTMLftDJ0ziWUWM0yrivVgtJ1pxs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717679859; c=relaxed/simple; bh=eSS6CFxpjOrEMCtb9xmg56c0gCLfaI7dITUwdjRcSbo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WZt1fSmaPj5Eu2lZv6MhJyjXSgr6vB7C7EXFd5IXR/nrUSa67mmUtJYWWIMR0CBMsi9OT5OXizeVWSzhHutKEfTIuNkjxQMh/Fthu0LW+K6y+lFsRKIGjoau1jfg660tGBr/6Y97NHnla0eMAsCgNK7aRJ58UDfLb8DImLH3Mcc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Hz5QRfdb; arc=none smtp.client-ip=209.85.219.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Hz5QRfdb" Received: by mail-qv1-f48.google.com with SMTP id 6a1803df08f44-6af55412d69so4126886d6.2 for ; Thu, 06 Jun 2024 06:17:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1717679857; x=1718284657; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=iAc0af9hq9pueFWwvpNqs+gjxvVge6a6O9DHrtQZV0s=; b=Hz5QRfdbzej5QLlbrWvb4i+VPuU2IgPOnLuFxX7frGcuhbkT9mZy3FbM35RiBVoJIv 7zeEOd/K0SSh/F0Vaeb8eQOq77+5ef6L8xe2HOYFsGB7hcgUHaSRVw5T6ru9QvcDGFHz m8FvAIrqdJkP8dyR1Qo6oJuLOWyFLcxWsewKE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717679857; x=1718284657; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iAc0af9hq9pueFWwvpNqs+gjxvVge6a6O9DHrtQZV0s=; b=Hko2lx1q6tAhuWku+dwzPHnm9qmC9jfT6wLQQRF2WHp05m+6VzmBaxtSfCyxrpvijL e+ZOVLvVAY/FHAlF2S/FPzAR4WJ+/KkBLxmtHoHK1rg/1clQnq6JRggnMqXMkoobW/TX iWAY7wEoclxxuApGhYdVaKqjDWSVSmCrFEFmLN+Isl44yhZkqri9xIYd9LsWwx3iGpFj sBL33aacGl0Gy7XJquwT+WXV7+g/aIqNFBDUAGwzQ/KjouEqYd4pW+1pO9cgUjh4uXu8 +cgumFgpjtSGG9Dgu5ZRAj5MUA+V6JFz9eHfuJGUVcJ1nmO4Iu/ge7XbwwNtqZKBVF1t pjzg== X-Forwarded-Encrypted: i=1; AJvYcCVpx2ilOJ7WBnmmt9hPEduUKUi1uKWEyS68Dggxu1oGWpgFb/znppmvYjS3bH7l8SOimyJOJ47iURekE8hiVSntQP03jAIuhs4VU8X/ X-Gm-Message-State: AOJu0YzSf/pxp8Q88YJOBGi96786JYJHvWE0E5X2D5eNgFO/cNALj6rY cp5NLlMbN6xZwFnYO+GWffC3cEHPao+Ens1YC+xeUW23OtUmMNi8cH+vXn7Muw1a00j1+Fy4hxP ACVTW X-Google-Smtp-Source: AGHT+IEJIOJiyMJDDmMHLc74buNW9eEFQjpvgj2J4ah7/DbHCd2DHUJMyDhfPoLk1ARALTqqXFgIww== X-Received: by 2002:a05:6214:451e:b0:6af:5af5:cf63 with SMTP id 6a1803df08f44-6b020320c3emr73595046d6.1.1717679856728; Thu, 06 Jun 2024 06:17:36 -0700 (PDT) Received: from denia.c.googlers.com (123.178.145.34.bc.googleusercontent.com. [34.145.178.123]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b04f6607f5sm6118036d6.31.2024.06.06.06.17.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jun 2024 06:17:35 -0700 (PDT) From: Ricardo Ribalda Date: Thu, 06 Jun 2024 13:16:40 +0000 Subject: [PATCH v4 06/11] media: venus: Refactor struct hfi_uncompressed_format_supported Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240606-cocci-flexarray-v4-6-3379ee5eed28@chromium.org> References: <20240606-cocci-flexarray-v4-0-3379ee5eed28@chromium.org> In-Reply-To: <20240606-cocci-flexarray-v4-0-3379ee5eed28@chromium.org> To: Mauro Carvalho Chehab , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.12.4 plane_info is not a typical array, the data is not contiguous: pinfo =3D (void *)pinfo + sizeof(*constr) * num_planes + 2 * sizeof(u32); Replace the single element array with a single element field. This fixes the following cocci warning: drivers/media/platform/qcom/venus/hfi_helper.h:1009:36-46: WARNING use flex= ible-array member instead (https://www.kernel.org/doc/html/latest/process/d= eprecated.html#zero-length-and-one-element-arrays) Reviewed-by: Bryan O'Donoghue Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/hfi_helper.h | 2 +- drivers/media/platform/qcom/venus/hfi_parser.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/qcom/venus/hfi_helper.h b/drivers/media= /platform/qcom/venus/hfi_helper.h index eb0a4c64b7ef..dee439ea4d2e 100644 --- a/drivers/media/platform/qcom/venus/hfi_helper.h +++ b/drivers/media/platform/qcom/venus/hfi_helper.h @@ -1006,7 +1006,7 @@ struct hfi_uncompressed_plane_info { struct hfi_uncompressed_format_supported { u32 buffer_type; u32 format_entries; - struct hfi_uncompressed_plane_info plane_info[1]; + struct hfi_uncompressed_plane_info plane_info; }; =20 struct hfi_uncompressed_plane_actual { diff --git a/drivers/media/platform/qcom/venus/hfi_parser.c b/drivers/media= /platform/qcom/venus/hfi_parser.c index c43839539d4d..3df241dc3a11 100644 --- a/drivers/media/platform/qcom/venus/hfi_parser.c +++ b/drivers/media/platform/qcom/venus/hfi_parser.c @@ -157,7 +157,7 @@ static void parse_raw_formats(struct venus_core *core, u32 codecs, u32 domain, void *d= ata) { struct hfi_uncompressed_format_supported *fmt =3D data; - struct hfi_uncompressed_plane_info *pinfo =3D fmt->plane_info; + struct hfi_uncompressed_plane_info *pinfo =3D &fmt->plane_info; struct hfi_uncompressed_plane_constraints *constr; struct raw_formats rawfmts[MAX_FMT_ENTRIES] =3D {}; u32 entries =3D fmt->format_entries; --=20 2.45.2.505.gda0bf45e8d-goog From nobody Thu Feb 12 21:49:24 2026 Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A221195F24 for ; Thu, 6 Jun 2024 13:17:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717679860; cv=none; b=IMIwOIZ/EQ32mtQ7vcCvu/4USHzam0VArYWkmJSywesPruOYhogCM+2uKY1GJOW8Gpj7EUk7YUyWhz7S432QYY+NEtNBVwApZqI/545Cfst1yN/HmT6x+7Xdrp14iU9Tq71vld4oJZKFRjzS2KSwwYlcp1FLzBstQgIOP2lwSZQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717679860; c=relaxed/simple; bh=rr+ZAD9eEY9wxQwSyBHAujNTY1n691T+07WEbe4AI+g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=F1gr8oqRaZRcU1lO6iHx7niMIlVqFxtUuEJ+8QHZFwBHDM/5VGdYeeR7KppMqVLuyznIWy5egfM/IDlqHUPlh2MfCJXSn6zhaNsycOasx4n9BMV7ArWprTd7E9RG5j9kghoWxmyvlHodneMS/hho1um6CUE7kOzeKr8WUUjFX4s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=ntd/dDPP; arc=none smtp.client-ip=209.85.219.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ntd/dDPP" Received: by mail-qv1-f46.google.com with SMTP id 6a1803df08f44-6adc63c2ee0so3109406d6.3 for ; Thu, 06 Jun 2024 06:17:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1717679858; x=1718284658; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=rV++zhXkLm63xkLNQev5FMXGRPhSAuf2+6p1s7sOLOM=; b=ntd/dDPPjOuAXrysYvbBo83QdWpNwlilfdrgAUQYRbdE0RAfoenU+qfyECYt2/kU5r 4TStcYC0Gs8kNraSTw6Fie4A8jMmytxs6UO4DHIJDDCdQgKIsqfClLQkP6jtmko+q/OV A73vOxGemKnuZQYGGsJ8PrIZ3h6uygmC/JDOU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717679858; x=1718284658; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rV++zhXkLm63xkLNQev5FMXGRPhSAuf2+6p1s7sOLOM=; b=oJ5zmaC1krGPZ0u3+gIKGaFLfxMrT3f9PitWxwPE0svawB4EV0RNcMpXgtLVvnWjFa ujg5F/gmRtQ0pe+PIHjCbL+SqMRiNaAIZ5ussA78/vcL98ExZNmOna3EeUmf8La7PDRX 6VXmFkWzd5XkIwQpXdSCz6TN/l1opY5s69GrZh6l7/jer/mnVCHZ7C6DMUubEPtoTKP9 6KKCUUQVECcrru7ZxX2d7u6JI4s1ZdD/bSlKbIzA9JtqCQEWpQwkVZyOlyjenXp+6tNn dBkaeSmt7WWN0lqtD/+2+OlPi1zotd2ghzS/GJwCNBzwin7ekxPJnc9kMF+LnoWMUwT5 Vhmw== X-Forwarded-Encrypted: i=1; AJvYcCWtUUxMBrEUtFM9fcVUkgF0WwtC04JcZdek9qz8kfXyu8fXHSCAtgl9pOcrYlZuXBq2vX49+HCW2BpqTPQlcxT2ybnCY30/ABMKFMH8 X-Gm-Message-State: AOJu0Yyj47fzy3v6rKxZGs1qCRvgSt7T56QLTXHLZiF9LBALrly1rt6E TLf491ubZ8rL3N24vkRUu8EAs3+U+YlSag5pm1bQB5oTP211TB+b4XgCUnY53g== X-Google-Smtp-Source: AGHT+IFEbhMVQzLzMehFBZ5O1a5UQYgBDvAL87jiyZxeXK49H/vAmDrzba4DetgTJ+cq2bB+dcgNzQ== X-Received: by 2002:a05:6214:3c8e:b0:6af:b8b3:338e with SMTP id 6a1803df08f44-6b04aeb2647mr34544096d6.53.1717679857474; Thu, 06 Jun 2024 06:17:37 -0700 (PDT) Received: from denia.c.googlers.com (123.178.145.34.bc.googleusercontent.com. [34.145.178.123]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b04f6607f5sm6118036d6.31.2024.06.06.06.17.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jun 2024 06:17:37 -0700 (PDT) From: Ricardo Ribalda Date: Thu, 06 Jun 2024 13:16:41 +0000 Subject: [PATCH v4 07/11] media: venus: Refactor hfi_session_empty_buffer_uncompressed_plane0_pkt Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240606-cocci-flexarray-v4-7-3379ee5eed28@chromium.org> References: <20240606-cocci-flexarray-v4-0-3379ee5eed28@chromium.org> In-Reply-To: <20240606-cocci-flexarray-v4-0-3379ee5eed28@chromium.org> To: Mauro Carvalho Chehab , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.12.4 The single element array data[1] is never used. Replace it whit a padding field of the same size. This fixes the following cocci error: drivers/media/platform/qcom/venus/hfi_cmds.h:163:5-9: WARNING use flexible-= array member instead (https://www.kernel.org/doc/html/latest/process/deprec= ated.html#zero-length-and-one-element-arrays) Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/hfi_cmds.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.h b/drivers/media/p= latform/qcom/venus/hfi_cmds.h index f5708fdfb197..8768ee052adc 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.h +++ b/drivers/media/platform/qcom/venus/hfi_cmds.h @@ -160,7 +160,7 @@ struct hfi_session_empty_buffer_uncompressed_plane0_pkt= { u32 input_tag; u32 packet_buffer; u32 extradata_buffer; - u32 data[1]; + u32 data; }; =20 struct hfi_session_fill_buffer_pkt { --=20 2.45.2.505.gda0bf45e8d-goog From nobody Thu Feb 12 21:49:24 2026 Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19F2C19755F for ; Thu, 6 Jun 2024 13:17:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717679862; cv=none; b=u1DIqay/bWB8ckkcxfImgv5ZUIWMJR3JITAyfw7cqHluh4gtsAtWGNaD6H4CaBZmmJIo84++CZa51QouJcGE1bwfjrikrLlrCLoVCyl2fvNV75orEpT/4tiUNr732Ae0IGPN1aa5DYAQomwUZCg/dOJOVwitz+MBte4pe+da+UM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717679862; c=relaxed/simple; bh=uRrwC8FD53XE8snF88MCg3YmB4JlgvZCoOrRUf+Aarg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GvNGcGNfa/Vy53rhlkjxjdXhmmA2p7nEAE9tDZxtHz8o8GUiq54wwVhaNSzPxMbgb99XR+IlFaY8cJlWiffkxbhGUd8Xi61YQdfqff4+6iKTaBL01Fuoay5qTENt3Xm/mn5AWlVmnrAqiFk8bIagqzfyu69kslkSJdO5tCF0Peg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=DjjfF8dT; arc=none smtp.client-ip=209.85.210.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="DjjfF8dT" Received: by mail-ot1-f53.google.com with SMTP id 46e09a7af769-6f8d0a1e500so584154a34.3 for ; Thu, 06 Jun 2024 06:17:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1717679860; x=1718284660; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=6VGhOi0hNkAMdTQTUdauz7KIyv6SLUrF14jCtpe3Zco=; b=DjjfF8dTX6CwRsYinTcX+b0YEDptOW/hHDl897jSdewsymydisNcuYARPQ9UEVMvjC ix1XdM/e8qrCtSzoO2SHQ8uBWpwyLQUt+oBc0lzeuW9YDrJvjiEs7px100wjZ+XMn7YF lUlVn1HBIpgMoTTJ8Vi1nCz20SIIAEOE9bIZI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717679860; x=1718284660; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6VGhOi0hNkAMdTQTUdauz7KIyv6SLUrF14jCtpe3Zco=; b=L4HsTSywZS3GA2J/Bhx89nhZ4bAh7gXXQv+Qa0cgKigGmTBu0bkrsQjxH//piHXcb0 zIsRL5l5Heq9y8dF3NffOkx98d+pXB6d+VuvI+fhx4aMAMGId3LxdEHpw5BSX+/5Jl4b FaEKqSivUqG7iboEHdNKIPcBaBOXq2rRSlFfptJM9qwwkl5GJW+u6p7Dv2lIn4ALRwpE AfPD35DtuuRV6jTQSN/7fyEbR8LQhrzwlrJUF70cMmJcieIOSXdL+9qphhGJYvRvq/LO ZZWMvX3B6aXM1n9CdKXSdbHG3MJCm4SaqqOGkszKWw2+AmYGfKEAJxH3zHhYsWaFsJnQ 3pEg== X-Forwarded-Encrypted: i=1; AJvYcCUBD2Mr2N4qoSpj5AAbEGY8psbnbq9QEnYZ0LwkOqW+M0zVTCKebDDSi2yDawQE53vWY4q9A6Iq8CQ69mgWMMzCjLtJ4lM7sf7iag23 X-Gm-Message-State: AOJu0Yx7gNLceFPGe4Gf+xU45h3eTQiaLjPThyspaAg7JD6oodZGo6vm 9MqsEQFwhpw1f+bc9U8cF1glLe3hTiLJKXgIUEtb5bRdZGeFxw1gscMTaX6JuQ== X-Google-Smtp-Source: AGHT+IFX9KGFgZD+xuwao+c++qZJRxYqYJVh/LsTI7EaXew+xbdJzstfPx2aof9T7S7zaI4fW+k32A== X-Received: by 2002:a05:6358:2908:b0:19c:45cc:e2c9 with SMTP id e5c5f4694b2df-19c69b89b75mr683604755d.7.1717679860105; Thu, 06 Jun 2024 06:17:40 -0700 (PDT) Received: from denia.c.googlers.com (123.178.145.34.bc.googleusercontent.com. [34.145.178.123]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b04f6607f5sm6118036d6.31.2024.06.06.06.17.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jun 2024 06:17:39 -0700 (PDT) From: Ricardo Ribalda Date: Thu, 06 Jun 2024 13:16:42 +0000 Subject: [PATCH v4 08/11] media: venus: Refactor hfi_session_empty_buffer_compressed_pkt Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240606-cocci-flexarray-v4-8-3379ee5eed28@chromium.org> References: <20240606-cocci-flexarray-v4-0-3379ee5eed28@chromium.org> In-Reply-To: <20240606-cocci-flexarray-v4-0-3379ee5eed28@chromium.org> To: Mauro Carvalho Chehab , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.12.4 The single element array data[1] is never used. Replace it with a padding field of the same size. This fixes the following cocci warning: drivers/media/platform/qcom/venus/hfi_cmds.h:146:5-9: WARNING use flexible-= array member instead (https://www.kernel.org/doc/html/latest/process/deprec= ated.html#zero-length-and-one-element-arrays) Signed-off-by: Ricardo Ribalda Reviewed-by: Bryan O'Donoghue --- drivers/media/platform/qcom/venus/hfi_cmds.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.h b/drivers/media/p= latform/qcom/venus/hfi_cmds.h index 8768ee052adc..2c56ae303989 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.h +++ b/drivers/media/platform/qcom/venus/hfi_cmds.h @@ -143,7 +143,7 @@ struct hfi_session_empty_buffer_compressed_pkt { u32 input_tag; u32 packet_buffer; u32 extradata_buffer; - u32 data[1]; + u32 data; }; =20 struct hfi_session_empty_buffer_uncompressed_plane0_pkt { --=20 2.45.2.505.gda0bf45e8d-goog From nobody Thu Feb 12 21:49:24 2026 Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4112F197A86 for ; Thu, 6 Jun 2024 13:17:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717679863; cv=none; b=R8JKSW/x5qTBg4v3wOzKYKuMvbro05YdFBlAmzcFPQcWw2AUDAgvPvLRWt8Odd+1yHWg+Y3eWOpLLjF1IHfl93/Yfn66FBqygwrQJqoqgzYE2a/2Mps4zLvjJ8whpLyCDy/fnt0hikKkrgyLQx3qo+SUU2ZasBbWPuvfkDGXvnU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717679863; c=relaxed/simple; bh=AWMP5+BquLDtzLKwUlgSS7VtSoQfhl9NrOwjnGNd7WI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=on3MBUX8rlTjwiQAgHkthTreZJ9ff43ekpNW+b8RP0M00AjB8aJIjnuZy1Df9yT1BgeHVv9M6JjHVr8Jz77AItxo478rsRIciZFxBDnlK0N5brsdWcxrD35bdZdeCPUh1v018wwYFRejqAwIxdkc7qONWPJNcdNHd5DtzrCTM1M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=hBvkXsXa; arc=none smtp.client-ip=209.85.160.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="hBvkXsXa" Received: by mail-qt1-f172.google.com with SMTP id d75a77b69052e-43fdb114e07so3977961cf.2 for ; Thu, 06 Jun 2024 06:17:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1717679861; x=1718284661; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Ox++ObHoucj04Nng5whrLexOcEwZLp6Wnb/NRj7bOEs=; b=hBvkXsXaGc8ztZwyZdsJtflSByqW+KORAWXRGhyLbOagYTMp8aHnmY9HcV+JCPLtnM 83YMLcZXDyMC5n9g6dW/ypqZHCeZZOBLwJy9D67FL87T4OS5cNXeEhlqUFqq8FnnwwXL /O9LuvK7Hli26AzPKpFkHi63RAZtj7QSyhByo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717679861; x=1718284661; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ox++ObHoucj04Nng5whrLexOcEwZLp6Wnb/NRj7bOEs=; b=XsQGn5TyIv2Pq9FtffFViHhLbGR5MeoXTPLPMYiX5SOO4WmgWnjTS0Oi4rqlIihf0u AltaXVbLe6dCsWt9Mk0PA9oIN6Agd79ZXEengLYEo5U6eTPdM0tFDea5F7UKMLfO1JUL TMlAKmizAuyUmzT9/ZPWFBKC1HSNhEyZ1Itrsg0O5h3z0TxfmP5uKkP7AV/PGAvfW/uN gLMm/ENTzZIOHBNqUvYERBiuflSCYzcjzKvRXAGRsgdzydhzRYdfv5anjZpiTw+e8Ldn coD0+aOvdfvU6g8JEGMdeokYz1eYZZR56b0Dn6W3WURl4Drccosuhzq2SvUBuf1pErFV YA+w== X-Forwarded-Encrypted: i=1; AJvYcCUrC592wF4FYXb/c/xN+wEbahNwAWLI/4nUvmBdzcDGWFw2kB+IaqWx7ku8PHKm1eQnDkOibxAaKWtK2afBvVfBIRLM8ZSe8SgJjN1n X-Gm-Message-State: AOJu0YwAWwcfOMCSNn/so7Ma/9fdLBigw4dotQ0RaRqr1Dtcj8okCoLr RegTp72rhqAsqjIQjpCze7ML3Sao9ILFR9oGeqop383prnt3zdeg6mnYmCuf2w== X-Google-Smtp-Source: AGHT+IFzv3hWSZczWB+TZSLeuXfXc1Q2NFlWyqPdthC4uOD9GBvoBOQzGOjMlXNfaGf9AaNt1yvmQA== X-Received: by 2002:a05:6214:4806:b0:6ae:47b1:58a with SMTP id 6a1803df08f44-6b013913980mr61775836d6.0.1717679861047; Thu, 06 Jun 2024 06:17:41 -0700 (PDT) Received: from denia.c.googlers.com (123.178.145.34.bc.googleusercontent.com. [34.145.178.123]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b04f6607f5sm6118036d6.31.2024.06.06.06.17.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jun 2024 06:17:40 -0700 (PDT) From: Ricardo Ribalda Date: Thu, 06 Jun 2024 13:16:43 +0000 Subject: [PATCH v4 09/11] media: venus: Refactor hfi_sys_get_property_pkt Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240606-cocci-flexarray-v4-9-3379ee5eed28@chromium.org> References: <20240606-cocci-flexarray-v4-0-3379ee5eed28@chromium.org> In-Reply-To: <20240606-cocci-flexarray-v4-0-3379ee5eed28@chromium.org> To: Mauro Carvalho Chehab , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.12.4 Replace a single length element array with an element. This fixes the following cocci warning: drivers/media/platform/qcom/venus/hfi_cmds.h:77:5-9: WARNING use flexible-a= rray member instead (https://www.kernel.org/doc/html/latest/process/depreca= ted.html#zero-length-and-one-element-arrays) Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/hfi_cmds.c | 2 +- drivers/media/platform/qcom/venus/hfi_cmds.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.c b/drivers/media/p= latform/qcom/venus/hfi_cmds.c index 75f4a3d3e748..0a4de8ca1df5 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.c +++ b/drivers/media/platform/qcom/venus/hfi_cmds.c @@ -156,7 +156,7 @@ void pkt_sys_image_version(struct hfi_sys_get_property_= pkt *pkt) pkt->hdr.size =3D sizeof(*pkt); pkt->hdr.pkt_type =3D HFI_CMD_SYS_GET_PROPERTY; pkt->num_properties =3D 1; - pkt->data[0] =3D HFI_PROPERTY_SYS_IMAGE_VERSION; + pkt->data =3D HFI_PROPERTY_SYS_IMAGE_VERSION; } =20 int pkt_session_init(struct hfi_session_init_pkt *pkt, void *cookie, diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.h b/drivers/media/p= latform/qcom/venus/hfi_cmds.h index 2c56ae303989..f91bc9087643 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.h +++ b/drivers/media/platform/qcom/venus/hfi_cmds.h @@ -74,7 +74,7 @@ struct hfi_sys_set_property_pkt { struct hfi_sys_get_property_pkt { struct hfi_pkt_hdr hdr; u32 num_properties; - u32 data[1]; + u32 data; }; =20 struct hfi_sys_ping_pkt { --=20 2.45.2.505.gda0bf45e8d-goog From nobody Thu Feb 12 21:49:24 2026 Received: from mail-oo1-f47.google.com (mail-oo1-f47.google.com [209.85.161.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07037197A98 for ; Thu, 6 Jun 2024 13:17:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717679864; cv=none; b=QVSulw1ucrAiVv5SgaeA5oll8hQTpMVM4YYt4m3o08+8h4+36/yoOaRsoXWGiHncyUzsQf3aR2CUXZ4LqRSgEvx1MwnNBVlkK10eh3z/mWR9j0cy4gD7p/qH8egUUT+wNMPSsJjZwsHUyKUNBlLFuBtnuXOKLvH5J+f8NDFaoQ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717679864; c=relaxed/simple; bh=/NolsqpFl438TCqFo9LQEcg+v+sNSkqQj0PpqvI4hys=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=duuPZ71eA2IR4pUeex0jGKNTqyMrvusssBt1+cMbKvNQd8J1bAmr1H1Flz4cYnlGoaDYQD5hKcaFNMfq0RLHa+06iY17H8u04PFe4AnjTsg5GJIrF70LObQl3BDrqs/YxEzOhVUR8Dzu5CxXWNzoOKkD0tLTiKcGeC65dlBlSq0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=B0m2W8Yc; arc=none smtp.client-ip=209.85.161.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="B0m2W8Yc" Received: by mail-oo1-f47.google.com with SMTP id 006d021491bc7-5b97b5822d8so389256eaf.3 for ; Thu, 06 Jun 2024 06:17:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1717679862; x=1718284662; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=9kZibIjO2Z4ZCSJlx2Ohq41MEqbhxGGlKtW/qmnnTcc=; b=B0m2W8YcCHfDC4u1Xmsgo73tUGvDyueDVroXxO9OL8c342QQY+D0w+AqzlzB+FSepg VYNOz4WDZiEH6usVHvTAWUl3MOIQ2nEr/4wmyDbdflv7Al9aaOvfC1TVesXa5ePhTpEz BgPlKq1RuHWbcY9EjEXv2fZG+eB8iT8cj61eg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717679862; x=1718284662; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9kZibIjO2Z4ZCSJlx2Ohq41MEqbhxGGlKtW/qmnnTcc=; b=L+TOalEJvKBGQa1NY9Auh9TzIYEts+YQQmjF0ycMcDQJJFMskZisIhcD1vwD8BxtV8 3XWEoYsv429OPCXpph0tiSR6NG6YzYxQfC73ttKla+PaabuNl+f1IAmTjFTGdfn/dvA7 Y496pmWPnBq2mbMEvynvT6FXvuzkBgidpLrL2BdB2KaKs/8r7pf5WFMrzDzteBQId+R0 cVkJS7MSfhRdUakjpnRbleo8aBGbTKbS+4454eGW6UxWRmSTg5Z1EKOKEydn09PruwEC 9i6AotYU74Kqgnnth4jec28z3zpSq8QWi6dzr0L8D1UzAENMoeTyPEAYdQgo6ZN0uuav uIgg== X-Forwarded-Encrypted: i=1; AJvYcCVOIlMGZGPH1Nl5pFLtkGDzsnP6HpysgQPXZZeOcjTuF9biVtKlh4uE5N0ghEc6hM29nwcPaHDte5Aa6zawf9N8J29HiSqVZGt+/RGH X-Gm-Message-State: AOJu0YyTnCKbnCSScnS3ZfUCfIBspOTy6UmURxOg/35MtJDhr/BYSUBi MBH0l3QJnEz53gn03D4+h765CB9ah7/NDy59EHAgZIW5AH/sAxWUjj/1x2JsVQ== X-Google-Smtp-Source: AGHT+IEGO3j4JeIIT057xPo5p1aauD1hqTN0PU5iBBrHrF1scvkyvtDkNWbpsNVMkjbf/7njNIrIMA== X-Received: by 2002:a05:6358:72a:b0:19f:13dd:b7a7 with SMTP id e5c5f4694b2df-19f13ddbb03mr111660555d.29.1717679862024; Thu, 06 Jun 2024 06:17:42 -0700 (PDT) Received: from denia.c.googlers.com (123.178.145.34.bc.googleusercontent.com. [34.145.178.123]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b04f6607f5sm6118036d6.31.2024.06.06.06.17.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jun 2024 06:17:41 -0700 (PDT) From: Ricardo Ribalda Date: Thu, 06 Jun 2024 13:16:44 +0000 Subject: [PATCH v4 10/11] media: venus: Refactor hfi_session_fill_buffer_pkt Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240606-cocci-flexarray-v4-10-3379ee5eed28@chromium.org> References: <20240606-cocci-flexarray-v4-0-3379ee5eed28@chromium.org> In-Reply-To: <20240606-cocci-flexarray-v4-0-3379ee5eed28@chromium.org> To: Mauro Carvalho Chehab , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.12.4 The single data array data[1] is only used to save the extradata_size. Replace it with a single element field. This fixes the following cocci warning: drivers/media/platform/qcom/venus/hfi_cmds.h:175:5-9: WARNING use flexible-= array member instead (https://www.kernel.org/doc/html/latest/process/deprec= ated.html#zero-length-and-one-element-arrays) Reviewed-by: Bryan O'Donoghue Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/hfi_cmds.c | 2 +- drivers/media/platform/qcom/venus/hfi_cmds.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.c b/drivers/media/p= latform/qcom/venus/hfi_cmds.c index 0a4de8ca1df5..3ae063094e3e 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.c +++ b/drivers/media/platform/qcom/venus/hfi_cmds.c @@ -331,7 +331,7 @@ int pkt_session_ftb(struct hfi_session_fill_buffer_pkt = *pkt, void *cookie, pkt->alloc_len =3D out_frame->alloc_len; pkt->filled_len =3D out_frame->filled_len; pkt->offset =3D out_frame->offset; - pkt->data[0] =3D out_frame->extradata_size; + pkt->data =3D out_frame->extradata_size; =20 return 0; } diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.h b/drivers/media/p= latform/qcom/venus/hfi_cmds.h index f91bc9087643..daba45720ddc 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.h +++ b/drivers/media/platform/qcom/venus/hfi_cmds.h @@ -172,7 +172,7 @@ struct hfi_session_fill_buffer_pkt { u32 output_tag; u32 packet_buffer; u32 extradata_buffer; - u32 data[1]; + u32 data; }; =20 struct hfi_session_flush_pkt { --=20 2.45.2.505.gda0bf45e8d-goog From nobody Thu Feb 12 21:49:24 2026 Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9ADA1198A02 for ; Thu, 6 Jun 2024 13:17:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717679866; cv=none; b=gcaNfhDNrMbQ7qOAkVsVqfQmoe2qkrX9kARmneYW16hcA1Azj4Kf39p/HhWNN28ftORFzcStVCBnVAH6T6lgxpf9+1YJs/PV51YwKy+Z9e0qxAazhmekuVz7XHLkVSSVuzV1dVEQjyH1YWyUpoI3anoUPEhfW1BLMNX0unmaM14= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717679866; c=relaxed/simple; bh=Avo2Fleh4ujjt70o15EeficxKnpelBo2TOFCLUdZKFI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=teSNtIYDdgTz1K8dGWOFKTRsTwdFdgYg9MNP3nKRV1Uy2vHX1fMImbsOhzD8GZqbSaZF+w+VPStXER8Ay8oZXRjAcGlYfGDneRMEqTz4agDWQx1bgFquhN2+TLz0PIMOa031OG/or5bKs1a0SpXQxINjSfhg+ctAiaAabEVjhc0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=dr0D+icq; arc=none smtp.client-ip=209.85.219.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="dr0D+icq" Received: by mail-qv1-f53.google.com with SMTP id 6a1803df08f44-6ae60725ea1so5388936d6.2 for ; Thu, 06 Jun 2024 06:17:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1717679863; x=1718284663; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=2o9uFpZwETiKeZWYLVPp/h/C01HBTzSktsioUGg06Ew=; b=dr0D+icqsuyL2nuQ7p7S3Vud/E3YjHXXW6VdaFnIvukhdpS6XoVSxygvcFuE3lurd4 ElRlCgM7ovhhl4r98jnxmqNfFGAemoaFK95QcAr78CbdyY7YSZRiDvoAgDLT1m3Hjd6n yrt+P0n5v7LJW1e/NjwPDP670UOhdTjCZpvfM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717679863; x=1718284663; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2o9uFpZwETiKeZWYLVPp/h/C01HBTzSktsioUGg06Ew=; b=Yk8Dag6ukm1yCvrzH7JGtiKpztKH8ZWT8ukQe3AmghbBa0C3y/A4SCFKVHbE87RhyC u6oCSudrMBfjBeUek4eJ4or5SvS7dMC+rDX/Qb8lIYOqCSw28ps5lXoeXwWFrklQtDsN A8ERNZALPQGWALQP2Or69TrIHjhufZJwHplAcfPaW05aU/KXVGhg4MbJwKwddE8QaxT3 Dc8UffR6bzX+km1srDcZZfIrO/9GF1J3jdSjjxoGjrCr2Z7eZFpym9EVfA+LSSdVeerC el5rz0OE2K0ncxTtInREaOYdE5WilxsVqMyIxWR7T9ZzKAZwjfFD7tLNr/+kWbAbo4FO 1wtQ== X-Forwarded-Encrypted: i=1; AJvYcCWmiAGI5aRoZJTVtTc2fIHj8nQqCwGQja3BsxweBpJPbNl2JfAR7zUz04f7GWEv5qEBxCPe5RbUwIVihS9JnFDXclylBpepBFP5k8mP X-Gm-Message-State: AOJu0YyJF5CvkyzklUmDJfztDxkLsdHeFlQQVD3buiSRaAqTS5Q3Wk6t rce1BveykZbQp3GmQZ58YybJBhZg0Avb5Sbt5JKzLbCiVN0ezB/IAYtDAJbOrg== X-Google-Smtp-Source: AGHT+IE8jXrmgfRC91PfzOqBRQfeMgy1DzBFB7+DOjFIBnca6lzwJN2RUcERx9LU43E0vr3vRV6ErQ== X-Received: by 2002:a05:6214:3f91:b0:6af:cdb3:5db with SMTP id 6a1803df08f44-6b031cecca9mr63488376d6.63.1717679863024; Thu, 06 Jun 2024 06:17:43 -0700 (PDT) Received: from denia.c.googlers.com (123.178.145.34.bc.googleusercontent.com. [34.145.178.123]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b04f6607f5sm6118036d6.31.2024.06.06.06.17.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jun 2024 06:17:42 -0700 (PDT) From: Ricardo Ribalda Date: Thu, 06 Jun 2024 13:16:45 +0000 Subject: [PATCH v4 11/11] media: venus: Refactor hfi_buffer_alloc_mode_supported Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240606-cocci-flexarray-v4-11-3379ee5eed28@chromium.org> References: <20240606-cocci-flexarray-v4-0-3379ee5eed28@chromium.org> In-Reply-To: <20240606-cocci-flexarray-v4-0-3379ee5eed28@chromium.org> To: Mauro Carvalho Chehab , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.12.4 Replace the old style single element array at the end of the struct with a flex array. The code does not allocate this structure, so the size change should not be a problem. This fixes the following cocci warning: drivers/media/platform/qcom/venus/hfi_helper.h:1233:5-9: WARNING use flexib= le-array member instead (https://www.kernel.org/doc/html/latest/process/dep= recated.html#zero-length-and-one-element-arrays) Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/hfi_helper.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/venus/hfi_helper.h b/drivers/media= /platform/qcom/venus/hfi_helper.h index dee439ea4d2e..9545c964a428 100644 --- a/drivers/media/platform/qcom/venus/hfi_helper.h +++ b/drivers/media/platform/qcom/venus/hfi_helper.h @@ -1230,7 +1230,7 @@ struct hfi_interlace_format_supported { struct hfi_buffer_alloc_mode_supported { u32 buffer_type; u32 num_entries; - u32 data[1]; + u32 data[]; }; =20 struct hfi_metadata_pass_through { --=20 2.45.2.505.gda0bf45e8d-goog