From nobody Tue Dec 16 07:29:48 2025 Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A5D8F18F2CE; Wed, 5 Jun 2024 07:54:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=114.242.206.163 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717574068; cv=none; b=FEOIbeNr+uzMnd8SCFJaoGTfUCOk0hTIRPxWBW3kaUyC2CJbjQOYpCpOYp7nEvr/2+xLdcgfZOJFyNu1ctdOdVbE0UjXCvcCg+SsMSilEwkqFKnwGKmoPAopoecZpPnbM8fGiYVs+3NRFwbtupztH0VQXm2izJa2HXmNGV5zdMk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717574068; c=relaxed/simple; bh=0WgU7SJsiJXMETAWSbenmXb88IxbtmToM9ed9ByiSVg=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=GPnyBecn99rgf6pYwret1AEKediQ+do6q4MLv1ID6W1ORSG/X3xU8SdMvU0q1kM3YsBNVjoX70lRW2hLJeRWDLogSMh3o//QVHBJFJnFQ/jkxq9bOLVWY8TReWEPQAU6UnIi3HiS6MpX1JnONvI23/OiYpouPOcmC20W2n7Yn8Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=loongson.cn; spf=pass smtp.mailfrom=loongson.cn; arc=none smtp.client-ip=114.242.206.163 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=loongson.cn Received: from loongson.cn (unknown [10.180.133.93]) by gateway (Coremail) with SMTP id _____8AxnOqtGWBmRLADAA--.15767S3; Wed, 05 Jun 2024 15:54:21 +0800 (CST) Received: from localhost.localdomain (unknown [10.180.133.93]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Axw8StGWBmJFkVAA--.42593S2; Wed, 05 Jun 2024 15:54:21 +0800 (CST) From: Hongchen Zhang To: Bjorn Helgaas Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, Hongchen Zhang , stable@vger.kernel.org, Huacai Chen Subject: [PATCH v2] PCI: use local_pci_probe when best selected cpu is offline Date: Wed, 5 Jun 2024 15:54:19 +0800 Message-Id: <20240605075419.3973256-1-zhanghongchen@loongson.cn> X-Mailer: git-send-email 2.33.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: AQAAf8Axw8StGWBmJFkVAA--.42593S2 X-CM-SenderInfo: x2kd0w5krqwupkhqwqxorr0wxvrqhubq/1tbiAQATB2ZfxJMElgABso X-Coremail-Antispam: 1Uk129KBj9xXoW7GrW7CFW8Jw4fuw4kZr1kWFX_yoWkJFb_uF y0grs7Wr4UCry0y3s0vr4fZrZYk3WjvFn2kF4xta43Za47AF15tayDury5JF18Ww43JF9I yw1UXr18ur17JosvyTuYvTs0mTUanT9S1TB71UUUUUDqnTZGkaVYY2UrUUUUj1kv1TuYvT s0mT0YCTnIWjqI5I8CrVACY4xI64kE6c02F40Ex7xfYxn0WfASr-VFAUDa7-sFnT9fnUUI cSsGvfJTRUUUb28YFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I6I8E6xAIw20EY4v20x vaj40_Wr0E3s1l1IIY67AEw4v_Jrv_JF1l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxS w2x7M28EF7xvwVC0I7IYx2IY67AKxVWUCVW8JwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxV WUJVW8JwA2z4x0Y4vEx4A2jsIE14v26r4UJVWxJr1l84ACjcxK6I8E87Iv6xkF7I0E14v2 6r4UJVWxJr1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44I27w Aqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jrv_JF1lYx0Ex4A2jsIE 14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwCF04k20xvY0x 0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E 7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcV C0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF 04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7 CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07j1WlkUUUUU= Content-Type: text/plain; charset="utf-8" When the best selected CPU is offline, work_on_cpu() will stuck forever. This can be happen if a node is online while all its CPUs are offline (we can use "maxcpus=3D1" without "nr_cpus=3D1" to reproduce it), Therefore, in this case, we should call local_pci_probe() instead of work_on_cpu(). Cc: Signed-off-by: Huacai Chen Signed-off-by: Hongchen Zhang --- v1 -> v2 Added the method to reproduce this issue --- drivers/pci/pci-driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c index af2996d0d17f..32a99828e6a3 100644 --- a/drivers/pci/pci-driver.c +++ b/drivers/pci/pci-driver.c @@ -386,7 +386,7 @@ static int pci_call_probe(struct pci_driver *drv, struc= t pci_dev *dev, free_cpumask_var(wq_domain_mask); } =20 - if (cpu < nr_cpu_ids) + if ((cpu < nr_cpu_ids) && cpu_online(cpu)) error =3D work_on_cpu(cpu, local_pci_probe, &ddi); else error =3D local_pci_probe(&ddi); --=20 2.33.0