From nobody Fri Feb 13 01:39:46 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 908291411E8 for ; Tue, 4 Jun 2024 07:52:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717487555; cv=none; b=W8UKEy7TjRbVwnnbQYMXe6RdVTTNGtnzNMQehK6KZpr1/HLpWX/QDbe41mpr1u0TjQY422nSwvuC4tozKHE6IHY/KsaUfnl9CYptSL/X5tWbowzr8pp9A4m0biYme4m2n1H6GH/SVh6uv9kcKN8N6X8NEbF4c3aGg2PsS4/FKlw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717487555; c=relaxed/simple; bh=4dNTR4z2BJ3pfaXEO6tM9yIxe4LDIns4WgIcbTF2vYs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dvTBFw+Mr0sR1w7z4LHbfqaUXt/5AnH6WQNoRuUYm4W+Q3zhV/LoOkxsmEWdtmv04Mh5fAP0uS8RFNwzgVvN7M8Kq9OUtoqpUpwfl2oIJqXVUroLd6nUlTsyVWbvH9EXoNFl0OzO+PbSOorr6Ou3cpoqrHeZa3orcBCzsRauyhQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=d6kfXcCM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="d6kfXcCM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19789C32782; Tue, 4 Jun 2024 07:52:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717487555; bh=4dNTR4z2BJ3pfaXEO6tM9yIxe4LDIns4WgIcbTF2vYs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=d6kfXcCMGKpSuvA2cir2lb03te8T5XAKFF4r3vqHWbHIEqBpJxf5BSJ470hKfvJhe YVcZWSYHuMGm2EjrDlZSTp+sXliB8A3/yOWOiIkTNO93DTMPiZrEQJ99e3tayCENrQ UIbshji7em3n8Dt1ioeo6Vu3gIKIJFd5EfvG8TyTc/XXk4x8AJpyFrgTDP4oftZ5My NuFrKIfD1sf6YV/Alor0ci1o1OjAMElPOw12S8KhdtkDJR2YZmBelK4V/LHzw0oios Rhptz7oVD8CMi3aRBVWCJqcTIkAkgpU7Kl1qkOHyCgPc2BCn7iHJV9teokjCBEASx2 nF1PUuyHAiT4A== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1sEOy9-000000005QN-2ixN; Tue, 04 Jun 2024 09:52:33 +0200 From: Johan Hovold To: Vinod Koul Cc: Bard Liao , Pierre-Louis Bossart , Sanyog Kale , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v2 1/4] soundwire: bus: suppress probe deferral errors Date: Tue, 4 Jun 2024 09:52:10 +0200 Message-ID: <20240604075213.20815-2-johan+linaro@kernel.org> X-Mailer: git-send-email 2.44.1 In-Reply-To: <20240604075213.20815-1-johan+linaro@kernel.org> References: <20240604075213.20815-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Soundwire driver probe errors are currently being logged both by the bus code and driver core: wsa884x-codec sdw:4:0:0217:0204:00:0: Probe of wsa884x-codec failed: -12 wsa884x-codec sdw:4:0:0217:0204:00:0: probe with driver wsa884x-codec fail= ed with error -12 Drop the redundant bus error message, which is also incorrectly being logged on probe deferral: wsa884x-codec sdw:4:0:0217:0204:00:0: Probe of wsa884x-codec failed: -517 Note that no soundwire driver uses the driver struct name field, which will be removed by a follow-on change. Signed-off-by: Johan Hovold --- drivers/soundwire/bus_type.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/soundwire/bus_type.c b/drivers/soundwire/bus_type.c index c32faace618f..85fa5970d98a 100644 --- a/drivers/soundwire/bus_type.c +++ b/drivers/soundwire/bus_type.c @@ -83,7 +83,6 @@ static int sdw_drv_probe(struct device *dev) struct sdw_slave *slave =3D dev_to_sdw_dev(dev); struct sdw_driver *drv =3D drv_to_sdw_driver(dev->driver); const struct sdw_device_id *id; - const char *name; int ret; =20 /* @@ -108,11 +107,6 @@ static int sdw_drv_probe(struct device *dev) =20 ret =3D drv->probe(slave, id); if (ret) { - name =3D drv->name; - if (!name) - name =3D drv->driver.name; - - dev_err(dev, "Probe of %s failed: %d\n", name, ret); dev_pm_domain_detach(dev, false); return ret; } --=20 2.44.1 From nobody Fri Feb 13 01:39:46 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6211D1411CB for ; Tue, 4 Jun 2024 07:52:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717487555; cv=none; b=aFyVBphwLqkbjbTJDLAp3hLJO7CBMSxm2pxG/0vMRJWCWQ1gqijvxB5A2jBeA6SRbOZPjoti5RPyoiFB33ps3ed2J3O1S7DK9CQoz3XeTd5oX8c1JIMoYHU2JipvKXYOVxCaluV90gV0HUOpHii6TPCV9mVqfZvjWoQvcNM9n0c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717487555; c=relaxed/simple; bh=0miAYvpRkAOFP1cMzY2sUokznCRDxVUYD0uECgu4qUU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sB/VZmm368SD7oDDQpqsNIjpG9SFpzFKF2dQ0SLg4n48as/S1/cBENdBNmjVbQf+hfLXeVncUzjtNFtQ8hYx63eJwS8hhwsfxxntFZQUeo7xypyIKe9OneYdkuQrG1Y8n4/Eh6Nw0GD0FMG1Vz+ZwpozFUndipS1fWLlXg/ALLU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KzG99Qw5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KzG99Qw5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21677C4AF0A; Tue, 4 Jun 2024 07:52:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717487555; bh=0miAYvpRkAOFP1cMzY2sUokznCRDxVUYD0uECgu4qUU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KzG99Qw5ODW1xQLiR9KG29aXCAfNttYdbB7UcPyeZbQXgW5vYcm8NJ5P4THgJvH51 9lMrayaJzfHdKb3ToFEsMtdbCJSaZwy3zX9QsB0OdoH8ZGCtkeW7LuCgyR4hhBIAxw YH6GDZstjwzBBekAPGDGIXxvqDLgTjBUIRQ40llXpFKk9VxNJTjc+xKmh1llyGpGx4 900dvTibDCfD0Ps9P7MC3PDkoWBmaCwNeLcJBSTHWaj502R9hAsrrTNI8Y9jufk4LQ mgU8nzwf5BVJIvOpFW5BSaEkmC0j2k6yeBAmqBekTrHFA01NFoKLhRZr8zKds1+0RH fsnDSM0N1kamA== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1sEOy9-000000005QP-3637; Tue, 04 Jun 2024 09:52:33 +0200 From: Johan Hovold To: Vinod Koul Cc: Bard Liao , Pierre-Louis Bossart , Sanyog Kale , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v2 2/4] soundwire: bus: drop unused driver name field Date: Tue, 4 Jun 2024 09:52:11 +0200 Message-ID: <20240604075213.20815-3-johan+linaro@kernel.org> X-Mailer: git-send-email 2.44.1 In-Reply-To: <20240604075213.20815-1-johan+linaro@kernel.org> References: <20240604075213.20815-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The soundwire driver name field is not currently used by any driver (and even appears to never have been used) so drop it. Signed-off-by: Johan Hovold --- drivers/soundwire/bus_type.c | 9 ++------- include/linux/soundwire/sdw.h | 2 -- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/soundwire/bus_type.c b/drivers/soundwire/bus_type.c index 85fa5970d98a..3979be0f8b65 100644 --- a/drivers/soundwire/bus_type.c +++ b/drivers/soundwire/bus_type.c @@ -198,16 +198,11 @@ static void sdw_drv_shutdown(struct device *dev) */ int __sdw_register_driver(struct sdw_driver *drv, struct module *owner) { - const char *name; - drv->driver.bus =3D &sdw_bus_type; =20 if (!drv->probe) { - name =3D drv->name; - if (!name) - name =3D drv->driver.name; - - pr_err("driver %s didn't provide SDW probe routine\n", name); + pr_err("driver %s didn't provide SDW probe routine\n", + drv->driver.name); return -EINVAL; } =20 diff --git a/include/linux/soundwire/sdw.h b/include/linux/soundwire/sdw.h index 13e96d8b7423..5e133dfec8f2 100644 --- a/include/linux/soundwire/sdw.h +++ b/include/linux/soundwire/sdw.h @@ -704,8 +704,6 @@ struct sdw_master_device { container_of(d, struct sdw_master_device, dev) =20 struct sdw_driver { - const char *name; - int (*probe)(struct sdw_slave *sdw, const struct sdw_device_id *id); int (*remove)(struct sdw_slave *sdw); --=20 2.44.1 From nobody Fri Feb 13 01:39:46 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 921431411EA for ; Tue, 4 Jun 2024 07:52:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717487555; cv=none; b=mKOKLq2FFltjywabskOGqFl9+7afpyJe4vy1MX80WhMI7YOEPKuDCuO4zIPI3XqbD+EA+EAN2NrlcUyFFi7Poev57UAz5OKYKfhGs4Gl4DgDaZunzwVeGajl174RIdMPKXr0N5iCRDNZ644Q8AYdxFmlIY9Uo6jPOJlM0snXyfA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717487555; c=relaxed/simple; bh=b3E/UIPslsT8I86wbPoMlWOJhjF5vCXYbMseh+Nd3tk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kwb+0HfxWmjorU7ja4Q2dyQC2IpQk2AiT6yd9OhBPR5AmtIzu084uWrMcH28bwrqTP+iu2uU8A1EOyyTr4V1J9Sf9sXFC/p87p4T9sev+4+mKJJ+vbIVBQUe3/87LO2B9Y2duTtCWgTM9RLB9DDp5NsP01UUO5hlxDgTdnclqXU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tjDXtJ2B; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tjDXtJ2B" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17191C2BBFC; Tue, 4 Jun 2024 07:52:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717487555; bh=b3E/UIPslsT8I86wbPoMlWOJhjF5vCXYbMseh+Nd3tk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tjDXtJ2Bnfn07g6X0XM+j297fga5v438KKDbcNVYwW2D+xQhMkkweVBBOq3AS1gnX LAT0S0hHXiRAbW0abuhjIBsb7zRZd9Vov9GSssIzB5IvYRfy0nEstMHIRPPAskPjwZ KPCRv+C8IrQHxklAXbga205F0kcrlnBKjckpEDIv6XiTukWD1DeFIjNuDugks8XN2e +NAcE3ybEZRC3RsKxXDrnGMEICl+VqRqArskLYTKbqPdtGalr7LhEMxDRIXFolzZ/z GvzdKSHVxQ/eknLuUFdKt8ZRyfKtv+2m3GlZTu3mNahck1+jtV4OGGQI18symujISv W1td3s2pCk3Mg== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1sEOy9-000000005QR-3RBp; Tue, 04 Jun 2024 09:52:33 +0200 From: Johan Hovold To: Vinod Koul Cc: Bard Liao , Pierre-Louis Bossart , Sanyog Kale , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v2 3/4] soundwire: bus: clean up probe warnings Date: Tue, 4 Jun 2024 09:52:12 +0200 Message-ID: <20240604075213.20815-4-johan+linaro@kernel.org> X-Mailer: git-send-email 2.44.1 In-Reply-To: <20240604075213.20815-1-johan+linaro@kernel.org> References: <20240604075213.20815-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Clean up the probe warning messages by using a common succinct format (e.g. without __func__ and with a space after ':'). Signed-off-by: Johan Hovold --- drivers/soundwire/bus_type.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soundwire/bus_type.c b/drivers/soundwire/bus_type.c index 3979be0f8b65..43e732ca73c0 100644 --- a/drivers/soundwire/bus_type.c +++ b/drivers/soundwire/bus_type.c @@ -123,7 +123,7 @@ static int sdw_drv_probe(struct device *dev) /* init the dynamic sysfs attributes we need */ ret =3D sdw_slave_sysfs_dpn_init(slave); if (ret < 0) - dev_warn(dev, "Slave sysfs init failed:%d\n", ret); + dev_warn(dev, "failed to initialise sysfs: %d\n", ret); =20 /* * Check for valid clk_stop_timeout, use DisCo worst case value of @@ -147,7 +147,7 @@ static int sdw_drv_probe(struct device *dev) if (drv->ops && drv->ops->update_status) { ret =3D drv->ops->update_status(slave, slave->status); if (ret < 0) - dev_warn(dev, "%s: update_status failed with status %d\n", __func__, re= t); + dev_warn(dev, "failed to update status: %d\n", ret); } =20 mutex_unlock(&slave->sdw_dev_lock); --=20 2.44.1 From nobody Fri Feb 13 01:39:46 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E6981411CA for ; Tue, 4 Jun 2024 07:52:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717487555; cv=none; b=WpgBq3iey6TrsnOO1bYUJTCPqK0A8qIYL2loCqW3a0krxnxN7YnYdgN3ILDHfiXcQq7TjoA9/KkSJclRfc4Gjy7l++4MYg5muHZpQZvHpQgCS7XKnFhG2+5HqfgekF5qN3j4KBFkFP8J2od/XBcvOJv+ftNNK0cpohiV8GyCjMU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717487555; c=relaxed/simple; bh=hi7PWtwphuTNKYoU1XS9MRhf81ClVkiQ1xJd4IkXUsg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=H2fuReHtgAD2ByQy97DoWBS8D6F5XE52pKU0GrX8q8qWI8a2e2I5s5A0HEci913MCNJMK1/3xh1d93t0FMvGYLb3WaUgyIwfcg1T29Kcu5iGpW4ncSUWJCFjlfs40PnS6/svchnESeKIJuPj/m50+biLE1jfnIDvIQ2ZqllnP1Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=E+XYvvT5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="E+XYvvT5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C508C4AF08; Tue, 4 Jun 2024 07:52:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717487555; bh=hi7PWtwphuTNKYoU1XS9MRhf81ClVkiQ1xJd4IkXUsg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=E+XYvvT5XpJaP1NvyduzcIpGyiIREifzDW8WqTsMx0GDH02HpxMjUk3CSQeKZdFKd t6M3E9lDRO2KpOhZnl5YykJXmipfY+cUhmbRUZ3ODgSdU+KlyUJWU5cEsGSUQh3x1t 9f2dZyUNLuVAi51/X6yolNV9BNrJwC3filbeBTn3uZqeJQe4I/W2pEwB1inZIc6CDK bR6VclVvYeys2vfTgdnwxf+4lbhXORPWyzBQY1rUvy4G8pUeYnSG8JbjFxkpMg6Cwh fr4htXNh5ciBZybh02rmJB23kcbTzmgQkanCtTOJTyKt4pqlSvvLN9w7IInp2WNuWJ x1LPpQnfVpmYQ== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1sEOy9-000000005QT-3oXW; Tue, 04 Jun 2024 09:52:33 +0200 From: Johan Hovold To: Vinod Koul Cc: Bard Liao , Pierre-Louis Bossart , Sanyog Kale , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v2 4/4] soundwire: bus: drop redundant probe debug message Date: Tue, 4 Jun 2024 09:52:13 +0200 Message-ID: <20240604075213.20815-5-johan+linaro@kernel.org> X-Mailer: git-send-email 2.44.1 In-Reply-To: <20240604075213.20815-1-johan+linaro@kernel.org> References: <20240604075213.20815-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Drop the redundant probe debug message which is already provided by driver core. Whether probe succeeded can also be determined through sysfs. Signed-off-by: Johan Hovold --- drivers/soundwire/bus_type.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/soundwire/bus_type.c b/drivers/soundwire/bus_type.c index 43e732ca73c0..5b9b129badff 100644 --- a/drivers/soundwire/bus_type.c +++ b/drivers/soundwire/bus_type.c @@ -152,8 +152,6 @@ static int sdw_drv_probe(struct device *dev) =20 mutex_unlock(&slave->sdw_dev_lock); =20 - dev_dbg(dev, "probe complete\n"); - return 0; } =20 --=20 2.44.1