From nobody Fri Feb 13 03:05:48 2026 Received: from out-187.mta1.migadu.com (out-187.mta1.migadu.com [95.215.58.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48987839EA for ; Mon, 3 Jun 2024 12:50:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.187 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717419041; cv=none; b=UXpbQZQNiYo90mRjmap9tJ3Bguftk6cg8Ubi/96ChbCMeYeRZrWf/FYFkQKdqGdtvyw/ec3qkqeCMeWxqKWYNPCWdw6b6oARhLC0ylWu3kgWUd6YYFX9If5SpFMaQBIanO9re108xI8FAv4z+RD5TdR5u09jLPAvmd9dM0uYpyY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717419041; c=relaxed/simple; bh=Xx8hZI8ETFFARLK8cGsQFhmUvgpM/d78SWxzC56NTOQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=GJvgJ5RvLfHlS5Er9hkQm4XwxCLmue8v8LbYLKH7HSUD+z/T/l7nxM7tBxFQeRf/axhd8oWy7XfSeOLWkaZnB2hYEZwZnQgthr8f9xGHZecyvepSsKY4APzHZRQlMjayADOA2xj71iCcbH+1rG3Z/jcKgKZwv9r/eZpwE7hrEV8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=N1g197vK; arc=none smtp.client-ip=95.215.58.187 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="N1g197vK" X-Envelope-To: mingo@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1717419037; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xgeKLP+6Ei7WwWWp/yRMV4AawW29LI/t4aEV6fabFvU=; b=N1g197vK3VTZ2J7/8XHk2GOHHCzRQQoMMbmV7UqK4R/ECCSq9+K3dwmpmaymCVDYfaSKyG extP3RgXsUWSsHD3FZZ6pjfFK8shp1fOV/iyLW0g0mX2qF6cUfPLJ1MEnxKue6vnBT3RoO 6HsBBNuggdKUgkK24jIKOKn/n68TAXA= X-Envelope-To: peterz@infradead.org X-Envelope-To: juri.lelli@redhat.com X-Envelope-To: vincent.guittot@linaro.org X-Envelope-To: dietmar.eggemann@arm.com X-Envelope-To: rostedt@goodmis.org X-Envelope-To: bsegall@google.com X-Envelope-To: mgorman@suse.de X-Envelope-To: bristot@redhat.com X-Envelope-To: vschneid@redhat.com X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: yajun.deng@linux.dev X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yajun Deng To: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com Cc: linux-kernel@vger.kernel.org, Yajun Deng Subject: [PATCH 1/2] sched/rt: Use 'back' only if CONFIG_RT_GROUP_SCHED is enabled Date: Mon, 3 Jun 2024 20:50:01 +0800 Message-Id: <20240603125002.3086-2-yajun.deng@linux.dev> In-Reply-To: <20240603125002.3086-1-yajun.deng@linux.dev> References: <20240603125002.3086-1-yajun.deng@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" The 'back' member in struct sched_rt_entity only related to CONFIG_RT_GROUP_SCHED, so there is no need to init it in dequeue_rt_stack. Init the 'back' member in init_tg_rt_entry and use it only if CONFIG_RT_GROUP_SCHED is enabled. Signed-off-by: Yajun Deng --- kernel/sched/rt.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c index 63e49c8ffc4d..44bb9087cfe5 100644 --- a/kernel/sched/rt.c +++ b/kernel/sched/rt.c @@ -232,8 +232,10 @@ void init_tg_rt_entry(struct task_group *tg, struct rt= _rq *rt_rq, =20 if (!parent) rt_se->rt_rq =3D &rq->rt; - else + else { rt_se->rt_rq =3D parent->my_q; + parent->back =3D rt_se; + } =20 rt_se->my_q =3D rt_rq; rt_se->parent =3D parent; @@ -1428,16 +1430,19 @@ static void dequeue_rt_stack(struct sched_rt_entity= *rt_se, unsigned int flags) struct sched_rt_entity *back =3D NULL; unsigned int rt_nr_running; =20 - for_each_sched_rt_entity(rt_se) { - rt_se->back =3D back; + for_each_sched_rt_entity(rt_se) back =3D rt_se; - } =20 rt_nr_running =3D rt_rq_of_se(back)->rt_nr_running; =20 - for (rt_se =3D back; rt_se; rt_se =3D rt_se->back) { + for (rt_se =3D back; rt_se; ) { if (on_rt_rq(rt_se)) __dequeue_rt_entity(rt_se, flags); +#ifdef CONFIG_RT_GROUP_SCHED + rt_se =3D rt_se->back; +#else + rt_se =3D NULL; +#endif } =20 dequeue_top_rt_rq(rt_rq_of_se(back), rt_nr_running); --=20 2.25.1 From nobody Fri Feb 13 03:05:48 2026 Received: from out-186.mta1.migadu.com (out-186.mta1.migadu.com [95.215.58.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B133784A50 for ; Mon, 3 Jun 2024 12:50:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.186 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717419051; cv=none; b=i1dolOWs6jO6/8AZhblaDG6+D/sDr/5z1+i6yagrfiJaeddYpIcgUPpoJVkZGcJHRD7597wW4+mSIn6Yf0fy9LuhvecKX04wqFlr8vOtvFBEd8knVvrQKbkIgcn7XT3hFoIE4TpyE1olpAv8Pwnp2sCXYnBCDDIP8yCJlT+A9zE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717419051; c=relaxed/simple; bh=3BYPVC4YThFdXa5JfdudgN18OixigWcVZ3no0Fj6kP4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=PWVmlfKFJ0NJ94kE7U6Y5cLAr4frSy7AfjhQqMrk2HIpjRlPNu2AVevtbn9QTpSSalrR7hvz8KQ+r957+CBKqJyUkrQdK0fNTRyvxMwfoEKfyHaN28hXcTxwYoeBDlYqtSbolviO8er7MqWX/daEJslrBV2fi49mv6ivoJA4ipk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=IGilUei6; arc=none smtp.client-ip=95.215.58.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="IGilUei6" X-Envelope-To: mingo@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1717419047; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EPvKdZkt6zfC2DIFe80EwNgQmao8ZMFweg+CO3/w42k=; b=IGilUei6dnciBL8aKrEXf3lD4001GHR7cGTjfOBvr35bn77m3YpRWQ3NR+h5eIM7bi3N1E TfzShZ5iOnBUH0r6Lx65XOk+gsWp6iRs/a+CgIrpVgoYHbihHoiB0GmLb7eHcoFc2J6YCE zgWAMfW78uhGeyyBbT4DXKqhZY42jVU= X-Envelope-To: peterz@infradead.org X-Envelope-To: juri.lelli@redhat.com X-Envelope-To: vincent.guittot@linaro.org X-Envelope-To: dietmar.eggemann@arm.com X-Envelope-To: rostedt@goodmis.org X-Envelope-To: bsegall@google.com X-Envelope-To: mgorman@suse.de X-Envelope-To: bristot@redhat.com X-Envelope-To: vschneid@redhat.com X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: yajun.deng@linux.dev X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yajun Deng To: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com Cc: linux-kernel@vger.kernel.org, Yajun Deng Subject: [PATCH 2/2] sched/headers: Move sched_rt_entity::back to under the CONFIG_RT_GROUP_SCHED block Date: Mon, 3 Jun 2024 20:50:02 +0800 Message-Id: <20240603125002.3086-3-yajun.deng@linux.dev> In-Reply-To: <20240603125002.3086-1-yajun.deng@linux.dev> References: <20240603125002.3086-1-yajun.deng@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" We already remove the call to the 'back' member when CONFIG_RT_GROUP_SCHED is disabled. It's safe to move sched_rt_entity::back to under the CONFIG_RT_GROUP_SCHED block, it would save a few bytes. Signed-off-by: Yajun Deng --- include/linux/sched.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/sched.h b/include/linux/sched.h index 61591ac6eab6..3af89a67fb61 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -582,8 +582,8 @@ struct sched_rt_entity { unsigned short on_rq; unsigned short on_list; =20 - struct sched_rt_entity *back; #ifdef CONFIG_RT_GROUP_SCHED + struct sched_rt_entity *back; struct sched_rt_entity *parent; /* rq on which this entity is (to be) queued: */ struct rt_rq *rt_rq; --=20 2.25.1