From nobody Fri Feb 13 06:09:26 2026 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A1611514EC; Sat, 1 Jun 2024 13:13:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717247591; cv=none; b=XR4WiQIm39OuedHbRH62d2zynnRKeFgjjeByAN+71pRYvndowWdUu5s1D5bSPh1kmchh+At2BD7bSGuYgtt8A4bjQHCR2lmu2JA9JwPLMyUJk4LZKkeipQHAQuoIaJMxyk7qo89rhWFxGJmndG6dwrsdpN2wy8TDR0O37ApXeu8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717247591; c=relaxed/simple; bh=0XPNMqqFtOhoxjrDgj6/3VgASXxe/+nxRaHRw8jQO2Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tLeuAP4k1e0zAoy0sOLe+58n96TnmRUvYUQ8ZSdjfAYJuPfgLQbd3A1Sgx58aYiqv7h02e6/Gjnl5bOd5X5WSOEW5UDUOyELl5kdhC0SfSBIw+UFEAQi3QToYE8peiQBZPTIRX21av/l1iY5Fw+xExQRSaAL9lZSaVWMtSIQtsc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=CcIMQRSy; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="CcIMQRSy" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1717247587; bh=0XPNMqqFtOhoxjrDgj6/3VgASXxe/+nxRaHRw8jQO2Y=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=CcIMQRSyY1+Z92ftcrx1DteAUgwOPwlot84JpoOPX/eObZdYfStC0xX4VzqfB53xr r+0ty4/5Fw1SKcNW/6WYGoAGRc7jh8Rme12L9IHJVFY+vT/UpoAVGdUs0/oBblNXtQ KRiUteamltWxYkVn6xDg+DF5ndxcgY7v+Dh+SMnDIzd+LzHFvqCAtBC8Gds6CswbGv 4yTRffFSMfkQPeM7tPorG8R0anVEmck3TajYYctUBN8fSiIbHvaDu597h1eu36aAxK yiqHd+U4Y7YZdD2LZwVoGXPLhBBL58hyeZixdKyIgiPDm72+gmxBJhdnyr7u7dIYG2 sIuEp4Nrj8HUw== Received: from localhost (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by madrid.collaboradmins.com (Postfix) with ESMTPSA id DD74437821EF; Sat, 1 Jun 2024 13:13:06 +0000 (UTC) From: Cristian Ciocaltea Date: Sat, 01 Jun 2024 16:12:29 +0300 Subject: [PATCH 07/14] drm/bridge: dw-hdmi: Commonize dw_hdmi_connector_create() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240601-b4-rk3588-bridge-upstream-v1-7-f6203753232b@collabora.com> References: <20240601-b4-rk3588-bridge-upstream-v1-0-f6203753232b@collabora.com> In-Reply-To: <20240601-b4-rk3588-bridge-upstream-v1-0-f6203753232b@collabora.com> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Andy Yan , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mark Yao Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@collabora.com, Alexandre ARNOUD , Luis de Arquer X-Mailer: b4 0.14-dev-f7c49 In preparation to add support for the HDMI 2.1 Quad-Pixel TX Controller and minimize code duplication, export dw_hdmi_connector_create() function, while adding a new parameter to allow using a different drm_connector_funcs structure. Signed-off-by: Cristian Ciocaltea --- drivers/gpu/drm/bridge/synopsys/dw-hdmi-common.h | 2 ++ drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 8 +++++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-common.h b/drivers/gpu= /drm/bridge/synopsys/dw-hdmi-common.h index 5fb65db4aaea..512fbaa1bb0c 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-common.h +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-common.h @@ -161,6 +161,8 @@ void dw_hdmi_prep_data(struct dw_hdmi *hdmi, =20 enum drm_connector_status dw_hdmi_connector_detect(struct drm_connector *connector, bool force); +int dw_hdmi_connector_create(struct dw_hdmi *hdmi, + const struct drm_connector_funcs *funcs); =20 int dw_hdmi_bridge_atomic_check(struct drm_bridge *bridge, struct drm_bridge_state *bridge_state, diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/br= idge/synopsys/dw-hdmi.c index d124c781da20..95c9ccb809ec 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c @@ -2469,7 +2469,8 @@ static const struct drm_connector_helper_funcs dw_hdm= i_connector_helper_funcs =3D .atomic_check =3D dw_hdmi_connector_atomic_check, }; =20 -static int dw_hdmi_connector_create(struct dw_hdmi *hdmi) +int dw_hdmi_connector_create(struct dw_hdmi *hdmi, + const struct drm_connector_funcs *funcs) { struct drm_connector *connector =3D &hdmi->connector; struct cec_connector_info conn_info; @@ -2487,7 +2488,7 @@ static int dw_hdmi_connector_create(struct dw_hdmi *h= dmi) drm_connector_helper_add(connector, &dw_hdmi_connector_helper_funcs); =20 drm_connector_init_with_ddc(hdmi->bridge.dev, connector, - &dw_hdmi_connector_funcs, + funcs ? funcs : &dw_hdmi_connector_funcs, DRM_MODE_CONNECTOR_HDMIA, hdmi->ddc); =20 @@ -2516,6 +2517,7 @@ static int dw_hdmi_connector_create(struct dw_hdmi *h= dmi) =20 return 0; } +EXPORT_SYMBOL_GPL(dw_hdmi_connector_create); =20 /* -----------------------------------------------------------------------= ------ * DRM Bridge Operations @@ -2804,7 +2806,7 @@ static int dw_hdmi_bridge_attach(struct drm_bridge *b= ridge, return drm_bridge_attach(bridge->encoder, hdmi->next_bridge, bridge, flags); =20 - return dw_hdmi_connector_create(hdmi); + return dw_hdmi_connector_create(hdmi, NULL); } =20 void dw_hdmi_bridge_detach(struct drm_bridge *bridge) --=20 2.45.0