From nobody Tue Dec 16 22:20:42 2025 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82239180A80 for ; Thu, 30 May 2024 22:46:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717109187; cv=none; b=NdAUkKymr4gH7LIt/yr0boTzfNHl/I0HFoklrFzFMgaJrgPzS/vUnTKUc19ROtfHfpqNSWyR7/PabU4hm7ZtAudbcLNamOLnEuQrnnCJNxxMtbJe6BCByR76bK3G6iJadBBSypYVD5LSiO59xrV5lEFB46MqLYkX/2QCWHwGPKQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717109187; c=relaxed/simple; bh=OHNRIjCt/AbOcKb2xouTeXmLM+pYeA2+sCM+PeZUBHc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aJW+z0zJ1tfF5BCEhSCToXLt2XoujEFjmHoJJMWfaERPapdWAa6OLhZjeJktxPdf9AOmJrFsKhSfhaYyWHcoe2F1iuBTTvOa/jMYkJp+MySKdLzOrt4wbOtmHTEcw2cqL8OC5iYGluqzhvJqMpIzZujC4oSEkbqgp66czia44qw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=kb3Lrb30; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="kb3Lrb30" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1f4a5344ec7so10870395ad.1 for ; Thu, 30 May 2024 15:46:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1717109186; x=1717713986; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UNGi3BaacIMJpkAV5tddhgVoLNe/JGSac2Iso/bclHo=; b=kb3Lrb30Bzxzp4hqWqNBdk2HVDHGurJUy1K2epaQtYVdH3NSQLgbkcZ4rUmblVRjdp wQChU1otXpzX/uRYQ4yYrshdLOI2d6/Il9Gkdbge3kmVAHYtqwwWNcWaR3xTUSzmnSa8 +u7X/etJRzqyqVl1iWIJbm1ShV2NtofjvS0pM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717109186; x=1717713986; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UNGi3BaacIMJpkAV5tddhgVoLNe/JGSac2Iso/bclHo=; b=rXmEv45sMNoJqVDIefqZx74iaNkSfbGx0fM9KmVCUf04Bozaw/sNdHYkQTJgqCd0wO sNLCaw/mCzN7aMk3geqcWJlddBFZhdJqGHV4NfF+jTnjR5UPx76rw3DohsJBcWszFnB6 qUOlss2NaT5GURak2addH6JZvpr+j5KPY4Rnfrs3Kj51a7BrNsD0V1eHBIKGAz37LXo2 6V+G7nWtt09EgOKhA3DAyhhDXEBaDzFMnAqIwk5CsO0ft1BpgQSu/rN8nQr4gIGkmG5Q JR4z0DUo28c4NCcwmtkSsL0MBDeSfhQTFVfDfmDxwEbF/CAJT6O/dFPJRgT4uZqouJ4D L+PA== X-Forwarded-Encrypted: i=1; AJvYcCWfSGDNni3ruIDRUytgbVx6JQhTQ+GsavdI7xsyDz5YmaDdiI0IDejtePSD+jXMHRYuT1wtVKlG0nW2ugywuvhp2cjpcV6qNwEV7a3q X-Gm-Message-State: AOJu0YxxI4aQIi53g7gBS4jjb9TW7Rq4WuoHeB8Y9doaH0Ggxi5lTq5l 6PDPcXbITx6In6VMdFcNsHJEOhBSmc8+l86eAmDalG77VD5fhXF+fXPE+43PUg== X-Google-Smtp-Source: AGHT+IGPRBGVd/Uds8lu/CwCOmUT5FA6Rwai1ahagYPAZWNotAwpSu3qyKimjG2+vC0ln3VA0ZBt+w== X-Received: by 2002:a17:902:c401:b0:1f0:8cbf:c1b5 with SMTP id d9443c01a7336-1f6359c9c78mr3578145ad.16.1717109185878; Thu, 30 May 2024 15:46:25 -0700 (PDT) Received: from dianders.sjc.corp.google.com ([2620:15c:9d:2:564b:72b6:4827:cf6a]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f632410b20sm2955795ad.273.2024.05.30.15.46.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 May 2024 15:46:24 -0700 (PDT) From: Douglas Anderson To: Greg Kroah-Hartman , Jiri Slaby Cc: linux-arm-msm@vger.kernel.org, John Ogness , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Tony Lindgren , Stephen Boyd , linux-serial@vger.kernel.org, Yicong Yang , Johan Hovold , linux-kernel@vger.kernel.org, Bjorn Andersson , Andy Shevchenko , Konrad Dybcio , Douglas Anderson , Rob Herring Subject: [PATCH v2 3/7] serial: qcom-geni: Fix arg types for qcom_geni_serial_poll_bit() Date: Thu, 30 May 2024 15:45:55 -0700 Message-ID: <20240530154553.v2.3.I24a0de52dd7336908df180fa6b698e001f3aff82@changeid> X-Mailer: git-send-email 2.45.1.288.g0e0cd299f1-goog In-Reply-To: <20240530224603.730042-1-dianders@chromium.org> References: <20240530224603.730042-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The "offset" passed in should be unsigned since it's always a positive offset from our memory mapped IO. The "field" should be u32 since we're anding it with a 32-bit value read from the device. Suggested-by: Stephen Boyd Signed-off-by: Douglas Anderson --- Changes in v2: - New drivers/tty/serial/qcom_geni_serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qco= m_geni_serial.c index 32e025705f99..71258eefa654 100644 --- a/drivers/tty/serial/qcom_geni_serial.c +++ b/drivers/tty/serial/qcom_geni_serial.c @@ -266,7 +266,7 @@ static bool qcom_geni_serial_secondary_active(struct ua= rt_port *uport) } =20 static bool qcom_geni_serial_poll_bit(struct uart_port *uport, - int offset, int field, bool set) + unsigned int offset, u32 field, bool set) { u32 reg; struct qcom_geni_serial_port *port; --=20 2.45.1.288.g0e0cd299f1-goog