From nobody Fri Dec 19 01:48:07 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 274F1EEBA; Fri, 31 May 2024 01:03:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717117418; cv=none; b=JJTX/IEmBeVqEPWkIx5+uBranSUeyvhFBnJGgnorC7dAGWTcx5Hy2lZhOWeKvo4QU3r1JAhEafX9lJCST6cKTEAxQhdoIVURLEmqWSMMMhTP30uh0rJ7EhrHRTtMEJIJ966RJmipwnTBhZW+r7rXh7+vQmXc7YttX8e0ovnSH5I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717117418; c=relaxed/simple; bh=TBi8BiVNfed7a3wLohEOqAfZBAjmUXKDQITmxlZkrSQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XXCBw6XTnXkHlqaPU9J7ac3PczKUrbr3vwRzcycw/fQyEa13tGzbs203k6T35NceaoNQ7W7XktFVqwxtvGmURoBZ7zBLGQFeQ25DlToBcmERhrbswRV87lo9TleSmzh3TQwUzW9ttZdioShuwLO4MXUmTQPR3Mvccump6gi7yxc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fbZ2ocmr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fbZ2ocmr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B9C0C32789; Fri, 31 May 2024 01:03:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717117417; bh=TBi8BiVNfed7a3wLohEOqAfZBAjmUXKDQITmxlZkrSQ=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=fbZ2ocmr2pO4+9KIvoZiSh2nbnmh1KrrQTtyfraADcqRxrTVQY+321sjiJHkJsrZL lEJYXiARvf3jrS9etlJJcs1GFhMLaMmDTOUVEKSUxGalp68oymgdtuytqZ1Emrl8bv t+gOvrZhLugtX8itN0wapYNqV5RWmQXzLBwTo30UA2j55Yr0PkARUio0wiJjsrD+BD YhZujCwU+3FIJXVzIoxRPlSpNTALoGHt9sbroGr1jtUAN2NKWRnD5AULcicNKx7C81 DlHe1hEWP9aX5QHWq39mPupaj+BUJ4uDAdAUNm0hXj+DMq5Cp3PnBbSiV8REI5wcx1 rCrT4HiT5wuIg== From: "Rob Herring (Arm)" Date: Thu, 30 May 2024 20:03:28 -0500 Subject: [PATCH 2/3] of: Add missing locking to of_(bus_)?n_(size|addr)_cells() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240530-dt-interrupt-map-fix-v1-2-2331d8732f08@kernel.org> References: <20240530-dt-interrupt-map-fix-v1-0-2331d8732f08@kernel.org> In-Reply-To: <20240530-dt-interrupt-map-fix-v1-0-2331d8732f08@kernel.org> To: Saravana Kannan Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14-dev When accessing parent/child/sibling pointers the DT spinlock needs to be held. The of_(bus_)?n_(size|addr)_cells() functions are missing that when walking up the parent nodes. In reality, it rarely matters as most nodes are static. Signed-off-by: Rob Herring (Arm) --- drivers/of/base.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/of/base.c b/drivers/of/base.c index 20603d3c9931..61fff13bbee5 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -91,8 +91,8 @@ int of_bus_n_addr_cells(struct device_node *np) { u32 cells; =20 - for (; np; np =3D np->parent) - if (!of_property_read_u32(np, "#address-cells", &cells)) + for_each_parent_of_node_scoped(parent, np) + if (!of_property_read_u32(parent, "#address-cells", &cells)) return cells; =20 /* No #address-cells property for the root node */ @@ -101,10 +101,9 @@ int of_bus_n_addr_cells(struct device_node *np) =20 int of_n_addr_cells(struct device_node *np) { - if (np->parent) - np =3D np->parent; + struct device_node *parent __free(device_node) =3D of_get_parent(np); =20 - return of_bus_n_addr_cells(np); + return of_bus_n_addr_cells(parent); } EXPORT_SYMBOL(of_n_addr_cells); =20 @@ -112,8 +111,8 @@ int of_bus_n_size_cells(struct device_node *np) { u32 cells; =20 - for (; np; np =3D np->parent) - if (!of_property_read_u32(np, "#size-cells", &cells)) + for_each_parent_of_node_scoped(parent, np) + if (!of_property_read_u32(parent, "#size-cells", &cells)) return cells; =20 /* No #size-cells property for the root node */ @@ -122,10 +121,9 @@ int of_bus_n_size_cells(struct device_node *np) =20 int of_n_size_cells(struct device_node *np) { - if (np->parent) - np =3D np->parent; + struct device_node *parent __free(device_node) =3D of_get_parent(np); =20 - return of_bus_n_size_cells(np); + return of_bus_n_size_cells(parent); } EXPORT_SYMBOL(of_n_size_cells); =20 --=20 2.43.0