From nobody Tue Dec 16 07:25:52 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90DD515FA8A for ; Wed, 29 May 2024 09:49:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716976141; cv=none; b=C2XhytqG9CJvZTD4aJ3SoaOjjHmBwGnCByqYf0t2ucur6eh+PaQzUEBRFx4FK/ehux5LehNxDWPVIyH45wSJuiKXcFIsDz67JWLLPfI+BHyEOkMqZPGBm1POh6VeRhNLwGuJA/iASxWf/zyiiTeh3ArnFUl9OsobVPtHlctSdCE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716976141; c=relaxed/simple; bh=8ujELDT4/VemDIoPdgqNcPZ20d2mihyif7bauGvChb4=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Ysu0mrARdhFxZaoGiz2ak/jiURttuZrIUTl3OjojM9Srsyjmfyiuioon1zCxU3XMCTdqRD4P7aytPxxG61/Qz5Qmqj/Yatq0qzGwScKJnFixwZkPep4ye5b3WbtPuKd+u96ijWKKm6tzc5YUm8AdeDi3GkeYc4foMRrx7kHw1Rc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Pu0r1WZ4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Pu0r1WZ4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F378C2BD10; Wed, 29 May 2024 09:48:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716976141; bh=8ujELDT4/VemDIoPdgqNcPZ20d2mihyif7bauGvChb4=; h=From:To:Cc:Subject:Date:From; b=Pu0r1WZ4Do3sEl6hi2unaAzAefPeO2N6ZGLfLyHPZ5IR5gM3X/CqxNQuIG6Pu0am8 EViy1WiZ4UFu16Cb7Ath9xrRne03lZByHFZmpb3Pg5XgjjR3KgqGIcy5p5MNtuEFG+ MdNqkvwSWH0k2UeH61WuBgUKDGN6bvN+huPHbKv9ZUg7uPPUXntcjVtjXzViOtbMdw 2y/c2lMV4lXD3jR7B2ArGCkq3QGxBYq108HOgGtXSbIQQHpzpfar92rClsjmMOeVcb 8StLn0mgvthQ/paouX03Dq+A160NZeLRlob+eVRZrIHxL9qv0GClCe0rtxivOrGn8o eHOGkge403M6A== From: Arnd Bergmann To: Lee Jones , Min Li Cc: Arnd Bergmann , Charles Keepax , Okan Sahin , Andy Shevchenko , linux-kernel@vger.kernel.org Subject: [PATCH] mfd: rsmu: split core code into separate module Date: Wed, 29 May 2024 11:48:47 +0200 Message-Id: <20240529094856.1869543-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann Linking a file into two modules can have unintended side-effects and produces a W=3D1 warning: scripts/Makefile.build:236: drivers/mfd/Makefile: rsmu_core.o is added to m= ultiple modules: rsmu-i2c rsmu-spi Make this one a separate module instead. Fixes: a1867f85e06e ("mfd: Add Renesas Synchronization Management Unit (SMU= ) support") Signed-off-by: Arnd Bergmann --- drivers/mfd/Makefile | 6 ++---- drivers/mfd/rsmu_core.c | 2 ++ 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile index c66f07edcd0e..db1ba39de3b5 100644 --- a/drivers/mfd/Makefile +++ b/drivers/mfd/Makefile @@ -280,7 +280,5 @@ obj-$(CONFIG_MFD_INTEL_M10_BMC_PMCI) +=3D intel-m10-b= mc-pmci.o obj-$(CONFIG_MFD_ATC260X) +=3D atc260x-core.o obj-$(CONFIG_MFD_ATC260X_I2C) +=3D atc260x-i2c.o =20 -rsmu-i2c-objs :=3D rsmu_core.o rsmu_i2c.o -rsmu-spi-objs :=3D rsmu_core.o rsmu_spi.o -obj-$(CONFIG_MFD_RSMU_I2C) +=3D rsmu-i2c.o -obj-$(CONFIG_MFD_RSMU_SPI) +=3D rsmu-spi.o +obj-$(CONFIG_MFD_RSMU_I2C) +=3D rsmu_i2c.o rsmu_core.o +obj-$(CONFIG_MFD_RSMU_SPI) +=3D rsmu_spi.o rsmu_core.o diff --git a/drivers/mfd/rsmu_core.c b/drivers/mfd/rsmu_core.c index 29437fd0bd5b..fd04a6e5dfa3 100644 --- a/drivers/mfd/rsmu_core.c +++ b/drivers/mfd/rsmu_core.c @@ -78,11 +78,13 @@ int rsmu_core_init(struct rsmu_ddata *rsmu) =20 return ret; } +EXPORT_SYMBOL_GPL(rsmu_core_init); =20 void rsmu_core_exit(struct rsmu_ddata *rsmu) { mutex_destroy(&rsmu->lock); } +EXPORT_SYMBOL_GPL(rsmu_core_exit); =20 MODULE_DESCRIPTION("Renesas SMU core driver"); MODULE_LICENSE("GPL"); --=20 2.39.2