From nobody Fri Dec 19 19:40:18 2025 Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B7A91391 for ; Wed, 29 May 2024 03:20:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716952850; cv=none; b=dP0selCBdSovOe53Q9in6JuKv+GpcQ0YxMT3eQmles8Wd+8Lo6SRwyp/tINBHUsHgX/CStU/D/peI8Op+B0ddebTYVMNYSYNKaom+IE/0RzKIbotdmstusx5jZdTF2eoTrmYVBAkP51MQOmMihUaPLFVdEb2hSkcau0mu0CmR3U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716952850; c=relaxed/simple; bh=BVpS8rKD6cvn1sPKzxoaeISlmBMwAbkMpGgmUZ9C45g=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ng3VUu3sHYNuwYrR+HrqwORH7qYj2rqyJnnDfjTgP1GA/qKZZjncelnpInTavNihuKpyeMBhaB2d4qTHKaWYQ47cMJJgWXic5mv60lq12FqOGDXStig+YS8ZxybgATP8kV/ndkEvt876jD0AE3HhMvK23A6rpvrP4KFohd7sToE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com; spf=pass smtp.mailfrom=fastly.com; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b=Dn4myONj; arc=none smtp.client-ip=209.85.167.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastly.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b="Dn4myONj" Received: by mail-oi1-f170.google.com with SMTP id 5614622812f47-3d19dfb3dceso835321b6e.1 for ; Tue, 28 May 2024 20:20:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1716952848; x=1717557648; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5WirfrVmj6xSxuzh+j2j6GMDFSD8Lc9FPWQtGaC4uG4=; b=Dn4myONjX3wib2nS25vRddz2OQ9sEn/AFE7s5KC/oiSSncEUrRZTMZnWcxCpYtdn1n G1yCWxRtFWFxWfub+l0qqVsc/VdYClK1o3cR5ItSU8Qc8hXxs8V9GbUfIOuTJeKt47U6 sTqkMTCqH/qrtphC/10aU9YCLX+z0qusLaU58= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716952848; x=1717557648; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5WirfrVmj6xSxuzh+j2j6GMDFSD8Lc9FPWQtGaC4uG4=; b=V5ljDU3UrPejF3iI4CFRFr+MyS5VnyLBoJjmVNSN1WeVoRaSbrrsQjfv6IJ19hFIaK sHCrOLOHp5+Zr4UXxMIMHhEn4Ze6mwgxqbEDqaKlKQJHSA91gd2zguoj5TBGeZB11A3g d/zx1DiOcmx+2rzY1hRbfDg56pzeUe8YQ50YSpcrZ6mucE4vJuRSI8rex6aQFCfVBkMV GHxa9zFpwhioq0J4BbjEbgly5XrhZqembsHXNFJzXS5eBp6nxVpIFx+UP94JqSCxWXg/ bQfREMybGtqFKhBRWCv5f8wekBYumUknmZeMcaBcam34bfwOvvpyxby7bhqurfS0huXc uLaQ== X-Gm-Message-State: AOJu0YwSieYwRQJzsAyXwQ3eTxo7CY7BytG40t2SAzH+6yAoh10Vq97L GW11rRhor/KkKxDVpVoXPH/rUbiEIBO9hTd9OJP7Hk7NYcDBrjcaJyTKEQKQP09I+e+dWkOy+fF sdUZLIyPJj7baedvytge5gTYWM7AC9Yikc7btF2Kdgc8X9zquDXql40i1TOSwr8sudN7PwenbVh 7Q+QAD6mgUR0iVoSFLZrQ58Bj0XejWzokBfzjdYiwy8WY= X-Google-Smtp-Source: AGHT+IHH9sy0SpZ3yb1feGf+fkpJAxcwJ0SYOomfUNtQqmdNd7SYvKLISg1dP1EawRO3hGcKzr9hBg== X-Received: by 2002:a05:6808:13c3:b0:3c9:92f3:d519 with SMTP id 5614622812f47-3d1a6019c51mr17456943b6e.4.1716952847979; Tue, 28 May 2024 20:20:47 -0700 (PDT) Received: from localhost.localdomain ([2620:11a:c019:0:65e:3115:2f58:c5fd]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-6f8fbd3ea03sm7156766b3a.39.2024.05.28.20.20.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 May 2024 20:20:47 -0700 (PDT) From: Joe Damato To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Cc: nalramli@fastly.com, Joe Damato , Saeed Mahameed , Tariq Toukan , Leon Romanovsky , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-rdma@vger.kernel.org (open list:MELLANOX MLX5 core VPI driver) Subject: [RFC net-next v3 1/2] net/mlx5e: Add helpers to calculate txq and ch idx Date: Wed, 29 May 2024 03:16:26 +0000 Message-Id: <20240529031628.324117-2-jdamato@fastly.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240529031628.324117-1-jdamato@fastly.com> References: <20240529031628.324117-1-jdamato@fastly.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add two helpers to: 1. Compute the txq_ix given a channel and a tc offset (tc_to_txq_ix). 2. Compute the channel index and tc offset given a txq_ix (txq_ix_to_chtc_ix). The first helper, tc_to_txq_ix, is used in place of the mathematical expressionin mlx5e_open_sqs when txq_ix values are computed. The second helper, txq_ix_to_chtc_ix, will be used in a following patch. Signed-off-by: Joe Damato Reviewed-by: Jacob Keller --- .../net/ethernet/mellanox/mlx5/core/en_main.c | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/ne= t/ethernet/mellanox/mlx5/core/en_main.c index b758bc72ac36..ce15805ad55a 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c @@ -2312,6 +2312,22 @@ static int mlx5e_txq_get_qos_node_hw_id(struct mlx5e= _params *params, int txq_ix, return 0; } =20 +static inline int tc_to_txq_ix(struct mlx5e_channel *c, + struct mlx5e_params *params, + int tc) +{ + return c->ix + tc * params->num_channels; +} + +static inline void txq_ix_to_chtc_ix(struct mlx5e_params *params, int txq_= ix, + int *ch_ix, int *tc_ix) +{ + if (params->num_channels) { + *ch_ix =3D txq_ix % params->num_channels; + *tc_ix =3D txq_ix / params->num_channels; + } +} + static int mlx5e_open_sqs(struct mlx5e_channel *c, struct mlx5e_params *params, struct mlx5e_channel_param *cparam) @@ -2319,7 +2335,7 @@ static int mlx5e_open_sqs(struct mlx5e_channel *c, int err, tc; =20 for (tc =3D 0; tc < mlx5e_get_dcb_num_tc(params); tc++) { - int txq_ix =3D c->ix + tc * params->num_channels; + int txq_ix =3D tc_to_txq_ix(c, params, tc); u32 qos_queue_group_id; u32 tisn; =20 --=20 2.25.1 From nobody Fri Dec 19 19:40:18 2025 Received: from mail-oi1-f175.google.com (mail-oi1-f175.google.com [209.85.167.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5A8115B54F for ; Wed, 29 May 2024 03:20:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716952853; cv=none; b=slLS4ubDWmyxydXb2y7ljEWaciHif9795Lf5tlZvl3F2T4eS32sowBztQ3Lqzm5pBZHik0HDnnviALCSef9kKYtOfNOwVP7l5QZFBqpYfcReewGMRRNGBSqHm45GbU9QRernLtE6QejOeqEdXFOSlW0/WlCDptah46H5PKC/8YY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716952853; c=relaxed/simple; bh=ngrgWoSn3dkOnzAYRsmf183bsxtu9OpYrpfalp4oSyM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Wt9yCX5hB71cG78zdCX8GxRfomjLNuXmehdup+yYjX/otcv9A38di3KarSPicwENOif0mzG6W4XwnEh1UHB5hkAIY1XSVlpHL7H6xRV4i29Drzy5dp6Ni2SWygd5J+rFeF3sxFgjeLQnEh6vRQWKhPUmJL/0Adw49Jya7dPgN1Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com; spf=pass smtp.mailfrom=fastly.com; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b=jQWVaHQq; arc=none smtp.client-ip=209.85.167.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastly.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b="jQWVaHQq" Received: by mail-oi1-f175.google.com with SMTP id 5614622812f47-3c9cc681ee0so748802b6e.0 for ; Tue, 28 May 2024 20:20:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1716952850; x=1717557650; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=J0LUNrAmj3v5i6Z8gYuVk/e8D51N4ShDxOcIG47i78U=; b=jQWVaHQqLdGjoo50QZA81JQ8bG0AF3OxBR8OmY4JnLZiWRELbhNRwILISsUIV/T+/C E/n7DZ/+1EJSGpCZVLvzXm7JLWjdHNwOperqlNyMdOuTvbguvbMRi+PZzRhN8tHBVIoC ycpScZk2O5JRdzpwqmMq91KTTwYcHRH6AT+PI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716952850; x=1717557650; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J0LUNrAmj3v5i6Z8gYuVk/e8D51N4ShDxOcIG47i78U=; b=gnpAUPCCERsF2rdNr07x7PNaQ/kL/u1w+W5mrDKFqkceAOJnbHehKNo6hAPKAxsVxx tm/is0j6rFaWLXrOlBlPS6sTUPXFMNf7KvfhIlH2JtUmlC43dxXvWdpebBfaNGeOmoPu kkmr/CwY/tgjKOE68m6vYtwjEax0MxyQVo01QW7pm0Y2UrPLqYzuawrcJ5IUbBwIlKZg fRvHq5EDowAoIWpd3LUBarYsMsSN/WYhlWhnMaZeNUNc/ExvjoiZqr8thnHqwdkEgHDc XT8FoNQ/KhFEAX4g1cBDYtRlybZDHBvwHU/acQDBvHVC4WD/ThSqziyFw1Ivczygzf3O ALbQ== X-Gm-Message-State: AOJu0YwXiRdgLOIzlYrGRrnwlLord4FjNXjinma23FmnIUEVBHl6YoNX a1BkAuGysK3mkkiZiTDFpHjyIhsU+tBgXENZsccsz9l9GGjJFKvYWOpRfX+HQA3uMRKKBye3rpe hrKKS5kHqV1o79o3UJM3KYeJbCzFSHmnSrzRMajFa282+TPEmp1wV4bdADvn/82IdjqhHA0pJ1w eLX41b8nC6BuM0e41uCpKfeMpLz8RNRVXxWUApNvOp4Ac= X-Google-Smtp-Source: AGHT+IF75C9u7f1pbiCwVZLhWlBLJ3alIuJgKnuDVZBCwa68S0caQmXZ+PKHwtGllBRjmWhuiFSbRg== X-Received: by 2002:a05:6808:205:b0:3c8:6543:584b with SMTP id 5614622812f47-3d1a7d27b10mr15151160b6e.54.1716952849895; Tue, 28 May 2024 20:20:49 -0700 (PDT) Received: from localhost.localdomain ([2620:11a:c019:0:65e:3115:2f58:c5fd]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-6f8fbd3ea03sm7156766b3a.39.2024.05.28.20.20.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 May 2024 20:20:49 -0700 (PDT) From: Joe Damato To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Cc: nalramli@fastly.com, Joe Damato , Saeed Mahameed , Tariq Toukan , Leon Romanovsky , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Richard Cochran , linux-rdma@vger.kernel.org (open list:MELLANOX MLX5 core VPI driver) Subject: [RFC net-next v3 2/2] net/mlx5e: Add per queue netdev-genl stats Date: Wed, 29 May 2024 03:16:27 +0000 Message-Id: <20240529031628.324117-3-jdamato@fastly.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240529031628.324117-1-jdamato@fastly.com> References: <20240529031628.324117-1-jdamato@fastly.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add functions to support the netdev-genl per queue stats API. ./cli.py --spec netlink/specs/netdev.yaml \ --dump qstats-get --json '{"scope": "queue"}' ...snip {'ifindex': 7, 'queue-id': 62, 'queue-type': 'rx', 'rx-alloc-fail': 0, 'rx-bytes': 105965251, 'rx-packets': 179790}, {'ifindex': 7, 'queue-id': 0, 'queue-type': 'tx', 'tx-bytes': 9402665, 'tx-packets': 17551}, ...snip Also tested with the script tools/testing/selftests/drivers/net/stats.py in several scenarios to ensure stats tallying was correct: - on boot (default queue counts) - adjusting queue count up or down (ethtool -L eth0 combined ...) - adding mqprio TCs Signed-off-by: Joe Damato Reviewed-by: Jacob Keller --- .../net/ethernet/mellanox/mlx5/core/en_main.c | 132 ++++++++++++++++++ 1 file changed, 132 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/ne= t/ethernet/mellanox/mlx5/core/en_main.c index ce15805ad55a..515c16a88a6c 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c @@ -39,6 +39,7 @@ #include #include #include +#include #include #include #include @@ -5293,6 +5294,136 @@ static bool mlx5e_tunnel_any_tx_proto_supported(str= uct mlx5_core_dev *mdev) return (mlx5_vxlan_allowed(mdev->vxlan) || mlx5_geneve_tx_allowed(mdev)); } =20 +static void mlx5e_get_queue_stats_rx(struct net_device *dev, int i, + struct netdev_queue_stats_rx *stats) +{ + struct mlx5e_priv *priv =3D netdev_priv(dev); + struct mlx5e_channel_stats *channel_stats; + struct mlx5e_rq_stats *xskrq_stats; + struct mlx5e_rq_stats *rq_stats; + + if (mlx5e_is_uplink_rep(priv)) + return; + + channel_stats =3D priv->channel_stats[i]; + xskrq_stats =3D &channel_stats->xskrq; + rq_stats =3D &channel_stats->rq; + + stats->packets =3D rq_stats->packets + xskrq_stats->packets; + stats->bytes =3D rq_stats->bytes + xskrq_stats->bytes; + stats->alloc_fail =3D rq_stats->buff_alloc_err + + xskrq_stats->buff_alloc_err; +} + +static void mlx5e_get_queue_stats_tx(struct net_device *dev, int i, + struct netdev_queue_stats_tx *stats) +{ + struct mlx5e_priv *priv =3D netdev_priv(dev); + struct mlx5e_channel_stats *channel_stats; + struct mlx5e_sq_stats *sq_stats; + int ch_ix, tc_ix; + + mutex_lock(&priv->state_lock); + txq_ix_to_chtc_ix(&priv->channels.params, i, &ch_ix, &tc_ix); + mutex_unlock(&priv->state_lock); + + channel_stats =3D priv->channel_stats[ch_ix]; + sq_stats =3D &channel_stats->sq[tc_ix]; + + stats->packets =3D sq_stats->packets; + stats->bytes =3D sq_stats->bytes; +} + +static void mlx5e_get_base_stats(struct net_device *dev, + struct netdev_queue_stats_rx *rx, + struct netdev_queue_stats_tx *tx) +{ + struct mlx5e_priv *priv =3D netdev_priv(dev); + int i, j; + + if (!mlx5e_is_uplink_rep(priv)) { + rx->packets =3D 0; + rx->bytes =3D 0; + rx->alloc_fail =3D 0; + + /* compute stats for deactivated RX queues + * + * if priv->channels.num =3D=3D 0 the device is down, so compute + * stats for every queue. + * + * otherwise, compute only the queues which have been deactivated. + */ + mutex_lock(&priv->state_lock); + if (priv->channels.num =3D=3D 0) + i =3D 0; + else + i =3D priv->channels.params.num_channels; + mutex_unlock(&priv->state_lock); + + for (; i < priv->stats_nch; i++) { + struct netdev_queue_stats_rx rx_i =3D {0}; + + mlx5e_get_queue_stats_rx(dev, i, &rx_i); + + rx->packets +=3D rx_i.packets; + rx->bytes +=3D rx_i.bytes; + rx->alloc_fail +=3D rx_i.alloc_fail; + } + + if (priv->rx_ptp_opened) { + struct mlx5e_rq_stats *rq_stats =3D &priv->ptp_stats.rq; + + rx->packets +=3D rq_stats->packets; + rx->bytes +=3D rq_stats->bytes; + } + } + + tx->packets =3D 0; + tx->bytes =3D 0; + + mutex_lock(&priv->state_lock); + for (i =3D 0; i < priv->stats_nch; i++) { + struct mlx5e_channel_stats *channel_stats =3D priv->channel_stats[i]; + + /* while iterating through all channels [0, stats_nch], there + * are two cases to handle: + * + * 1. the channel is available, so sum only the unavailable TCs + * [mlx5e_get_dcb_num_tc, max_opened_tc). + * + * 2. the channel is unavailable, so sum all TCs [0, max_opened_tc). + */ + if (i < priv->channels.params.num_channels) { + j =3D mlx5e_get_dcb_num_tc(&priv->channels.params); + } else { + j =3D 0; + } + + for (; j < priv->max_opened_tc; j++) { + struct mlx5e_sq_stats *sq_stats =3D &channel_stats->sq[j]; + + tx->packets +=3D sq_stats->packets; + tx->bytes +=3D sq_stats->bytes; + } + } + mutex_unlock(&priv->state_lock); + + if (priv->tx_ptp_opened) { + for (j =3D 0; j < priv->max_opened_tc; j++) { + struct mlx5e_sq_stats *sq_stats =3D &priv->ptp_stats.sq[j]; + + tx->packets +=3D sq_stats->packets; + tx->bytes +=3D sq_stats->bytes; + } + } +} + +static const struct netdev_stat_ops mlx5e_stat_ops =3D { + .get_queue_stats_rx =3D mlx5e_get_queue_stats_rx, + .get_queue_stats_tx =3D mlx5e_get_queue_stats_tx, + .get_base_stats =3D mlx5e_get_base_stats, +}; + static void mlx5e_build_nic_netdev(struct net_device *netdev) { struct mlx5e_priv *priv =3D netdev_priv(netdev); @@ -5310,6 +5441,7 @@ static void mlx5e_build_nic_netdev(struct net_device = *netdev) =20 netdev->watchdog_timeo =3D 15 * HZ; =20 + netdev->stat_ops =3D &mlx5e_stat_ops; netdev->ethtool_ops =3D &mlx5e_ethtool_ops; =20 netdev->vlan_features |=3D NETIF_F_SG; --=20 2.25.1