From nobody Fri Feb 13 14:59:09 2026 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB0832905 for ; Sun, 26 May 2024 11:20:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716722447; cv=none; b=jiV05ZFi826JYWwi9kb4Kc9xcS3a/Bwf/jwsdiHGiTTtI6GhC9PNkd44YEVik0xZxj15i4XOPNs1O/Bvsq2LfdCQNUA9AYgh954DNQKSiirRkzVMn99V4B3YaXudMJUVVee+UB8PApieW9eaqDE6tGx/z4Aefn0fr1a0tNBIZUA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716722447; c=relaxed/simple; bh=4nW91lsMoRhISbgOyFITvMo+Qsc6DiQN/rZt8bOa+/E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jdW/HeO8QNmc6NdiG9LVBY42KzcCzXjspx8QI6gZ54HBWRvQFV91ZSR1KdGwh+58X14ws8n1RvnDonwLGkeIEfex1j3ykJJmS/wG7iatXeR+wYvmt3TyZve1IViBFJiT9o8BgDlkB/Jyuq7ZzAuNm99QqPt4W6w8695PvKkFeCg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GS7D0xIS; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GS7D0xIS" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-a6265d48ec3so246504266b.0 for ; Sun, 26 May 2024 04:20:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716722444; x=1717327244; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=syZ0Cd4s3FznpGYw+gPuAARyriAcDeWsVaK2kx6TUGw=; b=GS7D0xIS36srUq/KYHzcZI70KqoRg1RP3035hHm/lsIAgD1sP7Db7TZvhVndc+5vjd 5Uwsy8uUTYT3EolfU6a1ypCJNAK1EXP3va0kgzQz8eqeiX3i/B8RdJ5AS6/7ar3uYR6I GV/2lYPNh8JUa1s5L9eAQ72ITftjOJsrEMOnfdVqBqmpSVHFjBI1onehjMoxnD+vPvAR eYHL9PZgRdUtnXmm7ey6NdHt1iBKdVqnu00Kx6rXh2ZK1ExhJ9IByXMwcMyz1CUFem9L 1vGRBft31OmgzGltdO8/axJ+uzCX5YTHM7Z0Ah1Qi5MORQ73IhimtVQG283rBbAH10nT bTUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716722444; x=1717327244; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=syZ0Cd4s3FznpGYw+gPuAARyriAcDeWsVaK2kx6TUGw=; b=Qk1xPrBtmDHFACLBX8MDaX9Rjl1dkm6n0crbItvcgNQhP5t/WAswcxQ6uZXrCBvflg ciw9vbLZbj3wkR3wF2Ek9kkHbJFCbfnAnL8JtYWmun9DiCWG5qR0C0YbsMU5FAc/zCMQ zQFTAjsSBHo0ExlAcE0WGYFFCXjUPgYHlCGPOS3hsuaAYcly1y3yBuBPUmCksynl7kxK w443z2o9opAkCQw8D9+KbpH9GZDgeg7VHD7/htbB5s4kGWshar926X/axlQZ+bXu9YNM mPnI55nI/GrUrM+CGlecnYlMWes3N9kZH3QMHGBfVH2WKx8HWG/Gk6OhT8ypbVdx1/Xz yJlg== X-Forwarded-Encrypted: i=1; AJvYcCWTwVtig2zd1iDJzf1JB50MjoEgwepAWXJbVb9cHWKbPp3Qy51txb3BlzwOKvO9AvGuj9oFkOFolzMtAybW/U/jpzzvp2RiWAtyBoj9 X-Gm-Message-State: AOJu0YxFUZ1DynWm+ySmlTOz5Wm30A38HLTi+ZJYZ4ETUUhBCiOjCGL+ 2XUPDojR2ytCQ/y/rTJ69By+zvDK0VhstfKXbN+NT+enhGZuPwve X-Google-Smtp-Source: AGHT+IGC7ii5g3GCI9INcE+djtsNq7KWXcdyct1Hk/1N95YMi7CDZgYjH+PyQBKl+G9MfHEBZp4hNw== X-Received: by 2002:a17:906:c217:b0:a62:2ef9:139 with SMTP id a640c23a62f3a-a6262f5c244mr441785666b.0.1716722444087; Sun, 26 May 2024 04:20:44 -0700 (PDT) Received: from localhost.localdomain (ip-77-25-34-87.web.vodafone.de. [77.25.34.87]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a626cc8e534sm373983366b.170.2024.05.26.04.20.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 May 2024 04:20:43 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: philipp.g.hortmann@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 1/3] staging: rtl8192e: reduce indentation level Date: Sun, 26 May 2024 13:19:26 +0200 Message-ID: <20240526111928.14574-2-straube.linux@gmail.com> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240526111928.14574-1-straube.linux@gmail.com> References: <20240526111928.14574-1-straube.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Reduce indentation level in _rtl92e_dm_rx_path_sel_byrssi() by negating if statements and use continue in for loops. This way the indentation level of the code that is covered by the if checks can be reduced. This improves readability and clears two checkpatch warnings. WARNING: Too many leading tabs - consider code refactoring Signed-off-by: Michael Straube Reviewed-by: Nam Cao --- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 170 +++++++++++---------- 1 file changed, 86 insertions(+), 84 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/r= tl8192e/rtl8192e/rtl_dm.c index aebe67f1a46d..2fda44c5a412 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c @@ -1335,51 +1335,52 @@ static void _rtl92e_dm_rx_path_sel_byrssi(struct ne= t_device *dev) for (i =3D 0; i < RF90_PATH_MAX; i++) { dm_rx_path_sel_table.rf_rssi[i] =3D priv->stats.rx_rssi_percentage[i]; =20 - if (priv->brfpath_rxenable[i]) { - rf_num++; - cur_rf_rssi =3D dm_rx_path_sel_table.rf_rssi[i]; - - if (rf_num =3D=3D 1) { - max_rssi_index =3D min_rssi_index =3D sec_rssi_index =3D i; - tmp_max_rssi =3D tmp_min_rssi =3D tmp_sec_rssi =3D cur_rf_rssi; - } else if (rf_num =3D=3D 2) { - if (cur_rf_rssi >=3D tmp_max_rssi) { - tmp_max_rssi =3D cur_rf_rssi; - max_rssi_index =3D i; - } else { - tmp_sec_rssi =3D tmp_min_rssi =3D cur_rf_rssi; - sec_rssi_index =3D min_rssi_index =3D i; - } + if (!priv->brfpath_rxenable[i]) + continue; + + rf_num++; + cur_rf_rssi =3D dm_rx_path_sel_table.rf_rssi[i]; + + if (rf_num =3D=3D 1) { + max_rssi_index =3D min_rssi_index =3D sec_rssi_index =3D i; + tmp_max_rssi =3D tmp_min_rssi =3D tmp_sec_rssi =3D cur_rf_rssi; + } else if (rf_num =3D=3D 2) { + if (cur_rf_rssi >=3D tmp_max_rssi) { + tmp_max_rssi =3D cur_rf_rssi; + max_rssi_index =3D i; } else { - if (cur_rf_rssi > tmp_max_rssi) { - tmp_sec_rssi =3D tmp_max_rssi; - sec_rssi_index =3D max_rssi_index; - tmp_max_rssi =3D cur_rf_rssi; - max_rssi_index =3D i; - } else if (cur_rf_rssi =3D=3D tmp_max_rssi) { - tmp_sec_rssi =3D cur_rf_rssi; - sec_rssi_index =3D i; - } else if ((cur_rf_rssi < tmp_max_rssi) && - (cur_rf_rssi > tmp_sec_rssi)) { + tmp_sec_rssi =3D tmp_min_rssi =3D cur_rf_rssi; + sec_rssi_index =3D min_rssi_index =3D i; + } + } else { + if (cur_rf_rssi > tmp_max_rssi) { + tmp_sec_rssi =3D tmp_max_rssi; + sec_rssi_index =3D max_rssi_index; + tmp_max_rssi =3D cur_rf_rssi; + max_rssi_index =3D i; + } else if (cur_rf_rssi =3D=3D tmp_max_rssi) { + tmp_sec_rssi =3D cur_rf_rssi; + sec_rssi_index =3D i; + } else if ((cur_rf_rssi < tmp_max_rssi) && + (cur_rf_rssi > tmp_sec_rssi)) { + tmp_sec_rssi =3D cur_rf_rssi; + sec_rssi_index =3D i; + } else if (cur_rf_rssi =3D=3D tmp_sec_rssi) { + if (tmp_sec_rssi =3D=3D tmp_min_rssi) { tmp_sec_rssi =3D cur_rf_rssi; sec_rssi_index =3D i; - } else if (cur_rf_rssi =3D=3D tmp_sec_rssi) { - if (tmp_sec_rssi =3D=3D tmp_min_rssi) { - tmp_sec_rssi =3D cur_rf_rssi; - sec_rssi_index =3D i; - } - } else if ((cur_rf_rssi < tmp_sec_rssi) && - (cur_rf_rssi > tmp_min_rssi)) { - ; - } else if (cur_rf_rssi =3D=3D tmp_min_rssi) { - if (tmp_sec_rssi =3D=3D tmp_min_rssi) { - tmp_min_rssi =3D cur_rf_rssi; - min_rssi_index =3D i; - } - } else if (cur_rf_rssi < tmp_min_rssi) { + } + } else if ((cur_rf_rssi < tmp_sec_rssi) && + (cur_rf_rssi > tmp_min_rssi)) { + ; + } else if (cur_rf_rssi =3D=3D tmp_min_rssi) { + if (tmp_sec_rssi =3D=3D tmp_min_rssi) { tmp_min_rssi =3D cur_rf_rssi; min_rssi_index =3D i; } + } else if (cur_rf_rssi < tmp_min_rssi) { + tmp_min_rssi =3D cur_rf_rssi; + min_rssi_index =3D i; } } } @@ -1387,59 +1388,60 @@ static void _rtl92e_dm_rx_path_sel_byrssi(struct ne= t_device *dev) rf_num =3D 0; if (dm_rx_path_sel_table.cck_method =3D=3D CCK_Rx_Version_2) { for (i =3D 0; i < RF90_PATH_MAX; i++) { - if (priv->brfpath_rxenable[i]) { - rf_num++; - cur_cck_pwdb =3D - dm_rx_path_sel_table.cck_pwdb_sta[i]; + if (!priv->brfpath_rxenable[i]) + continue; =20 - if (rf_num =3D=3D 1) { + rf_num++; + cur_cck_pwdb =3D + dm_rx_path_sel_table.cck_pwdb_sta[i]; + + if (rf_num =3D=3D 1) { + cck_rx_ver2_max_index =3D i; + cck_rx_ver2_sec_index =3D i; + tmp_cck_max_pwdb =3D cur_cck_pwdb; + tmp_cck_min_pwdb =3D cur_cck_pwdb; + tmp_cck_sec_pwdb =3D cur_cck_pwdb; + } else if (rf_num =3D=3D 2) { + if (cur_cck_pwdb >=3D tmp_cck_max_pwdb) { + tmp_cck_max_pwdb =3D cur_cck_pwdb; cck_rx_ver2_max_index =3D i; + } else { + tmp_cck_sec_pwdb =3D cur_cck_pwdb; + tmp_cck_min_pwdb =3D cur_cck_pwdb; cck_rx_ver2_sec_index =3D i; + } + } else { + if (cur_cck_pwdb > tmp_cck_max_pwdb) { + tmp_cck_sec_pwdb =3D + tmp_cck_max_pwdb; + cck_rx_ver2_sec_index =3D + cck_rx_ver2_max_index; tmp_cck_max_pwdb =3D cur_cck_pwdb; - tmp_cck_min_pwdb =3D cur_cck_pwdb; + cck_rx_ver2_max_index =3D i; + } else if (cur_cck_pwdb =3D=3D + tmp_cck_max_pwdb) { tmp_cck_sec_pwdb =3D cur_cck_pwdb; - } else if (rf_num =3D=3D 2) { - if (cur_cck_pwdb >=3D tmp_cck_max_pwdb) { - tmp_cck_max_pwdb =3D cur_cck_pwdb; - cck_rx_ver2_max_index =3D i; - } else { - tmp_cck_sec_pwdb =3D cur_cck_pwdb; - tmp_cck_min_pwdb =3D cur_cck_pwdb; - cck_rx_ver2_sec_index =3D i; - } - } else { - if (cur_cck_pwdb > tmp_cck_max_pwdb) { + cck_rx_ver2_sec_index =3D i; + } else if (PWDB_IN_RANGE) { + tmp_cck_sec_pwdb =3D cur_cck_pwdb; + cck_rx_ver2_sec_index =3D i; + } else if (cur_cck_pwdb =3D=3D + tmp_cck_sec_pwdb) { + if (tmp_cck_sec_pwdb =3D=3D + tmp_cck_min_pwdb) { tmp_cck_sec_pwdb =3D - tmp_cck_max_pwdb; + cur_cck_pwdb; cck_rx_ver2_sec_index =3D - cck_rx_ver2_max_index; - tmp_cck_max_pwdb =3D cur_cck_pwdb; - cck_rx_ver2_max_index =3D i; - } else if (cur_cck_pwdb =3D=3D - tmp_cck_max_pwdb) { - tmp_cck_sec_pwdb =3D cur_cck_pwdb; - cck_rx_ver2_sec_index =3D i; - } else if (PWDB_IN_RANGE) { - tmp_cck_sec_pwdb =3D cur_cck_pwdb; - cck_rx_ver2_sec_index =3D i; - } else if (cur_cck_pwdb =3D=3D - tmp_cck_sec_pwdb) { - if (tmp_cck_sec_pwdb =3D=3D - tmp_cck_min_pwdb) { - tmp_cck_sec_pwdb =3D - cur_cck_pwdb; - cck_rx_ver2_sec_index =3D - i; - } - } else if ((cur_cck_pwdb < tmp_cck_sec_pwdb) && - (cur_cck_pwdb > tmp_cck_min_pwdb)) { - ; - } else if (cur_cck_pwdb =3D=3D tmp_cck_min_pwdb) { - if (tmp_cck_sec_pwdb =3D=3D tmp_cck_min_pwdb) - tmp_cck_min_pwdb =3D cur_cck_pwdb; - } else if (cur_cck_pwdb < tmp_cck_min_pwdb) { - tmp_cck_min_pwdb =3D cur_cck_pwdb; + i; } + } else if ((cur_cck_pwdb < tmp_cck_sec_pwdb) && + (cur_cck_pwdb > tmp_cck_min_pwdb)) { + ; + } else if (cur_cck_pwdb =3D=3D tmp_cck_min_pwdb) { + if (tmp_cck_sec_pwdb =3D=3D tmp_cck_min_pwdb) + tmp_cck_min_pwdb =3D cur_cck_pwdb; + } else if (cur_cck_pwdb < tmp_cck_min_pwdb) { + tmp_cck_min_pwdb =3D cur_cck_pwdb; } } } --=20 2.45.1 From nobody Fri Feb 13 14:59:09 2026 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72A03B669 for ; Sun, 26 May 2024 11:20:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716722448; cv=none; b=GGzE+q3atu0OtRxktGLNHaIStocYGYxNOqT4M8KBTRRc/506qfRzpg7CjWqRMgWhV48dpJnJ/QbG7rwnUj2n0ZfWG6S0EuVhLwXGEHQZQEC2sYRbDqHGEUM5o+V21nN0S1tWAR3UqXn7/v1X/w2+v5tPs0bNYog3h+yJCzghyc8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716722448; c=relaxed/simple; bh=2KJRg3rxgw4WdUGj6+yaSTtcYpu9GqNWKKviyIlmQEI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LhoPT9GoVq8lywm5XaqgHAJid8jKd8vHX4gkR+B6sxz8bSxXVuZBqlIrhJJ58xRKHWbSI/wdWTXHt6ARD0lwpETvofbp2FvMEcrIGl8A2jHg3Ege0irtgIFdv69vL8KP0FLlZxiYC/ZYNPvos7nXM7AIFdSVYM/t3/EiHwbzdSo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gxcUNGHc; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gxcUNGHc" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-a62614b9ae1so308936666b.0 for ; Sun, 26 May 2024 04:20:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716722445; x=1717327245; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8IWKpCZ28tVsNAru3OI66zH7hDNq0tpB9AZz0FdEa4s=; b=gxcUNGHc4WAv+aPGBy83iM1r8sTfPUFf7W0oli8ZQllmSh6Bs9RBfruYQa2UppZWI2 H4sAn+8ICIZqeMSZGNmyw+BqQCrqye+nLJXIDehsc8sSdDukKTVwzT5W9ZfFaZcJemB/ bR0C40Ar5zbdg146TTMyBvMRlhn6uZhv7O0W2OoaLP8Mas9VPXIlN4suzLDDIf1J2lLg 60FtQK49aR4+eaOyESMlhpngPTdr3ltGHGCdaihMpgHN8mmMH8DBH4Yj9fnPdkeuSCf3 WZWYegQhzewrwztEMx5+Mo3OWxgJj3L33ivSF8trCmasuTwzO0wjgPBeoGBEuESLTWMy +KhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716722445; x=1717327245; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8IWKpCZ28tVsNAru3OI66zH7hDNq0tpB9AZz0FdEa4s=; b=bkVrPHLon3eEtelpctEL69+6LL/n/nKsriGIEj8WGgyh7yVvI2HvF690gy+tYYRSky htSz77Sq0IxXbC2dZ9IUY25Ek8o5wxq3V7tbSSEz0unUnSl1UdrPHfoLOwB2WfJPb1Ie COHIraq0ND1lsdgwWPf37KzMQtHBJX8FHsX8noecgpxF3i2dlqlgBL+u7uApo1N4/kWM Vwx5QTvPC4kebDDzlJjToLSlVwTZgN00x8+v9ZgWPUCK+Cmwu0ahOAvCWpdgh/8qhicz 7tiUzCRuN+u20h1V5AAuCqEXAZr8VJaVeqRq29bUDHrMHJ3Cb03hyOgXCgf77feZfQxv xGrg== X-Forwarded-Encrypted: i=1; AJvYcCV5yRe+ykgPgp9vjEeyBHmjNPTpP7E3uNvkbj+2k3q/Bg0Cf6rLOHIdfV89zTksyks1RC6OT9ga/93e/JcMQwX/PQOJQW0lIstfiO21 X-Gm-Message-State: AOJu0YycwXFbpeEY6Ao2Fmh/5iy+0RBVBERptiyyfDUqtRKcJHQxV28a GWo5NO8F3XXGzLdeR+Mr2dN6SXtPXFpdlw/KN/1DkeHg9gVSRrZLXzxbeg== X-Google-Smtp-Source: AGHT+IGb9pWHY5MwLKWjj4bkOvPj+V1TzZGffzKKFlAOIc2hqsj5ZU1m2qeFlw9/EUo+lBZpSOUVjg== X-Received: by 2002:a17:907:a19f:b0:a62:2eca:4f15 with SMTP id a640c23a62f3a-a6265128c48mr448892666b.48.1716722444622; Sun, 26 May 2024 04:20:44 -0700 (PDT) Received: from localhost.localdomain (ip-77-25-34-87.web.vodafone.de. [77.25.34.87]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a626cc8e534sm373983366b.170.2024.05.26.04.20.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 May 2024 04:20:44 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: philipp.g.hortmann@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 2/3] staging: rtl8192e: remove unnecessary line breaks Date: Sun, 26 May 2024 13:19:27 +0200 Message-ID: <20240526111928.14574-3-straube.linux@gmail.com> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240526111928.14574-1-straube.linux@gmail.com> References: <20240526111928.14574-1-straube.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove some unnecessary line breaks after '=3D' and '=3D=3D' to improve readability. Signed-off-by: Michael Straube Reviewed-by: Nam Cao --- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 24 ++++++++-------------- 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/r= tl8192e/rtl8192e/rtl_dm.c index 2fda44c5a412..5392d2daf870 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c @@ -1392,8 +1392,7 @@ static void _rtl92e_dm_rx_path_sel_byrssi(struct net_= device *dev) continue; =20 rf_num++; - cur_cck_pwdb =3D - dm_rx_path_sel_table.cck_pwdb_sta[i]; + cur_cck_pwdb =3D dm_rx_path_sel_table.cck_pwdb_sta[i]; =20 if (rf_num =3D=3D 1) { cck_rx_ver2_max_index =3D i; @@ -1412,27 +1411,20 @@ static void _rtl92e_dm_rx_path_sel_byrssi(struct ne= t_device *dev) } } else { if (cur_cck_pwdb > tmp_cck_max_pwdb) { - tmp_cck_sec_pwdb =3D - tmp_cck_max_pwdb; - cck_rx_ver2_sec_index =3D - cck_rx_ver2_max_index; + tmp_cck_sec_pwdb =3D tmp_cck_max_pwdb; + cck_rx_ver2_sec_index =3D cck_rx_ver2_max_index; tmp_cck_max_pwdb =3D cur_cck_pwdb; cck_rx_ver2_max_index =3D i; - } else if (cur_cck_pwdb =3D=3D - tmp_cck_max_pwdb) { + } else if (cur_cck_pwdb =3D=3D tmp_cck_max_pwdb) { tmp_cck_sec_pwdb =3D cur_cck_pwdb; cck_rx_ver2_sec_index =3D i; } else if (PWDB_IN_RANGE) { tmp_cck_sec_pwdb =3D cur_cck_pwdb; cck_rx_ver2_sec_index =3D i; - } else if (cur_cck_pwdb =3D=3D - tmp_cck_sec_pwdb) { - if (tmp_cck_sec_pwdb =3D=3D - tmp_cck_min_pwdb) { - tmp_cck_sec_pwdb =3D - cur_cck_pwdb; - cck_rx_ver2_sec_index =3D - i; + } else if (cur_cck_pwdb =3D=3D tmp_cck_sec_pwdb) { + if (tmp_cck_sec_pwdb =3D=3D tmp_cck_min_pwdb) { + tmp_cck_sec_pwdb =3D cur_cck_pwdb; + cck_rx_ver2_sec_index =3D i; } } else if ((cur_cck_pwdb < tmp_cck_sec_pwdb) && (cur_cck_pwdb > tmp_cck_min_pwdb)) { --=20 2.45.1 From nobody Fri Feb 13 14:59:09 2026 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA67AC157 for ; Sun, 26 May 2024 11:20:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716722449; cv=none; b=UdW4PAtWlk6RzPjhjeaJtkP6T4Gh9n8X5uo6r+FQXE4FTnkK5sUwwtbgfyqerQSM0SJ9NRe25EftAylValM6fTEoc10Q4f2lJ/HPo9bGjn9WvCl1OFxMyG0bkYKJm+4whMtzcccraa7siNM1OQH4vK3s3i0uhTnK3hNvGeRH1VU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716722449; c=relaxed/simple; bh=PNXgIt3Wa5nCdip+L1XbGJL1MjVLgBWcHtWc57wozJw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jzys22nCoqEdEiEYe8M8o484KQ+zejkHrkrYxXR311Xzmi+smO4Ll+9ZrU+Atn2A14a6YeDFzbqXAY4z/4VNAi3ELXcRIxmUeHRR/YQF9qcpZep0jZsCDVUhd2lWnzOiXsSJbhHtdvwDtydJRaslihFx7001TzRnZfj58XhrZA4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Dsqxck4D; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Dsqxck4D" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a59cc765c29so526049366b.3 for ; Sun, 26 May 2024 04:20:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716722445; x=1717327245; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NMeY3O7seoqjcUFeqW+QpBJu4jLGTaciPn8DhAqDpcw=; b=Dsqxck4D1xpU48qAU03y0L7mWib+BvRYz7Yz5vYBWtrZ9EN+DsB1shm661tUndYETi lSKc0w+ne0UQNTBb1MXuVWys9DLq2bFYZf90gwaQoKjSX4qGrvOpA+aVoltAWGhSGbGq xLcWIOIi5yAlNqj7NIrHe21F6JDJvIUDhAba6i0BeMyAgE2q6LX9EcYMF7QANQs13DLO 9g57Fy1gPL6vUtFdW9tIA4FB7R5jj7VKhhVeMWNMM2Ml33tNfc/RL/SQWL6bzqUMI0sW Rol+XdR42wYSsv4fED5JB5ceGSK/vicZM+0mp0jv0AfMqMR5dG+TiOA5aUsNpsNYPRtI Lxcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716722445; x=1717327245; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NMeY3O7seoqjcUFeqW+QpBJu4jLGTaciPn8DhAqDpcw=; b=Hg+fz+5OBbJqkJ7asKOiEsAE/p65PHSnl9T7dS5y30PtcbfYD+SUQwcpHzjY9sFZFc kL253XoZifirh7nYnALDeyrB6UiaN+V4PNe6rnpTbY65tGUcI91FjuaAu2j4Mguwl/ra xu7mIQhNzweeAt5a/d18ypOxKdOzBH6kPbFdsHLOGnxmFEpkDjCCJcCWw/Fb8U/JgTx3 ZYKCSEuuyQwo7LdfteTFDJ81JrQ5Pm/V+jz0ZvotXmBOGOn2pcAqeAfMGAlxWzcMny/K RxfKhoK0AsHG+kXcMbffS7xbCfxVRwlFmIfuUVAS2NmMC7tjvxvcL8YwACYcPg/oUGLs JIdA== X-Forwarded-Encrypted: i=1; AJvYcCV0atzGiutkXsEs0C/T9Hrn9r+C5nIujvWQy8gze06vHc0mIJbvPF/n2eSaQqYrbhwxktQupTxKo59Z8lBiSeK1ySjVDRQgIQkqFk9A X-Gm-Message-State: AOJu0Yx2mvf94gMdFe8fOBhPJyaD+UgBpieP5jxfJ7LYYujjA3sOJpuW ggwMNxAobnl8qcwX0EDnIXLzj0nkdlRgOk0bOzAjcKSqFqQZEnJfCn9TjQ== X-Google-Smtp-Source: AGHT+IFD/6dFxk1qtUrHDVrEqJ7xiBgSakazac4QIdCJw84Y9ymI0JHD5eii0l03scgu6UvGCxsJnA== X-Received: by 2002:a17:906:c59:b0:a5a:5b8b:d14 with SMTP id a640c23a62f3a-a62649c0862mr447888266b.40.1716722445282; Sun, 26 May 2024 04:20:45 -0700 (PDT) Received: from localhost.localdomain (ip-77-25-34-87.web.vodafone.de. [77.25.34.87]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a626cc8e534sm373983366b.170.2024.05.26.04.20.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 May 2024 04:20:45 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: philipp.g.hortmann@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 3/3] staging: rtl8192e: remove dead code Date: Sun, 26 May 2024 13:19:28 +0200 Message-ID: <20240526111928.14574-4-straube.linux@gmail.com> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240526111928.14574-1-straube.linux@gmail.com> References: <20240526111928.14574-1-straube.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove two else-if arms that do nothing. Signed-off-by: Michael Straube --- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/r= tl8192e/rtl8192e/rtl_dm.c index 5392d2daf870..4e03eb100175 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c @@ -1370,9 +1370,6 @@ static void _rtl92e_dm_rx_path_sel_byrssi(struct net_= device *dev) tmp_sec_rssi =3D cur_rf_rssi; sec_rssi_index =3D i; } - } else if ((cur_rf_rssi < tmp_sec_rssi) && - (cur_rf_rssi > tmp_min_rssi)) { - ; } else if (cur_rf_rssi =3D=3D tmp_min_rssi) { if (tmp_sec_rssi =3D=3D tmp_min_rssi) { tmp_min_rssi =3D cur_rf_rssi; @@ -1426,9 +1423,6 @@ static void _rtl92e_dm_rx_path_sel_byrssi(struct net_= device *dev) tmp_cck_sec_pwdb =3D cur_cck_pwdb; cck_rx_ver2_sec_index =3D i; } - } else if ((cur_cck_pwdb < tmp_cck_sec_pwdb) && - (cur_cck_pwdb > tmp_cck_min_pwdb)) { - ; } else if (cur_cck_pwdb =3D=3D tmp_cck_min_pwdb) { if (tmp_cck_sec_pwdb =3D=3D tmp_cck_min_pwdb) tmp_cck_min_pwdb =3D cur_cck_pwdb; --=20 2.45.1