From nobody Fri Feb 13 15:02:09 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C0AD132C16; Sun, 26 May 2024 09:43:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716716638; cv=none; b=ibdmU3G8Cjc2qsQkVn2oZiAofnb/QzMqTr2MwqqVlbj7dQ4OLiqbmyMt4qeMCvUo3csgBJ9gZU7s7XmQ5Jgy2sxcCwhlwHN4q1S17IZ4oNeM48VnsvtrSM97hc119GUv5gPyCJr+M4vnHS736XhoTEJ0nH7Ol9daQISy0TV0tDk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716716638; c=relaxed/simple; bh=bXW37V1Flhx5xKq+9jOYUj5LIwd5KNR2wByg+MPa6WY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=UHw1xcRQAb7P6FpjFk2gzZjA8pRBClEi/kMMU83bPSRGR8oCieWLZ8DQjaVgs3LKDpzZxRE381Q26e9EbwP0QT7sSwDUI9dtQ0FA6aBZQtIeqWJposFccBwi3NeCgfEfdgzU1TvMkum/y/TSAB/sGGV6vIGoLa6NPdA4jIzovDY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SW1UUKKN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SW1UUKKN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA5F3C2BD10; Sun, 26 May 2024 09:43:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716716638; bh=bXW37V1Flhx5xKq+9jOYUj5LIwd5KNR2wByg+MPa6WY=; h=From:To:Cc:Subject:Date:From; b=SW1UUKKNhtnTEvIMh7fV0vi11q2PwNUAxZkHQlWcz7Jqc7f6F0eEAXi002RvzjEO8 StC79IF2IfzOpZv2MP6TIGlizlEMBHtU53WVKtMtFFha5IjLqSIQGNcMlOAPx+hhuh AEFv/okm7ji4bn/N7Na4SqHxKE/kXM/553t49tCeHyIwfCcJiA2XROW3GCkWeur3qN Z4eQDLVHQDAN2V5nFA7UE1KgfH2TKUh5bEXVWMnQpNnRC5utAWBGLxfCVAcf4DodEB qTREpr7IuwaQJOzcuXLll0lxpQrRe7FcQ56RKY9EQjMRDTAwG8F1Vfq/l8rbGqxlqF N8DTCKUTfrY9g== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: "Paul E. McKenney" , Linus Torvalds , Uladzislau Rezki , Sasha Levin , dave@stgolabs.net, josh@joshtriplett.org, frederic@kernel.org, neeraj.upadhyay@kernel.org, joel@joelfernandes.org, boqun.feng@gmail.com, rcu@vger.kernel.org Subject: [PATCH AUTOSEL 4.19] rcutorture: Fix rcu_torture_one_read() pipe_count overflow comment Date: Sun, 26 May 2024 05:43:55 -0400 Message-ID: <20240526094355.3413996-1-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 4.19.314 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Paul E. McKenney" [ Upstream commit 8b9b443fa860276822b25057cb3ff3b28734dec0 ] The "pipe_count > RCU_TORTURE_PIPE_LEN" check has a comment saying "Should not happen, but...". This is only true when testing an RCU whose grace periods are always long enough. This commit therefore fixes this comment. Reported-by: Linus Torvalds Closes: https://lore.kernel.org/lkml/CAHk-=3Dwi7rJ-eGq+xaxVfzFEgbL9tdf6Kc8Z= 89rCpfcQOKm74Tw@mail.gmail.com/ Signed-off-by: Paul E. McKenney Signed-off-by: Uladzislau Rezki (Sony) Signed-off-by: Sasha Levin --- kernel/rcu/rcutorture.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c index 0b7af7e2bcbb1..8986ef3a95888 100644 --- a/kernel/rcu/rcutorture.c +++ b/kernel/rcu/rcutorture.c @@ -1334,7 +1334,8 @@ static bool rcu_torture_one_read(struct torture_rando= m_state *trsp) preempt_disable(); pipe_count =3D p->rtort_pipe_count; if (pipe_count > RCU_TORTURE_PIPE_LEN) { - /* Should not happen, but... */ + // Should not happen in a correct RCU implementation, + // happens quite often for torture_type=3Dbusted. pipe_count =3D RCU_TORTURE_PIPE_LEN; } completed =3D cur_ops->get_gp_seq(); --=20 2.43.0