From nobody Fri Feb 13 14:59:17 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EC841327FC; Sun, 26 May 2024 09:43:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716716635; cv=none; b=n1KuwVjfWVbBLP4MUtpTYBWPIsu4PS8htGvaw6MIeJuTYp9UzukDndmdr5CVlrkzVX+x7aaCHLiWuUHOgW08Tz63wMXRLCTKb5PaL53M/lyXiA+cMxQ6aHfkwTE5moR8YLDZ9IfUONXFTLms+cYKzl1VCP0roCRU2ryEXNqvGbQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716716635; c=relaxed/simple; bh=+1WSI6Am9V2JgdnGPquJH/MRGAEoUbgPpIB2ekCVDA4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=qPIlZG3vIn2EaU3/ZLmx4uW6UU/8XnUboZiTQ35EzL3h8Y5WfVWhScpVIs/fqq3cdIPjXPmQhr8nwU907zFahx+D2ult7Dohu9xk/mgiL4Q+mKzVWviOgrl5lolSpq/jTX/rdIseodQHxGH4cgL5+LuXzn9G6Xo1thPbP4IR0CA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KV0WpSRz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KV0WpSRz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85E88C32782; Sun, 26 May 2024 09:43:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716716634; bh=+1WSI6Am9V2JgdnGPquJH/MRGAEoUbgPpIB2ekCVDA4=; h=From:To:Cc:Subject:Date:From; b=KV0WpSRzsYcIQSLU6HrhKnCLTgcH4xMd0mCHCoRSfnU8eiyUdngfKcCrGLCkI/8yJ Cg6MHbgllN/iGpHmEWsSAJTWSbxzYpioWfiWIegc/GKRH4TB4meMdvN6uLS9obUo75 JjH58cvEFCP/jR4irV6Kj+3GZBjZOo9v/whaKTsWkJUt/tnM9MMdHJZzlE4AFhZsmW NXlt4kd1kv2J6lwVwS2PK2aYmMXDSxdvhHMHegQBl1qhYOHGZ5I+CcalZFgjPwnYmX IDAourBmt0PyCGwcNB/x0H6zlyFrIr0u+EhqcscBQYZPumTWHgU5lJPJLiplx/Wkqn bb7IeP5qV/7QQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: "Paul E. McKenney" , Linus Torvalds , Uladzislau Rezki , Sasha Levin , dave@stgolabs.net, josh@joshtriplett.org, frederic@kernel.org, neeraj.upadhyay@kernel.org, joel@joelfernandes.org, boqun.feng@gmail.com, rcu@vger.kernel.org Subject: [PATCH AUTOSEL 5.4] rcutorture: Fix rcu_torture_one_read() pipe_count overflow comment Date: Sun, 26 May 2024 05:43:51 -0400 Message-ID: <20240526094352.3413964-1-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.276 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Paul E. McKenney" [ Upstream commit 8b9b443fa860276822b25057cb3ff3b28734dec0 ] The "pipe_count > RCU_TORTURE_PIPE_LEN" check has a comment saying "Should not happen, but...". This is only true when testing an RCU whose grace periods are always long enough. This commit therefore fixes this comment. Reported-by: Linus Torvalds Closes: https://lore.kernel.org/lkml/CAHk-=3Dwi7rJ-eGq+xaxVfzFEgbL9tdf6Kc8Z= 89rCpfcQOKm74Tw@mail.gmail.com/ Signed-off-by: Paul E. McKenney Signed-off-by: Uladzislau Rezki (Sony) Signed-off-by: Sasha Levin --- kernel/rcu/rcutorture.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c index 3c9feca1eab17..aef4d01c4f61e 100644 --- a/kernel/rcu/rcutorture.c +++ b/kernel/rcu/rcutorture.c @@ -1291,7 +1291,8 @@ static bool rcu_torture_one_read(struct torture_rando= m_state *trsp) preempt_disable(); pipe_count =3D p->rtort_pipe_count; if (pipe_count > RCU_TORTURE_PIPE_LEN) { - /* Should not happen, but... */ + // Should not happen in a correct RCU implementation, + // happens quite often for torture_type=3Dbusted. pipe_count =3D RCU_TORTURE_PIPE_LEN; } completed =3D cur_ops->get_gp_seq(); --=20 2.43.0