From nobody Fri Feb 13 18:37:44 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8FF58565B; Fri, 24 May 2024 10:24:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716546288; cv=none; b=WqeE2aK1yL9677mtYjhIWQpLy6IxeMrQVcp69lzZt8zLaoBKtgQb+UPbjjWlavY5rtqyan5IL4P/zmzPxt/tnX2jnAZBGZF4642J4mrTmhQmQECYRyCfeK6yo8J0smEVSNGkIXkeAhkfE7MwCt/6cif/jDnLaNDSuaBHOAc2S78= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716546288; c=relaxed/simple; bh=6nIJS9JnhwT4xmNQms+xT2zwrRcKn5Gvsoq+btzuv78=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FJEiuk4darQxlGhY9Ol6IYcveYzEzXTh+ONsah90uFM/TOWEKibHQ9cTIXJAJzb9viiBW7SqukyOAlGWNuykdpd3jqNQHc/LM/NrScjX7mj2edssJAfAxUIJUSG7ETLGZYslzSTg8MSELyJqmGanDG6xchdfur9Vbv7hKIwLn+o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=B5MlsoNu; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="B5MlsoNu" Received: by smtp.kernel.org (Postfix) with ESMTPS id 4E958C32789; Fri, 24 May 2024 10:24:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716546288; bh=6nIJS9JnhwT4xmNQms+xT2zwrRcKn5Gvsoq+btzuv78=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=B5MlsoNuPsROxr63X/LaPKZOasKGfPjjFw2SweHIvLMJvtq5YNjFUUclbVbjtaIuD MQ0CeeZsNLBBx0aTC9SQ8tkWh6l+e/u4f2yWzIKeMV+lqK3u+5t9Yon3/z5v3xMYA+ eUPlpyHj7rUBTbaTyn3gsfpRd/S5FGDyk8K5P6bcp/Ln4RPTpnb7xWzMrmzUPcPqbP dAdzUJz+PUpH4MJ9GinCz/M4tokEqSPE/YIF55ESFVkorfVPgx4q/QdhVqosmlp2Li cvG7B+mhjknQrIlODoF/XAIpkLNnGGYP/XQevsOEN+XWRcpjRxEtVWicALYdl+51yg ejSViZ8+6dyVA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 452CEC25B79; Fri, 24 May 2024 10:24:48 +0000 (UTC) From: Nikita Shubin via B4 Relay Date: Fri, 24 May 2024 13:24:48 +0300 Subject: [PATCH 3/3] dmaengine: ioatdma: Fix kmemleak in ioat_pci_probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240524-ioatdma-fixes-v1-3-b785f1f7accc@yadro.com> References: <20240524-ioatdma-fixes-v1-0-b785f1f7accc@yadro.com> In-Reply-To: <20240524-ioatdma-fixes-v1-0-b785f1f7accc@yadro.com> To: Vinod Koul , Dave Jiang , Logan Gunthorpe Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Nikita Shubin , Andy Shevchenko X-Mailer: b4 0.12.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1716546287; l=3610; i=n.shubin@yadro.com; s=20230718; h=from:subject:message-id; bh=4F6Y41syeecTB0IjN8FIDbj5S9PP/ayLta+MVmDUoqA=; b=FI8qyvqmkOkuefCviyEdsbJ7x1T5n4nUv3F7H/eVvjt8dZNAV5mKqVrl8n/l/gJT7x/3wlYW6GLA iv1HrOdUBK4kgE8i6OQykyxaMAXaV1uGBeakzhC85NoqMgkUb78s X-Developer-Key: i=n.shubin@yadro.com; a=ed25519; pk=vqf5YIUJ7BJv3EJFaNNxWZgGuMgDH6rwufTLflwU9ac= X-Endpoint-Received: by B4 Relay for n.shubin@yadro.com/20230718 with auth_id=161 X-Original-From: Nikita Shubin Reply-To: n.shubin@yadro.com From: Nikita Shubin If probing fails we end up with leaking ioatdma_device and each allocated channel. Following kmemleak is easy to be reproduced by injecting error in ioat_alloc_chan_resources() when doing ioat_dma_self_test(). unreferenced object 0xffff888014ad5800 (size 1024): comm "modprobe", pid 73, jiffies 4294681749 hex dump (first 32 bytes): 00 10 00 13 80 88 ff ff 00 c0 3f 00 00 c9 ff ff ..........?..... 00 ce 76 13 80 88 ff ff 00 00 00 00 00 00 00 00 ..v............. backtrace (crc 1f353f55): [] kmemleak_alloc+0x4a/0x80 [] kmalloc_trace+0x270/0x2f0 [] ioat_pci_probe+0xc1/0x1c0 [ioatdma] [] local_pci_probe+0x7a/0xe0 [] pci_call_probe+0xd9/0x2c0 [] pci_device_probe+0xa5/0x170 [] really_probe+0x14b/0x510 [] __driver_probe_device+0xda/0x1f0 [] driver_probe_device+0x4f/0x120 [] __driver_attach+0x14a/0x2b0 [] bus_for_each_dev+0xec/0x160 [] driver_attach+0x2b/0x40 [] bus_add_driver+0x1a3/0x300 [] driver_register+0xa3/0x1d0 [] __pci_register_driver+0xeb/0x100 [] 0xffffffffa003009c repeated for each ioatdma channel: unreferenced object 0xffff8880148e5c00 (size 512): comm "modprobe", pid 73, jiffies 4294681751 hex dump (first 32 bytes): 40 58 ad 14 80 88 ff ff 00 00 00 00 00 00 00 00 @X.............. 01 00 00 00 01 00 00 00 00 00 00 00 00 00 00 00 ................ backtrace (crc fbc62789): [] kmemleak_alloc+0x4a/0x80 [] kmalloc_trace+0x270/0x2f0 [] ioat_enumerate_channels+0x101/0x2d0 [ioatdma] [] ioat3_dma_probe+0x4d6/0x970 [ioatdma] [] ioat_pci_probe+0x181/0x1c0 [ioatdma] [] local_pci_probe+0x7a/0xe0 [] pci_call_probe+0xd9/0x2c0 [] pci_device_probe+0xa5/0x170 [] really_probe+0x14b/0x510 [] __driver_probe_device+0xda/0x1f0 [] driver_probe_device+0x4f/0x120 [] __driver_attach+0x14a/0x2b0 [] bus_for_each_dev+0xec/0x160 [] driver_attach+0x2b/0x40 [] bus_add_driver+0x1a3/0x300 [] driver_register+0xa3/0x1d0 Fixes: bf453a0a18b2 ("dmaengine: ioat: Support in-use unbind") Signed-off-by: Nikita Shubin --- drivers/dma/ioat/init.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/dma/ioat/init.c b/drivers/dma/ioat/init.c index 26964b7c8cf1..d0d787cfd0e0 100644 --- a/drivers/dma/ioat/init.c +++ b/drivers/dma/ioat/init.c @@ -1348,7 +1348,7 @@ static int ioat_pci_probe(struct pci_dev *pdev, const= struct pci_device_id *id) struct device *dev =3D &pdev->dev; struct ioatdma_device *device; u8 version; - int err; + int err, i; =20 err =3D pcim_enable_device(pdev); if (err) @@ -1384,6 +1384,9 @@ static int ioat_pci_probe(struct pci_dev *pdev, const= struct pci_device_id *id) =20 err =3D ioat3_dma_probe(device, ioat_dca_enabled); if (err) { + for (i =3D 0; i < IOAT_MAX_CHANS; i++) + kfree(device->idx[i]); + kfree(device); dev_err(dev, "Intel(R) I/OAT DMA Engine init failed\n"); return -ENODEV; } --=20 2.43.2