From nobody Fri Dec 19 10:41:22 2025 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B5765B1E8; Wed, 22 May 2024 03:36:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.188 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716348965; cv=none; b=DbhaQJG7nHFQBUKUnDDUCFlS6r/trevkaATH7z7NeNPT4fwQP+9DYCBu8Fy3ho3iHv3TpwmnvGTL903yYMaUKyHzvYsoGLTeSSvh3XgbhRl3+GE6EC1dmwD/Cg0ryK9c79VpB6E0prX6hV9Wj+N28gqXcxapNoRo7uj/4CNWN0M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716348965; c=relaxed/simple; bh=zRjS4HniSyauajIjylYLbXjWxv2s24OoOrQ1SnYwpBE=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Ggu4YtWpU88/oYD9F2M8lMM8C2YNSvHieSS7G4540qlFNKJ36t02CzOWMHWDXMYEJ5LkgzHDlk/tCUn8Bo2bhjo12jHBa2iahSCSuhujJB3rgh+WIiMQpYxmRAI58DFpW6cFa/9FICATn+b9cB6ob8t1xVPyw25ddtncf9uJ8Pw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.162.254]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4VkcKx2d1BzXnRy; Wed, 22 May 2024 11:31:49 +0800 (CST) Received: from kwepemd100011.china.huawei.com (unknown [7.221.188.204]) by mail.maildlp.com (Postfix) with ESMTPS id D2ACB1800CB; Wed, 22 May 2024 11:36:00 +0800 (CST) Received: from M910t.huawei.com (10.110.54.157) by kwepemd100011.china.huawei.com (7.221.188.204) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.34; Wed, 22 May 2024 11:35:59 +0800 From: Changbin Du To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim CC: Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , , , Changbin Du Subject: [RESEND PATCH v3 1/2] perf trace beauty: Always show param if show_zero is set Date: Wed, 22 May 2024 11:35:41 +0800 Message-ID: <20240522033542.1359421-2-changbin.du@huawei.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240522033542.1359421-1-changbin.du@huawei.com> References: <20240522033542.1359421-1-changbin.du@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemd100011.china.huawei.com (7.221.188.204) Content-Type: text/plain; charset="utf-8" For some parameters, it is best to also display them when they are 0, e.g. flags. Here we only check the show_zero property and let arg printer handle special cases. Signed-off-by: Changbin Du --- tools/perf/builtin-trace.c | 29 +++++++---------------------- 1 file changed, 7 insertions(+), 22 deletions(-) diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c index e5fef39c34bf..915dcd258002 100644 --- a/tools/perf/builtin-trace.c +++ b/tools/perf/builtin-trace.c @@ -2091,17 +2091,11 @@ static size_t syscall__scnprintf_args(struct syscal= l *sc, char *bf, size_t size, val =3D syscall_arg_fmt__mask_val(&sc->arg_fmt[arg.idx], &arg, val); =20 /* - * Suppress this argument if its value is zero and - * and we don't have a string associated in an - * strarray for it. - */ - if (val =3D=3D 0 && - !trace->show_zeros && - !(sc->arg_fmt && - (sc->arg_fmt[arg.idx].show_zero || - sc->arg_fmt[arg.idx].scnprintf =3D=3D SCA_STRARRAY || - sc->arg_fmt[arg.idx].scnprintf =3D=3D SCA_STRARRAYS) && - sc->arg_fmt[arg.idx].parm)) + * Suppress this argument if its value is zero and show_zero + * property isn't set. + */ + if (val =3D=3D 0 && !trace->show_zeros && + !(sc->arg_fmt && sc->arg_fmt[arg.idx].show_zero)) continue; =20 printed +=3D scnprintf(bf + printed, size - printed, "%s", printed ? ",= " : ""); @@ -2796,17 +2790,8 @@ static size_t trace__fprintf_tp_fields(struct trace = *trace, struct evsel *evsel, */ val =3D syscall_arg_fmt__mask_val(arg, &syscall_arg, val); =20 - /* - * Suppress this argument if its value is zero and - * we don't have a string associated in an - * strarray for it. - */ - if (val =3D=3D 0 && - !trace->show_zeros && - !((arg->show_zero || - arg->scnprintf =3D=3D SCA_STRARRAY || - arg->scnprintf =3D=3D SCA_STRARRAYS) && - arg->parm)) + /* Suppress this argument if its value is zero and show_zero property is= n't set. */ + if (val =3D=3D 0 && !trace->show_zeros && !arg->show_zero) continue; =20 printed +=3D scnprintf(bf + printed, size - printed, "%s", printed ? ", = " : ""); --=20 2.34.1 From nobody Fri Dec 19 10:41:22 2025 Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DB8E77113; Wed, 22 May 2024 03:36:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.191 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716348973; cv=none; b=tS+xRqOz1LuHHE18nCZJzuGhNsYDcwa/5dGWVsDwCXdx1HnXFEY34BWQfO0wUNenzKiXmQ5Y5B/MJFMdCUoGubmyokVyIjL+OD5I1O30UiE5qz7Pte65ZloF1U+DnvKdKqHsTLlVtvxn4UdKgXw+mIlfs5/VBBSEPRJ4rGIPKRA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716348973; c=relaxed/simple; bh=Xkb858840JSpgt73J/+K8NkWTXhVSsceTUY+W6NiCQk=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=aRj6qDyM8l7OZxAGrRVbjkEOr3P4n4JmYCgRyXhCJenmD/AxAZ51Om7TbnRvtwn2a3OTB416ce6tw+IgTJZ0fR/DpOGtf6yKQSlLap9CNCEyg/SUtjQVK33f4yFtVafFUJ4bpmu2ahsuRcr28RnWi3ahXToI51JxLEX2E/OPR/k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.191 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.162.112]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4VkcP22P1Fz1HBl7; Wed, 22 May 2024 11:34:30 +0800 (CST) Received: from kwepemd100011.china.huawei.com (unknown [7.221.188.204]) by mail.maildlp.com (Postfix) with ESMTPS id 097201403D1; Wed, 22 May 2024 11:36:02 +0800 (CST) Received: from M910t.huawei.com (10.110.54.157) by kwepemd100011.china.huawei.com (7.221.188.204) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.34; Wed, 22 May 2024 11:36:00 +0800 From: Changbin Du To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim CC: Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , , , Changbin Du Subject: [RESEND PATCH v3 2/2] perf trace beauty: Always show mmap prot even though PROT_NONE Date: Wed, 22 May 2024 11:35:42 +0800 Message-ID: <20240522033542.1359421-3-changbin.du@huawei.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240522033542.1359421-1-changbin.du@huawei.com> References: <20240522033542.1359421-1-changbin.du@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemd100011.china.huawei.com (7.221.188.204) Content-Type: text/plain; charset="utf-8" PROT_NONE is also useful information, so do not omit the mmap prot even though it is 0. syscall_arg__scnprintf_mmap_prot() could print PROT_NONE for prot 0. Before: PROT_NONE is not shown. $ sudo perf trace -e syscalls:sys_enter_mmap --filter prot=3D=3D0 -- ls 0.000 ls/2979231 syscalls:sys_enter_mmap(len: 4220888, flags: PRIVATE|= ANONYMOUS) After: PROT_NONE is displayed. $ sudo perf trace -e syscalls:sys_enter_mmap --filter prot=3D=3D0 -- ls 0.000 ls/2975708 syscalls:sys_enter_mmap(len: 4220888, prot: NONE, fla= gs: PRIVATE|ANONYMOUS) Signed-off-by: Changbin Du --- tools/perf/builtin-trace.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c index 915dcd258002..919a462a7cb5 100644 --- a/tools/perf/builtin-trace.c +++ b/tools/perf/builtin-trace.c @@ -1033,7 +1033,7 @@ static const struct syscall_fmt syscall_fmts[] =3D { #if defined(__s390x__) .alias =3D "old_mmap", #endif - .arg =3D { [2] =3D { .scnprintf =3D SCA_MMAP_PROT, /* prot */ }, + .arg =3D { [2] =3D { .scnprintf =3D SCA_MMAP_PROT, .show_zero =3D true,= /* prot */ }, [3] =3D { .scnprintf =3D SCA_MMAP_FLAGS, /* flags */ .strtoul =3D STUL_STRARRAY_FLAGS, .parm =3D &strarray__mmap_flags, }, @@ -1050,7 +1050,7 @@ static const struct syscall_fmt syscall_fmts[] =3D { [4] =3D { .scnprintf =3D SCA_MOVE_MOUNT_FLAGS, /* flags */ }, }, }, { .name =3D "mprotect", .arg =3D { [0] =3D { .scnprintf =3D SCA_HEX, /* start */ }, - [2] =3D { .scnprintf =3D SCA_MMAP_PROT, /* prot */ }, }, }, + [2] =3D { .scnprintf =3D SCA_MMAP_PROT, .show_zero =3D true, /* prot = */ }, }, }, { .name =3D "mq_unlink", .arg =3D { [0] =3D { .scnprintf =3D SCA_FILENAME, /* u_name */ }, }, }, { .name =3D "mremap", .hexret =3D true, @@ -1084,7 +1084,7 @@ static const struct syscall_fmt syscall_fmts[] =3D { .arg =3D { [0] =3D { .scnprintf =3D SCA_INT, /* key */ }, }, }, { .name =3D "pkey_mprotect", .arg =3D { [0] =3D { .scnprintf =3D SCA_HEX, /* start */ }, - [2] =3D { .scnprintf =3D SCA_MMAP_PROT, /* prot */ }, + [2] =3D { .scnprintf =3D SCA_MMAP_PROT, .show_zero =3D true, /* prot = */ }, [3] =3D { .scnprintf =3D SCA_INT, /* pkey */ }, }, }, { .name =3D "poll", .timeout =3D true, }, { .name =3D "ppoll", .timeout =3D true, }, --=20 2.34.1