From nobody Tue Feb 10 23:53:31 2026 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F343F41746 for ; Tue, 21 May 2024 03:17:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261445; cv=none; b=jx8iFITSLU2vrqK8CEq+ghdxhJ51ueVPWTZyLYA/8LyAk2i2MvPrWqWHssoOylAIQ15irQkatxmPyw2wBL1sFt6BPn3mTh0FNYopXTwFB0ROnP8lqlqVj67Wn7rYRPBUMSV5fKSBbCaPZlytIDO227e9PMjWiqpWSkgvlUBN52Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261445; c=relaxed/simple; bh=BDYFLsz+/qdUa9ORrrhrQxUmtbfPzFNySy6nqCUl4C0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=XdopKuMVpMqetUTbLohVRCcPj/SzvIYRGTtcjzX7WxqwZZ7LMx2KF4qiaI74LxjscNBg5oCs0pVIBDbrSQ5yMDplBLvEEMXsDSMK1bSEU1ShmfoXNiyfkBdfpacXmHMDMqEnOsQ22KDhVw4l+nEBKfhhK4plLDFWVfQXlOpiY2w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=JnDeaCG5; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="JnDeaCG5" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1ecddf96313so81726585ad.2 for ; Mon, 20 May 2024 20:17:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1716261442; x=1716866242; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EBJmvHjrIZD4J5+8YalNZy3ccMmTqVm1w0JgkzYgp6A=; b=JnDeaCG5KGBMHJJAoGYCI7G/HKYEJQTN2ylrSgljXAgMNB2+MO3Dv5oQkNeyGVhtGD oDF0eHRf1qBR5w6gkBV1XUsFIlDfyyHNj3wOr19FShik40xbH71jpT28vyFeKGWOg9ew 6kholWQP/8m/RqsdKVtPG2CwanBbLaQCqKi0GYhoYVoI5tBbgXaWipKsB315SLC3EpNt A1iYgtyT+cCyxH4MwnPPZhp7k6NQ9v5JKsDzIQtMD9e0VO6yuxHNb80nktXh/kOLSz2e C87IZAUfq009V30ZC/s48Y+MFFt3/zQnW7bpVfBghZrQihy/JaOIvo2aeUQdvUihRQdc AOdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716261442; x=1716866242; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EBJmvHjrIZD4J5+8YalNZy3ccMmTqVm1w0JgkzYgp6A=; b=SwQ89ny34OSnnsj+q/uhqDFRU5WJSe9nl8IrJ28rNbkrJoFf1pXU31SLLe7Bs3Mg0P UXSbtmR41a4wnSbju7gHuzkcqU0gYK1OJGX0XdagF0al5sRJzXSam9+onyS+wfio12+p pr3mUy/xekNMnjyH5Kne/jp2au+5E5md9eyJJno47wRfH6jTcD1M5xt/aqu3HGOaBHwo DydGtdYRyurnyMGqDM9469WjKcD+/CUqA8Gmi0lxUXYMkTUoKom2uvlCx7wOaeJd1npk o7R9QOaIofKYaSElA5lS0YHdcv87lKQU12dxixM8LIz/3Uu+K6DsurEAzLfIWKh+vfyi 3Lzg== X-Forwarded-Encrypted: i=1; AJvYcCXnr6KyD9tGuiFqCoJfVuuYeTO/n3o4Lr5ZfRTo6N69nKyjGuU4a1rZkGxnJkqb7H3xeYbZykli4Bccpau9noZHUyBvhXZXjUJDk3xo X-Gm-Message-State: AOJu0YxYci9VHlzPMHEFK4BRVZ7u4yCWtIDgBUQvMnukMCNG//8LENJO TWJDvlBOPrFUabD1Qf/AyHOH/qO7tFe+c1Qf+/qvsGSLQSWXuGpsfXWcGhJqILs= X-Google-Smtp-Source: AGHT+IFNy6BKjfAI2rtz8anl6N+itc18Z32U8IcDCV9zSoM7IeBOmMW3L7ublaurf44C/d1dCLLr7w== X-Received: by 2002:a17:902:f683:b0:1f3:4e4:f76a with SMTP id d9443c01a7336-1f304e53670mr56219285ad.65.1716261442263; Mon, 20 May 2024 20:17:22 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bf31a93sm214885415ad.134.2024.05.20.20.17.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 20:17:21 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 01/31] Staging: rtl8192e: Rename variable IsPassiveChannel Date: Mon, 20 May 2024 20:16:48 -0700 Message-Id: <20240521031718.17852-2-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240521031718.17852-1-tdavies@darkphysics.net> References: <20240521031718.17852-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable IsPassiveChannel to is_passive_channel to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No change. drivers/staging/rtl8192e/rtllib_rx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index ee469c9118b8..4a0db2dfd5e9 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -2356,7 +2356,7 @@ static inline void update_network(struct rtllib_devic= e *ieee, dst->bss_ccx_ver_number =3D src->bss_ccx_ver_number; } =20 -static int IsPassiveChannel(struct rtllib_device *rtllib, u8 channel) +static int is_passive_channel(struct rtllib_device *rtllib, u8 channel) { if (channel > MAX_CHANNEL_NUMBER) { netdev_info(rtllib->dev, "%s(): Invalid Channel\n", __func__); @@ -2432,7 +2432,7 @@ static inline void rtllib_process_probe_response( goto free_network; =20 if (ieee80211_is_probe_resp(frame_ctl)) { - if (IsPassiveChannel(ieee, network->channel)) { + if (is_passive_channel(ieee, network->channel)) { netdev_info(ieee->dev, "GetScanInfo(): For Global Domain, filter probe response at channe= l(%d).\n", network->channel); --=20 2.30.2 From nobody Tue Feb 10 23:53:31 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA1BE20B20 for ; Tue, 21 May 2024 03:17:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261445; cv=none; b=J08xsTX7L+6M7xQexEKlr0GlYOjaviLa5sMY49gYpQRIDAxiJwpVGCIYhvEG0bnQH9FKfUyTRUHPOmRDn5gDr/GXyJtzgZ4xvOeV2gklM8hBZjsR/kbWTSoHDkqSz/wt7SCjDaO5H5o/rf2nT9Z6MU0us2MTxCl4P7VzX+ZP8H4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261445; c=relaxed/simple; bh=wUKoaCTHzLDDjFbhF0PGI5yAQPN1+rFJl7SEuLinulY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=bqOnR4PeRQukDN4N2DnnvVUVemtffjpux/y6IgFc1xPYMMeJXuWYuEmeY4tnhO+n/2rsAN++HzWHhrDhpqAHC2xkt+njZOUMu9yW45wd46rWREEslFtMTz1FBZ0u+/GB5A7M6HPX5d0CNuiMub7n5sZGoAXkhVS53gmZXX7KpzQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=e+vCBsBx; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="e+vCBsBx" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1ee954e0aa6so65209115ad.3 for ; Mon, 20 May 2024 20:17:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1716261443; x=1716866243; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dAeUQPv6s9JrE6X44M25yrVX3F0jSkau/eRXgFLNcZw=; b=e+vCBsBxoNnRVlKiB5Dp0gQjkQbj3eUkrtMbllGrjepML3iAJQ6R+jU2E1BAs0pnNS wN+zAbY65bLCTST4bafn0XMdaWdP5sqa0QHa6ny28469RyeL79J/jOiBOEr7vlX3C+/k oLHzo+z4Iqkdgv6G8/1/0BnsWUezp6d6x43rXRst09lDECNxye4J1Y7t/y5UqILULZQq h2CFDLdpo7yrw2dM7mCWLe3ICSVSmQR2zAsoeFqnk2oEF4BcPYX9OXJvH7TLAPTJmLEn JMdgWuobYi/XLVICNFDGQgvVkEWJjABe2R2eHBgD2+ODic42K9qDjt/n3smMb8qk/+U+ rflw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716261443; x=1716866243; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dAeUQPv6s9JrE6X44M25yrVX3F0jSkau/eRXgFLNcZw=; b=JSP+fdjwFg0us+YBLEYvMLhfYf4aQsbpaYEsGBU6fk1a1OU1PIJEZruf8b5By26ykw N8cDhU181L4nyFfvcjRuMNDri1smMlh1rqQ/IvDyFYH0mOhvo6GYKtnpgGRSSTd9WVXa 5Pnow2vlU+3j059Tt7lNg8PPfbyjz5o35dv4TY/sdxplOXnDuZyic7AmlfipZymJuzUP qxYGtASy23tyi7lXvdDd8w8wx+tjQfQf8VLsHeHlICa/Gl97v1VCD3VXqTDj1Pd4ddYR SpBF1wXW7+aR6UiH/2+PnmFhKsPACladXz/BDmQJ2mzyNqZBD83TeWAfIbS40F5DspYz MSCA== X-Forwarded-Encrypted: i=1; AJvYcCWXovru28WM+XOkEKMLZOcwFULsd1lzeAr4+n3m+UgbpsE+doZk9u644VUB1X+TiVgSAQJYh6VsDmfHmPCgXjwKhy/YXjHCyylkuizH X-Gm-Message-State: AOJu0Yx2e+3sszf5Z1A0lQwDaGhOr6Fjx+uDszP8Cxui3m+py+NcKoTI Ta0R4gpHBKLWUs2b+FjfE6wpiRZjXJmeek7ovCb5AYAR+nzWEUEoGDYzsZV1sYc= X-Google-Smtp-Source: AGHT+IHszlUz6OA/dUOeyg8tjnmbeh5iEFUaZGSDgL5C2iBiVC1BxXHS4d2GbPVB6NFN5UfSrcXH+g== X-Received: by 2002:a05:6a20:9f43:b0:1af:f514:97cb with SMTP id adf61e73a8af0-1aff5149931mr28164789637.8.1716261443132; Mon, 20 May 2024 20:17:23 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bf31a93sm214885415ad.134.2024.05.20.20.17.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 20:17:22 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 02/31] Staging: rtl8192e: Rename variable CountryIeBuf Date: Mon, 20 May 2024 20:16:49 -0700 Message-Id: <20240521031718.17852-3-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240521031718.17852-1-tdavies@darkphysics.net> References: <20240521031718.17852-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable CountryIeBuf to country_ie_buf to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No change. drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_rx.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 0809af3fd041..8a84d61e6912 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -950,7 +950,7 @@ struct rtllib_network { struct rtllib_wmm_ac_param wmm_param[4]; u8 turbo_enable; u16 CountryIeLen; - u8 CountryIeBuf[MAX_IE_LEN]; + u8 country_ie_buf[MAX_IE_LEN]; struct bss_ht bssht; bool broadcom_cap_exist; bool realtek_cap_exit; diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index 4a0db2dfd5e9..dc0db6fade0f 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -2184,7 +2184,7 @@ static inline int rtllib_network_init( network->SignalStrength =3D stats->SignalStrength; network->RSSI =3D stats->SignalStrength; network->CountryIeLen =3D 0; - memset(network->CountryIeBuf, 0, MAX_IE_LEN); + memset(network->country_ie_buf, 0, MAX_IE_LEN); ht_initialize_bss_desc(&network->bssht); network->flags |=3D NETWORK_HAS_CCK; =20 @@ -2343,7 +2343,7 @@ static inline void update_network(struct rtllib_devic= e *ieee, dst->turbo_enable =3D src->turbo_enable; =20 dst->CountryIeLen =3D src->CountryIeLen; - memcpy(dst->CountryIeBuf, src->CountryIeBuf, src->CountryIeLen); + memcpy(dst->country_ie_buf, src->country_ie_buf, src->CountryIeLen); =20 dst->bWithAironetIE =3D src->bWithAironetIE; dst->ckip_supported =3D src->ckip_supported; --=20 2.30.2 From nobody Tue Feb 10 23:53:31 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF7461D52B for ; Tue, 21 May 2024 03:17:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261446; cv=none; b=bq9iIcexdR/DDXsKyPeJKA8/Qpq/GCIVBfLWzUE0VRqDNuM3lzteNS3UdP7gCwXL2oBlngPCTGqB3lTrK513YOiO0H1yDI4p+KQlzjDVlY16Dn/tb0fttqSE5EndXhvT8itJaA3sv4++YDGT05jN55jVKMoqhZ6y9pu4VqVJmQg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261446; c=relaxed/simple; bh=ebhL7OWyfs31SLaHB1cYxnl7cOPvEZeqPuUHXc5pcNQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=CtMRn38R9FEN6StSHJDe3/UlbQO1YsI3QF92xb02wW7QjvCQNJoTlpz1wC9NxoHe08NMmGXv2zaTkLGbnqweHSvl3Bb2DpzBj8m4tPjNplJHua/iKcKLE4Icsz8B7jL1EhtCWklXivEZWhysEVXQdZrpN6mQMtmsLO7OYyWXd8Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=bX9WWI2r; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="bX9WWI2r" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-1ec92e355bfso107909875ad.3 for ; Mon, 20 May 2024 20:17:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1716261444; x=1716866244; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3P37hzP+paRdjgXjGabfu2gjX5afmH1EUMnSM6TIDMs=; b=bX9WWI2rp9QnuAH9Fz1ayfczIw07fmSrPHU2aw4NTqqGQT3LBUzl3gsY73zsRBf1YZ Ch9hyY5xDrjQokRcbbW+T6CTOt0ZyfVtwyb0EvrQj5vE4Gkgkd37w81+XRECsMUlibpk +m11KUn8Q2Lc9Y0+fmx2ysIyUrB4HVAVyinF/PaFOk+DMUpUB2Wrwj0+mRdJmyKB3T8p jGRO5zR04zx9oFLcxifZ+8ppBPXEsNmy26p8v0lalQBMCE9EvOdVYbti30gkmgvxTFl0 MKuonsiKF95wFyfnwp2aP4KU3qEE4qSUt1Cffzr/nbOQbxSGMQa6orZ4bzfELVEBDize 1hZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716261444; x=1716866244; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3P37hzP+paRdjgXjGabfu2gjX5afmH1EUMnSM6TIDMs=; b=EvFZnpwhywUhSljbAlBGtBU6R4RSufqslW5oIpd2nq0cyHuIrE16u7q0MEppiL1CsH ZG56hrgt1J987dNp/1i2PXu5cpYdPJdVG3o5ISzXRbjodsq/UotlWRB1nEI7R1fxWSat I6GXWe5/xfJ1uhWdy2DPBKvrM8c8OecNAJIMSfATxKHSNp0dIHPF9vOzTQAjBTTI49XE w1gQQOnMolKkkQsXBg4x3jjbXD4Cq+WB8vkRj8mPP568iCtYvplHacesfzkwMupdXNoQ PXhrquRpoPiUdwhRFhDvQvTzEmDWa2V+m5dfvmVZybYT/MdOT9vuSMhR+wWN2QtSZnNf YbEw== X-Forwarded-Encrypted: i=1; AJvYcCVKL2NklkloudJN9O55Z9whSKSTZqDtgEXR7QLV9ocD5OWKXujlhQxPCNs1tCuHtKnCLbEuEjeZz9CcJvRqWPv4w0J+ZRRyk3zkxxJS X-Gm-Message-State: AOJu0Yz2lR6Odynru0qYWn/VSH9V6rdFk2l2EG36ubE3xioB+lQE4eS9 8wAuimALAsmsQH80U7kejyDBlBTF+aY0DMmPqhfItnQ84wbtDIFTtqcb+2WTWSA= X-Google-Smtp-Source: AGHT+IEguD0lIgnB383cVpP59a3+EhvaL8r/2t38JuAG5vekRSV96M1f9rt5EICHCrC7qXiplCmvTw== X-Received: by 2002:a05:6a21:8cc9:b0:1b1:d31d:c0c8 with SMTP id adf61e73a8af0-1b1d31dc132mr8718679637.32.1716261444057; Mon, 20 May 2024 20:17:24 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bf31a93sm214885415ad.134.2024.05.20.20.17.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 20:17:23 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 03/31] Staging: rtl8192e: Rename variable CountryIeLen Date: Mon, 20 May 2024 20:16:50 -0700 Message-Id: <20240521031718.17852-4-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240521031718.17852-1-tdavies@darkphysics.net> References: <20240521031718.17852-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable CountryIeLen to country_ie_len to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No change. drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_rx.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 8a84d61e6912..cae4df481397 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -949,7 +949,7 @@ struct rtllib_network { u8 wmm_info; struct rtllib_wmm_ac_param wmm_param[4]; u8 turbo_enable; - u16 CountryIeLen; + u16 country_ie_len; u8 country_ie_buf[MAX_IE_LEN]; struct bss_ht bssht; bool broadcom_cap_exist; diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index dc0db6fade0f..1cae6d6efb96 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -2183,7 +2183,7 @@ static inline int rtllib_network_init( network->turbo_enable =3D 0; network->SignalStrength =3D stats->SignalStrength; network->RSSI =3D stats->SignalStrength; - network->CountryIeLen =3D 0; + network->country_ie_len =3D 0; memset(network->country_ie_buf, 0, MAX_IE_LEN); ht_initialize_bss_desc(&network->bssht); network->flags |=3D NETWORK_HAS_CCK; @@ -2342,8 +2342,8 @@ static inline void update_network(struct rtllib_devic= e *ieee, dst->RSSI =3D src->RSSI; dst->turbo_enable =3D src->turbo_enable; =20 - dst->CountryIeLen =3D src->CountryIeLen; - memcpy(dst->country_ie_buf, src->country_ie_buf, src->CountryIeLen); + dst->country_ie_len =3D src->country_ie_len; + memcpy(dst->country_ie_buf, src->country_ie_buf, src->country_ie_len); =20 dst->bWithAironetIE =3D src->bWithAironetIE; dst->ckip_supported =3D src->ckip_supported; --=20 2.30.2 From nobody Tue Feb 10 23:53:31 2026 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C8B542056 for ; Tue, 21 May 2024 03:17:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261447; cv=none; b=MTdCUZYwmTuqveLdHIjJO8qwzmSN/FOa6QJ2WhnMajTEvdpaNV3wXsO9G86YrsV8XXB3SjrYnHJpSPX/DVs15R8M5YsnK71RK2+f8zdE7y3IxQlTZRg3BKVdUDgRA+yLjzE4qMiwFuXzCjxiQ2MdHTiBRYU2dQU8q0AAUP8M4zc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261447; c=relaxed/simple; bh=bI19xLqdq+sgsz+YkllY+DoyTJRW1HQq4KyU3VNBrWU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=kYBZK7/xK4YxJRnXbjGrb1cAzmg7oFMOi5t5qTqa9MFAu2kYiIm5Cgyq0PXf9+SlbYr800wl0/3CbD3KzCc8kCGTkzqv17g/gI44Of2SmuQ11S9jSYFZpIAVEPSZpgsMg0NOwU3+smH18Ej3yYN2IBoaFYWQcFW0q27PlnZeCXU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=Ff31qTpG; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="Ff31qTpG" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1f2f566a7c7so64562805ad.1 for ; Mon, 20 May 2024 20:17:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1716261445; x=1716866245; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bmiNsN9OzMbofrVzRzK+lEWu2/pKW/vMoZ6Rvo+XamI=; b=Ff31qTpGFM3Hl+SuOI4ZX7wmeV0p1kc7ycsAYrthTJCQ8pQgLGTctGZTRk8TvCqmKe yPtdWZormQZ4iEPYaURWZCJAm6BRRWNZFc//K3Rk5ZFUfA+lvx/kX+UP4/DEiE5LkFyU urDVfCbstF/T2PxmZ/0frH4sMysRvjah/bOVtbatu6VelpsIKq2Jge6JBLGhNMbjf0wZ KQtgV8C6aWxD0h180nGrliSbl43K8/eAaO8smO8H7j55oaW5TsWjFBmMZY20uRBxJBEL E5tLiAJ0w41oR3HqoitjjHosBYzM/mri3v7T7w/W1wuOG0PT++2Hp/hhVXAUevolKm+I SPzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716261445; x=1716866245; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bmiNsN9OzMbofrVzRzK+lEWu2/pKW/vMoZ6Rvo+XamI=; b=dCW4F+A7MAOMvKrgTFmbqF5DItfgWJrJKanuDTqtjh0vWMeTe6k0c/Yb0dgOiC7vZI C9zwfXIdZyXGL5SS6O1NLeWpM3mmAbNZjohCO/zZuKrOLzQd2xuFxC6L3x6G13XnQ9H3 usHvMkukZDGmVs6DdBjK9iroDy0s4p/jTxDgbNYzj3fq0vVNklxP4EygOE8ujCq9YNhj oYoo5GUUoeQYVXTAA1ObNCo6t9Ryj/QmP6/fFG8yH+Br2Aq4L4BjdU43pzRsOkRszE5J Cy4mrttSnSKMZm/ijCjVPoaLlC/kxoV4QKYiRxBwAAj4Kn63Rc4vEUvOGKJMQzWfLxdH FJ7A== X-Forwarded-Encrypted: i=1; AJvYcCWGNIAr/NcBSc1sg59/M2rzHIBhT+WjIOEr7sIcTRJwLPuY0my1RZk86oxjSWm6saz3Sq4Ko+zfhWTeiUMKejS3gIwmEP1aeLU0Vi4t X-Gm-Message-State: AOJu0YwG9B5FckhqL2EJE0gztbFpdWfYGLK4xYY7rJAN/jtNDiSL97n9 SLOsm6jp5HTkSugj4JYhqyAbiTOxBJrCBjhquRgK4gyrZ5s3ntZ7HKCMIXakmD0= X-Google-Smtp-Source: AGHT+IE3jqKrq16VRelIbjkUBnYCDLJ7AALRudo5VhnkqCTTy7hEHxidb8UlPEdHQE1Ym5H06F/23Q== X-Received: by 2002:a17:903:2986:b0:1f2:f090:b2c1 with SMTP id d9443c01a7336-1f2f090bb1bmr77662935ad.14.1716261444846; Mon, 20 May 2024 20:17:24 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bf31a93sm214885415ad.134.2024.05.20.20.17.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 20:17:24 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 04/31] Staging: rtl8192e: Rename variable bWithAironetIE Date: Mon, 20 May 2024 20:16:51 -0700 Message-Id: <20240521031718.17852-5-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240521031718.17852-1-tdavies@darkphysics.net> References: <20240521031718.17852-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable bWithAironetIE to with_aironet_ie to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No change. drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_rx.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index cae4df481397..40ec29434d68 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -910,7 +910,7 @@ struct rtllib_network { u8 hidden_ssid_len; struct rtllib_qos_data qos_data; =20 - bool bWithAironetIE; + bool with_aironet_ie; bool ckip_supported; bool ccx_rm_enable; u8 CcxRmState[2]; diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index 1cae6d6efb96..d4dbf8052c30 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -2090,7 +2090,7 @@ int rtllib_parse_info_param(struct rtllib_device *iee= e, netdev_dbg(ieee->dev, "MFIE_TYPE_AIRONET: %d bytes\n", info_element->len); if (info_element->len > IE_CISCO_FLAG_POSITION) { - network->bWithAironetIE =3D true; + network->with_aironet_ie =3D true; =20 if ((info_element->data[IE_CISCO_FLAG_POSITION] & SUPPORT_CKIP_MIC) || @@ -2100,7 +2100,7 @@ int rtllib_parse_info_param(struct rtllib_device *iee= e, else network->ckip_supported =3D false; } else { - network->bWithAironetIE =3D false; + network->with_aironet_ie =3D false; network->ckip_supported =3D false; } break; @@ -2345,7 +2345,7 @@ static inline void update_network(struct rtllib_devic= e *ieee, dst->country_ie_len =3D src->country_ie_len; memcpy(dst->country_ie_buf, src->country_ie_buf, src->country_ie_len); =20 - dst->bWithAironetIE =3D src->bWithAironetIE; + dst->with_aironet_ie =3D src->with_aironet_ie; dst->ckip_supported =3D src->ckip_supported; memcpy(dst->CcxRmState, src->CcxRmState, 2); dst->ccx_rm_enable =3D src->ccx_rm_enable; --=20 2.30.2 From nobody Tue Feb 10 23:53:31 2026 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58FDE4654E for ; Tue, 21 May 2024 03:17:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261449; cv=none; b=lYffksm7rChKrovvKRPYdkCjtDC9FMh9K5JLSQecglGtI8W3fODlZpCGpXEJvqsJQwQPXGKOniu8zGTDUO8IKxOR7+f1Hy/IMXXQcJ2hPr0OOpRL+/QZyf6aW6IrYErQrRaOF10H9WPviq6E5e6B65N9CA2uvPlqRGBoQTVJNQg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261449; c=relaxed/simple; bh=yjnVfiPa/m1e7bMoAHPK8wG9ELF9HjLigJk4WoCJGCg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=foPSGN6pv6irGRb/O4VtH/AfDomkO1S3c2y/Mn2yVlvqCzztoE9s2i8HfdxSD1RFx9ppW9WMs7z6X6rYpnrWLhlYlFRmJUr8uqZBsAqEkCo9vxjGgpKWAiItajrF/+c2FLAERNW3QiSm8CJeo4l2TpZLksaOZ8BLasTqJZXwpdg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=FUGwlpUN; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="FUGwlpUN" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1ed96772f92so92953195ad.0 for ; Mon, 20 May 2024 20:17:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1716261446; x=1716866246; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oKQNuljJrQrm0mrk57cCGFb1Ap+racxF02oGqH9QatU=; b=FUGwlpUNleAcVSd/0DKGY5DthU1+WHhGXgsfqSZMSVPNW4mseLI/shtstsjgPayWdp Gjkdofuxa2o8nClBbmGDfyIWAV+1oBljo753SahogTighXp0DYOFZ8SfSIYSYeBW3iv6 C3dipajyzsKpzpa6u4dc4CulHcJj3sFOl+jRymtH/vCsSl7nepsWY3Tr1k2kzg7TqunK f5voxazmxI+HOKbSajbgDSs68Vq9L6FkZ2OopcIaKJsTzqnUL8zxM07uq5ZliVh++H9W XInabWuynv0yNAfojqg2zMEDi5CqAW43SuTuBhYbXZnVUf7KSPuHXi8P1nlGwPubApVW mG1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716261446; x=1716866246; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oKQNuljJrQrm0mrk57cCGFb1Ap+racxF02oGqH9QatU=; b=vovwO0xlXtxdln3eyTosG5YXpUTzYVc3Hel9niSCpWQyuaI5UCKd4u+kbzvltYk4GK QqipMccXFqjy8/gL6w2E6k2vAHygC4STbETUHAFjO4OesdbuZUKj5Pzo8oYjm5N9bsq1 iwtttVRM9rG78lBdpwBwAM3W/lAAZoklm8Imvv3BkwYZG7JyKU/SpqHv2dvGsyuc4YyC 17z4FEQfNdDYvpRLgLcx6zFNTs8r0XyPySyLve4iMPxZ38YGXfOQElbwYjOkIk3aTU6G I2Ss+yEVfY82oS5tfH05KYZ2jHCtgkZw8nKX0LCJiF9qmtou0Nxn4loHW7ghdCCDCjQR g77w== X-Forwarded-Encrypted: i=1; AJvYcCXavGQ1RW1ykJF6zIK52EQhM7YUVWZwqz9gzB1dKU+oY6yQCsG4nh6/EMXUYdvn4p/TMgY5TO0U2ePO8cb6bbElAXSWVGwU0y+vP+6N X-Gm-Message-State: AOJu0YzesRm9sgzHfgvXds4H5faLxx3JuT2N8xbQEDk+lw8ZpXawH+ra E/Ukx+PGigmRxJXpbUJuFz1bZQKlQdndHDrV+2p8G5CaF7x4+UTs2xIDmSQjGWM= X-Google-Smtp-Source: AGHT+IFw96ldbcgB3oflpWfTd8TOYioaKqrI7h7QhyBMYAnNYP6nXm5YDsaO4zlFVR8FeN+BqXFiSw== X-Received: by 2002:a17:902:eccb:b0:1f2:ffca:879e with SMTP id d9443c01a7336-1f2ffca8d6fmr51273685ad.11.1716261445574; Mon, 20 May 2024 20:17:25 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bf31a93sm214885415ad.134.2024.05.20.20.17.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 20:17:25 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 05/31] Staging: rtl8192e: Rename variable bContainHTC Date: Mon, 20 May 2024 20:16:52 -0700 Message-Id: <20240521031718.17852-6-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240521031718.17852-1-tdavies@darkphysics.net> References: <20240521031718.17852-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable bContainHTC to contain_htc to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No change. drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_rx.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 40ec29434d68..ce0cd1f557c3 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -489,7 +489,7 @@ struct rtllib_rx_stats { u8 RxBufShift; bool bIsAMPDU; bool bFirstMPDU; - bool bContainHTC; + bool contain_htc; u32 RxPWDBAll; u8 RxMIMOSignalStrength[4]; s8 RxMIMOSignalQuality[2]; diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index d4dbf8052c30..4e7c491c0aaf 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -743,7 +743,7 @@ static u8 parse_subframe(struct rtllib_device *ieee, st= ruct sk_buff *skb, =20 if (RTLLIB_QOS_HAS_SEQ(fc)) LLCOffset +=3D 2; - if (rx_stats->bContainHTC) + if (rx_stats->contain_htc) LLCOffset +=3D sHTCLng; =20 ChkLength =3D LLCOffset; @@ -862,7 +862,7 @@ static size_t rtllib_rx_get_hdrlen(struct rtllib_device= *ieee, netdev_info(ieee->dev, "%s: find HTCControl!\n", __func__); hdrlen +=3D 4; - rx_stats->bContainHTC =3D true; + rx_stats->contain_htc =3D true; } =20 return hdrlen; --=20 2.30.2 From nobody Tue Feb 10 23:53:31 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2AAF45BE4 for ; Tue, 21 May 2024 03:17:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261448; cv=none; b=CVOSGJPpbEDDAcftOBIJLSid5XULI2Mk/GsuTO5f3SchkNwgswsA/J5bvU7yulyEwpxYI06QHRPUR0DK7QTstBwa0sJKVNebBVvk/LXXqJ2/t8BAv80iU5Bz4GcEUafb43mXZkw3AonP94lVp4bo3xSiKkoumM2uZuuLcV5jLAo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261448; c=relaxed/simple; bh=HAcGEyiHKCIG8JO/8aUs7l9AldiL5WVCu/Fjjtl3Q6M=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=gZrL4T4ZqKQBEjKwMlq2ctJtSKeX/B+fhRv5llbRsPNWaYI3cHYQUP/z6VSxelL/B5ggFZO9aNrePS/9yp+ReczpkzaddeBBOqyA96bnRpih9Q2xY3PBZ8ekJrQxGJtootkLMuTsBfe0L70x7ZtX2PI0rxez5IZ40YGKKMnSk1c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=V1j4nVX4; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="V1j4nVX4" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1ec92e355bfso107910495ad.3 for ; Mon, 20 May 2024 20:17:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1716261446; x=1716866246; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vd9btt6pVE9LpJ5n8h41Qkxs4h4F6F4P2g3ly8ex9yE=; b=V1j4nVX448vZ5vloK1UUIenjuEIZhLQdlvOYmu+Ah5KHe1QVNL5E52kTSteJlM3VEH 0VOR0/qbkwwG88RpUY2nfcXszr+x1pCohdsKpZFI3YWGjTOcPQ8KCgRPceuCexQgPLQH LFXNX67XDT8dsVpYm094eiCMilCBSWwd04NuZf3mwzs7k+5tfiluW8pOqMhukPwR3YJB uQmzbDFZ7yflVBN4bIXrSPzcTV89kFFMWILX0gTvmHIn1gYfmEpGO6zFw2TMhCkEWvSd 0B0lnx6aeXr0kasdDD7ZjZi8gp5Rh999zXFT/GwOR3zELtL29+hl23kEgmARjgfwLh++ 2/xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716261446; x=1716866246; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vd9btt6pVE9LpJ5n8h41Qkxs4h4F6F4P2g3ly8ex9yE=; b=wViz5CCcko2JGtqYimBeRJi9kB21W68Djl43mF2zPrv3j8fAQ63Dv8NhloyrXtPpr3 7b5pwt3UoOI8xthQyq4pQqxOZKNFjMOcfhBxXwHAnNedNFPHQENEkRCJyWxn1AA4ZM58 nWfEq8lRTekuRGVk5fXWbTDCU1lvT5IYUFML/ZdLL5vmIEC3GrKt0PRzEL/yTh4zxElg GsxX1bAIPR94K3EahwivTzotFE4GVOYrWdo3AVKk/7w7eYUkeW3hRtjaS0q9CFKrbVhv i9NidlptVDaHRwIy3Sr4/s09IPVfOBzTcN4YFuBQ688nSFz51aocCU8aNVN64bGaguGI fa1g== X-Forwarded-Encrypted: i=1; AJvYcCVOSWRJn1Ud7yOm6ktlQOZbkgCAcueUadi6XJp3HukL4/z025+Vs0O1nYb2yj5EHFEzYYMg61nAVvBwQS9Upvi3+YD/4Xuhjoci189T X-Gm-Message-State: AOJu0YzvJyNC1NCwkgoAtGsANelc+8B9VAJ4fUHJhIO4XWc6sQVShJIY IY5YAn+usBnxM21ePM1fGz2DDspMcmwEF97U6MK3lnQFSOE3xHrsqlKq6xNoDZY= X-Google-Smtp-Source: AGHT+IHeKS24eWCSBCMhzaXtqlNvcFXLY1ze4ihnnHNRG1rQx5z2MKpVvn9kkaMUz9VJXr/TqxzhJw== X-Received: by 2002:a17:902:e809:b0:1f3:695:eeda with SMTP id d9443c01a7336-1f30695f16bmr35379215ad.61.1716261446316; Mon, 20 May 2024 20:17:26 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bf31a93sm214885415ad.134.2024.05.20.20.17.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 20:17:25 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 06/31] Staging: rtl8192e: Rename variable MBssid Date: Mon, 20 May 2024 20:16:53 -0700 Message-Id: <20240521031718.17852-7-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240521031718.17852-1-tdavies@darkphysics.net> References: <20240521031718.17852-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable MBssid to mb_ssid to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No change. drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_rx.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index ce0cd1f557c3..7f1c2f49227e 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -916,7 +916,7 @@ struct rtllib_network { u8 CcxRmState[2]; bool bMBssidValid; u8 MBssidMask; - u8 MBssid[ETH_ALEN]; + u8 mb_ssid[ETH_ALEN]; bool bWithCcxVerNum; u8 bss_ccx_ver_number; /* These are network statistics */ diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index 4e7c491c0aaf..c29efa3eef6f 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -1823,9 +1823,9 @@ static void rtllib_parse_mife_generic(struct rtllib_d= evice *ieee, network->bMBssidValid =3D true; network->MBssidMask =3D 0xff << (network->MBssidMask); - ether_addr_copy(network->MBssid, + ether_addr_copy(network->mb_ssid, network->bssid); - network->MBssid[5] &=3D network->MBssidMask; + network->mb_ssid[5] &=3D network->MBssidMask; } else { network->bMBssidValid =3D false; } @@ -2351,7 +2351,7 @@ static inline void update_network(struct rtllib_devic= e *ieee, dst->ccx_rm_enable =3D src->ccx_rm_enable; dst->MBssidMask =3D src->MBssidMask; dst->bMBssidValid =3D src->bMBssidValid; - memcpy(dst->MBssid, src->MBssid, 6); + memcpy(dst->mb_ssid, src->mb_ssid, 6); dst->bWithCcxVerNum =3D src->bWithCcxVerNum; dst->bss_ccx_ver_number =3D src->bss_ccx_ver_number; } --=20 2.30.2 From nobody Tue Feb 10 23:53:31 2026 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D01B547A76 for ; Tue, 21 May 2024 03:17:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261449; cv=none; b=Qjk10IgTWWHI6T1cuATe0rWLmtSvSwcl4SY4PNEaXIMimlSKKgXenrixbG8bzpi8aWYTRoEmNTySookXhIwLqApisCCjD4kBL1ewYNEK69VQQHcq7RTYivg2gZT/3wdZpKyQuilR6UPnclJPh/PnnAFjrrc3E7etkVfKNko8Fa8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261449; c=relaxed/simple; bh=xUSO0L0OOfzjr5/UosXPyoMQS3r3Io2/L3l6piKs/5A=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=g0sNhsfOCbmyXW8T1fUfV4lxyZnd5JRRW01HrLjO25LxA2G12HXWCLrm1uJ8vasVpaMr8K3oCn9sdaJ+uRX8GwPLAIHYQDEGGZC7nJOpBTHHaE5KHozxrAFmXN744bmgD512T/b+Jhp8jV/nb2vCx2DiFp4XGvmkrsFQ5T4EzP8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=RYWLW1NC; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="RYWLW1NC" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1f2f566a7c7so64563215ad.1 for ; Mon, 20 May 2024 20:17:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1716261447; x=1716866247; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lJ8EqTPc0f85y/sPEaQ2P9Fmp+Ujn48v2g0YjXV3Sdc=; b=RYWLW1NCt4aA2XPC8uzfuaxoAvyLcIUNyE4YTeHezRlOTnbzZbUZYpJ8u/YSpClsgE GN3DoNte4atLYqFBnHGIL9+VLVLTjW4f09QxkGoLkDVTksAtLnad3M3fob4JCItCmEXv pcLNqTHdTHBxKLXW+P0H+GFl20SghYCnBJ1iVA2vx9zWBPE5//zCP2lsYf9G3whr4opp 7nDIRAGiqK0fOra7J0TESQwTjLKdz/A7+3oMG3iC5MVwOeY4FBjeeDI4esHWl7UwCrEt PPR+mISvTGegkpLnLLHEM9O2CqfTOHr2X6zMopYUZkclzZ3vrhlKkLCiDSRiCB8QnXPi kuMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716261447; x=1716866247; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lJ8EqTPc0f85y/sPEaQ2P9Fmp+Ujn48v2g0YjXV3Sdc=; b=CmEn0oByn88VxTx4S7rOgwGhVW+Y8P6nr/PJdrf/KXVSJZxuGOhGybWDA6zbtxJg36 o6nAzHGXumhrYTXUqtt7vqyrhDBr+BVXlsbRK2YxsxyiI14jOGzOJpLz0mfXT3Isr+cT toPG+7vwoJEO+kJI31Fyf5HuiW+VHi+GTZ//upcZWQnV7GknYMcHOclkzZOECS1luc1v r5jR/r1IkFuNKuXbfW/uoH6M/Bvoh/YMRkAbt+MznF/eYAPA1BR8SC465wOvmTLwV6o7 UBbr+jxT+gt4qq3UB+WqpiqtZWhQ5/Y9hKtPbpBuXTRUsItXqAAxrBGY7Vsr5MUnMeDD kqNQ== X-Forwarded-Encrypted: i=1; AJvYcCXUs8ybADbGDMMs3rpomCMUGowaHinLMoIQIG6ymd2TBgmBOBmUvruE4QXNMh8q5Wsk0Ggpx5TP9HbnNGsA/x46yFOQDyH3q4hQStFl X-Gm-Message-State: AOJu0YxqiEGGcJlvqok7GTJ6ESTj3aMtkVbKZdbRiaq1eRyEnmXRHQUP LkGkIXkQw1lunwnS4pSG12OCN7ndEDzGmW33Rew+08X84Th4VPC0IEy7jJ4xllk= X-Google-Smtp-Source: AGHT+IENtRCxhNAvkpmcZ59SyrjtbbYxkY+wENlFTVIEpZY1wEkucQ06zKq5zCDgo7JH91LudJzktw== X-Received: by 2002:a17:902:d511:b0:1f3:66f:e030 with SMTP id d9443c01a7336-1f3066fe370mr40450515ad.56.1716261447012; Mon, 20 May 2024 20:17:27 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bf31a93sm214885415ad.134.2024.05.20.20.17.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 20:17:26 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 07/31] Staging: rtl8192e: Rename variable MBssidMask Date: Mon, 20 May 2024 20:16:54 -0700 Message-Id: <20240521031718.17852-8-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240521031718.17852-1-tdavies@darkphysics.net> References: <20240521031718.17852-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable MBssidMask to mb_ssid_mask to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No change. drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_rx.c | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 7f1c2f49227e..3722fc0cae1d 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -915,7 +915,7 @@ struct rtllib_network { bool ccx_rm_enable; u8 CcxRmState[2]; bool bMBssidValid; - u8 MBssidMask; + u8 mb_ssid_mask; u8 mb_ssid[ETH_ALEN]; bool bWithCcxVerNum; u8 bss_ccx_ver_number; diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index c29efa3eef6f..19cb717df3bb 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -1818,14 +1818,14 @@ static void rtllib_parse_mife_generic(struct rtllib= _device *ieee, network->ccx_rm_enable =3D true; else network->ccx_rm_enable =3D false; - network->MBssidMask =3D network->CcxRmState[1] & 0x07; - if (network->MBssidMask !=3D 0) { + network->mb_ssid_mask =3D network->CcxRmState[1] & 0x07; + if (network->mb_ssid_mask !=3D 0) { network->bMBssidValid =3D true; - network->MBssidMask =3D 0xff << - (network->MBssidMask); + network->mb_ssid_mask =3D 0xff << + (network->mb_ssid_mask); ether_addr_copy(network->mb_ssid, network->bssid); - network->mb_ssid[5] &=3D network->MBssidMask; + network->mb_ssid[5] &=3D network->mb_ssid_mask; } else { network->bMBssidValid =3D false; } @@ -2349,7 +2349,7 @@ static inline void update_network(struct rtllib_devic= e *ieee, dst->ckip_supported =3D src->ckip_supported; memcpy(dst->CcxRmState, src->CcxRmState, 2); dst->ccx_rm_enable =3D src->ccx_rm_enable; - dst->MBssidMask =3D src->MBssidMask; + dst->mb_ssid_mask =3D src->mb_ssid_mask; dst->bMBssidValid =3D src->bMBssidValid; memcpy(dst->mb_ssid, src->mb_ssid, 6); dst->bWithCcxVerNum =3D src->bWithCcxVerNum; --=20 2.30.2 From nobody Tue Feb 10 23:53:31 2026 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DEC64C3C3 for ; Tue, 21 May 2024 03:17:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261450; cv=none; b=HmJHXQlS16uDA2/sbHe63wXAUY0ojTqfgmV8RfZLdytw8JM/DAvXaY6+1JU2yLwRrF64ofIerKntbvPq0Qwm2nUS3Ll2UdZc45XuHCu2wEYnbh1kMckZr/ohvBx9V/DQzTa48gSEM9skSQWk1tF68X+x64P4ZEAkXnDN2jrHK7I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261450; c=relaxed/simple; bh=y4YjY+AojbIRMjK164jPJmgD6gUrucFooh+ClOh/re4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=howXy4l/v5GpvaT4d6H5+K/z1FO17irdKdia4asGi9ktw8cQYgs5Tor8FTjjApSDgefNa4q95IK6lWpJlAQeQXytEhpkJKP1R7gWpSkV2uOI/my/Cjy4gj5EOjq/eaH8033eNYthzmM4sgmA8tvsgdajX50GjzxpLz4Z3di4JFw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=R6Hb/Fx/; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="R6Hb/Fx/" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1f05b669b6cso92908065ad.3 for ; Mon, 20 May 2024 20:17:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1716261448; x=1716866248; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MEthYODi4I2R9YSYx+IY/meHc3WazGs4QoUP4G2Bq/A=; b=R6Hb/Fx/e9uQgbbdCv9chBTeexgajxFA12hk8ewRjtkIois65R8Rm5Uo0wPI6ORGQE aSpoHdZOv8bFG5pNe+08GMC5gnf2AF6vBRvwophP3UNbQdHqps3mUSId21LZWzgeaKml IruaKWMoHfPJOZJy7YnsBPhXFs3LQu83tPI/2CN9I01BFtKLyOYboOhgaIQYdYSnaQJd MD8xq2uWiCwrD7ynTwBrNEPoMR6gsflfjpDAxnM1LSQPcEIskodNmRMRHupF1d3yeWOm SepAHKJEn/827tvgugfObLwBwrNAm9dV6UBzJro10XcWTR4A5z9PnHgwdm/T4uDaS/eC LrAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716261448; x=1716866248; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MEthYODi4I2R9YSYx+IY/meHc3WazGs4QoUP4G2Bq/A=; b=b/mpTB8lqdyQ0t2ZcPNPKBv3UWnnpg4rCxTAMhycVtLedxEVEwWeY8IMWj0+WHnxwU Gc5RDQRjSmKj92pG2ayAqjb8jgYuObPE4rPduHqJH3ZfWS4mqf5XFdnwtn12UhU5pKhU h9++QqWP9Vv7zfpPxyUzvmzjjU5sxuDuHedXYJxCuzxmPzyMz6gKSZx3peaOOCMTwhba 8wCETftgpxvcB4COi15UCA9MIyc0Nl1vlZ42M4XZoooA2i+ziUZAVWV6Wkr8sqZfRqLs 6Nv9AP0PKyyP8IrXeus2uEZ+3mS3H+M3fkOI0APAIv1KPVUO8N1EhKj7Lb3xF66h+6ve odBA== X-Forwarded-Encrypted: i=1; AJvYcCXJE8vHnD8bFjRi5Mo3cebDIJPAdG18fu+aJayQGDJY9c5GRKbx7w+E40vszExUVnRfvtxjXgyNJ7RXG89UpFks75zZbhjbZP+iBM2l X-Gm-Message-State: AOJu0YxXstn1KD0Vk9K1yafXDX+C3TQtYh4aGQd6xp3oevYczC6oSiyf FjsHXAovNQu0ua/JJDYPHVS4GBgkTiRmOl5Mk/ilVLXRkhP+o5qr3bN0v+2QFc4= X-Google-Smtp-Source: AGHT+IE5In+DU67hMeJ+W7Cqy83Za6bcsr34N7BNepHTaCmbzXqcBBJbdgHcQWECMG9sAETxWRQbKQ== X-Received: by 2002:a17:902:d488:b0:1f2:f566:8908 with SMTP id d9443c01a7336-1f2f566a562mr77412435ad.52.1716261447741; Mon, 20 May 2024 20:17:27 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bf31a93sm214885415ad.134.2024.05.20.20.17.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 20:17:27 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 08/31] Staging: rtl8192e: Rename variable elementID Date: Mon, 20 May 2024 20:16:55 -0700 Message-Id: <20240521031718.17852-9-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240521031718.17852-1-tdavies@darkphysics.net> References: <20240521031718.17852-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable elementID to element_id to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No change. drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_rx.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 3722fc0cae1d..4645fe803a15 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -728,7 +728,7 @@ union frameqos { #define QOS_VERSION_1 1 =20 struct rtllib_qos_information_element { - u8 elementID; + u8 element_id; u8 length; u8 qui[QOS_OUI_LEN]; u8 qui_type; diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index 19cb717df3bb..76389aef53ee 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -1456,7 +1456,7 @@ static u8 qos_oui[QOS_OUI_LEN] =3D { 0x00, 0x50, 0xF2= }; static int rtllib_verify_qos_info(struct rtllib_qos_information_element *info_element, int sub_type) { - if (info_element->elementID !=3D QOS_ELEMENT_ID) + if (info_element->element_id !=3D QOS_ELEMENT_ID) return -1; if (info_element->qui_subtype !=3D sub_type) return -1; --=20 2.30.2 From nobody Tue Feb 10 23:53:31 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A90A18040 for ; Tue, 21 May 2024 03:17:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261450; cv=none; b=eQflZTJM+hyeRaqNl+8iqIxVLDuIViSv5Q5XzzNXg26ZtclgK9FULxpvzamASi/NeebsBzgJDaErhdmmIQf/qyt82yh7O2DjIB/WLEiL+voK7AURxMUEqLNnEBJEn7uYBpafuEb8IRmker3V4c0RfutWG+7Ihq/4oaJeFTGeQD0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261450; c=relaxed/simple; bh=BUrbjzcQWwyURME4rVWO/h6tgucWYD5267uEWABz2kE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=L0IdWz5/EnfbGAFB6LMpbU44hImC2wuzL6kC8JQXCF/ef+HfmlBohYPRe0pHBgBR3oqzRzZzz2mgcj/cd6to7/YCZMwC8b4MRDxJdDZ9IjxrioNbHeKyNQPHYrBNPIg/wDUMlaxJ1E9HFLaTstk+VrqFCuO7kneEXXdLZgnm3tw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=hsN0zHq2; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="hsN0zHq2" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1f3105f3597so1963855ad.2 for ; Mon, 20 May 2024 20:17:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1716261448; x=1716866248; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NZwyL+RFncPuaE+b/XOsaY3FBas0Jn4bpiLgCt4nDwA=; b=hsN0zHq2pqz0hPApH8aJzJFu3vAnjOScpgZwlFiXV2+jOjdEneI8yvfhEZQ2T6nu69 ZX6ViSGo6iMZnscl+9/0oVqXFyd4wgtpU6IObhevISVLs/INaxrTp/n3JvuPDNznD+x8 CjXCcxqzIu+jyYitI17L/yb9A9t8tp/kJNFlnZIyDmYLX4oUEI4MK18HFE3nu3I2hRr1 HcrMLEVo+YUDGEybYvKUbJVfs01mvkWkevqW0VnXhUWfLnjF+7N38afVjW3jrou5hOwK IYazG3NJ2RK6ARrrK+4nXF+Ti9atgCDmE9BPdXx9VQ5855MeXLaqnnRMQMPlUHwopPaN 3j/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716261448; x=1716866248; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NZwyL+RFncPuaE+b/XOsaY3FBas0Jn4bpiLgCt4nDwA=; b=QEPlZv1R3psR3ov9TW0eG5ZtPcXkmbfklNyykcFndzFxjXVlA4BA5wbnqkK6l9OylA aVqxw9Lw9pGchUzFSIjTyAB5NMEH1aixH+8zyHJmPYyUm9z9DGksUtu56/gAyfPb5zbe P9o2TPgXiU+cylF3vszSnBiSegHsKZ2n3E3nKgeIg4zrTDdyNeRJMuQTQxIkpMQ5f8nO 7AWJpZnobZ+n698s+7Qc7EtH4yR/FOvl59rGQGwLLMgfZFge1GvEMOhEcVJcS+vUGizO BO3leKXXtwlAtJIACk7GnrBxEXdhDGWClINqyomfH4IK69StupuN0nC6jHpt1PDU8yHK QVxw== X-Forwarded-Encrypted: i=1; AJvYcCVm6vX8/atKBmpvulFUgStdUAwGaPwmjjq0qDTaRzakJCZ3nepJVivnMQG3ETOne5K0cNWoSnssNpWxBlFWeIM/5ZCac1fYG4ISTlyn X-Gm-Message-State: AOJu0YzHrAcK0tG3JB709eVGI27bw2gnjdv32B/DmICD2SiXhyZ2AQIb AlDNSLqyAjxRVzASPkaS4KyBoWyoPj/6jJxBGOd3uNR+uyy/mqjchTkRqZIB1P4= X-Google-Smtp-Source: AGHT+IGyMNiay+OKPoZtkCBgoCgQD2kIuJLu79V7dIocZ4883CscupBlVT6PBm4ZfOBZs+l6TZHs0w== X-Received: by 2002:a17:903:1106:b0:1e6:1a7a:98df with SMTP id d9443c01a7336-1ef44050d9emr371334135ad.66.1716261448514; Mon, 20 May 2024 20:17:28 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bf31a93sm214885415ad.134.2024.05.20.20.17.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 20:17:28 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 09/31] Staging: rtl8192e: Rename variable rtllib_rx_Monitor Date: Mon, 20 May 2024 20:16:56 -0700 Message-Id: <20240521031718.17852-10-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240521031718.17852-1-tdavies@darkphysics.net> References: <20240521031718.17852-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable rtllib_rx_Monitor to rtllib_rx_monit to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No change. drivers/staging/rtl8192e/rtllib_rx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index 76389aef53ee..108fe1520cf9 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -1383,7 +1383,7 @@ static int rtllib_rx_InfraAdhoc(struct rtllib_device = *ieee, struct sk_buff *skb, return 0; } =20 -static int rtllib_rx_Monitor(struct rtllib_device *ieee, struct sk_buff *s= kb, +static int rtllib_rx_monitor(struct rtllib_device *ieee, struct sk_buff *s= kb, struct rtllib_rx_stats *rx_stats) { struct ieee80211_hdr *hdr =3D (struct ieee80211_hdr *)skb->data; @@ -1434,7 +1434,7 @@ int rtllib_rx(struct rtllib_device *ieee, struct sk_b= uff *skb, ret =3D rtllib_rx_InfraAdhoc(ieee, skb, rx_stats); break; case IW_MODE_MONITOR: - ret =3D rtllib_rx_Monitor(ieee, skb, rx_stats); + ret =3D rtllib_rx_monitor(ieee, skb, rx_stats); break; default: netdev_info(ieee->dev, "%s: ERR iw mode!!!\n", __func__); --=20 2.30.2 From nobody Tue Feb 10 23:53:31 2026 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04ABD18641 for ; Tue, 21 May 2024 03:17:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261451; cv=none; b=FfLpXZRgcqmyz7OJ/l/pmJpF3OXt7gfnHfJkLDUC3TeQhtY1dK9yDOuygg9/O50YPTBp870cOdY+MQBFQ5NX+J3Etv1pK1UvpLq0mF2+uu7rNlhf8aEJrYIDvog5V/4nCF0vejVQ8el5ootUMfoAuNmSzQObwP1xYneDtRpHYXI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261451; c=relaxed/simple; bh=XPJI+WS4EeMm9YhpHRUqULnGSCpjTomPq7hFHW5wa5g=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=g3CDArP6y3K+1lTNG5O3jhYjKi2kEu9OLjgKKkwMTMaviyYNUWdNIb7KCKdXPaFhDmkXQiWW/aHPiHjDZ/Q0GPGQ0VG92hKDfzwqgxQKfHzDbG3IbvyR++rKCGEyNPLrbutOTz8vmL8EXX1SBqLOb6sNv16CdlOox0zenHKNUyk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=awRJxGwR; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="awRJxGwR" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1edc696df2bso30587565ad.0 for ; Mon, 20 May 2024 20:17:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1716261449; x=1716866249; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8m47pozkJx2xYmkwgf2WxpxVuMQVKY0n0nxGrHzab78=; b=awRJxGwRhfoe86ga8MoKAHTu9oh4L1K0RNa+2tVCKoZlbPUd1rpCWF+YA7xQiVITKM i7okboUCeSKJ76XVN3ZiddDDmSwV/PAQzwdpeLNvTTuNmHllyom+GRZ5g3PcHaQAJfn3 Kbb2IhTEDvekpZt8wG3Ts2Hqo0A7d0QylgBBAlD6aHzMebocTjzykU5wJ6rsB/JZrrBC zfr+5RwOubn1kUECbWNK4z6As91oxTCrrYYmaCVX6f3xZ58Gobz4DdpzFp5LoOaPqoq5 1mOuIqle7XXq85ZQ1c8/mkvI97viAvRJ4xq71FgFMMAt/bParAO9ND4Cth+X6dnWenIM vZrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716261449; x=1716866249; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8m47pozkJx2xYmkwgf2WxpxVuMQVKY0n0nxGrHzab78=; b=Vud0BrPxiMvXRiBkA9s5+soVV+MdaFeE4hRKdfj/yJCh4CRLNz+5nXzgkRrQTjHlyl f9gGk3ObFsivX26wRmnS22p5YPpZaZy8yergGvCQXlgtXiIrA6LFMeNraccp5VumawA4 x2DXbbbe6QK4BnHnUuKIRdDVwl07peGyVLGOheYG4/0XPcvmVB6RgqAcsiXWigtl96UL 1deOvMoQOwjwdZTz/OYGqgcgRNoWLJAAFjtAbYUBQtg6StzLbKqfQIakmb/L44AyAWEY i1OH6jIYfSFv9LeZkivTGu+m6XFnQ7V1qk3IHIIepqbZL52nJw6KKYfVOK584I5Bi/M7 fcCA== X-Forwarded-Encrypted: i=1; AJvYcCUjCxuyau34hL0xFVFgqBoN/IHY7LTu2J/4JLvzfI9Ta6wad0dwMzk+ikUslWvbrQ3NPkvnn5TqY36dpDLT82RXlndcJ+bzlZFgBic0 X-Gm-Message-State: AOJu0YwXnhzcU5tEWKWZ+13+DQ8jyWPh0+Jq0mVhSLmfQjsN/3H+jISd BK8LvhlIpGaYlm65hXZeyRsyQdbvcNSguCEB1xxfb30s3zTRErHdrsae46u7BQg= X-Google-Smtp-Source: AGHT+IF8XMIr22vZBHnnoWoHa3Q8FM+pktp2JXxMwSQx57nMRLvpMYto1JBLC0Ubt03+7danJPVlmg== X-Received: by 2002:a17:903:2350:b0:1f2:f854:f54 with SMTP id d9443c01a7336-1f2f8541142mr75795665ad.62.1716261449374; Mon, 20 May 2024 20:17:29 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bf31a93sm214885415ad.134.2024.05.20.20.17.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 20:17:28 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 10/31] Staging: rtl8192e: Rename variable rtllib_rx_InfraAdhoc Date: Mon, 20 May 2024 20:16:57 -0700 Message-Id: <20240521031718.17852-11-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240521031718.17852-1-tdavies@darkphysics.net> References: <20240521031718.17852-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable rtllib_rx_InfraAdhoc to rtllib_rx_infra_adhoc to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No change. drivers/staging/rtl8192e/rtllib_rx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index 108fe1520cf9..ea8cab9707bc 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -1223,7 +1223,7 @@ static void rtllib_rx_indicate_pkt_legacy(struct rtll= ib_device *ieee, kfree(rxb); } =20 -static int rtllib_rx_InfraAdhoc(struct rtllib_device *ieee, struct sk_buff= *skb, +static int rtllib_rx_infra_adhoc(struct rtllib_device *ieee, struct sk_buf= f *skb, struct rtllib_rx_stats *rx_stats) { struct net_device *dev =3D ieee->dev; @@ -1431,7 +1431,7 @@ int rtllib_rx(struct rtllib_device *ieee, struct sk_b= uff *skb, =20 switch (ieee->iw_mode) { case IW_MODE_INFRA: - ret =3D rtllib_rx_InfraAdhoc(ieee, skb, rx_stats); + ret =3D rtllib_rx_infra_adhoc(ieee, skb, rx_stats); break; case IW_MODE_MONITOR: ret =3D rtllib_rx_monitor(ieee, skb, rx_stats); --=20 2.30.2 From nobody Tue Feb 10 23:53:31 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAD1B53390 for ; Tue, 21 May 2024 03:17:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261452; cv=none; b=MG6gjJ5dNNGoe/BgE58igEoI7SPnj0PUy3iBHYZeKfdRAkm0vNej+NKu7gatnP517hPno41/79REFdWf/p6XO0B8cdzU41+RG3zCFZt+ajw05FZ2ITjnW3IZtEPOzlOPkyTRY0aJaicai1zYdhEvRhRzLgclKty8zThpLl4FusI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261452; c=relaxed/simple; bh=gVS9SiiP3Jqr/gOO8soEZkMdLYajewLyAHFLwln8wjk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=r+ZGK2KJVXRKVZa9Cjrx6iOOBF4JGhXgF46wZOrNQhaP21EbMwHvfh0jo2iL3MNsGcwX92hUstXIIu2oN0ShXf6SfU8o4ZkPfGujvJT4OuhxhzgxD00d827mfmxarK6jid59l4kDFpK05QqPNxsKSDziolaCl1+pvM/BJFuNjb8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=gyDI/vb6; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="gyDI/vb6" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-1ee38966529so24148945ad.1 for ; Mon, 20 May 2024 20:17:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1716261450; x=1716866250; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=u9y3vOCZ0Z5C3M5gLdN2/bw89sLnlW10XMSKoOopYVI=; b=gyDI/vb63CC3nKQQkdioDSfBLne5eZ0YBqlCS6bJudywnkH6w8tf1qFK2MRs/foUH3 o01/P+2nntC9SCzMNlQqSS+PkGlzhrDfYnMoFmNUZX33tiNGrkyYsCr1FCEHuv7Qp9rs Italx9SmkQq3GP5U0GF10kdez+S7LWcdnVqF2flyGCUuZNSi0/iB7GqTo3S0QbEQXA+X br6Okh96L/gjaR8WpgsVn2QhbV8XZYBtOT8Cvb0QDQyCztuDJ0/cb0hKrjF6IxC9BDPL QsJXSg3ZbMnA1sytHcB/Vlw2EtY6EPKOGEJjcm8gEdtGYhzoopSspBZvnZgEYC0SUsfX TOJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716261450; x=1716866250; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=u9y3vOCZ0Z5C3M5gLdN2/bw89sLnlW10XMSKoOopYVI=; b=Wjk8Ky7PWJk5RYzL/gb61Pj2NAzsFm9FlIbULVLXZg7P49jpR+miXW5IwjM5SG9TzW ZstNsy3H7wNdOVqJNjXWJiXCoySqJ7J4K7/N1X4FB13nJ8d/G5PbN9C7GLTkD3s9ZOgK KorZHlA3VP98AleeO2C/txxIiA+w++xfMiEqB5dk+AkAf31BcRs4c30ne+F2Xr2uHB5/ 5RRuR9oJRiUOdhP87pJ/xHREBrrz/ry/pbpFGWU+ioj3DFrWFXVPxPIhpI2FSb8CMt6i EN2U8cIPqY5QodyuMPZoa3Eyj+QXKIntpJ8u+fCu5ngZNMI7hNjfssY/cMub5CU0Xjeb KW7g== X-Forwarded-Encrypted: i=1; AJvYcCWIcMXSAbcl2xilo3vo1gdpSkbW6grU95dCMUCJVVLckrNI3Lz1qJuFzr4TdE4/9ia5AsDWEFLO2nnMmAxBMGFoEXJRgD37xNKQZDfF X-Gm-Message-State: AOJu0YzCx16M7HqUIIJlLIAdQTOifH+C9KS4O6Rslf/53XoZFhPjr4fY x/5xLgZ7qEMRGjY4OcVCO2fqm77MLsz9RToZn729vWSroXAFQCMLCd10tLdyQyc= X-Google-Smtp-Source: AGHT+IFjkVC8ANjXpaRvethnrKCdkYfNqHmoD7I5z11eexJoDDsjhzYeSydmfkHG3t7A7bSzHN/OiQ== X-Received: by 2002:a17:902:a50f:b0:1f3:b38:aaee with SMTP id d9443c01a7336-1f30b38ac34mr18877605ad.24.1716261450105; Mon, 20 May 2024 20:17:30 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bf31a93sm214885415ad.134.2024.05.20.20.17.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 20:17:29 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 11/31] Staging: rtl8192e: Rename variable IsLegacyDataFrame Date: Mon, 20 May 2024 20:16:58 -0700 Message-Id: <20240521031718.17852-12-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240521031718.17852-1-tdavies@darkphysics.net> References: <20240521031718.17852-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable IsLegacyDataFrame to is_legacy_data_frame to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No change. drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_rx.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 4645fe803a15..cdb3ebc77a53 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -339,7 +339,7 @@ enum rt_op_mode { =20 #define FC_QOS_BIT BIT(7) #define IsDataFrame(pdu) (((pdu[0] & 0x0C) =3D=3D 0x08) ? true : false) -#define IsLegacyDataFrame(pdu) (IsDataFrame(pdu) && (!(pdu[0]&FC_QOS_BIT))) +#define is_legacy_data_frame(pdu) (IsDataFrame(pdu) && (!(pdu[0]&FC_QOS_BI= T))) #define IsQoSDataFrame(pframe) \ ((*(u16 *)pframe&(IEEE80211_STYPE_QOS_DATA|RTLLIB_FTYPE_DATA)) =3D=3D \ (IEEE80211_STYPE_QOS_DATA|RTLLIB_FTYPE_DATA)) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index ea8cab9707bc..24136bba64b6 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -882,7 +882,7 @@ static int rtllib_rx_check_duplicate(struct rtllib_devi= ce *ieee, if (!ieee->ht_info->cur_rx_reorder_enable || !ieee->current_network.qos_data.active || !IsDataFrame(skb->data) || - IsLegacyDataFrame(skb->data)) { + is_legacy_data_frame(skb->data)) { if (!ieee80211_is_beacon(hdr->frame_control)) { if (is_duplicate_packet(ieee, hdr)) return -1; --=20 2.30.2 From nobody Tue Feb 10 23:53:31 2026 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BF0A57CB2 for ; Tue, 21 May 2024 03:17:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261454; cv=none; b=KsfQs7Ui5tuXXmR98XXsqyODNGPi74ZrgB5GA53Ef97DsItS3eyYoT/GC1K6D+yiB3M5a/7TXmlJobtPdPNdvi3ZeGWluk4BT17UlUDYG0KrAWgyQKsaCqzRC/prx78payEqlT7XVkWgWgjE/PSHdvPyxz9hd/2mOXX0ZO4PEO8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261454; c=relaxed/simple; bh=zfJSmyU2EaunM1LXwvAIWF2URUqaOE8rSUmMagLurcI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=AtynjAz8OJTmUZfU2/LGB7u+i+4Ut03+MaOl4k5lDzlzC/QPvY2eH3870UWSWEF8ifHvesBga4eyToywjap8BQKtlTG2yZVlEndBzz1m3Cdnh8l/uZrquvY1BeIr0aQhn+5dSfqma0QOQn6e9FE9k+4vwf5qcCKuR+Y/grAwqwU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=DAx0hs6g; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="DAx0hs6g" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1eb24e3a2d9so105652955ad.1 for ; Mon, 20 May 2024 20:17:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1716261451; x=1716866251; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SEABkOW4VKvCqiq5IqHnapExkz50KHLin5f7EBQIzfk=; b=DAx0hs6gRBOQIUcAoPTD1or8j4KlAw9GrsN/7VIUG096sTR7S6Y4COfUcCsG5gHkP9 TAw4yV3dSBjw+mSDhtwsCE7vOVLgUVAwTbzIt7JlUihAr5YpSOoSmvoR1wAFoGfIgLmW l5YKU+vEz5pJupPoATK9sWYDHXJoCNujsjBdZ0quFmC2AG5uN7go9IY70fEj3tPerObc EnYNvsKN8vFOxiWOObVhR9XSpuZA8d/9arh6+qTB2SEDwS8LVnF4yj/2WGgK40ZtVtK+ DSH22uJZe+EzS2horWsTG79rAz/5/q+Vz5Jk8wUI1b3aoQVeR6EmmQAiQKbuf6oOVdVx QU1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716261451; x=1716866251; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SEABkOW4VKvCqiq5IqHnapExkz50KHLin5f7EBQIzfk=; b=f8EAT8hd4g6NKHThFEOSaNkxdaw+qrAA9tndxgUwjStsGvW2F9le/qNcOPKSv/Sdlt dboDmpTKqL4+u7+vTibE2Yy7Vu7ckdbXXop6PtX92r8pZzIfBNZdZz7SEADZvR9lqtBX 2M8Eq91VEdBBYFV3WRtxFu9EBSfuux21Us/RTzNT9dXCbDthwfpBlgCIClFOJiWyE7nC l8VGeZi1m7OlpGZxyt7L5wCZDZPr8BYJtzQ9aH969pjufRJNVc5zImz0Fy7pJK2Clusk 88jYgrvhJScIdkwCdAWVBzivdSjYaJZ4xvfjmE1oFLxVd565C495vdxTH2br6QdJ1GK5 IAFQ== X-Forwarded-Encrypted: i=1; AJvYcCUbUDNT3UX8Jy32rPgEpoM58selTbvR96E8+0DD5KwzcIUCq/cqLpMFEhzTKMxidxNPykxNzWIX+Sf1iUYwJHSA00ScRKTqaUkQN7u/ X-Gm-Message-State: AOJu0Yz2CdErgKyTx5zcFT5331EsYHQROthljQMJ26ztNcynIrzZh3np m0Wr+BuwNWgf3eooEyvbuxOgUaTJGDime6PHOiLJsaZ5DTYPF5g3rb7964M7vNE= X-Google-Smtp-Source: AGHT+IEh9d/TIcGUMSlsJ3sIHqq7naGrzIK8Q/3NUyeOT627ZX75Eg0Fa3k4rVRatRXfjf7q0IiRow== X-Received: by 2002:a17:903:32c5:b0:1f2:f7c6:7554 with SMTP id d9443c01a7336-1f2f7c67a42mr107221565ad.9.1716261450817; Mon, 20 May 2024 20:17:30 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bf31a93sm214885415ad.134.2024.05.20.20.17.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 20:17:30 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 12/31] Staging: rtl8192e: Rename variable RxReorderIndicatePacket Date: Mon, 20 May 2024 20:16:59 -0700 Message-Id: <20240521031718.17852-13-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240521031718.17852-1-tdavies@darkphysics.net> References: <20240521031718.17852-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable RxReorderIndicatePacket to rx_reorder_indicate_packet to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No change. drivers/staging/rtl8192e/rtllib_rx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index 24136bba64b6..a30945f30e14 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -520,7 +520,7 @@ void rtllib_flush_rx_ts_pending_pkts(struct rtllib_devi= ce *ieee, ts->rx_indicate_seq =3D 0xffff; } =20 -static void RxReorderIndicatePacket(struct rtllib_device *ieee, +static void rx_reorder_indicate_packet(struct rtllib_device *ieee, struct rtllib_rxb *prxb, struct rx_ts_record *ts, u16 SeqNum) { @@ -1366,7 +1366,7 @@ static int rtllib_rx_infra_adhoc(struct rtllib_device= *ieee, struct sk_buff *skb if (!ieee->ht_info->cur_rx_reorder_enable || !ts) rtllib_rx_indicate_pkt_legacy(ieee, rx_stats, rxb, dst, src); else - RxReorderIndicatePacket(ieee, rxb, ts, SeqNum); + rx_reorder_indicate_packet(ieee, rxb, ts, SeqNum); =20 dev_kfree_skb(skb); =20 --=20 2.30.2 From nobody Tue Feb 10 23:53:31 2026 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C7AD5674E for ; Tue, 21 May 2024 03:17:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261454; cv=none; b=sgr+Id5pFR2l+itZglLhNvhxhlxi8B65vkW2Ign9qN41VQYt3e9FvPjtj41htitqxwktIvNgtCDUJjKOG+8oadcIuLbKu6Mjx2m0d4/6t//+DHi99kMl8bwTDsneyVVfGwijfatyNaXR/GuKdAhMKM7yRPh78oSTKHdm5HpnlLU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261454; c=relaxed/simple; bh=4zQZ/o4OTAP1Q63eyDdLz+A695cMhyvRSK0keQfQf1c=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=D9hLY3DXASqj5OGoS64EAqxoycysBgrjT0piQP34/0wotsYYeBW8PAaiS85FDrIo1IqctMlnwk541Seww5JPkFiyHVxosP4xTDWg2LinuJgFA3/YJiRHturYc8OML49qFIGS5hyb8taophwG/V6EcbOV1eY/SWjbzXQ+We+HXtA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=BnY0/bGq; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="BnY0/bGq" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1edfc57ac0cso96079365ad.3 for ; Mon, 20 May 2024 20:17:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1716261452; x=1716866252; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2NY82JNhe1Lcp3d6UGeyI0G7Bbb4dBlKnBMAKZ+t4Vw=; b=BnY0/bGqtrkci0HseOWontANHEq9XcJKJRfsGl7MGQIziyaFl8dnT2VDVyCvGKY9zl J3GW2QZ3QNzoY9hWag6itrvk2sM8vN0j8xRVxepWVZQrqerUiZNKQsLVeg8V4RvFZPS5 j9ZWVzKuf7nk5tV2jnqOQ4ggBzwR9yiXLka8xKnaXFVVHZZww/v1tK8JCZTvJl7yqzcq dCc5jtAu+BI9B5WxsyrxyFI6pApzFfsN9zLdDlw6V6Qx06vEx9qn8jW63m3Wr4neNndj 3R4NwwlFPan519vBqxdLaHm4Y0dirg5KeIr31MNYJinwdthbxmzzShSzss3JsCHeXNk9 XuRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716261452; x=1716866252; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2NY82JNhe1Lcp3d6UGeyI0G7Bbb4dBlKnBMAKZ+t4Vw=; b=dkDgqu4OuiaWVGkZBzEpx4a47653M+AIB/d9wNx/Ue9UKFWWKN4WvUofPSgzBZwz1e i3i6XmiIdxI/92rQ1Tn5xvab6yJcj1cKU5JuOx8FA5YWUkNqHmeqWLEvwNXvGLi09Js4 wkSUUqCiMCiTl6jA40B1qF8TGqbOnXaEDFgdNyP81tSJu6PVpAbW+Gym9xbqCUv+IdnE 4/Ww8YqFM8LPrtWzzo6/0rLvxZ5KfUpHkY9wXg0NHPjgB6bSdJTV/jw9Mkv9AGS5I0ol 6wGXlx8AzEg+DzzLEW9aY+RePbWK+lAHelRUHgi+TDy99h5rQxsLspsq9N94t454OSIc i1sg== X-Forwarded-Encrypted: i=1; AJvYcCWStqxQP1/+jA2tC6PIBAuxMbVgk3oKqmCWdUyUdvtyyktUC14zyA4I8WSodZabv4GUEne3UED4rDi9qAY6DwE5AV7w6+OvojazNWM2 X-Gm-Message-State: AOJu0YxRtj8PBoMLGwt89hM0hWqUTlmdILeveAp+7miWaOYLI05Plc1j EWFO6RUG5t+1Zb1jk7q+3EIQyf7q+C2maPRfjPdNQj9K6GEElgcdgwsGKNs+k7U= X-Google-Smtp-Source: AGHT+IF/KndwB5JM/Mysm9NlKwnpEQ4rYTS2YQtb2qNKae5M3qcQWbQEJeZj5ZqRLsVnNipPseSjzA== X-Received: by 2002:a17:902:e891:b0:1f2:fc8b:ebfe with SMTP id d9443c01a7336-1f2fc8bf12cmr60440765ad.48.1716261451785; Mon, 20 May 2024 20:17:31 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bf31a93sm214885415ad.134.2024.05.20.20.17.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 20:17:31 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 13/31] Staging: rtl8192e: Rename variable RfdArray Date: Mon, 20 May 2024 20:17:00 -0700 Message-Id: <20240521031718.17852-14-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240521031718.17852-1-tdavies@darkphysics.net> References: <20240521031718.17852-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable RfdArray to rfd_array to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No change. drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_rx.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index cdb3ebc77a53..996662a06e3f 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1407,7 +1407,7 @@ struct rtllib_device { struct work_struct wx_sync_scan_wq; =20 union { - struct rtllib_rxb *RfdArray[REORDER_WIN_SIZE]; + struct rtllib_rxb *rfd_array[REORDER_WIN_SIZE]; struct rtllib_rxb *stats_IndicateArray[REORDER_WIN_SIZE]; struct rtllib_rxb *prxbIndicateArray[REORDER_WIN_SIZE]; struct { diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index a30945f30e14..4c8cfa40927c 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -509,13 +509,13 @@ void rtllib_flush_rx_ts_pending_pkts(struct rtllib_de= vice *ieee, pRxReorderEntry->SeqNum); list_del_init(&pRxReorderEntry->list); =20 - ieee->RfdArray[RfdCnt] =3D pRxReorderEntry->prxb; + ieee->rfd_array[RfdCnt] =3D pRxReorderEntry->prxb; =20 RfdCnt =3D RfdCnt + 1; list_add_tail(&pRxReorderEntry->list, &ieee->RxReorder_Unused_List); } - rtllib_indicate_packets(ieee, ieee->RfdArray, RfdCnt); + rtllib_indicate_packets(ieee, ieee->rfd_array, RfdCnt); =20 ts->rx_indicate_seq =3D 0xffff; } --=20 2.30.2 From nobody Tue Feb 10 23:53:31 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F1145822A for ; Tue, 21 May 2024 03:17:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261454; cv=none; b=q3svhbwko8917jFBd483bivJTBQMMOvmyr2ovEO3EhMNGcpA3ae9sYuhXUvOL+2h6zBfMnEggbmbvgGOBYcZzCNAfWLpke57NW9+kTRPVIoCu/Xf0c8Ti5imcyR2RbhBlb0U8U4ToPftDPuwcf8dCrNppp9cdm3IXUv5JKXergg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261454; c=relaxed/simple; bh=0KJ6/0UmzK8lxJK25BNUy5fsFD+en8FEeDG8l85Cv5A=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=DBR2UBP6F6lMAiWmL8aFpzl48grJKz/0F2ga8PNvc7GxRNA8wvg5T1OFRXFjwxOib7NmuyvhanVF9pPQbxY3xJY0kaSiIdLt31Sk3QjHbTKuVB9ZAjQkHVMqcW+ziRH1MDchJP4sZgvCWI0gkSxcqTDBKXfKUeXwhqGnPgKFOS4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=MkcUX30b; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="MkcUX30b" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1f304533064so9681735ad.0 for ; Mon, 20 May 2024 20:17:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1716261452; x=1716866252; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZPE9OC+GQk0I6LRtpC2oK8ZC/gu1AchzTamw8jiTg6I=; b=MkcUX30bVP+aPyxhzPJbsoJ2EHmPCbt39ihHP2puoLWRS5NqCijHtyFCJc3KQslwVv p+a+RVlP/5G6zZQc3qQ8YX7O/vUyJFrv2FReax3UeBkKEPLQ5e00uiPueeDyLIHaZsb/ wJklQp+Ec5c6YbIRfa09/NWwC4LHyZpw6vItlJ6p2hia1WIaefFqW+rqKWnd44A+2duW 39tILb4eqnO32+GdXz/4LtnZuTsMbCO9/OkXHsw0RIImuPiERo7s5MU/9Z20/ePyQyi1 Dxp7UWLjWZmEloYxppsl9h0CI2QpzelkZW704GA9sKCt/m/0BoqeD1uqEz3HDKw4+yZM AUpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716261452; x=1716866252; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZPE9OC+GQk0I6LRtpC2oK8ZC/gu1AchzTamw8jiTg6I=; b=c5FsqqtCjsJ/pHUNQF9gLnlGjWbRG8N1I0BNZcPMkWKY1KhoYGs/ZE+GJ8fFltAWoF vjnkHLwnQnGY3/zFOjJo8fPAhooqm1Ad8Nk/Y6jbZAJUb9fJmSugeoEfVGcHWgmMDI52 igGD13a80tRy8rlbvlDlUy3YzN2R3UVUsap62i3J+n4M80VRBYCYociG0ToQ2CUk9jae 4aRbw8RfwPQtQm3JViigk6jaz2mwyGsOgIrHO+oTEpTJDftkGZFAkYLIKbu8tOfAUJWQ h6eanmWVDsrHyx0N326+tPo+FzEgewGOIpdCAUHDJx2vK+zsB6h+XWMdLkwTSbKg3YYY oErg== X-Forwarded-Encrypted: i=1; AJvYcCXiOgGYFRBbc5NiqlGxlrQSv7A1j7cT0jV4SaZ2HHyvbje1x6ZeMCEVsz8hhYvKuO4BO8KNGX4F/IWkLNHynah8ZEOP4pL2VU0fvBtN X-Gm-Message-State: AOJu0Yy1cYe9kdMh9N6RPIkFMxwBBwXwtTQGNpVCZLhbY7PR8dNW7gA5 8PyqE6XRyZRpi+gptDPLO4zdfVFcy1xhXfwOZYveNbeegNZSfhYBp6l2TaaECwJ5eG9+2wnudW8 D X-Google-Smtp-Source: AGHT+IGhvkZi6H3ProckbnUiRXtNCDkSP46gIyKASbmiGcRGeltnEGsRQDKagpTmcKzBrSYzXsvV6w== X-Received: by 2002:a17:902:e741:b0:1f2:f954:d69f with SMTP id d9443c01a7336-1f2f954db9amr76401125ad.18.1716261452501; Mon, 20 May 2024 20:17:32 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bf31a93sm214885415ad.134.2024.05.20.20.17.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 20:17:32 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 14/31] Staging: rtl8192e: Rename variable Decrypted Date: Mon, 20 May 2024 20:17:01 -0700 Message-Id: <20240521031718.17852-15-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240521031718.17852-1-tdavies@darkphysics.net> References: <20240521031718.17852-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable Decrypted to decrypted to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No change. drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_rx.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index fdf8fc66939d..1901a319316b 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -1646,7 +1646,7 @@ bool rtl92e_get_rx_stats(struct net_device *dev, stru= ct rtllib_rx_stats *stats, =20 stats->RxDrvInfoSize =3D pdesc->RxDrvInfoSize; stats->RxBufShift =3D (pdesc->Shift) & 0x03; - stats->Decrypted =3D !pdesc->SWDec; + stats->decrypted =3D !pdesc->SWDec; =20 pDrvInfo =3D (struct rx_fwinfo *)(skb->data + stats->RxBufShift); =20 diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 996662a06e3f..f69f4ca39fd5 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -481,7 +481,7 @@ struct rtllib_rx_stats { u16 bHwError:1; u16 bCRC:1; u16 bICV:1; - u16 Decrypted:1; + u16 decrypted:1; u32 time_stamp_low; u32 time_stamp_high; =20 diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index 4c8cfa40927c..3afce436a5d8 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -1025,7 +1025,7 @@ static int rtllib_rx_decrypt(struct rtllib_device *ie= ee, struct sk_buff *skb, sc =3D le16_to_cpu(hdr->seq_ctrl); frag =3D WLAN_GET_SEQ_FRAG(sc); =20 - if ((!rx_stats->Decrypted)) + if ((!rx_stats->decrypted)) ieee->need_sw_enc =3D 1; else ieee->need_sw_enc =3D 0; --=20 2.30.2 From nobody Tue Feb 10 23:53:31 2026 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6A665FBB3 for ; Tue, 21 May 2024 03:17:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261455; cv=none; b=iV/r0NoETuWTp2ZkteblagTAF4AIy1tpwBTmbScI8/slZp+vVKqOeQBONRrt+ze5VH2RNQ9TjcWKADjfJVomIjV+GooHUjRbSF8awoh09TCLah5GSIpRKHcmBl/Z/0CopqqIXwAlYuUYVmnU25E911lND31ciacGlluEXzlbol4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261455; c=relaxed/simple; bh=Wr81TQ45G30xNhmOkpy6VqywIleSpREFvah2+9mPb8E=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=By0DD9b0MO9+4zD6PTnQCnqS+m/TpG9J1FIax1B2bOHywhEJoMjYzp3uRGlEChDIdIsA65EBhntz4N1iwaskX8v+jhUoasrLXVyFUO4mRR0s04LUN3qSp1WhiYybfmks7COwRKeZxUoNBg/cLPjv7OyHvRR6edRBrVAkf5dqe5E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=Y6th062R; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="Y6th062R" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1f2f566a7c7so64564565ad.1 for ; Mon, 20 May 2024 20:17:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1716261453; x=1716866253; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/beP8h/MyXUke5aaej1RngCGo0SmcFT4Mq28a4Aie08=; b=Y6th062RzraJvSW00tXjf8temGuSOhPsWj7XPlg2+KOirfRs0yC+m6K+zydEAlU5zV phfbj4DjRtEzBF8EaSxj9RAdJtU1IPpm2yWoaEAHVE2RJCmf4CSlphDrCU09ODM3MXqE 09cb52NC2/KKIsz5uIU3Yzn4hHR7c0kmILNFtJKB3EOxpVvvBGsO+1UhO7WuoTl/vC8e 0NqyEG21W7Wk0piXQop7IG/u3KNnBDei6YddnM7NoWEgZ+3d68Bn0S8q6WubrYnVD8TP 8pZ7ujyv+t0n8au/FvbQ8hAPNmYKK0BgyNUQ6CaxaUghMgQeE0Z5MTGkxwbJ8uGNe68t v+Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716261453; x=1716866253; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/beP8h/MyXUke5aaej1RngCGo0SmcFT4Mq28a4Aie08=; b=VmnfBYLUjV1vEzvf1p0TzzwRM8JJvIqFgQZDgVtG43TGhrS8LReIekAfH+yb7vVcPB fgg1c/k+RF95ZtHhvOZphsQawehxX8Mg/bgWcCs2J0DWVxoSusZdFxWFRqoBUQPAP9PX syjzDKB3nlZvK7y+Bf3XhbErbVvtRVQ/nvxQVcKo8Tp4buHmt6vld/0DG2ADo1wE0IGF hR/Wyqe8v/gSfDEJPmgwnirQLZl2cR/TiDbgQcWn1cCLlp9HMrjSIxb7suUfzpH2HNSQ Jow6/ulLdK5jfetk6LEeDHMyOaCMbBlP9DsIPNRKGk3XqQ1fwzjAcXjSwU+J3d+dwxXg LtQw== X-Forwarded-Encrypted: i=1; AJvYcCWcRIK2eumv4GxqHbs07Lp71lmcekCL6Li3xRFYOik/lQIHRfk7qfIVysiMYspXI+D3488LBaSJ1X9o+vsGCX0b/Kp7kvO8m3F/aJZp X-Gm-Message-State: AOJu0YwScBbmO9qJ3ezQv+8jJspjdOVBskJQQIYvL0Ket1wilvE5ZStN naqR35Eru3gCcHRk0Frn9Xt/AByU+W68JwYFNIR8j85fcN0/JcsiiJ8BeMJ5xnubHLozBVtKwWW z X-Google-Smtp-Source: AGHT+IFwsw9QskOPJMvjYDG8sYTnJv2LmRuTuJ7Nq9SpLDSqhIpvhdsb74byEyxWd/ZN+JYE69wbyA== X-Received: by 2002:a17:902:7618:b0:1e3:e0a2:4fb8 with SMTP id d9443c01a7336-1ef43d2e1dbmr289158535ad.30.1716261453300; Mon, 20 May 2024 20:17:33 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bf31a93sm214885415ad.134.2024.05.20.20.17.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 20:17:32 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 15/31] Staging: rtl8192e: Rename variable AddReorderEntry Date: Mon, 20 May 2024 20:17:02 -0700 Message-Id: <20240521031718.17852-16-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240521031718.17852-1-tdavies@darkphysics.net> References: <20240521031718.17852-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable AddReorderEntry to add_reorder_entry to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No change. drivers/staging/rtl8192e/rtllib_rx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index 3afce436a5d8..30bd6f49e915 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -403,7 +403,7 @@ static int is_duplicate_packet(struct rtllib_device *ie= ee, return 1; } =20 -static bool AddReorderEntry(struct rx_ts_record *ts, +static bool add_reorder_entry(struct rx_ts_record *ts, struct rx_reorder_entry *pReorderEntry) { struct list_head *pList =3D &ts->rx_pending_pkt_list; @@ -610,7 +610,7 @@ static void rx_reorder_indicate_packet(struct rtllib_de= vice *ieee, pReorderEntry->SeqNum =3D SeqNum; pReorderEntry->prxb =3D prxb; =20 - if (!AddReorderEntry(ts, pReorderEntry)) { + if (!add_reorder_entry(ts, pReorderEntry)) { int i; =20 netdev_dbg(ieee->dev, --=20 2.30.2 From nobody Tue Feb 10 23:53:31 2026 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9407C65E20 for ; Tue, 21 May 2024 03:17:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261457; cv=none; b=Adc7bXi2sgsY9pJ9oPcb6QIJ781VKcJaE/OXRuq+Ugk4lBAcPfRTSU8BLNHNvUVfkP6a2Czx8OFsBE188tfBDLlroCyV0iIc6hcDmBhyKPOWHMO3hQXw/L4L4SCme8n9Lsewfs2qamDvQLy/6qWzXOwG6cFlwczi2M2nSILX55Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261457; c=relaxed/simple; bh=iv5vtIT0B8sEKOqWsGuNVC0aO5c9WspHnf3XLIvStwg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ASsxVx/fo4aN9KuRggmcr31SkZwe75yC/7cak1ZZb55aRqX0KCCsMpWBNC5cPvflzwBTmrLytPxAzELR85CDTvvv6QaPouQNjK1tnTqv705raHtyYB/Jds0H/9cqRYEt2+zACamFDwezvzLxr+8Euopn2AGcfIQ0jti6/TewDvs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=g4nHzN4+; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="g4nHzN4+" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1f3105f3597so1965305ad.2 for ; Mon, 20 May 2024 20:17:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1716261454; x=1716866254; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EnnNiGWOZDyrhURhTHUizVWuJYzYU9zmKFPIjPvFtcQ=; b=g4nHzN4+uKrN7HWhwpAI7oVY4iOzkgPcpReuK1rMgWc66FbJXCb/5p4d2d4hyCdyBB 5+XCsuI1DbS6wHcoRzooKFw1/5cu8oChoxtUQVkfls02WG5Pz1kH5hl46w0KYanvgFSP Q5t/qfW5CzhyFJDEMYXXAh42dEACLtR2p+mg8AV3TOssyzc/L67uoXMj+rDkW779CaF0 olfHexEAksgux1SrqsUl4AsoG3vLg3Ip1G2GlTJo5a57+srRrzZkYZpyA+qtLB99RODV nBTPQti4IiWR2TDr7owLOLgmYPafp9V9b7HhKw+j+O+qVmVxHSs5mR8SYO3NthKr0pvq OomQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716261454; x=1716866254; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EnnNiGWOZDyrhURhTHUizVWuJYzYU9zmKFPIjPvFtcQ=; b=NQgBtVXz3z+Qm/RH6aDim/7MDHQl9DYfYi4SO76lg7ngj2lZwTNYGKZJCKDuftpV+6 LY4wBrEoWTCDoG3PUQ7ZT6/eIgOTzfQILzxIzYNTS0i0qPWTmVX2krp/PkcDPEOPpb/v shZZjo1E+tSLZqBst688DCtwB5jyMhdk8MtlKCDUyCRFjpyMCK7g3QLkDaMYMj2kU222 dKncQ2+rSZRMaGfHDCptBvRhCz0RdpreegspGub4iJPK4/XuHUczq8eDKI6+c6MxvVn8 wa1gC7gMjgwD4aDiuCLEHYq/5cj3pXNsJSff6+/qidrTb221gt80LZJSgwTba2h/eCAA IIZA== X-Forwarded-Encrypted: i=1; AJvYcCVeGqOM/38cWOXvcXPzeTfXnFDprpFwyyyD6YVZPm9WWCKBObsZMUT9xKb7Vkcwd+I/enPfgZSgr6uvMtYZjI4gai9NzQNKT7lfeVVK X-Gm-Message-State: AOJu0YwAmv2DqgPQk8oJdygBpya+V9IdPuJ1lpaDogNeyK8gYm4DW2VZ 4Q6POFw0RvUeJ5uPfqxKJcgmBAwEc62/QcwLiUQyyXPqU9uFTmeW5I26KWtN0fo= X-Google-Smtp-Source: AGHT+IFNOmj7w6LmZdeRnpTuqNZeDgFn5eoz7xWciHwLByvAWVY21M/4Ib9p5iHD9xbeAMtT/1Mk+w== X-Received: by 2002:a17:902:8308:b0:1eb:3d68:fc2d with SMTP id d9443c01a7336-1ef43e25fabmr305373295ad.34.1716261454070; Mon, 20 May 2024 20:17:34 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bf31a93sm214885415ad.134.2024.05.20.20.17.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 20:17:33 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 16/31] Staging: rtl8192e: Rename variable pList Date: Mon, 20 May 2024 20:17:03 -0700 Message-Id: <20240521031718.17852-17-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240521031718.17852-1-tdavies@darkphysics.net> References: <20240521031718.17852-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable pList to list to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: Rename plist to list drivers/staging/rtl8192e/rtllib_rx.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index 30bd6f49e915..b1cb73c2177d 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -406,24 +406,24 @@ static int is_duplicate_packet(struct rtllib_device *= ieee, static bool add_reorder_entry(struct rx_ts_record *ts, struct rx_reorder_entry *pReorderEntry) { - struct list_head *pList =3D &ts->rx_pending_pkt_list; + struct list_head *list =3D &ts->rx_pending_pkt_list; =20 - while (pList->next !=3D &ts->rx_pending_pkt_list) { + while (list->next !=3D &ts->rx_pending_pkt_list) { if (SN_LESS(pReorderEntry->SeqNum, ((struct rx_reorder_entry *) - list_entry(pList->next, struct rx_reorder_entry, + list_entry(list->next, struct rx_reorder_entry, list))->SeqNum)) - pList =3D pList->next; + list =3D list->next; else if (SN_EQUAL(pReorderEntry->SeqNum, - ((struct rx_reorder_entry *)list_entry(pList->next, + ((struct rx_reorder_entry *)list_entry(list->next, struct rx_reorder_entry, list))->SeqNum)) return false; else break; } - pReorderEntry->list.next =3D pList->next; + pReorderEntry->list.next =3D list->next; pReorderEntry->list.next->prev =3D &pReorderEntry->list; - pReorderEntry->list.prev =3D pList; - pList->next =3D &pReorderEntry->list; + pReorderEntry->list.prev =3D list; + list->next =3D &pReorderEntry->list; =20 return true; } --=20 2.30.2 From nobody Tue Feb 10 23:53:31 2026 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EA326BB58 for ; Tue, 21 May 2024 03:17:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261456; cv=none; b=CBMfMXF8PTSr2OeeGfr+yTG2Z+wNXKEFhJVL6NXCgnKoxi+9hm2I6N3HUUftPLjciHGxGk4GwO2fgR6w4ZGJhHeQLugtQjJbdANxDEhRs1BZwp3PupDJtRli80XaGllDjEqFRjzLaNMM6FQwop2i0QZZ9+bJ+d51lgWvx2rrRuc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261456; c=relaxed/simple; bh=Qp9Q2ISvQlMozzVKsSzgcrAnhyylfHKJ2ip+J3JJmPk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=bVvPzagC9+CdTeB6wYgkQVGn7Z96qsGWPa0RhqGOHJFMT8CV+F/KMYvQPKP/hK1FTAata0r3xqvu5KdCrN4ZycCMHADW7mJLBuTF4pAC3yKe6kEo2iVdcrAdexR3Hr8o8JJbyXgY3Kn15vyfDNdVee4ANUejWwY1Hl1oytOvIPM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=QJTX4JQ9; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="QJTX4JQ9" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1ec92e355bfso107912835ad.3 for ; Mon, 20 May 2024 20:17:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1716261455; x=1716866255; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=htW5kSCHk6pUg/aASaEh06kykYiS1exLSGkKV91xbbE=; b=QJTX4JQ9wnMLybWkvptQ730U8pYnApfPnyyz12lQ9uQ7Hp1avjGO9gejUSBjOz3GJI rg+DLSeMclBoTcMZq4KEXe7iiGs4hZBmFbiTcsfZWW7UpyBqMAlOxUpM1oy1h11afJtr cO7wz1RYzFgaT/tAiy32LFc3hfkZENObAW9Lgfk+Fxpk2AK4We5xbh2N1WcJgu0y0vXN STgV0Yqx0XTpPXX9F4i0rlL1MC9I1MFTTa7rfN/ez3oOrLxTvppxrHDa48ukzPVvaQ/i RtFpcyXJia0TDZjkfgt87/eVsfTcrlAC9+1w+hPVXk2hkC3hkDxQsO5152FOABDl1D7m +byw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716261455; x=1716866255; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=htW5kSCHk6pUg/aASaEh06kykYiS1exLSGkKV91xbbE=; b=spoNVGHXFaaYBApSt8Yo6U4E6G9VkUHAzllopx6ZWZyUtFmLEV8XoRyoD5YWcLViqR LeMSuefoR3iKfrG+PSNGMrhfuaWCR18MTWqjmAznvg6Bl1MQb4G+HU7OT9UG8DY0D916 4iwXxpK80vZv0oHsC5Vk4Y4F2bcvFI5zPdXEhsQPG8j698iM6JGfSG+88sI0zRt6xdTS CPhgqHfkqC9t1NWUYrfrYV4DM6lfTMFZnDw2EWOZsA17P/WMZtiJjWp/pg5wa9A2Cb6S vEc07K2ZZYrDfN32mWsC2OzqJ5Hvkp0B/9kc/AtvO7XuUlpF3RDrmKRCVU2R7u/zMa7/ tusg== X-Forwarded-Encrypted: i=1; AJvYcCXj6OAzQQpX3qlYrt4aNid2lVxfoLm8NdSLSEW8H4rmw0VomyJ2XvHPyw3835vlFwNpOlmv1VWFLpVGjBPOFBWW1jcxmFhP0LW4Cfp5 X-Gm-Message-State: AOJu0YxLgrM01uC0+XNADn/zGVzxal7AWtNfR0voS9y4iV7drBtYB7ck fAy3XZm7y02/PM+WxlA03JeWB58s4GKM0q08v/LO63WI0G9pXYTey4YlklkkeGw= X-Google-Smtp-Source: AGHT+IGDe74xf+ez6yX8mWjW+mXFftRFrHLChSip7NgL/qCcpWcipNqs9VMkv2lF5lXZTBDSviVZ5A== X-Received: by 2002:a17:902:ec83:b0:1f2:f0d3:db30 with SMTP id d9443c01a7336-1f2f0d3e367mr91334535ad.64.1716261454829; Mon, 20 May 2024 20:17:34 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bf31a93sm214885415ad.134.2024.05.20.20.17.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 20:17:34 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 17/31] Staging: rtl8192e: Rename variable nPadding_Length Date: Mon, 20 May 2024 20:17:04 -0700 Message-Id: <20240521031718.17852-18-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240521031718.17852-1-tdavies@darkphysics.net> References: <20240521031718.17852-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable nPadding_Length to pad_len to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: Rename npadding_length to pad_len drivers/staging/rtl8192e/rtllib_rx.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index b1cb73c2177d..c32eec733373 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -732,7 +732,7 @@ static u8 parse_subframe(struct rtllib_device *ieee, st= ruct sk_buff *skb, u16 ChkLength; bool is_aggregate_frame =3D false; u16 nSubframe_Length; - u8 nPadding_Length =3D 0; + u8 pad_len =3D 0; u16 SeqNum =3D 0; struct sk_buff *sub_skb; /* just for debug purpose */ @@ -833,15 +833,15 @@ static u8 parse_subframe(struct rtllib_device *ieee, = struct sk_buff *skb, skb_pull(skb, nSubframe_Length); =20 if (skb->len !=3D 0) { - nPadding_Length =3D 4 - ((nSubframe_Length + + pad_len =3D 4 - ((nSubframe_Length + ETHERNET_HEADER_SIZE) % 4); - if (nPadding_Length =3D=3D 4) - nPadding_Length =3D 0; + if (pad_len =3D=3D 4) + pad_len =3D 0; =20 - if (skb->len < nPadding_Length) + if (skb->len < pad_len) return 0; =20 - skb_pull(skb, nPadding_Length); + skb_pull(skb, pad_len); } } =20 --=20 2.30.2 From nobody Tue Feb 10 23:53:31 2026 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13D832135B for ; Tue, 21 May 2024 03:17:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261457; cv=none; b=GIp787iJ24QvrJ0VKXO8Qo6MBlts+y1YWrgLl6uytavshvjvGsTL1P2QSe6HZ/APB6mH37Yo7L9t+o7grmjWod0W3S+UIKuYVD58BrWWpR0HgNX5XCuwX2d914u9+v9UGdKmROmgh7Z3shxTrY4+TOL1DLP5U7Mcy2RB6qPWzKc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261457; c=relaxed/simple; bh=IB7CNwmjlf8uC05nV8aD8Ur48AzeMJj/pCJgovi46II=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=gSzKY/BXVknIp0SLEysdXqfgCXaIZqJe78owXuXqwiThlBfahy39O1hiRrI8h9OOsKyjBfqgzUo64b1lveCjipkMWYRgZKHTchkpMgCgNYNm1oWS9GyTtD9z/DHg6uCnCSFUWeLAb87gBByjddJz4yegfTIViGc3wiwHOKJfVhY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=BeN3rQzU; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="BeN3rQzU" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1ee38966529so24149195ad.1 for ; Mon, 20 May 2024 20:17:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1716261455; x=1716866255; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=L3Pa7O0YRALgZWigoHd2+NZIFF5xk9ptOqEgWjtZxvY=; b=BeN3rQzUDLiQfb+MyaqOJAdnz5N0V2//V6EbojMfU7o6YJDz2twQwwOyff89tmQ4b1 FkZWOhlQBGdFlccpJOju+OfX5JT9c2+5OIZOtHHo1UlrnHqFZ+wyeEb4Q0NzN3eFfBQk AMkAo2BNHeC4gEXx74cTr8b5ORnqRilp4Org4zzinB5Vg5PV6A6SX7pd/FQWjknFcW22 zoOGWcKYqPKFC9bhwSBWpudKpe0Fbn6SqEkcYodVrF6pRpK3b/qXFFIIuUyR1RpdAu9s w4gDg8IPBBxbIQLvqa7JQ2YyiD/Jl8KYdGYXDvfcRyLYg9shT/MsqOTImpwAt16etN6N d/SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716261455; x=1716866255; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=L3Pa7O0YRALgZWigoHd2+NZIFF5xk9ptOqEgWjtZxvY=; b=ngQCG6H+iT+7bI/efIPdysSg+4pr53WygbRi3/Wd2IvZYGjmLLcncye0MlBjcg78kc iJgIzMnIW5dQUAczvwLFG6uQAQ4WF3Mg7W1PYetIkW5LQTqomhNCrp47GDadjKrn05jd /vfG7uqgSLjAX88Rzh9qAJ+10MEzvuGLzuatfNmiXQ6yVF+QDvfuZseznvKarAI2vRuF c9WhFxYkTn/qxWdHYTs+UZ9HTRyyeJe0x0m3Jxhv8aTyqPMKOnB1MNVxwNRYYQPpOQXx 9DcVI8Fh2sbFlddehXUtd1rFXQlu57kkZSkUc55HH+Qp6Ub9sRpK9KdwrkSKBgVsIFeq 89dA== X-Forwarded-Encrypted: i=1; AJvYcCUYdHwkpyeUh0VtI74QlRq5qxFJnZuAymk5C5Yw433i6npQo+FFacvUOl5JbRpfl7wxsYo0i5LSRNXtKW00AjKiuSDIKRvH8kF5d6gs X-Gm-Message-State: AOJu0YyupM5vVYzhGJ0DhgZp2+/FYaPhEAPu1nVCKW5UXU80XvIhPhYL sl6HMq9bgFqnGbP3YSAXESvDAnlwuUX3Ryl2xFiNnG/mOcEPUW0mJAtjVVCEKEE= X-Google-Smtp-Source: AGHT+IH9SJOgsXhyxaZR2SprumkcnN3Ec5Me2r3sN0mzjmJEBaExV2E/4vuApVw9qjYvznRUmtZ/rw== X-Received: by 2002:a17:902:c946:b0:1f3:900:e7ed with SMTP id d9443c01a7336-1f30900eff2mr38837155ad.20.1716261455483; Mon, 20 May 2024 20:17:35 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bf31a93sm214885415ad.134.2024.05.20.20.17.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 20:17:35 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 18/31] Staging: rtl8192e: Rename variable LLCOffset Date: Mon, 20 May 2024 20:17:05 -0700 Message-Id: <20240521031718.17852-19-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240521031718.17852-1-tdavies@darkphysics.net> References: <20240521031718.17852-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable LLCOffset to llc_offset to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No change. drivers/staging/rtl8192e/rtllib_rx.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index c32eec733373..52fbbbaf30b0 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -728,7 +728,7 @@ static u8 parse_subframe(struct rtllib_device *ieee, st= ruct sk_buff *skb, struct ieee80211_hdr_3addr *hdr =3D (struct ieee80211_hdr_3addr *)skb->d= ata; u16 fc =3D le16_to_cpu(hdr->frame_control); =20 - u16 LLCOffset =3D sizeof(struct ieee80211_hdr_3addr); + u16 llc_offset =3D sizeof(struct ieee80211_hdr_3addr); u16 ChkLength; bool is_aggregate_frame =3D false; u16 nSubframe_Length; @@ -742,16 +742,16 @@ static u8 parse_subframe(struct rtllib_device *ieee, = struct sk_buff *skb, is_aggregate_frame =3D true; =20 if (RTLLIB_QOS_HAS_SEQ(fc)) - LLCOffset +=3D 2; + llc_offset +=3D 2; if (rx_stats->contain_htc) - LLCOffset +=3D sHTCLng; + llc_offset +=3D sHTCLng; =20 - ChkLength =3D LLCOffset; + ChkLength =3D llc_offset; =20 if (skb->len <=3D ChkLength) return 0; =20 - skb_pull(skb, LLCOffset); + skb_pull(skb, llc_offset); ieee->is_aggregate_frame =3D is_aggregate_frame; if (!is_aggregate_frame) { rxb->nr_subframes =3D 1; --=20 2.30.2 From nobody Tue Feb 10 23:53:31 2026 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF2146D1B0 for ; Tue, 21 May 2024 03:17:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261458; cv=none; b=S8SBRPIxRiB887cse14gQRK3OXTzHOn7TyM28MVwlsOtFC2p1cF7ATeCF1TnTImP8/AXLDoWf04j56U3NmnRxr54mhg9nsGOmWqXWUDX4zjiQ8RAhdBrXf7hXqHCJvwKLmbYUpODcjqj9A3LSAB1uVnBrHWn65Hl72jDLzE9/zw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261458; c=relaxed/simple; bh=vOlhyRJiwMlcqMkjgh8ZqeWXUxY6D61pDutdGqwl5CY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=t6wo2FzmGAexU3ITN9h1vzomREA5Ofjcx2iH/c97AIBwD/p74ZF3lbwlMuyrLnP8QN5CjhpMAgGk4FHo61VO7ej7lcztOVojgSEX4MKYR+r0Sk0q9l+hJ7P5cCM9/0YuqoDwshjERZaM/6tE6Wy4lh1K84LsJkBcoZs25e8rMz8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=JM+FM1Hu; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="JM+FM1Hu" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1edc696df2bso30589315ad.0 for ; Mon, 20 May 2024 20:17:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1716261456; x=1716866256; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vIGSQ3C/BdvZT98agea7mQnapaDbDhw1o6G8ocniTTE=; b=JM+FM1HukvOhiVVfpaBzpqrpMhTCy2bh0Monq8xoWuWFx4DKq63gr9YXu3yGvYvMLU 3T228LHr/qwuHJdfYP3LPd9RpUyaht/PPXDwDRKPoXKE1gE8q/Fh5SWkGXqan7gf352F KSdYIINB5MAqiotW1VDrmmyGyNYZ568/NsnNF8ubFV1SAW72fkBWvtJowp3XQ7Iq6hYL dEasRh2wl+SPNc/mkYnmJdn8b5EaDFu5sUu7vZaq7fP9cSpRbiOJAh/LwPHTHfXF9uAE Ym321F2b0mmNVlhfUbwZlEyjDhqpuAskfxUqpZrKp2Gs34n5WpkMXi+4yltMR9YpxV1O aWFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716261456; x=1716866256; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vIGSQ3C/BdvZT98agea7mQnapaDbDhw1o6G8ocniTTE=; b=Xj072Ch0W3+sEdG2J+lu0f/nUdl3Xwp9fn7YzRFU10ykOsy5y+9BoMq183YnbgRL4b ZnnJRbNsFcDCUOuYGN2AjP4M8YeXTJdEMToRcKotoYKom5sqVNzXkAGmCiaK+uNtWpx0 VECDg9ehA0lOy3EoN4vHzIdrt6MleayOtg/vuBklXLo9UM/MXjulmqjjlU9xqkTFkCcE CfuqKacX3iTAXBO1yWe1AtzXQWuxmMiYjyh7JWkBljYBam24d1qaeeWM1x0EzBlqs/SC cShs5BdmBX/n5sht/3tsxh6kfkFJyBfBmNP0nsLONB3roCAQDIHoDI9KqdAfmVTU0u+c nCAQ== X-Forwarded-Encrypted: i=1; AJvYcCVw1Jc3TufMdI6LdI6He8KJoRKy/7+uVyBLxMfuwpGVibIEDQGekpJN2IjmLbQhpJBQJUdgaJV6VK/odTEI6z84tse20oxHENJu7XHa X-Gm-Message-State: AOJu0YyJ5AQT6g68dVB1Axvqveh8HliCOJY8/zja5OA7xTEENQScXF7A t9HIqIXGRIV5vn0bjuIRu3zMzodgwoVoMlHLBbHHdfv24vagr4bCfOwc+BtqBfletoCPZq4yPOb 5 X-Google-Smtp-Source: AGHT+IHCEk90C+Vq4CiPohjEvBRo0vWIF3yzHeFHSZPkzH/iMjxz0YZfmHGO49DF9SNeggUgvFn79A== X-Received: by 2002:a17:902:6b82:b0:1e3:dfdc:6972 with SMTP id d9443c01a7336-1ef43d15755mr316580525ad.9.1716261456179; Mon, 20 May 2024 20:17:36 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bf31a93sm214885415ad.134.2024.05.20.20.17.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 20:17:35 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 19/31] Staging: rtl8192e: Remove variable ChkLength Date: Mon, 20 May 2024 20:17:06 -0700 Message-Id: <20240521031718.17852-20-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240521031718.17852-1-tdavies@darkphysics.net> References: <20240521031718.17852-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove variable ChkLength which fixes warning Avoid CamelCase, and use llc_offset in its place. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: Delete ChkLength, and use llc_offset instead. drivers/staging/rtl8192e/rtllib_rx.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index 52fbbbaf30b0..3a637731506c 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -729,7 +729,6 @@ static u8 parse_subframe(struct rtllib_device *ieee, st= ruct sk_buff *skb, u16 fc =3D le16_to_cpu(hdr->frame_control); =20 u16 llc_offset =3D sizeof(struct ieee80211_hdr_3addr); - u16 ChkLength; bool is_aggregate_frame =3D false; u16 nSubframe_Length; u8 pad_len =3D 0; @@ -746,9 +745,7 @@ static u8 parse_subframe(struct rtllib_device *ieee, st= ruct sk_buff *skb, if (rx_stats->contain_htc) llc_offset +=3D sHTCLng; =20 - ChkLength =3D llc_offset; - - if (skb->len <=3D ChkLength) + if (skb->len <=3D llc_offset) return 0; =20 skb_pull(skb, llc_offset); --=20 2.30.2 From nobody Tue Feb 10 23:53:31 2026 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A41F273171 for ; Tue, 21 May 2024 03:17:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261460; cv=none; b=Qt1zAtPNcfXvebdw35ig+x9JRI8RVzRiTKGX41ogJKzZm52F0NDDzze8kOSbLHhnfhCUUFhuJAzH6WM2jw8bFVs9XqJXlZf2YiaK/FEcUWtfxu3Mam4SY77g6fEozWld1oIzCcc0Q/MGg1r4UAIwC9F/YJQz+z0ttqr5a2aO5jE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261460; c=relaxed/simple; bh=hPJRM/f0cWl7W+m4SCd0UK0MHAt/7KX6y+yPnva3ddY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=CiG+P9RlZM0V8zr0ZXwcXjEFeFcYfc6pt8qtdvykTjMv7tDhlQd3P/zeWSxAUYvTI4I/YqVlZMvtmAKkhdJWNQGctGdU9AqUN6AG9ezEilntGN0HWbswEBZ1gpSnJhUMKeUEAcb6vr59G7wjWnVCUpsxKPgNiziDsXqztnKZm/s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=mGjjDAX2; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="mGjjDAX2" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1ecddf96313so81731035ad.2 for ; Mon, 20 May 2024 20:17:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1716261457; x=1716866257; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tzmRGVhra0vqV7ClBDZ8LpQ88upOg0kiLsBQjRBVvpA=; b=mGjjDAX2i8YCuT2+fbLDgOFjO2hMKh/5ocvjmHCvweRusZ/qmDUIw5wGByYY5AJzNv HWBy50GtWVj4JuUskB3vVfFEx/nAHQBbhn8TThIvuyEpjjwaF/Mlq6+NFpiqF7fqJivT Zv2GrthjZzWc/jrs3RtfapuY3X8auKHbkexiINbQ2SGa7yGZosKSsuuyAvaz0ekyUDlt 6u70CaohVk87W/LoGMQwK78UKi2sO26cm6EDhGA0rej767ufo/cS1qKWSDAlALIo42S3 rzdV/LjjpffFe5HpSagsPoLUfy8aZtEmCKNoQ58Z7OI6g/bK07qg76rcPw3SZ9EIiWKu SWxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716261457; x=1716866257; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tzmRGVhra0vqV7ClBDZ8LpQ88upOg0kiLsBQjRBVvpA=; b=PaXyBxqYQGC1vXVAvIuMkE9btWgrJuRoYf2qupM4BHmoqneilriuU1LyDWZUii/URo CWk+bLiM3A9FPw03C76zMc7i1wjk2mejx89oowoBUmTmb9730YN/qzy1PojtYC1G9xg+ 6+fbopZPXWl9Jf8+GfnITyKoSVDQLvIJi/ru/9LlDO0w6ouZZAroSEweeUhSj5j/WynK HES1vksHj9Nadssbe+whlF+vWINR1RyheONIVi6K3wWKFscfbGB64Oz0yzATGrtucAd0 epvFV9sq3OeNv44u7XD0NcXJEK/0DBZ4EpttOg317fTCl2bWe70eL7Ea8ETq+jWFplUr ZkKw== X-Forwarded-Encrypted: i=1; AJvYcCXUvnoNHlq9o3YQKBZqGoa4dVuiP61QFy668dXKUTkZVQyrufHlbynB1pQOaUgdkMDGsy6u1D3lz+VQLV1zt5qL5rJ+nFJZUQtEFg5r X-Gm-Message-State: AOJu0Yxg3oXyUgflKxT6dpRu6Da0mK0aJ3UbG9loenySCk0JnYdf+z77 RB78uDJau4/IcajK1yfYmH+dD2GCXggNOXNA26LIl3lMnf29ul/TuD24+ceWWAo= X-Google-Smtp-Source: AGHT+IG3xZPcwhNaTmcektbIQRrzEBZS1fMMUdZ5TEtlnDulIxt5qmDUML9L7SII1MpSR5noRKJh/Q== X-Received: by 2002:a17:902:6b44:b0:1e2:81c1:b35e with SMTP id d9443c01a7336-1ef43f4e417mr364559355ad.54.1716261456986; Mon, 20 May 2024 20:17:36 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bf31a93sm214885415ad.134.2024.05.20.20.17.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 20:17:36 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 20/31] Staging: rtl8192e: Rename variable WinEnd Date: Mon, 20 May 2024 20:17:07 -0700 Message-Id: <20240521031718.17852-21-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240521031718.17852-1-tdavies@darkphysics.net> References: <20240521031718.17852-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable WinEnd to win_end to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No change. drivers/staging/rtl8192e/rtllib_rx.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index 3a637731506c..ab2aa1a86c51 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -527,7 +527,7 @@ static void rx_reorder_indicate_packet(struct rtllib_de= vice *ieee, struct rt_hi_throughput *ht_info =3D ieee->ht_info; struct rx_reorder_entry *pReorderEntry =3D NULL; u8 WinSize =3D ht_info->rx_reorder_win_size; - u16 WinEnd =3D 0; + u16 win_end =3D 0; u8 index =3D 0; bool bMatchWinStart =3D false, bPktInBuf =3D false; unsigned long flags; @@ -538,7 +538,7 @@ static void rx_reorder_indicate_packet(struct rtllib_de= vice *ieee, =20 spin_lock_irqsave(&(ieee->reorder_spinlock), flags); =20 - WinEnd =3D (ts->rx_indicate_seq + WinSize - 1) % 4096; + win_end =3D (ts->rx_indicate_seq + WinSize - 1) % 4096; /* Rx Reorder initialize condition.*/ if (ts->rx_indicate_seq =3D=3D 0xffff) ts->rx_indicate_seq =3D SeqNum; @@ -563,12 +563,12 @@ static void rx_reorder_indicate_packet(struct rtllib_= device *ieee, =20 /* Sliding window manipulation. Conditions includes: * 1. Incoming SeqNum is equal to WinStart =3D>Window shift 1 - * 2. Incoming SeqNum is larger than the WinEnd =3D> Window shift N + * 2. Incoming SeqNum is larger than the win_end =3D> Window shift N */ if (SN_EQUAL(SeqNum, ts->rx_indicate_seq)) { ts->rx_indicate_seq =3D (ts->rx_indicate_seq + 1) % 4096; bMatchWinStart =3D true; - } else if (SN_LESS(WinEnd, SeqNum)) { + } else if (SN_LESS(win_end, SeqNum)) { if (SeqNum >=3D (WinSize - 1)) ts->rx_indicate_seq =3D SeqNum + 1 - WinSize; else --=20 2.30.2 From nobody Tue Feb 10 23:53:31 2026 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F6AF73539 for ; Tue, 21 May 2024 03:17:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261459; cv=none; b=KGE4pLcqWZ00LmTjsSaEmhVENOHssAr6nx8TNWGjzg5VAKdJq55hXDOawCYuQ6ejDKBw0pUjvtHWBrKwU5+w5LX+r1tA1/Ngh87B8QP7n4KzlMM9wWNuHV/jxRVZZ0i8vuyu6x2XckTUCv0BDUaUIqAQenilG+sO7eVxbjWsHWQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261459; c=relaxed/simple; bh=O1x9lXALRfV3PEXYjxpd9ysMagtz9IVgfLsMeVEQ/yI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Jrg11zzeHpJYIw98wHJBcJbaBAdM1RHuFYPfs2+0Ck3uB0rNlWFRM9IFJzpGfwNC01UltGdxqMVRi2qE+FB8b3ArP9WLaTQIgj3kbc3cZwUCg8/a93rN92w03hYshdlInV//fLZejryh2sJA6EBClFaMbEXvPakW0A956wRU9xc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=GlPa6h0m; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="GlPa6h0m" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1ee38966529so24149375ad.1 for ; Mon, 20 May 2024 20:17:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1716261458; x=1716866258; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4fdeEpEPtpWbE5Mh9fqJmFvRworqsEQTxGybJaCMPRk=; b=GlPa6h0mP+AW3aywezI+gwc4M4G/gp1RRjYk6gHzreyZjY4QB8yw66QQV4Bjm9y6dQ So2OJ+nPOZD4F/1J3sDddLO+orVA50cWoXz9t1L2Ivh+MNbTaFSzoMs+sQiR1JB///E4 yXR0oai9NM+mtlmOQ+Qz1B0nHsCXG03srXhok7jV6N0+6OncRG+GKj79A5xpJiN7ofhd EuzLr85y6dbcP+QqZYRTx8e+Ozhlck8gXkc7zBBZaNGbD8NRf6hKO6AmRYHgFob7V7ZF WC0BqyfWqTrjBDUVL+7Y8WVJB5Dlr3dw1DFXvgRYCLb1odQPX+wPRr7VNfOD845LxIr1 LgdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716261458; x=1716866258; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4fdeEpEPtpWbE5Mh9fqJmFvRworqsEQTxGybJaCMPRk=; b=MlqvWRHDJnvwp/anliYX290RM4VSPPjeBjCq6QjQGbOxFF94oRvLW17bnUDHWeXp9w 2Iopj5zf6ZXnmMf5G+v4kUwguK2qA7q/vT4j4h69h4/diDZ0nJ6rA1GxFO08wTpUaqmj u0c0z2g0oVyD3iuskPP9dCw3qDkan3hjgUpAcwM/YP+3kMKB3eowxWRiHXzU9MhwjjpV gRNQXw1UHSFHr6VCXofw1uAb007ekW2TCsuUmYvEwmbydaPZGxhI9a3g8w3xsP2Ei9G2 yGJuvfUpZVHYpAB7WxfFK5VSCDXCR1n39IB6zOvQslSyNFJX6KkACaHlazzA1RFwcI10 +tbg== X-Forwarded-Encrypted: i=1; AJvYcCWlbwup1I7bq1NwSLPjltk7JCfx3IweaUak1LVZi7Kn/z38cFonTRuBVRP7caJ7QqyKHPl4Stw8+GYAbofhEGYoUahxM1xwE0Z227OZ X-Gm-Message-State: AOJu0Ywr3o1ws6kUrSwZgaHo1zi+0vAGvVNeiUCeZVOvwT9X9uFVL6W2 ghzfZwUh6IRmfXc++R+Ivi4Bb5vj7G7xcClzAH1OpgmgJEzCFEmU5Df2jbF5PNTeUhHR2GpeU0Z T X-Google-Smtp-Source: AGHT+IHLUgFiZc3Qe3eYozL7kHO2osGBiNgXlRXygRH9TaPBs9Sb/E5DEHR2GAEbHm1R06IhTO9DZA== X-Received: by 2002:a17:903:2448:b0:1f2:feb4:84f3 with SMTP id d9443c01a7336-1f2feb48734mr60320535ad.1.1716261457837; Mon, 20 May 2024 20:17:37 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bf31a93sm214885415ad.134.2024.05.20.20.17.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 20:17:37 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 21/31] Staging: rtl8192e: Rename variable WinSize Date: Mon, 20 May 2024 20:17:08 -0700 Message-Id: <20240521031718.17852-22-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240521031718.17852-1-tdavies@darkphysics.net> References: <20240521031718.17852-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable WinSize to win_size to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No change. drivers/staging/rtl8192e/rtllib_rx.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index ab2aa1a86c51..50687f3dce47 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -526,19 +526,19 @@ static void rx_reorder_indicate_packet(struct rtllib_= device *ieee, { struct rt_hi_throughput *ht_info =3D ieee->ht_info; struct rx_reorder_entry *pReorderEntry =3D NULL; - u8 WinSize =3D ht_info->rx_reorder_win_size; + u8 win_size =3D ht_info->rx_reorder_win_size; u16 win_end =3D 0; u8 index =3D 0; bool bMatchWinStart =3D false, bPktInBuf =3D false; unsigned long flags; =20 netdev_dbg(ieee->dev, - "%s(): Seq is %d, ts->rx_indicate_seq is %d, WinSize is %d\n", - __func__, SeqNum, ts->rx_indicate_seq, WinSize); + "%s(): Seq is %d, ts->rx_indicate_seq is %d, win_size is %d\n", + __func__, SeqNum, ts->rx_indicate_seq, win_size); =20 spin_lock_irqsave(&(ieee->reorder_spinlock), flags); =20 - win_end =3D (ts->rx_indicate_seq + WinSize - 1) % 4096; + win_end =3D (ts->rx_indicate_seq + win_size - 1) % 4096; /* Rx Reorder initialize condition.*/ if (ts->rx_indicate_seq =3D=3D 0xffff) ts->rx_indicate_seq =3D SeqNum; @@ -569,11 +569,11 @@ static void rx_reorder_indicate_packet(struct rtllib_= device *ieee, ts->rx_indicate_seq =3D (ts->rx_indicate_seq + 1) % 4096; bMatchWinStart =3D true; } else if (SN_LESS(win_end, SeqNum)) { - if (SeqNum >=3D (WinSize - 1)) - ts->rx_indicate_seq =3D SeqNum + 1 - WinSize; + if (SeqNum >=3D (win_size - 1)) + ts->rx_indicate_seq =3D SeqNum + 1 - win_size; else ts->rx_indicate_seq =3D 4095 - - (WinSize - (SeqNum + 1)) + 1; + (win_size - (SeqNum + 1)) + 1; netdev_dbg(ieee->dev, "Window Shift! IndicateSeq: %d, NewSeq: %d\n", ts->rx_indicate_seq, SeqNum); --=20 2.30.2 From nobody Tue Feb 10 23:53:31 2026 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AFED74BF0 for ; Tue, 21 May 2024 03:17:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261460; cv=none; b=DJQR2CaeiBIMNyPMUiJqqAllDjKZgF2O4Z6V3BkA2951nb4bABdYb3i6GpjX+8r4rH5INUQoQ1bXE+Xt3a7cCXwdn3IDe2FucvXbFOkDuG4WnlvF1FoMhmdxM/teLLS/bjDxlVJBM7Rb6mgdF+9g2DrlaWe+AUxoqGjLYYBmx7o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261460; c=relaxed/simple; bh=vJHmGCnlTHJFDnVcYQjewmNGAN8HLDG68bKJqwbNMA0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=mIW/dCsiDQQ6X4Fktn0+0cRvht6DKi3kfostIDFjxH4yMPAzs9Cf7OrfTXMBAWPISfT30dIbPi6ZJQYcgx5G9kupUaIgTySlH2NUURX2XkoYpDJsZ86mtDP4xYyrVLgWJxE5KCEuPDNoy9NtLMUIH1tkjfIZJmAO6ld8fHagAHU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=WX4XQM1Z; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="WX4XQM1Z" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1ee38966529so24149435ad.1 for ; Mon, 20 May 2024 20:17:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1716261458; x=1716866258; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OpJfdLLLMHxwJAQ9HWJFKbBxT/10Yc80Go3jO/vuxHs=; b=WX4XQM1ZY8DNCiBiHAdWLjy4YSm+ToqEgkeGSk6c+fW2Li+fxuomRd67zIaochHtka mQwq3H5JcBdNHir3ZIT6om4Ql+XoU+vFbardY/tJPdItuG6rVoa3h1Rbg3yMFbTGaDIp iHgW4EJ9Jgs+DriBvO+rwAsZNZChhOYCffC2J2DFbq3hFXHk0Pz51Xm9biFyaaMm7ztW 2jrx5Sgxsdm0PMkBijCmWJ+ipVNY9n4moKz8xqHYIQEgteUvmx5J5eqL+kWpNlQoLPwa b1JF7wRENac15cc/XHED99+N240q7YYzH0Kh+AnJtce+foQ3INZ5tupCcAi4U9gFs5V4 22WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716261458; x=1716866258; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OpJfdLLLMHxwJAQ9HWJFKbBxT/10Yc80Go3jO/vuxHs=; b=JI+HN0VSrvlGqbRzTtl3afEUbXCyPwsNZfHtFifTYFjiRLcH+PGrFbaeuE8nMbOEu+ ibiubZLYd8L2/MvEhVC3BNBRoZZRAWj9YcOm4x9pAg3VHzD29wKQ/ZK/R3ePW/EajiqF 7jN9z+jUzFiZiZr8PaDgI4bd3pqNT9UavBXLlRLigEHb8xq+KiPd0g6F12oYQBFQjZmp A7zItZNuxec+HWb8sv4eJPi9CwUUoKTlfXWsOISxwBwKWRSyenX6/q3Z0hGrdIX7W6rf HsJTOb+lr4MBDCwoajVuZypHk+HFTW2vtQWjZO0Z44/EqSqMPnG5H5qJ8gNh8Ock5nBO cv+A== X-Forwarded-Encrypted: i=1; AJvYcCVd3coX2XLEzhcLEorMQ2UfMm9cy0sDiuuQh5ueovkznB0GFE2Huk58ijWx31LsagMnejjfMMX4FJxCVKwbRFDnqVOEczAwqWDqMhNi X-Gm-Message-State: AOJu0YzLAfgJdac64vJrh1281p3PjTCLEFnV7cS9Lr2RPMTKFsradA/k P/5dz3xfPUCsSg5wQYC15dVCxdmna5d+izsNrWfPQVYDPz5IaiT2nWbGGP984Uo= X-Google-Smtp-Source: AGHT+IFOsf2NDCipI6AzAYxPue93TEwoIH3sdDO+DdvaRSsMgk1Gn6DPut2+hCrJ8DfbQHkOPXP2vg== X-Received: by 2002:a17:902:c944:b0:1f2:f8f8:680c with SMTP id d9443c01a7336-1f2f8f86a26mr72740905ad.11.1716261458649; Mon, 20 May 2024 20:17:38 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bf31a93sm214885415ad.134.2024.05.20.20.17.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 20:17:38 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 22/31] Staging: rtl8192e: Rename variable IsDataFrame Date: Mon, 20 May 2024 20:17:09 -0700 Message-Id: <20240521031718.17852-23-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240521031718.17852-1-tdavies@darkphysics.net> References: <20240521031718.17852-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable IsDataFrame to is_data_frame to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No change. drivers/staging/rtl8192e/rtllib.h | 4 ++-- drivers/staging/rtl8192e/rtllib_rx.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index f69f4ca39fd5..0914ba37f42f 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -338,8 +338,8 @@ enum rt_op_mode { #define RTLLIB_QCTL_TID 0x000F =20 #define FC_QOS_BIT BIT(7) -#define IsDataFrame(pdu) (((pdu[0] & 0x0C) =3D=3D 0x08) ? true : false) -#define is_legacy_data_frame(pdu) (IsDataFrame(pdu) && (!(pdu[0]&FC_QOS_BI= T))) +#define is_data_frame(pdu) (((pdu[0] & 0x0C) =3D=3D 0x08) ? true : false) +#define is_legacy_data_frame(pdu) (is_data_frame(pdu) && (!(pdu[0]&FC_QOS_= BIT))) #define IsQoSDataFrame(pframe) \ ((*(u16 *)pframe&(IEEE80211_STYPE_QOS_DATA|RTLLIB_FTYPE_DATA)) =3D=3D \ (IEEE80211_STYPE_QOS_DATA|RTLLIB_FTYPE_DATA)) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index 50687f3dce47..9741d351363e 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -878,7 +878,7 @@ static int rtllib_rx_check_duplicate(struct rtllib_devi= ce *ieee, =20 if (!ieee->ht_info->cur_rx_reorder_enable || !ieee->current_network.qos_data.active || - !IsDataFrame(skb->data) || + !is_data_frame(skb->data) || is_legacy_data_frame(skb->data)) { if (!ieee80211_is_beacon(hdr->frame_control)) { if (is_duplicate_packet(ieee, hdr)) --=20 2.30.2 From nobody Tue Feb 10 23:53:31 2026 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA9D0757F3 for ; Tue, 21 May 2024 03:17:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261462; cv=none; b=L0VRyC2A0WTs8hGeOYh77RlI5mbXyv67J1/F9qUTT2xlpFmn675P47NWzWUiYWvw1qSfECdh8m6nzJ7G4egHe/JAucCKT47k0HlyY13nwp3/crr/j7SVcTjtKrXPhDqCCS6kLHd/gycEI8BtLTqsy0G9UQkDcFgMTyl97/3ITx8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261462; c=relaxed/simple; bh=BH5PhLOzGabd2LyORxMioicNxfmFgwW/JLD24nQfeWc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=LCZX3ZpQ498vJ5PJZTZ2mBG3+yIt/F6OXzLM8WLH3Fj1HTk0D/nxZiGaFhHzvV/I+Ewnr1kwbBoPEidv4UfsJ28T34KO3kjom5caEX7PF/ZXnGgInkJ5bZN6lTjOG+gl9+yI4aY8gNHEGjfZtt756BeBTStQ8rInCAAgMuEvnTo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=K2wDY6Q9; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="K2wDY6Q9" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1f2f566a7c7so64565815ad.1 for ; Mon, 20 May 2024 20:17:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1716261459; x=1716866259; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LlLPLUi/5OI3lQ5UEAOn0I+EJPj8lQ3+XMJGXZAx7Bk=; b=K2wDY6Q9P0MzS92PHIHr6TwbRQ3eZWlzVVB1BUFbEgtB5nA2n+ZqyqDRFeZAtQpxcX aRMnmhSg5su5d75uy60gkGYrgKinzcLp6YD0/ZyNH/iUJSMwZnnrQ8BsCuBOdf/gYAr9 gHQ451I184x5pNvfHizGBCNPuBNyt7G9wH5ligfH3jHZgy6zw/Za14RIOI2B12SloBg5 MbstKahx00gsZ7FlQSm/MkB0Qh7+L1b7n5ego+1OMNcJu4T7Uz1VnBeW3zSk9kqjo9M8 cJHn04kycIdl0pfqBfWH1rm3QNXM/bJM9l319sNqYOxR4lvN8pcx7c+SCJL8aMuPUBST bi2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716261459; x=1716866259; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LlLPLUi/5OI3lQ5UEAOn0I+EJPj8lQ3+XMJGXZAx7Bk=; b=jw6Cuayq35p/VLE+Er4TyWifPWCUn0QEOkZM24EWzCYN6aDgjJ2rxlq0bIiJULvLmq idl0M6sZ6YTT6AWUsD/5zP6p9jDBQucbWt1csq6n/4MyMO2GCBYXIKwf2wb2mhob6uHc 8pbqrBwGszC/kdp26jNreomq1xHG/60rALh1LmpfXqbkvHm1t8w7dAFrk/XzqhRClmzn FEqv2ibOP1h2HMprm6sOixBub+nElsvIZyR+ia0V0woOu830iQV/xnYO0oBHzr/OcNTs v0b1RSdFaytrAiHm3wyjh2Vubi+lY7qcVP+DXMhFpW2fuQi9vee89CtZf7vvxyZn2cg9 mcwg== X-Forwarded-Encrypted: i=1; AJvYcCXkmr9GmqvltB2DkbQtqMyHls2pgbJEZFgzbG4jgE5HzM+tSjQ2GXnWA4BuJdgx7ZtQxLvLAkWi9ueum2fOPS7z0g7TXXHak8yt67w/ X-Gm-Message-State: AOJu0YzDh5wdfpULm9+2ONY9tPllFYIZU66z+u9bXPErhLJ08ksBYCBQ 3q4+k/HkYhwHsLSNCz1k7B+c+4olrt8qKHpcAwfRNIIwaQCYW4C9/qZugVqo3Qc= X-Google-Smtp-Source: AGHT+IHUOS9oJ3E6Jg97TDaSZcbDD/AcLxwy5/zgEhM+cTaRxpX3PTrAhC1Svqtwfb7MaS7uMDKFvg== X-Received: by 2002:a17:903:184:b0:1f3:704:8304 with SMTP id d9443c01a7336-1f307048b69mr32619435ad.9.1716261459338; Mon, 20 May 2024 20:17:39 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bf31a93sm214885415ad.134.2024.05.20.20.17.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 20:17:39 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 23/31] Staging: rtl8192e: Rename variable bMatchWinStart Date: Mon, 20 May 2024 20:17:10 -0700 Message-Id: <20240521031718.17852-24-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240521031718.17852-1-tdavies@darkphysics.net> References: <20240521031718.17852-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable bMatchWinStart to match_win_start to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No change. drivers/staging/rtl8192e/rtllib_rx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index 9741d351363e..7e41519d997a 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -529,7 +529,7 @@ static void rx_reorder_indicate_packet(struct rtllib_de= vice *ieee, u8 win_size =3D ht_info->rx_reorder_win_size; u16 win_end =3D 0; u8 index =3D 0; - bool bMatchWinStart =3D false, bPktInBuf =3D false; + bool match_win_start =3D false, bPktInBuf =3D false; unsigned long flags; =20 netdev_dbg(ieee->dev, @@ -567,7 +567,7 @@ static void rx_reorder_indicate_packet(struct rtllib_de= vice *ieee, */ if (SN_EQUAL(SeqNum, ts->rx_indicate_seq)) { ts->rx_indicate_seq =3D (ts->rx_indicate_seq + 1) % 4096; - bMatchWinStart =3D true; + match_win_start =3D true; } else if (SN_LESS(win_end, SeqNum)) { if (SeqNum >=3D (win_size - 1)) ts->rx_indicate_seq =3D SeqNum + 1 - win_size; @@ -589,7 +589,7 @@ static void rx_reorder_indicate_packet(struct rtllib_de= vice *ieee, * 2. All packets with SeqNum larger than or equal to * WinStart =3D> Buffer it. */ - if (bMatchWinStart) { + if (match_win_start) { /* Current packet is going to be indicated.*/ netdev_dbg(ieee->dev, "Packets indication! IndicateSeq: %d, NewSeq: %d\n", --=20 2.30.2 From nobody Tue Feb 10 23:53:31 2026 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB54076057 for ; Tue, 21 May 2024 03:17:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261462; cv=none; b=CeCMOYhnJNgccrZCvBlegragHcdE0P8TxZ7iev0M7j9RNjCdDvTUjfsrkPhjkJ9WQRLGlxYYtX5uNssdq04/7/5OMvBjoTptWKm/RN0+lYrqAMuA6y5J9WAh16jhtsG6xF+nnQi7xYNRqxg7ZpXrgf4RVH2oeZh5CHIWAsaQ8sk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261462; c=relaxed/simple; bh=CuSkbWzRNmgEhaFefmBeplAIbDah/SxhcN3EtVvQ+Y8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=P8dfuKpvTYkzUL6m+ceZ5aGrjllrlEtPubCewWdPM2Aco4l//7FC13viAdRZEHTp6oMloRDCXUTZNyt0KtIAVyUzOuCNalQmS7Ex4K/T21mHPC6BK2BFnAyDC5vcn76B9LOdqxz5E6TBPRhtRl3rcGPY2TQ0i09xNBBQwqKFY9U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=jRPp0Ru7; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="jRPp0Ru7" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1eb0e08bfd2so98963555ad.1 for ; Mon, 20 May 2024 20:17:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1716261460; x=1716866260; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5sIarUzF2tCuO5H11FbEf7IvlQmJwJFaix8anRhpZwQ=; b=jRPp0Ru7/xGkU5oUwi/UVS3THkqRpkKxVMtQmMDS3D+fgAWr3FZMaUzCOamc65bMLc +UH98dyURkPFsh0RvsQKrhV5tNSqN3Rrc+xQNz1mtjFRSajGB2ljcNRpRthuF06PTH5G Y08St5Uycg7uPl221yRNtnSogWOOBweQhoAdCAM5DB/HKSHxJxuCP3/AbUIs0NBAdFNR GBeuW7LumeplTVVgLfOrEd+fAxDI/gJ3QWGRmdUD1+4GvCXQ8EgDFQjAGHYrKQqWMHcQ TuH7p8aJCXjF5/6+g7ZHugEOn8HAoSUW7v2KClbNCPhOs1i0clSZQXoZPK9CMExFUJHc y9bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716261460; x=1716866260; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5sIarUzF2tCuO5H11FbEf7IvlQmJwJFaix8anRhpZwQ=; b=CWaMXnhDdRaYE52jAMSPHAfwgB0Di1NZaxs6UnO2K12somVPb1Lh6awIrXTop5SJYv 4Yd/uKjJqr394ayuSTpjg2l0s+V4FoNVVeLxasBT74NgGL41iGLkAFemdiLr3CMCH/6/ sxv+kDzq40Bt1eiNVqbT8mYwUrVliugRu8CDRKdqnnQXUZEB6pE6l5C8pck6lzblTtcO 6r+ZTtu+KcSwBPpgFFhAOlrHKntHIF5lJiyQQnEI5MTlSyzx8Ts+OB4zmkeunidN9Jmw pEeiZmmiNMKg79+mbtdL3uRz0i8UAe8k9HZyHht7yAPzRhn8MuOGNZJpZoicU46ZmVDC lH4Q== X-Forwarded-Encrypted: i=1; AJvYcCU3jWc60wpX5XJ3eW7BgjvQaiQ9suK/J3ZrNsncJfWoiBhaYsBETV0f2GLTUiqalQgQorxgJhcgUotBoO2MKJthrjy2c8IdBhYd+3G5 X-Gm-Message-State: AOJu0Yw4rKZXMXVoM/ZeS4/PqdnePK4iVH2C5eZYPCdsfmpCBYa6Es9I huN9CIW3K7B1vwFJoVH+0kqLd9sWTh3MEwV5tOx1qHRBPRysNi9QZnX4KmzBG4BCEFE53Zg5QTx U X-Google-Smtp-Source: AGHT+IFVS9fZKUBesDxli8IK6MdEI1+1J7dFgtFOdibJVi6iwJ1Q2AG8ffB5ZIrhDQU89OpkPSdFcQ== X-Received: by 2002:a05:6a21:1518:b0:1b0:9b7:bbe3 with SMTP id adf61e73a8af0-1b009b7c0d3mr22886121637.0.1716261460190; Mon, 20 May 2024 20:17:40 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bf31a93sm214885415ad.134.2024.05.20.20.17.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 20:17:39 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 24/31] Staging: rtl8192e: Rename variable bMBssidValid Date: Mon, 20 May 2024 20:17:11 -0700 Message-Id: <20240521031718.17852-25-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240521031718.17852-1-tdavies@darkphysics.net> References: <20240521031718.17852-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable bMBssidValid to mb_ssid_valid to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No change. drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_rx.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 0914ba37f42f..91164a3b01aa 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -914,7 +914,7 @@ struct rtllib_network { bool ckip_supported; bool ccx_rm_enable; u8 CcxRmState[2]; - bool bMBssidValid; + bool mb_ssid_valid; u8 mb_ssid_mask; u8 mb_ssid[ETH_ALEN]; bool bWithCcxVerNum; diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index 7e41519d997a..480d4bf8df4f 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -1817,14 +1817,14 @@ static void rtllib_parse_mife_generic(struct rtllib= _device *ieee, network->ccx_rm_enable =3D false; network->mb_ssid_mask =3D network->CcxRmState[1] & 0x07; if (network->mb_ssid_mask !=3D 0) { - network->bMBssidValid =3D true; + network->mb_ssid_valid =3D true; network->mb_ssid_mask =3D 0xff << (network->mb_ssid_mask); ether_addr_copy(network->mb_ssid, network->bssid); network->mb_ssid[5] &=3D network->mb_ssid_mask; } else { - network->bMBssidValid =3D false; + network->mb_ssid_valid =3D false; } } else { network->ccx_rm_enable =3D false; @@ -2347,7 +2347,7 @@ static inline void update_network(struct rtllib_devic= e *ieee, memcpy(dst->CcxRmState, src->CcxRmState, 2); dst->ccx_rm_enable =3D src->ccx_rm_enable; dst->mb_ssid_mask =3D src->mb_ssid_mask; - dst->bMBssidValid =3D src->bMBssidValid; + dst->mb_ssid_valid =3D src->mb_ssid_valid; memcpy(dst->mb_ssid, src->mb_ssid, 6); dst->bWithCcxVerNum =3D src->bWithCcxVerNum; dst->bss_ccx_ver_number =3D src->bss_ccx_ver_number; --=20 2.30.2 From nobody Tue Feb 10 23:53:31 2026 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85DF1768E7 for ; Tue, 21 May 2024 03:17:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261462; cv=none; b=elpfP4DAursmFCQzzY/KIODy8BQWKTh89ykmHtTgYmiLzkgZNZqIzKT9tl/r6Mka6fqKNyWLZpemt/BJ6Wspx1HfmhEGQ6Eae5fg/Yui7EU1M4zVSM47AyBoUWUIQQ5A5pB3soaMESWb4tCPrj2afnf+oLSLGt8mQzWfvg8KZzA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261462; c=relaxed/simple; bh=zCqvorSBaGZIzif+lPh4oaRT8OhvldrR3odkMX5XB38=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=JawyCDiqosH/2Jp5dUmfhYS2+FON2hRIEwed6u9Hnlu6A3ks6FIrhkB8tPIduyszwoTn9WR9YYloAnVIpEjOIAgtm1WkS8CYlEzO3i0/53QU8QVJGW3K8YlHbUwiWfDhfd94NjAgn0PmRxcirM3iYlAxYO5bfE4f49G65vtNHjU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=HjsGsX6y; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="HjsGsX6y" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1ecddf96313so81732275ad.2 for ; Mon, 20 May 2024 20:17:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1716261461; x=1716866261; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bi0tzsNlePC+MRPb33kI/mSFw1w7V1fTyHb4oJsIRQ4=; b=HjsGsX6yi4WBnGkUDph7QHA35WfHK11zuQruBxqRlQnfGquovkWm0/bsiUdH6cKvdN P2zmfpdWgXUzlyGaH8xNFzumEtx/gJkP+NWa0SO5K0y3kOqKK0/Ihm+9VmRsUJD8Y+1V tBX8NDbZ2zN0yjyQtPxY50+jIhxET7Hmb5kKEplvKISwZGG5HobC9Z6br7wpFrtC4QdJ 0jp0iYI6qnG/VkOOnPW6FUgafooy9YZFj2k8njt+j7Ir5lnHIUKsTrsKNwiolVyfiFJY 8BkWnp7vNryktJQsrLveQwf9L4rv9Eh0kDnHkPxp5Z/G7GrjbqItMspfyN0+Aiup18gj qQXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716261461; x=1716866261; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bi0tzsNlePC+MRPb33kI/mSFw1w7V1fTyHb4oJsIRQ4=; b=cTXK/EezFIUVzzOGJO81Fx/rFOmmsk1hTMhkSjCRaTLORslqqGc4NZxwp8aj4qjJhE 0YXDHSwk0N4oYclwuhjuNyo2BK/uHyvmvKsaQp1YfpE1ROsSrjqxLnbyV4nlPFUI7mOb MwKFiafy6WNMIOKsvOTbPoBwacgiCbbE2QTk3Y1lgrZd3QGbrVGdED2BvD4NVa6pF5lp i+dvrkdcznPj7XQK9vZpmWDIdy3DaDrbF0Ty1QyzpTdiaN1vJdfETShQiYzmP97NdY8L koSE3jRnOM5fatihFCOUSr1bYHL6/hGSixL7SxZAmOl33BIaF22h6WEpMvYyYnWn116t 088Q== X-Forwarded-Encrypted: i=1; AJvYcCVBxN+dI3OTsLg/k4jVw0d+grw49MFs81LShcCqHx5fxgMIbcnWjXkjdsoS5RNN4XVNbY12dSA3vQ2iXWnp8812pKNnczL1gu+1cLRb X-Gm-Message-State: AOJu0Yz43sp1EnC7j3dDJseiY1GZzWpYlQDwFnyvdCfNKwHqdvkvD/7X bbtLt2SZpmdeMHh+RkUut/tv0x2TOTwLBSiJ/+EkBq6RJg029SxR2NpKH3IaP5M= X-Google-Smtp-Source: AGHT+IE1lUAWf9zcNS4+KWUmFaa+Gmi+y1btT54d3CnG4I5elxQClQvx7GoFbtofB9i0QLiAf/kcfQ== X-Received: by 2002:a17:902:b70a:b0:1e2:8841:8d67 with SMTP id d9443c01a7336-1ef43d2da8cmr343378175ad.32.1716261460995; Mon, 20 May 2024 20:17:40 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bf31a93sm214885415ad.134.2024.05.20.20.17.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 20:17:40 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 25/31] Staging: rtl8192e: Rename variable bWithCcxVerNum Date: Mon, 20 May 2024 20:17:12 -0700 Message-Id: <20240521031718.17852-26-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240521031718.17852-1-tdavies@darkphysics.net> References: <20240521031718.17852-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable bWithCcxVerNum to with_ccx_ver_num to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No change. drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_rx.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 91164a3b01aa..4fec36cfa2fc 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -917,7 +917,7 @@ struct rtllib_network { bool mb_ssid_valid; u8 mb_ssid_mask; u8 mb_ssid[ETH_ALEN]; - bool bWithCcxVerNum; + bool with_ccx_ver_num; u8 bss_ccx_ver_number; /* These are network statistics */ struct rtllib_rx_stats stats; diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index 480d4bf8df4f..2d0a0efedc97 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -1836,10 +1836,10 @@ static void rtllib_parse_mife_generic(struct rtllib= _device *ieee, info_element->data[2] =3D=3D 0x96 && info_element->data[3] =3D=3D 0x03) { if (info_element->len =3D=3D 5) { - network->bWithCcxVerNum =3D true; + network->with_ccx_ver_num =3D true; network->bss_ccx_ver_number =3D info_element->data[4]; } else { - network->bWithCcxVerNum =3D false; + network->with_ccx_ver_num =3D false; network->bss_ccx_ver_number =3D 0; } } @@ -2349,7 +2349,7 @@ static inline void update_network(struct rtllib_devic= e *ieee, dst->mb_ssid_mask =3D src->mb_ssid_mask; dst->mb_ssid_valid =3D src->mb_ssid_valid; memcpy(dst->mb_ssid, src->mb_ssid, 6); - dst->bWithCcxVerNum =3D src->bWithCcxVerNum; + dst->with_ccx_ver_num =3D src->with_ccx_ver_num; dst->bss_ccx_ver_number =3D src->bss_ccx_ver_number; } =20 --=20 2.30.2 From nobody Tue Feb 10 23:53:31 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CBFC75818 for ; Tue, 21 May 2024 03:17:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261463; cv=none; b=V6z4dM6kIykpkfWyKr9uZMYuweLxyKKmCnPvhjySuHnViqVq0394wvVj2Hq9zya6SSef3HrHJ2lrhxweqfetbL8ZA/hRG5Idmaxn/pPP9CfrJmc2EpSvmVEAqiah062bV8GE0G4KmKEBmUU3JW9TMRtY+JXB3bK4JgQluGMGzj8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261463; c=relaxed/simple; bh=cbh5TxJ9lOr9epBP+PxY9ro4whHmhXzi0y+5nh95DMg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=qlPqRa5QnwfQPXxjq0tlAhbXoARTfi1fCOv4rtcZo7tPnsl/CgdnbT0VltCLFabCx7iGZbXypvWwcKeqln1H2vj0LqunVmKBoleJAzTngqKkQigI2+jw3I8JULw1mX+40bfyHQIyQmRcnqZufe9bVaL6f2iy+LOp6DTeEbxGFKE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=dNZAF70t; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="dNZAF70t" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1ec486198b6so88003215ad.1 for ; Mon, 20 May 2024 20:17:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1716261461; x=1716866261; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cKXdhlAm8cv2q262aWrYc+MjVhozaby61eiStvWdJh4=; b=dNZAF70t7Q55AkwbPYUOlZuyAM91+ZhgM44kw6WP9LxmP810QQ94EaiRBRAjYZ4YOt KchDKcGi52EFubXKbiQ2k+TOpiO4if63c5NW0AB1N7qst9U2b9R8gRyZXWfC6uZfJGd/ 7kg9WWvMQxKZ91zeMVknGJiFVDKWgGaDhFkc2YvGsv5etTUflMlreBe3CAVm6u6mPoKf tuLCS6RFJiwKk+tpJcIBBtzaLgzranZruwaEn+OjQgdmqE5dq3EdkPFcymbYRt/ydIBL SkstDxgU+suHo+Iw4xc3kdLM4JfzNVlgJnP+lZjilQHQPTSaL5GV88q1MKxtbduBweSR 2BbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716261461; x=1716866261; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cKXdhlAm8cv2q262aWrYc+MjVhozaby61eiStvWdJh4=; b=idsbhBoX0FEFeZddoCF80xI9c86uQGy2D1Aryg7vDxeUuTmmdu/WAzfAZnc5r0thLr KMmkimaOYVyWJeIBq3rrZMt44G8Hm4XfBfZqIvYlwVkNCiycHWEbGhrcliXri0b6Mhrf EEB6oEEQ3QoT9RthpdCcjJTsibUH5eXdx1z5/xmhY31DMtGCuZTnMaknXoZA8z/uYtuJ fLp7LDPvEgtmLMk2Qcn+6BBGLF2qPG/WCDnRmJ3a4xv3rqjCyGHH1ubmkhEtgg6MCTOA Mypil9spdGV0xvg2Ak570VrPq7dHQH1su7Go9RkPT43DiK/GPwEEhbJ7lsi5fXCD1Vgz UJQg== X-Forwarded-Encrypted: i=1; AJvYcCWAr8Ng2ay0vf+YXSoiuu50RELTfWDob95dNxeFz2NjKhBoJKSEKOge5rtebLNSoORzxx/roXtO5wFYMDtGwSpel2WgmVUfOMGyW8aI X-Gm-Message-State: AOJu0Yyjz4vQdR/+tpKiRnWjJFYbVxIjnkgXiDm6Vt6MUifN8WW+/iAR 6c10vw3jLj3oU3aQJhsfnkC1VJpmahpcgAXfKCjOiTDRA5VYcJsqWG6sSn7z3So= X-Google-Smtp-Source: AGHT+IEv01dRQXsvlO+6puFkXHHTmVcZ5c8jKElNm2gicctO/+98PGsaZebxky0gX6+gzQ/k04BD4g== X-Received: by 2002:a17:902:7849:b0:1f2:f784:97a3 with SMTP id d9443c01a7336-1f2f78499famr50867705ad.51.1716261461656; Mon, 20 May 2024 20:17:41 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bf31a93sm214885415ad.134.2024.05.20.20.17.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 20:17:41 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 26/31] Staging: rtl8192e: Rename variable Frame_QoSTID Date: Mon, 20 May 2024 20:17:13 -0700 Message-Id: <20240521031718.17852-27-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240521031718.17852-1-tdavies@darkphysics.net> References: <20240521031718.17852-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable Frame_QoSTID to frame_qos_tid to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No change. drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_rx.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 4fec36cfa2fc..b88c7cd399fb 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -799,7 +799,7 @@ static inline const char *eap_get_type(int type) eap_types[type]; } =20 -static inline u8 Frame_QoSTID(u8 *buf) +static inline u8 frame_qos_tid(u8 *buf) { struct ieee80211_hdr_3addr *hdr; u16 fc; diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index 2d0a0efedc97..22c04f37bb40 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -888,7 +888,7 @@ static int rtllib_rx_check_duplicate(struct rtllib_devi= ce *ieee, struct rx_ts_record *ts =3D NULL; =20 if (rtllib_get_ts(ieee, (struct ts_common_info **)&ts, hdr->addr2, - (u8)Frame_QoSTID((u8 *)(skb->data)), RX_DIR, true)) { + (u8)frame_qos_tid((u8 *)(skb->data)), RX_DIR, true)) { if ((fc & (1 << 11)) && (frag =3D=3D ts->rx_last_frag_num) && (WLAN_GET_SEQ_SEQ(sc) =3D=3D ts->rx_last_seq_num)) return -1; @@ -1321,7 +1321,7 @@ static int rtllib_rx_infra_adhoc(struct rtllib_device= *ieee, struct sk_buff *skb hdr =3D (struct ieee80211_hdr *)skb->data; if (ieee->current_network.qos_data.active && IsQoSDataFrame(skb->data) && !is_multicast_ether_addr(hdr->addr1)) { - TID =3D Frame_QoSTID(skb->data); + TID =3D frame_qos_tid(skb->data); SeqNum =3D WLAN_GET_SEQ_SEQ(sc); rtllib_get_ts(ieee, (struct ts_common_info **)&ts, hdr->addr2, TID, RX_DIR, true); --=20 2.30.2 From nobody Tue Feb 10 23:53:31 2026 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 000F077110 for ; Tue, 21 May 2024 03:17:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261464; cv=none; b=n94mhe5mSH6izmim7b/eZrwfXN29lP47o+QeaSc6T1aU61rE6om5DLyBKr0zt/z4CRC0Cz3JSQ4IdDMIjyjOmzdfIarvk3f26vCHwS1PSC3VnQ3T3iwW7wnhexZQkglUYTXfFLMbr6dQyCvV8XQnLufdrgu0c0AaQ0lLDc1IMnE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261464; c=relaxed/simple; bh=sskCsC9Vm7UrLbQDRtkQoQ+iOreZFfaBms8WkVFgyLo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=OG9IXmoO+hoxQ5F10wCuit/nRFrOoi2IGnFA5ZdGZn8YOnb4uohy33E4CerM/SyCQetYvrqdTKaoP/8LUuvnjOC2zrZRlvatzqIenA6Mk1BBDtPu6YWhz/Mhvec9Es3fhaAj3XCSm7cnofgyqR+1j/kV9/KzhNVKuCWms1BRMVY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=DY8pY/zv; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="DY8pY/zv" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1f3105f3597so1967555ad.2 for ; Mon, 20 May 2024 20:17:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1716261462; x=1716866262; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jEDkjeMT5xd5TiSydSW03WzTRxILrRiRjBw53kiJS/I=; b=DY8pY/zvGjKhc7Yb6kr3AgER/9UjtWO5QsTzUei4jGiwhRdb1aSLMf1lhQWlsat0f/ ygsDm6Gb9HHZafzz2CSTpA/ii1Sc5+0dlmP2XkgBFgbkBQReugnunxlVtcV0zaI6CoF2 6nUpudjYEAt7FPrNycji96ST8r4fKEqAMn4ZVvC9+jblJA9HNyyYyUXSmrqkqTpsHjIL gx9fKTh2c05rPdkC4xbeRi6zAe2gyBSQqS+6Xh0b5smyJqquPdQj7QIt5zp3wFQ47XaX 4UQWO6rXQh09E3AcHd2zxqjYL97dfmX7GSVEygHYCFPtOxraLLA9yIgnRyDAKEFYbgWd TmUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716261462; x=1716866262; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jEDkjeMT5xd5TiSydSW03WzTRxILrRiRjBw53kiJS/I=; b=sP+vDkSMAIj3dGO5My4JOyCu3IvmLinEBIrjTO4m4gsm5BbW5ZYQ8t1eZDhYei8Wqs FSnKOnvn32+Gw6NZ0alwCPDhIkMPGKznTQHyYYxxcegq3W8Cp66dcLslDziSjcKcpiEA n4OdR05H0522eLRzI+J8tHnL7jKLLf/Oz+W/XV4DU+zZ4SdrHlMalS30g2+H2UL+DCB1 gGMfwwSdwbM87bNkV6DgQFzNdIU35kiymBbD93L1O+SHHj0Cz8pCg18zKxzHMm0PL+vx /BB8rE/NEYhIPCStvUwOVHgPkSI/9H790ReInKzJ2EOkZQjKGzr7y0rLiU7lSq8yGCIy xliw== X-Forwarded-Encrypted: i=1; AJvYcCXNkRieuyi5vXM2ixKykUPtt5opQjoi+JH1lxowvy3/UWilkVzOjVDLn/uB9LukMDPC29eetG33aqv6CXyjnqpWyBIDFWInL29tr45Z X-Gm-Message-State: AOJu0YxGf5pvnF4N66MxI+wzGXa9uYLu5rVC3JdtHi4iPWh0EeJl6r91 OC+cjsbqA+1ddtmt6rBYROhoJhPVJ+MOxq+KK6x6p06MNcFQNIIYngv37O28BJ9Q2qONxcQ5ETr V X-Google-Smtp-Source: AGHT+IG79QyCRtGTpo6DaeE6OC79fud+iH4BsmkxBCnehK+xNrUjxZW1M3SLBKnYMz10OsNWBQUJ+w== X-Received: by 2002:a17:902:6ac5:b0:1e8:2c8d:b749 with SMTP id d9443c01a7336-1ef43e25e67mr297822655ad.30.1716261462384; Mon, 20 May 2024 20:17:42 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bf31a93sm214885415ad.134.2024.05.20.20.17.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 20:17:41 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 27/31] Staging: rtl8192e: Rename variable CcxRmState Date: Mon, 20 May 2024 20:17:14 -0700 Message-Id: <20240521031718.17852-28-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240521031718.17852-1-tdavies@darkphysics.net> References: <20240521031718.17852-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable CcxRmState to ccx_rm_state to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No change. drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_rx.c | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index b88c7cd399fb..ca69bb0965ba 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -913,7 +913,7 @@ struct rtllib_network { bool with_aironet_ie; bool ckip_supported; bool ccx_rm_enable; - u8 CcxRmState[2]; + u8 ccx_rm_state[2]; bool mb_ssid_valid; u8 mb_ssid_mask; u8 mb_ssid[ETH_ALEN]; diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index 22c04f37bb40..3e8ee1335c24 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -1810,12 +1810,12 @@ static void rtllib_parse_mife_generic(struct rtllib= _device *ieee, info_element->data[2] =3D=3D 0x96 && info_element->data[3] =3D=3D 0x01) { if (info_element->len =3D=3D 6) { - memcpy(network->CcxRmState, &info_element->data[4], 2); - if (network->CcxRmState[0] !=3D 0) + memcpy(network->ccx_rm_state, &info_element->data[4], 2); + if (network->ccx_rm_state[0] !=3D 0) network->ccx_rm_enable =3D true; else network->ccx_rm_enable =3D false; - network->mb_ssid_mask =3D network->CcxRmState[1] & 0x07; + network->mb_ssid_mask =3D network->ccx_rm_state[1] & 0x07; if (network->mb_ssid_mask !=3D 0) { network->mb_ssid_valid =3D true; network->mb_ssid_mask =3D 0xff << @@ -2344,7 +2344,7 @@ static inline void update_network(struct rtllib_devic= e *ieee, =20 dst->with_aironet_ie =3D src->with_aironet_ie; dst->ckip_supported =3D src->ckip_supported; - memcpy(dst->CcxRmState, src->CcxRmState, 2); + memcpy(dst->ccx_rm_state, src->ccx_rm_state, 2); dst->ccx_rm_enable =3D src->ccx_rm_enable; dst->mb_ssid_mask =3D src->mb_ssid_mask; dst->mb_ssid_valid =3D src->mb_ssid_valid; --=20 2.30.2 From nobody Tue Feb 10 23:53:31 2026 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD8EF77F2F for ; Tue, 21 May 2024 03:17:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261465; cv=none; b=sg0/zLaJQAbnUp/+C/ZqP1yROonN/vSqYlMdhMStA7SVgEPNMoS5R4BnjCkscbZd0AvCQPre0Is7THxCBNl6NR5lipgf5x7pe3lSWNHsduHtarpwG2RAIDKq4OBOJrj/2ih02ckFNIz+tK/dgYUbaCu3G3ikAzjm+OsfQKIYwjA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261465; c=relaxed/simple; bh=WpyAz4wfmdfSZALVu3DB4xV0NpQuAtGDfjdRDPjwzzc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=jJ2AW0GDAPXwro3yk2Qazg64Ir/hewEKGi6b1R6on1bD97UNGITitBvf6cJsQ1cG0NbmNsXCqAhI0m1gexKtFt8mspyGahAdSrMgXI4a9z5slNlmJ8ZTYkyRf1TLJ/UFbsrkzrkUtAKN2sG3kPVuHGpSzGeJ2Txetl3opZiFCzU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=GDtwBcK+; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="GDtwBcK+" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1ed0abbf706so26890575ad.2 for ; Mon, 20 May 2024 20:17:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1716261463; x=1716866263; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5yp9yXgV9Klh/+mkE2OY5ZmNDFLPm1WNDo65CGEwjjY=; b=GDtwBcK+n4BjNYqKW7Vgfl6ZrJbMsyRxmk3DQmFxCyivdxDdPXa5sZsNpReYTaZ8p/ G02jpr8xI1m2SCGajmGOiLIwe3YaIc/9CSe3yqI0xjggmsIoRJzR9v5XB+aCoCOnBOws 73n5HRd1FNTuFr/PrtCvaNs1lJUpuQzwWS2Si+5GNLECakmHfS5n66X8d/M+PQ3FUbUs rmQ10LrcqqQ+kflQwOjrcYZN8p0j+vB33CC9rgIYyvgqQxQ2snjBRtYQr+PV4wo2feuo RITTM7bzAYQBRbqw3jGWevNUEfoAZRC3qEIqHRFhlMsSVVgup0PLtVQI8NAyhtQnBQfy Wr4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716261463; x=1716866263; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5yp9yXgV9Klh/+mkE2OY5ZmNDFLPm1WNDo65CGEwjjY=; b=O1akir5YsjJqo7r7HDtwRQd7LT6zrnFM313i9sTt3Rs7wwaOyh2g82dRLVPDy0HqEm MXQdTrvRZCQ6kU2X9rCXoU29bS+8RYtxqF8FMqUQ4mTmWefBxOIhcGDJkbzNMpfzxlxZ H9CgZkZD+M7d7RGMSbCNCo3YYJRJgJZQj2sOUFDHm+LkUlaIH3RPrFSZhFa7M4/Ah1Kr Hds9ea+LXb6DWxTauZ3jEpDG7n+Vd0iIuXWj34hJJ3FrbRdfKC37uE+gKMdEgicet0+5 MNb0/ltZZ9QjiGrVmHegxFtAo6Z3UyGmpXSkt8dRFHDVyE8E59U6q1YAbYcweoYr0f9D ELBg== X-Forwarded-Encrypted: i=1; AJvYcCXLMw1zorlRmsECJcshr6dCt35eNyvS74WMZWQ8xn8aUgfH2pqgOqcX62zGV8LYaNUhBUAXHlhBXqQy/7c/2NLQSDOsxGJ2bMafifJa X-Gm-Message-State: AOJu0YxL++1lgPvklOMze2wJTT3QWICsUB7FQ8mNqqox8TOl6Qk6jsfU SMvdTcTQAWgwduVX7cEY/gBDhLa0Bqw6ImA7OR+0v8BePkkE+Vb/W0pgzBEQ4GnWYMio2Ff2tbp y X-Google-Smtp-Source: AGHT+IHs6mSWS6UdBkpPE/OJN4puMJl+wlxrOdvXDxZwnag1VOT2ZFK/LfZ1pCZ+djJMxnGbyCbwNA== X-Received: by 2002:a17:902:c942:b0:1f2:f3dc:43ee with SMTP id d9443c01a7336-1f2f3dc4ddbmr85796915ad.3.1716261463134; Mon, 20 May 2024 20:17:43 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bf31a93sm214885415ad.134.2024.05.20.20.17.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 20:17:42 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 28/31] Staging: rtl8192e: Rename variable IsQoSDataFrame Date: Mon, 20 May 2024 20:17:15 -0700 Message-Id: <20240521031718.17852-29-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240521031718.17852-1-tdavies@darkphysics.net> References: <20240521031718.17852-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable IsQoSDataFrame to is_qos_data_frame to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No change. drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_rx.c | 2 +- drivers/staging/rtl8192e/rtllib_tx.c | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rt= l8192e/rtl819x_HTProc.c index 9b0a981f6f22..36a734ded7dc 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -625,7 +625,7 @@ EXPORT_SYMBOL(HT_update_self_and_peer_setting); u8 ht_c_check(struct rtllib_device *ieee, u8 *pFrame) { if (ieee->ht_info->current_ht_support) { - if ((IsQoSDataFrame(pFrame) && frame_order(pFrame)) =3D=3D 1) { + if ((is_qos_data_frame(pFrame) && frame_order(pFrame)) =3D=3D 1) { netdev_dbg(ieee->dev, "HT CONTROL FILED EXIST!!\n"); return true; } diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index ca69bb0965ba..e2695beaf582 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -340,7 +340,7 @@ enum rt_op_mode { #define FC_QOS_BIT BIT(7) #define is_data_frame(pdu) (((pdu[0] & 0x0C) =3D=3D 0x08) ? true : false) #define is_legacy_data_frame(pdu) (is_data_frame(pdu) && (!(pdu[0]&FC_QOS_= BIT))) -#define IsQoSDataFrame(pframe) \ +#define is_qos_data_frame(pframe) \ ((*(u16 *)pframe&(IEEE80211_STYPE_QOS_DATA|RTLLIB_FTYPE_DATA)) =3D=3D \ (IEEE80211_STYPE_QOS_DATA|RTLLIB_FTYPE_DATA)) #define frame_order(pframe) (*(u16 *)pframe&IEEE80211_FCTL_ORDER) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index 3e8ee1335c24..4d4a4a830470 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -1319,7 +1319,7 @@ static int rtllib_rx_infra_adhoc(struct rtllib_device= *ieee, struct sk_buff *skb =20 /* Get TS for Rx Reorder */ hdr =3D (struct ieee80211_hdr *)skb->data; - if (ieee->current_network.qos_data.active && IsQoSDataFrame(skb->data) + if (ieee->current_network.qos_data.active && is_qos_data_frame(skb->data) && !is_multicast_ether_addr(hdr->addr1)) { TID =3D frame_qos_tid(skb->data); SeqNum =3D WLAN_GET_SEQ_SEQ(sc); diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192= e/rtllib_tx.c index 1aeb207a3fee..b1bde5c0050a 100644 --- a/drivers/staging/rtl8192e/rtllib_tx.c +++ b/drivers/staging/rtl8192e/rtllib_tx.c @@ -275,7 +275,7 @@ static void rtllib_tx_query_agg_cap(struct rtllib_devic= e *ieee, =20 if (!ht_info->current_ht_support || !ht_info->enable_ht) return; - if (!IsQoSDataFrame(skb->data)) + if (!is_qos_data_frame(skb->data)) return; if (is_multicast_ether_addr(hdr->addr1)) return; @@ -472,7 +472,7 @@ static u16 rtllib_query_seqnum(struct rtllib_device *ie= ee, struct sk_buff *skb, =20 if (is_multicast_ether_addr(dst)) return 0; - if (IsQoSDataFrame(skb->data)) { + if (is_qos_data_frame(skb->data)) { struct tx_ts_record *ts =3D NULL; =20 if (!rtllib_get_ts(ieee, (struct ts_common_info **)(&ts), dst, --=20 2.30.2 From nobody Tue Feb 10 23:53:31 2026 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B974278C8C for ; Tue, 21 May 2024 03:17:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261466; cv=none; b=QjG3hh1FkwcN8fMw1Hi4B979beMXtnqC1qfwlJaMr7FsvXBBTD6gNNIjsuzVHiC//6j0sP+zcMPJ301sCeTy6vRqZVDGG+Nwimr8Vc7GtBrpm2J3TUUrQGiyFpzZrFzAUGMgEwyZvlIEuQC6JY9X08g9SaksZGN4j88SHyVf8h8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261466; c=relaxed/simple; bh=E214j+oVI9amVqkKz9xdNTWnTsNw6nE9EpWfpQfQ0fs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=OdnH1xSAhNLwA9o5zeS96kMEk6GQ6BZSC2dJvkXABTAAvQwf9d3AAUsP5mDPC5cCrFkUPB2ZxJf0CEt4hCyxp6JJhsyJ4g7zkIBwbqXdPyqjvOzl2eEl432DHRCaiN7RQWU4lsVJFt3y6foyaxiMzPtqcX9/6cZme1wMWYOB+K8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=M8YRq0So; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="M8YRq0So" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1ed012c1afbso27114505ad.1 for ; Mon, 20 May 2024 20:17:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1716261464; x=1716866264; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ITc+3AXVWxBKyxU7U+mxRvRUw4cedaMFQ7sA0ad4TOc=; b=M8YRq0SovGfrhx0l5z98/Xa8iHFR5lbTmPAspEVVCErDiM5bVgfTm/Ezk7uPITFYqi 8uEgQmnFUj0772hWo8C8LTpxVbWlvis35qQDBcXVKbPV+gcrUi5idlftscyEmpbaL/3n vfd9n2VoVkNdlRGT5WouBLWG1TmUT7tbXNc/RDIs3vrPDJdh/5jdjUW3Ho6HbTTCXSRu 7kgErIfQScDDTDQbhFr6l1mKw5utzYnu1D/KOkDxoc6HEetdLOUcCId5qbR15+/r//Nq G0FkFkRjTlEjen7/uNo5lQrfJK82qrslCsRsPf8uZvhIwIhMGn2geaw0vtTv1/ei+Az/ UmJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716261464; x=1716866264; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ITc+3AXVWxBKyxU7U+mxRvRUw4cedaMFQ7sA0ad4TOc=; b=bH3ug0cWFpBa0iNCyd6SjV1eohyI44O6RC1R9cEZkfdqX67OVNE1ZzwqxXbUtU+4V3 slF9om5kTTSNNilZ98pQB736YQTzbgM8dJbv/TklMzN2OdM8xtfKA0Ad71Og96zZGK2v eO5O+5wgP2azrjNbD8PSMP8apJIkhH4anpQ/OpG3PuiOIpemoxcAP10RNW1jvLP8ZITo CPNtkaA76IqUmRTQ8BIuaKY/9T0tcj4kOft+I4OSo6ZbAgx/NFOTrOHtgR8s6PQyMy7+ f+FyrzcGQiI+yA/kspfBNV01MHbKJLoHs/huD2Zz7WlrMySKbniMBhYdQhftryZKe1mi Eirw== X-Forwarded-Encrypted: i=1; AJvYcCW3VPWlxer83HVes2jHhaku9pZqj9HYmj58iRVL78NbBYrLWdBRuRsV4BglkDAxBCGNVJvFmH0bdCS2fXGgtVw9SyOr1mN1FD+XryRT X-Gm-Message-State: AOJu0Yyojy6wC11875mfL7DhVFMNzTWj+GOuMFXuN2wQsnTdE9so790g GxN7Uz6JQyIukx+SnRqQWBwZDyxf99RPk9SYa2Ep2Gk4drBCyHo2dr4IcE7zz3A= X-Google-Smtp-Source: AGHT+IEw5VAAC3r728AHxOxol/YQXn/otGSty/ujAWGLz26xdnFg57Vk8vhuV29f9hFWduZtSB+EdA== X-Received: by 2002:a17:902:d509:b0:1f2:fbe5:7d62 with SMTP id d9443c01a7336-1f2fbe5822dmr68844905ad.33.1716261464079; Mon, 20 May 2024 20:17:44 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bf31a93sm214885415ad.134.2024.05.20.20.17.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 20:17:43 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 29/31] Staging: rtl8192e: Rename variable RfdCnt Date: Mon, 20 May 2024 20:17:16 -0700 Message-Id: <20240521031718.17852-30-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240521031718.17852-1-tdavies@darkphysics.net> References: <20240521031718.17852-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable RfdCnt to rfd_cnt to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No change. drivers/staging/rtl8192e/rtllib_rx.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index 4d4a4a830470..124fa5d54a23 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -491,13 +491,13 @@ void rtllib_flush_rx_ts_pending_pkts(struct rtllib_de= vice *ieee, struct rx_ts_record *ts) { struct rx_reorder_entry *pRxReorderEntry; - u8 RfdCnt =3D 0; + u8 rfd_cnt =3D 0; =20 del_timer_sync(&ts->rx_pkt_pending_timer); while (!list_empty(&ts->rx_pending_pkt_list)) { - if (RfdCnt >=3D REORDER_WIN_SIZE) { + if (rfd_cnt >=3D REORDER_WIN_SIZE) { netdev_info(ieee->dev, - "-------------->%s() error! RfdCnt >=3D REORDER_WIN_SIZE\n", + "-------------->%s() error! rfd_cnt >=3D REORDER_WIN_SIZE\n", __func__); break; } @@ -509,13 +509,13 @@ void rtllib_flush_rx_ts_pending_pkts(struct rtllib_de= vice *ieee, pRxReorderEntry->SeqNum); list_del_init(&pRxReorderEntry->list); =20 - ieee->rfd_array[RfdCnt] =3D pRxReorderEntry->prxb; + ieee->rfd_array[rfd_cnt] =3D pRxReorderEntry->prxb; =20 - RfdCnt =3D RfdCnt + 1; + rfd_cnt =3D rfd_cnt + 1; list_add_tail(&pRxReorderEntry->list, &ieee->RxReorder_Unused_List); } - rtllib_indicate_packets(ieee, ieee->rfd_array, RfdCnt); + rtllib_indicate_packets(ieee, ieee->rfd_array, rfd_cnt); =20 ts->rx_indicate_seq =3D 0xffff; } --=20 2.30.2 From nobody Tue Feb 10 23:53:31 2026 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6830E78276 for ; Tue, 21 May 2024 03:17:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261467; cv=none; b=Gm7scbLxgU3Ibt8Wh9/Wutl2FV3O8YOtVBTNrB31nBgIJrqQIqK8zDqENNmxnrA7HfOWYZkX9tKPJO6OXjm6ktWnY8G57ebM1rR/90eFhu1N9orukZd84K75iF9jxAFpBg0fOpWHnA7bBwxdE0WPPaI2qklRgrWXQdHH+krD3Sc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261467; c=relaxed/simple; bh=jnf7MKlRaQOkFyg85H4qHW1UXLeXYlD7mIZgc/DHAnw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=OhjrbXiob6p/iz9XOG6tL51FMkgsAjSk+9NsRG2/DuFLOF9qlOtuMysucce58NOv1rNp+OKPkqM+R9Yetnj0MORNkT0BSEf7qsabsH+BwrKhatYF/3bOTsw8NDqFyfZx19E8vbgelAHKwLun6IsQ4q5UAru/s8PnYQOuETDqZ0Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=MLnOiWxZ; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="MLnOiWxZ" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1ec92e355bfso107915915ad.3 for ; Mon, 20 May 2024 20:17:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1716261465; x=1716866265; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HHovnZHgvjy0PmQut0EmLQXHHNUr2jbMi7LfsvmK2ps=; b=MLnOiWxZM9b0IaYOdIVPLjzWNw5goVaF9guw6jAS96M23Iz47QvWHpmMFF805Nzu2O nkZdpQq9wzdu9PjE1kx/ctQ+4hyzmSccyFMjpEMaxERD+HKjbZApCWSqUHwSQshJq7NF 1yEzDtA7u1yr4rbiDZVuWlT7E4yFDZ6EnPDdO1VHPYmQ7qgxEwHCQPLEEpGvoERG036P UuRvoEwDWZv/+C6bR1qrreais0UtLVBbun1rwdwZrsHbKQsdgIEDD2eXOnVQzpZ8D63l Hoek448hMxpnth31urtqwNuPaEyRwcU7DMD3iwFNTRJIIFkaHNfnBbhQazC2sxA4232B r6sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716261465; x=1716866265; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HHovnZHgvjy0PmQut0EmLQXHHNUr2jbMi7LfsvmK2ps=; b=tph0HrO/epzXEo2HG5YCibPIM6CS3BJezJrzEd7frxtXdyKV+2AcWvIo73/xcN2iwl jXtl0xZa9trZkUgcWC2z6Bi4KWGYxdK6+LBIFRClQNTW2qUIHuL85nyYyBct2UKsQJZl yBxwyDYrcr0pAtym8Dwhq+aqBkwrvARSIIPLyYWA3NfLKCTx5WlU5COAWgRZdWFvMmgx 2ivriKRaHWEExfyqPOfuPDbN4KmxaEJcPJR1wUoty+Cmz+ldcNU6ef6d+ntlYz30R9Vf Jzv1XRRog2lysr8MjMgCJGSbg6lwgwrxZgOXOewkUZntWUc7g2qgV0O3zgo3sdVWDl3g FY9g== X-Forwarded-Encrypted: i=1; AJvYcCVNOMsD3aOshdTDk5qOtHuW6Yip06d/yTyNU6ragjrmpisgJo3tRk3us3NpfCwMHtDtlwZE3tr7luwqS3/DSGpxN7SmvFyHtva0AN8+ X-Gm-Message-State: AOJu0YzSuJGdGYGeuIxfTRhMgsZ297kvgHBJ7ZKmZ94sr3/hvSVWLJmE rT+riaKmmJ8qSC9PijQUIQbzxpgqrVPnOQQOWaEIRaGPyCfE3miyaE7TBiSJxwo= X-Google-Smtp-Source: AGHT+IF3ubzY7qKH1CfCRDojxg6HqGjBneJOGGVIGZ0wbgdyAYQpkqHlmaQqQFVPekMQDSBuQfG82w== X-Received: by 2002:a05:6a20:9782:b0:1af:ab0b:1c08 with SMTP id adf61e73a8af0-1afde1b6f80mr30327709637.46.1716261464802; Mon, 20 May 2024 20:17:44 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bf31a93sm214885415ad.134.2024.05.20.20.17.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 20:17:44 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 30/31] Staging: rtl8192e: Rename variable prxbIndicateArray Date: Mon, 20 May 2024 20:17:17 -0700 Message-Id: <20240521031718.17852-31-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240521031718.17852-1-tdavies@darkphysics.net> References: <20240521031718.17852-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable prxbIndicateArray to prxb_indicate_array to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No change. drivers/staging/rtl8192e/rtllib.h | 4 ++-- drivers/staging/rtl8192e/rtllib_rx.c | 10 +++++----- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index e2695beaf582..62af48c20229 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1409,7 +1409,7 @@ struct rtllib_device { union { struct rtllib_rxb *rfd_array[REORDER_WIN_SIZE]; struct rtllib_rxb *stats_IndicateArray[REORDER_WIN_SIZE]; - struct rtllib_rxb *prxbIndicateArray[REORDER_WIN_SIZE]; + struct rtllib_rxb *prxb_indicate_array[REORDER_WIN_SIZE]; struct { struct sw_chnl_cmd PreCommonCmd[MAX_PRECMD_CNT]; struct sw_chnl_cmd PostCommonCmd[MAX_POSTCMD_CNT]; @@ -1803,7 +1803,7 @@ int rtllib_parse_info_param(struct rtllib_device *iee= e, struct rtllib_rx_stats *stats); =20 void rtllib_indicate_packets(struct rtllib_device *ieee, - struct rtllib_rxb **prxbIndicateArray, u8 index); + struct rtllib_rxb **prxb_indicate_array, u8 index); #define RT_ASOC_RETRY_LIMIT 5 u8 mgnt_query_tx_rate_exclude_cck_rates(struct rtllib_device *ieee); =20 diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index 124fa5d54a23..0cbd130e946a 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -429,14 +429,14 @@ static bool add_reorder_entry(struct rx_ts_record *ts, } =20 void rtllib_indicate_packets(struct rtllib_device *ieee, - struct rtllib_rxb **prxbIndicateArray, u8 index) + struct rtllib_rxb **prxb_indicate_array, u8 index) { struct net_device_stats *stats =3D &ieee->stats; u8 i =3D 0, j =3D 0; u16 ethertype; =20 for (j =3D 0; j < index; j++) { - struct rtllib_rxb *prxb =3D prxbIndicateArray[j]; + struct rtllib_rxb *prxb =3D prxb_indicate_array[j]; =20 for (i =3D 0; i < prxb->nr_subframes; i++) { struct sk_buff *sub_skb =3D prxb->subframes[i]; @@ -594,7 +594,7 @@ static void rx_reorder_indicate_packet(struct rtllib_de= vice *ieee, netdev_dbg(ieee->dev, "Packets indication! IndicateSeq: %d, NewSeq: %d\n", ts->rx_indicate_seq, SeqNum); - ieee->prxbIndicateArray[0] =3D prxb; + ieee->prxb_indicate_array[0] =3D prxb; index =3D 1; } else { /* Current packet is going to be inserted into pending list.*/ @@ -675,7 +675,7 @@ static void rx_reorder_indicate_packet(struct rtllib_de= vice *ieee, ts->rx_indicate_seq =3D (ts->rx_indicate_seq + 1) % 4096; =20 - ieee->prxbIndicateArray[index] =3D pReorderEntry->prxb; + ieee->prxb_indicate_array[index] =3D pReorderEntry->prxb; netdev_dbg(ieee->dev, "%s(): Indicate SeqNum %d!\n", __func__, pReorderEntry->SeqNum); index++; @@ -706,7 +706,7 @@ static void rx_reorder_indicate_packet(struct rtllib_de= vice *ieee, flags); return; } - rtllib_indicate_packets(ieee, ieee->prxbIndicateArray, index); + rtllib_indicate_packets(ieee, ieee->prxb_indicate_array, index); bPktInBuf =3D false; } =20 --=20 2.30.2 From nobody Tue Feb 10 23:53:31 2026 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47AEE7C085 for ; Tue, 21 May 2024 03:17:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261467; cv=none; b=Law9euvQCwHmjYyNeTyzse+6OkXFbH2kQmbf/T4vuZvtcmNoUGkr5svgTFAo4Q/WORurgGRPn/qu23YHcbrAp6Fex36PoXG60EpO0fq3a/5SBi37EFF7UCrKJS1rKJ/kqKAqGMX6PyrXil61ybD3yt0m6kJDI05iTwTgqMAKp4Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716261467; c=relaxed/simple; bh=Trj0gkPStjUwWgwQ7VdoJPBVTbXISJFT9NGpxdHYZrM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=RXTFjzRAIOJh4vvdTVf3pMiZZAtA5eH7lrZrnZXTsQXfEcBVI3S+9JH98YW3yinLCmJ71hn+jZaMJMx9HzhDY9AR93SemmLcf/IgY40RZqI8IsV+62OKmvHIxPnqdW7/ZsbJdkgI2QbVCn3Q5URS5k8CZLs5NBvDxflCzKhYcxo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=DPd2D1gn; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="DPd2D1gn" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1f0937479f8so92000285ad.3 for ; Mon, 20 May 2024 20:17:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1716261465; x=1716866265; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mQtEWcQTCYMN0RrUCy15v6k/lfOYvsIzszQIWWjwSE8=; b=DPd2D1gnVVE36DLLno5xuVUOeLP0wL+hD3BQlZBGnNEkMxwY/Zr82HD60XVyu/BiF1 17wbAydgsEcQ00UESXtESS+pkiISbuaPN6ZhtplDQx8wbZOQey4nz1/pGa9yhjGw4DAy 12SkR5TudckPsEUg6GSIR9Luuf1HHeknw6fQnvBdhqgGH/l2HKWURkoHO05K6tIdFusR lAqDkLSdaHdJ0jvFO7w9R7AYahiQrU187pU2V1tmmJyCN5VhcfelZXmJhJ8yBCY0UYRT oTqC78OwVFMuMPim8rpxx3ETTC2oESBUqeVd7Ts1q951a7KMmwPx/NERMUEEJsfPQlGQ 0BOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716261465; x=1716866265; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mQtEWcQTCYMN0RrUCy15v6k/lfOYvsIzszQIWWjwSE8=; b=qeHfwn28PhhM+luY7VwLDJpDgGUIjg283+5VUzeWVSvVDNkT+6ZF/We+qT1UIw4E9l Kkxk2rTz11jZM5Ce9bTmAfHxIRNKoO1ZVGK3qkXXMPgDHZBqmbq6OBPsbunM9LoOrHcv Yocp3D/c2CLZ/3CPr70sfhuCgvIthwoSQKXyOooSK35m55QqEVCl3dDAdup5UJuTAGFK ER3QlM+8LaVH2WATtSDMPoSpbXWzSezO5ziYpeE+XdilkXQC9nH5Bd+FhDGYB03ORf1Y isVYUF2jYCLqL35FhRDrXcvnsn8YzrgJm73MOTOJFwBBp8Ry5ilwSjXhzC+l3ndYfOOi krYA== X-Forwarded-Encrypted: i=1; AJvYcCXjh8mgFjhULQ1t4v9bckZftNJBgJQZ9Za1qLM5d66arcF720fST48nvIHD1N0HPtuqzCwpDRgOykgCXcf1/zFqTVJ/6W6qGLqe35U+ X-Gm-Message-State: AOJu0Yw949rz274/Tgi6/P46V1T+r53Xx6h1brjwE33hX7kAAfYYce4C Q7N0gHWFmRYiFaDJinfRQ23kNpnDeTqlHYaS9chZpx9f/J1Z4lS5rDUfechvN8M= X-Google-Smtp-Source: AGHT+IHOuwo6ZIL4x8jeMcBOU5YI71QsKPDHL54tfoEZOOXfEd25pV2b8Cm0INEu2TrdltsLLVz4fQ== X-Received: by 2002:a17:902:db0a:b0:1eb:75de:2a5b with SMTP id d9443c01a7336-1ef4405977fmr395700305ad.62.1716261465523; Mon, 20 May 2024 20:17:45 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bf31a93sm214885415ad.134.2024.05.20.20.17.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 20:17:45 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 31/31] Staging: rtl8192e: Rename variable bPktInBuf Date: Mon, 20 May 2024 20:17:18 -0700 Message-Id: <20240521031718.17852-32-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240521031718.17852-1-tdavies@darkphysics.net> References: <20240521031718.17852-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable bPktInBuf to pkt_in_buf to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No change. drivers/staging/rtl8192e/rtl819x_TSProc.c | 8 ++++---- drivers/staging/rtl8192e/rtllib_rx.c | 10 +++++----- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rt= l8192e/rtl819x_TSProc.c index 9903fe3f3c77..7cdeca7ed8c2 100644 --- a/drivers/staging/rtl8192e/rtl819x_TSProc.c +++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c @@ -18,7 +18,7 @@ static void RxPktPendingTimeout(struct timer_list *t) =20 unsigned long flags =3D 0; u8 index =3D 0; - bool bPktInBuf =3D false; + bool pkt_in_buf =3D false; =20 spin_lock_irqsave(&(ieee->reorder_spinlock), flags); if (ts->rx_timeout_indicate_seq !=3D 0xffff) { @@ -50,7 +50,7 @@ static void RxPktPendingTimeout(struct timer_list *t) list_add_tail(&pReorderEntry->list, &ieee->RxReorder_Unused_List); } else { - bPktInBuf =3D true; + pkt_in_buf =3D true; break; } } @@ -68,10 +68,10 @@ static void RxPktPendingTimeout(struct timer_list *t) return; } rtllib_indicate_packets(ieee, ieee->stats_IndicateArray, index); - bPktInBuf =3D false; + pkt_in_buf =3D false; } =20 - if (bPktInBuf && (ts->rx_timeout_indicate_seq =3D=3D 0xffff)) { + if (pkt_in_buf && (ts->rx_timeout_indicate_seq =3D=3D 0xffff)) { ts->rx_timeout_indicate_seq =3D ts->rx_indicate_seq; mod_timer(&ts->rx_pkt_pending_timer, jiffies + msecs_to_jiffies(ieee->ht_info->rx_reorder_pending_time) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index 0cbd130e946a..86b8d342ac80 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -529,7 +529,7 @@ static void rx_reorder_indicate_packet(struct rtllib_de= vice *ieee, u8 win_size =3D ht_info->rx_reorder_win_size; u16 win_end =3D 0; u8 index =3D 0; - bool match_win_start =3D false, bPktInBuf =3D false; + bool match_win_start =3D false, pkt_in_buf =3D false; unsigned long flags; =20 netdev_dbg(ieee->dev, @@ -665,7 +665,7 @@ static void rx_reorder_indicate_packet(struct rtllib_de= vice *ieee, netdev_err(ieee->dev, "%s(): Buffer overflow!\n", __func__); - bPktInBuf =3D true; + pkt_in_buf =3D true; break; } =20 @@ -683,7 +683,7 @@ static void rx_reorder_indicate_packet(struct rtllib_de= vice *ieee, list_add_tail(&pReorderEntry->list, &ieee->RxReorder_Unused_List); } else { - bPktInBuf =3D true; + pkt_in_buf =3D true; break; } } @@ -707,10 +707,10 @@ static void rx_reorder_indicate_packet(struct rtllib_= device *ieee, return; } rtllib_indicate_packets(ieee, ieee->prxb_indicate_array, index); - bPktInBuf =3D false; + pkt_in_buf =3D false; } =20 - if (bPktInBuf && ts->rx_timeout_indicate_seq =3D=3D 0xffff) { + if (pkt_in_buf && ts->rx_timeout_indicate_seq =3D=3D 0xffff) { netdev_dbg(ieee->dev, "%s(): SET rx timeout timer\n", __func__); ts->rx_timeout_indicate_seq =3D ts->rx_indicate_seq; spin_unlock_irqrestore(&ieee->reorder_spinlock, flags); --=20 2.30.2