From nobody Wed Feb 11 04:22:34 2026 Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 155A715749C for ; Thu, 16 May 2024 17:44:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715881458; cv=none; b=YG9075PF+m0XP4360SFWigtKEB0n7/D5CYetnSAq0nEi8YzoN4QXqg+988Z9CcEg6OFxx18LgFRuSFiRk8NWuOPnNOHqDf++WCbax1biFIJuBSQSHAr4HdhgQupn+AYU8E8IMQX8NUk5F1l1WUCqxYsxK83PLoNHHR1dT5wtxTs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715881458; c=relaxed/simple; bh=Nt65keRmpZDv8bRmjvL3/GSbT4bx+qc+RUCALuerzkw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OaSLbR2FZlOyY+S8159GX/3e0p4TOcnbIQ5xQe9rmYDgei27slVKISSuqWP/obsqsdAYu7NmuRpMjtMWV08QnzaleEJN0MTzVBM3ESxq6HuHZPFsjC61DvwAfs3kCL2VxmnNJcx3GSmj6c17/q/A8U97Ngc2PxxfpfDiF/sQXsA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cekmB5B6; arc=none smtp.client-ip=209.85.166.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cekmB5B6" Received: by mail-io1-f52.google.com with SMTP id ca18e2360f4ac-7e1f984312cso63458239f.2 for ; Thu, 16 May 2024 10:44:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715881456; x=1716486256; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=I+DOksUhXvdVEsoG4IsyAg8S9S+luDW/WoR3/bPFU7A=; b=cekmB5B6IueRaGjXPXytbWp9tBawF8TNDhMYEfXA+U52wKbXS8xhKWGqxA2y87AaE1 LWR05HPhm1THQm063InyrzpTZ5dz+f6ecwx5R+JvZP22rSCXJf2DICYxyStMJwYS81qR viBgzL9Qi7ZQkx0p6IW2TK8TMw8oV4W8snmcO/2iPoQzOXmdxoofk94EzFZRosZTrjcN MHQVFTB2oMZONu5aw5guShoVuBQYazsO4t1waWrMog/EouViRbIE7dL4q0/eKzK/2b6R 1SlWleURqDKdPGA7tTm3e8n7j5futXLyz5fIYgOImrPJRk++KudrIMuYvHD+bwaRipey 9sww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715881456; x=1716486256; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I+DOksUhXvdVEsoG4IsyAg8S9S+luDW/WoR3/bPFU7A=; b=qr6n+t9GkNt4fhyYMejIBSiqyDlY3AeTenoO9e6KIPd2/GHoYKaDfQeSd8kpJ9Bpq1 4IwvRjkORhCEk/3UPE199mwARlF59viAxCpB9+qZHv5V0cETUYxpwIiabfZFkgWGFC+k 1PpvW+0JvWGdzuYUKEDP4FDWZAeyKxaqVYTyMExi9bmBm0Sfw9drNyTuzL3izsmTqpSK DPQvYesvdp6nxnC5+971hCkz46kn1BGvTIWxNsM6wEIMXBvy5dxSVmB5EE3gxWYt8/PO hAVV5fgBXUmDpAJ3apZMZ+RuRHG2V7qd9gdT9b0Qxj67jltj7Ydcv6fkdQKz9PxkjOX3 kWng== X-Forwarded-Encrypted: i=1; AJvYcCURtrsA9ioZ9OOPionp0pVGyA3Lf7kgKpck2AF2TBOqLH2KVavtHcNVLCWc96R3wsS5OpsDbvtMiE4TH/5IjnCnAElQ/f0bE0mOOPUf X-Gm-Message-State: AOJu0YzXyb0bEo6MPipQt+daGPqSTNPQK8U5xWw1eoRMdG0hYwbWLiFG OfFf600KC1UFDEKTcmhYFZLr5HN2IqmAQYdxqRD0fbgulJjIMogaVKQsY5d9 X-Google-Smtp-Source: AGHT+IHcBxJkN6uEQZ6STlgd+VfIFQxSOSwIQkkZfJjLLUFzr4pi0YI95jI1BP5k7Bw3eele8hAssg== X-Received: by 2002:a05:6602:18f:b0:7da:109d:1b84 with SMTP id ca18e2360f4ac-7e1b51c6243mr2064289339f.12.1715881456166; Thu, 16 May 2024 10:44:16 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id 8926c6da1cb9f-4893715057csm4273595173.80.2024.05.16.10.44.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 May 2024 10:44:15 -0700 (PDT) From: Jim Cromie To: jbaron@akamai.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Cc: ukaszb@chromium.org, linux@rasmusvillemoes.dk, joe@perches.com, mcgrof@kernel.org, daniel.vetter@ffwll.ch, tvrtko.ursulin@linux.intel.com, jani.nikula@intel.com, ville.syrjala@linux.intel.com, seanpaul@chromium.org, robdclark@gmail.com, groeck@google.com, yanivt@google.com, bleung@google.com, Jim Cromie Subject: [PATCH v8-RESEND 06/33] dyndbg: ddebug_apply_class_bitmap - add module arg, select on it Date: Thu, 16 May 2024 11:43:30 -0600 Message-ID: <20240516174357.26755-7-jim.cromie@gmail.com> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20240516174357.26755-1-jim.cromie@gmail.com> References: <20240516174357.26755-1-jim.cromie@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add param: query_module to ddebug_apply_class_bitmap(), and pass it thru to _ddebug_queries(), replacing NULL with query_module. This allows its caller to update just one module, or all (as currently). We'll use this later to propagate drm.debug to each USEr as they're modprobed. No functional change. Signed-off-by: Jim Cromie --- after `modprobe i915`, heres the module dependencies, though not all on drm.debug. bash-5.2# lsmod Module Size Used by i915 3133440 0 drm_buddy 20480 1 i915 ttm 90112 1 i915 i2c_algo_bit 16384 1 i915 video 61440 1 i915 wmi 32768 1 video drm_display_helper 200704 1 i915 drm_kms_helper 208896 2 drm_display_helper,i915 drm 606208 5 drm_kms_helper,drm_display_helper,drm_buddy= ,i915,ttm cec 57344 2 drm_display_helper,i915 --- lib/dynamic_debug.c | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 46e4cdd8e6be..a1fd2e9dbafb 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -605,7 +605,8 @@ static int ddebug_exec_queries(char *query, const char = *modname) =20 /* apply a new bitmap to the sys-knob's current bit-state */ static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp, - unsigned long *new_bits, unsigned long *old_bits) + unsigned long *new_bits, unsigned long *old_bits, + const char *query_modname) { #define QUERY_SIZE 128 char query[QUERY_SIZE]; @@ -613,7 +614,8 @@ static int ddebug_apply_class_bitmap(const struct ddebu= g_class_param *dcp, int matches =3D 0; int bi, ct; =20 - v2pr_info("apply: 0x%lx to: 0x%lx\n", *new_bits, *old_bits); + v2pr_info("apply bitmap: 0x%lx to: 0x%lx for %s\n", *new_bits, *old_bits, + query_modname ?: ""); =20 for (bi =3D 0; bi < map->length; bi++) { if (test_bit(bi, new_bits) =3D=3D test_bit(bi, old_bits)) @@ -622,12 +624,15 @@ static int ddebug_apply_class_bitmap(const struct dde= bug_class_param *dcp, snprintf(query, QUERY_SIZE, "class %s %c%s", map->class_names[bi], test_bit(bi, new_bits) ? '+' : '-', dcp->flags); =20 - ct =3D ddebug_exec_queries(query, NULL); + ct =3D ddebug_exec_queries(query, query_modname); matches +=3D ct; =20 v2pr_info("bit_%d: %d matches on class: %s -> 0x%lx\n", bi, ct, map->class_names[bi], *new_bits); } + v2pr_info("applied bitmap: 0x%lx to: 0x%lx for %s\n", *new_bits, *old_bit= s, + query_modname ?: ""); + return matches; } =20 @@ -682,7 +687,7 @@ static int param_set_dyndbg_classnames(const char *inst= r, const struct kernel_pa continue; } curr_bits ^=3D BIT(cls_id); - totct +=3D ddebug_apply_class_bitmap(dcp, &curr_bits, dcp->bits); + totct +=3D ddebug_apply_class_bitmap(dcp, &curr_bits, dcp->bits, NULL); *dcp->bits =3D curr_bits; v2pr_info("%s: changed bit %d:%s\n", KP_NAME(kp), cls_id, map->class_names[cls_id]); @@ -692,7 +697,7 @@ static int param_set_dyndbg_classnames(const char *inst= r, const struct kernel_pa old_bits =3D CLASSMAP_BITMASK(*dcp->lvl); curr_bits =3D CLASSMAP_BITMASK(cls_id + (wanted ? 1 : 0 )); =20 - totct +=3D ddebug_apply_class_bitmap(dcp, &curr_bits, &old_bits); + totct +=3D ddebug_apply_class_bitmap(dcp, &curr_bits, &old_bits, NULL); *dcp->lvl =3D (cls_id + (wanted ? 1 : 0)); v2pr_info("%s: changed bit-%d: \"%s\" %lx->%lx\n", KP_NAME(kp), cls_id, map->class_names[cls_id], old_bits, curr_bits); @@ -755,7 +760,7 @@ int param_set_dyndbg_classes(const char *instr, const s= truct kernel_param *kp) inrep &=3D CLASSMAP_BITMASK(map->length); } v2pr_info("bits:%lx > %s\n", inrep, KP_NAME(kp)); - totct +=3D ddebug_apply_class_bitmap(dcp, &inrep, dcp->bits); + totct +=3D ddebug_apply_class_bitmap(dcp, &inrep, dcp->bits, NULL); *dcp->bits =3D inrep; break; case DD_CLASS_TYPE_LEVEL_NUM: @@ -768,7 +773,7 @@ int param_set_dyndbg_classes(const char *instr, const s= truct kernel_param *kp) old_bits =3D CLASSMAP_BITMASK(*dcp->lvl); new_bits =3D CLASSMAP_BITMASK(inrep); v2pr_info("lvl:%ld bits:0x%lx > %s\n", inrep, new_bits, KP_NAME(kp)); - totct +=3D ddebug_apply_class_bitmap(dcp, &new_bits, &old_bits); + totct +=3D ddebug_apply_class_bitmap(dcp, &new_bits, &old_bits, NULL); *dcp->lvl =3D inrep; break; default: --=20 2.45.0