From nobody Sat Feb 14 05:36:52 2026 Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 059C674407 for ; Wed, 15 May 2024 13:39:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715780344; cv=none; b=Ll2GE05D5WWsIQ3xxAoGWFwsr5U1Y/mYAOb8VqiZPh9wp+lZfp78ESD8ajeUqfwKrZBw6mA035QbIv8lyVog40SBVFeV2ohshu6z7fzb+zstrf9jvnbdL4SazHY5kznvzYmPATbFPce/8JDQVEK0XRC2fDMUwvFVrdpVqufX9pY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715780344; c=relaxed/simple; bh=+q68qLffCQ8ohP1Ct5Wt6hlG+Spc5lOHshUFKXtvOYo=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=QIaNyvfBmwy+JNENWvVWdJf76hkE0DO/mZ1wCKUGyyVeda+u/bMlgmvWr5eR+3e6nKIodgpKFUtc02BKeryc/M0UhhrWWMjECAvllOYT2K+nIS9gsErb+hSmkau8ojqi51WhY7NWKpuoltW+Aw41ZC0i1NOy+xWCTeJQ3UNWb9g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--cmllamas.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=3YSJsm81; arc=none smtp.client-ip=209.85.210.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--cmllamas.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="3YSJsm81" Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-6f49fc7b5e6so7682084b3a.3 for ; Wed, 15 May 2024 06:39:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1715780341; x=1716385141; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=xPBzW+amWPhjwlTP5JQYyMHPSoVaeIQN8RijRrwrY5o=; b=3YSJsm81lk/qVXDvbiqWMoNcXjgMsVWuwbljSGZBzxqMw6SDftGTBJ5DOgw2BMzsYF B1BfLlqvaA0sgeu6TPpj2mjQYDxCr1BNnG+vPeXZggm3C61XQTjH+2D+tzB0GlvxG/8M 2c4pv7k7CwAfVMYvWBXTCj/4ZrzWhn0L4osEmkQCVkTLjAcpWzEd9caedXji15DfvDf9 yV1+vVmQHgvbF8mfhvn1HEXk71gdAthgokowTp0o07q0G1Ih03fzzwWqrlpBS0gpT9OA 7pKBOQge1QKIFDLlVplNuy4mR6l3Ynt0bCSLLcObueMECULWI//DzYri0bGFw1Tou4oK LDyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715780341; x=1716385141; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xPBzW+amWPhjwlTP5JQYyMHPSoVaeIQN8RijRrwrY5o=; b=d3Xj5VZXVE7951q2vYFz4uLx+GOOnGoYjUfgYd+OHupz1vsGbopuk+lrhTgqcqEFiB NM9/atX8eHGtfQ3nT+t+6i6izr1Le19u+Vy99NH2ilCZ8oTrTC5+9K1f9omMcel3pO0u Bw86mmiu6XbRt8shBThCUR24Le2Q5lWnP4fIWW5B69CG0YLMb4PprcxRFsV3n8YBzAgz 9x7QkJFhcn3yxV2VTjlNxmn+pXrKd4Sd0QCAVGB30FkjIOy9JC6SZkGIGmj2jZIMMl3H wwWIQ7ecEPhDmaKPP5QoqFzmhufkZOi/TRvllJ1wwVbVmprZCrfs2zGBaGqatyjd6B+V OGDw== X-Gm-Message-State: AOJu0YwbDVX/klpYGrUMc4oPSdL9+RQqHUMkmC8fgMdDpYZFyL0D8veN 7TmvsyCrmHKQ4YmYMRV4ReaZb7cbCDHDXx9AK7hWThQe8UU8ow6I8aFhfbfmrD05kS0R77VoJ8A 82nA+Mf6PkQ== X-Google-Smtp-Source: AGHT+IHjhWzgWKKbS0lhm52/3G5+5pjlBVgo1aud6No+Ix3PvQKS9gPnNT9c5Qwzn6hh0RU/XCeI9fRNWs1Rrw== X-Received: from xllamas.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5070]) (user=cmllamas job=sendgmr) by 2002:a05:6a00:98b:b0:6f3:ea4b:d1bf with SMTP id d2e1a72fcca58-6f4e01b8428mr956707b3a.0.1715780341237; Wed, 15 May 2024 06:39:01 -0700 (PDT) Date: Wed, 15 May 2024 13:37:10 +0000 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: X-Mailer: git-send-email 2.45.0.rc1.225.g2a3ae87e7f-goog Message-ID: <20240515133844.3502360-1-cmllamas@google.com> Subject: [PATCH v2] locking/atomic: scripts: fix ${atomic}_sub_and_test() kerneldoc From: Carlos Llamas To: Will Deacon , Peter Zijlstra , Boqun Feng , Mark Rutland , Kees Cook , Ingo Molnar , "Paul E. McKenney" , Carlos Llamas , Uros Bizjak , Nhat Pham Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, stable@vger.kernel.org, Arnd Bergmann Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" For ${atomic}_sub_and_test() the @i parameter is the value to subtract, not add. Fix the typo in the kerneldoc template and generate the headers with this update. Fixes: ad8110706f38 ("locking/atomic: scripts: generate kerneldoc comments") Cc: Mark Rutland Cc: stable@vger.kernel.org Suggested-by: Mark Rutland Reviewed-by: Kees Cook Signed-off-by: Carlos Llamas Acked-by: Mark Rutland --- Notes: v2: fix kerneldoc template instead, as pointed out by Mark include/linux/atomic/atomic-arch-fallback.h | 6 +++--- include/linux/atomic/atomic-instrumented.h | 8 ++++---- include/linux/atomic/atomic-long.h | 4 ++-- scripts/atomic/kerneldoc/sub_and_test | 2 +- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/include/linux/atomic/atomic-arch-fallback.h b/include/linux/at= omic/atomic-arch-fallback.h index 956bcba5dbf2..2f9d36b72bd8 100644 --- a/include/linux/atomic/atomic-arch-fallback.h +++ b/include/linux/atomic/atomic-arch-fallback.h @@ -2242,7 +2242,7 @@ raw_atomic_try_cmpxchg_relaxed(atomic_t *v, int *old,= int new) =20 /** * raw_atomic_sub_and_test() - atomic subtract and test if zero with full = ordering - * @i: int value to add + * @i: int value to subtract * @v: pointer to atomic_t * * Atomically updates @v to (@v - @i) with full ordering. @@ -4368,7 +4368,7 @@ raw_atomic64_try_cmpxchg_relaxed(atomic64_t *v, s64 *= old, s64 new) =20 /** * raw_atomic64_sub_and_test() - atomic subtract and test if zero with ful= l ordering - * @i: s64 value to add + * @i: s64 value to subtract * @v: pointer to atomic64_t * * Atomically updates @v to (@v - @i) with full ordering. @@ -4690,4 +4690,4 @@ raw_atomic64_dec_if_positive(atomic64_t *v) } =20 #endif /* _LINUX_ATOMIC_FALLBACK_H */ -// 14850c0b0db20c62fdc78ccd1d42b98b88d76331 +// b565db590afeeff0d7c9485ccbca5bb6e155749f diff --git a/include/linux/atomic/atomic-instrumented.h b/include/linux/ato= mic/atomic-instrumented.h index debd487fe971..9409a6ddf3e0 100644 --- a/include/linux/atomic/atomic-instrumented.h +++ b/include/linux/atomic/atomic-instrumented.h @@ -1349,7 +1349,7 @@ atomic_try_cmpxchg_relaxed(atomic_t *v, int *old, int= new) =20 /** * atomic_sub_and_test() - atomic subtract and test if zero with full orde= ring - * @i: int value to add + * @i: int value to subtract * @v: pointer to atomic_t * * Atomically updates @v to (@v - @i) with full ordering. @@ -2927,7 +2927,7 @@ atomic64_try_cmpxchg_relaxed(atomic64_t *v, s64 *old,= s64 new) =20 /** * atomic64_sub_and_test() - atomic subtract and test if zero with full or= dering - * @i: s64 value to add + * @i: s64 value to subtract * @v: pointer to atomic64_t * * Atomically updates @v to (@v - @i) with full ordering. @@ -4505,7 +4505,7 @@ atomic_long_try_cmpxchg_relaxed(atomic_long_t *v, lon= g *old, long new) =20 /** * atomic_long_sub_and_test() - atomic subtract and test if zero with full= ordering - * @i: long value to add + * @i: long value to subtract * @v: pointer to atomic_long_t * * Atomically updates @v to (@v - @i) with full ordering. @@ -5050,4 +5050,4 @@ atomic_long_dec_if_positive(atomic_long_t *v) =20 =20 #endif /* _LINUX_ATOMIC_INSTRUMENTED_H */ -// ce5b65e0f1f8a276268b667194581d24bed219d4 +// 8829b337928e9508259079d32581775ececd415b diff --git a/include/linux/atomic/atomic-long.h b/include/linux/atomic/atom= ic-long.h index 3ef844b3ab8a..f86b29d90877 100644 --- a/include/linux/atomic/atomic-long.h +++ b/include/linux/atomic/atomic-long.h @@ -1535,7 +1535,7 @@ raw_atomic_long_try_cmpxchg_relaxed(atomic_long_t *v,= long *old, long new) =20 /** * raw_atomic_long_sub_and_test() - atomic subtract and test if zero with = full ordering - * @i: long value to add + * @i: long value to subtract * @v: pointer to atomic_long_t * * Atomically updates @v to (@v - @i) with full ordering. @@ -1809,4 +1809,4 @@ raw_atomic_long_dec_if_positive(atomic_long_t *v) } =20 #endif /* _LINUX_ATOMIC_LONG_H */ -// 1c4a26fc77f345342953770ebe3c4d08e7ce2f9a +// eadf183c3600b8b92b91839dd3be6bcc560c752d diff --git a/scripts/atomic/kerneldoc/sub_and_test b/scripts/atomic/kerneld= oc/sub_and_test index d3760f7749d4..96615e50836b 100644 --- a/scripts/atomic/kerneldoc/sub_and_test +++ b/scripts/atomic/kerneldoc/sub_and_test @@ -1,7 +1,7 @@ cat <