From nobody Tue Feb 10 22:18:01 2026 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31CBC6A005 for ; Wed, 15 May 2024 07:17:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715757457; cv=none; b=ClhW/w2b/yTY9jRaKqpIC62GVRFPI3yy9T85kcSnVTjbi9Zd0NVpxESsu//jNSn75OcncZOpHABloJPadU1vFJuwTdwokNYN0CzzBHo9TyNu4EvwE7VMbuexnxg7Qs4+wAfGua2kmbqrgtLR88/lxSpDcbWoMRhoK1yZRZPxmXQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715757457; c=relaxed/simple; bh=EdcVeRKP/KQ7J2vOPlmfMisYBBpem1rc+IBT0Rrt74I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Trhyx3oBPSJtLft/Hq4s2FDv2IR93XbcuvebTj/PgSIUzJ+rfVGMWL5zGpAQuWnM0svVUTecv8VpFVcaUkDrWp7PxS0rzXNSda5x2UMmVyAYH/E7QRlrEnqooK2k2Hz5+dipjoVClBxf4zQfhzCfD/auvn72a8Cm6hXsgJxE/KM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=LYOGCI/y; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="LYOGCI/y" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1eeb1a4c10aso39642615ad.3 for ; Wed, 15 May 2024 00:17:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1715757455; x=1716362255; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KqMJS5agkLEOzJWW1AUSO+pWta3iupztSYk/iAWBNyc=; b=LYOGCI/yIuAyRPoBAN9Lhn3v1z52/Tj8mf633vwkwvzNGMv2Jcg7rYe/JyUJA9bgK6 bbCJW4kiYIc5NzxoFGBozGvRP+BHGZa2z6IIXQdTpYCeU9KpuJ2e/7cLFtZOpGcoil5i TY7HgCvmkTtBcpEDI79AQ0Zeb+AOU3uRV0HAE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715757455; x=1716362255; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KqMJS5agkLEOzJWW1AUSO+pWta3iupztSYk/iAWBNyc=; b=hXCIF17YpLAsvC1Y4EHcU7CaXdgD5aeUqgHMvVOVzM053QOa/F0MRi34SWR2PvSzXS 5A75WGExjeioSV6jzotcdjB+vFl8uTPEJHhZONUDdfg5hsxpcLj2MU62TFxUHwrTmALo 7j44VvgtluhW3BvDO0hudl4dFgAQLaVqKcRHPHKMQQixfdtsss1g3Uikv7Jm6GM7sngt A9Dwh8G+HoJKzRaFPoetlxJblCtrwOYZ1FUMz9WkH+0iqn0aqilIZOhvvBX/vCWTogi+ E+gUOD10qvZZmlOFme3xCE98nynR2nsOsGAhSf6wx/i8c0Vpur6HK4v5VxIvwd4a1xDz y2Fw== X-Gm-Message-State: AOJu0YyOahieK93bs4XrjouaT+D5Ubj0yxTmK1QJaJA+zf5IEV3Jg6VK KGC47QgNHHtQXkRQKgMxhAegzUw5ukbqPTcT++GuVFm1TYlNOyVsWdUKvjzl5g== X-Google-Smtp-Source: AGHT+IEqDaF2jnae7dsuVOOBN2n95AgJH3VLf55Gs8FaRkx1MfHX06Cxat1HEPBqfloibFYY9DeFyg== X-Received: by 2002:a17:903:283:b0:1e3:e081:e7f5 with SMTP id d9443c01a7336-1ef4404bf29mr165136805ad.66.1715757455517; Wed, 15 May 2024 00:17:35 -0700 (PDT) Received: from tigerii.tok.corp.google.com ([2401:fa00:8f:203:111d:a618:3172:cd5b]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0c136d53sm110941605ad.254.2024.05.15.00.17.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 May 2024 00:17:35 -0700 (PDT) From: Sergey Senozhatsky To: Andrew Morton , Minchan Kim Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Sergey Senozhatsky Subject: [PATCHv4 16/21] zram: add config init/release backend callbacks Date: Wed, 15 May 2024 16:12:53 +0900 Message-ID: <20240515071645.1788128-17-senozhatsky@chromium.org> X-Mailer: git-send-email 2.45.0.rc1.225.g2a3ae87e7f-goog In-Reply-To: <20240515071645.1788128-1-senozhatsky@chromium.org> References: <20240515071645.1788128-1-senozhatsky@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Some backends can create a backend-specific private data for comp config, e.g. parse a dictionary and use it to init all of the ctx-s later on. Introduce two zcomp_config callbacks to create and destroy per-config backend private data. This is also the place where config can be validated. Signed-off-by: Sergey Senozhatsky --- drivers/block/zram/backend_842.c | 11 +++++++++++ drivers/block/zram/backend_deflate.c | 20 +++++++++++++++----- drivers/block/zram/backend_lz4.c | 20 +++++++++++++++----- drivers/block/zram/backend_lz4hc.c | 20 +++++++++++++++----- drivers/block/zram/backend_lzo.c | 11 +++++++++++ drivers/block/zram/backend_lzorle.c | 11 +++++++++++ drivers/block/zram/backend_zstd.c | 20 +++++++++++++++----- drivers/block/zram/zcomp.c | 6 ++++++ drivers/block/zram/zcomp.h | 4 ++++ drivers/block/zram/zram_drv.c | 3 +++ 10 files changed, 106 insertions(+), 20 deletions(-) diff --git a/drivers/block/zram/backend_842.c b/drivers/block/zram/backend_= 842.c index 12e716deb763..1522aa88ac35 100644 --- a/drivers/block/zram/backend_842.c +++ b/drivers/block/zram/backend_842.c @@ -11,6 +11,15 @@ struct sw842_ctx { void *mem; }; =20 +static int init_config_842(struct zcomp_config *config) +{ + return 0; +} + +static void release_config_842(struct zcomp_config *config) +{ +} + static void destroy_842(void *ctx) { struct sw842_ctx *zctx =3D ctx; @@ -64,5 +73,7 @@ struct zcomp_backend backend_842 =3D { .decompress =3D decompress_842, .create_ctx =3D create_842, .destroy_ctx =3D destroy_842, + .init_config =3D init_config_842, + .release_config =3D release_config_842, .name =3D "842", }; diff --git a/drivers/block/zram/backend_deflate.c b/drivers/block/zram/back= end_deflate.c index 83c660adc722..2e166b507f5a 100644 --- a/drivers/block/zram/backend_deflate.c +++ b/drivers/block/zram/backend_deflate.c @@ -17,6 +17,18 @@ struct deflate_ctx { s32 level; }; =20 +static int deflate_init_config(struct zcomp_config *config) +{ + if (config->level =3D=3D ZCOMP_CONFIG_NO_LEVEL) + config->level =3D Z_DEFAULT_COMPRESSION; + + return 0; +} + +static void deflate_release_config(struct zcomp_config *config) +{ +} + static void deflate_destroy(void *ctx) { struct deflate_ctx *zctx =3D ctx; @@ -42,11 +54,7 @@ static void *deflate_create(struct zcomp_config *config) if (!ctx) return NULL; =20 - if (config->level !=3D ZCOMP_CONFIG_NO_LEVEL) - ctx->level =3D config->level; - else - ctx->level =3D Z_DEFAULT_COMPRESSION; - + ctx->level =3D config->level; sz =3D zlib_deflate_workspacesize(-DEFLATE_DEF_WINBITS, MAX_MEM_LEVEL); ctx->cctx.workspace =3D vzalloc(sz); if (!ctx->cctx.workspace) @@ -129,5 +137,7 @@ struct zcomp_backend backend_deflate =3D { .decompress =3D deflate_decompress, .create_ctx =3D deflate_create, .destroy_ctx =3D deflate_destroy, + .init_config =3D deflate_init_config, + .release_config =3D deflate_release_config, .name =3D "deflate", }; diff --git a/drivers/block/zram/backend_lz4.c b/drivers/block/zram/backend_= lz4.c index df0753fd8180..cf39bfc30f5b 100644 --- a/drivers/block/zram/backend_lz4.c +++ b/drivers/block/zram/backend_lz4.c @@ -10,6 +10,18 @@ struct lz4_ctx { s32 level; }; =20 +static int lz4_init_config(struct zcomp_config *config) +{ + if (config->level =3D=3D ZCOMP_CONFIG_NO_LEVEL) + config->level =3D LZ4_ACCELERATION_DEFAULT; + + return 0; +} + +static void lz4_release_config(struct zcomp_config *config) +{ +} + static void lz4_destroy(void *ctx) { struct lz4_ctx *zctx =3D ctx; @@ -26,11 +38,7 @@ static void *lz4_create(struct zcomp_config *config) if (!ctx) return NULL; =20 - if (config->level !=3D ZCOMP_CONFIG_NO_LEVEL) - ctx->level =3D config->level; - else - ctx->level =3D LZ4_ACCELERATION_DEFAULT; - + ctx->level =3D config->level; ctx->mem =3D vmalloc(LZ4_MEM_COMPRESS); if (!ctx->mem) goto error; @@ -72,5 +80,7 @@ struct zcomp_backend backend_lz4 =3D { .decompress =3D lz4_decompress, .create_ctx =3D lz4_create, .destroy_ctx =3D lz4_destroy, + .init_config =3D lz4_init_config, + .release_config =3D lz4_release_config, .name =3D "lz4", }; diff --git a/drivers/block/zram/backend_lz4hc.c b/drivers/block/zram/backen= d_lz4hc.c index 2f03ca5809c7..428b393371d7 100644 --- a/drivers/block/zram/backend_lz4hc.c +++ b/drivers/block/zram/backend_lz4hc.c @@ -10,6 +10,18 @@ struct lz4hc_ctx { s32 level; }; =20 +static int lz4hc_init_config(struct zcomp_config *config) +{ + if (config->level =3D=3D ZCOMP_CONFIG_NO_LEVEL) + config->level =3D LZ4HC_DEFAULT_CLEVEL; + + return 0; +} + +static void lz4hc_release_config(struct zcomp_config *config) +{ +} + static void lz4hc_destroy(void *ctx) { struct lz4hc_ctx *zctx =3D ctx; @@ -26,11 +38,7 @@ static void *lz4hc_create(struct zcomp_config *config) if (!ctx) return NULL; =20 - if (config->level !=3D ZCOMP_CONFIG_NO_LEVEL) - ctx->level =3D config->level; - else - ctx->level =3D LZ4HC_DEFAULT_CLEVEL; - + ctx->level =3D config->level; ctx->mem =3D vmalloc(LZ4HC_MEM_COMPRESS); if (!ctx->mem) goto error; @@ -72,5 +80,7 @@ struct zcomp_backend backend_lz4hc =3D { .decompress =3D lz4hc_decompress, .create_ctx =3D lz4hc_create, .destroy_ctx =3D lz4hc_destroy, + .init_config =3D lz4hc_init_config, + .release_config =3D lz4hc_release_config, .name =3D "lz4hc", }; diff --git a/drivers/block/zram/backend_lzo.c b/drivers/block/zram/backend_= lzo.c index 79ecfae9c4c5..75e0e3d297aa 100644 --- a/drivers/block/zram/backend_lzo.c +++ b/drivers/block/zram/backend_lzo.c @@ -6,6 +6,15 @@ =20 #include "backend_lzo.h" =20 +static int lzo_init_config(struct zcomp_config *config) +{ + return 0; +} + +static void lzo_release_config(struct zcomp_config *config) +{ +} + static void *lzo_create(struct zcomp_config *config) { return kzalloc(LZO1X_MEM_COMPRESS, GFP_KERNEL); @@ -40,5 +49,7 @@ struct zcomp_backend backend_lzo =3D { .decompress =3D lzo_decompress, .create_ctx =3D lzo_create, .destroy_ctx =3D lzo_destroy, + .init_config =3D lzo_init_config, + .release_config =3D lzo_release_config, .name =3D "lzo", }; diff --git a/drivers/block/zram/backend_lzorle.c b/drivers/block/zram/backe= nd_lzorle.c index b0937103b5fb..d1dc2e35061b 100644 --- a/drivers/block/zram/backend_lzorle.c +++ b/drivers/block/zram/backend_lzorle.c @@ -6,6 +6,15 @@ =20 #include "backend_lzorle.h" =20 +static int lzorle_init_config(struct zcomp_config *config) +{ + return 0; +} + +static void lzorle_release_config(struct zcomp_config *config) +{ +} + static void *lzorle_create(struct zcomp_config *config) { return kzalloc(LZO1X_MEM_COMPRESS, GFP_KERNEL); @@ -40,5 +49,7 @@ struct zcomp_backend backend_lzorle =3D { .decompress =3D lzorle_decompress, .create_ctx =3D lzorle_create, .destroy_ctx =3D lzorle_destroy, + .init_config =3D lzorle_init_config, + .release_config =3D lzorle_release_config, .name =3D "lzo-rle", }; diff --git a/drivers/block/zram/backend_zstd.c b/drivers/block/zram/backend= _zstd.c index 4be149370e0b..9d2cc27d4c9d 100644 --- a/drivers/block/zram/backend_zstd.c +++ b/drivers/block/zram/backend_zstd.c @@ -36,6 +36,18 @@ static void zstd_ctx_free(void *opaque, void *address) kvfree(address); } =20 +static int zstd_init_config(struct zcomp_config *config) +{ + if (config->level =3D=3D ZCOMP_CONFIG_NO_LEVEL) + config->level =3D zstd_default_clevel(); + + return 0; +} + +static void zstd_release_config(struct zcomp_config *config) +{ +} + static void zstd_destroy(void *ctx) { struct zstd_ctx *zctx =3D ctx; @@ -63,11 +75,7 @@ static void *zstd_create(struct zcomp_config *config) if (!ctx) return NULL; =20 - if (config->level !=3D ZCOMP_CONFIG_NO_LEVEL) - ctx->level =3D config->level; - else - ctx->level =3D zstd_default_clevel(); - + ctx->level =3D config->level; ctx->ctx_mem.customAlloc =3D zstd_ctx_alloc; ctx->ctx_mem.customFree =3D zstd_ctx_free; =20 @@ -173,5 +181,7 @@ struct zcomp_backend backend_zstd =3D { .decompress =3D zstd_decompress, .create_ctx =3D zstd_create, .destroy_ctx =3D zstd_destroy, + .init_config =3D zstd_init_config, + .release_config =3D zstd_release_config, .name =3D "zstd", }; diff --git a/drivers/block/zram/zcomp.c b/drivers/block/zram/zcomp.c index 3f990a715487..a7013a4b6575 100644 --- a/drivers/block/zram/zcomp.c +++ b/drivers/block/zram/zcomp.c @@ -187,18 +187,24 @@ static int zcomp_init(struct zcomp *comp) if (!comp->stream) return -ENOMEM; =20 + ret =3D comp->backend->init_config(comp->config); + if (ret) + goto cleanup; + ret =3D cpuhp_state_add_instance(CPUHP_ZCOMP_PREPARE, &comp->node); if (ret < 0) goto cleanup; return 0; =20 cleanup: + comp->backend->release_config(comp->config); free_percpu(comp->stream); return ret; } =20 void zcomp_destroy(struct zcomp *comp) { + comp->backend->release_config(comp->config); cpuhp_state_remove_instance(CPUHP_ZCOMP_PREPARE, &comp->node); free_percpu(comp->stream); kfree(comp); diff --git a/drivers/block/zram/zcomp.h b/drivers/block/zram/zcomp.h index 345c78bc76db..aa604e5db7ad 100644 --- a/drivers/block/zram/zcomp.h +++ b/drivers/block/zram/zcomp.h @@ -22,6 +22,7 @@ struct zcomp_config { s32 level; size_t dict_sz; void *dict; + void *private; }; =20 struct zcomp_backend { @@ -34,6 +35,9 @@ struct zcomp_backend { void *(*create_ctx)(struct zcomp_config *config); void (*destroy_ctx)(void *ctx); =20 + int (*init_config)(struct zcomp_config *config); + void (*release_config)(struct zcomp_config *config); + const char *name; }; =20 diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index 216686a5f3f0..ce63c3f12f58 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -1003,6 +1003,9 @@ static void __reset_comp_config(struct zram *zram, u3= 2 prio) { struct zcomp_config *config =3D &zram->configs[prio]; =20 + /* config->private should be freed by the backend */ + WARN_ON_ONCE(config->private); + vfree(config->dict); config->level =3D ZCOMP_CONFIG_NO_LEVEL; config->dict_sz =3D 0; --=20 2.45.0.rc1.225.g2a3ae87e7f-goog