From nobody Thu Sep 19 19:38:14 2024 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2053.outbound.protection.outlook.com [40.107.249.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 200DF37152; Sat, 4 May 2024 13:12:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.249.53 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714828362; cv=fail; b=ue1H/68hQN7nZMcBhOYDv8soRpYjUQODBA0M8XXO010cmMJH7t3Pqt0g4b6OsXZXcTZ5ZS5JgxrJjyUakkJ3rolXUNA266WU3YT8Ilkk6JrtB23FKO5tQofnXkiXBjcNtIRkbXQLDHvT6/o+ttsSiNl9F+JenlM9ehX62XmJfK4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714828362; c=relaxed/simple; bh=Ou336TSEbTPCZ/WIqf3NpyjX9m5zSkYnk3ABqYz5TbQ=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=Gq+EE5qRY9MfEawTXmHlDXYoWFvtPaeheyXgGzf82ctNzPYIgpZizoY0LfVj11r6IHggwjhjKgAmGswgyrnG+KLH8G3txDj9Q6y6EFVukeDbvRBxRaXR3vn1pCPyDSbuVtSc0gJrKFRB3LEhbdNbT2Vahh4dcSv8HVVWURElFEw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=RfoqmVxx; arc=fail smtp.client-ip=40.107.249.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="RfoqmVxx" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UY7zlqxIQP4a0lCG19cd/h/eNk91MNW0MPe2ZEXbWeyKbOaQb3KGvf+59/GdrNKFsxHVxzxCb8V/Uf8FFYwBhH72xdJt3sChpofEmxkvAU0N9nkKXFTAiYKdKRFY/lDnzSv8apboekGYxPCa+idf62VEcif6Q6Sv40hsseNFLIsv6rz1I9ThFq/VLbo3jRCPyvocKVoVML/vKG8qI16hjeMHZi37KTC5SnTUsm8CUKCaVK21GYukGewBH3fWeKOxwrYaupy8yeZfm8Y4UQgxqB/Io5T2DLEk7APtUhnhlBi4ZeMMIkcTGwiBBZmVA7OLS/bhiHOELARH0HLvUgMqTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xnIztDwVNRck+xwGiauHd7SjHMFdl2QwKvaMCCPUiQU=; b=Cu6szOifWb8hjTpJcCl9o60zOxpU4DqihhS1IgLtrb8MeKVL61qmqkcltBXvJkxymIqirKaLM2HrK/740AOdGsNFKcxym0ykdWiuWjmz1HkRP1TeXAc8qdMsU+HYz2b7aKeNv1enyUAi2O5qXAir+uqujEdjcCqtC3eo7W4+PhvptLogY5BPAo3FuHHW/HXhSLlx9g6ZPcD9rYCqnS0W+g/7I3iTmAGj3648emQmGGz6xJ509iWd8qNkVCE7pQIskG35c1YYkLcEu5tgkz5BqNQzGbCU2QjKMkzDbM7yam4yc+fAvykWNg67LsrpXIbJr7EDf6+K0Lf+Tr299b2ieA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xnIztDwVNRck+xwGiauHd7SjHMFdl2QwKvaMCCPUiQU=; b=RfoqmVxxKBchWsVMFsNGvdIgaX2urC6JZngbr5PBYllS2QiW+z2o7qS27p7FAN5YMpeaCiCi3gULtNf/zGv2vLc0YleCQvEoYO/xVFSZ3yKQb10r5mTJTEcprkBnZNntcov4lTcYOcRk6MmNLjbsHz86gh7c2WQZYn+bTsX1Qlg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by PAXPR04MB8174.eurprd04.prod.outlook.com (2603:10a6:102:1c4::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.39; Sat, 4 May 2024 13:12:36 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7544.036; Sat, 4 May 2024 13:12:36 +0000 From: "Peng Fan (OSS)" Date: Sat, 04 May 2024 21:19:59 +0800 Subject: [PATCH v2 01/20] pinctrl: ti: iodelay: Use scope based of_node_put() cleanups Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240504-pinctrl-cleanup-v2-1-26c5f2dc1181@nxp.com> References: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> In-Reply-To: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> To: Linus Walleij , Thierry Reding , Jonathan Hunter , Dvorkin Dmitry , Wells Lu , Maxime Coquelin , Alexandre Torgue , Emil Renner Berthing , Jianlong Huang , Hal Feng , Orson Zhai , Baolin Wang , Chunyan Zhang , Viresh Kumar , Shiraz Hashim , soc@kernel.org, Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , Geert Uytterhoeven , Patrice Chotard , Heiko Stuebner , Damien Le Moal , Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , Chester Lin , Matthias Brugger , Ghennadi Procopciuc , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Sascha Hauer , Andrew Jeffery , Joel Stanley , Dan Carpenter , Tony Lindgren , Stephen Warren Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-mediatek@lists.infradead.org, imx@lists.linux.dev, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, Peng Fan X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1714828815; l=2712; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=+OvVNjQ9hEJHGX2TTZXWfIPqFH/ASaiGPFRoyyD86ck=; b=wBwz78+ulysi78J8qrvqUz4DHAoNLDZSQ8dx1MUycl0AKWDH3Hh6flSWohonDhSJYkPD4nSLU q4z3mqBYnq9AJZKYQSF9Qw0Mfn/LYZD8v5fhhR/sN5iLqcismO0zG9m X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR06CA0230.apcprd06.prod.outlook.com (2603:1096:4:ac::14) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|PAXPR04MB8174:EE_ X-MS-Office365-Filtering-Correlation-Id: 3a386a51-db17-41ce-fd86-08dc6c3bddc0 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|376005|7416005|52116005|1800799015|366007|921011|38350700005; X-Microsoft-Antispam-Message-Info: =?utf-8?B?eWxyR2p1SUpQcWxrc3l1bXVsWVRrdjc0bHpzQjJDMzNTNFZSRGRLTDljcjlL?= =?utf-8?B?QnJ0bVVzWUlRdmtad3ZzWUlCN3EwWk90Ni9VUkp2QXdNN3E3T0NDY1dESUEv?= =?utf-8?B?TFdsTFlRaVVFTHBZS0xQa1h1MFpBMFZHK1VxWGNYRURLanR4YkNseUpxZjM0?= =?utf-8?B?cXhyczFDdW05YjM0QmI3cTR6NGsvQ3RQcmZpMi9nZXVNbTRBZGQwZmpHQ0lZ?= =?utf-8?B?U0lwS25GNXQ4RzZIQ3BPWFBvMk1iZk56ejdDb1pHYS9lUEZhYVFFdjBlWUFO?= =?utf-8?B?a1FPTk1UT29mWDdFaVdHU3k0REZDdmpxTS9jRkNGdkNUa1puMFlNdkVtUk1Q?= =?utf-8?B?SDVwSE5pTTBqRGNmMk5xQXhVNFd1UkFrUE1hUTEzR3NZZEcyZFlXa2lMSk82?= =?utf-8?B?UW5UWmNuTy9sNHp3MDBVYzVJdjF5ZDBXN0NFMDQyOHBUWkxFR2RaQUZrYVJy?= =?utf-8?B?OUJnSjM2SnpCSkgvTHc4dTFqM3ZRazhHbzNSeG50UnlWeFJKUVFNRTJ6eWlz?= =?utf-8?B?bXBHckFKSGdWWUhRbEtHcGQwelM1MTFLWHA2NVlJaTJ1NkYxeTRKeUg4Vmdi?= =?utf-8?B?bmwyNUFXUjhXY0h4ZEpsWThTZkgxeCs1N0ZFZ2FTRDBucW5OUjZZYkY3eVZz?= =?utf-8?B?WlJ6Rk5wVkUwSGlacTZqTkQrQVptUThoQlhlSzB6dUtud2xvUktSdW05eVhy?= =?utf-8?B?dTN0TkRBdzJyK2YvbnlxUjBFNnJ1Nk9WTzV5bDBISWZNRUl2dDhUOVBqWldP?= =?utf-8?B?aTVRUW5vT0FBekhMcjBJN09EME5TaVhCb1htUzJhNUNvY1B4QjZKSmJZS0Vq?= =?utf-8?B?WXN3QjhYY3pGN3owcGp0SzZVbXB1SFo5NXdFMzVxem1oVzVNNHNWaTFiSko4?= =?utf-8?B?MEFPUklBRzYwajhkdG9RakVWYUQzRUNuWUhPRGtyUXpSZUUrb0s3QUN1MmZs?= =?utf-8?B?QnhWbzBSbFhDTTM3Q2tyUWJuMm5CN0NaZDZNMXRVelV5dy82Qmd3ZTBCdTVw?= =?utf-8?B?WWJJdWtzd01WRWhTeFVFNWw1eHFEMSthQ1FReTdMU2pacWExME1oYlNDdXZ6?= =?utf-8?B?R0JsMTJ2OEgrbG9IbWJjWW5xazNpUjRKV3VnL0VKc2tLY0VOVFlnUTI4b2hz?= =?utf-8?B?MVhNN2ZWdlR2UTc5Z1JVbUsrd3FBZlh1SG1CVXA3SFpNVmhabGJVa0F0Smlu?= =?utf-8?B?ZzFDTzNKVUFSc3UzMDVFRSs5Y3VUK3VKaUlhc1V2Q3RrVU1pTlpUZ3JUOFFq?= =?utf-8?B?alN5L3hMSFU5aE1OeW1OblFMSHBJWWRmNHp0Qk9FME5NRzZVWE9aQnQvUnRy?= =?utf-8?B?Mml6dE5zeTV2WVhxWjNsNTVad1l3MDl0aWZuMm02NEtuazA1KzhmcURKWFdr?= =?utf-8?B?U1RzRlNBR0I1a0EzT0lSdnBQNktqU3pPRGdtQW05UGs4aGZwRHpmcXhPYitN?= =?utf-8?B?cWllVTFqTisyT0hvSUJWNjlkOGw3c095Nkgra04yT3RqYWx2RmtUZFJFb2Nh?= =?utf-8?B?U1FTaWpOZXMza25iNkY2U2p4QW8rZHFpeEgwNk1ER1VvR0hsT2JmRzhucmJG?= =?utf-8?B?RmdmdmhQcmFYUzZ6azBOTXZGWFR2M2t1RWpHMy9vNXFjbFM4ckZyQVJjNm1z?= =?utf-8?B?TENWU3FnUFRHL2RWQkRYRGhyZlZQcGdUYzcrb25HY2hRSEJIWjRoMzdaRjl2?= =?utf-8?B?RXA1N3l6OElaamdRcHY3cFN1SkdVZ2FCanVqS0d6Q0c1Rlg3YU5PSllyYTRV?= =?utf-8?B?djZESnBCSkxXcnpVU3JPeFJVUENXU2tVSzJUdEwvd0tHc2Z6OUlwNVh3aEtD?= =?utf-8?Q?owyvDiiu3/CsM72YdsgQa0QXYlwoOsbU5Prd0=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(7416005)(52116005)(1800799015)(366007)(921011)(38350700005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cVVuNmRweFgwTUJMMTl5SmdVbEhxZWZDQWsxT2tkTTBmY25va0dKZlppTEM2?= =?utf-8?B?Q0F0VSsvMkRRL2p0RDk5T2hwcWxQNTU4ck02N3ArdTk5ZEJZSlEvdHZQbW1Q?= =?utf-8?B?Ry94dGdDTXJLd2prYXY3dnJ5WTZyVnNybE9qZWxJcWVzclhTYVFHNHR0eFpv?= =?utf-8?B?azV3akEzdmF0YlFEcUJ5dmNZREMyTzluRmhzclo4RjJMalFKTEVVQTFGWm5j?= =?utf-8?B?ZHhJNy9TNkZQT0VNbzE0b1plWWlPWjNDaTlXOVhSYStzSE1GU0FsRzk3czQr?= =?utf-8?B?YmxObTJKRnl3VnkrYUQvRDdObGFvMUE4SCtxUUFMYldmNVhOTW1uZS9FOTFp?= =?utf-8?B?ZUdtQ1BjUWpuczhhY0ZuSGtDZnU3MFpVdWRwRnFOSzNFV2xDSCt5dEg3Q2dp?= =?utf-8?B?Ny8rS0UyOW5OckxtSTFWTjI4UVhiMVhRdzVONmUzNWxOSWtBTGVpYnRIQ04v?= =?utf-8?B?ZWE2N2JXeWNlTG9FTGlBYUFRZENtazJuQ3NoV21HN2tGa3NuNUZnTWtleFJm?= =?utf-8?B?MVI4SGtPT0hOZ1NkdUt5VzhQS3d2UFVoOUZvbGxvZFBlYjZtYXdwaVN0Y1dy?= =?utf-8?B?Sm5xRHQ5dlZlNzVPMzh3UysvV1dpMC81c3lubTFBYS8wRGR6QkFnc2JKdVVD?= =?utf-8?B?bnpUTEdSeXVqTmh0YjBqdXc0eVdpb2JKc2Rod1l2RmIvbHpUOTFqd29YM081?= =?utf-8?B?VUozVWJ1SWlFcjBmUVR1dWluVDEwVWRlMXBWeFlNMFNPbkN2UHVBR2xiSG9m?= =?utf-8?B?VG0yM3RVNVVZUFFTV0FHZ3hZTVhRWEc5ZTVzYXlQZ3R0a3hGVjJwSDJseTRB?= =?utf-8?B?Wm5xMi9PeUl1elpLNFJFWHdKOHh2bU0vdk55R2kzaGtZRUpaREdub240RUlN?= =?utf-8?B?OHluUmNJMjZwaG84NU9saVI3WGxqSnpRREN6MXhEangvbXVLK1JaU3VJaXZJ?= =?utf-8?B?NUxzc0dKWlRnRzRPeFJBSDhOT2F3RUJhL25MSlQrWStpbEdGbVNwNldtQmwz?= =?utf-8?B?NGJsRmlyQjJIMCtlT3N4Kys1ZC96NTA5OE92SHdPaU5MK2dBRmdtUGxMREhS?= =?utf-8?B?akxHMDBKRjJkZFdyY2dxR0tNVUxFMGFxb2JkWVpETzlmRkRIa0NuM2lOOVNs?= =?utf-8?B?czV1RzhuUW9NdFRxaDdxS05HWmJBWnV1YzVTVlRyWlhjZzBSMktQTTFsWUNC?= =?utf-8?B?UUUwalozOGg3RWlvYlhzQWF5SENCdGN3Q0oxRUhiTUhaSXphamp6WmYxMUc1?= =?utf-8?B?UVNsZ2pSbitqWTFicVVpMktwcjR5dS9uMk4xM2JvNk1ZNlR6QTUxU2hFNkxa?= =?utf-8?B?c2dtUVhkQVdxVTkxdDU0S2d0ZG5xV09Ub3lLRmdpQTFKZEVsdTNqUE1uK2hR?= =?utf-8?B?Y3k1dHh3eFlyaW9CV0oyanRlMTNocVRzSmdvQkdGaS9PVSt4eWg1WVJBakZs?= =?utf-8?B?dE5Vam9pcnk1V3dDZlExWTVnVFlpZnZ3ZFBDNUJNUkVPRVpkTWMyQWY1Qk8z?= =?utf-8?B?eFdrbjhTVGRydlFsT29tc2VQdG81YkNIeGVxVEZKcnFzejZ5MlNPZ01Vb2dt?= =?utf-8?B?VUZCb0lWWmxRQmNTUUh6aVUyZW5qTTRTVjArZ3VLMnBFUGlZVGRrZ0U1TktE?= =?utf-8?B?bTdzSlcyNkQ1NHlEMXJHdGtxcXNmSHp5MncrRTR0SW1SeEgzMUlJSkZKRUpS?= =?utf-8?B?ZTVFNUo3ZFE1aXMvdEJCcG45T2JtOGNhNE9QSlpEeHJnRG02N1JobHppek5U?= =?utf-8?B?NWdUejRiTmRSYVZNOU0xVkFjaHVQU24zb0RKcmJXVUs1M1pza0NhMmVod3Ro?= =?utf-8?B?TnZlS2VPbW9GeW5PSUdaOTBiY09QaHBvOWZVbzlZai9IQ1JCRG1OQzBzTFJM?= =?utf-8?B?ZVZzNGN2Mi9hSmlXUVZDQmtpTUlIcHhiN1FNSU85blVnYytZZ0lML2JuRkZa?= =?utf-8?B?VDlIYjZLUkpzRmpYU1RNY3hDS3BnN3pONmVkREJuSkJPT29idlVscTIvc2JK?= =?utf-8?B?N0ZoOUZNUXNMTDAwTTgxSVA1R0kreXZ6SDVGTW0wN0xSOWNKWTJOUERUaWl6?= =?utf-8?B?ZGlpR3JLVDdFd3VFSm5VbFEyU2VWdlpaYjMxcndIV29CdGFiNXF6bENYTmpP?= =?utf-8?Q?wZQCRd70hvzt7jdJ8+uLghO/Y?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3a386a51-db17-41ce-fd86-08dc6c3bddc0 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2024 13:12:35.9937 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xkL1NGtmjTHzgUEOEpGYD3XConoiQLgB8vnYFjSMgVN5FoD8qaklgWrmfeCEQ+h1dWwFnYe/mlK+tvyurvqy8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8174 From: Peng Fan Use scope based of_node_put() cleanup to simplify code. Fixes: 6118714275f0 ("pinctrl: core: Fix pinctrl_register_and_init() with p= inctrl_enable()") Signed-off-by: Peng Fan --- drivers/pinctrl/ti/pinctrl-ti-iodelay.c | 37 +++++++++++++----------------= ---- 1 file changed, 14 insertions(+), 23 deletions(-) diff --git a/drivers/pinctrl/ti/pinctrl-ti-iodelay.c b/drivers/pinctrl/ti/p= inctrl-ti-iodelay.c index 040f2c46a868..1032bc9c36aa 100644 --- a/drivers/pinctrl/ti/pinctrl-ti-iodelay.c +++ b/drivers/pinctrl/ti/pinctrl-ti-iodelay.c @@ -822,53 +822,48 @@ MODULE_DEVICE_TABLE(of, ti_iodelay_of_match); static int ti_iodelay_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; - struct device_node *np =3D of_node_get(dev->of_node); + struct device_node *np __free(device_node) =3D of_node_get(dev->of_node); struct resource *res; struct ti_iodelay_device *iod; - int ret =3D 0; + int ret; =20 if (!np) { - ret =3D -EINVAL; dev_err(dev, "No OF node\n"); - goto exit_out; + return -EINVAL; } =20 iod =3D devm_kzalloc(dev, sizeof(*iod), GFP_KERNEL); - if (!iod) { - ret =3D -ENOMEM; - goto exit_out; - } + if (!iod) + return -ENOMEM; + iod->dev =3D dev; iod->reg_data =3D device_get_match_data(dev); if (!iod->reg_data) { - ret =3D -EINVAL; dev_err(dev, "No DATA match\n"); - goto exit_out; + return -EINVAL; } =20 /* So far We can assume there is only 1 bank of registers */ iod->reg_base =3D devm_platform_get_and_ioremap_resource(pdev, 0, &res); - if (IS_ERR(iod->reg_base)) { - ret =3D PTR_ERR(iod->reg_base); - goto exit_out; - } + if (IS_ERR(iod->reg_base)) + return PTR_ERR(iod->reg_base); + iod->phys_base =3D res->start; =20 iod->regmap =3D devm_regmap_init_mmio(dev, iod->reg_base, iod->reg_data->regmap_config); if (IS_ERR(iod->regmap)) { dev_err(dev, "Regmap MMIO init failed.\n"); - ret =3D PTR_ERR(iod->regmap); - goto exit_out; + return PTR_ERR(iod->regmap); } =20 ret =3D ti_iodelay_pinconf_init_dev(iod); if (ret) - goto exit_out; + return ret; =20 ret =3D ti_iodelay_alloc_pins(dev, iod, res->start); if (ret) - goto exit_out; + return ret; =20 iod->desc.pctlops =3D &ti_iodelay_pinctrl_ops; /* no pinmux ops - we are pinconf */ @@ -879,16 +874,12 @@ static int ti_iodelay_probe(struct platform_device *p= dev) ret =3D pinctrl_register_and_init(&iod->desc, dev, iod, &iod->pctl); if (ret) { dev_err(dev, "Failed to register pinctrl\n"); - goto exit_out; + return ret; } =20 platform_set_drvdata(pdev, iod); =20 return pinctrl_enable(iod->pctl); - -exit_out: - of_node_put(np); - return ret; } =20 /** --=20 2.37.1 From nobody Thu Sep 19 19:38:14 2024 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2083.outbound.protection.outlook.com [40.107.249.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CE2B4A1C; Sat, 4 May 2024 13:12:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.249.83 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714828377; cv=fail; b=Kg6++inJDR5ulm8dMxW4kBW1az63A864OB8IPbH66Iokt+oOnKS3RrQMYgqpmEkQMxyOJq+SnEycY9K8fHqJJpuZ6fPiHGhpn8FwwALXMlgjtuyk7S6s9bmAXFpybSVAXzJb4Ny1Pdpe4rKzrjbO+IlvqOOJrrnMh2uz7TFNk/I= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714828377; c=relaxed/simple; bh=O584+LvuF4pyN3SkcooP3Ifi0UGy7KBPUUWirXlIAaY=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=R/dx8IkvkYAlMaHqmWB9omBNWhl/QC37Ta6rgLKap/R3IM2MR67r21shHESFNlIbgzdBgsYp+4hP/bbLEtSi41Oyw4i8EbQ9/a3VE3FO/pahW+Bo/VrOXwu9Aa9UZLlNosRJK5CsyYbJ3CDDP4nMteno1LzglHpTLvX5JsDSBPU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=V349u3hI; arc=fail smtp.client-ip=40.107.249.83 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="V349u3hI" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PsBZCp9Q2DoZaI+7hZlpN4AV3qyDi6yk7j7xxI7aGPT+2QAuqBU8BWUZRtyjv5ta58Tjp0X17Pj4FUsFIUhwx6616LxpbEML5R1Ge0fKCdWbw8EiidXONIprB2Xp01fjzqw20PD/0PwOIvndEJM96+EMEmTohkJ1lWum4EBeydMmKGozTV4yYBXpD5+8N9JKmqqkt7bbmuA0ZA5si/2/imZivs5R8QM/eyZf5o/7FJahC7Ymfg5h8X6hAcOHR7+YWkS0MBYx2zi0C9eorle4yqBpsSs8nmrYHAVjEjwPJmNjk5roVvDrL6UfzL/+YfLoASCQ4gI7MUA8tV55yPaq8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9XH/O68wWJ/FfHgYL+Kkys96wwEpB5Ik6VZZUTwb4Mw=; b=TWncYo9doring7vInD062OrPa8mLEYYPnQHCKdGMbQ4nwgay/lYItCeIzbuggHKlNeECzTvi9foYcxGeNknjR9IKymosX2iGWN8xXy73U3+Vu9K3QAQiGswibNii9Q+Nl4hSw08IndO6k0s9Op6HkrTJGjGDRKJQ+kZyhkic4EtI1aecDrvzQqv0Fb4bjZNBMkaGuyfL7i+MInmsqksnhJ3OvHNDCCSWhMVtfLv0/T5HM7BX5LNVZ+2yeTLknS21cBk39N0cqWvodUUDth9uBOxs+94yeIjQDuL8vdtdoGxjSDbkekeqyB4bs6/uNcq6ToVOHx3LjaWqiIvORVZd3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9XH/O68wWJ/FfHgYL+Kkys96wwEpB5Ik6VZZUTwb4Mw=; b=V349u3hIj3jx8cbwqgkcfFeYcAviXPW4lFmxDNc1jpRnCj3N2UqV3+1FNPMZisxIMljtshFftZvf9/CqPZF/gwdakXv3n++Lu4Sy9MydaP1a/VvfeQHrAQFT2+jWoV4WSZYvwvdlm+9h7N/D5atkTpy3EcMi0t+yX1XnvLDWNo8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by PAXPR04MB8174.eurprd04.prod.outlook.com (2603:10a6:102:1c4::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.39; Sat, 4 May 2024 13:12:52 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7544.036; Sat, 4 May 2024 13:12:52 +0000 From: "Peng Fan (OSS)" Date: Sat, 04 May 2024 21:20:00 +0800 Subject: [PATCH v2 02/20] pinctrl: tegra: Use scope based of_node_put() cleanups Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240504-pinctrl-cleanup-v2-2-26c5f2dc1181@nxp.com> References: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> In-Reply-To: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> To: Linus Walleij , Thierry Reding , Jonathan Hunter , Dvorkin Dmitry , Wells Lu , Maxime Coquelin , Alexandre Torgue , Emil Renner Berthing , Jianlong Huang , Hal Feng , Orson Zhai , Baolin Wang , Chunyan Zhang , Viresh Kumar , Shiraz Hashim , soc@kernel.org, Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , Geert Uytterhoeven , Patrice Chotard , Heiko Stuebner , Damien Le Moal , Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , Chester Lin , Matthias Brugger , Ghennadi Procopciuc , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Sascha Hauer , Andrew Jeffery , Joel Stanley , Dan Carpenter , Tony Lindgren , Stephen Warren Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-mediatek@lists.infradead.org, imx@lists.linux.dev, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, Peng Fan X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1714828815; l=1919; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=dgr9gEpDJDvikxHa9ZakH2O4ug/ULsl0qx1MCE8QJXg=; b=c29ur0xozBQHWw4UNa1DPvMPB/3nv84hzDNq2CwMxaS5GG6IYyoT0/JK1IrVkkQRteonbSNKJ JhK2UeiCgPTAeUzI40ur2LqqsCNKyNGdObHFdFgxDDw3tA05J72cW0s X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR06CA0230.apcprd06.prod.outlook.com (2603:1096:4:ac::14) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|PAXPR04MB8174:EE_ X-MS-Office365-Filtering-Correlation-Id: 567fafd5-b163-4390-58c8-08dc6c3be7cc X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|376005|7416005|52116005|1800799015|366007|921011|38350700005; X-Microsoft-Antispam-Message-Info: =?utf-8?B?eWFCYUFwMG4vWGFpQ0xWbU5MS1R6STQ3V0xVSWhuSDgyUUZ2WTRUd09zajhl?= =?utf-8?B?anNJa2wydXY4SWxKamxLMzdBemQ4a3UrZG4rWVZiYktRZmNDNENBNzdwQTRZ?= =?utf-8?B?aGdkeFdPdHEvaGRPdWVrNGhCeTB5dXBiSi81cm9ueTh1QjNoYnBIVVZMZ1NN?= =?utf-8?B?R09EamtuYmZCUVlyTVFIZE92VUlGSEtBalBvaTBmdU05TTNJdUpEd1JuRGZH?= =?utf-8?B?cFVXVlprQS9kdDR6RndjZ2RGWlpPYlo1bWtJbS9UeHpIbzU1aXV1c29DeE5V?= =?utf-8?B?NUI3YzhPSVVWb3QvU1BqV0t6RFB1T2pnMVZ5KyswajlJK3paYjFHR2dFMlVa?= =?utf-8?B?dUxhaitxMXU1T252OTRWN1p0K2txVllhYU9ZY01rcG5MbUZxQ3pyTjg1UjhL?= =?utf-8?B?RzVoMFJDalhmMHdYbFNZb2Q5d2pNMVZ2RFdVdS80MHZyQmFxN2hwS3J6Z0NM?= =?utf-8?B?K0owaFAyMURyL2tScEdJWDZ6RldPZzdIcnF6VHpXcU1nNE9WbzFiWFlIcG5l?= =?utf-8?B?WldOV3cvWmowQTNaMVlhVnJ3b09MWC9XVGJtK2tCTkcxUDRHTTBpMEZVdzY0?= =?utf-8?B?dDFrNU9GczFRTE5FZ3JjTms5ek5NbVhVVG52SWY0cEJtNWoxSmZlUDBMeURI?= =?utf-8?B?UDgyOFNSckJITmo2MzNRd1hjSHFDVWZLb2l2Ly9zeVZXeFJxU1JIK24wcXd0?= =?utf-8?B?eUNhbEZuN3RIaC8xRTFnZ1hwc05mVk1oQ0JnUGdaMUpMd2xNU3NqcFk5Q0J4?= =?utf-8?B?YUJVWVJXa0wrVDdoNFhhQXIwa1dPUFNPNVJOUVB5MDhoclRjTkNyY0RvcnZP?= =?utf-8?B?TXU5ZnhsZjNjZVpqUi9JNzNtL0pFcFhYWnNqVW1GNUZQbEhxR092WU1DWUto?= =?utf-8?B?dUoxcnEvNzN2RU9oNXd3R0NVekYxZVNEU0NPZ3cra1RQY1hSSkVmREl3MGU4?= =?utf-8?B?ZTNvZzFraUJRVUlIU1lxanYwcWJ2Rjh6WHcydDI2MU4xQkYwc3FoVTU1OGdp?= =?utf-8?B?SXlhdHY3cndoMGgvM1NxYmlDZUdTYjZyN3FtMVdIYjhzanVZZjgwU1dLRjU5?= =?utf-8?B?KzJYVm5BRkxacG4yTjBkRXh0SHJra0p0M01GZ0pWMnFtZ0YxakUvNlZnTkNT?= =?utf-8?B?TStBVk1QbTQ2bE5sa052VS8yUVNQQzhRdE8vMlppVHFyZGFKRkNoR1BQWTAv?= =?utf-8?B?TzFpOXJqRysxOGVlY2NLTG1FQVZuVi9lZGFjbGNlWVppVk5OdTZRUmJNZTN5?= =?utf-8?B?KzVibk8xL3V5bVdqbjVYV2ZMbnlvc0Q3NjJGWVpYQUg5UHV2S2phZENMVnM0?= =?utf-8?B?UEJoZkJreTJvY1dkSkQwV2pMeU9LbHc4TXkrcGJKdXF4dHFCbU92bVJ4ZFN5?= =?utf-8?B?N2xSSmkwWEdRMWEyb29qbUF5YkxrZk04RG9YcEVhOTN4NU5rY2tzTCszOXY1?= =?utf-8?B?Tlk0N0VaS1FLd0hYczZ6b3NadEJ1OCsrWVN6V05HOFNxa0tPWld1OElndjho?= =?utf-8?B?azV6cmtWVktMUzY5R21QU3RTTzQxQWRVNVBnM0MyLzRpZXRzSWV5VGVobDlZ?= =?utf-8?B?SnVqUWJKN1RYK2Vza2ZGWCtnL3ZIQjk0UytFNThSRWVpc3FlTCt4WnNvSlhY?= =?utf-8?B?RldlOTBJQm5ERVVab0xndjllTEFMbjgrclkxVkU2VEN3ajAzU25lOGJTbytN?= =?utf-8?B?cmt1MzdtYVdUNUhVdkIzN1lPZDM3VXptemdMdGJVd1RXait2Q2N4MmgrWW95?= =?utf-8?B?ZWV0R1FGMG96UDBibThoSnl2ZUJTdnVwVnI0QzNjOE8wanBPaHFLM3lpSFN3?= =?utf-8?Q?Jz9zlJ2KTyW+xF7/VV/sgvG4n/64eu/1Yot4I=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(7416005)(52116005)(1800799015)(366007)(921011)(38350700005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a1h1TDRUL28wRGlVYXFUME9qaGRPcjg3NjdJZ01IUzREK2M2TWxiKzVRM0lC?= =?utf-8?B?YjBDUnpQTEo3NjJHZGZtVU9YbklNQkFHMjk3bjZXV0tBMnZPcEMzY2pIcTEz?= =?utf-8?B?Q0lnN2ZsMG1OcXNLZjRyZTllaTllUmZVUVBUYnNHN3BQN2RCZzJmaG9nWGVl?= =?utf-8?B?NzJPdmNrY2Fid0N3SzRQWUxLSGVmTEJCU2F5NmtlUVRQUnF3MG9BMWFwOEd3?= =?utf-8?B?TTZkamdWYW5KMlpOejBTaWVIRktiWFd0dnpCQVgxZ2hGQW9nYmVJb3NQbTNo?= =?utf-8?B?SlJ5dlJJRlJrUlJ1UksvWHdJbmlIeUtwSGg0MnltSVRaSWwvZUtlOXJBSjJU?= =?utf-8?B?Tk9nek9NUnpVMHhwR3l2Y0ZzTWdUdWo3c0V3bnZZWmZnUVp6MlpRbzBMM2Q1?= =?utf-8?B?bmc4akdQbW1RR3BMTWNOQ0N2WW13aVJCdXkrVEE4alE2NTJhc0s2KzZCR3ZR?= =?utf-8?B?WU1scXovSk94ejZDT2h2bDdMbVA1Z1F2RElVR2JQQVk3S0pER2lzdmhjY1ZJ?= =?utf-8?B?YnZLdXJJdE5EQmQzaXhmNWlEWkp1MjlRV0I1NkJWcGpaMERsRllvUG1qS0Fx?= =?utf-8?B?elQxa0w1bE1xZ2RveHQ1aUhLRVNjYTFHOHdLUnR2Zm9MbDhxeEtUVVRrVnU5?= =?utf-8?B?bnZVRUVNeENsbU80MWlUdVZoZ2Y0OHFwRXlZVHdpRUtOajFtcG1HV2tRUXBR?= =?utf-8?B?YVpGRWJhV0Q4NmJvQUxIT214ckpGVkpsL294RnVMRkNBcy9EOVlaNUxFQk5l?= =?utf-8?B?ejlNLzVSWEZSUkJnUGEwRHFMd1pOTCsvZlJlVUhobklxNkFRaUp6Y3pWcTRL?= =?utf-8?B?T0J3Y1docDU2Wm5lcVZoQml2OFgvazR0cWd0NU9lempwd1RIYmtYK0dUVWtw?= =?utf-8?B?V2hIMk53UUt1S0srT085TDJDVmYzNFdzWmVCbjc3cFhTalRjQnFCc2tnUEl1?= =?utf-8?B?TlVLeGo3NllGQk8wV29oRXNzZ1dnWGpTKzFnN3lCU25ZeWNXMnIxelVUVkNl?= =?utf-8?B?TzA5NHp4c3ltNHNPYjA5YWMyempzM0VMQmxhamtHMHRma3JOQm54QzBzeHho?= =?utf-8?B?L1pBRzR5YXpFNmQ2S2dtVW5HMlBnVkFkbEZBUG5zSDBzV1JXKzhYd2NoL1hG?= =?utf-8?B?SElXMUhtRmd3YmN6Yy9HQ0xUMFNKNkgxbFBuVFIzSG5kYkNkdDZDM0lBRWth?= =?utf-8?B?UWdzRjl4NHNxS3U3dFVIRFVpQUZ5RVNYeGNUNlNyTG9UcE4xdERpU0V4Um83?= =?utf-8?B?VXduSW94ZXFBQVNrazZuVUdGZDVZOEpNbjRYcndESCsyVk9iSGhTeXl6VDBU?= =?utf-8?B?cGJlQTZvb2ZSREovc0J1ZWFTMEpSSk10dHZKSmF0VzVJVlFFekpLMVRWajVa?= =?utf-8?B?YkphdHhOOWU2MXNBaE1PL3dwdGdHQVBKd1VTTEpMN0ZFcWVRWEgrWEJ6M1JQ?= =?utf-8?B?blVDdlY1N29xKzgyelFuWXhlK2NKdE8wandRSy9VdDZZVG9MS1BVWXRORlRy?= =?utf-8?B?OE5mMURvU2gwWmVKSHJjY3EvUkdBMDhCQWNvdTJnUVV3RkdyTmxKdDlSTWpx?= =?utf-8?B?ckszbGZ4WmlXOGxkQnhHaGlVVzJvVGxja25TYUVDKy83VkhxOUh4T0xWQUlU?= =?utf-8?B?NC9xdStKMWhzUmw5K3lreWVuc1h4YmRpREtzYUdrYU1lbWJiWmFlcjE2a3lU?= =?utf-8?B?ellOUUVIREZndjg3K2RWblpDTUJIWWhMQjlMbUtYWUdIUE11dmtJM2Y5SlVr?= =?utf-8?B?S1FISkYxZjF0YlV3UUQyQ2U1czRUSDdCZzhCdjE3TkN2UXN6M21DMmhCY1Zj?= =?utf-8?B?N2tTc3pTL284a0tTR0RwYmZmY0tlUmdiRTc3WXBCVnB1MXcxQXlhaHprc3Jk?= =?utf-8?B?ZGF5N3FPU3BqdTU1blhsSHdiMkdudTZhcW1IVVMyUnVtQitIenM4bmZLZzZF?= =?utf-8?B?MDJueGJTRjRxbGNqVUVsblZ2enI0UjJBSmxvZ2lNR0dFYlFJZTI0dzZsVlZv?= =?utf-8?B?VTFPNUFWRXJoYUVlQ1NSRmJzSERVNnFINS83OURvZ2JyWTdzS1lLdlZoSCti?= =?utf-8?B?QU03ZE5xYXNGeWNaeG1LN0pLQTB2ZndVSHZFK0JZNFN4ZWRFYnpDYmlpUTE4?= =?utf-8?Q?yHAQlzlKBuX+yVMuGIUrVeoC+?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 567fafd5-b163-4390-58c8-08dc6c3be7cc X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2024 13:12:52.8610 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4sy0/+akhGM1b/xMzo7AidLZmxf7iqXZJ2mOFSl12FWS2ISjCqiAQ+I1mwlX0irAQsix20v/1FTiNUyCDxWpQQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8174 From: Peng Fan Use scope based of_node_put() cleanup to simplify code. Signed-off-by: Peng Fan Acked-by: Thierry Reding --- drivers/pinctrl/tegra/pinctrl-tegra-xusb.c | 7 ++----- drivers/pinctrl/tegra/pinctrl-tegra.c | 4 +--- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/pinctrl/tegra/pinctrl-tegra-xusb.c b/drivers/pinctrl/t= egra/pinctrl-tegra-xusb.c index 96ef57a7d385..49c5edeba87f 100644 --- a/drivers/pinctrl/tegra/pinctrl-tegra-xusb.c +++ b/drivers/pinctrl/tegra/pinctrl-tegra-xusb.c @@ -238,20 +238,17 @@ static int tegra_xusb_padctl_dt_node_to_map(struct pi= nctrl_dev *pinctrl, { struct tegra_xusb_padctl *padctl =3D pinctrl_dev_get_drvdata(pinctrl); unsigned int reserved_maps =3D 0; - struct device_node *np; int err; =20 *num_maps =3D 0; *maps =3D NULL; =20 - for_each_child_of_node(parent, np) { + for_each_child_of_node_scoped(parent, np) { err =3D tegra_xusb_padctl_parse_subnode(padctl, np, maps, &reserved_maps, num_maps); - if (err < 0) { - of_node_put(np); + if (err < 0) return err; - } } =20 return 0; diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.c b/drivers/pinctrl/tegra/= pinctrl-tegra.c index ccfa3870a67d..c83e5a65e680 100644 --- a/drivers/pinctrl/tegra/pinctrl-tegra.c +++ b/drivers/pinctrl/tegra/pinctrl-tegra.c @@ -188,20 +188,18 @@ static int tegra_pinctrl_dt_node_to_map(struct pinctr= l_dev *pctldev, unsigned *num_maps) { unsigned reserved_maps; - struct device_node *np; int ret; =20 reserved_maps =3D 0; *map =3D NULL; *num_maps =3D 0; =20 - for_each_child_of_node(np_config, np) { + for_each_child_of_node_scoped(np_config, np) { ret =3D tegra_pinctrl_dt_subnode_to_map(pctldev, np, map, &reserved_maps, num_maps); if (ret < 0) { pinctrl_utils_free_map(pctldev, *map, *num_maps); - of_node_put(np); return ret; } } --=20 2.37.1 From nobody Thu Sep 19 19:38:14 2024 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2088.outbound.protection.outlook.com [40.107.249.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BF084A1C; Sat, 4 May 2024 13:13:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.249.88 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714828394; cv=fail; b=UcULIoxD5YwMTqQt+Eju6lQpD3vgU/zGXUW0LPqE66mP6PusIev1JDdKbgsF0kuLGGQPxsEyrNB3xFDuFnz7iNjJuO75YDwmicpS0NX5/ygPWiDxatOizViHUmW/bUQ7DG7RGrKKoVr6wF+QPuu0fxFc2npC4TGYDXN5OtSsB6k= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714828394; c=relaxed/simple; bh=4kFV9K5wvGejwy+SJ2LKcCyxaJGa0mPSeiJjq47A74s=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=UJvRtmQtx+y61Kyhm2mj080YJFytnnb1lx6j54mPlAKk/KT16ywNeuB2B4AGpGzjHb2pYbUZyS057qpWLFQTrQr/Sn5mtTJQcdAWls9b7U6QiXYfXrk27LV3Yma2ixZvFSvpMSlWry4yfoO4G9hf78vVxL47j6A6CwiTV5VoGJM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=gw5ShpcH; arc=fail smtp.client-ip=40.107.249.88 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="gw5ShpcH" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QcaVkUmsYsgy3hGwoc4viGWghmbmJckIyjk3VfgZyd0q9zykcuOT2r/Up0JHjRRSlaNiUuC+67e9b7cyrDO5Sz2n+Zq9fHPBwbDbbPjabh2l6lKIwGkgM8aOXyDbHdc+Mfi2osWQ3Rpvvl24REF5xLx2BB0BOW0q33p7alKyB1Rfxnf3s81JlFUP6NXETKywKjeLMO+InMLyLc7dnpetL+WqtcibgKLV8U3Yl/3IvsxbPEicFPN3udN1LbmkWnBMmEJv9pIxIT2Lee78Vnqd2W88RdVhcXjLJDphxU6nHBPxjil4fejb7CFw6k7VoxTt1jzzIGK5PZzt6Mo4uQMGYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TTUcWyDbCSVNKuwyH5CGkMM0CICuYlw4uOmY5Ln1Lww=; b=IzcjEHg3B++1mx9qN0aqRQmWrjGkJy1+oWQceAgzG+WmADqth92ecZ5z3vswxH5oEG+evbmIaZB6Y7z7HYBjdgChGEhQ5z6GJBGKt2Ad2BUtkbRr6CU9MCCs6s2VNUks/OZt4VUthFV/LMA7v/XlJRAl8SeIqd3saEd2Lzi+0ih1KJcw5wYLvxyCLaseo1sjcU2Us2OQLamOE6YOKy/ahK2+0silk14y1Vi97kfueW1MpJ1/iLQ4RuD8Uw6MXM6KIhVnBa54n7isYNvCVsDBOPZl6y++n3X9iiGDHqz1mzoxMxhysYITeUhO7n1c7NLB4LjKz2S2DyC2A6hTvmqrWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TTUcWyDbCSVNKuwyH5CGkMM0CICuYlw4uOmY5Ln1Lww=; b=gw5ShpcHbxX+/Xgfdkl6TAsvFPiMvIEC+Wi+Ae6nDPBN80+wYr5eN5N4wCs9HQdsZHVPCfURXlozR7QE89G8wt/kwGfWscEVp50pt1vIB1+dt1JzONplO4EaBHo6DN6kyJXhHSOlNQq/3TaVftMeT7o9rKj08S11oECy3aSVXqo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by PAXPR04MB8174.eurprd04.prod.outlook.com (2603:10a6:102:1c4::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.39; Sat, 4 May 2024 13:13:09 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7544.036; Sat, 4 May 2024 13:13:09 +0000 From: "Peng Fan (OSS)" Date: Sat, 04 May 2024 21:20:01 +0800 Subject: [PATCH v2 03/20] pinctrl: stm32: Use scope based of_node_put() cleanups Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240504-pinctrl-cleanup-v2-3-26c5f2dc1181@nxp.com> References: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> In-Reply-To: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> To: Linus Walleij , Thierry Reding , Jonathan Hunter , Dvorkin Dmitry , Wells Lu , Maxime Coquelin , Alexandre Torgue , Emil Renner Berthing , Jianlong Huang , Hal Feng , Orson Zhai , Baolin Wang , Chunyan Zhang , Viresh Kumar , Shiraz Hashim , soc@kernel.org, Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , Geert Uytterhoeven , Patrice Chotard , Heiko Stuebner , Damien Le Moal , Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , Chester Lin , Matthias Brugger , Ghennadi Procopciuc , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Sascha Hauer , Andrew Jeffery , Joel Stanley , Dan Carpenter , Tony Lindgren , Stephen Warren Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-mediatek@lists.infradead.org, imx@lists.linux.dev, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, Peng Fan X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1714828815; l=1139; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=ghhx4F825SMq6fS1o6/f7VxGij7/D0TVS3p3q5rW72o=; b=W1ebSmJCvWCOZPu9H9k2jOBBLmE4aP3UkbMAeH4VFsI8NvpmJKE1fTQkEzyogXFOCywZ9HGuZ t/i1shR6m/HAeYvAKPCXfhOd309a+7YyiU7qE5UF2EXObsv2UvI//bP X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR06CA0230.apcprd06.prod.outlook.com (2603:1096:4:ac::14) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|PAXPR04MB8174:EE_ X-MS-Office365-Filtering-Correlation-Id: a58bc258-71c9-40e7-3d3b-08dc6c3bf1bc X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|376005|7416005|52116005|1800799015|366007|921011|38350700005; X-Microsoft-Antispam-Message-Info: =?utf-8?B?TmJmdjB3Q1FybWtGWi9IMkNxRmRQZ214UFhKY3FVdjI1NzhoOE4ySWZkUmps?= =?utf-8?B?NTZGTjkzNm9WVFVHOHdsVjM4Wlo4Zy9pbkhJZ0dFQS8vMHQ5SndJK0hwV0xM?= =?utf-8?B?Q1BMZVVQNTErVkV1R3Q1bXpxWTFlcXNUZHZqMkVFRGh1TEtuSzROcTdlVlR4?= =?utf-8?B?UHpQelFxampLYldBa2FESTd3NHRML0RRQUZtd1UwSkd0Uko1K2NTQXhyN0xG?= =?utf-8?B?V3ZOWFV1YlVRTjM3eXMxdjVkdWFnY3ZxRHZkQ1kzcmdndmI4Q3NYREhyTCtx?= =?utf-8?B?b3NmcnpuOUlkZDM4bDlmTXhWZkFzU3FsczN2cm5ueTZ3aGh1SHNKVWFXeXBp?= =?utf-8?B?cVc0dTVSZkFZNEtGcy9TaGpCazhGejk1eE8zNmRML21TZEZQZXhEK0xNSGVP?= =?utf-8?B?OHE0QVo4NFI5TmlvenI0UkVJbjdESElUMndka2NJU1IwbXcxSzZuWS8rRTUx?= =?utf-8?B?VmVPLzJsdFFENHhEL3hPK0J6K1FDbjBSTCsvZDN3U0dmL0dURDFRaG1mU0g0?= =?utf-8?B?bUVTZ0IzY1ZwOUNtSVNBZlNaczNuM0gyQmIvOSt1YmExd1p6YlRFMlBUS0Zs?= =?utf-8?B?UTFFS3ZyVm9KMUNPL293cGhRK2pQZHRMVjBkQ3BuZWlnVnQ0SFd3U0NKVHBM?= =?utf-8?B?Zm1nZWNjSkJmWGdzZ2NEZXdMQm5TNjlVMUYvMVJQdTYwQ1dBWlhWK2ZKV1Nq?= =?utf-8?B?ZG1XMVpRNWRDU2V4Si80SmhvV2Q2UlNmWjhCL2Rjcml0U0pmdVM2SE4yVTkr?= =?utf-8?B?c2traS9ubEozVWFNNHN6MWFIL29NZFlMcXFCaHhyTGRmbkhOc0NNRk5CRmJR?= =?utf-8?B?UUpWR1RYditIcFh4djFuK2J6SURDSy9LL3Z0bTNOOFArdmxuNjN6amlFQ2R0?= =?utf-8?B?cnM0L085TDZFL1BjQnFiRW14MVNOOFVDU3l1cTl2QkFRNHROT1hCbzhwRWhV?= =?utf-8?B?SjdLRjRwRHhnSEhsSnlVY3c4dUV5SFpwUkw5SS9LNXVmTVhNSTErS0pRUkMr?= =?utf-8?B?VW9Mdmh5clRmdU91M3Mwbko0RU4xa0x6OFpUV1RUTXdLYUorUlhURFpWd0ht?= =?utf-8?B?RmY0VU1BVGpwcCt1SER5Mnk2b1ZxRWhWb1V3elo4MmNadEJ4bG5IMHQrVjBx?= =?utf-8?B?T3FZNTIyZlFKd1Y3eHlUUnNXak54Y2NjbTdRWG9Rb3FyYVBHeVBsMmFYdE5H?= =?utf-8?B?eUZhTklwT3VxZE56R29oM1ZnaTU3U2JRLzAvbTlPa0pGVDhlQmhxRDZwZjRW?= =?utf-8?B?NXFTblpxNW1YVXpCNS9VZU5GZHl6dG9PeXE1SmtWbkU2MS9TT3Y2Q0xTUjdU?= =?utf-8?B?a3FNRHlDVGJsZ05tSHIwc21SblhESmxOOUVmRnNyMnV1NFhDVjl3bkpBY2s2?= =?utf-8?B?cXpRdHExa05HNGhUNFBiT3J2VThmUGNrcloxSDdoUERrQ240eUxKVC9wMUVI?= =?utf-8?B?TEJDV2h5bUZIN3ZrbFJVbStKV2tiaG1WRHcwKzVoWUFuNnBJdzV2RnJubWtK?= =?utf-8?B?dDA0N2tHTGp0dm56SkEycDZiZDk4RlVxQlhRZ01GM0VyMFhKV2tvM3J5eWZz?= =?utf-8?B?V3E2VkhqaE5BS3FKNG91WlpYUjgreW56akZ5a2F6SnFSWmFHaUYzQUhSZ21L?= =?utf-8?B?emZVbDJURkthTlVNeGZwckJSV1ZnN3Ixd3FaZmdYZ3pIRjUxeUFKVXBxZ2dR?= =?utf-8?B?MEh1MS9sQnRGczY1RXdTeVpwbkRGQjY0bzZxa2hSbXNJdUo0WmkyMmJxZzlq?= =?utf-8?B?RjFUWnZ4OWFFZU9LangzVnFNT2ZqL29UdjI3a0EreGMrUUVFcDdvQkF4RGFr?= =?utf-8?Q?K3rMim1vC7hFCSdyb2D8OiDcKzl0UYYCqO7Lg=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(7416005)(52116005)(1800799015)(366007)(921011)(38350700005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YW9IQ2oyRWt2ODBUZlZyam43aEpYZ0dmeFFqQ0FGTTYwQWxtUmhjVlU3OTVv?= =?utf-8?B?bUZNZHkyOUtBa1l4VEVsTzlEMWI0b3hzelhPaUhSbDZPTzRQaXJzSkdseGs0?= =?utf-8?B?WklwNnZkSm9jMTFvTkpud2plQytWL2wrTlhjbGUwNWc5SnFqUjVuWVdtNDRT?= =?utf-8?B?ak5ON0pzcnlQK25xZktwVjZjRlBSc3FzVUQ0aWVCY0QwelVPZ3gvWXV4MjRG?= =?utf-8?B?eE8xUGt3cE9iaHphaHBvRGJUYk9sSHRHQ1Ird2trTytQQUpYOUVCQkxrOHBR?= =?utf-8?B?WkNWcWtlNFRReGNHWWR6Ymp6bkhNRHBmUDlrRkY3dkYrdjJ3VHJIZWVFb1pJ?= =?utf-8?B?ZUs2dmIzMEY0ejk2NmdXWGthLzBtdVYwaFNWZnJ5bzk3UTRuVm54ZHdhQ0pQ?= =?utf-8?B?c3EwZHRhMTFJYjB0RTZXbllxOHEyeU5BblJiKzRZMWgzbG1HUWozb3pPdm53?= =?utf-8?B?ZFArNk5BZnExS21wd21rMkgweVova3JUck5zVTBJVnlaTFJlMDJjMFRaN2lL?= =?utf-8?B?d0lrbUpIOE1vemNjaVQ5MmhWWXFWYVEyOWd4QUY1TXZqTnh6bEppZlVIOFRY?= =?utf-8?B?dUtoM1owOE5XWHZwYkRLSEV6dHh3TFVKa1pXYTUxTHk3cGtxUW1KVlFvbTl4?= =?utf-8?B?T0NkOU50VFZ0SzBBcnNZTXBocDN3aVRGeUJVUTZCT1dNZktxSVVpdmY5a2R3?= =?utf-8?B?ZFFZcDFuVDhDcFZpOGh1cCs4QWFvZGNQQWp6WmMxekNEUkpUVXVOS2RoaTZ5?= =?utf-8?B?cXdudFJsRDYzRGRScFdvcGpMSHM2RFo1TFJ6VEZFbXhJMDhqMFQ2M050S2Ew?= =?utf-8?B?RlUzekdSRjFvcjhDVGJ1Z0dYelBRUEZ2YjhDaVJCYWV3N1ZBUkZBZkJMUmQv?= =?utf-8?B?bnBWNnd6WGpTOVIyWm0rWG1CdXBHUDJqQWpKZXhxcVVuUlJIeWx1WlRsc0hM?= =?utf-8?B?STk4bU80SXpPL0w5SnNqV281RU1HTVR4QVV4UXZMeWNLdnpqYmFka29kclhP?= =?utf-8?B?cHFBaGU2NjFuUDlkYU15UlZkbTlUM0FlcXI0eHVXRUkzSXlEcHJxMEdVUytJ?= =?utf-8?B?RTd0SzFDbXpZcVJUQUh0ZkpjaWtENkdMMEw4WS9TL3hrTHNicnJZUUlhWmtK?= =?utf-8?B?TzBLb1QrMlZlbVA0YXROTnlNRmhqSEIxWkhGcFEyeDUwMUZUdkNoeDBrK2xL?= =?utf-8?B?WjFsbmJzTEYyWkRZT3dlUmR4OUw2WWQ0SXNhUk8rNmczSFJwajZjcXlSWXNm?= =?utf-8?B?b1VvQURpZ0h2R2JkRFlIaStkWUR4Yms5RFRwaEFYMndMZ2tOVHB5WmQ2YVA4?= =?utf-8?B?TGxEMmpDcFFMSkd3Y3NHOEJVeFFUaFRQNVVCY0tZQTRKR2ZTYS90VW4ydkMz?= =?utf-8?B?SU5rTWo1THUrRmhXSmNSZFByekllbU9tVnBwRHp2WXltaWMwSlRPd2UxaURk?= =?utf-8?B?cTN0SlgvTUhreVlMZWMrQWM1WkpsU0IrL0UzelNqT3hNUjRmMHVSK2NreHhY?= =?utf-8?B?T0Q3aVg0QzNHYklBdXBOckN4SXNVeU5LYzRBZExjZGlrL2k5cTFxV3ZPdmE4?= =?utf-8?B?ZlZWaTUyTXpRSXdTWlZ3RHYwRlJFQ2RiWHkrbjcwdnRwdmZjNmRNd1RPUEFq?= =?utf-8?B?KzF3S2I4cWtzUHM1ZFhnRTFWQ0xrRnRKNWYzU2twN3JyRWxCeDM2VGJyTitI?= =?utf-8?B?amx1TzE0UFZYUjVJZ2kvVHRQN2s3UWh1VU51YzBaZ1diR1BQRXNUbEFGdU1u?= =?utf-8?B?UHNtaW1SMFFYeEhsRjFDUHVzdWRhOHFoVWtqajBoa3Z3M0hpMEw5MzlZZUtn?= =?utf-8?B?Q01Da0NjMUlwY080TmkxUjYyL3JybVhHc2hGbk51R0FqaVhsdnpoWFM0Z3Jq?= =?utf-8?B?WmpoWmRHQjMvV1N4S1pnczlaWlVEamJSNW91bjNxYzdhajB0aWFkSlRZSEx2?= =?utf-8?B?OUd3cnhnYzBTUjN5TUt6QXliWVFyK2FPVWZSemRrRk5aZGtOc2IxWjBscFk0?= =?utf-8?B?YWlMMlFjeHJaZURNRFBGc3FRcmNmUVhPT1g2OUZJQThveDJZU0w5TVFnZTBm?= =?utf-8?B?MW0zeGQxV3FHTFI4RDBGTE9vRmMyNXFLYUN4YmJhWkhpSGxEZVhrMWtJakRj?= =?utf-8?Q?7I8k0iQt/fuoDXWeOlrrSOcjX?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: a58bc258-71c9-40e7-3d3b-08dc6c3bf1bc X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2024 13:13:09.5321 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: J1GjQsq3v29c4m3/YXAs6Ektsn5bDk3jJgwDKomPp3mvw04yndm2r8RYRPJ3nySNDMLJSkoCImINANayGJ8DNA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8174 From: Peng Fan Use scope based of_node_put() cleanup to simplify code. Signed-off-by: Peng Fan Reviewed-by: Patrice Chotard --- drivers/pinctrl/stm32/pinctrl-stm32.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c b/drivers/pinctrl/stm32/= pinctrl-stm32.c index 978ccdbaf3d3..a8673739871d 100644 --- a/drivers/pinctrl/stm32/pinctrl-stm32.c +++ b/drivers/pinctrl/stm32/pinctrl-stm32.c @@ -670,7 +670,6 @@ static int stm32_pctrl_dt_node_to_map(struct pinctrl_de= v *pctldev, struct device_node *np_config, struct pinctrl_map **map, unsigned *num_maps) { - struct device_node *np; unsigned reserved_maps; int ret; =20 @@ -678,12 +677,11 @@ static int stm32_pctrl_dt_node_to_map(struct pinctrl_= dev *pctldev, *num_maps =3D 0; reserved_maps =3D 0; =20 - for_each_child_of_node(np_config, np) { + for_each_child_of_node_scoped(np_config, np) { ret =3D stm32_pctrl_dt_subnode_to_map(pctldev, np, map, &reserved_maps, num_maps); if (ret < 0) { pinctrl_utils_free_map(pctldev, *map, *num_maps); - of_node_put(np); return ret; } } --=20 2.37.1 From nobody Thu Sep 19 19:38:14 2024 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2045.outbound.protection.outlook.com [40.107.249.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F59B2869B; Sat, 4 May 2024 13:13:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.249.45 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714828411; cv=fail; b=JQYGd/J2iZ3Nql/hzozIRk4E16DUJVPwUNAA3/oLV64plyEj0b6zUESFGBsnd2ZPFxWjEUObcZ/Mbz48vk8ygluoC6Ccjr5OtP3TnhOxl992hKnFnsk/bqgSWaKiU56uqbsOE0mLFc5ZkSAksY6bzKuyRrzojMCoXdGGaiW511g= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714828411; c=relaxed/simple; bh=F+EfADWV2CbYDvWUwfS8uybiJnwFWQ5dJTGce5wgt0c=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=Y6iO2vFqUKYrbr6ymha6wKogSkvnbF2PpBUBRzTWjMyzuY1xP2fbFTa14SBkxxuYo+xlQuT3hRmlTr7b7hUq77NE2MXzxDGixlVc9VLs9aKqti6skCJzIUxCcwFSuUGZrA8aXr/ZTbdTzsokZQg52PJ2Seg6uHGf1/H2/08Whxo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=EPpXBiBu; arc=fail smtp.client-ip=40.107.249.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="EPpXBiBu" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W8dFrHb4e4KL7HwgGceMdwnIPATbwEajoCf0r1L751fG9TntfkojtXEFdwtU3+h4mGisBNyqodX9P/617fvvKWFPWxKVesYpSiNfQ8n/RRhkSVTQR/G4CqrXUZe5kqbNc18EwGKBOT+1RnK8SpANUOyYwY+SEYB4G6SDHCGZzWU8pzS94pMbF3xGWG6I0U1Y/Ik6reegZfH/pLahiWARc/kW1s+u3iYzsC1rwNBokyY+YWDlIXGS8lXQsaXkiRuluFYQu/tKOoN4SjT/5FMPs72IDiKaNoTvOWhm9gEZs1CAFtzVyUqLHFEOiFHuKC8zBN3OvjtFjjADEq70ZaZa2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2P30wZxS8Lt+11rd/nJOtDx2uGO5cN4rLrSAJ1jfCLE=; b=O62izbjHXj+4zdPt7+GiEoTPn8XodB2piI+Ga/xTuqqDcmWL9YM1JeivlJYchx61wb9HDbYxTJLgAgFo78/feSpBITmSsIsQX2uoJDhSRcT6zzZFFHcazvbiyvXEQYS8Aknsm1YD2Fgtg5D7ju3xiiP0MhbXDCDxFyRAUr7g8L8rP1Flxz13XuN2u1BOr8zF2XKrHV35s8AmEKn2fFtROZTMDgax8b0ny/gsVv4roL7RxmNYmvTuEgeMn5UjyvjEDOO+UCObxyNXu7b9BuyuGZTJPIdJO3NFSvTsSEj3lqXZTbU2W9zhsII+airVQrB9JAMhp7lkwyNT4Cu3blGHoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2P30wZxS8Lt+11rd/nJOtDx2uGO5cN4rLrSAJ1jfCLE=; b=EPpXBiBuohwFfGAUtTWvLzMJ2DMt4ltyln5SdZNBx/EDHOeCEMyumXCN8/sG48I8pRdal8qf6VU3jh7h5UhovOLHJgRoiDULw+dFDM21AVVJh135v+SO6E5K4vjpdQfOU1ITVUyr8xhWADRG989kAil8xzzq+wC9G2PYy63kYBw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by PAXPR04MB8174.eurprd04.prod.outlook.com (2603:10a6:102:1c4::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.39; Sat, 4 May 2024 13:13:26 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7544.036; Sat, 4 May 2024 13:13:26 +0000 From: "Peng Fan (OSS)" Date: Sat, 04 May 2024 21:20:02 +0800 Subject: [PATCH v2 04/20] pinctrl: starfive: Use scope based of_node_put() cleanups Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240504-pinctrl-cleanup-v2-4-26c5f2dc1181@nxp.com> References: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> In-Reply-To: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> To: Linus Walleij , Thierry Reding , Jonathan Hunter , Dvorkin Dmitry , Wells Lu , Maxime Coquelin , Alexandre Torgue , Emil Renner Berthing , Jianlong Huang , Hal Feng , Orson Zhai , Baolin Wang , Chunyan Zhang , Viresh Kumar , Shiraz Hashim , soc@kernel.org, Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , Geert Uytterhoeven , Patrice Chotard , Heiko Stuebner , Damien Le Moal , Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , Chester Lin , Matthias Brugger , Ghennadi Procopciuc , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Sascha Hauer , Andrew Jeffery , Joel Stanley , Dan Carpenter , Tony Lindgren , Stephen Warren Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-mediatek@lists.infradead.org, imx@lists.linux.dev, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, Peng Fan , Emil Renner Berthing X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1714828815; l=6725; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=Y9g/ve7R+m3W/e7zIx8b/uEfWQwRmgNvX+GDch7Of5U=; b=3vMnbw9Ysa7jrTpC44efhMT+UFQsFvhEKHMRSieT7F1Sbddy2bEGEc5EfpALwgSvWWAxat145 9aXjF5wEdpVCTILYnh3hhNbtAWkA3LZyCxa8WDZMWvRG7MOlkDt1Wen X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR06CA0230.apcprd06.prod.outlook.com (2603:1096:4:ac::14) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|PAXPR04MB8174:EE_ X-MS-Office365-Filtering-Correlation-Id: 5b5c4df5-44d8-4c73-20b1-08dc6c3bfbe3 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|376005|7416005|52116005|1800799015|366007|921011|38350700005; X-Microsoft-Antispam-Message-Info: =?utf-8?B?K2dmcncvYzBhVU9RQzdhRk5BeGNxTzBiaHlVVjA1MkZSTUFYeGhiUzhZMFJR?= =?utf-8?B?Sk0wdUJoOGI2MDkrZ0dORzltckxJa2pIZUU0YStDRzBpSElpWVpPRU1pL3Iz?= =?utf-8?B?d1FmRUJMa3EwT0Y3eHFQUExMcW4xRVJWcE1YSnhKcFBWWCtWVUc2aVpOV1Q2?= =?utf-8?B?b2NDUWxjc2F5TEdJNjJIbGRXeTRUcSsxNjQ2anh5Yzdydm95UlVoZENWOGRk?= =?utf-8?B?bjFHYitickNuUldOaVRTRGNFemhHVjlsSUlqV0g2Z0tsSHgvTGpKalBsS0NE?= =?utf-8?B?NGFZMCtzTkVtYUI4bzB4aC9iMTVtYzBFalMraTRzbkNnajhPbldGaXR4dXVB?= =?utf-8?B?SzFVbTNXK2szRkVXYzFRQUJNS3VoZXNLdHFnRmRkZDIyVEJEendka3hLRnNp?= =?utf-8?B?T3ViNGwyWG9XUFBnSGdFUkoxM1RZSG9TVmlUNFlnQzVoaXI1YXpLczQ4T3Rn?= =?utf-8?B?NUY1ZFJWQWE0U3JYR3FIZks3QnJBVTJaVmZMdEI1QlhtMDQzZitQQ2JuM3l3?= =?utf-8?B?ZCtvbm5tSlR5RFNBNGduODVKRmR2eVYybGFjcnVuSmsvL2pmNFhaUW1CMFM1?= =?utf-8?B?OTdUZURxanpDcmkvOHhZWWJyeGNycTNFN0dyZlJ1b2FzQW4raGw1QVkxaEI2?= =?utf-8?B?a1pRdkgrQ0dCeVdWZU80TStTdnBBYmpQYXZ6ai9nMGljc3pUYmF4Z0hMV1dI?= =?utf-8?B?NS9paWp6dDB1djRBT2k1RmNoUE5VQ1Qyb0FGcnZRb2ZYNjA4SHNRU2Y2U1Y5?= =?utf-8?B?cDJYMmVFaFhTY29iUXV4TUxWZ0thcTFsaWFvdGNoQnhqa21nUVR3bHZMWnQy?= =?utf-8?B?VUkvc0tFbTRLRkVRbFA4dUtPQ1JIVHZwblZmREh2WERaMkhVUWNkVWd5bFFn?= =?utf-8?B?MHBhTG9FRXViVHptNHNMWnlYZmg0T1FjcGtKMTB3NFNreS9uNTRZZWNhMzF6?= =?utf-8?B?Qzd0bTUyaklST01UNzBCYldEekFwOStqU05qb2hEK2lwaW1XL04vQ2RKUFBo?= =?utf-8?B?TFlaajBhS2Rib1h6L1lWVGJEVWFacGFtZFlKbUhMa1BJT29pRWQ2TkN6MnVR?= =?utf-8?B?eHoydnlmeXZ3a2tOUklMaTUzL0pNaWRXUnNPUkdpbldMRHRCMWNlR0dJZkhU?= =?utf-8?B?YmRYWFJ1eXRsZ2ptTU5tWmxWTUQ3ZityMjRMZGoxQTlhQU9LM0hjcGdIR0xV?= =?utf-8?B?SHBuMWw2VEZtSldTVEFXZ0M1bGxnMW1DUjNjSDNNRUhZOEcvaU5ZakhZM0xM?= =?utf-8?B?Nmh2RXdOUmNnN3llM0RmQXRLandPTXhXMXREK2lhd2RkQnk0RW5QOFh0Q291?= =?utf-8?B?VXYxQzhiV1YvM0dzTk1yS24wVkFpdy83c05aWDM2aXo1bDFROGJIUGdzRzFQ?= =?utf-8?B?OXg4TkNZTmtPcTBORUs2SlU5VnJWZkxVTzJ6L3RsTm1qZUt3emUvTzhScU9M?= =?utf-8?B?ZCtJUngvL3JPaVFMSFROK1pPZktWS3UvSTlVeUMyL1E2RzB4ZGNyU2RLRFpv?= =?utf-8?B?OUdOK1d1UW1FWlAxM01HNGtLTnJBbGNTQ1g3RWdQU0doMk1sb1ZVaFVpdEcr?= =?utf-8?B?WXk5cHJLZVdjU21BWVNVdzM4KzlzSWlIN3dMZG5WV2pEdkp4Y1dHdElJNmpX?= =?utf-8?B?MW53ckFLeWMvYWxza1BWUWxxVjJEbDN4eTZGdS9MZE5UUjBWVmZBZC91TFFx?= =?utf-8?B?YnpOTDNvSS8yUCt0RHZqKzVLWXdQUG9JaldFMDN5NWxkVTlCeEppdGtNV3Rq?= =?utf-8?B?Mldsa0VXVkovZkg2b2NrU0tsM0ZCdWZ6Nkg3UDdjcGJZM1prd2hXcitVeE43?= =?utf-8?Q?WtDpFuauAHUjj4roOv7Z8aHFjl3q8i7IQtP6s=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(7416005)(52116005)(1800799015)(366007)(921011)(38350700005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y21NckFlRUVGb25nNWQzbHJ6R3ZQNXAwbTM5SGtJR05yUHZOeFZzUWRsdjJs?= =?utf-8?B?dVlaNjZYd1RQQnllOXFNUm53VFFZWFpkaVlLSE5HTUhyRmdXU2lXTUJrZExy?= =?utf-8?B?K0ZmU1d4K1NwbnkrNHhrQTRmVG40VkRQNGovSG52ZlZEUGpUMHZMR1g0ZFhP?= =?utf-8?B?by9MTWIrZHY1Qk8xSUg3WlFveTBzUmFJVk91VFJMNmFCQWNiOUdaTEZCTG5w?= =?utf-8?B?YWNlZ1ZBT0x3NE51dVBFcG0zRkcrMk1MQk5YazlHbEZOM2ZSeEU3NzQ0Sk95?= =?utf-8?B?MTJDbFJ0bXZ4eU5HcVRzSWhWak1JNFg2VW9qMDdzYU5ibGVFem0xT0ZyOVNw?= =?utf-8?B?TzhQSFFrMkFNMGV6R2JkdWhCZE9MbzI0cmkvYnNGTmVIcmlCNkV1LzRNSCsx?= =?utf-8?B?ZHUvdUN1SURCZkJDazJ0RHMrUGVJSUo4TjBBTjdhTW5Yc1pYK1V3ZEhzVVBD?= =?utf-8?B?dnp1VmtBMTlHNnZoMHpla0ZmcjJmakZGMmFCZnp6WEFoWmVXZ1JKTUtTSjc1?= =?utf-8?B?WUw3eXEwVmhpYzJZTEhMR1hJODRMVklsaVBKblZ1ZHdXUFZwcVBRUWl3dGlW?= =?utf-8?B?aHJpVHlCRWh3cVR2M1NwK2hLbHU2YTBSQkEzQm5UOTFKK0s5VlM1L2hlM0hl?= =?utf-8?B?MXFyNmFIYkNoVGdEUm1jdzhYb1FMRFNscTE4MWErTU9vRUtDVEFJVnZRM3dq?= =?utf-8?B?SmNjTXF1VmhoMEZ1NTJBYnBZS0ttS0dDalRTVEQ0MlMvc1N0ZUJENDF0dHhp?= =?utf-8?B?MlNUUmh1aUVOZ2hIaEdmNjNsbWZ3Q3djZlkrcFY0WFZMN2ZNUmxHTVc4cDdn?= =?utf-8?B?UTVTbG9XM20xNzR3ZDJGVmpKSVNuM1lFTXNFUlFYeUVmYUcxVjJEeUpNN0x3?= =?utf-8?B?WElpVXBxRmJ4UnozTFpNWDdiOXE3ZmlUZWhXMG9KZFhoU0lWK292bG9LZWtv?= =?utf-8?B?cW1SMnVBNjM2ZFNvUlNYcm1XRlRuMEJSUHV6MHNlTWVZcW5iRDFrVFJtZUVD?= =?utf-8?B?T1JKNmx1QjkrV0NIaGdVSVA5bllyYncrUis5SlcwSUVwYnFDSGw2dEVRNStL?= =?utf-8?B?VjVscXZuM1JZTndDM013QWJtcHh4VlJWQjdhRnkxeTMvaWhUc2FuOXBLSHAv?= =?utf-8?B?V2pQZlBMSlhqODNkK2E3VEl5bG9SRVZwUkt4TzlpUjlrK0VXc3RYTDZWRDZV?= =?utf-8?B?cjA5VTZtemYzVGtLbnFGYkc1QjBsMTdBNFVZNGVvS0xodko5VENhVlJQckhj?= =?utf-8?B?QkN5bXh1bDhJVEJQMjNBMGROYVB1ZDNtSFVtOCtybHlTZk02RkJFeHM0ZmVp?= =?utf-8?B?eS9iUVBzNWtXZzdzTlpuTVNYNjRncmtVK2xLMVlRT1lYK1JWWnArUzRjOEQ3?= =?utf-8?B?VTgycm9FRGE0ZUdLcjZyRmVWT2p2OGJnVXdaZXViRjBBelR1RG54WWcxaFR5?= =?utf-8?B?cUlQNzUyRWhGU29LUmRnVHhpVUFuVGlDOVRoU29iTlpueFRQUkY5bER6b2pR?= =?utf-8?B?Z3FndHBaTGhSU3p3ODBjc2p5NWVwYWxYUEkvR3FaaXB3QUppUFRnQlRkREtC?= =?utf-8?B?L1N2WTdKL05zZDI3RURWTmpLVFhBMnBXRDdwclZZYnlJK2twWHhpYmhDUEFW?= =?utf-8?B?aXFqanlwbDJsR0FwRkpkQlVEOUJtK3JsR0xKeEk0cmg5c3A5cHlxdmU0Z2hB?= =?utf-8?B?dkhwaCsxTVBLbzJvWEtha3FrWVJkUUdOdWVyVkhmd3dBeExabVZFTEVGRW9S?= =?utf-8?B?dDl4dVVoeERTNXZ4c3dCd1RZQzB3YnIwNnRhK0EvOWRYZklnak8yb3FTbVIy?= =?utf-8?B?alNxaDRmdkhnUUZ4bEJZdjlkYUYwcm50ZHpsalRsWGcxS3VNQkdkQkxiL1k1?= =?utf-8?B?Q0xDZnVXQkNGQlhySnhpZCsyOWNOUjdidE13L1NxT2xKRzZVOEM4NGVVMnlz?= =?utf-8?B?S0xXcXFjQVZNdGlnMTVhRnpOd3NjeHI5L2IrcDFYejFINXVUeVByTG4vZm5x?= =?utf-8?B?aFNnbDVGcUFjbllteFlQVFRjRTc2aW9HTktISkJCYVM2T0Fxb0NORXlJWlJw?= =?utf-8?B?Qyt1eHg0OUtIeEhUSm5kYWNZRGxmVE54ZGNDbkh6dWlMMnJ4TkRaWHRoREg0?= =?utf-8?Q?qtOAYpv32DzYh9COHf/VGFMxv?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b5c4df5-44d8-4c73-20b1-08dc6c3bfbe3 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2024 13:13:26.5554 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IsKCV3MzsPaHV6FuLQIUwE1z3AlbnmuFE+6k6bOen/PYAptY1ACmRlUrV16UCorDIjT5k+tijSoDho+Qyfas5Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8174 From: Peng Fan Use scope based of_node_put() cleanup to simplify code. Acked-by: Emil Renner Berthing Signed-off-by: Peng Fan --- drivers/pinctrl/starfive/pinctrl-starfive-jh7100.c | 27 +++++++++---------= ---- drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c | 18 +++++++-------- 2 files changed, 19 insertions(+), 26 deletions(-) diff --git a/drivers/pinctrl/starfive/pinctrl-starfive-jh7100.c b/drivers/p= inctrl/starfive/pinctrl-starfive-jh7100.c index 6df7a310c7ed..27f99183d994 100644 --- a/drivers/pinctrl/starfive/pinctrl-starfive-jh7100.c +++ b/drivers/pinctrl/starfive/pinctrl-starfive-jh7100.c @@ -480,7 +480,6 @@ static int starfive_dt_node_to_map(struct pinctrl_dev *= pctldev, { struct starfive_pinctrl *sfp =3D pinctrl_dev_get_drvdata(pctldev); struct device *dev =3D sfp->gc.parent; - struct device_node *child; struct pinctrl_map *map; const char **pgnames; const char *grpname; @@ -492,20 +491,18 @@ static int starfive_dt_node_to_map(struct pinctrl_dev= *pctldev, =20 nmaps =3D 0; ngroups =3D 0; - for_each_available_child_of_node(np, child) { + for_each_available_child_of_node_scoped(np, child) { int npinmux =3D of_property_count_u32_elems(child, "pinmux"); int npins =3D of_property_count_u32_elems(child, "pins"); =20 if (npinmux > 0 && npins > 0) { dev_err(dev, "invalid pinctrl group %pOFn.%pOFn: both pinmux and pins s= et\n", np, child); - of_node_put(child); return -EINVAL; } if (npinmux =3D=3D 0 && npins =3D=3D 0) { dev_err(dev, "invalid pinctrl group %pOFn.%pOFn: neither pinmux nor pin= s set\n", np, child); - of_node_put(child); return -EINVAL; } =20 @@ -527,14 +524,14 @@ static int starfive_dt_node_to_map(struct pinctrl_dev= *pctldev, nmaps =3D 0; ngroups =3D 0; mutex_lock(&sfp->mutex); - for_each_available_child_of_node(np, child) { + for_each_available_child_of_node_scoped(np, child) { int npins; int i; =20 grpname =3D devm_kasprintf(dev, GFP_KERNEL, "%pOFn.%pOFn", np, child); if (!grpname) { ret =3D -ENOMEM; - goto put_child; + goto free_map; } =20 pgnames[ngroups++] =3D grpname; @@ -543,18 +540,18 @@ static int starfive_dt_node_to_map(struct pinctrl_dev= *pctldev, pins =3D devm_kcalloc(dev, npins, sizeof(*pins), GFP_KERNEL); if (!pins) { ret =3D -ENOMEM; - goto put_child; + goto free_map; } =20 pinmux =3D devm_kcalloc(dev, npins, sizeof(*pinmux), GFP_KERNEL); if (!pinmux) { ret =3D -ENOMEM; - goto put_child; + goto free_map; } =20 ret =3D of_property_read_u32_array(child, "pinmux", pinmux, npins); if (ret) - goto put_child; + goto free_map; =20 for (i =3D 0; i < npins; i++) { unsigned int gpio =3D starfive_pinmux_to_gpio(pinmux[i]); @@ -570,7 +567,7 @@ static int starfive_dt_node_to_map(struct pinctrl_dev *= pctldev, pins =3D devm_kcalloc(dev, npins, sizeof(*pins), GFP_KERNEL); if (!pins) { ret =3D -ENOMEM; - goto put_child; + goto free_map; } =20 pinmux =3D NULL; @@ -580,18 +577,18 @@ static int starfive_dt_node_to_map(struct pinctrl_dev= *pctldev, =20 ret =3D of_property_read_u32_index(child, "pins", i, &v); if (ret) - goto put_child; + goto free_map; pins[i] =3D v; } } else { ret =3D -EINVAL; - goto put_child; + goto free_map; } =20 ret =3D pinctrl_generic_add_group(pctldev, grpname, pins, npins, pinmux); if (ret < 0) { dev_err(dev, "error adding group %s: %d\n", grpname, ret); - goto put_child; + goto free_map; } =20 ret =3D pinconf_generic_parse_dt_config(child, pctldev, @@ -600,7 +597,7 @@ static int starfive_dt_node_to_map(struct pinctrl_dev *= pctldev, if (ret) { dev_err(dev, "error parsing pin config of group %s: %d\n", grpname, ret); - goto put_child; + goto free_map; } =20 /* don't create a map if there are no pinconf settings */ @@ -623,8 +620,6 @@ static int starfive_dt_node_to_map(struct pinctrl_dev *= pctldev, mutex_unlock(&sfp->mutex); return 0; =20 -put_child: - of_node_put(child); free_map: pinctrl_utils_free_map(pctldev, map, nmaps); mutex_unlock(&sfp->mutex); diff --git a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c b/drivers/p= inctrl/starfive/pinctrl-starfive-jh7110.c index 9609eb1ecc3d..4ce080caa233 100644 --- a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c +++ b/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c @@ -150,7 +150,7 @@ static int jh7110_dt_node_to_map(struct pinctrl_dev *pc= tldev, nmaps =3D 0; ngroups =3D 0; mutex_lock(&sfp->mutex); - for_each_available_child_of_node(np, child) { + for_each_available_child_of_node_scoped(np, child) { int npins =3D of_property_count_u32_elems(child, "pinmux"); int *pins; u32 *pinmux; @@ -161,13 +161,13 @@ static int jh7110_dt_node_to_map(struct pinctrl_dev *= pctldev, "invalid pinctrl group %pOFn.%pOFn: pinmux not set\n", np, child); ret =3D -EINVAL; - goto put_child; + goto free_map; } =20 grpname =3D devm_kasprintf(dev, GFP_KERNEL, "%pOFn.%pOFn", np, child); if (!grpname) { ret =3D -ENOMEM; - goto put_child; + goto free_map; } =20 pgnames[ngroups++] =3D grpname; @@ -175,18 +175,18 @@ static int jh7110_dt_node_to_map(struct pinctrl_dev *= pctldev, pins =3D devm_kcalloc(dev, npins, sizeof(*pins), GFP_KERNEL); if (!pins) { ret =3D -ENOMEM; - goto put_child; + goto free_map; } =20 pinmux =3D devm_kcalloc(dev, npins, sizeof(*pinmux), GFP_KERNEL); if (!pinmux) { ret =3D -ENOMEM; - goto put_child; + goto free_map; } =20 ret =3D of_property_read_u32_array(child, "pinmux", pinmux, npins); if (ret) - goto put_child; + goto free_map; =20 for (i =3D 0; i < npins; i++) pins[i] =3D jh7110_pinmux_pin(pinmux[i]); @@ -200,7 +200,7 @@ static int jh7110_dt_node_to_map(struct pinctrl_dev *pc= tldev, pins, npins, pinmux); if (ret < 0) { dev_err(dev, "error adding group %s: %d\n", grpname, ret); - goto put_child; + goto free_map; } =20 ret =3D pinconf_generic_parse_dt_config(child, pctldev, @@ -209,7 +209,7 @@ static int jh7110_dt_node_to_map(struct pinctrl_dev *pc= tldev, if (ret) { dev_err(dev, "error parsing pin config of group %s: %d\n", grpname, ret); - goto put_child; + goto free_map; } =20 /* don't create a map if there are no pinconf settings */ @@ -233,8 +233,6 @@ static int jh7110_dt_node_to_map(struct pinctrl_dev *pc= tldev, *num_maps =3D nmaps; return 0; =20 -put_child: - of_node_put(child); free_map: pinctrl_utils_free_map(pctldev, map, nmaps); mutex_unlock(&sfp->mutex); --=20 2.37.1 From nobody Thu Sep 19 19:38:14 2024 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2040.outbound.protection.outlook.com [40.107.249.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45362383AE; Sat, 4 May 2024 13:13:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.249.40 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714828428; cv=fail; b=e14jzCFZJfCE4bGMpbDXHtXxlIrE3zxhus/u1gc87zWOKtQyBL74vF/CMBTKKIhMUTcFbgGC1uaOY2L7eQM1PdfzgDUgM/+L8UJqntK8LZUNlUL0dhyiLLSzj5QRxeuHzxoDiI5pmgMnzwW64q3Ejv78a5Q8OFfbeBl0yH2OCpQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714828428; c=relaxed/simple; bh=8+3VXwLUrYD3nDfOr7HntPuhh41zJEyci3faFCn1b9g=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=L/wk8ifc/hMxW94EZ2cRcMIiB7w3RTYlO4eCNwjSrL1Q3HjmkxxlfyoW2WvZ+T8Kd4f+lMMSmI10M1Mfg725uwnEWiHMQH13Lw5p3UF1VYP3HGWrklh0I5f5az/Bh8Sta6qy4f31dM6DkgASNdFwvqZfh10vDzLKyffccnuWN68= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=NpK/lcod; arc=fail smtp.client-ip=40.107.249.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="NpK/lcod" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZEjKrZo35vprb+ulRKgA5XEBXHoWfX08dfs+rfUGfxW0PsNaNSU9X++A0D91rq55txf6Zy4S4ePWFyc3OH82pZbecy7zdz7TQC7fBUgYQcgPAO7Q3IrNPuR9YSP7nw8jtNStd/k8cZXy7gFXjRR990xlCjeastrPzUx7wQ8z4Vyz2vO1Eq5DpKinHWAYdVbDIJws0noJf699InJsQBHFd9+kvwCiPaoFVx/lluCamNaECO4LCyNpV0YvyHioneC+69uXv90rVJuM4ZtfC6HbwLccnV8tt1fEXn/Z8aD1bdmXDcBmh0tKeQX9tGTkLtESbvGMP3WyPY5LLbLDbSQ2sQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wlbn/xB/PZwPV7ROj5DqSEALVDss+DndXNnPfNwAESg=; b=IpRShFXqryoEfTWHOcp1CIk6OH6s0zqw6wy9MuhFPbdKWLEcGix0ULHFmGU9yaQCohNtVQtwHDMyceNi6KhS+hQpo/s+Chi4ZII9dJ2p8Zk/ItIfMODcyWvD4kQlaiFlSl237zSxkn/KWkkWUgbCkvwYuxDVH4d+f+IBu3BeilfYqQhoDFcEI4jfy1fVOvpPbdVboWQlXCIIMI4c37exFBI1IyMV4Rrt8At9gyOXWdHgvKk0h2ACW3ANF/2IWzzn+e7HI6zDdB6ZiqLI4NNUNjafCqWulT0cqU6iXvfYw1jgXJB83eb6u8Dvr1NOER0e5eLy1yDLjCIBwpzBP0E2UA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wlbn/xB/PZwPV7ROj5DqSEALVDss+DndXNnPfNwAESg=; b=NpK/lcodQ9pE5BbJNbhQk3YjH5Nhyb1JmDwtplCNwBMtXa1WcgJG0yq/JeQCSa8Mi+kNwkwFW2xk+0BZq+jFo54RLX+6FZWwJajiEHumfZuG9ozhKXVpQS9IfB03auLP+qXSrU6Nn0lrmX0rES7yPc3mbezMfUNTvvJLmgrVtSM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by PAXPR04MB8174.eurprd04.prod.outlook.com (2603:10a6:102:1c4::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.39; Sat, 4 May 2024 13:13:43 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7544.036; Sat, 4 May 2024 13:13:43 +0000 From: "Peng Fan (OSS)" Date: Sat, 04 May 2024 21:20:03 +0800 Subject: [PATCH v2 05/20] pinctrl: sprd: Use scope based of_node_put() cleanups Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240504-pinctrl-cleanup-v2-5-26c5f2dc1181@nxp.com> References: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> In-Reply-To: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> To: Linus Walleij , Thierry Reding , Jonathan Hunter , Dvorkin Dmitry , Wells Lu , Maxime Coquelin , Alexandre Torgue , Emil Renner Berthing , Jianlong Huang , Hal Feng , Orson Zhai , Baolin Wang , Chunyan Zhang , Viresh Kumar , Shiraz Hashim , soc@kernel.org, Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , Geert Uytterhoeven , Patrice Chotard , Heiko Stuebner , Damien Le Moal , Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , Chester Lin , Matthias Brugger , Ghennadi Procopciuc , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Sascha Hauer , Andrew Jeffery , Joel Stanley , Dan Carpenter , Tony Lindgren , Stephen Warren Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-mediatek@lists.infradead.org, imx@lists.linux.dev, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, Peng Fan X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1714828815; l=1540; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=BMqLHOrX8EQjg9Z3uUGPLv8QrQVTIzjrj8QOQ3y5znM=; b=Ugm0fFZvckU11/gZlb9LPokzX1/XETwbD8kMAjOF5h1wfoVm6mH4BII4a8+jjdOKtEdnq6kb6 jei5lzvJulvAYZ2W6id9lnxq2Oa6z3vUfHWLegACPLLaaZYeJIhnMjE X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR06CA0230.apcprd06.prod.outlook.com (2603:1096:4:ac::14) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|PAXPR04MB8174:EE_ X-MS-Office365-Filtering-Correlation-Id: ae48280e-1957-4ec4-2bf4-08dc6c3c05d4 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|376005|7416005|52116005|1800799015|366007|921011|38350700005; X-Microsoft-Antispam-Message-Info: =?utf-8?B?YlR0UUJmS1IzU0J4VTdPMVAzV1dmRG54RzZHUzlid2RHK0t6UnBHLzBncEVH?= =?utf-8?B?NXRNc0lHbDFyTlVKN3QyWnFzcE9HZHZocHBRWlFDZU9vSW8yV3FZdEdXMGI4?= =?utf-8?B?NU1KRzRuZFc2S0xiV1d3bm9jUGxvbDlZMVpPOVp4MzYxTVpJMkpkUGpVM0Yx?= =?utf-8?B?bkE0bThTRFJLUksvL01QQTFYU2NiYUsyL2J4YjRpSjgwZ1Yxa2hvZjVDVVRS?= =?utf-8?B?cmJFdHp0SDF1WkRqTGZTSk9oVlVMTUJBYjB3dGF5MHBjSGVzRmRvcFhXY1F0?= =?utf-8?B?dERzTVJpS0U4UFpXU1QxeVI2U08vaWhSUkkzMThSWElTRzczSzNXVHpiY3ls?= =?utf-8?B?Rk5mTk96cTYwZ09sbVFndElONVFsbVBDTGs3R2Y1RkNWaDlJY2dzWENaUEh2?= =?utf-8?B?RnlIMTJVdWQwazRWZGhEVWMrTmlqOUNtMm0wbHY0Wms2RTdaVXgwZGl3WEFn?= =?utf-8?B?cGVYMEFHS3hTazlyaGNtRUxtUzFpZDVaaThMelBDWXVGeEN0enZvczY1dFVz?= =?utf-8?B?RGg0Yk9aRnZyemF4S0NLR3RFZXMxai9GclRHbFhsMnZuMnQ4VlpmQUlwajRk?= =?utf-8?B?bG9pWjRjalpvUnQ5NmY2c3U4UHdNMEo0dG9LS0JtdVlHOUdES0ZBMTZQUW10?= =?utf-8?B?clhiQmtqMW16ZnBTK3dvWDE0QUIwZzVLdlVIR2lFclFZZ1pNb3dHYlViRFk1?= =?utf-8?B?OERGN3lJVlVNSU1SM3JNc0tOY09qQlEyM1lDQml4UVgweDZNMWNxbHFLT0s5?= =?utf-8?B?Y3owVzdnZGR2OHM0a0s4QzBtQW16czZOMmZKVXIrQnFDK0hPQ1FENTVoWUxQ?= =?utf-8?B?dk5xN3BpQWE0QlYwNGprWjJWSFZwd2d5eFJyY2Y4c1EwN2pGWngraEVLZXpl?= =?utf-8?B?a2FOZzNLUjZ5amFKcFFXeXhqRWZmWi9wSVVsaXc1bHFEOHU4aCtOckZPVTQv?= =?utf-8?B?VFA0djB1MUc1MnVsdzVBVGlrem9nUlZVZ2F6eFJPUmhiUzk5TTVNVlR3T3Bp?= =?utf-8?B?TVZHMXNhUnExSE1wMkxKNGRDQ1lpQm5PNlp6bTMyeERBSjVETHR3bUh5dlFh?= =?utf-8?B?MVlTb2dSemRiZm52MUZzYi9lQTBOUEY1UytvenNLYkFRQ3JyL2ZxT0djRm56?= =?utf-8?B?YmtmaHVTYXl6b2pWLzJ0RGxFdFliT0p4S2lzSWlpZW5heTh2anhQZURLQjNV?= =?utf-8?B?SHJBdXVNbSs0WkM4MzQ1MXU1VEVSc2dBSmUxcnhCS2RpNWQ4WU1kZ2diMFZw?= =?utf-8?B?RnBFb2hBOVprWmRZUXVxWUkwdGRMdmNiZmtlU2NVS3ZOOGFBMjNFUXBkVkMr?= =?utf-8?B?TVN1T1NCVnM0TERQMXF4bG9QdG5Sd1UwNUs0NktScXMzc0JkcHdsSVdBdEhX?= =?utf-8?B?VWFSWGtLa0luNk9RV3IxeFVhNEF2RXYrZ0VjcnFiUFVkQUkrSTI0SFZ6ekNy?= =?utf-8?B?eUNqdTB5ejdJdHEyRFhJeDZzR2VDdDVQZldZYklnQWZSR0V3WmhsanRHRkxR?= =?utf-8?B?b29jL1BzaWRveHNhM1RBUHBSUVZZQ3FJUDBRNGFaZmpXazArU25jSWozNEM5?= =?utf-8?B?UjlXU09YeFpnR052amtUM3dBaGxJMUxGWEtlMlJIY0dBQ0pjb1V3UWVtZS9v?= =?utf-8?B?Wkx0S3JxTGNHNFE5U2Q2d0o2dXNhc2tOUHpSNmxGbmVFVXdxMEd5MEkxbHc0?= =?utf-8?B?UTZrd3lweHRMei84RHVpTy81TG9FQ1J4WGFVNFQ4dEVpVytSR3RmcVp2NkVy?= =?utf-8?B?YW9QRzB5VVRoV2xZNmsyb0hhcTRtcVpldEVTa1ByOXNaS1J1N0Q0ejZWNjdE?= =?utf-8?Q?RGjTow0l8Koi2XeQGjRkSP1bAuF9+W/v3yXEw=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(7416005)(52116005)(1800799015)(366007)(921011)(38350700005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K1I3M05jWUw1SDRETVQ2cDVTL2dCOS8raXhYcW9Cc3Z0S0xDU1ROWTV4U2pB?= =?utf-8?B?cHg5VTZTWGFCZVRuM0pEODNmVEFzTzB1MXd6Q0YxNWJDMTJVaU9KbTRKWkpk?= =?utf-8?B?dWVaaE5Cc3BQN3E2YmpuZDhFazVqZ3c1ZkFLVW5OU01ONGhFYWJBaVhENHU0?= =?utf-8?B?am1wTHpxVzNqVjg4b0JBTnhtZjZuUnlPall4bm5oRklLMll6SU1EL2t6ZlhD?= =?utf-8?B?bGg4MGRGcGZMU1NCWEV0SGxxdE1PTXBXcFFuRkpKZDhGejFnWFNibHMvTnAw?= =?utf-8?B?ZVpLSllUVVUyVFF5eS9LdlkxbnlCeERsaHRLRlQzK2prNDA1VjlBcHJZL0lv?= =?utf-8?B?SlY3MjQ3a2kwSlJKdkk0RWFkSjNsOWFZSmwvelRVMkpCREh5Um1VYjRkV2JW?= =?utf-8?B?MmdNMDRNV28wakZvWWxPeTdrcVJndW5CdWh2anc4am05RmdhUUw5UkR0UDVv?= =?utf-8?B?dExBQlJOMWxVVm9LdVlWaWEzZGJDWDhwUnpRcThyYjhhS2liZ01Bend3VnBo?= =?utf-8?B?cU5JbFJvcmZDMkt4dHQvT3hpa05HdldGTENDcTJQeStJSWdCZ0JwMHgvbnRV?= =?utf-8?B?Y0dhSkN1RDNKS3VMYjgrVDV1YW83UG9IeG9rTVJ4TDhuNFhCcGxna0pEdFdU?= =?utf-8?B?NmlhMDR0MjNKV0pKMzdhN284OVRGVTFhVmljQkFrZjltbG12QmNSNnBZQWFi?= =?utf-8?B?ZmpwaHpndE54SW5VQ3dsYXJiZ09jeXBpWmJncHhxZHkyaGpLR2lHamZiQnd5?= =?utf-8?B?M2llT0Fxb1pVRGc4cUhFQlBPb0RsZFFkdWN5U2hLdXpNQkxkaGkrMHFLK05v?= =?utf-8?B?L1FGVHBRVXU1NmlyWm4vdXpsZnJsNEViK0V1YXVIY2tyRjNJK1dWZDhWWTlr?= =?utf-8?B?Q1VMclRmVms5dDNXRzdMc0NIdVB0VElPbk5TNWYvYnpzbWFXTklPM0V0S3Zt?= =?utf-8?B?MlRXOEN5UDBlcS9vb2Rhdm1XQm9qc1BIQjFoNDhQM1l2L0ZQSDRzNHFCS294?= =?utf-8?B?TU56dlZ3Zm1DOXdCZCt0V1dXdzZ6eDVwWEJtU3dQNFh3c1NqSzhXZGZ5cFI0?= =?utf-8?B?dXpEeThNdS9aM2lWVUI4d3NYWUFPcEY1bHBybEJYYjVWcklON2NrMmpoRjFy?= =?utf-8?B?OTlmQmwxNlN5YjRnNWR0d05LM3hCem5kSlozNHFpakZYZGZteHFDT0tpQncx?= =?utf-8?B?ZEwrMlY4VDVNenUvblNmT3pSeXRYMGVCNGVCZURUSjVsa3lBVUM1WUpCb1J0?= =?utf-8?B?KzZOMCtjdXEvNlhsYk1YR0RvQXhaaVpJOUMwb2dLZkNPSktBdzRra2YyaldC?= =?utf-8?B?UWFGb1NsbEhVWmx3cHNMVTMvUGk1Z2d0bFJpcnNYeThDZEFkTEh2dTVxRmJR?= =?utf-8?B?c2kzdmtQUFQ1TXJrN0xpLzV3blFnVitZV0xtdmVlYzZVWEhSYkNqWllna2J4?= =?utf-8?B?UGZnbUtOa1Jqbk5XWS9WM1c2djFZeGVUVFFOZjAxeHhicGdDV2UrMGJWVW5x?= =?utf-8?B?UVl5RHg3dUJtcmxPN3lBVWZnQklHU3lDQ3F4L3V3RTBmRjZBWkF6NW5vV0VR?= =?utf-8?B?L3lKVUwxMkpiQnRkRTA4VklsYXRSeUphK09lbWVhMWxVbHdXL3FmSVBIeEdR?= =?utf-8?B?WjNpVEJac25yQXpaUEQrNHRkUkNxNWZObExEcmo4TG9NQmhUeVcwUGorbUlT?= =?utf-8?B?Ym81SVl4V3JMK0FrWTg2SVhVQXVmOUVqRmNyemJtRW9DVlZpVU5sVzhtaXN3?= =?utf-8?B?SjJWNGZjZ3dLdFRPOStyUlpuVWhmQzl2R25XWXZmdzczQytlRXJzd0NkQmFi?= =?utf-8?B?RHJEUnZxRXh6Z0FpS28rUWF0S0V2cyt6YXdlZzFWNWhIV3ZUUlpUeFRsV00x?= =?utf-8?B?MTBpNlpkZkEzNWtLcWpiZnl4alNoVmk2WUVlWkZJZW9mbVZuQVdyaHZPZGhI?= =?utf-8?B?R3I0VXVTVDdXZFY1UTZEKzI1STBVcHltYnI4YkxMN2hBQWJEcGxaMmx3VTVa?= =?utf-8?B?OFliUlR2dXRLWm15N1UvR0RJazVSRzlxdjNuV1JvVTlYUk1VZ1hxWWxSaUFS?= =?utf-8?B?ejJ1NDBoaThodENIb0RDNGlJVkdBaTFia0x4dGt1K0tpTTV4VXdXTDM4ckFE?= =?utf-8?Q?Vr0BaQNkVughI8/WS0Bc8JzhX?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: ae48280e-1957-4ec4-2bf4-08dc6c3c05d4 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2024 13:13:43.2390 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xBz/wo6jszy9seIjpFniB9zAk6LmJZ++0AvHsX+MUpveQib2IRf6H7bVmdHZ7jXUcpz7/Ua5/Cme+TomydhrMQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8174 From: Peng Fan Use scope based of_node_put() cleanup to simplify code. Signed-off-by: Peng Fan --- drivers/pinctrl/sprd/pinctrl-sprd.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/pinctrl/sprd/pinctrl-sprd.c b/drivers/pinctrl/sprd/pin= ctrl-sprd.c index d0b6d3e655a2..c4a1d99dfed0 100644 --- a/drivers/pinctrl/sprd/pinctrl-sprd.c +++ b/drivers/pinctrl/sprd/pinctrl-sprd.c @@ -934,7 +934,6 @@ static int sprd_pinctrl_parse_dt(struct sprd_pinctrl *s= prd_pctl) { struct sprd_pinctrl_soc_info *info =3D sprd_pctl->info; struct device_node *np =3D sprd_pctl->dev->of_node; - struct device_node *child, *sub_child; struct sprd_pin_group *grp; const char **temp; int ret; @@ -962,25 +961,20 @@ static int sprd_pinctrl_parse_dt(struct sprd_pinctrl = *sprd_pctl) temp =3D info->grp_names; grp =3D info->groups; =20 - for_each_child_of_node(np, child) { + for_each_child_of_node_scoped(np, child) { ret =3D sprd_pinctrl_parse_groups(child, sprd_pctl, grp); - if (ret) { - of_node_put(child); + if (ret) return ret; - } =20 *temp++ =3D grp->name; grp++; =20 if (of_get_child_count(child) > 0) { - for_each_child_of_node(child, sub_child) { + for_each_child_of_node_scoped(child, sub_child) { ret =3D sprd_pinctrl_parse_groups(sub_child, sprd_pctl, grp); - if (ret) { - of_node_put(sub_child); - of_node_put(child); + if (ret) return ret; - } =20 *temp++ =3D grp->name; grp++; --=20 2.37.1 From nobody Thu Sep 19 19:38:14 2024 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2068.outbound.protection.outlook.com [40.107.22.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBE262D058; Sat, 4 May 2024 13:14:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.68 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714828445; cv=fail; b=K71+/2QVqCxiL9jHW4ewZ/iIXDcU/TcBEnTfIaG6/NnYGIS7cXj29BM4zLw2LrA66B3SWuz7CzQVlh7oKuHjuyeFj7V/4Hpp7nuc1r/xxMrc+JKdAhga8Ij82oqut0GwKpxyIR/96zj/ZKNcxhCu8amo3el1KG4MUli9XDppmNg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714828445; c=relaxed/simple; bh=OInO6yAg14U2A4TIttQDy/mS0VvP7xhIZA0f8KUS5dk=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=Q/PervaaOdNx1hxFuWunhL0wwFOs9vyT3ePpuYKlVzI/x3l1urrhJ53oXL8KvxCGmTcT9fW8hllizBTh8gw7Ry+7paqNOfI9npN0MxVuAsyj4HMDqAiokVsEHxfouPXWlMNoNN/J7PhIjZlBmvov5i1Q5EKFFJIVjJahEQERshI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=K9HoFs+8; arc=fail smtp.client-ip=40.107.22.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="K9HoFs+8" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BB++BuCWovknZieJLe0ezXwJ+LlNNUJmOh0r5XrnwAwWqL9Hl8BKUM0C1XizqtjYZfZ0i+bX5qH2cv/biMOHoFZfdjxbjDDKaGwbGOEPf1+IEnCLneloZqj0Jfpk7hNcEFVo1Yr39KkUcd8NAwWmbp6oKWLA2LvtQ8EfgcZd8cYg8xeV0LUBUUOkt3FoC2GUyBsVqSZNOE0XExVjRQkd6RC+joEfrvaxBYs9aKd5wlylLZNXITXpAF3nHYZKHlIBPD0EevH7lE2F0rIbmam7K+ZeUxgJkrZwhh01QyD+qBT41Smn0I3+pq1mVBkvLLqKX8M49lpF9HY4ADjmZdX5JA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Eig9P6zNNvksUOs0mChTICwLK4o4MZg7g2lLrYGu3MU=; b=ZmFpipRA/d0vqDXvfI9t2oC+JpQwtgSv3XbrgR6cvNx9nIZBw60DisGv1ZoNEkio6wqCcHPrpGcw+J6e/JtxkGU9mWcbYR+OyORhMgz0tI+G2p2uZPpyIqJjMH6IwEv8+zIQZb/tjOAfpqPCbenJPKDPneP2+gQeqimhb3fDzspZNZpMJSIhbca0rKMq6r7GpAnOoLDN2ssRp9kaiWoVK3Q+rnj0Ph0r1NZBS7ZqBZc0ug7hhBF4OHZ1dFVAfetlD2YqudsOGFYdL5cbwD997ZgQJIe5/ETDjVZWS9sz6fU+kqHQwF0KEwQQAvR/rbAcryerI8aZdLy2tLxWwCA34Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Eig9P6zNNvksUOs0mChTICwLK4o4MZg7g2lLrYGu3MU=; b=K9HoFs+8inZwiLNq5Z6MwNjq7DYsbc8JTeDqn/VxH2PSLW/7PNxhcix9EnzKWVNkwzRETbUqiIwcU4dbsWNglLL+0n+O7EcO+MsssmI20feQ0DIJuT+FAKpwdmWX0s03dV+f9DS7nr36WsAprRd03x2hSVbg/RedEz8stpoDajc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by AM9PR04MB8633.eurprd04.prod.outlook.com (2603:10a6:20b:43c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.34; Sat, 4 May 2024 13:14:00 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7544.036; Sat, 4 May 2024 13:14:00 +0000 From: "Peng Fan (OSS)" Date: Sat, 04 May 2024 21:20:04 +0800 Subject: [PATCH v2 06/20] pinctrl: spear: Use scope based of_node_put() cleanups Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240504-pinctrl-cleanup-v2-6-26c5f2dc1181@nxp.com> References: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> In-Reply-To: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> To: Linus Walleij , Thierry Reding , Jonathan Hunter , Dvorkin Dmitry , Wells Lu , Maxime Coquelin , Alexandre Torgue , Emil Renner Berthing , Jianlong Huang , Hal Feng , Orson Zhai , Baolin Wang , Chunyan Zhang , Viresh Kumar , Shiraz Hashim , soc@kernel.org, Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , Geert Uytterhoeven , Patrice Chotard , Heiko Stuebner , Damien Le Moal , Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , Chester Lin , Matthias Brugger , Ghennadi Procopciuc , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Sascha Hauer , Andrew Jeffery , Joel Stanley , Dan Carpenter , Tony Lindgren , Stephen Warren Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-mediatek@lists.infradead.org, imx@lists.linux.dev, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, Peng Fan X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1714828815; l=1599; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=gLxq6qceZG7Nsihhv4/AWrdppvVafau2eKIInT5INMM=; b=5ffTl8ZtioLSYaaZNjD41K3m0KxkH56uyb2/IQ3LQ/eLhFTIgJ+z+teWheN9sal8KHmc+TJHg AnbJfBYdZnCAlHsBRS1fxFEmq8MQgiKr7ur+z8H1JXy6MJM4yebyMux X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR06CA0230.apcprd06.prod.outlook.com (2603:1096:4:ac::14) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|AM9PR04MB8633:EE_ X-MS-Office365-Filtering-Correlation-Id: d6598716-c0c4-479f-c7a2-08dc6c3c0fe3 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|52116005|7416005|376005|1800799015|366007|38350700005|921011; X-Microsoft-Antispam-Message-Info: =?utf-8?B?djRRUUQ0YXJxcDMyNHh3RXUwSTNYZW5YWUZ5dXc0NGpGNHk4Q1hiZWt0SWlh?= =?utf-8?B?KzRlZE1sb2V3Z3Y0SmlqM2N2RHA2NzJRR2FodHF6RzBOM2hCWTI0SlhWYWNQ?= =?utf-8?B?aFNBMG5rWXlNbks5WVc4dmIwdlFEZmxmVVZoMFM4YnNCWjVFT2lrTldhRlNu?= =?utf-8?B?RG5YK3AzMkpoa3JzUXIvSU9hUGhiWjZjSHZwWjZiZnJYZHlyZUozVDF4VzV4?= =?utf-8?B?Y3N0UkN1NXVnT0pFN2J0ZUxORDFNL3h4WUFXWXhhU2hhRENqeFg2TFNzVGZV?= =?utf-8?B?bmV5U0RDdVhPRWEzdXhPUW5XL21XOXRwaWg0d2FxWU0vU0pqTkFlc21wQ0V3?= =?utf-8?B?MDRHM1lTSGhQQmpyMlE4NDZnLzdXMWZOZG9wTTFrZm9kRGpzQVQ3azBaVVdJ?= =?utf-8?B?d0lFYUVRT01mcGdJVGNaU1lQL3V5bStIVGNFSE1zZjdyTTFEbjNXVStXZ0lY?= =?utf-8?B?R0JIUmZGTk5sZU90cnBjdkI2S1pMR2ZwNlNDYzAzOW5OVkU3WlhXQllTVitW?= =?utf-8?B?alphdjZMVmE2Z0JwZWl5cUQxWU95R2dZaDVBdHYySnFkSzkzSVIvUnhLakd2?= =?utf-8?B?Z3N4WlA4WGlma05Ob0hSTTZKQ0NnSmdzV0pNVWp5TTMraENnem1wQnUxVGo1?= =?utf-8?B?bVVLWWdiOEVsWFozelQ5S1NzeXM3VEJINzJmc3VybUNpdGZ1VXV2NmVTZVp1?= =?utf-8?B?M29UN2lHbFRQdFhoTnpManRoVFdEbnFiTDM1eGxhUWJwOHhGTk40S3h5RDhm?= =?utf-8?B?TFM3YkZLNHJEUmF6d0EwQXo2aTZBQ0hrbGxubWtJMnZvaDV6dEJaTFEyV3or?= =?utf-8?B?VGNwY2trMTFKc1I4SUZrS0FCOUFxNXFuK3Z6Rk9JNyt2VkxLbGZ0TTQzTVBy?= =?utf-8?B?aFJ2UjVGTm5LOXIxZURiRWNuZEpZdlFCcWhqeUM1UC9PclA4YWk3cDYyWlNV?= =?utf-8?B?RC93OUhMdEdHY2E4VXNlMFZBelE0SUlrbGNHT01xV28rOWRNS0VXUGtWMG1l?= =?utf-8?B?clVCbk40Zmh3MDR6cHhxc3NrUEJhL3ZqTmV0ay9zdVBnRXpjUzdFUDdmdWxL?= =?utf-8?B?eE5ZSEcxR0VRRDNmRytpRG81c1A0Zkhtb2lKYUdraEwwdkFEQUt6VmlNRlV4?= =?utf-8?B?L3drOUtxWVNBY1pRU1lDSlEyV1JhdThQL3EvN1ViZWcvaDR4Y1dQdGhQUkJI?= =?utf-8?B?MmEzTVY3elh4Q2VUMGRtK3RrdFZrNVFwdysvdTVLQnJ2WE1TczV2dkNydXgy?= =?utf-8?B?MGY5b1M2TitwT08yWE0zSHI3Vm1VNm1Bb2l4WU4wTEtncVc2TTM5R21OV0s0?= =?utf-8?B?MXpwTDBXTjZ0UXhpYmpiREk5MG80QjBiUkVraXhkSjJoWDhtd1Y2RTRrRFJk?= =?utf-8?B?bHloOXZTckxmZGhCMzhwOFZyVU91a2t2SGZqM0hLUE5MQXpIMmVpNjR6dGVX?= =?utf-8?B?V21FUUdiYWlmVmorcXFhRUU4Ukw4MWY1UHpIK1kycmprOTVic0pGTVpja1Jp?= =?utf-8?B?eHNmN1dyL2l3Q2xocUFQd3pNM0VnMkh1cm9nVFZud3JwUVdVdTJtZXdUV0VL?= =?utf-8?B?Rkh5SDUyMzFxYnY4L0pGdEloRy9oS0lsNWF2b1JNVkJsSGNTYk1DdnpMSTI1?= =?utf-8?B?UGxEbG9GdVVJdm5JNm9oTXdVMWJmcHVFL0xZMlRrblRGQlc4Y1F3cmNhZ1J4?= =?utf-8?B?aEkyOGtacnpUSkhJLzQzdzRFbC8zL3pZdUd5VjNxemRyUTlwa2E4UWljak5P?= =?utf-8?B?MGphaWZNZG5HaDlRLy9wUm1ZNG9ZUXh1ZXlYdDhFZUZvclkrLzFja21HZ04y?= =?utf-8?Q?nPodn+Cxj++E8zHGQSs6kMG0dJETboHMXr7ZM=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(52116005)(7416005)(376005)(1800799015)(366007)(38350700005)(921011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L01Da2pYNStpbEhjWWZmNGFmT3J3VXA2WVdUZ0RlUXhtZTltdmxDS1FMOENr?= =?utf-8?B?SGRjR3pDSGxYVkNFY1pZVUU0eG9TUmVpY003TmpETGw4c2F3VyttZ0lEczla?= =?utf-8?B?MVp1cHNKRHd6SU5FdTdIK0k0V1dZQmNIeVZMNDNZOFlKZXArYjAyRUdQS01G?= =?utf-8?B?ZkZuRUJHTDlYaUpuYUozbkpxUjBKbmhkTnBrek1Ydk9OMllZZFc4Y0dpTU9G?= =?utf-8?B?THI4Q1IzQVBIUXlMY3pVZ1k5dlBUK3g4UlFjL1h2RUx1TUpDWlY0eGY5NFJK?= =?utf-8?B?ZGVlaU0zbHFUM0hVV0tpa0xxNElrcEFMaEVueVhtMTBEMkJwbmxTSzl0c2NX?= =?utf-8?B?QTRGUWo0a3VHY29CYVdEeDJVa3QvOHhhQTUyblc1ZmRGTGY0aGVzSHB3Mi9y?= =?utf-8?B?MTQ1WnU1dVBiYkpDNTlzVzQwRHZpSkJuTVpYOGt6bmRVUXVZYmxoVzhTbXpE?= =?utf-8?B?czR1a1ppVmhONnprb3MwWHBXOEs2U1pMeUgrZDJEekNFTzlpRW92NFh5Q2Zy?= =?utf-8?B?RVlacHozUnlFUG10dStSK0ZEUDdmK3V0aUFQM2lxSnpkR05PUnFoczRIYnRx?= =?utf-8?B?YStGZVhyak5SdzFLR1Z1TitteldPMXNCbktMVCtPTlFVZ1dmMHlBdVhLNzlJ?= =?utf-8?B?Nmh2OWRqZmJTN0ZkZnFuenZLdGhsMmcwVU9OYThBRVRoeVVOTDYyTGQxQkVO?= =?utf-8?B?MXFXQ2ljZXNSTmJxUEIrWWNtUXVQOXl6NFRaekRkVGpPdngxbGwwYkM0S09q?= =?utf-8?B?ajFDcjFnQ2EyWno0cG1NT3ZMSml3Z3BTdHBuUUJoOGY1cUUrNUJweW1QRDZR?= =?utf-8?B?SEZrOFJPVTB5ZGZLRXBKSzZITm8xemJYYmJzVzlpVUN3dzJSTWdNZTh1NjNp?= =?utf-8?B?cm5zbWxSOU1qMzNwYkxycDYxalh5OHZNN1lDVFNQazFML25wUTVHS0d3N0lk?= =?utf-8?B?b0lKRll4MXJucUlpZ0hUZ1NGY0wxUUdNcXdsREkreDRCQ25ack1qNjFMVG92?= =?utf-8?B?ekZjekV5UWR0NVRsMGYxbm10OUVFNDZaWXN6R3JMMTRRQ0tYaTA5WFM4SlpD?= =?utf-8?B?WGgvK1JXMGpKL3pSdmw1MC94Zlk2ZlJGTEw0UUw1Q2tKWSsyQ1ZQOVJlTUkv?= =?utf-8?B?aXRBb3dnbDM0YnVyRkdNT1c2SW0vTmlHUXNrS0FHVHp4NVJjemE3UTV5UEg4?= =?utf-8?B?R0dQbEhqV3Y1NERpZWhEamZYM3oxdTR5R3MybithNVcrTHpmVnVnL0NKMXRU?= =?utf-8?B?SmN0RW9kR0xVK3lmUC9hZ1p1K25rMnU3NXZiTkZUQXV4S2kyNGIxWisyb2l4?= =?utf-8?B?RmlzaE5NU1NLTUhNNTBVSDFrVHZOSjBOR0xOelpoOWFqV1g0VFQrL3FYMVJ4?= =?utf-8?B?cmNmNnRReUtHTTF3cVZYVG4xa0x1VDdUL3pFRUdkY2xka2E3L2pmbVJPWHVt?= =?utf-8?B?aGF0YnRBODV0Z0pQb1VLZXdaN0p2QjNUS3lqZWtITzc1b011dXNlcGNPcTFx?= =?utf-8?B?bko2ZTErSUZ0WElnMmVZQzBHaEVlU2gyOWwzc1d3cEEySzkzRGVZMUpwTDZk?= =?utf-8?B?UXozVFltanV2b0Z3QStWY0R4SGpqdG9LcmUyQ01QOVFmWnZwZUpvOUNkSTl4?= =?utf-8?B?RmtHWDYySnZEUWxZNllOQm1ubWhITTVYYml5V29iazZUR2FxV0JJY1lZWWEr?= =?utf-8?B?SU1XNVZ4Y3B6a0MwakR3VjFsUFljaDRnVzQyRFdOZHhTcVVVTWdWYjNxYzlr?= =?utf-8?B?Tkx3MzZmUStWTG1CZjRmWXpuTStpVGdEZWlvdWJhSlpXcTc2N0xGRmx6MDZM?= =?utf-8?B?NUpWTGlLMHE3NmY2eXcxRWJhRmdZNUlmQ1o3SE1XQkowaExGckhpTndJSXZH?= =?utf-8?B?ODB6NlR6UGh0WnpJZG9uRzRwK2pPTU0xMHNnbllxOWlIazNiWkRXdmc2Mnhi?= =?utf-8?B?VDNGUm45NVBVR0U4dWtKaDdQVzZHV3hTbmlNVDlwVXcwWVNlcFBDaHVESDNR?= =?utf-8?B?Rkl1czc2VGF3QndQKzl5RE9DNUJUVml4V3hJRHdLeS9hWmQxTG5wdHJOc2g2?= =?utf-8?B?V1pKZkMycGYraENlWEVUemRrQjVHM3JtWUczdGRqU3VCdEFnbmlLMkJjVVdK?= =?utf-8?Q?1GaUFhRg4MAwPgc8fNxfZlsKA?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d6598716-c0c4-479f-c7a2-08dc6c3c0fe3 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2024 13:14:00.1186 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: T+cymmIPNQaUTjAAeGY7giHGdI+UShMOKcu96YfvdEpUl5E3Du0kUO7KnLBy/GG82X25bBpZf2YVHU7iNXWLEA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8633 From: Peng Fan Use scope based of_node_put() cleanup to simplify code. Signed-off-by: Peng Fan --- drivers/pinctrl/spear/pinctrl-spear.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/pinctrl/spear/pinctrl-spear.c b/drivers/pinctrl/spear/= pinctrl-spear.c index b8caaa5a2d4e..a8c5fe973cd4 100644 --- a/drivers/pinctrl/spear/pinctrl-spear.c +++ b/drivers/pinctrl/spear/pinctrl-spear.c @@ -151,24 +151,19 @@ static int spear_pinctrl_dt_node_to_map(struct pinctr= l_dev *pctldev, unsigned *num_maps) { struct spear_pmx *pmx =3D pinctrl_dev_get_drvdata(pctldev); - struct device_node *np; struct property *prop; const char *function, *group; int ret, index =3D 0, count =3D 0; =20 /* calculate number of maps required */ - for_each_child_of_node(np_config, np) { + for_each_child_of_node_scoped(np_config, np) { ret =3D of_property_read_string(np, "st,function", &function); - if (ret < 0) { - of_node_put(np); + if (ret < 0) return ret; - } =20 ret =3D of_property_count_strings(np, "st,pins"); - if (ret < 0) { - of_node_put(np); + if (ret < 0) return ret; - } =20 count +=3D ret; } @@ -182,7 +177,7 @@ static int spear_pinctrl_dt_node_to_map(struct pinctrl_= dev *pctldev, if (!*map) return -ENOMEM; =20 - for_each_child_of_node(np_config, np) { + for_each_child_of_node_scoped(np_config, np) { of_property_read_string(np, "st,function", &function); of_property_for_each_string(np, "st,pins", prop, group) { (*map)[index].type =3D PIN_MAP_TYPE_MUX_GROUP; --=20 2.37.1 From nobody Thu Sep 19 19:38:14 2024 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2059.outbound.protection.outlook.com [40.107.22.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1FC22C1A0; Sat, 4 May 2024 13:14:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.59 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714828461; cv=fail; b=iPQKWmyvb+2vvvg8xwN2URpTqK/LDJnnFdq90a4l/C0/4euMXqpE1iBTypq9a7fe9Cex+fc/TjAgVi5Tfy91rGlRF7zXn4mUuvieqXgSX4kNKy8JqdB6+pVzwMiZ0Gkl7MifWpBJBqMME/Z3EjLiosIeG93g6EUL1OWGNwDcENM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714828461; c=relaxed/simple; bh=klyd7TcZI5h0sPA/ott/7mG9NW3OBXly1KYgwl3L3hA=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=X0f1pNk0Rs9DuRStvD16TrqRuEPsUi0lzAliVtzwaFercc6ey5FP3yl6MNkqoDRFS41++87viCmCEL1XIZKszSyI5P9nMKU72MGnzsZpMdmmhNZ5xBNhjrwlW92pNpgrlTuhqybn9c9X7dPbyZuA6kdsroKD/nqBi1RLiPAcG1A= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=CxNGfzcZ; arc=fail smtp.client-ip=40.107.22.59 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="CxNGfzcZ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e043KH9dCq8dWsmfeKQz3zMn/2C2bwJ7dl9LaOvScQd14Z1P3BuRUHiMQ4EWL2AX5BixlDRrF7G7hVqQ++bU27UsDQtNXIq+J25bfb1K+5Y4ewzDXjbek/UF1hq7yzVpFkX9i4zMiiBtcIwKWAFVxIzPXb51Ksfaf7FjCyQMPT1YNbluWlW0q5qZuVGhjNDDd6N1n8vftq18l6YfLwgDxYiSgzq1ARS3PPgXTGBuTD0M8dx2UgJcq6xWaWskZjYb1xbAg2lVRq0NJ82mgdVYvS/bLL6407xQ5iEbwcMgpMwkY2S/1aR7yKPX1fEKU5eesuS4tD18E+Nv1PVUQDRXUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xlpULG990sWFrI+9qxLt0ZBE85TdL60SLUPePmyaqSI=; b=O4Y2ScxgswofbZzRbVgTs64eSe100TK3S2nCZ+AafZ9bEEj7qu83tE2PQWUOfGYUt/0TDS4qPTzb+H2FYqHg4vtV9w5HZXKbXgofb6jXJ33H3SRRPoIyrRaCr/HXcAFG294xbPbrXOST5EWAojyL33MHs926WDQvsfy3zAqF9Uy4zGQi0sim7dbbyTuMaQsE1YZX5O6O+BLi2MBQlQ13uRGqmL+e2U8kB5iZhfv9964jflVaTOGLwKPUhRpShPW9m3TPQQFBcvfgwwlPZtLZRtjeS257Z4Wsg8DXsD0LG26zPLiNXKyuCwExzHKRMNFfX0P2j6yER4IOHXaRf4bl3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xlpULG990sWFrI+9qxLt0ZBE85TdL60SLUPePmyaqSI=; b=CxNGfzcZ5jiD6UiFRzRV/406Ja8hQdGwImmDedFo6vSUAQUvVkb3fzxh1GmvkJ1+XRFIqmXPR9HqH/CNFpIvjFpmwMpnfOiqD7kceQQxiLXcuwj/BAIIXKMeHxBq80IcdBY527TNY2zfTABkjJFsegOU2y5BtGpEDMU1DONTAts= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by AM9PR04MB8633.eurprd04.prod.outlook.com (2603:10a6:20b:43c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.34; Sat, 4 May 2024 13:14:16 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7544.036; Sat, 4 May 2024 13:14:16 +0000 From: "Peng Fan (OSS)" Date: Sat, 04 May 2024 21:20:05 +0800 Subject: [PATCH v2 07/20] pinctrl: renesas: Use scope based of_node_put() cleanups Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240504-pinctrl-cleanup-v2-7-26c5f2dc1181@nxp.com> References: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> In-Reply-To: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> To: Linus Walleij , Thierry Reding , Jonathan Hunter , Dvorkin Dmitry , Wells Lu , Maxime Coquelin , Alexandre Torgue , Emil Renner Berthing , Jianlong Huang , Hal Feng , Orson Zhai , Baolin Wang , Chunyan Zhang , Viresh Kumar , Shiraz Hashim , soc@kernel.org, Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , Geert Uytterhoeven , Patrice Chotard , Heiko Stuebner , Damien Le Moal , Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , Chester Lin , Matthias Brugger , Ghennadi Procopciuc , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Sascha Hauer , Andrew Jeffery , Joel Stanley , Dan Carpenter , Tony Lindgren , Stephen Warren Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-mediatek@lists.infradead.org, imx@lists.linux.dev, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, Peng Fan X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1714828815; l=7378; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=rblCQQjgjZSJUmkJHlAJdcDG19G0fEKKnoN4VoqDxp8=; b=rP64dRmiJWkjbNAzDUBgxO/jiMdNGY2Dt53nxwhfN/1GpjWG/i9oTL6uo0n4rFB9bCsFKaLFJ jG5wo4Gqa6zAfFCB7rn9+S0tSvNdGYgf0P/NDnesEBdMWd+TqbHCddq X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR06CA0230.apcprd06.prod.outlook.com (2603:1096:4:ac::14) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|AM9PR04MB8633:EE_ X-MS-Office365-Filtering-Correlation-Id: abac60bd-c623-496b-f9fd-08dc6c3c19d5 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|52116005|7416005|376005|1800799015|366007|38350700005|921011; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VzRuQjkrQm90SVVYV29BWHk0ZDhDS1BVWnZIeCtUNkhwVmlBU1A4ckswN1Fh?= =?utf-8?B?b1lIMkFudlUvYlQ5QzdYcjRVVVZ6aUxsUnZ1c1JYZXRIZndPVm0vUEk3aU82?= =?utf-8?B?UXNaUzBKZzZuOWtudVliQTNpVk9memVhMWxQQkhQRXNKRWF0WStLTVBSWVVC?= =?utf-8?B?TnBhWHNTbkYzaXJIZGIzUWQwQzRzbEZta3dWUGtWVUhCMVlDSm00RGZCaHBt?= =?utf-8?B?TVdFZ3l6S1N2RUFOY282bHZGN2RFMW56OVp3UWh0T29pUGlWcEMxZTQxZkJo?= =?utf-8?B?dmphMjl1ODR0K2JNZWZ0b1BoNFR3K3B0MzR3RHFrVmJIWWNOd3k2VVltVThZ?= =?utf-8?B?c2NZVzRPdWJMWUVzU2VoRDJFOVptU01kdE1ZV3FyQU9EUG1iSmplbHltQkJt?= =?utf-8?B?Vk1hNENkM3gwOFM4SUl4RkRSU29lbmJuWmNHMkxCYXV4UGlxeWFHN29tYnZz?= =?utf-8?B?UUE0Z1RqREJNMDMxc0lQV0R4MnpJc1NMQWVMNGw3UjhVbE16Ulo3YWU2YWR2?= =?utf-8?B?cUV0amhRa1I1d282WFJDTGdzQUN3aXNsSlFzbmg4VGQyNGN5MHNzaDJxUXZk?= =?utf-8?B?aVpEMmU3ZnJNTmFZMVhJME5KYVp4SjhsYlFtenduNkdUTDJsbGlhV1FRZ1Nq?= =?utf-8?B?ZVRjelBCUlJ0U3ZnTWFmVmNJcXhmSnJsZzNScFFTcTIwUkdjTEsyemlrZEEv?= =?utf-8?B?WEd5U0xXZDRHMXNsTHRUTnZGN3ZnSXNwN2JYc04reVVEY0Q4WmhzYmdYampn?= =?utf-8?B?V01ROEd5WDRnbVNUb0g1bXdOdzdYSXlMM1FWeUV5eThVa041enk4RWxNR1cx?= =?utf-8?B?Y2pTeWtNU1drM0R6MHN5eHB3M0swTEJpZG1hVDA0YThjMy84K3czSDJqdDZW?= =?utf-8?B?OXd1Z1huREpONUVkNGwycmd4MTg2bytOMlBFTnd5NW1hbi80c00zekZvM1RW?= =?utf-8?B?SnBuTHJ3QWhmUkZhMFErNUwxdDFvUVlrNG1tSDJLZ2M2cWE0RUVqc2VSNmU5?= =?utf-8?B?VU1lWWFGN3lzNWI5aHRUM24rbktVeWE0NzZTSlR0ZUt1N1ZhU3A4NXFySk85?= =?utf-8?B?VnRlUXBpNFFRYzBhQk8rcE1hVm5VaWFLR2M4ZnpoM2N2alRUZEFjcGRqaXRV?= =?utf-8?B?Y2FtN3ZCNTZtQVBpSjlYM1lRdmd3YUs4Tlh3dUUycXZCV3VMbTlQeWk0T1ZI?= =?utf-8?B?ek9kVkd3WVhzZ0xCUCtNaHY5dHgxNTRyZ2szLzRPYWRONnU4OENJa0lGMSsw?= =?utf-8?B?c0hpQ2F1OVdRcGtseVpuZHFDVElVRVY4clBRSVZJVlBJRnhJRVc1K3pyTjJH?= =?utf-8?B?QWFzUm9ZRmFxcnBnR0tvdW5Dbm9xWjdFa1BpQ2RZa09wemxpMi9LMHdkN1pE?= =?utf-8?B?QWVJYnlpWW5EMnFkT1NPNnJRR2k0VkxZQmFxUWxiYnhCaGYwdUg5Zmw4RXdB?= =?utf-8?B?dzFtbVpFcnNrWHNwUFpkR0JlbzRoc0ZzdXNKaHlIQ2Z1UWZjNlJyaS8rZlRE?= =?utf-8?B?MXh4VkE2N3g2WHJPLzdjMk5ldTNpQ0VNblR2NEhnYkl6dWVUSzFXZEVpNnpT?= =?utf-8?B?ZFBSNGsreDJEWmZwcUtUTkRxdlpXeTkvdmFBSkt3WEtuUGw5UktSdU5qeHBI?= =?utf-8?B?dTN5cDdNYWw2Q1lhYlBIajY5aCtCRU5IQzJwWGVYM0hiNmdhOEFCVkRjUmRV?= =?utf-8?B?N3FLS0JSMjFVMTZOdWFqWXFEaFpoRXgzU2E2cUxhZWJQdVBvdmlLOE5JZGg5?= =?utf-8?B?d1BlN2tGTG4wTFRCRzBJNE5LS3IzUFN2K0l6eVNHcjg5MnV0anlyaGJuYzVQ?= =?utf-8?B?WERzdlUrbkN5ZFE5R2FXZz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(52116005)(7416005)(376005)(1800799015)(366007)(38350700005)(921011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZnRMN29MRGVLdUpReGl5dUlBZXQrQXZ3emVMZWluZ2IzM1ZrOGZWZGxtcWNs?= =?utf-8?B?UXhBZnFuV2M4eXU4dHQzb0Zua2lDc2VFZXlWZlU4SDJmZ1UwVXRWMW13OXhH?= =?utf-8?B?dU1QVUZCSFRmM2Z4QndTRm1rNXZraVNlSTJYQlloKzNVd0UxVzROTkxIeG9a?= =?utf-8?B?eTZET1dlWmxXNTVTQ0FwQjYrbGFxMm8rSFRnWTFnTkxsSms2S0NOUGVmbnpC?= =?utf-8?B?M2ZlRjVzRGpWZTlpaU9zVVZIaTlua1FrRmRaS3RYUk53NUQ3akg5ZU1pOW5B?= =?utf-8?B?WUc2V1g3Z1VJa0RXQU1nMXRZTWZ5dVNiVkNDdkJFSktVVFdzZHBIT3hJeHBG?= =?utf-8?B?Q3lJQWxGVGI4Q2o2bGM3WlUvY0ZSNENKRUIvcS9HRmN1ZUU4TEpPSU9pT1lk?= =?utf-8?B?ZG9aaXJ0YmljQzlOaUlQM0dxRE1CbmNIUW9NYmpCR3AyM2lrai9QNHRaeG5L?= =?utf-8?B?MW9HbkcxTFc0a1dGaEpWUTFKYjB4ekZSM3dybmcwZFdUNFhqUDdwQ0N1U1Rk?= =?utf-8?B?QzliLzlnZmZneit4ZkZ3Q0RpS0FLaUs3c25FTXlyTlRFZjFSdlVmMmZhVWJB?= =?utf-8?B?ZVZNeW9NU21uekVSakc1VUg4WVdsRDh1cnhHbXJQWVp3T2NQcXRMMTFnK25w?= =?utf-8?B?TjhoR1Z4V0dGNytaYkJuWlRTY0o1RzNGeFdkQzd4bS9nWUJ3V2NwTGNJV1Nx?= =?utf-8?B?aGxLUzlnb2tta3k5anY4QmJBMXZ5a3pNMGdOYkJlb0FNZGlraVFJeFVDb2pN?= =?utf-8?B?TWdZZW5Ob05NN21Wb2JHNWNTV2FBY09wangxeDI1cTJQV3lsWWZVVlJXU2tk?= =?utf-8?B?b01FV2JIMVQrL0ZwZzJrZ3dTUWR5MVptNU9oRnJFaWNKT0l4RG5yaGZQbk1t?= =?utf-8?B?NGR4K0t6TS84Tmo0R2orUTRzWmNRc1RDYjBtWUFsb01DNkhieHVQd0NiRDFy?= =?utf-8?B?M3RpYWpyV2x0SHI4M0s5NlBpeU9vbEhIeTg5NllaWnA5L0QwRlZGa3NjRlhx?= =?utf-8?B?ZExXbk5HTXN0YmI4RFdFSDJjTW8rZmdlRHB2ZldtcjYraGZBV05oV1MrZzdy?= =?utf-8?B?UzdUNStqbXVvMWFVbW44U2IwMitXb3M0Z0tURzU0RkNjYUlNZXlVVVo3b1Jx?= =?utf-8?B?UmRIK0liRTNmbXNwdXJMZW1jdWJ0U0lmbUZFU240TlM2VXNqV0NLaHJDMGxE?= =?utf-8?B?dUtsazNjbUw5NUhGOVJmeTZORHVoK0tCZkJtSjRvU1NNZlp4aVdNb25iTkFX?= =?utf-8?B?SC9YekxOS0VmY09HUzNSNEc5a29YSjVTN1Y4dGJiRUNQVUtId0dsbkhkNTg5?= =?utf-8?B?M2Z3VURZUzhMQWVLNktKNzhwekN3TUg0YUVBbXUySXZXMnA0V05zQUlRaDg4?= =?utf-8?B?Q1MrdXV0L051Z2VZc2dIbU1yTGt6SFc4bkcvcWhXVzgxcEJ5cDNIaUF1U1Fq?= =?utf-8?B?alZmaUJuQS9JRG5lZWxubnpvWUVISVUzYS92eGYxWnNyWXQ5Zk8wb1pKN1Vt?= =?utf-8?B?TXZrZjJXMDBJdzdWZG9MbklHV3lmY1JoandST0Z3RFBkNTFNVzRYRmszVmhr?= =?utf-8?B?WkJ3S1RUNHBzbEtvTGxLV0NNeXI4L0xTUzkxMVhPTmU4eWVabDNIYWNHSm1y?= =?utf-8?B?TzV4ck40K3QxNC9pcmtDdDcxM0xvSnZnb1RmMWxUTlkvMU9RZEdyWE5ZeE9x?= =?utf-8?B?TG5tWk05MmdDRWhuaEdGay9pYmsxK0FWUWFHWEZ4WnRDaGtDUjZZdEZwM29Y?= =?utf-8?B?TThDK250dVNmcFloLzRpbXhybnJuTlRBL2dMbjArWG5ydFBldENJaHpiL3Vt?= =?utf-8?B?a2VkSkJaOFAwVmNuNjhNUVcwR0VMU2pLeExYZzVHYnhDb3V3TU9DNktoMnRs?= =?utf-8?B?ZStIc3FEY1F1TTAwNkpEQnNCVUtVMStMNm81QUw3UDJ3Q3V6VGd6S0ZjTkQ0?= =?utf-8?B?cU1aWTBQMFJSc0l5NVR6bCtnZmF5RnFzMzZBU0FXNFdzbWxjQmx3ZjUrczNW?= =?utf-8?B?ZXVPbmtuM1JBdVRKZUQ3UlZmL3dGQ1pMbXVqZTZuYzVJRTY2YVpKbU9ZTVIy?= =?utf-8?B?ZDd3dUJ0ZUdHUHhLLzN1K2hudGhia1p3UlM1bFcySzNQQmQyYm1QN1FWTTAv?= =?utf-8?Q?AoFNHEYBxA0Y8/F9tv8Jgfwys?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: abac60bd-c623-496b-f9fd-08dc6c3c19d5 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2024 13:14:16.8086 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: D7c/JWrShKmGOa5H4afl1vGgxSkCzZarqCkczeKZcBRMQ0KdqvL8ItqXWU6PkgfribG/1Sy3XlXOpFVDaCef6w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8633 From: Peng Fan Use scope based of_node_put() cleanup to simplify code. Signed-off-by: Peng Fan Acked-by: Geert Uytterhoeven Reviewed-by: Geert Uytterhoeven --- drivers/pinctrl/renesas/pinctrl-rza1.c | 14 ++++---------- drivers/pinctrl/renesas/pinctrl-rzg2l.c | 7 ++----- drivers/pinctrl/renesas/pinctrl-rzn1.c | 23 +++++++---------------- drivers/pinctrl/renesas/pinctrl-rzv2m.c | 7 ++----- drivers/pinctrl/renesas/pinctrl.c | 7 ++----- 5 files changed, 17 insertions(+), 41 deletions(-) diff --git a/drivers/pinctrl/renesas/pinctrl-rza1.c b/drivers/pinctrl/renes= as/pinctrl-rza1.c index edcbe7c9ad56..6527872813dc 100644 --- a/drivers/pinctrl/renesas/pinctrl-rza1.c +++ b/drivers/pinctrl/renesas/pinctrl-rza1.c @@ -852,7 +852,6 @@ static const struct gpio_chip rza1_gpiochip_template = =3D { */ static int rza1_dt_node_pin_count(struct device_node *np) { - struct device_node *child; struct property *of_pins; unsigned int npins; =20 @@ -861,12 +860,10 @@ static int rza1_dt_node_pin_count(struct device_node = *np) return of_pins->length / sizeof(u32); =20 npins =3D 0; - for_each_child_of_node(np, child) { + for_each_child_of_node_scoped(np, child) { of_pins =3D of_find_property(child, "pinmux", NULL); - if (!of_pins) { - of_node_put(child); + if (!of_pins) return -EINVAL; - } =20 npins +=3D of_pins->length / sizeof(u32); } @@ -986,7 +983,6 @@ static int rza1_dt_node_to_map(struct pinctrl_dev *pctl= dev, struct rza1_pinctrl *rza1_pctl =3D pinctrl_dev_get_drvdata(pctldev); struct rza1_mux_conf *mux_confs, *mux_conf; unsigned int *grpins, *grpin; - struct device_node *child; const char *grpname; const char **fngrps; int ret, npins; @@ -1023,13 +1019,11 @@ static int rza1_dt_node_to_map(struct pinctrl_dev *= pctldev, =20 ret =3D rza1_parse_pinmux_node(rza1_pctl, np, mux_conf, grpin); if (ret =3D=3D -ENOENT) - for_each_child_of_node(np, child) { + for_each_child_of_node_scoped(np, child) { ret =3D rza1_parse_pinmux_node(rza1_pctl, child, mux_conf, grpin); - if (ret < 0) { - of_node_put(child); + if (ret < 0) return ret; - } =20 grpin +=3D ret; mux_conf +=3D ret; diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/rene= sas/pinctrl-rzg2l.c index c3256bfde502..fc7f33d3c613 100644 --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c @@ -745,7 +745,6 @@ static int rzg2l_dt_node_to_map(struct pinctrl_dev *pct= ldev, unsigned int *num_maps) { struct rzg2l_pinctrl *pctrl =3D pinctrl_dev_get_drvdata(pctldev); - struct device_node *child; unsigned int index; int ret; =20 @@ -753,13 +752,11 @@ static int rzg2l_dt_node_to_map(struct pinctrl_dev *p= ctldev, *num_maps =3D 0; index =3D 0; =20 - for_each_child_of_node(np, child) { + for_each_child_of_node_scoped(np, child) { ret =3D rzg2l_dt_subnode_to_map(pctldev, child, np, map, num_maps, &index); - if (ret < 0) { - of_node_put(child); + if (ret < 0) goto done; - } } =20 if (*num_maps =3D=3D 0) { diff --git a/drivers/pinctrl/renesas/pinctrl-rzn1.c b/drivers/pinctrl/renes= as/pinctrl-rzn1.c index 4b2f107824fe..e1b4203c66c6 100644 --- a/drivers/pinctrl/renesas/pinctrl-rzn1.c +++ b/drivers/pinctrl/renesas/pinctrl-rzn1.c @@ -404,7 +404,6 @@ static int rzn1_dt_node_to_map(struct pinctrl_dev *pctl= dev, struct pinctrl_map **map, unsigned int *num_maps) { - struct device_node *child; int ret; =20 *map =3D NULL; @@ -414,12 +413,10 @@ static int rzn1_dt_node_to_map(struct pinctrl_dev *pc= tldev, if (ret < 0) return ret; =20 - for_each_child_of_node(np, child) { + for_each_child_of_node_scoped(np, child) { ret =3D rzn1_dt_node_to_map_one(pctldev, child, map, num_maps); - if (ret < 0) { - of_node_put(child); + if (ret < 0) return ret; - } } =20 return 0; @@ -760,7 +757,6 @@ static int rzn1_pinctrl_parse_functions(struct device_n= ode *np, { struct rzn1_pmx_func *func; struct rzn1_pin_group *grp; - struct device_node *child; unsigned int i =3D 0; int ret; =20 @@ -793,15 +789,13 @@ static int rzn1_pinctrl_parse_functions(struct device= _node *np, ipctl->ngroups++; } =20 - for_each_child_of_node(np, child) { + for_each_child_of_node_scoped(np, child) { func->groups[i] =3D child->name; grp =3D &ipctl->groups[ipctl->ngroups]; grp->func =3D func->name; ret =3D rzn1_pinctrl_parse_groups(child, grp, ipctl); - if (ret < 0) { - of_node_put(child); + if (ret < 0) return ret; - } i++; ipctl->ngroups++; } @@ -816,7 +810,6 @@ static int rzn1_pinctrl_probe_dt(struct platform_device= *pdev, struct rzn1_pinctrl *ipctl) { struct device_node *np =3D pdev->dev.of_node; - struct device_node *child; unsigned int maxgroups =3D 0; unsigned int i =3D 0; int nfuncs =3D 0; @@ -834,7 +827,7 @@ static int rzn1_pinctrl_probe_dt(struct platform_device= *pdev, return -ENOMEM; =20 ipctl->ngroups =3D 0; - for_each_child_of_node(np, child) + for_each_child_of_node_scoped(np, child) maxgroups +=3D rzn1_pinctrl_count_function_groups(child); =20 ipctl->groups =3D devm_kmalloc_array(&pdev->dev, @@ -844,12 +837,10 @@ static int rzn1_pinctrl_probe_dt(struct platform_devi= ce *pdev, if (!ipctl->groups) return -ENOMEM; =20 - for_each_child_of_node(np, child) { + for_each_child_of_node_scoped(np, child) { ret =3D rzn1_pinctrl_parse_functions(child, ipctl, i++); - if (ret < 0) { - of_node_put(child); + if (ret < 0) return ret; - } } =20 return 0; diff --git a/drivers/pinctrl/renesas/pinctrl-rzv2m.c b/drivers/pinctrl/rene= sas/pinctrl-rzv2m.c index 0767a5ac23e0..0cae5472ac67 100644 --- a/drivers/pinctrl/renesas/pinctrl-rzv2m.c +++ b/drivers/pinctrl/renesas/pinctrl-rzv2m.c @@ -388,7 +388,6 @@ static int rzv2m_dt_node_to_map(struct pinctrl_dev *pct= ldev, unsigned int *num_maps) { struct rzv2m_pinctrl *pctrl =3D pinctrl_dev_get_drvdata(pctldev); - struct device_node *child; unsigned int index; int ret; =20 @@ -396,13 +395,11 @@ static int rzv2m_dt_node_to_map(struct pinctrl_dev *p= ctldev, *num_maps =3D 0; index =3D 0; =20 - for_each_child_of_node(np, child) { + for_each_child_of_node_scoped(np, child) { ret =3D rzv2m_dt_subnode_to_map(pctldev, child, np, map, num_maps, &index); - if (ret < 0) { - of_node_put(child); + if (ret < 0) goto done; - } } =20 if (*num_maps =3D=3D 0) { diff --git a/drivers/pinctrl/renesas/pinctrl.c b/drivers/pinctrl/renesas/pi= nctrl.c index 4d9d58fc1356..03e9bdbc82b9 100644 --- a/drivers/pinctrl/renesas/pinctrl.c +++ b/drivers/pinctrl/renesas/pinctrl.c @@ -241,7 +241,6 @@ static int sh_pfc_dt_node_to_map(struct pinctrl_dev *pc= tldev, { struct sh_pfc_pinctrl *pmx =3D pinctrl_dev_get_drvdata(pctldev); struct device *dev =3D pmx->pfc->dev; - struct device_node *child; unsigned int index; int ret; =20 @@ -249,13 +248,11 @@ static int sh_pfc_dt_node_to_map(struct pinctrl_dev *= pctldev, *num_maps =3D 0; index =3D 0; =20 - for_each_child_of_node(np, child) { + for_each_child_of_node_scoped(np, child) { ret =3D sh_pfc_dt_subnode_to_map(pctldev, child, map, num_maps, &index); - if (ret < 0) { - of_node_put(child); + if (ret < 0) goto done; - } } =20 /* If no mapping has been found in child nodes try the config node. */ --=20 2.37.1 From nobody Thu Sep 19 19:38:14 2024 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2068.outbound.protection.outlook.com [40.107.22.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79CB72868D; Sat, 4 May 2024 13:14:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.68 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714828482; cv=fail; b=Zmd9D4oFaKyrBZSlCFp0F/jfrCzQ3f7/JdzYjVvapc3t3+6wYETvP/NG4YL/ajHIebw3bJYLJO81EufoA6aaHn0egBlQkfrS5D4Msobh9rBKy63Xms1/0boCMnS026eBG43qcyo+peCVdvm0kplq8rPXuJ0YP5F2jAvXkJ08JPI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714828482; c=relaxed/simple; bh=9hvlVy6b1eo5pxJBgdmpuQ0CR5gv9409rTkOxz7XFTQ=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=sYO0t3YPqO+LEE4m4J5NG57Ejxb0/EU80m3ibtAI6rumv5yCi2h+raAbfgL4lrIWu77QNvRQGfBsLhejD9FCLg2PLYDNT2+EIf1K9KKvJR/zOS0ewuapQR4aYNwDsVWlVvqzfhbkzbyrArWJJQeSQh1WwuJF3UDlkLKB6IXSpvo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=Dj+fXKXO; arc=fail smtp.client-ip=40.107.22.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="Dj+fXKXO" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fWXn+HNPyiNYRoDQDcAcXp4xArKAw/y8SFe/oayt6TItkT60kYUvZw3LsUO5+w8cIdM28YEM0q3jSoDZjWtLjKH1vMktTx9G+Rp5tw8tG12E6+Jkd1fCM9BArtum/H5wgxpfn1Bb95X/Ews/RyLiMruVN8cDELzVsEVzY1UZR7wDnWfqeWkTRZsRQul+UTPmSVatWS6CuqONLusUSbHNXhVzqEp9DU8Jpng59kI0wbZ+aka+RHpz8K7LuIDqhqXDn7JAlA+XA8ctk8Rejq5LcG4LSEBMHd/ol1CU6A6CLYrBkyC1MCdthm5B6uK6B7xi9RiEmCOL7f4rpMLgcjOnng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=epf4L/dpti+hg620NqhC5qYH7xMXGAi+pTHVtvEELiU=; b=AW82+A8IJYGHbQJto/aGxXBevTqLMwgnJF8ET8BsnuEFzN9iskxYO6ib6PxRmfaZWPiWt+n7+enL4Qs1oUPPHwzPF1+IRaClEHwU23lvKPCVfhAMYmdw+FVBMlmjAwgWulJcaoSsBR6Km8JFlf2uVzuu7QM8GYd2DQ3zFM832wieBJatzEggMThrR7I4RlTruCweTk3JYo2qhhEAjP59J+lNCok7UKn5smB2TedoHc+hkW6nd0R5dqf42vkE5U7Xj1B0UMBl8jxKKFgS8AURB2VnJwOhyz2TPbFrjS1u/vt8ZpXUjNbcRJHiu5uloSUKjJAVtMndf/iI34wVaebWSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=epf4L/dpti+hg620NqhC5qYH7xMXGAi+pTHVtvEELiU=; b=Dj+fXKXOBD1vI5VZVLaZnuBzZPwOSlnDkyrIq5Iit8VQPl/2J45TnEi8RICFxnOSUXd56kwto8odRlP5WmKXOXHlN4n/sHVH7BL856t0WxL5kawMYOTMcVZNHJ10JhXQq8plNmxx/hBcrYzNdjuJ6B0Oi//pM+j3bXhvDZtgjOQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by AM9PR04MB8633.eurprd04.prod.outlook.com (2603:10a6:20b:43c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.34; Sat, 4 May 2024 13:14:33 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7544.036; Sat, 4 May 2024 13:14:33 +0000 From: "Peng Fan (OSS)" Date: Sat, 04 May 2024 21:20:06 +0800 Subject: [PATCH v2 08/20] pinctrl: st: Use scope based of_node_put() cleanups Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240504-pinctrl-cleanup-v2-8-26c5f2dc1181@nxp.com> References: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> In-Reply-To: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> To: Linus Walleij , Thierry Reding , Jonathan Hunter , Dvorkin Dmitry , Wells Lu , Maxime Coquelin , Alexandre Torgue , Emil Renner Berthing , Jianlong Huang , Hal Feng , Orson Zhai , Baolin Wang , Chunyan Zhang , Viresh Kumar , Shiraz Hashim , soc@kernel.org, Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , Geert Uytterhoeven , Patrice Chotard , Heiko Stuebner , Damien Le Moal , Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , Chester Lin , Matthias Brugger , Ghennadi Procopciuc , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Sascha Hauer , Andrew Jeffery , Joel Stanley , Dan Carpenter , Tony Lindgren , Stephen Warren Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-mediatek@lists.infradead.org, imx@lists.linux.dev, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, Peng Fan X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1714828815; l=3917; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=WkwqgZKiLgnl2jfID+Ud31pueZUfzLGyRuwnbdcTMcE=; b=54q7MBEBsmgWVOdKQelInf02EJz/WtXPNBQuDk5mK2LcLLCBCOXVl32net6pxq9g8cBTu/cs8 PgTb3cxhzI5C/dbPij4nnc9A51CT7/Xx+UEJuEZwAX3+3Z+P3Zwv4ES X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR06CA0230.apcprd06.prod.outlook.com (2603:1096:4:ac::14) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|AM9PR04MB8633:EE_ X-MS-Office365-Filtering-Correlation-Id: 9f5ee1a4-bb1a-48ca-a0c5-08dc6c3c23c6 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|52116005|7416005|376005|1800799015|366007|38350700005|921011; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dndIdUpNdDhGZmJpNlBSRVNKekRYc2ZUajhFMDlENXd1U3dYTTJEUFpSeW1v?= =?utf-8?B?empJcSsrN25RWDVBa2lrQ2V4bTlHVFN6T2Q0THJ3YUFBTUxyWkZyTDU5MzVM?= =?utf-8?B?Wm9JbWpxTzVES09wOThnNDEzSEtyb2psZTA0UVdqMVZjRCsvcHRmUU9nWTlC?= =?utf-8?B?dnl4Zkh4c2tEZVFuakZCZitjeDNqOTRHMFdYNzNEdzk0ekpjQnBWVmdQNEVy?= =?utf-8?B?ekxOb2p0UUhrbTBjRktPTlFFVU5PR2xKMmRvNU1OUkpHR0RmMUpwVmxlRGZD?= =?utf-8?B?MkZyM3ZJV2lSb2R3aFVhMm4xeFhNcUR3aTFnMHNtbk02VmlmK3lxNUt1Tm82?= =?utf-8?B?Um51WGs0T1lReGNIalJEa1BwMFNxWWF5ZkNLcWRldVBTYkc5dWU1U0tkdGxE?= =?utf-8?B?THdmWlBRY1BoRk9Md0ErREhZamZ3R0VLLzNmWWE5ZlZ4UmFvQW81SXZuT3FQ?= =?utf-8?B?aU9KeDI2azliQ1NqK0RPLzF6WW5LVnNBdklodEJQZTlYcXNWT1JvOGtoMHlv?= =?utf-8?B?MDBydGtFcGJOQmpFSytBYW1tWURjZ1pIdnRLQ01CdHc3RlRwU1NIODQyNVFz?= =?utf-8?B?c0F1c3VZT0Y1R1FPdkZaOFc4V1p6YWVUMXdmdHZCOGh2c0pCWkk3TDlhWHls?= =?utf-8?B?SWplUXkxbVR2VEIrUGtvSGhFWjVLZmJFUStlQ2RTcEtuZGlXMHJUOHM5bnlK?= =?utf-8?B?S2Q2cDdWZVNJN0txRXNhb05EdjhUM1VTNmNQeUdOYmc4aWFXQkxGRSsyME5a?= =?utf-8?B?WHZYVjI1Q3gwYmtDNXMwL2I3YUN6aTBnRTJLaUxNN0xjNFVwU09LSVFCcXZq?= =?utf-8?B?aWhDa3NPK09CZjFBYjNUVURWN3lNUW5OaXFwczR5ck1weE9jQ1BvOUlCUTBt?= =?utf-8?B?TGIzU0tMTUFBeEptdCtHWjFSVTZwZVFTTmF2R1hFM3dNdFYxb3lxRmtyYVlX?= =?utf-8?B?S1oxMFJyb2lYS1J5NEVtdVp6TnFKWFkrY010bzRGUjdBWGVIallMR1hiaXo0?= =?utf-8?B?Vk52QWJCNi9wVmp4WElHd1VDTWU4M3NIVTR1QUdRWVVsR3V3aC8zVFlUdW9Z?= =?utf-8?B?MS9vcTcyUFFqYWdBYWg4RmlvM2l3RWQ5dGVPVjBLOFFjTUtHbzIzNzdyWDNx?= =?utf-8?B?TWRWdm9uenFlalcwbWcxbmR2ckNrT3F4bW1pcXovR1UzSm1nM1ZzL2xxV0gv?= =?utf-8?B?MDRQTSt3Y1o4NG1IRHRSWW9qTHBtdTQ5R0VFRDY5L0Q3aU1VYnltV3AxMGVy?= =?utf-8?B?UUF4U3VYOWxUSDdtdUlSVUNCQnhTdDFZNjd6ZG5zTC9vdVAvTTA4bDc5MlVw?= =?utf-8?B?MUtoQjBZZ3JEUHNBbUprWSt0cTJiYWsyTE1mSHZvVWFwOGNEb3BSMGJ3eWFR?= =?utf-8?B?L2puZ2FZRko4T056N0dFb21UY051M1VpeVpMRndQNkhXVzIwNTJRaUVhS3Vj?= =?utf-8?B?TUs2WU1acys1dWpiU25XakhGWndSVy8xY2VsYVpFQ2FUN2cyTVFvb05BMktq?= =?utf-8?B?aWU1cGNQaERVeXdyVnZHSW5JUWJrNUh2RzBpQklqaEx5TkFTdW9TSEV0SDNS?= =?utf-8?B?elJuQm1TNFViMmlJQzYzREJvcG1aL3B2eXBjZjJjRGthcDZjVEdtMWg3aG91?= =?utf-8?B?WEdHZ05JSFlLZUQ0TE5WUUExZDc2bk9JQklGY3lvd21Sdk5xR25MeENlTG15?= =?utf-8?B?QVQ2aDNXVVpNeXVZN09uVEpoU3h2VXMxakRlVlhVMnlZY2dGYmdjNG5paGZ0?= =?utf-8?B?Q2pkMWZsMzdYdnEzNm9iSWtHMitFZnVEOE1CLzY1QVl5NXRZVkkvTUR1bnl0?= =?utf-8?Q?DjelFG7iO47a6QAQMfnjcLCWggrfmndhlPIQc=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(52116005)(7416005)(376005)(1800799015)(366007)(38350700005)(921011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R2FEVGxmNWtFdlJ0S25BaFJOZ0xjYTZlWmRQMTB1SU56Snc3STFlRkgxYis2?= =?utf-8?B?YTAyNTVPaVBBbnZlZ3RvdjIyZDQyQTZibTFoRThOc2dYbUhqR2pqUG5GS1FU?= =?utf-8?B?QUZPcU9Wd3dVWXRCY09KY082ckxOMVNKQlVZRWJneC9sVTRUODR0RjAyNFhq?= =?utf-8?B?cDdLQXFzTHpiTjVWRUFkZFAwRHRDaXNnM2cxbGd6UW9KV0RiTlA4amcvaUQx?= =?utf-8?B?THdQemdIZlJBMDNtMS9ZbzlLbTA0R0pubHFPRVdxWG5kZFMrUWQ3MjJjbVFi?= =?utf-8?B?OTI1WjJFNnhLVzBEdnQvZlVOZFp3SXBBc0pWSGx3UkMvR1hMeC9WQjVYZEhW?= =?utf-8?B?UldsMTdmUjVzQ3d4bHFxNGsrNUYyMHZLUkNtVUkvbmQzM3NrOTlhS0dGSUlV?= =?utf-8?B?eU1UNEJXaW1EYWhZSHE5Vmd2akNrT2V4ODVFVFlBS0hFeTE4dWhVMVNjRi9p?= =?utf-8?B?TGdkQmQrSXJwbTNXMjR3cEMxeis0N0NSL0x4RDl2TC8yTjNKL29iZkxyZkVz?= =?utf-8?B?YU1NZlpoYkxXakdmamlkSms3UWk4TWhmWmpRVDNmVW1ZV1A5T0Z6Qjd1T3BO?= =?utf-8?B?MUx3ZFJHRHRlN1l4S3RtSHlyc2R1b3BTbnppZmFyZXNsQXkxUUtJclYxRFJs?= =?utf-8?B?NkptekVoelB1TXV4TUxPd1F0UGpzTXROZnZtd0pVbXFZMDQzZ3dPZUpmdDB5?= =?utf-8?B?NHQxbWIyK203RkpUV0xuOHEzdTBwVi8wZ2hkaUcwMTd2ZTlFckk5V1VSRnlD?= =?utf-8?B?Mlc0TWduNlNMa0x0UmxhcEtrejNSNmJRcXRuRjVzajhtOVEvOVlpRnowang1?= =?utf-8?B?czYvU0FoYVRDeThVNytPVTJpSEJkcWJtdjE3UTVCSWlGd3VuMElFUzd1OERx?= =?utf-8?B?M1JnVHNvVC96b1RVd09kT2s3ZHhOelk2SkF4K0Vkdm1NblA4ZzViTmpVVEV6?= =?utf-8?B?K3g4cm5SaHg5NVZRZjlLdFJ3Rk5XL2QrSTlPL2s4SVpGQ0NxNUNmeEk0SDQ2?= =?utf-8?B?VC9wd0o3WlhZRWR0RVpQZ3dwdzllYUdtYnhVaUN3aWdvZHM3QTd5MkpHV2hX?= =?utf-8?B?d2xBbW5FMGxxOEF2b2ZvZDVRTncrcXZhWHg2YUJmb1BGcHFnNnNBOWQwMW9k?= =?utf-8?B?RzhQTlUxWDgrYVkzK29SZW41TU9Oc2xLSFlaNGhmSWFxdHdBUjRTc1NkNWw3?= =?utf-8?B?aFNuelVFRnNLeHBIVzFXRjhjWExIaC9sdmlXTHdiNlc4aGdvdGNlWDVaUkRu?= =?utf-8?B?ZWxTRE40UDAzdWxSOXpTRm82em9mazU3UVk2ZWx3RUVaYlhpK1BRRjRFTWM1?= =?utf-8?B?S3BiaGNGZ0tQZjVCTUMvYk9OYVR5VEpSQ0MxNHJEUEd0VnAweThRUnRseDJ6?= =?utf-8?B?Zm4zaEJzcm9VdExlK0pyVDFXcFdweGRrUTI5NXVEN3F5RDdIRit5d0p6amJN?= =?utf-8?B?eXJaQ3BCUy9rbW5ENy9wUjJSaDhqcTd0cjFuZFA0YzNsWTZ2Mkt6UFZveGto?= =?utf-8?B?TTdZek5VRVB0czVwMmxqbTh4ejBBNDdpVkJMZzlYZmpQQmJNem9oeWVTbEhG?= =?utf-8?B?c2Zzazl4K0QraGs3OWZpcEJaVnMyMEJNbmZQa2JjMUtlZ3IxVUhuaVpRbWI0?= =?utf-8?B?SUZqQURHM05nV3BwODJVby9LbGxGUWlPRDE1ckQrSm0zc1NkVHJSYUlDS25O?= =?utf-8?B?Sml4cFRsTWxLU3luTnZ6Q3M2MmR2Y2lLcFNWS2ZxYzNVMWp1WDlzV3AwSmM5?= =?utf-8?B?OXNWT0szSjdvZjZlMGcyd2RXWWlsZFAzQ1k3Y05uNFJzL1NhYy9oMVMwTzVr?= =?utf-8?B?UDhwdkk4REVxQytLTVNtY0dUenQvNDU3Y240aWtycFh6R3dvWFVmL2NQelVz?= =?utf-8?B?M1YrSHAwYUwwaUlkNVU5WlZnQnpuSVBYbnNUNUFyejRMN3EvUXlyaUZmbFdo?= =?utf-8?B?ZnlPM2thVkllalJLTkJQcHNGN1FWbWNNOHplWDRUaTV1SnI3M05IL2lNRjBk?= =?utf-8?B?dHJLTWQ2YWRGYmVNaDBCUmJPSzZSNzRROGpKZ3ZXa2ExK0hKeEpjc3JTZDVt?= =?utf-8?B?c0xtc3NrbHBLRFg4V1BuK29sbHpJZjdKUlV6NkN4SkhqVUludlVMSDcrYVRP?= =?utf-8?Q?eQ/3zzyoUuSI3gnMabyiQmTmK?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f5ee1a4-bb1a-48ca-a0c5-08dc6c3c23c6 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2024 13:14:33.4684 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cffexWyhFxcbCs7yVHPCRoKq8Hz6oeRtownJutulL+N/e5mtXIytW8fqu18Jm+yYgRBqEfJGqV/mzLUkkQYPDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8633 From: Peng Fan Use scope based of_node_put() cleanup to simplify code. Signed-off-by: Peng Fan Reviewed-by: Patrice Chotard --- drivers/pinctrl/pinctrl-st.c | 37 +++++++++++-------------------------- 1 file changed, 11 insertions(+), 26 deletions(-) diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c index 5d9abd6547d0..fe2d52e434db 100644 --- a/drivers/pinctrl/pinctrl-st.c +++ b/drivers/pinctrl/pinctrl-st.c @@ -1195,10 +1195,10 @@ static int st_pctl_dt_parse_groups(struct device_no= de *np, struct property *pp; struct device *dev =3D info->dev; struct st_pinconf *conf; - struct device_node *pins; + struct device_node *pins __free(device_node) =3D NULL; phandle bank; unsigned int offset; - int i =3D 0, npins =3D 0, nr_props, ret =3D 0; + int i =3D 0, npins =3D 0, nr_props; =20 pins =3D of_get_child_by_name(np, "st,pins"); if (!pins) @@ -1213,8 +1213,7 @@ static int st_pctl_dt_parse_groups(struct device_node= *np, npins++; } else { pr_warn("Invalid st,pins in %pOFn node\n", np); - ret =3D -EINVAL; - goto out_put_node; + return -EINVAL; } } =20 @@ -1223,10 +1222,8 @@ static int st_pctl_dt_parse_groups(struct device_nod= e *np, grp->pins =3D devm_kcalloc(dev, npins, sizeof(*grp->pins), GFP_KERNEL); grp->pin_conf =3D devm_kcalloc(dev, npins, sizeof(*grp->pin_conf), GFP_KE= RNEL); =20 - if (!grp->pins || !grp->pin_conf) { - ret =3D -ENOMEM; - goto out_put_node; - } + if (!grp->pins || !grp->pin_conf) + return -ENOMEM; =20 /* */ for_each_property_of_node(pins, pp) { @@ -1260,17 +1257,13 @@ static int st_pctl_dt_parse_groups(struct device_no= de *np, i++; } =20 -out_put_node: - of_node_put(pins); - - return ret; + return 0; } =20 static int st_pctl_parse_functions(struct device_node *np, struct st_pinctrl *info, u32 index, int *grp_index) { struct device *dev =3D info->dev; - struct device_node *child; struct st_pmx_func *func; struct st_pctl_group *grp; int ret, i; @@ -1285,15 +1278,13 @@ static int st_pctl_parse_functions(struct device_no= de *np, return -ENOMEM; =20 i =3D 0; - for_each_child_of_node(np, child) { + for_each_child_of_node_scoped(np, child) { func->groups[i] =3D child->name; grp =3D &info->groups[*grp_index]; *grp_index +=3D 1; ret =3D st_pctl_dt_parse_groups(child, grp, info, i++); - if (ret) { - of_node_put(child); + if (ret) return ret; - } } dev_info(dev, "Function[%d\t name:%s,\tgroups:%d]\n", index, func->name, = func->ngroups); =20 @@ -1601,7 +1592,6 @@ static int st_pctl_probe_dt(struct platform_device *p= dev, int i =3D 0, j =3D 0, k =3D 0, bank; struct pinctrl_pin_desc *pdesc; struct device_node *np =3D dev->of_node; - struct device_node *child; int grp_index =3D 0; int irq =3D 0; =20 @@ -1646,25 +1636,21 @@ static int st_pctl_probe_dt(struct platform_device = *pdev, pctl_desc->pins =3D pdesc; =20 bank =3D 0; - for_each_child_of_node(np, child) { + for_each_child_of_node_scoped(np, child) { if (of_property_read_bool(child, "gpio-controller")) { const char *bank_name =3D NULL; char **pin_names; =20 ret =3D st_gpiolib_register_bank(info, bank, child); - if (ret) { - of_node_put(child); + if (ret) return ret; - } =20 k =3D info->banks[bank].range.pin_base; bank_name =3D info->banks[bank].range.name; =20 pin_names =3D devm_kasprintf_strarray(dev, bank_name, ST_GPIO_PINS_PER_= BANK); - if (IS_ERR(pin_names)) { - of_node_put(child); + if (IS_ERR(pin_names)) return PTR_ERR(pin_names); - } =20 for (j =3D 0; j < ST_GPIO_PINS_PER_BANK; j++, k++) { pdesc->number =3D k; @@ -1678,7 +1664,6 @@ static int st_pctl_probe_dt(struct platform_device *p= dev, i++, &grp_index); if (ret) { dev_err(dev, "No functions found.\n"); - of_node_put(child); return ret; } } --=20 2.37.1 From nobody Thu Sep 19 19:38:14 2024 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2080.outbound.protection.outlook.com [40.107.22.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9B4D2110F; Sat, 4 May 2024 13:14:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.80 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714828496; cv=fail; b=mn6G9MkJvoNvVao/ObJXbMz4p171sMUYjGuzQ1iREquKkcLYnhIDQy1FAUZnCpPnlVkfP64d/QwWAFWq+CYl812PAGeHYUl82oN1SAKlqDTnXCTpLneO28gKUNtAPJ98IC9sSs8OwKSLPG5BLY3po47i75YEXoUcI7oQvA/zwD4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714828496; c=relaxed/simple; bh=kj0ul2EuXMYF9cM0zyM/P5KHB6HNOsIcY8SnDh940O4=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=GHm9QYqwPSIyp55m6Rq6b8QCsMlM+lrbULgimY0t0EDOCsvzCx0yHHvlGYB1AWzdFHHj646hFlHo6+tEI+u/KA7TK+BDxe0qjf4VpvaRZwqyCTGMvSCbaGxyW4jJPxVI8fnE5xkSGugefVFqvfMGwnz7ooHRRD+lAJOCG7bEHOA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=iZnIReQ4; arc=fail smtp.client-ip=40.107.22.80 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="iZnIReQ4" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DUWsAuXgOKWq65PCrP9C+WmK/AFfmaCTCPRFukS/x2CYCw93S5laeahvxUYjKjd0pgj9JVyj13jj0RmcrgAeDgd70hzkOJvZRP5GhcDRrYpFJjHz+obdo016nNekOuqFcxx6UxlSPSiZNIZNaGzEfocf5gRCBx78gnlCx36a4eWUJaI+Ot9uu1xaOT/9xpAfI8t+UdlP0iyS1GFBCyaCq0cCMTuP5/AkW7dkEgdUmvMEzPkszbZg2wEtDc7d4jd6I0IoBa9OFDa4BlYBxwS2NGJ/i4s69gT7NPaRrSco1iijF3mim2quLCpJoqL4hbeGoUGu/r9Dhrx/atUdd0HAMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vokkuqgxyY5IUH8pE/dXW6vgGGl21pxNgCW/XhD57MY=; b=hHqFpmyRqlcw/4fqhS5W/oGJyszBYWmHxskkNIVpi9ofFyxfnaST8RJiKVnILgnZICeZtTqjr3qOO2s+uWNPOZQABxDTUtBkDcbdYtH5nxrQ4RjH8wB8ELXTouK3bAr4MdqEM1dKh5JhoBUtQldJLA5zCkGHmLydoAPKh2rlcDMhzlfTrGsJ1+6USjrsFnSwiwwP57xQIL18wsgyO0NtaNDpqpGlzzg1xNerwUNEfycduFNSx+u+DEF7+VUS7JywZS+oTqtuZF3K6o4+YB3gIZdq5WcpKvkT4ve7BIg4gRCuYMw8XQhzJPQL73u4utmh4DkNNRTLymRP8vsEwcdAyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vokkuqgxyY5IUH8pE/dXW6vgGGl21pxNgCW/XhD57MY=; b=iZnIReQ4wZWUttAX3CqmVOY/cy8r2jDJVTyW3auHbbvjzhM/6lPhBWaMzuaVvjFcMMkVEw5lp9xBPwQ8OOb3wIJ2V9Io5y7ggQD9n5Go8PmkJZp3PwpzGRW9H+kqj/OIZJHf4tJteLiUbW64KhA0qoTnqZq+37Lj+7it5wVTQTA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by AM9PR04MB8633.eurprd04.prod.outlook.com (2603:10a6:20b:43c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.34; Sat, 4 May 2024 13:14:50 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7544.036; Sat, 4 May 2024 13:14:50 +0000 From: "Peng Fan (OSS)" Date: Sat, 04 May 2024 21:20:07 +0800 Subject: [PATCH v2 09/20] pinctrl: rockchip: Use scope based of_node_put() cleanups Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240504-pinctrl-cleanup-v2-9-26c5f2dc1181@nxp.com> References: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> In-Reply-To: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> To: Linus Walleij , Thierry Reding , Jonathan Hunter , Dvorkin Dmitry , Wells Lu , Maxime Coquelin , Alexandre Torgue , Emil Renner Berthing , Jianlong Huang , Hal Feng , Orson Zhai , Baolin Wang , Chunyan Zhang , Viresh Kumar , Shiraz Hashim , soc@kernel.org, Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , Geert Uytterhoeven , Patrice Chotard , Heiko Stuebner , Damien Le Moal , Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , Chester Lin , Matthias Brugger , Ghennadi Procopciuc , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Sascha Hauer , Andrew Jeffery , Joel Stanley , Dan Carpenter , Tony Lindgren , Stephen Warren Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-mediatek@lists.infradead.org, imx@lists.linux.dev, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, Peng Fan X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1714828815; l=1826; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=8mEXPtWcMD1dO1kfLyDNpVkp869sIls+8yPccG0G3Io=; b=Khs2zelGliaL8fmUviQXPXSVDQ1eQ1SaAtwroqFPpigDdALV264pqy390e4AFEOqYQgGi9tW5 VAhx4S1rhRkBWvJ7B9Kn4+VsTHM/VeYcR3dExy9enWKyK+tvT3oIozz X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR06CA0230.apcprd06.prod.outlook.com (2603:1096:4:ac::14) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|AM9PR04MB8633:EE_ X-MS-Office365-Filtering-Correlation-Id: 6db9388f-6ac2-4d97-4849-08dc6c3c2db3 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|52116005|7416005|376005|1800799015|366007|38350700005|921011; X-Microsoft-Antispam-Message-Info: =?utf-8?B?MHBINjBWOTAwOHJiQldRcllpRGdwK3dqa1pmcVo2cUlURHpMNks2ektQWVd4?= =?utf-8?B?Njgrb3BxYlEyMk8zaVJkZGY3QUxFOXI2S1dBcGJRVCsrTEhmY0J6YVg3QlBr?= =?utf-8?B?SHFWbVE1MVBjSVpTQzFLc096Q1ZIemRhOTVsTzhuazZmakEvMVRkMnJ6RUlC?= =?utf-8?B?dGxTcEVNM0pjbEZnL21jL3M2anlsejNkSWIxOFliZTRMQ3NzNGVjUkh0NS9w?= =?utf-8?B?dkkxOWFOYzYweUdiVXZKc2FNSkNXKytDa1lQVHVFRWxia2Y5MXB4SFd5dUYr?= =?utf-8?B?b1BFMFA1YWJ0bGFrSjV5VU94bTZ6dTJDb2dqRVFZRkxXRmo1cWhXZTBlRzlE?= =?utf-8?B?SGsvbHRjZERQcVRzcU1FSy9oaDYzeFBOWlFQVU1uemxDd281QnFRQWVFSVBo?= =?utf-8?B?MVVFMDRFMVh0UHVENmhQcDJweDZDL3oxVmpjenUxTHQwRUNCb3FKL2lYdFZX?= =?utf-8?B?ajM1Z3Z1N2UxMW1sOW9seVVqNDAyMFQ3MEtKbFRCa3FQSURFOXNvYmVaQkdh?= =?utf-8?B?SnNuNXpTQ1hycE1VMUJvWjllbDdVdXVNd1ZVdm5PekZacTFuNTNQYU53QVc5?= =?utf-8?B?a2NZWWEyOGFEQXo1aXpoUkFkd0UzZkY1QUhUdThUWXNPMGVLMlFRazcrMFFN?= =?utf-8?B?SFBJcFRCbGRaUkFKZG9sU3ExQXJ4WEtuQTdHTE9IS2RUS0V5bnFDVTBkcEtV?= =?utf-8?B?aVZSTlFQeU53Q2FpUmdRUUJWaERnREhoSDc1aExFcVJmdDJaWWRQUVNIdHRC?= =?utf-8?B?UVFmOWVyOWFvbFkreW5RNWR1bkdQYkxZZEFIRkI5N0svZmZicmM5SURPYUh3?= =?utf-8?B?NDE2Vk5lT1dXS2paM2NMVnlOdkpSeFZJdUloZW9ZQUVSdmNVWGZHTXZKeXlQ?= =?utf-8?B?eGZDbTBqQm9LWWhqSlcvTkJOekl1TGFoaERvOHFsYlVrdUpDSVUxQVZ3WEZj?= =?utf-8?B?OUpqc2NXTWxLNEFwa1M3SW1obUxGYlU0VUhQNllOS1lpVDc4RkNaY3RjZC9l?= =?utf-8?B?djgzcXB1b3JPZjFNaUtjZkdubU41eTZwRjJ2ekQ0RGR3N1N2UXlBcDFHMDdu?= =?utf-8?B?NW1nUUw1cWF4M2dleUNpOEdRdkxJcjFlRW9IK3ZwVEFVQmt3UjZhSHFhRENS?= =?utf-8?B?RW4xMEMrNndPRVJLRmxrdXFwZ3pMTmFIZ0lEMmpJNUNYak53RTYwMkJ5WmR1?= =?utf-8?B?WU9XQksyZTdVK243djUybzVaOWhxRVpIaUxvSlRnVjI3RVlNUFQ5MklVREVs?= =?utf-8?B?UDgrVlpRS3MzK28yWlptMkhvdkd2T1J3ZzNVS2JqZUh6SnpVTkRMdVVzZStN?= =?utf-8?B?OWdHZkRRb1FERHZ4c3NYeDRLUUN4d2ZkRVIwVmgrRFJiM1N5Zm5XTTRxT2po?= =?utf-8?B?enBjQXF4cUk0Ky9GNm44SGd3NU5NSVVCMmZoSkZIb0l5ZU9OKzc1WmVIV0Nu?= =?utf-8?B?S1J4MVNPUlpTRnozNVRhMGhoWE56eTNkRlhSYmJlSDI1KzV1SFY4Uy9jQllH?= =?utf-8?B?MHh1OERTQWhWYVVjUzdmbUUwVFRMaElYRU5WZzV5N0lKd1VYcHl5dmllNU1H?= =?utf-8?B?N3I0VUFWRjNyL3lmdmduaThYMk9XMDVTejZDSUNJYWh4aHAvSjl2M21hZE00?= =?utf-8?B?ay90OUZIV2hQRHZocFpRRTcyc2JTME81VC9sb2J1Wm1reEU0QitKaCsrZ20w?= =?utf-8?B?QklrVGw1cjFXSy9xcmMyangwbE5XeTNuSE8xS0hUdHJmcHlleFllMnBmTDBN?= =?utf-8?B?Y3JUN1I2U1k0ZGNSREZqR01PUUZETzFtVEpvaUFEWmdiZ0c2dFZqejRrZVhw?= =?utf-8?B?dkNRU2wrWHM2ZWEvejBndz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(52116005)(7416005)(376005)(1800799015)(366007)(38350700005)(921011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MzZjT1IxZGRmWTlYRkRMWS9JNDBpRERhZGQ5TkhUUkQ0NnlCTWo1VXBsVnNh?= =?utf-8?B?QUlPakNPMDJtSm9BL01EOUk2V1ZCTFdKOFlTT0Zud00zdWpySzlaZTZ5WXhF?= =?utf-8?B?TFJUa2tueWU2VkFQMHd0dk14Q2hjZzhzcVRIQ0dYVkgwc2xMNFdIVitaM2pr?= =?utf-8?B?Yjdvb2N1UDBpMGtZK3F1VTZiekFXNUlWYjAvSzdDVThwZmhZZFV3ZFdPT0Vp?= =?utf-8?B?ajFmR2lvRWo2YXdxYjBFZmVYL1RlUDJmNHV5Slp3RkwxRlNIelkwVXRGOFJo?= =?utf-8?B?WTg2ZkRLTE1aN1M2YnN1TENQb3lsRUtuMDc1YTJFTWZyUXN2QnNDMHJJZm1I?= =?utf-8?B?NWMxZXExTHNTSzFGMG9rR2V4NG5tWDQzcWl3eUsyTWN4VjBESnF6b1NaNzlR?= =?utf-8?B?SGRGWVlSRlRoU2g2dkFZQ1hjbE9BTHJ1MDhYRmZXRVJ0bERrWFF1c082QTBP?= =?utf-8?B?eUQ1UDJVLzRQOXZWVk1TOSt5eFdlbUpJeEVwMGhxcUZRcFRXdFJObWdYZ1hJ?= =?utf-8?B?Z3EvdkJFYnB6ZjFWakRJOWVxdi9hTi9YQUc4eXVPT2hKWkJ6cFlLaHBPd1Zp?= =?utf-8?B?czVudmdaQzM0VXJ3TFVNMTMyR0wvL0ZVUlNERkU0VVk2QmQzMTZOY3pRb2Fq?= =?utf-8?B?eG1xZGFFYm1qN3FxQlU2b2xObStYRWJ6TktRb1Y4RXJzZzVqSWVGNHVYQlJW?= =?utf-8?B?elhZUUpGd0hJUUlYYTVuYVpBd2pBVWZPalpKM0F3bGJ0QVJEWFJCcVdwYUF2?= =?utf-8?B?L0xCR21ORkdPZWFiaXppUVF0YzJZVjl2R2QrRFZIVnlFSE1WK21hZGVSOHRp?= =?utf-8?B?WHpWMlN0VXp3UFVzVjFrVXE4TUdtbjUyUHR5YUltdEZCSmNXOTNlV2VqZE9a?= =?utf-8?B?R2tVcHFhVzJqa3ZLd1FmT2lBZFhrR2hDWTl3S2JocDFuMkF3bEdBUkZpN2Vu?= =?utf-8?B?SUJsUFV0N1F3SDNEVzNFUjZPbkE5L0ZHVTBqOVZvVjZ6djBHUUE1eDU1ZGpp?= =?utf-8?B?SHRhMGRqUlBOQkJhN0RBM1p6MXdmT21ZTEhyVExlL0Q1UnRuL1ZGbWVRZTNN?= =?utf-8?B?QStBN09jNDN6SCt0SjF2WUhISmV4aXNCYVltZitWbEVXNkEyQUNDc2NJRVRs?= =?utf-8?B?UVNBNmxraGF6RCtsYXZsdHE2REFrSldpUHFUNmlQQzB2eXV2V2pnVkllMDBZ?= =?utf-8?B?Qmo1VzhXb0pJcVlFeTVEZi82NGk4SFR5T2RUVm1HMDM0VjFGRW82WXpnVjc1?= =?utf-8?B?R2JUd1BWRldwOXlpT2hibDdvelllRUoyNmFoVnE0bExqQksxQnY2cGF3Y29V?= =?utf-8?B?K0lwRVZtYWFXeXNjYjhPS0pKcUxmeTBPSlA0NWVmMnhjWkdDeDNEZVFnSWhK?= =?utf-8?B?Y1laa0duc1crMXI0NHl2NTFEaXNiVU1FbFNGZXpJaDNTNGFoWFZEUmVkZHA1?= =?utf-8?B?WGpKbXhNRHZyYmZ5dEZVdHRsUWd3c3BRalNaVmh2NjFVMW5JMEd4QTVhVXZh?= =?utf-8?B?QkF3eEVhYVVuK3JSbmhmTnhCUlNNVS9aTE1yRnhYYS94ekFmbzhhZVVqTjY0?= =?utf-8?B?S2JCekNDWlRGRjVuY1BVTTJ3dTNIRTNCU2E5eVpZR3c2VHVMQ25iQWVuU1Vy?= =?utf-8?B?UWtPUFg1YUV0RnZmWjRmV3J1U2lCVGRPamk1U2k2eGR5VFMwT0F1dHBOM09B?= =?utf-8?B?WHM5K0hyUkplaXc1MkJiMzZDSGk4UTJlRm1kQUYvOHdJR2NGUXEwbXJBdHU4?= =?utf-8?B?dHFmWm1EcFdBelBZa3VveHRYd01qd1lzY2tiVmt1YlhibExFci9nQWtrd3E0?= =?utf-8?B?VEhDclR0a3RKTG9rVFd4S2ZCRzYrdStGb1dSRDhQNVNCWk5XY3ZTaU92b0tK?= =?utf-8?B?b3VNWGFIVnBIT2VGR2NLTFcvKzhqbThON0Zkd2pLZWRzV0VQTHJUSy8rV3By?= =?utf-8?B?ZExhNDJQVmNhVzJvUitmeVcrSmtZbnIwVkZGcmpaeXpuRllqYk1wcWF4aVM0?= =?utf-8?B?TXpzWEtBN0JnbW9MNXZtNFhaWkJuWDY4ZTBEd0RDYlFCYkZraExhU1k1c3dO?= =?utf-8?B?S0JleFExR2NORk5RcUI4MUFuZ0hoenQ2Qmt2a1h4VGt2RUErakwvRkJCeXBT?= =?utf-8?Q?dr0YO6Zl9Z+lJa766eYq/7Cgv?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6db9388f-6ac2-4d97-4849-08dc6c3c2db3 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2024 13:14:50.1228 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: k1FOWtQcbK2S5D56WJHSNhwKVTAFFg62e5/lh421anpq5APRIQxJEDcrzvxs6j37GpD2sPQQcQ4kMMkZMFL5wg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8633 From: Peng Fan Use scope based of_node_put() cleanup to simplify code. Signed-off-by: Peng Fan --- drivers/pinctrl/pinctrl-rockchip.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-r= ockchip.c index 3bedf36a0019..68391d6497c9 100644 --- a/drivers/pinctrl/pinctrl-rockchip.c +++ b/drivers/pinctrl/pinctrl-rockchip.c @@ -3057,7 +3057,6 @@ static int rockchip_pinctrl_parse_functions(struct de= vice_node *np, u32 index) { struct device *dev =3D info->dev; - struct device_node *child; struct rockchip_pmx_func *func; struct rockchip_pin_group *grp; int ret; @@ -3078,14 +3077,12 @@ static int rockchip_pinctrl_parse_functions(struct = device_node *np, if (!func->groups) return -ENOMEM; =20 - for_each_child_of_node(np, child) { + for_each_child_of_node_scoped(np, child) { func->groups[i] =3D child->name; grp =3D &info->groups[grp_index++]; ret =3D rockchip_pinctrl_parse_groups(child, grp, info, i++); - if (ret) { - of_node_put(child); + if (ret) return ret; - } } =20 return 0; @@ -3096,7 +3093,6 @@ static int rockchip_pinctrl_parse_dt(struct platform_= device *pdev, { struct device *dev =3D &pdev->dev; struct device_node *np =3D dev->of_node; - struct device_node *child; int ret; int i; =20 @@ -3115,14 +3111,13 @@ static int rockchip_pinctrl_parse_dt(struct platfor= m_device *pdev, =20 i =3D 0; =20 - for_each_child_of_node(np, child) { + for_each_child_of_node_scoped(np, child) { if (of_match_node(rockchip_bank_match, child)) continue; =20 ret =3D rockchip_pinctrl_parse_functions(child, info, i++); if (ret) { dev_err(dev, "failed to parse function\n"); - of_node_put(child); return ret; } } --=20 2.37.1 From nobody Thu Sep 19 19:38:14 2024 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2041.outbound.protection.outlook.com [40.107.22.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C4C83AC0C; Sat, 4 May 2024 13:15:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.41 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714828512; cv=fail; b=G0fgLjKR/eRBHNDp2CJhIIlUW41QwEHx4ppxzJ75xGzUpRI4iSagfCVRObl1mZ43/yZvMtrtHptmTKixxqjcQ9H/8xyaK3LpnPp7nukAPAsWSS5Zsw/tvIZl6J/u+Kle/3DHPe1T5hJipPady7W+FIPKjVhl0xNhORhxT2fqqYI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714828512; c=relaxed/simple; bh=E6ik9M6/qhOWxdXMSi5wfgwa6MozB3Zte/4KB5unPbM=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=fP07JKr0G6x5MdEAKWwKd2aFDmDHYhhmSY+4FfiSdFlf+d2q1Mx0ZG0tiM3LTQVIJ/KB/I+VTpl3MCqEJSXw07r8UH7dcDj7mroNWzKJ4IPEANfO7OMYJ2DOd1HkcUFYYshYiuhu0BVgmSFiY3nl55jkusOI6YYnha441jO/vS0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=lZr7eJvK; arc=fail smtp.client-ip=40.107.22.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="lZr7eJvK" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oWcs9F6D1cAInFj0HNId55OgFiP/mkBRJdDBth1QPgZ5CaKgqIAALcgcQA1NjWptsksyVAzXuhsB3we/2egExl9uYbbVtaxdsq0leD3umqoNBu+9Ccxb8izBxX0JQ5w2zPGyFCIG9XcR9h6EXqpY9B2EPYkqz1V/CygsdPAe63ZvpD3Dk8JuG9HlU5X2ruOSETUaCKiZQEW253cf5Cl9oHzq5xhhjeYZR33/Siq5yx3CO9DxCQUZN4xP9Uos93z0tmyzcRg52dcbHPDW2YDrx6viOehHk+dnvXdGsJS7iqL209vw/qHQhIAGk6ML/9vKar82r7wkfCYgoO50+FPaUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RKzscdFMbKHIkbo5TBU/zyPoN0zmGs6d6fVNhcTfxjo=; b=h5aiCFA3yIhGGeDVFZp9kTNSwyd475ryEOK/SwQEGNwyuf8nAUKXiAKpeWOtGrkrG/DAkGmwU0FmaxJJ/Qh1ToPDh8oAQCYFNqzdxmG4x4XkI+CnQsToa3zZzW0z+Y/5kqztve3wax35JxlgJWPRQn4Cj1p84j2V3kd47RIp/pQr40bX/BY68ySZ4z7ZxdMDbCFd8EbpPEOLzCm4qeSjfrQeVc2esgF6218qpIGtcad4RckxyhOxOnng93HiR+/Vm/o3J5TAJEiDNV0Jwip3eEaq6gcIi1RI6108Cm7yMH84PCPm3puWCkSFF3Q7LIEUKhJ6cEUQ7cK9iu1lQSsOPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RKzscdFMbKHIkbo5TBU/zyPoN0zmGs6d6fVNhcTfxjo=; b=lZr7eJvKLCQzJZDvJgt7Naxc5QoUcJvqDpm0lF9CZdP2zjbsNCbQcGc2VU0uaTeQ1RX0b3Mq05FEoza+cTb1C87bIBo7Ud/6+Gotll2gHMQo0KA/svrXB2TElm9iznEQIx28QiSe8Fzb0dRRnqVsvZ9l0QoJ7H4RinW3AYeTC4k= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by AM9PR04MB8633.eurprd04.prod.outlook.com (2603:10a6:20b:43c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.34; Sat, 4 May 2024 13:15:07 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7544.036; Sat, 4 May 2024 13:15:07 +0000 From: "Peng Fan (OSS)" Date: Sat, 04 May 2024 21:20:08 +0800 Subject: [PATCH v2 10/20] pinctrl: equilibrium: Use scope based of_node_put() cleanups Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240504-pinctrl-cleanup-v2-10-26c5f2dc1181@nxp.com> References: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> In-Reply-To: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> To: Linus Walleij , Thierry Reding , Jonathan Hunter , Dvorkin Dmitry , Wells Lu , Maxime Coquelin , Alexandre Torgue , Emil Renner Berthing , Jianlong Huang , Hal Feng , Orson Zhai , Baolin Wang , Chunyan Zhang , Viresh Kumar , Shiraz Hashim , soc@kernel.org, Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , Geert Uytterhoeven , Patrice Chotard , Heiko Stuebner , Damien Le Moal , Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , Chester Lin , Matthias Brugger , Ghennadi Procopciuc , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Sascha Hauer , Andrew Jeffery , Joel Stanley , Dan Carpenter , Tony Lindgren , Stephen Warren Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-mediatek@lists.infradead.org, imx@lists.linux.dev, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, Peng Fan X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1714828815; l=3196; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=HA5FdeU3k8hXGIzvGdYVmDetKxvVIH+CQmWTQZMAMaY=; b=5/9X9Qk9v/w+LR87FogVZNrWJ/LbCFJXvedVd7p6cKDdq763RoRF3HqVmtqSayI+ZxqnUpTVv 9nppgP1puY4C3uChQOu864GCcusz2Mno4rh5TLaHidULc7StN8ugZY1 X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR06CA0230.apcprd06.prod.outlook.com (2603:1096:4:ac::14) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|AM9PR04MB8633:EE_ X-MS-Office365-Filtering-Correlation-Id: e5a5311e-56df-4041-119b-08dc6c3c37ca X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|52116005|7416005|376005|1800799015|366007|38350700005|921011; X-Microsoft-Antispam-Message-Info: =?utf-8?B?K2UySGRvcHJHVnJ6WHJtT0h4L2E5R1YzdlRET1BYSFpkejZzN29TMmYrLzNT?= =?utf-8?B?N3lwQTdjendEMGU3cjRkZVUrRFdyckJxYURzQU14T3pwVnBxdGxuTnRBSXo5?= =?utf-8?B?TC8vbFN3ampOcTR0T3RrOEtneloyaU14QXFjRzBnR3RBSDJodS9veHM4bFJy?= =?utf-8?B?SUc1UHBtL3ppNk5uN3hOdG1rRDU5ZVFqTTQ4WDcwY0hhNmNKcDlDTzVkbHFH?= =?utf-8?B?TWRmN093dFpadXljbGlqMG9xZ1NIT2hvK1hSeW5LNGZRYVVUWDFtQy96NFBy?= =?utf-8?B?QWFSN0s1YUJRRWpVU29Nb2VlMU5wYWZKWHB4bnBsRG5tUWo1T0VUVlJVb0V6?= =?utf-8?B?ME04bHI5RFpEeEdYWjRFUGNQdXZJUlBTRGZ6UGluSHRqNjZQR0xWUGRIZXNx?= =?utf-8?B?enRUd0lJM3k2OG5wRGNxV1BtV2J1Znd6WHlLRGcwbTYrenlydHVyZHlGOUpF?= =?utf-8?B?UUplbjl4ekxlZ0duM1hvT29HV2xweW9Oc1hSVWpIQWpoMFg3MU1vR1lBbHpx?= =?utf-8?B?RHdyOHI2ZCtPSE81Y1IzcGl4bUgra3ZWeGFjZDdwYXVGaWo3NnZGSVV5c0I1?= =?utf-8?B?c2lVa0ZvY0RUejlyVUVQSXFvbm9lZUozZTUzRVU2Ti82eTkwZ2FBa3RmbG4v?= =?utf-8?B?RVM2OXZUdkRwQTNvNWtDUWhYWlFmUVIvTUVSSEM3RUUxK0NDQnRXQkdvWUU4?= =?utf-8?B?aWc5Z1Fta3pETEUrV3JZNWtCUGVlUjJFMVNvRjduNmtRWjNnWHpIcWQ0VUth?= =?utf-8?B?dWU4RmhoaFFOREpCSW9DRjlsZkRiYThRQVo2Q0xSSzNpRUxZUFQrSUQ3cGtI?= =?utf-8?B?L1pWdHFTcFdLdTUwT2ZJd2hXOHdvNmw1djFiQ2wwakF3QWFSRTB1eVZFUlpL?= =?utf-8?B?QVZMSWs0M3k0MGhzblFwMDV5TWZwUFg5VThhNGVGUjBaTGg1bU50T0o4dCtm?= =?utf-8?B?MjZsMDhEejQwMDc1bnhCd1hLQ1g2UXB5bjNyUCtPbm1oRk5WVlhMenZ2MjRk?= =?utf-8?B?K20wWVhGSlR6WEtJUitpWm1jNDJocVJsVmxCd1dtam9razBwdDNTRkZ6UWhG?= =?utf-8?B?L0xjMk10bklQL0J1UlhSU1A5UDJMbkN1YW12ZE1uVzQ3dm1RbnhvejR2TEUx?= =?utf-8?B?SFVta3hWUmkyWGxKZzV2NGFISmZWRGVwS0dXY0Zvbm1uRGtYRWxrd2ZwbGJO?= =?utf-8?B?UCtnNEl0V09UUDBaMzBqY3ZIUzJvU0Q3KzRkZGZrUDNjMitUTytnNWlkYUlD?= =?utf-8?B?M25MZWQ5RVd3d2VRYUx1L3hhTzhjcG9QNnZDMnZjSUEvcHdkUFIwbU1JdVgw?= =?utf-8?B?NFlldkRYTDY0ZVVENW1RN2t3cjhTRmdFclhMRExGNkVLK0s5VE9RSnZYWHhC?= =?utf-8?B?RTJmWnVsWFR6UjRQeXNLaG5nSkMvaWpCYW84bk50TlFLc1BOYWtqQ1JGbVdZ?= =?utf-8?B?UWdINDk5VmlLT09KSDViYU5va2xIZXFockgxSXpqYXgrWkNMQVJWVHNmV295?= =?utf-8?B?NDBzTTM3clFVeGlqQmVpRndteHFRTUxjUjBiQTVmM1FTRWZMeElvc21oazBh?= =?utf-8?B?MVFjVG55T1hzZWVnY1BuakdBM2pOZytXanJ5dTEzR0ovY3Q2OUJYQWxQUmF4?= =?utf-8?B?dm1hKzBYMW9HYW1XRXExaDRBRFpNdW5tZXVRQkRWYis0WkdrRmtPMG1yVDVE?= =?utf-8?B?OXdUQ3RKa2xXaUxLZ1ZnL3F0NGRMMkd6a3V5VFBwUUhneFJOS1ZJZGh1MTFj?= =?utf-8?B?dkkwSmtsUWFtQjRIb0J4WmVWeXZ5ZVhKWXN3L2ZsVk1pTFBEby9EUWZlbzlt?= =?utf-8?Q?ZEu9B7LC9bIlEV3yco77GgnAwjjydpT+PXlH4=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(52116005)(7416005)(376005)(1800799015)(366007)(38350700005)(921011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MTg4UXZMeXppOE44QXViRWRoK0pyMlFZQTZ1U2Y5bTduN0FNbFhxVzJSUHhw?= =?utf-8?B?YnFmZEZxU3YzaHFLdk5NS0pkeStHbjRvT2kvc3E3TjBUOWw2eEJJNG9iemlS?= =?utf-8?B?VHYvTmhxbXNmcDRWV3p4bXVPWTJWZExVQTNoTzlXZHBZQmNuL3k2eFdkcm9x?= =?utf-8?B?OU80UkdzN1dPbUVGMjJNbmR5UEcxYittc3BqRUJsdHpRRXh3U1BYc0xYd3Rn?= =?utf-8?B?eTNncXpOcm52QnhRdXgwNkQwR25BRFlZNTJTVCt4aGZsRjhocnJzeXFkVkNX?= =?utf-8?B?YUJUeXdUSnd6aHRmK3NZcnlLeG1uSlRPQS9BMjF1V1o2dDJRNzA0V1FoeC9N?= =?utf-8?B?Ykd3Ylo5SFVuNzYxbHZHQStmZGVrQjc3ZCtGeEg1V2ZYYkxTZ0IraWY4SHVh?= =?utf-8?B?TUFTbG1qWkI5NFFEUjhuaEZDWVg2R2JpdjVBbStqd3dVckpFRkVjM0VweFov?= =?utf-8?B?aFNnMHZ4TWZVa3BoMllGU2IzN285NmlaQVhTSUZra3ZsaXQwMkZrdXZPcTBW?= =?utf-8?B?Z3BhbnZKTyt0T1ZvdWx4alk3VU1aTGo0MDlrd3dtdHd3VjRnTXJWS2FaNENY?= =?utf-8?B?U1FwcjZpZERpT1lLeGZ5RmEwMW5ObklsQUlZY0JQM3N2ZDNmM1hhQTVabHFE?= =?utf-8?B?eHNSTjV4Q3RiNDVkTmNlbjFzYXAybFAxYmtQbEx5VzBLckNZUWQ5M0syekhz?= =?utf-8?B?Q0F4b0VSYU1ycER3bHYxdzEzU21IbUJLNEo5T0xOZ2VWMm14QXFjZGovZG95?= =?utf-8?B?aHhTY0NhYnhIV1dNWVE5N0NrUm00SjV6N3E2cE9IQ2lMREpMMlV4UUxpemVO?= =?utf-8?B?dUFyL053eC90dWhFTXoxM09RL1p0YVZScXdxSmpRWkg3R1pIRFZtS2MxdGFu?= =?utf-8?B?S2FVek1FNngwSFpteFZuSVJ6M213UXlZaXpHZEdxMlNFVUZSMkJIem56OXIx?= =?utf-8?B?VFNaQ0hLNVY2Q1VNYTNaZDR6NnBBM2YyRXBYdDVtN3M2KytoVVVDenlNY1FK?= =?utf-8?B?OGY0cmk5VCs0b0NBSDNrUXd6Ynh4S1JBRU5kN3d6OThzVEcrbWJmWlY2WFZX?= =?utf-8?B?WWhETWFTSlN2UVliYm0yTFV0Tm1sZFJkRmJaSXhNNXRGVC91NDdIdUlyV042?= =?utf-8?B?MWxXMUNUQzZmb0psUlo2UTdvK01uRjJiU3JteFUyOWVpeDZoS2hmUmNvRWZS?= =?utf-8?B?NDlTVXR2MTFWQm1VeVJKZERFZXYwOXl6UFByRzE2RUl1RGpVTkM3UlhxUVBG?= =?utf-8?B?WmNRN04wUVJWb1VhQlk0QlpMSUlVR1U4RSsxZjlaQWVYRGJjMmZaSkx0Rzhx?= =?utf-8?B?Ky8rOFRMajBuL2tCalhyczVaRTQxVkJFekZMT2RQeFkwZnVMWUZRa3l0RWEy?= =?utf-8?B?Ump5Q1F0Yjd6ZG1ta1lBUnZ2aWs1bHdKK2k3Qk9MZW5mQUxMS1JzZE9OdUUv?= =?utf-8?B?WVpab3lST05nRmtIRnN6Tm9kS1QxdDV3NFRaSGM4L2JieFBvenM2aE9OQjAz?= =?utf-8?B?N3RDQ0JWMFhWUUl1S0FVMmxxRmNQNmNGT2Eydi82L2JXcjRsN241SFVVNnJJ?= =?utf-8?B?N05NR1hROEltMEdVUzBFZnJLTksxd3B4SHpXWTV5ZVBHOFNONUFSZ2E2OThL?= =?utf-8?B?QThrVjlBMFlZeVpldTBKR3BGdWY5eWhubG1naDVOL1pnMWs0cnpmRjJWTEk1?= =?utf-8?B?WHViblByQlFGaGtQTitQTFNNN1RvOEJJVUxZdmw1WjQ0VjNydm0xVjRCVFhm?= =?utf-8?B?R3I0WFpLMXhhT3VxeXduZTg5Wm5Pa1VOWWEvNTFFcXVSL050aTQvUVFmNEhs?= =?utf-8?B?UHhJK1ZabWY2N2t3U2RuUUlhWjhOa2duSWwwdE9BK3ZYMzZMV1I0ckYwV1pM?= =?utf-8?B?a056Qnk5cktWUjk0cGFIVnNCUlc4NWpJWmdlVVEwQUZYTlI1aTRUeEFIODFa?= =?utf-8?B?RU5jd0NVd1Y5VHhUYmxkNXdSaWt0aDVQWFBUY0ZYcjdGTUkxTXZQZnU0QXhh?= =?utf-8?B?NFU4ZGRHWjBhT2d0cTR6U3Jxb2JGWklib05ZUHpRY2V6RFVhS0hmSmQrUTI0?= =?utf-8?B?QmJyVDhrYndxYmVsWndoREhSVG5SYzRLMFNPV25FQTFPbkZJVytobUduamR6?= =?utf-8?Q?MpG+xFD7kktKN64Yq6XoGt67O?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: e5a5311e-56df-4041-119b-08dc6c3c37ca X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2024 13:15:07.0565 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tgqzsjFOhmoOiJr4CQutCoVr54qf+mNdPaAiocqwbFYANx50RD96f41YT+/5iD2RuPK65b/qDDXMDb1ZrTn3Ng== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8633 From: Peng Fan Use scope based of_node_put() cleanup to simplify code. Signed-off-by: Peng Fan --- drivers/pinctrl/pinctrl-equilibrium.c | 21 +++++---------------- 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a/drivers/pinctrl/pinctrl-equilibrium.c b/drivers/pinctrl/pinctr= l-equilibrium.c index 6e1be38865c3..e727257bb697 100644 --- a/drivers/pinctrl/pinctrl-equilibrium.c +++ b/drivers/pinctrl/pinctrl-equilibrium.c @@ -588,14 +588,13 @@ static int funcs_utils(struct device *dev, struct eqb= r_pmx_func *funcs, unsigned int *nr_funcs, funcs_util_ops op) { struct device_node *node =3D dev->of_node; - struct device_node *np; struct property *prop; const char *fn_name; unsigned int fid; int i, j; =20 i =3D 0; - for_each_child_of_node(node, np) { + for_each_child_of_node_scoped(node, np) { prop =3D of_find_property(np, "groups", NULL); if (!prop) continue; @@ -633,7 +632,6 @@ static int funcs_utils(struct device *dev, struct eqbr_= pmx_func *funcs, break; =20 default: - of_node_put(np); return -EINVAL; } i++; @@ -706,11 +704,10 @@ static int eqbr_build_groups(struct eqbr_pinctrl_drv_= data *drvdata) struct device_node *node =3D dev->of_node; unsigned int *pins, *pinmux, pin_id, pinmux_id; struct pingroup group, *grp =3D &group; - struct device_node *np; struct property *prop; int j, err; =20 - for_each_child_of_node(node, np) { + for_each_child_of_node_scoped(node, np) { prop =3D of_find_property(np, "groups", NULL); if (!prop) continue; @@ -718,42 +715,35 @@ static int eqbr_build_groups(struct eqbr_pinctrl_drv_= data *drvdata) err =3D of_property_count_u32_elems(np, "pins"); if (err < 0) { dev_err(dev, "No pins in the group: %s\n", prop->name); - of_node_put(np); return err; } grp->npins =3D err; grp->name =3D prop->value; pins =3D devm_kcalloc(dev, grp->npins, sizeof(*pins), GFP_KERNEL); - if (!pins) { - of_node_put(np); + if (!pins) return -ENOMEM; - } + grp->pins =3D pins; =20 pinmux =3D devm_kcalloc(dev, grp->npins, sizeof(*pinmux), GFP_KERNEL); - if (!pinmux) { - of_node_put(np); + if (!pinmux) return -ENOMEM; - } =20 for (j =3D 0; j < grp->npins; j++) { if (of_property_read_u32_index(np, "pins", j, &pin_id)) { dev_err(dev, "Group %s: Read intel pins id failed\n", grp->name); - of_node_put(np); return -EINVAL; } if (pin_id >=3D drvdata->pctl_desc.npins) { dev_err(dev, "Group %s: Invalid pin ID, idx: %d, pin %u\n", grp->name, j, pin_id); - of_node_put(np); return -EINVAL; } pins[j] =3D pin_id; if (of_property_read_u32_index(np, "pinmux", j, &pinmux_id)) { dev_err(dev, "Group %s: Read intel pinmux id failed\n", grp->name); - of_node_put(np); return -EINVAL; } pinmux[j] =3D pinmux_id; @@ -764,7 +754,6 @@ static int eqbr_build_groups(struct eqbr_pinctrl_drv_da= ta *drvdata) pinmux); if (err < 0) { dev_err(dev, "Failed to register group %s\n", grp->name); - of_node_put(np); return err; } memset(&group, 0, sizeof(group)); --=20 2.37.1 From nobody Thu Sep 19 19:38:14 2024 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2061.outbound.protection.outlook.com [40.107.22.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE8DB374C4; Sat, 4 May 2024 13:15:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.61 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714828528; cv=fail; b=AryvWqtp7YdjoLkRLY4mUVKipCBm7LlSSehuZAEgKincTouvhYaWudE6S+C3kSVeN1SMYaA+MxWsktxpaZeT7CehlxEcBnLYY01aDtwllBlbUJCUlaPYknGaOZ/xmbgQ7LSLmzuOvXVwQdDmvX7MiVuchg8PeRTE2xEw1yM5UdE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714828528; c=relaxed/simple; bh=vjEL2SocH6lGT0TAwBIfY9y3UDdKYLa1JTfpR+eS2MI=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=kTysqc5GK2K6olGAbocV601QXNzM0cgMxbfX9sOWcwx7ag67lCDv7bj9gou3aMR/S81+pBjoc5ZZoGo7pXvRaWXBBp/Gm39OT3FZnnm7msEJLToz6YwrAKrPMRu4U1wZqsr4VoDzmZb/4MPrQzTqOnFnjidxRm4gaI0Mz17Aauo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=Q4Jz55xP; arc=fail smtp.client-ip=40.107.22.61 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="Q4Jz55xP" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hRU9oD+gCI8AllMgq87kzYL6LXgAyv72q3OQ/wuyed31OEyiMWOvAbbwCe2VDTrMGg7Z21zT+QvWhPpvyATZZMARpENnA7ZqepQTlF59zLf/X/5AKmsBTq7oII/9pZCf4A8a5FXe+t/s4ydIlnhtAALAj1ZAHuDhPyqevcT9D0pS/vhtA1V8oQA3nI4y8DXqMbQpAdIQG+bAmklpviHJtaa7JL+EFiUXCq6rnh1KlJCM+36n4EMM/PaMbLznoADLf3DD1Xm7VspxiWLIQN0tuesytE2bO6iUuPFugXeufpsK5ZfKDIj7HMeAoGtj6duSvp7FYuPxZXwYr0gR7HzuCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UOvnEs+skM9QGzIMn0U2l0iY/qhwIQjWYjJlD4x3FDU=; b=ZQtFwx3xBDkDdEM7F4IIc7StjJF8bribsUK4x97ROf6xfiiuumqN/lvIh7FUz8Iu59kbTzrkml1QsvEM6yerGPDt6zeKLxPxQJAmbjQ5N+fBGpw1Id6veuETaP3d58OA/cA/fAJrHAnl4RU3DPIUXJRBfURgNkL9hpwMKkrGTVxE11hHopj/LbpBrpzYRHU4kGoyR/QKTrwg3lJ3nIEF12N9WrPjS1tGVUHdBXs1v+AlZZB05s5XqqafSvAW0WsFMQlc/3x0Mg8RmvUOPQ0XfQrGYpvU5TLE/WoO5evD3aNPKGs/C4+Ce5jawr+/iu+J74MUNt5OOPmTIHNKkvaXaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UOvnEs+skM9QGzIMn0U2l0iY/qhwIQjWYjJlD4x3FDU=; b=Q4Jz55xPVklCOEhMsIghTu/K3ZsdV8zlhwWv8DIvis7TbOkzUaaeOjLpP4fFECNj86SLMjx1DeNL3Nk+SB2N0h7fVfvvayuYmpqAUl5oH567Kmet+LwjgGAEtCb5RJAh7fyYnmONkciEG6hEXyTcmCRq0yjWkgehl/QCgbrVwM4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by AM9PR04MB8633.eurprd04.prod.outlook.com (2603:10a6:20b:43c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.34; Sat, 4 May 2024 13:15:23 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7544.036; Sat, 4 May 2024 13:15:23 +0000 From: "Peng Fan (OSS)" Date: Sat, 04 May 2024 21:20:09 +0800 Subject: [PATCH v2 11/20] pinctrl: at91: Use scope based of_node_put() cleanups Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240504-pinctrl-cleanup-v2-11-26c5f2dc1181@nxp.com> References: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> In-Reply-To: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> To: Linus Walleij , Thierry Reding , Jonathan Hunter , Dvorkin Dmitry , Wells Lu , Maxime Coquelin , Alexandre Torgue , Emil Renner Berthing , Jianlong Huang , Hal Feng , Orson Zhai , Baolin Wang , Chunyan Zhang , Viresh Kumar , Shiraz Hashim , soc@kernel.org, Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , Geert Uytterhoeven , Patrice Chotard , Heiko Stuebner , Damien Le Moal , Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , Chester Lin , Matthias Brugger , Ghennadi Procopciuc , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Sascha Hauer , Andrew Jeffery , Joel Stanley , Dan Carpenter , Tony Lindgren , Stephen Warren Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-mediatek@lists.infradead.org, imx@lists.linux.dev, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, Peng Fan X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1714828815; l=2885; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=PFAUzME6mdXWvdeIt8xe3iTmfwle3TOSpNkHGUiPLOM=; b=ZSqBon2rMgrekfypu2BMfK1KhgN2I4TeLQnuA6cTenlBlAU32e6ztk3KfhwVMkDVeeE23HHUz fSXhosqCh2LAS4Z1TF9PJfbt7eER3+wURlcwJ8y4XASWKf8a+ucTYNC X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR06CA0230.apcprd06.prod.outlook.com (2603:1096:4:ac::14) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|AM9PR04MB8633:EE_ X-MS-Office365-Filtering-Correlation-Id: adcae72d-abe6-4074-1525-08dc6c3c41be X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|52116005|7416005|376005|1800799015|366007|38350700005|921011; X-Microsoft-Antispam-Message-Info: =?utf-8?B?d2d2alZMNXk1eDRUTjJDVDZsNTRYOGdTRUNycUNFbm5OY1ByZFJOZVAvb21O?= =?utf-8?B?ZVZRM2xoeXNJZDBUOVBVZ3MxcElUNktickYzMFNrRVpnVCtHbzRXdXpxOGM4?= =?utf-8?B?MW91MTEwd0pDK3VNOFV1dmNSNGNhVG1SMGdldXNhMTNRbmo5Z0dRekl2WEVM?= =?utf-8?B?dEJGZUM1aDNwY00ybm5FRkZvbW42RzhrRWFXUXVxTzI1VXp2cEM1eS9saHds?= =?utf-8?B?b0NYbmxZdk9tVEEzNTAzRENxa2t6WWl0SFJZajNrVTcvbDYrcnhvZ3p2Z1hL?= =?utf-8?B?SDlSUndFWGIvRmlZR3BKVXAwcU5ETjRUL0hoSzFQZVFqR3AzN0xXYXBQem9C?= =?utf-8?B?Q09kWExuSDRWcnl2aFgyVnN6bFg3WnQ2bU45c1BlQmpLeFluOEJxQjZzOFFR?= =?utf-8?B?dDRiclJGdkgveGoxcTJGRkdQRlIrMGFZTXF0eGR0VjFOMWRPM2VOWHNuWHkw?= =?utf-8?B?RklQTTk3Wk1JNEwzY3JsS05xeWlOYmFBZENsNDV4S2UxeVlYd0U0WkxRNW9Y?= =?utf-8?B?UzZUUDRJWVlFN0dqYVF6U09keDJNOUlTZm5kT29iSFVydzBHbUZwMmZLUDhZ?= =?utf-8?B?QXplYm9RVW92Q1picWxNREo4MkUyY3NnQ2NSb0k2U24wRFkwRlByZlFzWEl1?= =?utf-8?B?VHgyeTZxbFZzZUNCNDdaYjhKQnBVd0J0OWRIbHdlaVhwVnJMZ25RL0NXMGZM?= =?utf-8?B?U3pzSU1EdGNSMXVQV0J6Vnp5cVduL2RqNFdJcWViTVdhMVBsOFVIbFoycU1v?= =?utf-8?B?aDVvYXltWUVENExZK0pwQk1PTHBJTlNWNFhXZ0d0TW1BRVZWWUFZVnkzR3JC?= =?utf-8?B?NzZLUnFwS3lHd21GYVMyK1BxQmt0QlpuL2Z2dCtqQmxoR0pnNVFWM050Nkcx?= =?utf-8?B?MkhZS0NSbm16U2s4UExDVjFIZGRUMExEemJiTkcxWWN2SG9JYU5WeDhyZDNM?= =?utf-8?B?TjAxNkdLa2o0NkN2eEZFWUZHREpaOXVwek9vMWtkTDg4SXdPY3ZYT3cvMVNr?= =?utf-8?B?Z0VYUkVpUVNVeElrd0dHZk4rMytoa0o2MzhSZ29tOXZIckc3cDdsOUp2blNh?= =?utf-8?B?ajF0MGs4Zi9nNUtlbGFDQTBXTlA2V1RXS2k0R29LRkZvemo1ZElwd0tsSk41?= =?utf-8?B?Y1BraTdDeUJGWHhFT2xMZ3o0TDJGc2xQY2cxdnN2alZ1SHArRnlYUFQyVlc4?= =?utf-8?B?eWtKa0hIbEFFKzMvUE9XaFYrOVh5c0ZsaU91bmU3MGVGV2hGWTNSVC9sQWJu?= =?utf-8?B?K2lRcmJDOXJiZEU4YW1BNTAycHFPR091a1U4aVBOTlFyZTA0ZUdCQVAraGo2?= =?utf-8?B?aVVKSnNQcEMycGppV1dYb2NyNm1VRnVsZUVCLzAxeFg4WlJMa3FkdjROTjBy?= =?utf-8?B?clA0NUNTWmZhZHRVdlAwaFoxcXlaOFRsa1lJandvVVY2NytVV0ZXTzE5UFJw?= =?utf-8?B?VGZybmxhSXUwdVNXd1ZyVXRLcExnVDBUdGFKR3pvMFV2MnMxS2RJUUtxWnVu?= =?utf-8?B?N3Yyb3JYMmtSR1NaZ3BER3llbmZleUFKWHpzdTM0YUNXdWluU2R2SnZBT2VO?= =?utf-8?B?SDFFQytKY3gxNjNhRk9NM0lrNm51aXJrQnZxUjFteDEvaC9VOTE4Q3NKWktn?= =?utf-8?B?cHdOWEhiMlR5dUNLNjJjZTQ1U1lLN0puZHNpME05VUNqWElwU09DaXI4NXhC?= =?utf-8?B?bC93aWFMSzg3aHJNL0hSN2pKSE9GbzJnS0NmeXdKWmZpWFB4T2tXZTBjbEJs?= =?utf-8?B?cTlvYzRQRXVZRmhxd3R1TlFKdVcrb1h1OXFVdzQ1bGpSVnYycS9DKy9TdS9O?= =?utf-8?Q?AeNgSFXZ1D4SbbfRoC/28qHQUav1CRC/GCi+c=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(52116005)(7416005)(376005)(1800799015)(366007)(38350700005)(921011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TzV2RktubG96ZnVOQTFBK2djcE44bXpDeU53dVRQbVV6WVAxV1cxWXFkS2RM?= =?utf-8?B?dVRvUmVVajh2VmsxVmRKRnJVdlZPbmR2bzhGVytwMi9EWVVDM0xGZFJKa1BU?= =?utf-8?B?eklERXZ0SXVmaHNrbnFPOXQ5MmxpMjZiM01MZWFjam9ucWdkT2JZL3RpYmRq?= =?utf-8?B?cTdvdUhIdWVWWnlOSkFmcUY1QVhPbkZ3aFBYM0VrWHU4UEFEQjlTOE0zUGJs?= =?utf-8?B?M2tJK0U1TjhpVVczaWRLbG9nTlJpdnRkcnpmOFlvTzBYTTg2Zk0yYTcrQ0lP?= =?utf-8?B?TEtYeGZkb3BZaTM3UmcyWTZmVHo1RzBTdVhQcUxiZ3AzUThJT1dxUzQyT0Z5?= =?utf-8?B?K1ZvRnJHa0J4WFhWOGZOOXJLRU1JRDZYOXFsQ3lCcW4zMzIzdHJBMjNrczlO?= =?utf-8?B?VzhuRE1KT29CR2l5SkY0QkNScFFHTnd2WUN4Z0JDbXZjeEs1SzkxVXpYbjRt?= =?utf-8?B?UGFFZkdLdkpPa0J0WFlyOGRJbDg0bDJBa1diUUZ4OEtKemlmWGMxMG0welg1?= =?utf-8?B?cEpabzcwMUhKQUs3cjMybGdnaW16L1FmZ3NqcnB0enA2WUxyekZPby80YWlI?= =?utf-8?B?ckI1UjZCS1FDZ0hDY1dzUlZvK2hBZ1kxL3VRc3J3bW15eC9Xa25WYnFMTWs4?= =?utf-8?B?czA3OUcyV04rZFBNdFF0ZStDYlpBcGF3NytSaHJHbGtURVpmVlUxQXlNTFV4?= =?utf-8?B?SUlsMW1ENEducDE5ZitFOVNnUmJ4ZFRMK1ZDTkVOalUxczFmMDE5VkVBTWdJ?= =?utf-8?B?Y2sxczZXQ1dja2NCWUpBM25GT0RZYktaczU1RWluSmdsT3B4ZTVhdkxJMnVZ?= =?utf-8?B?eVpwYkFRS0FGQ0RsTldDOVp1dnU3eDhtZi96c1h2eWRtVXVYYVlmaysrL3F4?= =?utf-8?B?REJmYisxTksyYXdYd3hQeDNmL3F5cit1S0E1SEtsaDh4SDA5VGpqbi9JZVhu?= =?utf-8?B?SllaWTRlc3dCeVo4OVIzS3VqRndTSmZLOWxxNURyT0krcVQ2NmVELzdOVlBN?= =?utf-8?B?SjBXSHBuUDFDV0FGS0crSlgxNm05K1JEMkE1c2dab3dZNFA1cEJhNGhvYno5?= =?utf-8?B?M0h4ZnJabGRZMTQ1bG5WeFpsR2RMdWNsTmRzaGdjenk2TElXaWd1b1ZaV1Ur?= =?utf-8?B?dXZZYlJjcmR4aWFuWnAySWJMVk9VcnIrdGVDWm45VTVFUXVpaHl3TGRobVdY?= =?utf-8?B?Q1N4eEtoUkd6Q1RvM05YRHEzZ0R5VlEwc2w1UmNaWmFxMVY3aTVjK01tTDRi?= =?utf-8?B?WGdoOFVKQWpQYkU4WnZQbGVSQkpYMFd3V1RzMU5MZnkwQldPMVBnUktxQ09V?= =?utf-8?B?NnMrOU5JY0Nmek9MejlUY0JhM3U4ZzVodXdmTmhXd3MySWJHRzZ1NS9MM1Rm?= =?utf-8?B?dHI4RGU0SzlmNVZnZVhSWGVKNUVQSWJGT3lXNVN6WUlDSSt0UzZja2xLZndM?= =?utf-8?B?Y25HVVNFMS8xMVd1MG9WMUVzamEyWmd1TWg3aUVPR0tYVG1QL0FxbzJJSHhz?= =?utf-8?B?anBBSTBWaFVrSlcyVEhSK3l1Rm5pY0lYdko1VC9KaWN5SDJCeXg2NXpDZk15?= =?utf-8?B?U3BVbFV1YnZEQTBkeHdOMW9jdHJ5UEh3SXJEQk5KT21mcVUrdjdTdU1MQ3ZL?= =?utf-8?B?WEZCakRiSkV0RUhGZXE0YkhYY2tVMXYzaGtOWUJUdGpVS0JoNloyVW9wUVR3?= =?utf-8?B?M3pKaS94TUQ4R1VZeXlHS2VUOFJWRnBMUWlXcDJ2NG11NUd0bzQ0Qkk4bmNQ?= =?utf-8?B?WXU3d1pIeVdpeVBaNVgreFNGUUhrajRmWFFWN0RMWUVNajFOZUJlYkp1Z3ph?= =?utf-8?B?UURxNjRWbExNTHErS1ZWVVVmOHJrWGZ0U1ZBOEtyWEZyLzBtVjBEVndtanJm?= =?utf-8?B?cUlmM0JocFlzNHBYMk5wYjBDdG9XdWVMV3h0RzdMQmhxeVlGT2Y3aWVLUG5j?= =?utf-8?B?NnRJUVpWbGJHQmphaTIwU0wzMGE5ZVN1S052RnVVK2FEcTdmTlZxY2tSSXpO?= =?utf-8?B?SGUrOG9ycE1YYnFkYTZYOGJPUW9ROHRuMFd1SUhudUpkaXNYSGovcnUwR1FH?= =?utf-8?B?cDlnMExJU1B4TjdMa3ZNZjQ4ZjVSUXY1RlJPY3FXU3B3MlIyTVNpMG44eW81?= =?utf-8?Q?vNmDwXu6KJgBACKRzrJkDD5gF?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: adcae72d-abe6-4074-1525-08dc6c3c41be X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2024 13:15:23.8049 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sfw12hIrvLjOgg5lbK8eknU3BCindbFYEf8fy2r3veI8lqSY9cN3GZHug0TMbaqAxJ3Pgh4eLG/BLrXZbhpy3Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8633 From: Peng Fan Use scope based of_node_put() cleanup to simplify code. Signed-off-by: Peng Fan --- drivers/pinctrl/pinctrl-at91-pio4.c | 7 ++----- drivers/pinctrl/pinctrl-at91.c | 14 ++++---------- 2 files changed, 6 insertions(+), 15 deletions(-) diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c b/drivers/pinctrl/pinctrl-= at91-pio4.c index a27c01fcbb47..8b01d312305a 100644 --- a/drivers/pinctrl/pinctrl-at91-pio4.c +++ b/drivers/pinctrl/pinctrl-at91-pio4.c @@ -632,7 +632,6 @@ static int atmel_pctl_dt_node_to_map(struct pinctrl_dev= *pctldev, struct pinctrl_map **map, unsigned int *num_maps) { - struct device_node *np; unsigned int reserved_maps; int ret; =20 @@ -648,13 +647,11 @@ static int atmel_pctl_dt_node_to_map(struct pinctrl_d= ev *pctldev, ret =3D atmel_pctl_dt_subnode_to_map(pctldev, np_config, map, &reserved_maps, num_maps); if (ret) { - for_each_child_of_node(np_config, np) { + for_each_child_of_node_scoped(np_config, np) { ret =3D atmel_pctl_dt_subnode_to_map(pctldev, np, map, &reserved_maps, num_maps); - if (ret < 0) { - of_node_put(np); + if (ret < 0) break; - } } } =20 diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c index 5aa9d5c533c6..b3c3f5fb2e2e 100644 --- a/drivers/pinctrl/pinctrl-at91.c +++ b/drivers/pinctrl/pinctrl-at91.c @@ -1244,7 +1244,6 @@ static int at91_pinctrl_parse_groups(struct device_no= de *np, static int at91_pinctrl_parse_functions(struct device_node *np, struct at91_pinctrl *info, u32 index) { - struct device_node *child; struct at91_pmx_func *func; struct at91_pin_group *grp; int ret; @@ -1267,14 +1266,12 @@ static int at91_pinctrl_parse_functions(struct devi= ce_node *np, if (!func->groups) return -ENOMEM; =20 - for_each_child_of_node(np, child) { + for_each_child_of_node_scoped(np, child) { func->groups[i] =3D child->name; grp =3D &info->groups[grp_index++]; ret =3D at91_pinctrl_parse_groups(child, grp, info, i++); - if (ret) { - of_node_put(child); + if (ret) return ret; - } } =20 return 0; @@ -1296,7 +1293,6 @@ static int at91_pinctrl_probe_dt(struct platform_devi= ce *pdev, int i, j, ngpio_chips_enabled =3D 0; uint32_t *tmp; struct device_node *np =3D dev->of_node; - struct device_node *child; =20 if (!np) return -ENODEV; @@ -1349,14 +1345,12 @@ static int at91_pinctrl_probe_dt(struct platform_de= vice *pdev, =20 i =3D 0; =20 - for_each_child_of_node(np, child) { + for_each_child_of_node_scoped(np, child) { if (of_device_is_compatible(child, gpio_compat)) continue; ret =3D at91_pinctrl_parse_functions(child, info, i++); - if (ret) { - of_node_put(child); + if (ret) return dev_err_probe(dev, ret, "failed to parse function\n"); - } } =20 return 0; --=20 2.37.1 From nobody Thu Sep 19 19:38:14 2024 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2076.outbound.protection.outlook.com [40.107.22.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FE383D0D1; Sat, 4 May 2024 13:15:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.76 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714828545; cv=fail; b=cmVs+NTSjWNjcHNAVOZjEJ7116eiBdKJLGfk6ShxrV+uH9JpsZJhl6qBjj6Pxch70aEYB9EgsGgG5kSM2X295vXX2fz8ZhX2N/tOUZdKYcRwYVgLmJ3tY9OItuPj6ksret/TT/U6l1vZB3kAUn7xSfSF1pDZ2OwP80guYnDZxuU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714828545; c=relaxed/simple; bh=XjYcrC4knEYcZi59FiMv3CxGYKeUFr0HCFF+UrzXVqE=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=bNPdy1MrdJUKSoXP+ufOKTFu23TBJotMNVff8jCHciC4Tf4jYg+fKFQrDgJljd/20o+RKnITkEVINLrOEJJVi6I78IW3X0YmFY8aAobSEttKt2da2AQxZ1ALSJ/rJImkVT8Wh2Gmj9CgmE0dDlT09LgOi6GLQTLQ4Jv1v3KsWRY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=ikUa133S; arc=fail smtp.client-ip=40.107.22.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="ikUa133S" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W13wp9FiM++nWc+Yz28yg2bbPZLLdw+WTg1bDgGDy97n7my34QTBMGJm9rCBvzp1jMM40UEGyYOCjXD0zS8w/4qkYpLKQvl7qMriD27ylLz18r1NRpGpx71+GEwMlRijcmKKUhs+CFXmH3G9kKcmBss3HTxz6j5/wfn2/ZkDbfipOOFZwJudnMiD2ird4Hc/j/vk2HMY4xe4rTH60RivfIHTmI/7r/gxMu5AU+cvfzkbp3oXgi+gdfEF2NaAknoNou+/0PzqNZ5+f40vNXUDVNCCLF71gCdSTz7Sj63iiXWC0PUSOU1MYg18Pk0DfHCpTkaY8eI6SEW49xo2CPrxGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lfJwrgHZf+RNEj6PZEelZwXcext4Fk8ZGEAWxpPRGZk=; b=EhXMCkb8gOkREMgpBl9dMK0MTGtMhyMCwsI/DCmdxXmz2BiDju4e0MARf+kdgnef3ekgtf/sA9wJjhLkLd6Woccc6Qi0oJ9qXs7HxQ4XHHn9TeSdhapuG31Hto5GwfCrDrrSFI74qAb7guux+hptHu8hvQZKzhaSYIDPhsgyorjn8xKgNNXFlwfRhwKyWTt7SG6vfhYriDHOeo0SOkJBpHhlAi6OWt4yqsUYKvHFcL4PAVylfJghDn6Pv8pNNg/UwTdNciF4jQVyFOU6oSCDIwWY4aCHM1nfV3820Dw/nCDJc4Pwz1nHR6zgMJtCOq8jckdo093BlwodHwDiJ8gSQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lfJwrgHZf+RNEj6PZEelZwXcext4Fk8ZGEAWxpPRGZk=; b=ikUa133ScwGjkZxB3mOk8JOHeMMaVQC05IL6z7ifMBDxhZikG5oDN5sD5QpBRr4tLPYGOACUrjCuJdwC44Z297sorvsDzH3xZIa//z39u4jVbrh6HxrLaD6DnCKoTP5EFf6x/zLkmrhHCBDTN7wVZUv4UsoaReDqBrH4StYeQPY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by AM9PR04MB8633.eurprd04.prod.outlook.com (2603:10a6:20b:43c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.34; Sat, 4 May 2024 13:15:40 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7544.036; Sat, 4 May 2024 13:15:40 +0000 From: "Peng Fan (OSS)" Date: Sat, 04 May 2024 21:20:10 +0800 Subject: [PATCH v2 12/20] pinctrl: s32cc: Use scope based of_node_put() cleanups Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240504-pinctrl-cleanup-v2-12-26c5f2dc1181@nxp.com> References: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> In-Reply-To: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> To: Linus Walleij , Thierry Reding , Jonathan Hunter , Dvorkin Dmitry , Wells Lu , Maxime Coquelin , Alexandre Torgue , Emil Renner Berthing , Jianlong Huang , Hal Feng , Orson Zhai , Baolin Wang , Chunyan Zhang , Viresh Kumar , Shiraz Hashim , soc@kernel.org, Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , Geert Uytterhoeven , Patrice Chotard , Heiko Stuebner , Damien Le Moal , Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , Chester Lin , Matthias Brugger , Ghennadi Procopciuc , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Sascha Hauer , Andrew Jeffery , Joel Stanley , Dan Carpenter , Tony Lindgren , Stephen Warren Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-mediatek@lists.infradead.org, imx@lists.linux.dev, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, Peng Fan X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1714828815; l=2925; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=DE1TsODFhZuLZm6pDc3wReEJgqgWx9DxsgygoDyK3OE=; b=4lPD+sR8+ZJDBmnUSGc4BiJR63BC+fsZ9sA6ZLC22ieCU5l/dWZtPjTnnXlLTXwDaVFM8DgGy HeQBDCN8beEC267VymO0c1EOJ0IkKry6T9AQEMkG8hUVyAvlluXu2Hk X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR06CA0230.apcprd06.prod.outlook.com (2603:1096:4:ac::14) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|AM9PR04MB8633:EE_ X-MS-Office365-Filtering-Correlation-Id: 0b200d19-f7e4-46c0-a449-08dc6c3c4bba X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|52116005|7416005|376005|1800799015|366007|38350700005|921011; X-Microsoft-Antispam-Message-Info: =?utf-8?B?eEhMUEhleVQ5dHNIaFMvZXZEaThmWkNEd3crdGo0dXRvMUhUVGhvbEFZUDcy?= =?utf-8?B?N3JxMkRkeExOZ2tjcUZpLzU5Ymxtd3hJejYvQk92WFdQVjJ5Y3BEQ1FtMXhT?= =?utf-8?B?SytJcThEWCtEWWNDRGp2TEpBTXNnUVVNV0tjemNIUnpYY2RlajFqV0w3aThw?= =?utf-8?B?UXB3M0pmRnRVYWZvaE9YZnQ3UkhwOGRhV3FqcGJ5WnFVRmVQVWtPVHRVb0xO?= =?utf-8?B?TngxaVhpNDRLeDVFYTBaNCtmU1NnSmwydlk3b1RneitidUR5MGh4ZWl3MjBt?= =?utf-8?B?SnliWEdvdVVuYkgwOWc1ak1kRGFKVHZDdW1iSHU3OTF0cy82TFMzQ1VZV3c4?= =?utf-8?B?am03cUltWGczMnVkb3d0YUxRSU5XNXMyY3JCdVlGYm00Z05FQTJncytoTEtE?= =?utf-8?B?UzFMQnZnMjlZUWdMWnJ5NC8wWDExa2Qza0tmTUtSdms2TTAreU1yUmZ1MlpT?= =?utf-8?B?RFQ3bkU0Njd2cEhvL3RKUVlodnNjdGIybEFPQ0pwbUhOSURZcHQzd1hjWjhk?= =?utf-8?B?WjQvUm9UYXEyMFkvYjJReDF3ZHNpcWtOenlmVVFVUXNETVpORkhtd2NlRTky?= =?utf-8?B?K1dzUkJxd1dybG5nN2tva3FkejVDdUMvK0Nqei9lKzl5Q3FxQlhvQUg5SUVM?= =?utf-8?B?Q1BXNWs4S0lXWHFibjFjdmMyRkFhL0VSZGgrWU9zN3ZtMTJvbUQ0WWNPWHFT?= =?utf-8?B?VjN5U0Y4czZDcVJFdGVCNGhaNHk0SFprSTFHNStmMFFweTgyT0ZxVTBaU3Rk?= =?utf-8?B?dHhMZ3k2dCt2THdXNUU5Z0xselV3eEVGcUppdUd5Vko5SjZUbGVtUXYrYjdx?= =?utf-8?B?VjhRV1FHRHRid095VmNZNk5zSkRuRmRyWmxEUXp3QXhpYTRWSGVkRUFEcFdq?= =?utf-8?B?R2lLZGthMU5mNGFKL1d4L05OeFZRWGplUml2VnFZTkdXODBXYk9jc2NSTjRT?= =?utf-8?B?VzZpN2xFS2VJZnZlNjlGVE5oWE1SbDFnMEkwbGV4NGZoeXdmbzlDRTRrT0Rs?= =?utf-8?B?MDhUelk1V2dQZjVvKzIxTEZlQ1BweEQwNEhDRitiTWtvVVhqdzh3V3hiMW80?= =?utf-8?B?UEFJMGc2QWdKMlIySzAvWkdsOXc5aTJRWmliWTdjMUcrblhWQTBSMms2WXVw?= =?utf-8?B?Q0VQL01kNm1JMnNxMFRUekVQTVp2TCtMbExFa3hHalM4UDJmbWU2MGRVZVVl?= =?utf-8?B?aG9ibEhHSjN6eHJqS2tyeFY1NWNQbk0vYTNOWmphM0pGQ1BjcGVVUjlpb3RM?= =?utf-8?B?R1VUeTJBRVZNeTdkU01IaGIrMnQ3RlpuNFEvdUtNdmFQN2NWdm9iZ1BRZ0g4?= =?utf-8?B?OFNMb2lRSGRzT3ZJQklqV3BKQlh5YTl4YlpzZ0ZvUkt3TGNrOWp0VldQUm5o?= =?utf-8?B?a09jY2ZqcVBtTWdmd0hWS3dmY3puSSswaWRKQ3lxSmZCWmxsOEsxSjRJeXpT?= =?utf-8?B?OEFiNWRQVzlScDkxOGtaMjBLZGVqd0ovZDJWa0w0V3pKZ3pKNU0vNFkzSHU4?= =?utf-8?B?V3VUMFRJOHoyRlAwTUpscjNOWlMrV3ZQMGxxOGpIMUZRbE9Pa09DcTF6cFNY?= =?utf-8?B?VERtL0FUellpa0tteVc0NnFVa1lMRWRrYWRvUml1TE4wdlozVGM2UmdaVHFX?= =?utf-8?B?VnI3UXB6d0lkb0FCRlVSdU8venpBMFh5WERENXQwc0FXOG1yRWptbWRPbE1n?= =?utf-8?B?dkI5UWxScmRneGdmWkJCWHRzTTg4bFJTZndDbG83TDQ0ay9LOU8rSndtTmtk?= =?utf-8?B?aXFmQjgzaE51Z0c5bm9FUWY2dG5vSE9tUEhhMU1YTHhmT3Nld3pRRVZjSUlH?= =?utf-8?Q?LgRsGUyWyLAPOzeLd8VCUWsMPdczJRUT9D+Qo=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(52116005)(7416005)(376005)(1800799015)(366007)(38350700005)(921011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cDZvNmFibnhTVDZEb0NpakZwKzJCbm8wNU5aR0d4T2tMYUFwSERWUUxacmxx?= =?utf-8?B?c3V4TmVWNHpWZWdWVzlyaTdrR2pwUFMyTjBwc0FUSTl6VUp2b1F2Q24xcVE5?= =?utf-8?B?OHFQbm96a01PMXQ1bXNXV2xTek8vSm9VSEd5NXZqNnl2R0JldlAwd1B4WWtP?= =?utf-8?B?amt4ZThaY3JVQ1Y5dFA2alM3NXVtZ0d6M3JTTkJ0YXl5TjhzbUZjcTZOdzA4?= =?utf-8?B?a1dYQUxUQTk0Z1NGZDhNY01ISEZ1V0J3KzhRODNoODE0QjM3aENBd2ZiTGoy?= =?utf-8?B?dmhNNkVtbEh5MlpOQWI1d2xWa3RZOHJtUGdKTUFPaFA5a0duaWxJRlBBNmM2?= =?utf-8?B?ZGlxMVJJeUZTRjU2R0lGRVlYMzA0aDByN0tqSXJJMzhOQ25YTThRQ2EyMkQ2?= =?utf-8?B?N1psZFVTRTNmeXVkNUZyazQ1UWJmZGwwbmtlcmRvVEIzYVdodVpXbDZ5a3lT?= =?utf-8?B?VFo4T0Y1U08reVdQSUVJd2lZOWl5UXV1WFVaN1RFWGxsUGtxNVF3V1V4Rm80?= =?utf-8?B?SWQ3YzRsYWtGZkJnZ2hPQW5ubVBMZ0dMSHlYNEswbjNLZzFZM1AzRElFNlFn?= =?utf-8?B?bzM5VWZBZ040OXNwNlgwNURVVEtXd0JWcDNxa1pLcU8rMFRtUWZQYjZWUytW?= =?utf-8?B?THJTWjZLU3RTZmZ3Vk9nNHNYdmhiNnpyVDFDc2FlbEVDaEdHVVkyUCtUZTl4?= =?utf-8?B?TEZWcjhibm1JTFJyd3lzM2xqVUN6VUhla3BBUGdrNVUzWk1rT1JPVU9sTS9D?= =?utf-8?B?TXJydnpoZlhVTDAzbmk4UFZ3OEUyeGlmc3VlMk0rRnVTYVFqbkprS2lGOFV2?= =?utf-8?B?cTE2L0JpYnEwTHlxeW1xYW1HNCswU0hrcnBXMUpUL09XYitjNyt5Qm9vVFA5?= =?utf-8?B?ZU50blNsWUxkRGE3Y2ZTZms4MmNyb2EyV1luTlpabEZ1ZzRjSUl1V2pkWEJz?= =?utf-8?B?Qm1URVFxM2crS3p2cFhKTlQ3VHFoWlBUckUwMXpackdkZUV3bE1hYWFyRkd3?= =?utf-8?B?QWRLYkQyYTQ3elZ0VmFPSE1yZjg3cjZ6MXJRc0RHU0JLb2FITkxRcFhoRmpC?= =?utf-8?B?WTFNUExtRlI0T2VzMGdrOEJKWkVHQnd2NTNvb1lWQ1QveHh2OUExNENLVFhK?= =?utf-8?B?ME05MXQ0c2NmLzVGL3ZkbXJsR1NnK2FHaHdlOG5vN3p4WVhMMzNua3JUcnF1?= =?utf-8?B?b29WM2ZDbFpETDlmTE9uVlZIWlppNU5LNWRudVNvZHBWYTBtN0VzTWNqZVZZ?= =?utf-8?B?a3c2WldqQzlqU2sxbzFhL3BRblkzTlpzMktEVHFRUmZkaWcvT1lEUXV5eDlG?= =?utf-8?B?cWdXREpRaWgzWXVVWktRMUFLd2FpTjNKa1A5b0RGdVRhQitVditJS2JBaW5Z?= =?utf-8?B?MGZmUkZ2VUtqR21hSjZJSklVNE5MMlJPWUxmSUExTHBkRVI5UU1kKzBpNlhL?= =?utf-8?B?NVF0cGQ5M3A5c1l2ZnFBa3NKZDJYWnlaNGpROXpzQ1h6b3Q3V3laaUVqUWFq?= =?utf-8?B?cXZzSThEeVJ5MURWSW5mRlU2S2VlSFVib2w5ZlBzcU80YlM2OTAxVmZmcW0r?= =?utf-8?B?ZkdFZ2phUUlqdnFXOGhaNHZqMnZHWGVvNUZScjN5ZDBSVWUyZTNwcFFDS1Nm?= =?utf-8?B?WE1POEhscUsvaUFqQnBCTFdIeEo4bVA1SjVlRTdndGpwcGdTVlFqaXJmQjV2?= =?utf-8?B?SEFqbjRGVDdralM5VU9LcjlFdEcxVUIrN1djai9URkZReG5YUHQwd01WMnJk?= =?utf-8?B?dHVjVFhkUVIyRk5ReEpFejAxNkh3SUIrMUFBTCswc3YvdzhTZGZ6WGxWY2RV?= =?utf-8?B?L3V6VDVxRHowVlpESU5RMmFZOWVJZ3hjeGRoMGxvWStPZTl3b0kySEdkOHlK?= =?utf-8?B?NTYvWkJFQlpHd2lBb002cGRqUUNUeGZ3ejRwR2llZFpMUEJRMDd0ZWsxZEow?= =?utf-8?B?UjZtYXJ5OXUwSnJYUmdzMWd1a3pnU3F2QnhoK3k4VTFZQml1alIxNXNlQkxG?= =?utf-8?B?elY0Lzd3aFlqdHB5VG5TNncrWUg3SVpUV0YrYkhiYzF0NU0wQkQrbDY1QnFP?= =?utf-8?B?QUU0c2EzTFpVOTJoZHRYNmdpVmJLbmhaeHZKYnE0bUhUNFE5QUk5U21uYVgr?= =?utf-8?Q?vfyGxGNZKkduzNzMELAK2Gje/?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0b200d19-f7e4-46c0-a449-08dc6c3c4bba X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2024 13:15:40.5200 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kTB7cM73P9h5jqKaR9YGbwVTQwji2+xZXBGT2FJE8I8Ox6V09qZ1W0fqCU0ax8qp0sCNCd/aXZ64mGZHFKS8kQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8633 From: Peng Fan Use scope based of_node_put() cleanup to simplify code. Signed-off-by: Peng Fan --- drivers/pinctrl/nxp/pinctrl-s32cc.c | 31 ++++++++++--------------------- 1 file changed, 10 insertions(+), 21 deletions(-) diff --git a/drivers/pinctrl/nxp/pinctrl-s32cc.c b/drivers/pinctrl/nxp/pinc= trl-s32cc.c index f0cad2c501f7..df3e5d82da4b 100644 --- a/drivers/pinctrl/nxp/pinctrl-s32cc.c +++ b/drivers/pinctrl/nxp/pinctrl-s32cc.c @@ -268,28 +268,23 @@ static int s32_dt_node_to_map(struct pinctrl_dev *pct= ldev, unsigned int *num_maps) { unsigned int reserved_maps; - struct device_node *np; - int ret =3D 0; + int ret; =20 reserved_maps =3D 0; *map =3D NULL; *num_maps =3D 0; =20 - for_each_available_child_of_node(np_config, np) { + for_each_available_child_of_node_scoped(np_config, np) { ret =3D s32_dt_group_node_to_map(pctldev, np, map, &reserved_maps, num_maps, np_config->name); if (ret < 0) { - of_node_put(np); - break; + pinctrl_utils_free_map(pctldev, *map, *num_maps); + return ret; } } =20 - if (ret) - pinctrl_utils_free_map(pctldev, *map, *num_maps); - - return ret; - + return 0; } =20 static const struct pinctrl_ops s32_pctrl_ops =3D { @@ -786,7 +781,6 @@ static int s32_pinctrl_parse_functions(struct device_no= de *np, struct s32_pinctrl_soc_info *info, u32 index) { - struct device_node *child; struct pinfunction *func; struct s32_pin_group *grp; const char **groups; @@ -810,14 +804,12 @@ static int s32_pinctrl_parse_functions(struct device_= node *np, if (!groups) return -ENOMEM; =20 - for_each_child_of_node(np, child) { + for_each_child_of_node_scoped(np, child) { groups[i] =3D child->name; grp =3D &info->groups[info->grp_index++]; ret =3D s32_pinctrl_parse_groups(child, grp, info); - if (ret) { - of_node_put(child); + if (ret) return ret; - } i++; } =20 @@ -831,7 +823,6 @@ static int s32_pinctrl_probe_dt(struct platform_device = *pdev, { struct s32_pinctrl_soc_info *info =3D ipctl->info; struct device_node *np =3D pdev->dev.of_node; - struct device_node *child; struct resource *res; struct regmap *map; void __iomem *base; @@ -889,7 +880,7 @@ static int s32_pinctrl_probe_dt(struct platform_device = *pdev, return -ENOMEM; =20 info->ngroups =3D 0; - for_each_child_of_node(np, child) + for_each_child_of_node_scoped(np, child) info->ngroups +=3D of_get_child_count(child); =20 info->groups =3D devm_kcalloc(&pdev->dev, info->ngroups, @@ -898,12 +889,10 @@ static int s32_pinctrl_probe_dt(struct platform_devic= e *pdev, return -ENOMEM; =20 i =3D 0; - for_each_child_of_node(np, child) { + for_each_child_of_node_scoped(np, child) { ret =3D s32_pinctrl_parse_functions(child, info, i++); - if (ret) { - of_node_put(child); + if (ret) return ret; - } } =20 return 0; --=20 2.37.1 From nobody Thu Sep 19 19:38:14 2024 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2078.outbound.protection.outlook.com [40.107.22.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C750E2110F; Sat, 4 May 2024 13:15:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.78 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714828561; cv=fail; b=n5KIhlAslUWQRQGwSgO3QhiJTHYb58z+oAkXDS631V42Wp4X6Ohwng5Apu6b/zq47Rj5kKOONq08LJkD/KE/xrYwWXfdcl5xYuY0Z/JNbZk5DAtakJniOJ7Bb6FoW0N7t6qAemcIedE9w3tNaUsXKT9+tsUkyvUhPWGvvAjHy6Q= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714828561; c=relaxed/simple; bh=UYDu+QLrZ0SSLpWHuRHRNNZ73xp3uVF3FfCqwL6cAd4=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=i3iLvfxfl6Z0NnaVCSbMkDGL8/ZqC9W4zcseDcsNF5eGCLlBrld1LNt0dIi4r2I1EzDjv62VDyUGA85NSYwkjRE/CAFElf7cNtfT4GHh/W5h+/Q1Ld7iSCpfql+U/frmL7aVY2yoYbPQH6tMUwB8mb86NJfiT6Py81PyjdYZlP8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=EVS5HR5x; arc=fail smtp.client-ip=40.107.22.78 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="EVS5HR5x" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Lee+JnAzlNvpehCxhyFAeNpuVgBeieK0ADvhiJEQqhD5hrggv2Iv+0N7RubufUMVytEBTc5Z3PorTPlZQzy4on0VDWXW5O3GGi3eunGf6u8W07OKRiaMybHa6Y5gjwlJYyrivI/aFHaQEEl1THvLGBgUKsxK4PrZs60drZ4aXox2/BTK5RdlHZHofGyMOfeHw4o8PvmTQtHPWcgZDJj2Wez3FtOLBNsbl4ywsj56D3xzm8hci8kdUH5IhQqDFWLmpNNvF7UHiNdRzeDOf+t8JAxIolN9NrEYKsLnNqbQIAL2fhW83h4X9KoENDLEtBQvkFCAX3qmE9UBLfIEJxWzHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wh46VIFFtnR87VP8CR7uMzRt81dfHvC2gK19Gu2CtGM=; b=aEj/6j9IjzSd7KybfPLL3ptJ9WKdL0PYHrUkCXghiSmDOzxXraYQqc4iO9uTppTMoEhk1KAyvoWlN5KXwB4yWjClQoH+Krx5fBgJQu4to/2epChjSQoMNZceMY5Qtn8g5tr1QyqXgiXLku2vHu5tIAZZfKqd+SxOQiZifaagg4eXRLTOTAplderools+hJbX+qAtUxX3mTmz/15yf9jvxk2ftcyEqsj3tA7ZiUhGew41dZIxE5wASVm+7bDyCCkG8SnwS489nBvEkIYHOyOKRn/uqHpqm+pfnxnXy9xmSr/8LOpPCi0GLgi5iUJuupPbEBXdHA2T7ytaQZO3HHeCsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wh46VIFFtnR87VP8CR7uMzRt81dfHvC2gK19Gu2CtGM=; b=EVS5HR5xT5AFA5dsCbKK5mnP37N6m8GiH3ZoMhDe710IfMnodKMRLnfDYtCYSuzrxxLvkKC47feDQoHmqZkUF4OUrFP3o18J6dUNoJmL/+ayPxkANvxAPQMDmIaKB70JBkCdxI3cANfhpsRHxTPMF//ttNGowaREPSakeoEQ0pw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by AM9PR04MB8633.eurprd04.prod.outlook.com (2603:10a6:20b:43c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.34; Sat, 4 May 2024 13:15:57 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7544.036; Sat, 4 May 2024 13:15:57 +0000 From: "Peng Fan (OSS)" Date: Sat, 04 May 2024 21:20:11 +0800 Subject: [PATCH v2 13/20] pinctrl: nomadik: Use scope based of_node_put() cleanups Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240504-pinctrl-cleanup-v2-13-26c5f2dc1181@nxp.com> References: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> In-Reply-To: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> To: Linus Walleij , Thierry Reding , Jonathan Hunter , Dvorkin Dmitry , Wells Lu , Maxime Coquelin , Alexandre Torgue , Emil Renner Berthing , Jianlong Huang , Hal Feng , Orson Zhai , Baolin Wang , Chunyan Zhang , Viresh Kumar , Shiraz Hashim , soc@kernel.org, Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , Geert Uytterhoeven , Patrice Chotard , Heiko Stuebner , Damien Le Moal , Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , Chester Lin , Matthias Brugger , Ghennadi Procopciuc , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Sascha Hauer , Andrew Jeffery , Joel Stanley , Dan Carpenter , Tony Lindgren , Stephen Warren Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-mediatek@lists.infradead.org, imx@lists.linux.dev, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, Peng Fan X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1714828815; l=1905; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=x+RKtlqeCysZbUAk0csydxI+b9I02cK4F7LOISGb+DM=; b=JE8/0bWFt0FhuoluAmwXD7cZ1NKNXM1V4n4g+hFSwn0VVc4ZZ5ApyeZfiWy4V4lQKgKKWENdl 0jAfiJK0OOcCjOJmK2qZEUZh4Q54eqOAxtCinzihJGth/uc8xGvAO/J X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR06CA0230.apcprd06.prod.outlook.com (2603:1096:4:ac::14) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|AM9PR04MB8633:EE_ X-MS-Office365-Filtering-Correlation-Id: b70a4f8e-bdcd-4b57-d0c5-08dc6c3c55ab X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|52116005|7416005|376005|1800799015|366007|38350700005|921011; X-Microsoft-Antispam-Message-Info: =?utf-8?B?RTVMK0JVcW0rdk1TbTM5RnJwMlN1ZWhzVk44ckVJVGhZN1pNTTAxR0VvR0xD?= =?utf-8?B?Nms2WWVYNVhsbGFUVzlqUmN1U0NXdklWMmp0Y1dqOVNlT3lHM3VEYkc5V0Q1?= =?utf-8?B?V0NveG9SQXV6a3lWMmZSS1MvTWI0R0V3Y05nTWZTRExFQ2NTdzZ6UExUd0R3?= =?utf-8?B?YTc4eFQxUUdXSHVsOWRlQXZ0MmtJOGdLVXdjcnhXRHh2K0U3a2gwcTAxcmpW?= =?utf-8?B?OVRPNEgzZlk5OHJ6V3lUbGhlcFJ1RVhLYVoxN0kzYmJVcmlnMy9rVzI1VzBC?= =?utf-8?B?T0pKMkY0WUxkSUJlbkNJNGxnUW9zY1BhUGFYNFVybUZoTjlyWW5SR1h5bjNk?= =?utf-8?B?SFVmOXZRTjdNUnRJTmExcFlBRWZuR2dtSTRrQkJqcktzQ1F5OFNrVDFIWTdD?= =?utf-8?B?ZnMvazZXOFpBN203Z0hXUUpQeVBNTjJ6UXhjTFVobEJBTDBTQVVtVmpNQStU?= =?utf-8?B?K2orZjJFTHhlTldxclBDZHJRMjE0blZoT2diNmZZRVprVmxrUmtlL013OG9u?= =?utf-8?B?V1VJN3RkS25JWHU2Um9ROXhDbFRhTCtXR3NUSUFhOExEZllqaDVsd2hlV0ZL?= =?utf-8?B?ZG9tQzlNYnlhZVBrcjNjTEVZYmpFdU5DUVVxMUh6SlRmdnk4RzBRN1FBRno3?= =?utf-8?B?OU52bHhkUUlMUFlUK1o1YUlHNEZQOEJPV0JFbVZSSStXRlVJZTBmL24wUStJ?= =?utf-8?B?M053MUh6OEFicTF1WXc2c2tCak42R1JESmtCNEJwOTJDa1AxVmRudWpiK2t2?= =?utf-8?B?b050R2E2YkV4VW5XcTVVMXhsRjZrdmVKZmZ1TmRmWHlTMFRvSUx1azJPZkNl?= =?utf-8?B?K1hsV042NWI3SnpvYTRkdWdjdVBKZFVxaFNlZGRMejB6UkprQkc0Ni9XM1Nq?= =?utf-8?B?Ym1NamZDa1JsVHRXbi8yS3dEZ2xPNGxtQ09IRUNRVzZLend6cytrVWd1Zzls?= =?utf-8?B?eTdFdk1ZSm00T1EreE5seUJITU5IZlpOc0psWlNzejdCR1ZCM1ZHcFUraHRX?= =?utf-8?B?NVhWcEtYUzRXK3Rmd05zbEhiRDlwNWszWEVvYVdFZXljV3orZmtSbEpKZGNu?= =?utf-8?B?dXhhZGdjTEpYSCs5eXNURGZEeVlna3JFdkZ1WE5MUEVSWFZzaTVGZDVaQUU2?= =?utf-8?B?enNaQXBsM25WZXVYQ0hOdzNxVzlYZGVDVVB3dDIwSU9HS2FuY0lkT0JNSDRv?= =?utf-8?B?S3ZLM3IxWWdIY2NWVGFPZTdUbGUzRzNUbEZkOHYyRllJeTNoWXczcysvbm9r?= =?utf-8?B?TCs2Ym94Z2c3eVViV3Y2N28vZ2U2d2NnaURrMVpTZkE1UTJGZXBCMDNjUDBj?= =?utf-8?B?SldHMW1haXhaeTNqRzFGQ0JSMnRRS0IzRStKZjVSbG9LZnk4Yk9KdVlJSnV1?= =?utf-8?B?WFJlMXc3VEhUNVFCYWsrME5iNmVXTWZJNnBCRVlHbTBiS1owR09HbDdqRE5l?= =?utf-8?B?RXJiSDhGbTM5TXg5cjlSNnhXRVBTVWh3SXR1OUZMSzJVTjdIUlo5ek5RN25o?= =?utf-8?B?S1Z5M0VnL0lxQTdWK2hBVE0zcWRSRTFCVER2L1FXSlN4ajU4OGQzQzJ5cXJF?= =?utf-8?B?YVFyVVJZNVI5QW5MeWNaTG5xQ1pCVU13d2J4SDFVaE4yNzJHQ0NTQWZhRWJP?= =?utf-8?B?cU0xV1hJbzVEN3l0QXJpSFlCUnhzbE1wNkpwWlBYcGVYMVJoUWhOZHdvUGNq?= =?utf-8?B?MVZYcU43Zkh3enJneGFDNWVYcXpBNmZIeDVyc3E4T0xwa3NpczhTUFhJK0Ez?= =?utf-8?B?OHA3WUZIbCtDRFNabzN3dHNsZVVJYVVCMVQvc21wanQ3VEtjVjJKUXgyOFds?= =?utf-8?Q?Ti2NS4TsUg7PVW9cHqpBHfyE1S1gner7m8WWo=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(52116005)(7416005)(376005)(1800799015)(366007)(38350700005)(921011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aFFkSzAyeVhRTi85SHhDYlpXbXIzYjRKUmJsb2MrUmp1aXdGOEdTRlRXUkJm?= =?utf-8?B?Q2xEa1JjTkJEMWlvNlpERXZNanI3bW9YNGI4YzBRR3VxV1pjUFdWTGFic3Fv?= =?utf-8?B?TXlaYWlMR01JUHBUVGYya1BqWTgyWXJRMWQ2emRsOEN1NXczWmw5VUc2WWdW?= =?utf-8?B?TXhHUkI1cWNZS0hoNUt2NEJqeG45UktZaVl3cm5UZUVmeE1vWGFtT3lPWEUx?= =?utf-8?B?cThUdHA2VjcyUjZxb0ZWZk1rZWVHZk8wZVJYeFpTMW1nVUxaLzRYSXRnd29p?= =?utf-8?B?Q1haRWdtQ2hBSGNNMjNBb1NWLzlDVzlmVkt2Sjd2SFR1ckt2SmhPTWlOMmll?= =?utf-8?B?YURydXV1d01QYTdJbmZsbXZmSUpQNUdCS05vb1ozdGhiZUFVSGJHbXppSm5M?= =?utf-8?B?cXpyanJuMlJ6WlVyY2RHTmhacHovaUMxSXlaMm9OL0ZXWnJ5cGVHVjMxWjhH?= =?utf-8?B?T0FrWjd3UWFjNmViR0lPMHpNWFRNUytmbzQ0N1NaK3V2NThpWnZ6Q29MQy9k?= =?utf-8?B?NXl5dDJQUUpZcG8xR3JnTnhaYjFZZ3Y4MzNRNjlTUFRCYVFUc1grblpoOEdG?= =?utf-8?B?dVMyQTM1Ly9oQlRtNlh2T3dCQjArSW9BQ2ZaeTlYT0xoN3lIdHZQdWw5MHlI?= =?utf-8?B?R01ySGtNaVhlRlhHcHFSaEZDZUFjUXNXWjNSa2FVZlRFZUVvZXBMcjBHUUZL?= =?utf-8?B?ZnNrSy9mN3V3Q3ZwRTFjeVduZXpCM0RqbmdXL1I0YWZuV0RyL1V2T2ZsbUhV?= =?utf-8?B?VzRGaWNlZGJxZFhBOE93WERwU3VqSFlob3FkVURzNHdLSDdiQXh5eVlkN2xv?= =?utf-8?B?UXpkTm81YXBXeFllT3dSSlpJWTQ0Wk5acm9BMktHNldwTStZa0cyZEszQzBY?= =?utf-8?B?cGJENzJSV25QWkhaaDl0K3F0Q1haMGtSeTlsTzZRZklwS0ZmQ1NBQnN1RGZx?= =?utf-8?B?bnhFVVFvbng1UmFuM1R0R2NTS3lPeERQeG9tblpzUTFyVHgvaDBzQSt4OFY1?= =?utf-8?B?cTdaUUxSMGhqZU96TnNTcExZeDAyNVE3eVpsd1VYN09BMWN1OXo1a1V5b0s3?= =?utf-8?B?V1g4ZmRqQW5Qa20rUWFxTHl3WDlpS1FZa2VCWWxydlpPNUxQVXdNM21CU3NG?= =?utf-8?B?SllXbEhUOU1YbWZsSzJmZzdIazJJb3dseEI0OERUTFhST1JrZ3IyWk1waEFK?= =?utf-8?B?ZERUOHJJakdZa3N2QmtCZHF6OUFQMEFjbkE3dGtaZUtudnRhdlpjM05ibm1w?= =?utf-8?B?TWdaQnpGRnUzWGU2NWxoVzdvR3RQN3hqc1A5MjdBS2k4am00a2RNQ1grMnRi?= =?utf-8?B?TmxqcVpzb2lsd3BBVjhMNVRpem0xODdIMVdPTXpRN0pJOFNzU2FxV0RKM3l2?= =?utf-8?B?eG5KcEM5YlJ3ZnZyUTZ6bWlGSStmdzJxM1hxaXVrKysxNDdXYW5CWHVpaFFJ?= =?utf-8?B?NGZhS3RwV2QvQXJWK3FqNGdodUFDWlZFdzEvM3dKS2pYVXZLanBuL0xyQ1lV?= =?utf-8?B?M1V6SVlHSTBrdEIyaGptbmpOUW9nRmJRN0VUdWY1L0NxVGI5SGQyL3pMMk9v?= =?utf-8?B?ZjU5UEFKUExaQkwzdVhxRnFoeURyTXN0SFI4dEVOQ2ZhMVE4Yjh5ME9NMGV6?= =?utf-8?B?N0hJMlluWnpyUXEyd0U1aHhZQUlkNnoyVjVIb1hlTnllNmhTZ0U3RDgvS3hP?= =?utf-8?B?SGZDRU4rSUlmZ0I3bTZBTGlaaHdaSyt0Nm9YRDZPZjl1dUxoSlBFdU1mRlR6?= =?utf-8?B?RmozRXMyOXE4RlFYNGZDazVDbEwrb1RxeWh6TVZQWUU2QlRJaC94ZmdoNE5u?= =?utf-8?B?VENZTHVWM2Z1TUNMZDlCRHpnZDM2RDA3SGJCYzlsclVLK2F6UldEUjdVaFl0?= =?utf-8?B?OVk3elBwL0VPMlJTUU1ySDJjOVcvMTVIL0JHR1VIODN4OTF4T2FtVHZpaEdC?= =?utf-8?B?bVFKMHNEWkhsMU1RUnVmb01SRUJlV2VNbllBd3pjS1pLN0duUUEwMmZ0OGFO?= =?utf-8?B?KzJQTFRFUjRmaEV6MnNocEJyZEFURDRUQ0VjMFJkYTVvVWRoRUVVTDVneWwz?= =?utf-8?B?a252RTFUbyt4N0N6QzdJQ0w5cGtIZTZBNCtlOEFRQU5oR0R5LzhNTG1ZUTc0?= =?utf-8?Q?K7kZ9zVoNRQRzk/x3SCy4hua6?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b70a4f8e-bdcd-4b57-d0c5-08dc6c3c55ab X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2024 13:15:57.1871 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UNrCeNgMIYVy+8heMkCZBvq6g6j6oQC/D98TXd5g78WaLKxK+Hl3hAFwJCgy7l9LEl9URhHECQ/dXLSXji+JsA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8633 From: Peng Fan Use scope based of_node_put() cleanup to simplify code. Signed-off-by: Peng Fan --- drivers/pinctrl/nomadik/pinctrl-abx500.c | 4 +--- drivers/pinctrl/nomadik/pinctrl-nomadik.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/pinctrl/nomadik/pinctrl-abx500.c b/drivers/pinctrl/nom= adik/pinctrl-abx500.c index 80e3ac333136..47f62c89955a 100644 --- a/drivers/pinctrl/nomadik/pinctrl-abx500.c +++ b/drivers/pinctrl/nomadik/pinctrl-abx500.c @@ -811,19 +811,17 @@ static int abx500_dt_node_to_map(struct pinctrl_dev *= pctldev, struct pinctrl_map **map, unsigned *num_maps) { unsigned reserved_maps; - struct device_node *np; int ret; =20 reserved_maps =3D 0; *map =3D NULL; *num_maps =3D 0; =20 - for_each_child_of_node(np_config, np) { + for_each_child_of_node_scoped(np_config, np) { ret =3D abx500_dt_subnode_to_map(pctldev, np, map, &reserved_maps, num_maps); if (ret < 0) { pinctrl_utils_free_map(pctldev, *map, *num_maps); - of_node_put(np); return ret; } } diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/no= madik/pinctrl-nomadik.c index cb0f0d5a5e45..fa78d5ecc685 100644 --- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c +++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c @@ -804,19 +804,17 @@ static int nmk_pinctrl_dt_node_to_map(struct pinctrl_= dev *pctldev, unsigned int *num_maps) { unsigned int reserved_maps; - struct device_node *np; int ret; =20 reserved_maps =3D 0; *map =3D NULL; *num_maps =3D 0; =20 - for_each_child_of_node(np_config, np) { + for_each_child_of_node_scoped(np_config, np) { ret =3D nmk_pinctrl_dt_subnode_to_map(pctldev, np, map, &reserved_maps, num_maps); if (ret < 0) { pinctrl_utils_free_map(pctldev, *map, *num_maps); - of_node_put(np); return ret; } } --=20 2.37.1 From nobody Thu Sep 19 19:38:14 2024 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2069.outbound.protection.outlook.com [40.107.249.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2FA9374C4; Sat, 4 May 2024 13:16:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.249.69 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714828578; cv=fail; b=Ge+Dl22efjfI8LOretsl/vWJ/Ws00AzEerRzGY5F+GqD8ukg/MckRXzUWpCViHqP9/D/wl670LRfEvD7uaU0otmLhP8dscXI67pDiCHCU+SEMLPMa3RDh7sDHFo6gEk8BDA6AUSJdIA4a9ZWUvapVXdQ/dp9n4nPLrW8Z129IV8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714828578; c=relaxed/simple; bh=aGocML37yKFLTQmAgdHIf5uoWsvtHUPQJME8EyVoT6s=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=SGyCPYqe1yAKP1BNxwr4MOFzeDbgv1wTN5ltC/OkKrrUZfXwMstLD/QDQzTdzLJNsyCh7MQ7CfFC2diBhoZ8oZJr9Zus9Zb/7m3MFnqxGdy4ei+wVsNREbqRIBtu7L5xXIFq6CyNx5AlRyEP/YnvjkS+2oqyF1A8W+9xuReY5go= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=LbykI/RZ; arc=fail smtp.client-ip=40.107.249.69 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="LbykI/RZ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HjpbylIYacvnbNTWQP2eW4n5I4okmE77Ce7/Dl53/EpW4Yt8DXzAzkFvYu8UldsRbkKqZPe3VissAU7I5jfJT18hYiGAWBsdEdnKWAxcBtPOxibb3Uvon5JFSTkptfPnOy+MOP4npnLPhRn2tEFbe5z65Iz2iDYrAswN+z3Z5vb9513kV3ldW2CqleJMF/LBMywB+tgrfD1sGL75xCez5X2jjrv89l0qKlBZxw7i97RzX9mJjN/K+2COUQuDVL5mt5yS5gJnHUTzAtbOU9tYZw1tgYgDMOiZnkfllE34U/j8XoJKG2jhVj2zCGCbLpe2KUyy0a7olcgT55PALcNERw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YyGeWpCkYZh4WcKx5URim9X/pl2xw38Z9ho8YthB/aQ=; b=dqGYH1FwLeN/qpMQsYJ0OBQXmLTP3aJUc7GzoCCWjyJrF2QvI0uVycx7CRkHbtc06SSQTJXmiPi98aUf8gG+JmiOsOJZce7M9pBhnCR5rJYGyI/FtQTsCJV3takHYFyBu5OvMG5wH+3DxvDvamud9A2R1+Q2Ji6fZKFaCngPDKCeNqgasKOdE43yAK2dV8QO6XxD96iLBsLPosTkRWwlHIfemLah8ppu6psxAyg1SCa9WNfgotSaU2gMDmZjVlSeqadnP3f6fEMXWOQ2EwK9OVhXs0rWjqLeX5R6xyLhkLhONee/sWVU+hrlwhz8XbRQi4V2NZ2Z+TyEchh4//yPTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YyGeWpCkYZh4WcKx5URim9X/pl2xw38Z9ho8YthB/aQ=; b=LbykI/RZmuGK+O14E8wO67iqZNfdyu5EQnlofWQCNSbAHiStMpPWzUmxv9UiR5GbG2yCzkxFgz1NQ+IwIUW1ySOpuWD6sM2jl05iLgCGOtZjFpdDtSOXhpaDm8KRFQiOPoJLE8ZmlMC7w+DDbq97yjKsNdcQeIQlGxagDrmT7Ms= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by AM9PR04MB8633.eurprd04.prod.outlook.com (2603:10a6:20b:43c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.34; Sat, 4 May 2024 13:16:13 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7544.036; Sat, 4 May 2024 13:16:13 +0000 From: "Peng Fan (OSS)" Date: Sat, 04 May 2024 21:20:12 +0800 Subject: [PATCH v2 14/20] pinctrl: mediatek: Use scope based of_node_put() cleanups Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240504-pinctrl-cleanup-v2-14-26c5f2dc1181@nxp.com> References: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> In-Reply-To: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> To: Linus Walleij , Thierry Reding , Jonathan Hunter , Dvorkin Dmitry , Wells Lu , Maxime Coquelin , Alexandre Torgue , Emil Renner Berthing , Jianlong Huang , Hal Feng , Orson Zhai , Baolin Wang , Chunyan Zhang , Viresh Kumar , Shiraz Hashim , soc@kernel.org, Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , Geert Uytterhoeven , Patrice Chotard , Heiko Stuebner , Damien Le Moal , Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , Chester Lin , Matthias Brugger , Ghennadi Procopciuc , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Sascha Hauer , Andrew Jeffery , Joel Stanley , Dan Carpenter , Tony Lindgren , Stephen Warren Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-mediatek@lists.infradead.org, imx@lists.linux.dev, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, Peng Fan X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1714828815; l=2143; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=lm1PEdHATfoxwJUL9YMs41GxvVEK/pacMdZ5mWFlWX8=; b=d8MWpOtXKNnFGmfz1eHOooCE8YCLHVTyQNBBLhSiEJgr+86Or3+ekvXynCYNgOqJisw6NtlEy IWju/BxoMOfBW/IhPYIVChwIIYZ7T5qVjSiPvU1zknqEB2Ele8EoB2c X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR06CA0230.apcprd06.prod.outlook.com (2603:1096:4:ac::14) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|AM9PR04MB8633:EE_ X-MS-Office365-Filtering-Correlation-Id: f321deef-96f6-48ee-0b73-08dc6c3c5f9b X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|52116005|7416005|376005|1800799015|366007|38350700005|921011; X-Microsoft-Antispam-Message-Info: =?utf-8?B?c0JCeTN0SDFDVG5oUlhXRkhxbHZIRExxVWVFeWJmK1hqR1A5Y2UyR0VyOUFs?= =?utf-8?B?OEVYbzZtSi9GdDU4S1NZNjVPK3lCL3VHK1BxOTFNUk1tQU5HV21LWjNnZXJn?= =?utf-8?B?MHZUZXNVYjVkbVNpOVc1c1NTbXYrQzdOWWRvdUdaaDNOei9qNVBWM3lvblB3?= =?utf-8?B?N0E2eTlMTFpLZHovM0trbitLMUdvQzdGeWFxcHV6SXNWVVVST29zMElEQ0RV?= =?utf-8?B?amFYTWw5TGQwZm9qNVErWkdyUkRLQWl4QnQyWHEwWjlzeG5jNmNjQ2dTQ2h2?= =?utf-8?B?RzU2TStMdlZ3dUI2d094RFgzaHVFMlNSL1BMakJJUjFBTVJSNjZZNlIzd1Ex?= =?utf-8?B?YVNQb3pOLzYwbldsRi9JaXlWZ2tONlI4a0FkbTJyeFluTm1XUGR0S2xVVkZ0?= =?utf-8?B?VFcxbjFRcXIrNHlsdjJTMFBySm1hbWVRUE5idzN3eHk2SzlkYmVTVE5CVnB2?= =?utf-8?B?OTBSenRScVEySVVZVkFWU0haSFBPdFYrVk4zSjNYSUNIazBwOFNiRzR1V0xr?= =?utf-8?B?Mk9yYlFZbWU5TXdBTDZxV25UWDF3N1h4bGM4TWwxL3hBY2hKbjVBYUZ4ZDlZ?= =?utf-8?B?M2ZMcHYrRkNOMG4yTW1XVnAyU3FUYTNIZnRJYmZDTGt5dHpMOVowYWYxUC9B?= =?utf-8?B?YWQvbzhaY2RYSEtNdzBBTzN5MHVoald0T21aTG52eEhvQ3R5WGJVb0hHVlhT?= =?utf-8?B?cjZHejZ6d2l5a29sM3dHbXJyVjdSZXhmbkFWZ3RwcGVpeU1ZSm51UVVJMHdU?= =?utf-8?B?M0ZWVHo2MXdGY3hDNmQzRUxIVFVmYmM4U0Y1eGNXVjBYdGhQTVhBWDdCWlZ5?= =?utf-8?B?d0g0VGpHaENZVjVVSEo2RDJkUktpbm82QWpqUzgrZHhVaFFOVFV2WU9ibFhM?= =?utf-8?B?QmdYRUpKcVQ3c0ZHN3o0NkU1WFI2TmZ5MExobHRDQjlCeEdCRFVMMkZWQVFq?= =?utf-8?B?NnhJQ1N4bGV5UU8vTHEwUTlaakRqY1BYTGkzWkpvUGRMaXJkQTJkY3VLMGtu?= =?utf-8?B?RlRWa1V1OGpGSkZCSVVINDZ4NXdLT2xJZ1I1QkRoUktCV3Q0OXkxZ1BuVDRF?= =?utf-8?B?NDk0eUFqY3NUNFJjVUFUYzVyeTVkdWlCSWd1Mkx0bG1vRk55RDkvWXBGWFdR?= =?utf-8?B?WjA5Sm1NUUZJeGhKdXJ2OTRZMTlheFJtRWthU3VFajN3aTh3eW1QbVJSTGpO?= =?utf-8?B?SWpTMjlkRWFZZ3BNdHBKYzNKZzhlTVExamNmRTU5d1gzanV3S3dMQzhNMXN3?= =?utf-8?B?a0RUbmM4a3NOOEc2Q01rS2RMamh3WlloaGtLOW8vS0w0c2tzcXNxdG5VUklR?= =?utf-8?B?d1c2NkFKUC9vMjRDMGhVL1hmUDcyTFlPTGQyQjN6NGRyYzk1dFNYbFViNERH?= =?utf-8?B?dVMvbUJSOVBocXRLNzdka3Z4S1loQUpZZ09pTmg0S0VVT3NZR3hkNDNYNnRX?= =?utf-8?B?bndkYjEvM1JjTFBnVzFPaThKVkNnSWEvZFpQZnhtekd5WkdETG1vbUk3Rklr?= =?utf-8?B?bG5TTnZCUi9UZlJLNWl6LzN6R0lnR2x1YzlwTDRqaExDbEJtZEhMV3N4alFq?= =?utf-8?B?S0YwNmZSVGVBaGQ4cnFYdnhwWmVJVThQUHE5M2o5Tk96d09aTDMrZGN1RjBE?= =?utf-8?B?amRrQzBnbFZacWxqeDVFV1drK1R4TmtuRzd0a2E0K1NNNU80bUtvRDRkL09V?= =?utf-8?B?OUNTRUxhc1EybEQwcmJWREwwLytVc1NRZ0NhaktHVTZyWFlIREpOS3M1WWl3?= =?utf-8?B?V01tWDU3M1VYRmRmMXhBS1E4dmUwYWlQNytUaUhLM0VWODJOaGh6R3RXdjN0?= =?utf-8?Q?RSsChYiiP4tQ4c0GA4kuFGTaAK4pCq77iXazs=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(52116005)(7416005)(376005)(1800799015)(366007)(38350700005)(921011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SFgraXdDV00xaTgydFE0Y2FqdHJxZExLMjJrb25hZFVPajFPdlR5eThEclFm?= =?utf-8?B?NXJKdklxNFF2UHNmSkJpTFlvZmMzamwyL0cvdlhyZVZMMDFwR1JTN0RzendW?= =?utf-8?B?a3NHN29FNytqN0t6QzRWbU9kamcxSHI0U1l3NjkzRjZwdTEwWUpHekZNVGpT?= =?utf-8?B?VjhJL1d5aTF2bVJlaE83ZVFPRmtZSktqR3p4aFRWWHp0S0t3Ky90S0duNEVp?= =?utf-8?B?TFVlN01HSTcrVmhoVmdpb3p0RFpnNC95ck4wNXdxVWx4VGdHZTd4TFpnSEV1?= =?utf-8?B?blo3MmowZ01rb2I3dXpaUTkrOTV2TWlzaU9hZ1VFS0Qycmx1K3BDVGE2dzlj?= =?utf-8?B?cU9EU2dPYTROWFdTbXRvdjk1OURRbkZlMmVSdXp1bFRzMENpNTRuWnNwaENn?= =?utf-8?B?aUExQ3RuRHp5Q3lkandBRjcyQjZDb2srT2ViNzRLVnlxRHJDdGZxUEFuNDR0?= =?utf-8?B?bDFqSXRwdE5pOWtUYkE4Q2htNjREYTFaS0FQYVFRZTcxazhScXJEUjhzZHBN?= =?utf-8?B?aVR3cmxwNTdqRHFKWktRSmdQUWg5cXRhTmh6ZlgxbE5IK2VYRnZQcVRTRlkx?= =?utf-8?B?N05BVkQ2NUNocTB1ZVpGM2QrazlJd3JSTjZ6V0FkWEdtcTEvSFBxb3lhYWh5?= =?utf-8?B?aGtxbDVybU44YmpKTFdsSVdlUEl6cU5YZWZIdnBsYXEwTFNka0ZuV0UwZEw5?= =?utf-8?B?bGZEWUl5bTRTVjcza0FHc29JL2R3SjdZdzFMM1krTW5hZFM1ZHpjVlZldllu?= =?utf-8?B?UmtJMjFpcXN1Z2NvRk5pcXFKdWlJN0RMZVYyeFBqYVNxMDRRQnhWcWV2S0Jp?= =?utf-8?B?ek1LSHp0WEQ0ZDRvNmhqa2dnUEJFY2pRWlo3NmlVZ2w5UWpVeXlPY1Z2aWpP?= =?utf-8?B?a1Z3U3gwS3RDbkNjR2VqYUp2WVRRNnFiekRmYkRmOG5manhubDdXWjFaQ2ZC?= =?utf-8?B?S3dDQ3JpdVZPSC9qN2xVR3doSldKdlMzbzkzMHQ1RmsycWFNVE03UTA5dkFE?= =?utf-8?B?c291ZUdqY1ZSVDRlMmI0Y1Y4V0pCU1B6MHFmclMxZmdEWmhCM0tvNjFxQXRJ?= =?utf-8?B?ZGc4Q01wSHAvQXNKQnlteTllS0c5cndkcGhGak9Bb3BaYkpmVFUrOUdlWWFQ?= =?utf-8?B?dUtrTlpXMXF2QWlXSGhQbHYxMmxSaWdRdTM0KytGckVuY1IrMnIrNVJ2K1dX?= =?utf-8?B?cUNIQVpiNG5XdlFGSDYrQS9CMzB5Rnd3VWgvZUtxTkFDUG4ybzN3Q01FSHRa?= =?utf-8?B?Tnl1ZTMzaG11RkFyZjdJa3dNRmhmRGE3ZkJpdEZGVE42ZmFXd0RBRjVrby90?= =?utf-8?B?elBGT21obkg0UmZ0cUh6Q3I5UHplQjhEd0FKV1M4WEtZUzhrUVd2cEZJb2tC?= =?utf-8?B?T3FqdmU0SEI4YklUNUkwZmQvR1V1U2czK0dBb1Q1QmZqU1oycWxTR0Fhb29N?= =?utf-8?B?UHRhb2FNQ1lkSXhZTnpMRW9ySDJwajNsOHBjSTVCY1RMQ0R1aURjWUM2cEZK?= =?utf-8?B?RGpSNTcxU2ZHSGhBN2RXRGtDc0RSRVRxUzJCcy81bGNvVm1aK0QzemNCQjNF?= =?utf-8?B?c1hZRGMyL1VtdGZtUFdMSFBGTjdzSlRqTkE2RFE2TVYxNWtiTSsxWEx1Y3FM?= =?utf-8?B?R1ZLM2xFem9kckJ0Q1laTERDd3dJejhVOEI0ckhzQ3ErVlltZVFBZkxVaXhV?= =?utf-8?B?N0ZYeHNkSDlSQzZMMEpvUkJRdlRHSHdwOFlWQzBSZ3N1VVFjenNCUy9tVEVW?= =?utf-8?B?dWtQMTZyMkZ0SGZyN0EzdlZUZllqUWxQaTFGOUtmK3lKSXBRWHJ2dG1CZ1lz?= =?utf-8?B?QUZFK2xoRGZEeTdVaGxtYWN5SWwrTi95S0lZUVBqZzU2R3dmZGgraGNCVk5w?= =?utf-8?B?MjdEZkw4aEpYQit5K3prdGZ4eVVDckVzMW1Mem1JaGJKczBiQW5WTlVURzRp?= =?utf-8?B?VVFhVHAydGFwbUxMSU5uRWlqYXhnRzJSYXFLN1gyS2NJYUFWL0dWbjBDR1lD?= =?utf-8?B?WEszRUJhT1lmbkY4QzFYUHFyK21ROVFDZE5ETFF0OHlxaTU4b3JZeC95dzBJ?= =?utf-8?B?YTZJRXBBY1VNYy90UDNHejRDMU0xbnVNUnJQQTZqbzd2TmFNaHp1WkNRSHpS?= =?utf-8?Q?j7mJrs6vxwrXPaA9fau1ED4Xn?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: f321deef-96f6-48ee-0b73-08dc6c3c5f9b X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2024 13:16:13.8452 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lasWAHSEU3CxIZoEiNBOjXZT/zjQItAD5txUd1NRZGwJarmvJdg3IsFiwxyqubcEn/E1ytvCZx3FX7rxsZyRBQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8633 From: Peng Fan Use scope based of_node_put() cleanup to simplify code. Signed-off-by: Peng Fan --- drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 4 +--- drivers/pinctrl/mediatek/pinctrl-paris.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctr= l/mediatek/pinctrl-mtk-common.c index d39afc122516..91edb539925a 100644 --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c @@ -621,7 +621,6 @@ static int mtk_pctrl_dt_node_to_map(struct pinctrl_dev = *pctldev, struct device_node *np_config, struct pinctrl_map **map, unsigned *num_maps) { - struct device_node *np; unsigned reserved_maps; int ret; =20 @@ -629,12 +628,11 @@ static int mtk_pctrl_dt_node_to_map(struct pinctrl_de= v *pctldev, *num_maps =3D 0; reserved_maps =3D 0; =20 - for_each_child_of_node(np_config, np) { + for_each_child_of_node_scoped(np_config, np) { ret =3D mtk_pctrl_dt_subnode_to_map(pctldev, np, map, &reserved_maps, num_maps); if (ret < 0) { pinctrl_utils_free_map(pctldev, *map, *num_maps); - of_node_put(np); return ret; } } diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/med= iatek/pinctrl-paris.c index b19bc391705e..e12316c42698 100644 --- a/drivers/pinctrl/mediatek/pinctrl-paris.c +++ b/drivers/pinctrl/mediatek/pinctrl-paris.c @@ -536,7 +536,6 @@ static int mtk_pctrl_dt_node_to_map(struct pinctrl_dev = *pctldev, struct pinctrl_map **map, unsigned *num_maps) { - struct device_node *np; unsigned reserved_maps; int ret; =20 @@ -544,13 +543,12 @@ static int mtk_pctrl_dt_node_to_map(struct pinctrl_de= v *pctldev, *num_maps =3D 0; reserved_maps =3D 0; =20 - for_each_child_of_node(np_config, np) { + for_each_child_of_node_scoped(np_config, np) { ret =3D mtk_pctrl_dt_subnode_to_map(pctldev, np, map, &reserved_maps, num_maps); if (ret < 0) { pinctrl_utils_free_map(pctldev, *map, *num_maps); - of_node_put(np); return ret; } } --=20 2.37.1 From nobody Thu Sep 19 19:38:14 2024 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2058.outbound.protection.outlook.com [40.107.22.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D886A39FD7; Sat, 4 May 2024 13:16:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.58 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714828595; cv=fail; b=AaTH6O6L9AHh7l6mo980Lpwnbde0XBjPgw0VCysAOqqJdgbFLfBRfi/ThHCNXNh8R7AdiE4Gy8g0jjfyqjfkZNWEM1dtzqfwgjfBB0l/7lhPCt44n5d/7It3zCbUUBLKOIg2T3nuMsWLFcEmJLwxvAOA1sJqhC2IRjwc+o71ozI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714828595; c=relaxed/simple; bh=7oLy/VNXv8mod/yO9pa5qybVbR+daZZ1X7hIX56xPZk=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=ljsrVEScI7pvf0iAnssomqYaC8TZdcJPfbhF1BGOvNaboObH2lAX6xq5LPk+JvZvj6KvMSqnHcOirIucFBPY8rPcowbOtXKXSXFilCDc+eCmExKmm0+nVxNyd8pOUh0dk6bxTOTGpZIesgarw1bfAXY7mqNw/Q7ThykGMaI2xQc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=JwGL8Zs6; arc=fail smtp.client-ip=40.107.22.58 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="JwGL8Zs6" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LIMM1EBcMpsAfoIajRF8lWxzqD5W5hV8CGR9eAQIs2T1oAhTOaKF0HCpJcnlc8sroJw018a5EyhoY5IExC3qqM/iF61FMdZnyHLMLCHhq+o3yrexo0iu9Xr6TXSyls9xJcIV9CfYgZ+X/aCnw1tL8enOeJjt4t93iHXGazwvHkTRL9iCy39v8F84rGNy+ty1x9SjkVGouTe9sqS0rH8auDRgN7zXZLuVBTATTG/Q+EUh8bsjNjHp+HpDHsA7LAmZVOH2dIy2QjpI/oaqPgOrLmimERTvp+7q6Ez3IYJqHLdlc4/GhQ5pFdeXTBNPcjCVidkv+cXMKY7URRnZ/9XmTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G6JJzIlsATPz+eeVRC+tmQRXVLBCszxKxTWLO7z/7Rw=; b=iIBs6qs50gXDdVnot+R0Tt18PMfLYan0y5eX4WWZBZ6Rmn1OplAcASf2Ui7+GWnY0XYgH1qEIPRphOElHqDmFQ0Zwp6kIoZEpOkkA+jGHrU5kIwPxWj4a7Qfp9QyPyfzFcR/YpluMQWUoDneKgvXgDhQd5yzbpvUzSm9pGJU/ZhPNAtVfq9FVVodtKKzBKFkmrN+CHcjg6/6ldPW3ecglLQ6llosWZ/4FQCY0rikWyE9gVaYAfal2h9nPcS6PsLMFvNrT7JYHLWHqWyNYPCV/oFruvx2k2GN5W83t6C/Kc8qRswy4wIevZm6SgryLF3MhM/fbgDlE6Q6nM9FCbfr1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G6JJzIlsATPz+eeVRC+tmQRXVLBCszxKxTWLO7z/7Rw=; b=JwGL8Zs6PoyHk+U+trsx6DmiL7Uh7CdB7QXcgZ7fwYsKtjlQTGUndTL/ynWE1SI9AmOVt8aHUAITzcJGJjBmYWjzAdmi/zHzu3mXgciACNlrVtknBQWSZS3t4z9FZHrkV8M2dvU6mytpNprf/CaijdDfxEEPyGCXAiuTQK0BNhs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by AM9PR04MB8633.eurprd04.prod.outlook.com (2603:10a6:20b:43c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.34; Sat, 4 May 2024 13:16:30 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7544.036; Sat, 4 May 2024 13:16:30 +0000 From: "Peng Fan (OSS)" Date: Sat, 04 May 2024 21:20:13 +0800 Subject: [PATCH v2 15/20] pinctrl: freescale: Use scope based of_node_put() cleanups Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240504-pinctrl-cleanup-v2-15-26c5f2dc1181@nxp.com> References: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> In-Reply-To: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> To: Linus Walleij , Thierry Reding , Jonathan Hunter , Dvorkin Dmitry , Wells Lu , Maxime Coquelin , Alexandre Torgue , Emil Renner Berthing , Jianlong Huang , Hal Feng , Orson Zhai , Baolin Wang , Chunyan Zhang , Viresh Kumar , Shiraz Hashim , soc@kernel.org, Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , Geert Uytterhoeven , Patrice Chotard , Heiko Stuebner , Damien Le Moal , Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , Chester Lin , Matthias Brugger , Ghennadi Procopciuc , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Sascha Hauer , Andrew Jeffery , Joel Stanley , Dan Carpenter , Tony Lindgren , Stephen Warren Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-mediatek@lists.infradead.org, imx@lists.linux.dev, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, Peng Fan X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1714828815; l=5535; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=CgYPpbd8zRZLHMaSBUod3MJSkUGYYuTkn7XHxXWmDfQ=; b=QThPNXw7bxO4a7RWVR+x8/it3yFCdDCIJhct6pJk1X4WfCzb33CCZ6xXajsk5epDPQ/hH1F0c spUFq/qYsKOCFwSsFFp6AnQ0TVEi4pJVnIpdLi/K9c5op0pxw0uris8 X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR06CA0230.apcprd06.prod.outlook.com (2603:1096:4:ac::14) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|AM9PR04MB8633:EE_ X-MS-Office365-Filtering-Correlation-Id: 826172fc-8f7a-47ae-4b44-08dc6c3c6988 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|52116005|7416005|376005|1800799015|366007|38350700005|921011; X-Microsoft-Antispam-Message-Info: =?utf-8?B?b0NFTThrOXRSN3EwQjAvZkc3RXhFUUNRUTVsMUhGQ3NrTEszcU1Gdjk4MkZS?= =?utf-8?B?MDRMZ3Ira2ZrdGpkazdCTE5Hd1Vsa1hmbzFSYkVYblhWTmp0Q0gvWWlac2pI?= =?utf-8?B?T2dub0FwVUJ4dTBVY2hSVWpvZGJjTzFrbDlLVHhqaFdtaTYxdk9UZElYZE81?= =?utf-8?B?ckRzZ1loQTE4aGtucm9Cc08zK29iWWVUUjhIZmR3MFVlMGlzc2ZvV1dsNlpa?= =?utf-8?B?UDZQN0VxOElMRkZydGU5ZkNDRFFkc3lJNVBoSjhjdldUTUorOFpKNzdwNzRI?= =?utf-8?B?aC9YM0phWlNwVmVEZkc1UElrM2t5L25IZ3I0eE5Yc2x3ZnpENS9KYVBaQnpo?= =?utf-8?B?ZXUvNTIrSmUvNGh1QTZBbWN5dkhZS0FvQVFEd20yN3VmQmdodzAreWQvZjdy?= =?utf-8?B?TlFPa0lQb0NxS2ltZ2JiOVlhZHczbEJLL2NWbTBjMWZ1UlVwVVcxcGk1NThX?= =?utf-8?B?M0VVc043RnZXMjh1NjlCSVRGd1BMVTZBekIwcEkzbkRWaE9BZUpxZHI1NDM4?= =?utf-8?B?dDRNRUY2dkpUSXZTRnJwRDZLV1NXWVZWeEFnSDBqSnlXUnlZQmxnZEd3VS9m?= =?utf-8?B?Qnl3NkhObEZweWd2eEM0TDhCMzNXVE9XZUJVR3duYVkranpQWDFMSTVERGhI?= =?utf-8?B?TlVRWjl3WDArNkhJczlGZ0xSeXZoQjdCYVBEeG5PeUI4T3gwTGxIdTVqbDdT?= =?utf-8?B?cUNKN2pTRzEzK0hLcVFrVkU4Mk1hZ1ZxNzNKN2dBOWYrWFJNRlZBTzJLWTJN?= =?utf-8?B?LytNbTZYakdFemxuck5DZ2pQa2pQRk95aDNCVEt5Z2hWK1NCWGcra1VDZU9k?= =?utf-8?B?bkV0ZC8zZHdyMFlHVFY4N0RwaFlrdzViSEZFZ3BwTGxqRDdTcE9SYlFoeU5L?= =?utf-8?B?L1BDb0x5ZTRNQWkzZlFqK1RvRllXR29uVkk4eG96SDRpWGFLbnUyc2F3Vzdk?= =?utf-8?B?ZkgzVkRIcDRvZjhXbVYvSE5sV3J5RUxrWlZJYlNLSzdVMWg4cUdrYmlxbVRE?= =?utf-8?B?Y2N6TjZXTTNESjNSN2s2UFE1eGtmSTN1cStXcWgvNlpDbWwvZkJ4a3QxUWkx?= =?utf-8?B?WHZFamcyb0JLME9sN0RUUE5vWFpOMno5ZEx2M0tXYzc2L3FuRHBNbUtpQUNx?= =?utf-8?B?SGtlYnVSd0NDWVRENGlaVXh5eVgvK2ZlS25CU09PTmRDZzY0TWV4b2FxeEtw?= =?utf-8?B?QUJpbTBvVURiUzduRjlOOWNpZEk5VG12cmVoY3U5THFhYUovMGZ0UHZLSy9T?= =?utf-8?B?M1ZPbldCU0lCL1l0dGtJNVhacjgzd2hRaW9wZnVtK0wxNmhyNnJZY1BJS2Vu?= =?utf-8?B?c0wxS2hxV3NDZ0R5aEJDNWNqMVBCQ1hnNzg3VUhVUDVCa2tLWVhzMmNUYTJB?= =?utf-8?B?WHVHa0kvWHFhTEI3WVdINUtsbnY3SkJSYW9XalhaOVFLdkVxc3FRN1lDSUxz?= =?utf-8?B?VnFUUlRTQWhDbXNHRXB4MlRXSjhBc3VtQkpqWjlKRHRTZ0gxUzBuQTNrUEJi?= =?utf-8?B?THRnNEE4VVZNZ3ZQS3FsNXUwcytGRXE2bDVyYlBpa29TKzJwSnVoNlFMcUlw?= =?utf-8?B?dndXTVl3VkI3NDlmSWxUVjlnM3FsQ1FaY3dnVGY2V2dOUzhoZ3RoYXBhalFr?= =?utf-8?B?WVJ1UDNJU3Zzdm1GSXR6TVppRGNtZVlHUWhzYWxWMTB0VzZYaGhTL3J1TGYz?= =?utf-8?B?ZTNNQy9XYmIwQnZ6NmY1Q092MUZERzhad2hZK1Q2QXdERFFRQlNXWXNKUWlG?= =?utf-8?B?Ym5UVEVIUEJRT3FXemp1UVowalhzN3ZDSnFOdGFvU0RhVjg5VURTY0Jqb1lm?= =?utf-8?B?M3VwY2hrQkFiOG9wU1ZPUT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(52116005)(7416005)(376005)(1800799015)(366007)(38350700005)(921011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OFJXV2MvS3RwbEJTMlVDc1hadk1mYUZJUm9kMlN6MWxpbUtGelN5U0pWYmhJ?= =?utf-8?B?bVpJbzE0SGNBWnQ4VkY0bzBIZEtXQjd2T3o2MUF1dkkvM25JdnlhWjF4cXNU?= =?utf-8?B?ekFucjlwc2ZxYVRGaWJ1TVFYR0FsSnR5L1grTjRYSy9ieExkYjM4VVJ2cnhU?= =?utf-8?B?b2xlOU9xQ2pjMFVxZ0JGdmZ1MzkraDYvbkV4YVB4ODU4aCtLSUhGTm9tNTM1?= =?utf-8?B?b2NyRmtvb3VwMm5BLzY0YXlhWnlTM3NpY3Zyb3lWaDkvcUpnRGdEaytYRENt?= =?utf-8?B?YklGZGdkdDBPczIvWGY4RGdEUzB6ZUF2aWZPaDZ0dm9oK3pOamgwcGNScnM3?= =?utf-8?B?UGcyRE9SZUhoNHhmY2tJR2huc0ljKzMyTFUyU3hIcHQvQWkrRnpCWVhGZGZ5?= =?utf-8?B?SDlOaThKNjYydlRIdGZZKzE4bEZFbnBUV1RObFU2R3MvQWluVHlQMG9ONDY2?= =?utf-8?B?SWhHQzhtY08vcDUrZXpqeXZoNEwydllUSFdTRG1xa0RlWVEzMUk4cFNmTFla?= =?utf-8?B?NDQ1dkNiZmdxSmN0bGlzK0hSYUZPWit4bElka01uTGFlQ3VPbEpLRlFxYllB?= =?utf-8?B?b2lIdkFGbC9LZGNJdUhpT1NIMkt5UmJmRGNQc0dyMWZMcmFHc2dQeFhuMFBr?= =?utf-8?B?TCszNXBaZXczTHNXb3RhYjQ5eHZPT1l1WnNXVWpybGdKYmNEdW9oak52OWo5?= =?utf-8?B?c2toM2E1Z0tpMXZpTXNkYWFlQmlXd0pYRW1ldzcvRXAwR2pRa2FocmdVaGsr?= =?utf-8?B?b3paVml0N00rL2dFN09FeTNqbHdEQlB4WDh3citjMEgxTDc4dUJ0Ykt4VmY4?= =?utf-8?B?RUgyd0lSUXk1K2xSWHBGemRCQUxiVFRqYVhVQkZHWTBQcWJZU21oYUdwMzk4?= =?utf-8?B?cy9sS1c0dFRxMmUrZ0N3dWpyYVFNVjlHRlRwWWxTbFNPZDE4M1VsR3I5bWVs?= =?utf-8?B?TVZlcmtMaWhpU2NHZ0IrKzIwcVZ4TDVDSzIxZ21pN1VBbTV4N1QyRnpkdTYz?= =?utf-8?B?VDIwLzZzSkJYSmtqUFJRZXd3QXU5WFIrMEtUSDRhQ2RmcTVhcDh0ODRFVmZT?= =?utf-8?B?bno5aDBtRlNJc0xJL2NEdkY1NkUrZ3RoVGN4SW55S3ZhRTZFV0NsOGhNTHRN?= =?utf-8?B?YS9CamIwalVQSXZWY25ENko2MndxZzQ5dmJRWnRFNFhCOUt4dmZiM2hUV1RF?= =?utf-8?B?K0NhSkJpaW45OWNGdVhtQWZCM1YxZFVDSHA1MzZTanBBU1k4RC9qQ3V4UGQx?= =?utf-8?B?UzRwNlBsaW1tbzExa0gwN2N6TCswcWZScWsrR3laQnZTejhZNG54YU1VMXl4?= =?utf-8?B?NjRFeERaQmF2bE4vTUh2ZCtZdE5BSnlZelhVem56dEx6SlJaeWljWG8rTy93?= =?utf-8?B?Q2U0NXBsU1JTMHBhSFZnSWtQYmlHYWl4cTlNVmVSbnd1cG9EeTNlYloxbmV6?= =?utf-8?B?WDRHMDJGeFV0Kyt5cW5zeHppRS9lUC9BZ3Q1aENvYjZLWHdBajFrdDViclpj?= =?utf-8?B?M21xcU5MOHFwNjM2RjA5VGpkTS9sc21DelN0N2F2V200Uzl3UFBMbXNoYzZB?= =?utf-8?B?TTUvSmluZDJ3ZVkzM1RidXk5c3AvNEFBUXdYVWdnVE9Md08wTWZIa1cxcXJ3?= =?utf-8?B?Q3pocHFYOUwrT24wMTRwQVFGemgxaGN3MXFDT2dja3pVU2JOOWdEc0dERXNJ?= =?utf-8?B?ZTJlb1JXR3VHNHBkcWNBWU0rSmF5Yi8vdDhVbmp1WnA0UXlqa293MXBDckt2?= =?utf-8?B?Mkw5M1h4RndsM3BTbEwyWVc2RzBGbmFsSUJya3UrRlU3ZEx2ZWdPM2MrMXZQ?= =?utf-8?B?cGFrQjlhMWJzUDhCenN6QnhzWGV3cGNZdVloTmQyOTZubzd5ZWErMkd5dGFW?= =?utf-8?B?RnlGcHdkR0pPN2h0UlNSQ3Vsdms4QWhqRE9BUCs1cThTWGhRNHdpV0p4MlFv?= =?utf-8?B?SXNvMU5Kdms0MkZiL2xER1E5TkRKaEVmWDhENWNUb005MFYxdDFHRU1vQkZP?= =?utf-8?B?ZEJiODB0ZG0zbW1FWVgxc2xRaFkrS05PaUxCc2VCWW5HNEJPbkVpUE4veUll?= =?utf-8?B?ODBUTUZicW8zSmxNcVhwZ210SEtKdnFUUm1DcjEzbnNPZEczN2JHQVRQUEJm?= =?utf-8?Q?flGCiE1iMzSEktcOEaBrvJCgZ?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 826172fc-8f7a-47ae-4b44-08dc6c3c6988 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2024 13:16:30.5045 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vZZ7kr3dkSjhuW6rezuQjtYbweUoIm8juzVfBE1tlEK9WX76tRZQ7SkDKVhXwIHJQ/qGFmQ99JQhT5X1sU2CgA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8633 From: Peng Fan Use scope based of_node_put() cleanup to simplify code. Signed-off-by: Peng Fan --- drivers/pinctrl/freescale/pinctrl-imx.c | 25 +++++++----------------= -- drivers/pinctrl/freescale/pinctrl-imx1-core.c | 16 +++++----------- drivers/pinctrl/freescale/pinctrl-mxs.c | 14 ++++---------- 3 files changed, 16 insertions(+), 39 deletions(-) diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/free= scale/pinctrl-imx.c index 2d3d80921c0d..2b7448e3cd65 100644 --- a/drivers/pinctrl/freescale/pinctrl-imx.c +++ b/drivers/pinctrl/freescale/pinctrl-imx.c @@ -580,7 +580,6 @@ static int imx_pinctrl_parse_functions(struct device_no= de *np, u32 index) { struct pinctrl_dev *pctl =3D ipctl->pctl; - struct device_node *child; struct function_desc *func; struct group_desc *grp; const char **group_names; @@ -605,17 +604,15 @@ static int imx_pinctrl_parse_functions(struct device_= node *np, if (!group_names) return -ENOMEM; i =3D 0; - for_each_child_of_node(np, child) + for_each_child_of_node_scoped(np, child) group_names[i++] =3D child->name; func->group_names =3D group_names; =20 i =3D 0; - for_each_child_of_node(np, child) { + for_each_child_of_node_scoped(np, child) { grp =3D devm_kzalloc(ipctl->dev, sizeof(*grp), GFP_KERNEL); - if (!grp) { - of_node_put(child); + if (!grp) return -ENOMEM; - } =20 mutex_lock(&ipctl->mutex); radix_tree_insert(&pctl->pin_group_tree, @@ -635,21 +632,13 @@ static int imx_pinctrl_parse_functions(struct device_= node *np, */ static bool imx_pinctrl_dt_is_flat_functions(struct device_node *np) { - struct device_node *function_np; - struct device_node *pinctrl_np; - - for_each_child_of_node(np, function_np) { - if (of_property_read_bool(function_np, "fsl,pins")) { - of_node_put(function_np); + for_each_child_of_node_scoped(np, function_np) { + if (of_property_read_bool(function_np, "fsl,pins")) return true; - } =20 - for_each_child_of_node(function_np, pinctrl_np) { - if (of_property_read_bool(pinctrl_np, "fsl,pins")) { - of_node_put(pinctrl_np); - of_node_put(function_np); + for_each_child_of_node_scoped(function_np, pinctrl_np) { + if (of_property_read_bool(pinctrl_np, "fsl,pins")) return false; - } } } =20 diff --git a/drivers/pinctrl/freescale/pinctrl-imx1-core.c b/drivers/pinctr= l/freescale/pinctrl-imx1-core.c index 90c696046b38..af1ccfc90bff 100644 --- a/drivers/pinctrl/freescale/pinctrl-imx1-core.c +++ b/drivers/pinctrl/freescale/pinctrl-imx1-core.c @@ -508,7 +508,6 @@ static int imx1_pinctrl_parse_functions(struct device_n= ode *np, struct imx1_pinctrl_soc_info *info, u32 index) { - struct device_node *child; struct imx1_pmx_func *func; struct imx1_pin_group *grp; int ret; @@ -531,14 +530,12 @@ static int imx1_pinctrl_parse_functions(struct device= _node *np, if (!func->groups) return -ENOMEM; =20 - for_each_child_of_node(np, child) { + for_each_child_of_node_scoped(np, child) { func->groups[i] =3D child->name; grp =3D &info->groups[grp_index++]; ret =3D imx1_pinctrl_parse_groups(child, grp, info, i++); - if (ret =3D=3D -ENOMEM) { - of_node_put(child); + if (ret =3D=3D -ENOMEM) return ret; - } } =20 return 0; @@ -548,7 +545,6 @@ static int imx1_pinctrl_parse_dt(struct platform_device= *pdev, struct imx1_pinctrl *pctl, struct imx1_pinctrl_soc_info *info) { struct device_node *np =3D pdev->dev.of_node; - struct device_node *child; int ret; u32 nfuncs =3D 0; u32 ngroups =3D 0; @@ -557,7 +553,7 @@ static int imx1_pinctrl_parse_dt(struct platform_device= *pdev, if (!np) return -ENODEV; =20 - for_each_child_of_node(np, child) { + for_each_child_of_node_scoped(np, child) { ++nfuncs; ngroups +=3D of_get_child_count(child); } @@ -579,12 +575,10 @@ static int imx1_pinctrl_parse_dt(struct platform_devi= ce *pdev, if (!info->functions || !info->groups) return -ENOMEM; =20 - for_each_child_of_node(np, child) { + for_each_child_of_node_scoped(np, child) { ret =3D imx1_pinctrl_parse_functions(child, info, ifunc++); - if (ret =3D=3D -ENOMEM) { - of_node_put(child); + if (ret =3D=3D -ENOMEM) return -ENOMEM; - } } =20 return 0; diff --git a/drivers/pinctrl/freescale/pinctrl-mxs.c b/drivers/pinctrl/free= scale/pinctrl-mxs.c index e77311f26262..aee70fa55bec 100644 --- a/drivers/pinctrl/freescale/pinctrl-mxs.c +++ b/drivers/pinctrl/freescale/pinctrl-mxs.c @@ -490,16 +490,14 @@ static int mxs_pinctrl_probe_dt(struct platform_devic= e *pdev, /* Get groups for each function */ idxf =3D 0; fn =3D fnull; - for_each_child_of_node(np, child) { + for_each_child_of_node_scoped(np, child) { if (is_mxs_gpio(child)) continue; if (of_property_read_u32(child, "reg", &val)) { ret =3D mxs_pinctrl_parse_group(pdev, child, idxg++, NULL); - if (ret) { - of_node_put(child); + if (ret) return ret; - } continue; } =20 @@ -509,19 +507,15 @@ static int mxs_pinctrl_probe_dt(struct platform_devic= e *pdev, f->ngroups, sizeof(*f->groups), GFP_KERNEL); - if (!f->groups) { - of_node_put(child); + if (!f->groups) return -ENOMEM; - } fn =3D child->name; i =3D 0; } ret =3D mxs_pinctrl_parse_group(pdev, child, idxg++, &f->groups[i++]); - if (ret) { - of_node_put(child); + if (ret) return ret; - } } =20 return 0; --=20 2.37.1 From nobody Thu Sep 19 19:38:14 2024 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2062.outbound.protection.outlook.com [40.107.22.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 683B13C08A; Sat, 4 May 2024 13:16:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.62 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714828612; cv=fail; b=PXToDImcbk8MwRhoWBoX7fM9CCtB5gRd5A8LBdiTMzR9Ee+tRqo1ZC4oyzdfKeu2+8A3HdkjkHY2nzksJcesVQoUehpBIYT+6OgEmqctl+DQirS7usoMJNDITjjcYfR6e7DKSffvSNDwMWe2LQfIzAgM0Gs8s8/lIda5hPkEQ4M= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714828612; c=relaxed/simple; bh=o6F5l9CsoiURStmJJEE9Qa953QXfjAQBUVSJDbNbaG0=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=geURmRg8XFBO0EVXnNcrsKT5y4MR5R7DmKkoLIWttzEg9NU9JLE2eXO39gNtl5/dYg2e0Lt6aqs6ryzrmU0cQLODMCtVB3+IBPVXo6qKdRkwAJ5EuJNunqHxpelp+6SymvINNhc1Z+Q0V6Ed1+Z4OjwuLMuE+oNwx1nSjemp4fQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=hkF9lq/j; arc=fail smtp.client-ip=40.107.22.62 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="hkF9lq/j" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Iq0+wWzoQ8QOjJwjhT3U65H2p8s/t/dew5fgj3ZBpZzUk94yZ5xiSQTXDrbvtCsvKitephcf/XzfQs2ZViYgQN5gfd6ViC1nVLrEVKjEmQtDI4l/MsJXIB9Nbl11lNRyFIUpXHNqe9487vJW2J0u2NthW+NgwEvEoDOzbc1p/zC/rNwQTER8ZCEnPsOhweUwo1Z3BsPvJYle71vu8RTC4FvzBKeeKBmkimz6ADvmiRhfBlwz6HKqi5qgB6kSQ00sLNpMBiuILfp4na8qWwd8okkSij5ege9oLWCgBwWWZ/mME405ItQu9locoPpASh1+tFLf8mTXySgGLz31lgnu0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b8YW68N9lyxeJ9/mVk16q9wzxsh3g7k9BYoR+TfhQy0=; b=UE4qcH8Qe+cAnvJzlJYA4nduogUPkrcB6BJOqMOhNnPn8IiDdbCGoFpdL4StqFnNlceH/+46kN2heoV8Vq8jSzfqVwyLVn8w8uLkokRQbDw5ny+DnsqRNsXWE/5oG93KFp0cxGHLmXyTz7jQsI39SL1i21jFaSrstmClmLbCn1LOH17wXCa18NxKP5h8/5EQNSax2tXAEda3a5T/G/Kh6h0hC6qMrJ8I6Va0KrnV6MdQLiIl+CqLLuJf8YGyrg1b1QKAcDuVcD0m13hywuqt9PIJ141rjv2TbAl4BdEMo/W9C1KzPRsnlAwdGNZLXQkgsy5U9DBnPZpzPCakUyiaIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b8YW68N9lyxeJ9/mVk16q9wzxsh3g7k9BYoR+TfhQy0=; b=hkF9lq/jMcSmd1vDCP4Xw1FUFal2vtMiBcdMIM9IGtY/RbMqABtrwAJ/XD3hbLK8tTye+IspbuC5y1BpSRyaRYHzAlK6rsUAqHloELbRn+VX1eNkANyQqyLBPRR0toDsqQl3oXPWoUwPEZdh+ye/fqC2fSv8iNNIsw0PwMz2xQU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by AM9PR04MB8633.eurprd04.prod.outlook.com (2603:10a6:20b:43c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.34; Sat, 4 May 2024 13:16:47 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7544.036; Sat, 4 May 2024 13:16:47 +0000 From: "Peng Fan (OSS)" Date: Sat, 04 May 2024 21:20:14 +0800 Subject: [PATCH v2 16/20] pinctrl: bcm: bcm63xx: Use scope based of_node_put() cleanups Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240504-pinctrl-cleanup-v2-16-26c5f2dc1181@nxp.com> References: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> In-Reply-To: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> To: Linus Walleij , Thierry Reding , Jonathan Hunter , Dvorkin Dmitry , Wells Lu , Maxime Coquelin , Alexandre Torgue , Emil Renner Berthing , Jianlong Huang , Hal Feng , Orson Zhai , Baolin Wang , Chunyan Zhang , Viresh Kumar , Shiraz Hashim , soc@kernel.org, Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , Geert Uytterhoeven , Patrice Chotard , Heiko Stuebner , Damien Le Moal , Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , Chester Lin , Matthias Brugger , Ghennadi Procopciuc , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Sascha Hauer , Andrew Jeffery , Joel Stanley , Dan Carpenter , Tony Lindgren , Stephen Warren Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-mediatek@lists.infradead.org, imx@lists.linux.dev, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, Peng Fan X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1714828815; l=1176; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=ngb8bjYWoY2vP8GroJ6WPcYXu1rPDt13jwjXmDP0P84=; b=DCvLS+tJSjIJOYzv5GBcRPWdyszwIStRArI44CNxG71LlT4DW0wLaiJVWa3krSYbnAQteIYKQ axMlCLkIflgBmSjBIiiZAA++axwuvzMqZXOU/It10tJ/dOb4zf/rLxO X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR06CA0230.apcprd06.prod.outlook.com (2603:1096:4:ac::14) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|AM9PR04MB8633:EE_ X-MS-Office365-Filtering-Correlation-Id: 039ec075-bd8d-4c85-d9a6-08dc6c3c7377 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|52116005|7416005|376005|1800799015|366007|38350700005|921011; X-Microsoft-Antispam-Message-Info: =?utf-8?B?LzduUWVNSlU1RG1jTWZIRVhQT0R0QlJYbUVIYnZWcVB5M2NVUDMrNDRZODQv?= =?utf-8?B?NG5RTDV0ZEkyWlVnSzdiR2pJazBNaVJoZU56bkpyUkRFaklUZ0YvTG1uNHdi?= =?utf-8?B?Rk1kV0JSUWhBMjJlejRTSDRodTBhbS84VEVVbHdNamMwN3ZXVUFPcnFiRzdM?= =?utf-8?B?cUt0OGtkYTRhR3VwbUJNdjFaT3IzTXZqZkhwdEFLUkQxREhzVmNwUHc4RktV?= =?utf-8?B?bWZRanAzTzVQMU1TeWlMZnVwSk1FYnhjU2VYN1I1ZHoxdzV5OE9veE0wcjFa?= =?utf-8?B?cEJxNTlkaHp3S0w5NGpCODhqWS9ESVdSYWhvMzlnV0J3c3VTNHhkUnZQL2Ix?= =?utf-8?B?T3IzUkRSaVo2UUN6bFNhNXJqa2ZudDRCampJWjFRU0JTWVp1dmtjYTE4UE8x?= =?utf-8?B?TGEyMG5YQmt3NEk3aTNpKzR5TTN4bmRDbGNDb1J6bUVTaHI1dHVDRStIUDV0?= =?utf-8?B?RE5FeFhiSkVFYWEvQWw2Rng2Nm5UR1ZyaVNrd3V6TDhWb0x5RFpvVkcxQ2x0?= =?utf-8?B?WmlkRkZnOVNVZ2NBWWxxa21pRnVtNGprTnFuZHF5djkzS2F0VXZrSWVUTFNC?= =?utf-8?B?NWlFOGFObDZIMHRINXVkRHpQYno2T2Q4YU9yZ0Rxb1ltM0kxdWFyc2psdWZQ?= =?utf-8?B?eGUzYWdHV2MyWlZpbExiZE5qeFFIRkJSM3k1KzdjaVZkOVFTdnJTdDdoM2ly?= =?utf-8?B?NDFMTnhROTV1YnhxUXJEUU4yWjM1TEZ3UE9tVFNKdXIwU1NSTGNRd1ZsNlJP?= =?utf-8?B?SHFWV2pVNGlvNGQySGt1WWNMRU9zdVN1STkwVWZwcHhlMjVjYVZrQzVGVjdL?= =?utf-8?B?VnVmdWxuN3ByUW5nS1lyK2dyWm9LaXlRNTFDSDRnSDk0dmlmdkZTNys2N3dx?= =?utf-8?B?YWVZQ0JhYVdLYm12SnlTdlhjNmNRcFk1M1RkZitPUU1NVWZjV1A0bEZwWTZQ?= =?utf-8?B?RFBHbHFCRnZMZGFieGlPd1ExeTRoK0JWNld3RDJ3c0xUMGZXVitVMW1uOTg3?= =?utf-8?B?NnhUQnZWeHg1TTJibzFVcDE3aFRoU0NEc3d1enJiM2Z4WFZMU1lsRkVHM0NH?= =?utf-8?B?RVFsbCtLNmFNT3JqcjlZUGFOS0pualdEY3d2N3BrVGtaTERRY1pMRlVWem9Z?= =?utf-8?B?UjVZenlMbkRKN1F5Rm5vV0FaSHNabGJnRDUwOGZKWGVpU1NrMzErb2VqelN1?= =?utf-8?B?RUFSYWU5cnM1NG9EU3hVdjBiYVMrelMyNUc1UzIwUU5CN0JPTEhuc1p5Q0I1?= =?utf-8?B?NFFaTnZwaDNsRkUrRVVGcHkwQk5qNS9SQmh4ZmdVVWM4cmxGZis0dVpBems0?= =?utf-8?B?TzdsUjR3Y0lVVjZYQjVPVUZ6L09PUHp1YWlJZVNsVDBueE5NL2E0USt5YWJL?= =?utf-8?B?QzdTLzZQWFRZRVZyaXd6SHN0NlluNXduV0RPNlZqcmtHU3o3dFFOU2hCcDZV?= =?utf-8?B?bHZDNm1vc09NYmVSMHB6K1RITGV2Y3V0OURSdUdJaHpKZEJvZk0vbHRPNGVv?= =?utf-8?B?VHI0dEhNaiswZUNoQ3ZKckpBNDE3cmY4Smtra0cxdDdkcjI1bytHL1pJUWFH?= =?utf-8?B?WnZEYzdzbUNXVnEvSzloYUNGNDNudU56QTE1UEI0MDdQS0ZGUlJrRE9MblhD?= =?utf-8?B?TVJnRHovSFNHZnRJK3djdTU4NWREMzRaTWlScDdBdFpNQyttRFpsUGRTQ29s?= =?utf-8?B?Y0ovNHNHOUJYTFBjdlVYelFzS3dVSkN3a08wOFlhVGdmSTVPNjh6OEtqcG9F?= =?utf-8?B?R2kxVXRJaStPWGpQQ3pncVhKaGs2UnNTTXB2dVFDb3dZVW5rdHNmR0M2cGFW?= =?utf-8?B?d3dZaG1INGhTMTdpaHN5Zz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(52116005)(7416005)(376005)(1800799015)(366007)(38350700005)(921011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cEdxTlNOZE9IQ09XNDRkeTRFLzhLeXdxTnNtVmVSdkEzVGNZTnhLM1RZTWxL?= =?utf-8?B?ZTZadC9IUmtLdndtR0FqaG9lQ0pybDF5WDljY0xnUzF4MEVvVFIrRDd1TGtL?= =?utf-8?B?OFNOdEJnZllNVGFWNUlBRTVDbWtMUlhiYzB0WHFKZ01Lc3B3Nk9VRStNWkRF?= =?utf-8?B?eDZIblphSXQyaDhxN3o0U0RmZzVnN044UHIxWExFSTFPTnVibVpqZS9qeUhZ?= =?utf-8?B?cUROTmdlNXlrWm16bzhOWm50S2RHOG9RV3RVRFVoSHh6NUxWUi9YSTdOeDB2?= =?utf-8?B?TXRNQ1prbEpHZHZmMXpHTHZ5d2RQcTMwN1kyeVRCR3lWVmFnRjBLL0VCVWZG?= =?utf-8?B?Wm1raGdXV3dkaVM1WjdSWHUxT1NkK2p4KzlSUDVzK2hPYm1kYk9Yb0xMS2Vx?= =?utf-8?B?dmxIYmlyUkU5SVlMWE1ZcUhPL2IzTHZiZFFRakVtOGEydkVURzNMMUVMTU91?= =?utf-8?B?OTRCNjZWa0pyR0ZBUTZFbHRmR20waWVQMksyQktVMk1sOFVaUFlUSnpIaFlG?= =?utf-8?B?cEFrcDdaVmswT2E0NjZ3dCtaQm0xNytCbFl4SXVLQmtIRm83NTBmcll0cXlu?= =?utf-8?B?L3lVL2plOGMvTVU2OVFDNUgzaGZGTEFYNGJkcExjcEZueE50QzZiMVhHNG5B?= =?utf-8?B?NGlKWXZGZVdJcUZvL2dFK3ZoRUlyZWZ1TjE1VlVjdkdlcHJDMWo5QnJDYUQx?= =?utf-8?B?OUE5NFYyK2U1czVzZWcrazNONHpJbmVYWEhCYnMrZVc1MGlkRk54V005NlpQ?= =?utf-8?B?TkUrd29BcklJM2oyTUlkOStGeTE2MnhuWW9Wem94WENYY0drS0FJdFVSRTFq?= =?utf-8?B?Vlo3dzNNUVBOek9NWTZMcWk4Zjc0UUh4VXRQdDdiN0ZUYjRVSFpidWpCbjB5?= =?utf-8?B?QjY3MmR0UkNIUTlCZVpTRjY3YitIUU9pM2o3SFFkWHFrNlZvRWdZSDNHZDc4?= =?utf-8?B?S1NLOENseDcwOWkrUFJHdjkxYzRpSXU3NUhCUk5qaGtWT3RkSTdVbGNJZmtv?= =?utf-8?B?VGRmcWFPMXJiT1NqUThyTytWRzZwS0ZkcWtRcjM4OVU5LytuUCtGUGNXZ2Mv?= =?utf-8?B?d3hWKzlsMEZKRkZhdGgyMENSajJEMWJDWEE3ZkNkYlllUmhPaWtDMFRYR256?= =?utf-8?B?YWkxb0hybXJMYittaVY5OTRTZVR4QTI1dy9LVjBUbmJ0NWJ5Z3JZQVdadVdN?= =?utf-8?B?OTJWb2JxNE94b3RMNkRaazV2V0NvalBuSDZGUlZJZGJzQXZqM1d2VEcxNFBk?= =?utf-8?B?TlRmNUlrallucTdGZEpPTXJyVkJNTStTY3hpRUtaV3RkV3JVSkR1K0F6TTFx?= =?utf-8?B?YWxxbk8za3RoajJ3Nnl0V3UrOHlUeWhlL24zcUNsTzUxYmxXLys0TW9pY0VG?= =?utf-8?B?TUZBcVJtTkZ4R2ZET1Q4ZU5rVDRnTzdsZEVrdDluTDl6WTRyR0hVY1Y0bGZa?= =?utf-8?B?WnVnMzJNK3UvTFd0QmJHVnNUY3hvaDV2dUhBajYvWmd2STUzTHdTMUVIT3ls?= =?utf-8?B?L3VXWEU0blVoVUYrczVDTjI4dDZQbXVEb1pUSlRwc3dvZVV4TGlNSllQZXlZ?= =?utf-8?B?dWUwWlBDa2NhbEVnbmttd1VKTW5NWW9tTnY1Ym80b3ZLSXc5R2FvZUkvNjRO?= =?utf-8?B?ckNiTU81WUJESkpZUnNGMzFsTVlFZlNsak5jeHVSQVVqTHNmM0srNDk5TlZl?= =?utf-8?B?c05VUVdSZm5pYkhGR0RSTERoYm1HWmZETTBjSlB1ZklYd3pEU3hqaW1Ua09X?= =?utf-8?B?Y211SkVoSW9DRml3T2tHZ2Z2STBKd2VBWURuOHBqUTJ4SUVTSC8yVEQyRjVJ?= =?utf-8?B?WTMwQUdrWmlkamlXdVlnaTF6OUtHZzNPYTVTMDBhbW5CWEZOU1pNOWdEMllO?= =?utf-8?B?VDRzc3hzK1BZc1RITUlRdTh0MXhBNWRGTW51S2thdVdPL3h1ZW1qQUtPc2Jl?= =?utf-8?B?TnVjaEU0YnBiT0xuc1IyUlN2ZzZXRFdWVzNDRnY5akg1ZHMvTVZqZVhFUnBP?= =?utf-8?B?RHBYcUw2dWZJY05DZDNteEx1NTU5d3o4K054Y2RGdGlCNDNiSVpNT2VabU9m?= =?utf-8?B?S2tsWHhuaVRWUjJBR0NYVSsxdXFlcEthWCtBY0dyK2ZMbUcyMWp6UmN1cTYw?= =?utf-8?Q?l3l98y3cuPmFhHCzZOaoEXeOt?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 039ec075-bd8d-4c85-d9a6-08dc6c3c7377 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2024 13:16:47.1839 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: shY0dafUZUsi2/PfSPmiPNkIGEOpXTthpisY1rGu+XtACuv/H167vsA0VUdr90Fmv7gkwOa2dZP59lS30mxyRQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8633 From: Peng Fan Use scope based of_node_put() cleanup to simplify code. Signed-off-by: Peng Fan --- drivers/pinctrl/bcm/pinctrl-bcm63xx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pinctrl/bcm/pinctrl-bcm63xx.c b/drivers/pinctrl/bcm/pi= nctrl-bcm63xx.c index e1285fe2fbc0..59d2ce8462d8 100644 --- a/drivers/pinctrl/bcm/pinctrl-bcm63xx.c +++ b/drivers/pinctrl/bcm/pinctrl-bcm63xx.c @@ -67,7 +67,6 @@ int bcm63xx_pinctrl_probe(struct platform_device *pdev, { struct device *dev =3D &pdev->dev; struct bcm63xx_pinctrl *pc; - struct device_node *node; int err; =20 pc =3D devm_kzalloc(dev, sizeof(*pc), GFP_KERNEL); @@ -94,12 +93,11 @@ int bcm63xx_pinctrl_probe(struct platform_device *pdev, if (IS_ERR(pc->pctl_dev)) return PTR_ERR(pc->pctl_dev); =20 - for_each_child_of_node(dev->parent->of_node, node) { + for_each_child_of_node_scoped(dev->parent->of_node, node) { if (of_match_node(bcm63xx_gpio_of_match, node)) { err =3D bcm63xx_gpio_probe(dev, node, soc, pc); if (err) { dev_err(dev, "could not add GPIO chip\n"); - of_node_put(node); return err; } } --=20 2.37.1 From nobody Thu Sep 19 19:38:14 2024 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2078.outbound.protection.outlook.com [40.107.22.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 846A339FD0; Sat, 4 May 2024 13:17:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.78 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714828629; cv=fail; b=Ir+FP0J3lHtrNfUgSg/X0Za+uxixB4fBbB3uu/sAar+0eSvBNNanHxwYjD307dNTxa/g+mJXNwaIN4IjYXr5GKxvIkGpctVqmKHKiiGI6sWn3eySfycDgNjaRkz6YCN6WLBRPVKEzx81vYvJNjfCkSpevMhWTaxryfrR57sP7lU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714828629; c=relaxed/simple; bh=Hg4Xy0vEppWnC63RFatzWPhpn/VvXfklWFuoj2CIg+Y=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=l2zqKPPM0JfHttFrZ0g9BBrpevtssuA5qaOCOJoLyrTPt2iIg3FmI6R5s/oZMqT2vBInCN5S0zvF+oMtcybYT7F/S5xD5nUF4yWaEddkKXQcFDv9FPGWxKIgDu3t5R/eI3+sb56b028jeTtdmN5P7v4VrSLz75ZrmnImsBizTHw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=Hujfgk6p; arc=fail smtp.client-ip=40.107.22.78 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="Hujfgk6p" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UlggmPZvqE79ZaeW1gTAbA+cs1kIqi2SIyvOM1HB4159JF/+JtCxmfQiW0ivqdXP5CXkKje/nyrmWH/Yrn/GJo/ayUbcZ+X7nWP9o82PvscO9WYRE33rPFwr6REMQXZZgRmeuzGld47CW5hNOyINSpkGwwt41YY4W+dJkF2OBzO9Jru7wS7dw8RyU47sOrtdJeQefKEOH5Rf01ZmrXjRMuEfr+0BICN4NYt1LACPnQEuj41Jh4qqSfByzmuZ1dMuc1l7qwVm73K3m2oHRU+DAEs8Gi2JKGyam4WkrpLUqSqCD0bxtus6agOBE0cWUaxvdjW+UkG+HtJXUKZx3q8OyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OzFmWqqgAaHNbNJ4y5r21eHdO5OywXD/utfmPqrXP8Q=; b=TgVpot3hegYYv3qbkWnLZxHoF9Lz7u+bMV5C77TdeGnx3Ry6fBW9wp98fjl8BNVSkpfnxfSzk3ETv8W9t2zD/MuPKI01Ilsgqe23L7MPimZ4SNdsBCI/2UAeCuxN6ej1okwS8bXnqP1nsWbmIvxD1AAwBe9FFp/+vFE1GVbmZ7o0jAf+PHqp2by/jQp92NhEoS4xiFsH3W3i6UgEzOCXNB7Bx+Ti9HYrCmDvb++GAKFHiKLqPkGZY6rNJHrWf3p2+OGupUqsfQOQjc1jZs8Th7uhdyRGqBvFpKqcjOU4ReHTJRv2IQUjfDIG5+xEw4EY3//hA5atG4ZS1cixltpUMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OzFmWqqgAaHNbNJ4y5r21eHdO5OywXD/utfmPqrXP8Q=; b=Hujfgk6pBbJGD9Gn7U6zkbL3oeUYDzP9UMdHGvZL/K+xEh+dg1xpaQYo1lBHM8dRZTsMDLDcMg7aDlpeBuyBnsTkrCN9AI7lSKXvaG3RIin2lRLyV/vsqE6L59CW7E1hXxjdoMrKgn3ksp4JBgAQIzBAi4SZ3isnWO3ZQqIciJU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by AM9PR04MB8633.eurprd04.prod.outlook.com (2603:10a6:20b:43c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.34; Sat, 4 May 2024 13:17:04 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7544.036; Sat, 4 May 2024 13:17:03 +0000 From: "Peng Fan (OSS)" Date: Sat, 04 May 2024 21:20:15 +0800 Subject: [PATCH v2 17/20] pinctrl: pinconf-generic: Use scope based of_node_put() cleanups Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240504-pinctrl-cleanup-v2-17-26c5f2dc1181@nxp.com> References: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> In-Reply-To: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> To: Linus Walleij , Thierry Reding , Jonathan Hunter , Dvorkin Dmitry , Wells Lu , Maxime Coquelin , Alexandre Torgue , Emil Renner Berthing , Jianlong Huang , Hal Feng , Orson Zhai , Baolin Wang , Chunyan Zhang , Viresh Kumar , Shiraz Hashim , soc@kernel.org, Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , Geert Uytterhoeven , Patrice Chotard , Heiko Stuebner , Damien Le Moal , Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , Chester Lin , Matthias Brugger , Ghennadi Procopciuc , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Sascha Hauer , Andrew Jeffery , Joel Stanley , Dan Carpenter , Tony Lindgren , Stephen Warren Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-mediatek@lists.infradead.org, imx@lists.linux.dev, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, Peng Fan X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1714828815; l=1107; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=2wM6S75hkeICu8KMVBGWw7nINzfNCEUbOtGveeJZglQ=; b=W5Ezlhd9RfExH8zWzuKwrmVUyRSF1AbQsCIMFKOLEKa6ZeJmr07/EaJgdP6wSTycJk1QVaR5H zbLbDF4FDjFBbtd58shfrCerWTDLaxNYTJIpazadXEO2mmS4+ShJxp+ X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR06CA0230.apcprd06.prod.outlook.com (2603:1096:4:ac::14) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|AM9PR04MB8633:EE_ X-MS-Office365-Filtering-Correlation-Id: 0c1176af-102a-4e3f-0f53-08dc6c3c7d6a X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|52116005|7416005|376005|1800799015|366007|38350700005|921011; X-Microsoft-Antispam-Message-Info: =?utf-8?B?RGRpa3pES0VtTU9yOGtDQ2srRElob2g0VjNPbTZKWDh6dnIyOTNXQndDa081?= =?utf-8?B?ek4zcjFSMW5ndUVIcGNVMkZnUlo2OVBEcElHaFhCVTJvUXB0RysvNGZlMFAy?= =?utf-8?B?UUVvejI1SmRVakFnZTBVd2p0WTc3NnY2VFZRSmpnUHROc3BZOVRDZzVob0dD?= =?utf-8?B?dFBHMkVCblZyclVOSmsvRjJ0SmFKNVBPZzQ3RTRCbEFwWWE4ZU1RaE5CQ0lv?= =?utf-8?B?RVVRRlJOWjRxVHJDcStRVWxjZXlEVzBBMHhNZzc3ZU9pdk1XbmM0d2U2bXIx?= =?utf-8?B?eUpWa0FtQjFraXp4SEdoUndJUElzbmtHUXkzNHNlUVFxZVY1TnhNYVB0UzBh?= =?utf-8?B?MUZDNERaMk93RVQyVGdSUVEvdHA3aFVDU0pzOGgzbGFPQUU5WCtQMlBEd0c0?= =?utf-8?B?SUQybEluN0lVZFd4eG0wNzdSR2ZDQmFHNWtzSHRTd2graVMzYzNIZmN5SC9N?= =?utf-8?B?MnFvNDhpQ2UxbjBEM0poemhaS1AyVmFmLzlBTmpiZEFwbWNjSm1sOHAwWDFF?= =?utf-8?B?bm5ZM0paMXJvTXZKamZCQXZMbGthL3dFSUpaYlFYdi9qMzc0NnpFOGVteUEw?= =?utf-8?B?eC9FcGF4dTJkdVhZOU9SRW9jTFl2QzlJYXl2UDRGZ2FHZ3RmUHI4cks0ZXRv?= =?utf-8?B?ZHNPSUQxZUNsSE81ZFB2elRSMGdhL0ZFZys1dURIKzF3UVdRUUk4WW5FNDhq?= =?utf-8?B?T1haUG03cDRVTGRQUDd5bkVFR09MRkhXcE5BdUk5OTJmZ25VZVowQXBlRUxV?= =?utf-8?B?UTJJRzI3d1h6T29YaVdseWRRNnRoaGg1aUdEajdXRzZQYkVtUXRVVE90eGJY?= =?utf-8?B?VjhJODZOWnIxb0tNS09vZEtYcXBsaE54OW5FV012OCtBc2dBQ3VEZ3lGTHYz?= =?utf-8?B?eDI4RTlmMmR4UWZHN25TYUkzME12MXlHeERTeWtLZHQySDJRdVc1bEhxZHg2?= =?utf-8?B?VDNDWjRLVkF4bzdoMVhoeFBJaEVKNnJXa0N5K2NMZ2VSdU1xOFVJay9FQXF5?= =?utf-8?B?SlFnYTJiYnd1L3V0dVJhSnJ0MlRaSnRaVU0xVHduMG1vd0l3MGo1TitsZzBP?= =?utf-8?B?V25hNzRxT1ZuSkJMRzlDVTFvZmJDZlhtQy9EWi9LV1pzUWFCYXBuMUtPRFRi?= =?utf-8?B?M2trM0pKemFGWWNEQ0lSdXE3bVRBbEVXbFhieGpOOGVuQTF3OTFnTEVSelZL?= =?utf-8?B?SmlSemFobzRPSlkxSnUyRDZDejBERXJwM1NkekNZWFYzbDZIWFNid2lNQmJ6?= =?utf-8?B?RkhvU1ZWWkNJU0FCR2h2VDZGbldpRzhvbXpHMUEwY2RBRDRPazdhV3FJMWRG?= =?utf-8?B?VXhyWmlaNWtDNnl1UmpGd0JVWUxHSXR1TEJaenJNMHk5Ui9nRDVUbzRkQTNH?= =?utf-8?B?UjY0bFA1WThYSVg2SHRGQnRDd28wa2E4ekg1d2F5ZUpBNkFUS3VRNndEem1M?= =?utf-8?B?akxmUG5XZFpkN3pPZjkrREFmVys5WlJ3KzFMa1ZlTnJQNG1idWkxV24rSHo0?= =?utf-8?B?MkgrcTVZNTZZam5YN0I2VFBpSVBxOWEzVmFDMllPSDVRQk1jSVZOazd4VVIv?= =?utf-8?B?U3F3MGlmdnJPOEo4WGxJdGNlZ2dXbFRVb2hMdmZkelFWNlpqbTRxQVNlYmdi?= =?utf-8?B?L21OSjQ4YmJMQkJrUmVGSzE3VjhERE0zWmh1N2poODRlRG56TFUrMDhOM1Bw?= =?utf-8?B?QTkyM3BQQXlnN1g2UHRnSFV4Mm9kcnN6SXJGWFBNYVVNT3gwY1l4UlM4alVo?= =?utf-8?B?U2E5SEZoN1RGeFMrdkJDSkN3UWFUTE0wZC9ROXRVWGZQQUR3WStnZkl4QXNr?= =?utf-8?Q?UGekrTbvrNDIe8lMFMn0euljNvOtJCVLh9uYQ=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(52116005)(7416005)(376005)(1800799015)(366007)(38350700005)(921011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b2wwOVRvd3c3SWhzUThUUXo3eEI2M29oRzZyeHQvMEJXV0pGNmdWbyt2L1d2?= =?utf-8?B?WFpvWURFblphanhTS0czNUVqL0hLelpNNXBDbnBjd3hDOG85NEdCNS8wbmJJ?= =?utf-8?B?d1VOTkF0emM5dy9RYTRsdFJvWEVONGlnY1pabkFhNUZrMno3dWt2ZVRiNlRm?= =?utf-8?B?R3NieDg3clQzRjFpTWNOaWhmYkFEZHBYQkJnbStSWGRmbHhjelVOaGlJTGcw?= =?utf-8?B?S09TcGVGcG5RMTFidktNcnErTG5CRmpYRStvY08wYlJNczJaSnZ0KzUxT1J3?= =?utf-8?B?RmxoS2dDSGVIWXZqMzNqSVJuRFVDUTEyR1pOUDNhWnRoMlFOVlNiNkdRakRm?= =?utf-8?B?MGlicmhvWEhINXcxMXlpMEdNeEFwNmY2RE82cndvZVBzNVNjOHc3QnF3b1JS?= =?utf-8?B?R3MzT1EzcnBUSW0yamxKUG1PWlBCeHcreEZnWHQzdEZvaGNaV0hmbjRCN1c2?= =?utf-8?B?TFVYQkx4M0lTek1IeW1QYWU4akUxWTRGWHpwUi9zSE84L0R5b0RsQVloejE5?= =?utf-8?B?WE5oU2d5Q1c4cFIwK3pCNC96UGgrR0szNUJJK25FRU1rMGVDY1JJdUlWZldv?= =?utf-8?B?TnB6Y3VGcjRwVHJ4Q3ZHRWNSZmJ6d0FXekpNZ3BqODMxS1Y3U2sydTZ2eVdp?= =?utf-8?B?a2VFNUpJbG82ajE2WnhNbmN1cnhTZkVrenZZN3BFTW9mOEtJSHluNkxYU1lN?= =?utf-8?B?YnVTZzdSbWtma21QWGVBeWs4NGJCVEdjMHltRTlwVllRVGNXcTU5ell0Uk1Q?= =?utf-8?B?dUFWVFJJRU9TQUkwWi8rZURybTc0UGJhNUYrRmFiNCtPOVgyU1NjM2ZkQlhJ?= =?utf-8?B?WnhrQm5iUmtEMUl2eHI5MEZlUHFOS2lacWtaY1JxTGpPbFFyWWZlOERlMjd6?= =?utf-8?B?Q0t2ZlpqMXhtTlhSUW52d2o5S0t6MDFMUW42eEN6aUJHYVI4dzE2cGxRMzFZ?= =?utf-8?B?NFVXMXdOUUdvdFJTRnUrSEtNdUxnZUZia0hnQXRlUGZlT3BYM25HZUZpWEVr?= =?utf-8?B?bmZ3UTBTano1VEtIZ3VxazRlSTlhbWcycWFTa2hwTXhUdWVab2JlVERHZUhP?= =?utf-8?B?OWtNT1FQMkdKbFAvZkovVnF0aDhMaFFiWFpVV255Y1Y2d091M0J0VzNXRGhn?= =?utf-8?B?U1FIU05HNnFueWt1K2NxNmYxVkV6QWF4WUVtZDlZbHJvVE43V05uNDZPVEdF?= =?utf-8?B?VHpzbWRZVmdhaGthUnBxZDdxYTZhdlVWcksvZVFhdEJyeFZCQWZrejU2dU5q?= =?utf-8?B?MlJGaWQ0UEVSTVdzRzltWDM2bXJkK2doYWlvZkNvUWJ5N2d3MWJ4N2tvYmVT?= =?utf-8?B?NFNreHhyL1YrcUJpVy80NGRrTUNxSy90anJYUG9sUDBud0tTbWdzRHZGYnVp?= =?utf-8?B?WWE3c0wxaHIxOGR1dkpRK2J6N2FiWU9Ldys2bFEzMVh6TS9uTXhsQzJEbjVm?= =?utf-8?B?NlJ5V2VWZCtlbFQwOSs2TldtOHFuMTRRSHhSTTl1ZTdWbVdoanJXSTFpMnlI?= =?utf-8?B?Qk1KYnFMNXdJbWJYMWgvRGN3azBvc0pvUmsyZ2lFSDBpMlp0N0Y2Y0JnU0dr?= =?utf-8?B?V0VMaTh4Y1F3V1lQRlUwU1hHMldGVUt4ZDU0V2UrcDRqN2wweVF0VkRienV3?= =?utf-8?B?N3FJNmY2T0o3eGR6Ui9iNDB6cW9HdC9vT2NoWlVQOGhLVTlzZFZybmpTUGEv?= =?utf-8?B?VlVJK05vMks4bkVQMURHdUVpaGlvK21NWkJqNFVIaEt4Z2NpTzZmQ1ZSTHBI?= =?utf-8?B?b09BcnQwTGkxSXlLY3ZWUVRuN2orRFplVXc3N3V0aFVGNGo0eS9LYjhLbmZ6?= =?utf-8?B?VFFGZTRhUEVqZi9SMlE5ano1VUN2K3krWmpUa0ozSXRaaTgzYWxDTkhnV0wx?= =?utf-8?B?eXV6RGFkRHlqelpGSFIra0tFREcvaW9sY3hKd3pJMlZIZ2JOR1FjQkRSa1JG?= =?utf-8?B?WWovOURZSk51TThua0hBcFQwcWxSNWEwVFlHZkpCSmtyU0diQkxoV2ZadUdQ?= =?utf-8?B?cnBFRHJoRGpmb2hvbmllMkdZemRLamEvdjI4c0VZTER2U1I2clZQRUd5cGF1?= =?utf-8?B?cm1QNWRCTkR1eXowZTZJQ0pmOGREbm11UmUvQ2xGMG5kVjk2RGJiR1NTb1JS?= =?utf-8?Q?kpc0BrcBPbGpYrGqyMcFmCYKd?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0c1176af-102a-4e3f-0f53-08dc6c3c7d6a X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2024 13:17:03.8642 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QEgJUaP4zRnl3xuiECIIdwnDgtv8meyTZQoA+0gbgaDOSP2A4ZANHr3rQdpLv48ANaBT0NARX4dl/yrvw7Rd4g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8633 From: Peng Fan Use scope based of_node_put() cleanup to simplify code. Signed-off-by: Peng Fan --- drivers/pinctrl/pinconf-generic.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/pinctrl/pinconf-generic.c b/drivers/pinctrl/pinconf-ge= neric.c index 80de389199bd..a499b8af5c1f 100644 --- a/drivers/pinctrl/pinconf-generic.c +++ b/drivers/pinctrl/pinconf-generic.c @@ -382,7 +382,6 @@ int pinconf_generic_dt_node_to_map(struct pinctrl_dev *= pctldev, unsigned int *num_maps, enum pinctrl_map_type type) { unsigned int reserved_maps; - struct device_node *np; int ret; =20 reserved_maps =3D 0; @@ -394,13 +393,11 @@ int pinconf_generic_dt_node_to_map(struct pinctrl_dev= *pctldev, if (ret < 0) goto exit; =20 - for_each_available_child_of_node(np_config, np) { + for_each_available_child_of_node_scoped(np_config, np) { ret =3D pinconf_generic_dt_subnode_to_map(pctldev, np, map, &reserved_maps, num_maps, type); - if (ret < 0) { - of_node_put(np); + if (ret < 0) goto exit; - } } return 0; =20 --=20 2.37.1 From nobody Thu Sep 19 19:38:14 2024 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2051.outbound.protection.outlook.com [40.107.22.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 780BB347A2; Sat, 4 May 2024 13:17:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.51 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714828645; cv=fail; b=JqmKQOv58B4QNnn62xP3gFDKNLnGgfLPYS4Bp7YPPItZ7lVG1mxDV8e9N2mdQeD4IeykFxkmlvV4ZhbY3ABAsYxSt7n1dagC86gMJkHe8m08BhtEdHmd8PTAcRjqhRXoN506ed3TM5tT9ul7Cl8CebzoWFgdZFLMQkKxJd9FtMg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714828645; c=relaxed/simple; bh=VIt+S9lqc+k4TIsuVnBU6FhhXcdzzv/izY3n11KkU7c=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=pd58cPwY/oGQe9je8VcGC4xejWvuNNXV/AKnph0B1QYgjkc6lYawbkmacH4VDctzcmgu77wNB940BtHN4IcCutNQS5dQSr+Z4wwU0UY3UD/qkcIpCeEk1BYchJTU8iRf5wvAjxbDCoWpz5eBWyj5yZTdW4I+Z6TeTZ3XhKAjB0Y= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=jqHBIut/; arc=fail smtp.client-ip=40.107.22.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="jqHBIut/" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Uit+z74daa9mOsT6ePUJ2VMAVskH21u3nzQSgbWmY66uHTJ/hJPh1jE2HKUZb6uVYEyh9QWswo0MpHO5IRoT3gaPUQ8ozqL+Zol0j8WJTB/1Bg9/eMtv3pEgYzA6jo96MlfZ6HRJ87eGzlxhc2oetuS3TMwOhqbF/52fIV9eHEewG4Rz/IO5TFnv8WDYQma1FaukRc7KZGSJD8jiuIt/olxWiHkrxwJidc6F6x/q7x+uqxpYfLP9BVTIK7jNmlsbWAdJ98bwwxslgbyXMhrZhGwr+AfrVapxsgbV3SzIiguWOuoxbpsm03n1hioZxn1LE/JYKOI8rYqMJ0PxPefLBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b/qD4YQU9UBX2QLemhdFC0vYRw50NOR9F8fnfRi2ujg=; b=OSk6CPQoV8WoO69chXXc/btdybtOIRVLJPiTTfEB5l1MdnqEtN958wiXrp9lYGxp9hIJpgEIkQqLpT0OmxHgBKme/YUWV7INO6IHFnNXbjPyMae0RDCRa/oTYCmWuj4Zf8oTzVeEPND8FPz7b0fUw+KzjMhbgES8lmowZv5ACW/WQuxDyS+LRkDiqyhLFbZZY7e45IvTmYRjZy6Qmxb8K2F1f3Ycapp56u4pSIujKebpsUkM9I5lNGnXlfQ96BOn7wba1CmZdyXzyZyiloWMV9OqB5IMsW31w6WPQ6K/ibTBWbm1PZVqk3VEaddsQbo6T9ynEZnv8miZ66x/pzQwZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b/qD4YQU9UBX2QLemhdFC0vYRw50NOR9F8fnfRi2ujg=; b=jqHBIut/ZxbfJT53SP+F1q1/5XOg6UM2ONcAdAT67c+od0NBJAE39H3VHJG1SWx0ywtzj32TlW1Fd/AIhsGyWwULIsjQ0WpPgHOiFzXGz41QPlJDF47l7uhM5BRFfOR60nmc3R4N2OZlOD9/XhRjUIgsj2lBom2qTdNGz8hJ7zQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by AM9PR04MB8633.eurprd04.prod.outlook.com (2603:10a6:20b:43c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.34; Sat, 4 May 2024 13:17:20 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7544.036; Sat, 4 May 2024 13:17:20 +0000 From: "Peng Fan (OSS)" Date: Sat, 04 May 2024 21:20:16 +0800 Subject: [PATCH v2 18/20] pinctrl: freescale: mxs: Fix refcount of child Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240504-pinctrl-cleanup-v2-18-26c5f2dc1181@nxp.com> References: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> In-Reply-To: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> To: Linus Walleij , Thierry Reding , Jonathan Hunter , Dvorkin Dmitry , Wells Lu , Maxime Coquelin , Alexandre Torgue , Emil Renner Berthing , Jianlong Huang , Hal Feng , Orson Zhai , Baolin Wang , Chunyan Zhang , Viresh Kumar , Shiraz Hashim , soc@kernel.org, Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , Geert Uytterhoeven , Patrice Chotard , Heiko Stuebner , Damien Le Moal , Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , Chester Lin , Matthias Brugger , Ghennadi Procopciuc , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Sascha Hauer , Andrew Jeffery , Joel Stanley , Dan Carpenter , Tony Lindgren , Stephen Warren Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-mediatek@lists.infradead.org, imx@lists.linux.dev, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, Peng Fan X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1714828815; l=1008; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=n5zUltymbb2QT8OVUi0ykdiDnyL/KXFAnvLfuklG8sk=; b=VlM2s8MWPklorkSZy9NCPoYCC+X1qhpT9U8O+RJ4UAzCFrQN9FgW0mVCVJh3cOF27q65t8QZ6 Ls7HHept/5WDey6gNVcw0jH5LWh2wGBBfxXZKtcPS/ES2kVoImJ3XLa X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR06CA0230.apcprd06.prod.outlook.com (2603:1096:4:ac::14) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|AM9PR04MB8633:EE_ X-MS-Office365-Filtering-Correlation-Id: 4a333ccc-4d63-4645-7e99-08dc6c3c875d X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|52116005|7416005|376005|1800799015|366007|38350700005|921011; X-Microsoft-Antispam-Message-Info: =?utf-8?B?c3pvWFRSTm94VGN1REFOTC9hdnZqbGxyUHVjVDJzNHViMDZ0b1dpeGlMak4r?= =?utf-8?B?MmI0NEtYYk9sVzNOeit1OHpIYlpNZzlzV0RLRU9mQ1UwWktNZjBNMkpwVFky?= =?utf-8?B?cVhlOVBGTU5JUzRWS0MvSlFtd2g2ZkV4R3lpNjFmd1grdFpJU24rVmJ6b0M0?= =?utf-8?B?MlpqVW5SczloL25POWFTLzhvMWo3UEdGZGcwbjRTdFlHVDZHaWNoZVpnNTMz?= =?utf-8?B?anA3VVFRWWp6d25wY2FXOEpNZElSb29EdDhsNlVqYjlWTnkyWCtleVFmb1BZ?= =?utf-8?B?azlIN3RtVTFqa2xqNStpRlgyMVY2S1F3dGlkdkFiUy9WUHgrV1lWUFVLL1V4?= =?utf-8?B?NmdNRHd6ZVRKc1krUVBSd3R2K1hQMGJCOXBLc1d6QTR2NlBrNXNPUW90Zm4v?= =?utf-8?B?RkpKMGFQbHVWcDlDWlNMTy9PdTJwSnJaZkIxRm9adEVabkRSRXl5MzZyRmh6?= =?utf-8?B?ZWZISjJKUElUcFUvbk9QMkVmSlNpeWFoL21JU2dCeWhIZHNLRTJ6bnlVNVRz?= =?utf-8?B?NE0rTHo5aGZYdnJ6eDNzSHNZR3A5NlVtMHVGMnJYaUYrdE1TWFhMSnIzZW9S?= =?utf-8?B?ZVphay9kNm1JV3luMHduN0c0aHd6ZXlmbHdUWHp0em5VekhYejlFSnl5V0hC?= =?utf-8?B?d25GOElTVVYxdk9KdFp0UllqTER5ZVRtWnZpV2VXYThoRzNBeGpPVFZ4Y3pv?= =?utf-8?B?dXdCaUEvQm1kNU1KS1dZRlVZd1pJa3crc21MK0NXZWZwQjEwZ0daQkhuMTR3?= =?utf-8?B?VGU4c1duMXIwZ2lSUHdlKzBNNUt0R1ZIYS9lNWlsL3RNVC9INnZGRWJScXV1?= =?utf-8?B?K3BzcFc3Y1FBY3JCdEdaWDM0ZWNoVTJzR0ZhWkFGMmpGQmU5bVhMVXAwZk85?= =?utf-8?B?RTlzajh2cDR1eDQzd3FPVXVSbXgrRTdkSGpFZ1BIZVdISUd0VDZ0MmVuOGpG?= =?utf-8?B?aUozVklrNW9BdHlCTHRyblBkckpINFdzYmV4T3ZsbXpZWUNZTFNFa3JtZlBm?= =?utf-8?B?RWp0TXM4Tmd5OXNQMTFlZzMranpKZkg0azkrMmVaTHZDTjJFUHFheEJmRjA0?= =?utf-8?B?MmZPZTA3ODZJYkRYSkNWZTJpNGxDcVdrTTdwd3NxRklXTnZVWVRobVlad2k0?= =?utf-8?B?d0tqQjBmQ3FwdEtzeG5zMjE1b3J0UXpnc1dsb3BMMFZuQmVnUFFlYUlvbDF4?= =?utf-8?B?ZDFqSkwxb1dhc1pMcWZ1RFVYL1U3bUxHNXBGeTF6TG1WTm1IR1NWOHpnRFlj?= =?utf-8?B?Rm9CSlcyenB2a2I0Z0d5Wk5xWlRKZFdTc2twbExaZXJKeHE5dHdlcEZEL2dF?= =?utf-8?B?ZmFmelRjczlHemZra0ZYanMrVE9VNkk1dVBmSnJYVndodGNpNkl4Mk00TG1U?= =?utf-8?B?bm1UUjdZcGw0OTNmWWFHekh4VGM1WWF3dFliYTFCNlhtQlEyRHpjUjRFUWJF?= =?utf-8?B?MituM0FrZUZtaU9xdmIzSXZ0TmF2WmpMc1JXTDZlUE1VOWdheDMrSXFSV1BY?= =?utf-8?B?Z2p6SGo2dFppWnRNRmRha0JCZHFBTkN0dkNvaHBFdkJ6b25HUnE0VjlmTkpr?= =?utf-8?B?Ykd1bEsyeXZiRE5Zd0ZtVERtQUsyaDJzYzRjR1lxejNJSHhOOGVSMm1KWmZ0?= =?utf-8?B?aVFrNk1HcFZhaEM0NDlML0owWDQ4YlMwVlQweU9JVHRNNTdYMGxoSW00VUpa?= =?utf-8?B?OGhGQXdHRDlidERObkdmZTJNTk1CNDlWQ2pvdEhNWWtJRXcyakZGR09UaFcz?= =?utf-8?B?QTJwYVVlRzlSUXFKSUE3bEU1RjUyNXRCZVVkZm4vTnBJV2laS3Y0UDh1ODlh?= =?utf-8?Q?1qenO5INjoactfyJKvsSx1utsUO2mruGz39w8=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(52116005)(7416005)(376005)(1800799015)(366007)(38350700005)(921011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WlVZODB4bG1qNm9zQ0d4eXVxOVJhLzZoeFpGWGNjdVd4b09na2JKOGtTZkV4?= =?utf-8?B?Z09xS1VIZnZud0hYVmdnQ3Y0Zmdsb0UvUEE4MnZqSDgrUXdzenNlTmljSEpU?= =?utf-8?B?dGR2bUdtSnkyZFJDY1dqT1NhT25peUhYaGhncUVoTThXaE1rWjdIOURjTzh1?= =?utf-8?B?eDEzZmFXbWl3ak5Zb0RPaEhYaTJhS2lEL29yc08rcXZoWmQ0ZStNTkp3ek5t?= =?utf-8?B?dms2VkdTWWdSbk5RN3d3Z2FDTGZSREpZZTFoaXFGYWF1S0xKa3h1UnVCYnRM?= =?utf-8?B?MHlUMjVIWkFsbEQrelQwWmlqQk13TzZoOHp5cmVJQVgvS3BPNkZQK0FrSTMy?= =?utf-8?B?bG8wSDV3U0VxNDZ1WnZnS0J3REt3R1ZPV1VzVHZsUFlyNVk5VVJvVmJMODZu?= =?utf-8?B?a210M1pBOVJyVGovd2dzVGJ2RVJIampHMU8vaTZZcTN4bVlDSllFS2FRbzVD?= =?utf-8?B?dGtSb0lmUEYvTjFYSFo1bDRBZExXY2ZXbUZuNmlMUllOdHVjbjFNS0hpMzhu?= =?utf-8?B?ZTA4bFV0bXpmWGRFQS9wam1ieWhrOUtjNFRrYWFlQnNZTlFsellrZUduOUhO?= =?utf-8?B?RVNmZjF5bE1zOGs4S0JvWmZOd2t5L1h4UzlpM2NtNEVLV3YxVG5NVGJ2YTRr?= =?utf-8?B?MHM1cS9tZWpVN1d1R200ZFdqNTFhWnFpOFEwSkNsQ05UK3FwNFJObXhDcHgz?= =?utf-8?B?VXoxNVdudnVoWHJJSk43VGsrY1NRbHZtVC9lT3BqOVRLVUF6Z0lzZ2JxSWlH?= =?utf-8?B?dWZCSlduZlFVeWc1bzdZL2JpN0NQZHlzaDFyQVh2ZzNCWUo3NHdNTXk3SmR6?= =?utf-8?B?OVhhTHVxd2pPU3BBZDZ5dE0vZHFpZUU5S0lUWDFkQUlZNGc3THJ4bHQ0NC80?= =?utf-8?B?OFBKYnkxUFlCczh1dmErWmxxMnNndVNLdHg0ekNHSm0wNXhNbGZ2aGxaSHo0?= =?utf-8?B?cnkwN1FRTXE2cFhLQXVrQkVlWDZuMVFTQ2l6aHdacFA0QVFaRzlITHBoWFJ2?= =?utf-8?B?VENwSWMyNVNSOEk1YW9hUE10b2NFODJPN3R4VmdzeEdXZFNiOVdlb1p5d0VG?= =?utf-8?B?c1RJL1BmR0djZmRUZWkwTWRnNWdiR3NYdGRGa2hlVFdrWGlxZjlma2VuRkMv?= =?utf-8?B?SnNINk9zdGliTkdmQUFES2VmT1pFL1g1S0xyeHZRZUlpTTlQY2x5dkpnZ1pj?= =?utf-8?B?Qnl0TnJPb3hibVJrT1p0cEN3dUR5RDFudmZUcTZpdHNmVStCVXN6RGVFRFFt?= =?utf-8?B?ek5HeEU4bnlUU0N0OE42VTh0c0F6QitVR1FBQVdLUEhIWHRPa1hDaklRRkFy?= =?utf-8?B?cXpwRGFIWlExQ2pIYk9PdWFvazQ1d2drMS8vamUxbjhVQWRyMmVDeVdFZG5V?= =?utf-8?B?WHhLNUl0cXJxNkMyRUM2eHU3bDlWR0JFb0piVEQxeW9VTDNXQk5DRzdFZ0ZN?= =?utf-8?B?cmEyYnZ2VXEzUHBlY0xDaVo4Q0FMakJVYVNDcm5jOWxCVSsvTTlxOGtQMGtJ?= =?utf-8?B?U1JvUDFzeVFsenlyMkZ0cndwNkxzVDFCUitYeVNHQ1gyeTlxMkhVMGxleVph?= =?utf-8?B?eWcxSFloYnRoeksvd3BKY1lpaEZkMlFYaytoVTNTRUNnRXU3UDZpWDUzY3B2?= =?utf-8?B?U3QzYjdLSHIrY1lRTWM1bENDNDNrajFYT21TYzVzeExuQUtQZU5yVVhSOTh2?= =?utf-8?B?TlJSTWJjTzd6K0dVZ3NZMTd4cnFZM25QR1JqNlBYMXAvRnlGRnZOUGFGNjBt?= =?utf-8?B?Si8vMVZvaHRMRGgvd3pzRC9raGh3c3NoQUxLWWR4RG04U2ZKY1F4N1ZUOUg0?= =?utf-8?B?b3RLTnpRb2FtbjdsMTNiTWw2YituVTVRN3pGZm5YMGxnWnZZVFRvc0NMUzBY?= =?utf-8?B?dmhsTzhGVnFIUWhBakltY2lsbEJzNlRELzFDSDQwZ3k1UXRLY2h2VXZpZFFR?= =?utf-8?B?a2MwNXdJbDllaEhVM0o0YXU1N2NqZVNRcmZFY1BzNFVUWkZMMlltaGxYK1lS?= =?utf-8?B?c0dCV2VLY0ZJc09DVXkybGhhNkVaaXJkVjVtL09jYnFXdDBFOGNicnlhelB2?= =?utf-8?B?bW5CRDBBMGlkdmJjMVlRMUhiNDdKSUt6RXJOMVZ1M0RpQ3U4VTZlNE05WDcr?= =?utf-8?Q?4e6Ap0jTJmqhLemodOOEYN6aM?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a333ccc-4d63-4645-7e99-08dc6c3c875d X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2024 13:17:20.5544 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eS0Hqw20bfQUZBCxvAY/jHXjr5fiJodXMP/iYb+b2NEaYZD9Se67ioovz8+ccXYKulvQ7D65SmO1VsXjEHyfdQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8633 From: Peng Fan of_get_next_child() will increase refcount of the returned node, need use of_node_put() on it when done. Per current implementation, 'child' will be override by for_each_child_of_node(np, child), so use of_get_child_count to avoid refcount leakage. Fixes: 17723111e64f ("pinctrl: add pinctrl-mxs support") Signed-off-by: Peng Fan --- drivers/pinctrl/freescale/pinctrl-mxs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/freescale/pinctrl-mxs.c b/drivers/pinctrl/free= scale/pinctrl-mxs.c index aee70fa55bec..edb242d30609 100644 --- a/drivers/pinctrl/freescale/pinctrl-mxs.c +++ b/drivers/pinctrl/freescale/pinctrl-mxs.c @@ -413,8 +413,8 @@ static int mxs_pinctrl_probe_dt(struct platform_device = *pdev, int ret; u32 val; =20 - child =3D of_get_next_child(np, NULL); - if (!child) { + val =3D of_get_child_count(np); + if (val =3D=3D 0) { dev_err(&pdev->dev, "no group is defined\n"); return -ENOENT; } --=20 2.37.1 From nobody Thu Sep 19 19:38:14 2024 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2087.outbound.protection.outlook.com [40.107.22.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81A31364DC; Sat, 4 May 2024 13:17:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.87 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714828662; cv=fail; b=cEvUC+T/ODzuhakcap7p79BIr4DUR0vEOlwsGID3DQB+4NlE3bbMmgsCrkSWUYkWE3JThjhHIxUMNc7dXjOBCwqWTfev8TVljZ9QWwF0VD6BINBsx17zorRzmy1jDYHsT4klLp8virT/tpmNjENhvr45E7bQm9XIunmHUo8Q1jU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714828662; c=relaxed/simple; bh=FyFseGQJmsq1rScaeKVJgP424XsxB+ntR+56HIl8ufU=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=m+HwH+SHcuAvTGNpnWR8l7tXHCyDlg3IbXKryo5Y9Trou7YAY2YK5hnYPdu1DRBWvgM/c7gii6IQ5YZRRaiDuGiWSAtilwli/SfCj0u/iX99kiKmhUROKw4n5aLkrZDqy8LAt5WWAH0BdAnr3vLHVaslURGL7bDxm/q8gUsSSR8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=U0oBYf6u; arc=fail smtp.client-ip=40.107.22.87 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="U0oBYf6u" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kYxiRSbXrlxM0QIZzB2JKkGv1WJuFfsZ5UeNw2hEhj3s2RugeUNPmnruOs3KpMnTUl3wLULJaA9kWr825f0PL1V65U6T2VhJMZNg6Ph0uzezGyCOafoYdFqTRIhQlDiDpUXoQEGJUL4lErnu2rfYTpG+nhVzmvG1aHI3lvEULEOfMiIOVDnLQjkHBRf4LY4rE3vqHoQFP7dQQDVpZQTDZrvPf10iDSA3cniKUGIVHYDdDXKVOSWAzyNS5hYV++eY0ZwfDgQBdvuSrkqtFMqjYwLvMmiRkprFbK3D5aNugridWj1DX/Q806+Vl5faqD4ovOn++GuoFSqEgaPcixcWHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rPCG6xZzK0LC/23B+oYJdueIO/buCemfRXEoPX5rvQQ=; b=JTpmd+rqr42czEZb91zi5Jo2aSufwuMAvEL7P+ECrNA9kvs+uFlC3Gxy9vxOQyI3sGAPsnd63WdGDUTMPc4tAHZ6sT8MYx7Ggkuz4D18WQyO8t7vyFCMf50L4Gx3wDbm0FtBo5oANfUu3Q97gmLteAKjDQWVnh/gFvZSdvrJ//7knKIc4IK0NdDx+GLzeaHTKfsi9GFQtchFeWOvT+WnsJUjZnsQvWsNL3D/1xHK4kulYh6lfwpVp1N3hvhBTHaEfm4S25JQ2RqmZ1fZUE/cOAlDy3WY35zRWC+CalNrv7abUyspyaH+5c5EVea/DgLqQbj1FeXDUD+oXMCgoIMPPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rPCG6xZzK0LC/23B+oYJdueIO/buCemfRXEoPX5rvQQ=; b=U0oBYf6uD96SvqELHvZ1Dm4fRhXclJNCzV5vD9LAKg2FJer/qQAgCy33yfbFfxL6OCfoJmrvNotAl9NB5G7lmt08HgP2vvNUlIgL7KkHi/vOcbuwTCWrK0PGMFYkZMqgRM6FVRLBRnpVS9FZeYPfntla8UGRo1RGes+KL9BWCOc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by AM9PR04MB8633.eurprd04.prod.outlook.com (2603:10a6:20b:43c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.34; Sat, 4 May 2024 13:17:37 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7544.036; Sat, 4 May 2024 13:17:37 +0000 From: "Peng Fan (OSS)" Date: Sat, 04 May 2024 21:20:17 +0800 Subject: [PATCH v2 19/20] pinctrl: k210: Use scope based of_node_put() cleanups Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240504-pinctrl-cleanup-v2-19-26c5f2dc1181@nxp.com> References: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> In-Reply-To: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> To: Linus Walleij , Thierry Reding , Jonathan Hunter , Dvorkin Dmitry , Wells Lu , Maxime Coquelin , Alexandre Torgue , Emil Renner Berthing , Jianlong Huang , Hal Feng , Orson Zhai , Baolin Wang , Chunyan Zhang , Viresh Kumar , Shiraz Hashim , soc@kernel.org, Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , Geert Uytterhoeven , Patrice Chotard , Heiko Stuebner , Damien Le Moal , Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , Chester Lin , Matthias Brugger , Ghennadi Procopciuc , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Sascha Hauer , Andrew Jeffery , Joel Stanley , Dan Carpenter , Tony Lindgren , Stephen Warren Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-mediatek@lists.infradead.org, imx@lists.linux.dev, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, Peng Fan X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1714828815; l=1076; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=58KovdEVBZIsn2lfhZ/T0dqiN9oElq31ckJF6Ac0RQ8=; b=Z+wSwh1JPoQAPchmd5Ic4kf6A6+OCSxNrWN3N1KhVLu4RjS5VBGAWLrX0O4aqR9c7Yhj1583S ps7l8SBklTdDPmAjAcjmF7u6Z9ImB7S+gJdZ3GjS/jXZ/LXZiyUzK46 X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR06CA0230.apcprd06.prod.outlook.com (2603:1096:4:ac::14) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|AM9PR04MB8633:EE_ X-MS-Office365-Filtering-Correlation-Id: 656e3a5c-55ec-45f0-bfc5-08dc6c3c916b X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|52116005|7416005|376005|1800799015|366007|38350700005|921011; X-Microsoft-Antispam-Message-Info: =?utf-8?B?L1ZyQ3ZNZUpYdUZRUlh3S0xYTXRwNWtteTl1ZnpYa25RUEJ0dHZRNlRNbzVO?= =?utf-8?B?bHg1VUQxaCtZMHR6K2szakJjQStFV2RwQnA2eHlER1U2d0ZMZjc4Sy9jUXlO?= =?utf-8?B?d1RYSm5pRHFUNkY0MnNPbFBKK2RkcDl1YXdrYXJOR2gyY0FQcWQrdWY1Znp6?= =?utf-8?B?dXBQRVdBMXdVbW9Ebit5SnZJSDZnM2ZQWDBOdTdMTXE0WittVHRwMDduUElM?= =?utf-8?B?VUdNclhYc1VOZEIzelViOS93SUJURXVUcWxOZ0hyRXBlQjc0VUs2cEJmT29j?= =?utf-8?B?YzF0c09XWTQ0OFBnTWozd1dMQ3VZeEcrUExsODhkWGpZQkhXRDQ4QjlXNWVp?= =?utf-8?B?aC9RempqM1RiYjArdG5FL3NONkpmVVdDWDlSeW95Z2h0dUt4cm00MktET3Jo?= =?utf-8?B?ZVE0Z0lZeUk1MnlkakMyS1YwY2t4L3h2d0RIdzBPcG5CNWJPTHNFZitBSEpa?= =?utf-8?B?U1ZabW5ISDlVeHZoY082N0ZZNytCL2gzbWlVUmpmRlNpeTJpbW5DdDZKcjFU?= =?utf-8?B?Zmp3V1lxWVVQRWxpZE5JVXo3QmI2QUJjOWE2Z01rN05PN3VIVVMzeHY1Q0lh?= =?utf-8?B?UHJvNHZqejY5TnQrYXlyMDZ5b1ZwSXhna2xmZ3VsaVc2SnA4eXhrelRZQ0FN?= =?utf-8?B?OUxMZUM3VDV5bGE1NmxSKzRPNzRMNUVyUVRmVGhDWXRPT0s1MGw0M2dwRjZU?= =?utf-8?B?bnpZT0tOUXo1VHVGY1ZmeU5zQnFxMmdVcHkvZVc0QmpTclNFTHBkYTRMcG95?= =?utf-8?B?T2xHTGtILzMwQUowN0RqMC94b1hja0Q4RlJVQTRkOFlMOVQzcFFpVmF4T1ZQ?= =?utf-8?B?Q2RUWkhwNEJ6U3pKNkxXSWxGQ1BOZ04wYk05UG42NzJDWm5sbEY1RGVXTEtt?= =?utf-8?B?L1l4TEU1WExFRkJkZUx3UWtmQ1haSnNqZ3Uwb0dHcTNWa3krYjdVZ1JmcUV1?= =?utf-8?B?WVhvOHVzQzZOM3Nmb1ZvcUk5d3dDWmVxT01LbFpVbzBHUVdHSk9KV0NmcHNv?= =?utf-8?B?c3p6YTZBeVNIQWlIeDJMWlhFTXE3cGczTzVQQ3EwbnI0WEFtOWlyUGVqaS92?= =?utf-8?B?aWVSZTlWbHZYRGFhTHdHaFRUMjNPcGkrUy82d0dFN0FkUHk2YWZuUVVJcjV5?= =?utf-8?B?bm1PRGdXSjlhT3NaenpjY1Fna3ROSWM2Z1YwK3NHTlIyc1dVdExnVm8rNUQ1?= =?utf-8?B?Y2x0USt1TVhDVXdKN1NWSmE1VGJSOEpMRGorQ0g2TWhkL2JON1NPRzdsYTM2?= =?utf-8?B?YW5oSHl2RFFuemExUDNScEdXaGpjcWVmYVhraS9mSlc3UmREaHNVZWRUeEZj?= =?utf-8?B?bU0xdVptQkZzb3ZwVEtQSEU1MVFtbkJNQTdXOC9hRk04cWhVVnlxQTYwWFdL?= =?utf-8?B?dWd0K0xuQUlrWDFtM3FYNTJteTA1Wm1OYlQ2eGJTV1Z2bVZmWVJERmsrWUJ4?= =?utf-8?B?U1pJbCtrOGR2WCtPUFhIcDJ5eFBpUXV4N2hWY282aDdrOXVJSmM1ajYxaE9s?= =?utf-8?B?TzNpYnNMTms0U0FIUnhaalpXUW5PK0h1ZHNkSE13WEo4RlhjUk5EYWVKNTQ4?= =?utf-8?B?ZWE1bVZXd3Y2ZWVIVHBqQyt5UzBUZXE5Syt5SGgxTTZWVWNnT2RrTER5WHhT?= =?utf-8?B?QXI1UnZUd0VVaFM4YnJQYXRsbnJXdDRGUEJ2SFpzcHpSK0xLMng3TnBJb0do?= =?utf-8?B?UmVxeGRUSG9zaXpuaUlidmxZNE56L0JaOHV5aDVGbXIyNGZIblNnS3RwUEcv?= =?utf-8?B?UDlWaGxMNHVJRUZBelBEWGhlcGhVYVlOQm1mM24rS3o0RU1FYWpFWkZ3Yitv?= =?utf-8?Q?LPbON/1NL46Q3gcH6TAb6FqxKvSYUCBnoNRSY=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(52116005)(7416005)(376005)(1800799015)(366007)(38350700005)(921011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OXJ2Mloxdll4ckJjYjBuS1l1Y29TTGFtVGVyWmJnWHpXMEV4M3A3MmNKNnVV?= =?utf-8?B?MFJvd05rdlliaERxeCtZcG9YS01sWWdBcUg2U29vQ1hEOWs0cTlUU215UTFF?= =?utf-8?B?ZXQrVm9xM1FmSW1xdmROSllTdEJzRHk0VVB3cGVjL2lkMk9ield3Z0dpS1Jj?= =?utf-8?B?QjdCaE9uMCtJS0Zsc3ZIejVCdEhJa3RGWExuSVl5WTQwTi9mNlptdCtVbkND?= =?utf-8?B?TGxhVTg5eTJHNmlleFZlK2lFNE54Y1ovalhOVlQ1V2YvV3dDR1M4K0R2Lzc3?= =?utf-8?B?MGtuVVNFVmw2MTVQUzFKclZScEFCWVpLQUxJbm9Ka2FETE8zRlhjV1Voaita?= =?utf-8?B?YnJYSEVwOTB6VXVMbjVCcVVJV05tYkEyT3lXdTZkSXVuZkwwNmNQTmcyb0xE?= =?utf-8?B?MWRFVUJMeityZzdLQkdhSzlxeDBjSHo1eUdWVDFrc0E0MkV0Y2xQRjF4MUE0?= =?utf-8?B?emxIOW1Lakxza1lGeEJ1cTNaQjVmL010clg1dlFMYUNPL3VFbmNLTG9YcDFh?= =?utf-8?B?cEw1dW82V0lkYk43Rkh6Q0xydU50NkFYR3JxTEVZNFRHQ04rWUlkdEJMaVJ3?= =?utf-8?B?MmQwSWE2ek5JY21Ja2E1bUlNaGYyczBBU25sN0JuTDY4MEhCc3haKy9iQTdC?= =?utf-8?B?WkRDNEZhb0lTeDVSVmo4QWdrSlZhN0dtZ1BGdkxJQUhWbk9kT2JaZlkvMFFt?= =?utf-8?B?L1NOdFMvQ25HZVk0a2J3SmloV1d3RnhTZENweFdvM2ZUNzlUN2Q3amxvQU84?= =?utf-8?B?SzVIU0VoRlUwNi9lK2tZWVY4aFJHZlNIOTJGcjdtdjlYcVZDdEpnR0RXTzhV?= =?utf-8?B?VlBHVWc4NG8zN1NjSnpUMFRQMHV2MDRRRGZNY09wbmJHVkMrQ1Y3QUZRdW1i?= =?utf-8?B?UEQ2UlMrekN0cEI3T3phSjdiREZnUG1hdVhCSk82RGJVRFQ0OHdzRGk0T0pZ?= =?utf-8?B?cmV0R2xIM3F5OS9YNld1b3NXemRPZVZzS1BVR3lGK0tBWFhwV2RFd2w3YThk?= =?utf-8?B?SWhJMmRIN2NUT3A4QlN0V25XL25ONXNwZENTNHJ2SXBZYVFEdnp4anA0ODZn?= =?utf-8?B?bklnbGlsZDZyWEIwTVd4T1VWenc1Z1Bhd1ZiQWRhRm1zdVIxei91ellCNE1z?= =?utf-8?B?VUQrR2svN241VjlEcmExKzlkY0NhVGxMR0RFNVV4YmltZHA1T1dRbzJRMkl0?= =?utf-8?B?dHUrbmVPM1ZLeHpQUXNsa0hoN3lNR05XQWt0NithNG1pcHpnZ3dxRHRsdGFI?= =?utf-8?B?NWpxRUFZNjJVVFV5ajJSUU8yMzFUd1ZjWXFYT0pQREVVejlYeEtidnZhbmZi?= =?utf-8?B?cGJzMHFZL1ZPaWRhOU5qY0IrYXdNcUExNzRRcU9NeGdlSW1pNnpUbzVHaVMz?= =?utf-8?B?QnVRMXRJakJTM0hyZWRmeFIzR0ExNmhXc3cvaC9BZ0Uyb0swU1RnelBXR09h?= =?utf-8?B?cUphYmcvaS93elRIdEVlOUdxUDhGWnFsK3JKeE9SdjVESVQvaHNHVUhudlAv?= =?utf-8?B?TXBBZ0xjUUVuUUhuOExBTnRpUmVGbTFhOEFBTTc2UTY2QmRyTnBuWVlnN2hE?= =?utf-8?B?bVhCR0VRdTZTMmZORStiSzZKSFJ6Rkp6NVYxWkg0U3BnN0tha25JOTNSRkVZ?= =?utf-8?B?ZFVuaThBZXhTVmUwUWpJMUhZUms3UzYyU2MyU3F6YktPakJ0eVVlRTBuaGti?= =?utf-8?B?dGJJT3h2Rk5LU29HT1NHMStzUld3SjNhUjgrUmduSjBJTXBaZitpTzFCcE82?= =?utf-8?B?aVNpM2MwR1RIYTZtaWhsUHdDTGJ3L1ppNjhGTjhTZE4wS1lYVTdYOW5xR1dH?= =?utf-8?B?NDJ5TVlmeEZJMXg0RzdiT1lQR0UvMUdFU1FSb2NJWU4vTVhyNjRNbzA3UGJt?= =?utf-8?B?bUw0WWl4Vkdsam9BK3J0QzJFejVOMGNVRE0wVUJyaW5peXlOSXFOak9sbTY2?= =?utf-8?B?NEJyVEhSVkxYSHdKQ0lRRVg1Rk55R2RBR0hHcHk2cGVla3JDbVRMWVkrbjc4?= =?utf-8?B?bkVPempGa0ZjQjdYMjB6TnZKbFZRby8xYlNjY3dDWTdxVjR2N0tsNnpHTFds?= =?utf-8?B?Y3RjNUk1ZEZQb0xxVGdCOVpJb0h0V3Z6ZGlCNTJIc1FvRVdybnFTeFI1cmQ5?= =?utf-8?Q?goR+YVBGb8ozJVYfDY99w9qAi?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 656e3a5c-55ec-45f0-bfc5-08dc6c3c916b X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2024 13:17:37.4396 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: g6nupdqB+zySfjS5aEdMaK45BkDcQFF3xV64E9YCjbGQMY976BhNaluoO2HLwNgSGP71nunEjSbX24YIjKnQog== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8633 From: Peng Fan Use scope based of_node_put() cleanup to simplify code. Signed-off-by: Peng Fan --- drivers/pinctrl/pinctrl-k210.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/pinctrl/pinctrl-k210.c b/drivers/pinctrl/pinctrl-k210.c index b6d1ed9ec9a3..2753e14c3e38 100644 --- a/drivers/pinctrl/pinctrl-k210.c +++ b/drivers/pinctrl/pinctrl-k210.c @@ -849,7 +849,6 @@ static int k210_pinctrl_dt_node_to_map(struct pinctrl_d= ev *pctldev, unsigned int *num_maps) { unsigned int reserved_maps; - struct device_node *np; int ret; =20 reserved_maps =3D 0; @@ -861,13 +860,11 @@ static int k210_pinctrl_dt_node_to_map(struct pinctrl= _dev *pctldev, if (ret < 0) goto err; =20 - for_each_available_child_of_node(np_config, np) { + for_each_available_child_of_node_scoped(np_config, np) { ret =3D k210_pinctrl_dt_subnode_to_map(pctldev, np, map, &reserved_maps, num_maps); - if (ret < 0) { - of_node_put(np); + if (ret < 0) goto err; - } } return 0; =20 --=20 2.37.1 From nobody Thu Sep 19 19:38:14 2024 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2066.outbound.protection.outlook.com [40.107.22.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F92438394; Sat, 4 May 2024 13:17:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.66 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714828679; cv=fail; b=p/vNYG+6u7IHsuuZYZGMx/RlfWfc1eNHhGZEuSZKbHWFo4PEiw/Q8Liz0xh+SFOieEGeyLjd4MBANNx4Ow386ChMXtJpF+iUd5i6BXl2fPUn8yw2QrfLM4ye+sU4WcCEOXd4RfUuRDQQ2lRCbOV65cX84lae1uxayBDfUlyc5c4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714828679; c=relaxed/simple; bh=wMNSJkH/G6gb8vDhU37wTmbLXobqUGpvvFnYEW9f+eM=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=TBTkh4ZMsufjGcWdgJWdjZL3icZnZmp7299YZ+XWNNjkThsDY4OnqiTK8WJE8IKTJKpWMs6rKsqFZiFrCNWYtObdMgeAvTDYnOu9EIrhw4uKN+X1RYfju6rDVS4VZvuTNshp/4HeeteUF8y0fs2Wx1J0Gf07t5IKgjNtFkmYZOo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=BiuzAJRq; arc=fail smtp.client-ip=40.107.22.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="BiuzAJRq" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MeqS3lzaTiTvvMpQkhxAqx5LXu9Qz5Eun3vOl5nnj8mwXBiR+kPagCszrMCqC/HX7ErnmtqmkeHTlsQl7mCDF5OUcE2weGzTeSDHfeYnp627g+vC66DWr5E2/g0ozE3Oxe3HpjuwAK8453pa3XLNlyrFkMhz1aWOVQXdfoJJSarYTNDNhZXlFk1zo7DHTyvhVq7GQc0xx6AOWV8BG2Z343zDEYH9BJMW4vx6fWZakzmjimLoG0RmF6npsV0ooZRo3KVzUHfYatmil55/XwTirR6IhZ6eddWT/jwf3pcth51hCFg9Nw4lxdARDPsLR4HOLxLpr9s9edGjfYIKroB11A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ppg9aWlK4+huIGMqna4KeQPNUar5cHCrgX7Io5VTsjo=; b=eSqoOAsUP7zY+Kz27f04NZE8iZsc0ibTh/UKOCUYR1zdYHH2E8lajoRSyA8sDy3HvYin2IPk9R9VINGcz+xnoU97GgyO8xrHjmxu2PIo0KvE6tC7T/CwSOswA7haahV0t3JTAFusYl7ZfoYYlEyg3x/jM8xnEE8NlM9isHl5oWn1cm/Ts8fvWezutcVuUjLsPXSXVuNq8PsDytUlaICnsw+GZuSTWAzjFVSBxhATNrlGrb6xEVrIa8kevPTzME95TFC+O5OgK9hFHWIPZQ0VjhfolUDqh/LI067mWsjVDswRfZ9stebFk4P+850KwVhkLF2pWkabx1CYbNVTUU8lSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ppg9aWlK4+huIGMqna4KeQPNUar5cHCrgX7Io5VTsjo=; b=BiuzAJRqpHcg55cTD7Unx+2M7N8+VFhoSv+0CWmFBcYl7Z/WnOM/7NK2dREH09pZnPG9i0D+o39Dt0+CWJE4qgWqLizCKQMOXCFo2BGb5flRUGdzlr/E+bM7i1JWwUDG2zPwHzjuq5+8P3TF0T71rpYbqr3BGQgJwdLA/S60Cm8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by AM9PR04MB8633.eurprd04.prod.outlook.com (2603:10a6:20b:43c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.34; Sat, 4 May 2024 13:17:54 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7544.036; Sat, 4 May 2024 13:17:54 +0000 From: "Peng Fan (OSS)" Date: Sat, 04 May 2024 21:20:18 +0800 Subject: [PATCH v2 20/20] pinctrl: samsung: Use scope based of_node_put() cleanups Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240504-pinctrl-cleanup-v2-20-26c5f2dc1181@nxp.com> References: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> In-Reply-To: <20240504-pinctrl-cleanup-v2-0-26c5f2dc1181@nxp.com> To: Linus Walleij , Thierry Reding , Jonathan Hunter , Dvorkin Dmitry , Wells Lu , Maxime Coquelin , Alexandre Torgue , Emil Renner Berthing , Jianlong Huang , Hal Feng , Orson Zhai , Baolin Wang , Chunyan Zhang , Viresh Kumar , Shiraz Hashim , soc@kernel.org, Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , Geert Uytterhoeven , Patrice Chotard , Heiko Stuebner , Damien Le Moal , Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , Chester Lin , Matthias Brugger , Ghennadi Procopciuc , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Sascha Hauer , Andrew Jeffery , Joel Stanley , Dan Carpenter , Tony Lindgren , Stephen Warren Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-mediatek@lists.infradead.org, imx@lists.linux.dev, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, Peng Fan X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1714828815; l=4267; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=Eha3FnaEY3bzUrakRMW1Ov8R+kXDm5JzTBhq10KxbQk=; b=j1GGjC8jOMD9Vols6kLJMsB1llGpiQjkJR5IlNAnfWDcAKwLbiKZUAALPTehYonJf7lE4q/wH yzEqddp4EMID2GMdMRfAxpHQh4H/pYIY+KCEK/dlCVBsLbU5lsfKaOD X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR06CA0230.apcprd06.prod.outlook.com (2603:1096:4:ac::14) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|AM9PR04MB8633:EE_ X-MS-Office365-Filtering-Correlation-Id: 88a760b2-963a-44f4-0ccf-08dc6c3c9b5e X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|52116005|7416005|376005|1800799015|366007|38350700005|921011; X-Microsoft-Antispam-Message-Info: =?utf-8?B?QXR3dkpDNi96VXJwU3NaNnpLcDNSY3dCYkZrUXRvNUw2QUU2bjdmTEhYaFds?= =?utf-8?B?VFZ2QlhscVF1NmV5OTJranhqRE0yeDZ6YVdkcmZMcjhXS2theWVUc09nVm9x?= =?utf-8?B?aDJiclNJbHVxRkFFMmJ6YkVKdmthZWlxYW1KZjBCS0c3dVZJbHFBMWlLdk1q?= =?utf-8?B?aUxuNXVsVTZLc1F2d3FiYjlIZVRReklhWVJ0UnIyTVQ2NDN2KzQwTEUyUWZr?= =?utf-8?B?VGF1Y0kvVjZ0ZnpHOW9JVk1JSFdnL09zUHpya2tPYmlqVDdwR0p0VUx0M0Ez?= =?utf-8?B?YW5HbkQvdFRlU1pXWjR0ZEtVYzYvRnN2YTdJQnA2MmZYekJlVXpNQzVwQ0Jo?= =?utf-8?B?MWJKZXl1T1ZTdkk4UmdpS24rY0MydkVkSTFZc05IOW9YcmpwK3NvYUxhOGdZ?= =?utf-8?B?VmFLRGRISTN3MXdPWG0wTDB3WlhLbjJhODdKOEF4OHQ0anlSV0V4d0dnTmlP?= =?utf-8?B?cDEzZzZpWVRFQUlBbi9wZko3T0MvdlNtMUlLWGlIcFJ6cEllVTVkSjRJNC9n?= =?utf-8?B?N3lnVTE5ZTZmT2x5S21IVUhaT3F5cUZVSmlIVmtEbi92aUoxbENlNC91dTJy?= =?utf-8?B?MGNDbDhCRkUzbCt2ckwwbHRhd2FBbk95dnJ1WG1vQ1lXNWJ2MDRNaGV3Mnds?= =?utf-8?B?QVhraHFzTHZZeXZiOXFYN0VjTUFlQjNvVnNGUG9VL2VNOVorMDJtZjhIdm5j?= =?utf-8?B?THBqaU5QSlBjcUozdXNTL3NsdU1LVFFFeVZId3FqMGl6dUZaSnBjSEs1eklr?= =?utf-8?B?bEVwUEczSUpodEJVcjVsVExTZWZqM1NJcWdxYXlZYzR3TTRlS2FzejdCQkNX?= =?utf-8?B?cHc1cXVQZjNNS21PTmE4dm1WNzN5WWh6UTd2RE1DN3hybXpsU0NPU2NrN0ZG?= =?utf-8?B?dk9NbUVDTXhJNEhuWWZpSkZ4S05GT0FhK2R2ak5PamVla1dyS3FGWXpYSm5N?= =?utf-8?B?TTd4L2dUZDRMYWlWbmF5RmlFbW5zUFA0ZFNpTW9XbVpUN3lSWHIxcEtTUjA1?= =?utf-8?B?eW52Q25HZmVUMlZRUFRyYUdJc0IxN0xDZng0VENHQXdsSWJieG1YeXNzTHZE?= =?utf-8?B?Z0lyNTFmZXAvdWlQdTlqbHlIU3pLc0hUUW93WVVzRjVPb0UxeStOeWdDR0xi?= =?utf-8?B?d1pBZGZFL0lxakZmeHZjVWhiUmU4M3JPNTd1cWtjU1FsU0pncFVQc1h1aGlQ?= =?utf-8?B?NFlwUEFnWVJsVGwwNkVzNTRPV0lDUzhNOXJXaENaV25YRXRwdFNkTE5UeFVm?= =?utf-8?B?QzRWd3J6UHptaitxR0c3cnVGRjliVE43Y0tRV3FKTFZmTWtUNWgxalNka1E2?= =?utf-8?B?bzJGeDNuU09RekpNeFVzV09zTSsydlpFa0ttNU9UU2FwYkxYUTV6UFNuVVVk?= =?utf-8?B?WXBBVE9yMVhFTVZCS2hQRW5YOEswZnJ5QlVxb1RCSkpCd2ZLR1M3Z0hDMUsz?= =?utf-8?B?Wmtaa0tvTGVHeGVoM0I3dW5ZdUsxcWNKL0l1Z3dEZWVDUktSaml5Nk8zT09z?= =?utf-8?B?RDQ5SmpJRDF4WmVRSzdzd21ERnh5R0RzUmdzWktGeFBQMWF1eDdhVGdEYzEr?= =?utf-8?B?U1NQN2F0c2dVR1RLMi9wcUdMcE02b1JlaUppaWdWOERUQzZxdzF0V3psVUZo?= =?utf-8?B?ZUw4QVhxOHJ6SW5NRWM0OXhTQTBiSzExZHcvVlVxdGlzQ2x4L3lzdVpzSita?= =?utf-8?B?YXRtTkNTRmp3Z0tnWmwzMWN3aDdxd1drVXlRK255SXZUdHozSkdzZGE3VUFW?= =?utf-8?B?M3Rabm5ISHpoOFBMOVNEaEpIL2dnR1pQczVHQyt3L0YzRzlEbWk5M0k4S2pl?= =?utf-8?Q?o5nj42PJt+NXtAKdRgjYHq9jkqvSUlEv3EhhQ=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(52116005)(7416005)(376005)(1800799015)(366007)(38350700005)(921011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bDdkVkM1bWpaUFpJMFRRcnJBY2xKQjJTRGRGZktacDFyNFVsZnBiR3E3dk9j?= =?utf-8?B?NkdoTWFINVBZaDNTSmpBUjI5RThEb1VpWXdXblRGVXR6cmYrNmRDSHFTQkZy?= =?utf-8?B?dWRza3pOaEF2UHRsRGcvR0x2SlQxNUJVSWFhVW5RWlFnZVhKQUpLOGtjcFd0?= =?utf-8?B?ak1xS1N6c3lmeWhDaHJ3c3hiaDBjNjJ0MVU2dkRyazNmWFg5RFJibXlXZGFE?= =?utf-8?B?SG15WnpVQXkyUjEzYVdVYjRMZEJ1b05hWkJMMnpxZXhXMzE1UzRDb01mZTZX?= =?utf-8?B?bXpBQ3R0UWV3b2ZLVSs1dU1uWGJOSWdpUmxHR1IralpCZlZ1NGhSaXlSenJr?= =?utf-8?B?ZXFtckREeVBGWHhaVkdXQlNlb0E4aWhva0RocldOQzhPV0ZnUjJFeG1OUm9i?= =?utf-8?B?U3dTTTJldlo2anEwd2JXNlNRNjh5VElOZEtYTmVNd1NhckhyM0NHQ2Q5eUc3?= =?utf-8?B?VmYzRXhESWdqR0tzaVdkMEdmd0RJaGpuVGhZcEhHMkoxN0VGNDQ3bVYvWk1q?= =?utf-8?B?Zy8xNUt6YWZ0R3pMUFpyT2d6RGQ4eHFXQ0hZVytaejJ1Mjl4dFlHRFdPaE9G?= =?utf-8?B?THdHMExGOXBaTFpVYTlseTAvU2lsOHVCRHdXN04zbmpBUFZkMWF3YnF4VWM2?= =?utf-8?B?ZmY2RXhoYkxqeWYzZ0pseHpKTm1UdGZJVm90UTZtOEhwWDZUTm1mM01yK1pG?= =?utf-8?B?YzlxLzYwcDVUU3JRQ0o0ZFd5MjQ1U1MvVnBhbjF5YitTemY5bktYYjdJUTNQ?= =?utf-8?B?SGFXTjF6dVR0MkxudkxvbXAvY0pzbzRCWENxK1BjQWRSOTh2LzFEUDE3V1l2?= =?utf-8?B?T1Fpbk5OYzcyZjZzODE0b0RhU3czV2VqL1NSeklXbytDK3d3bmJqeFdLa2ZQ?= =?utf-8?B?elRuZjBHdXRXdUNZUzFLOFJFRkZqZnF5WlJLUEk1R3RtY0E3ZUVKZE5JYnBt?= =?utf-8?B?SEtxd2w0MXZQNG1jdWVCN3FPQUp2cjFOWmpDMEdEWU96azNnMWxYU0lqWSt2?= =?utf-8?B?UEhrTXA3OElTM3EzMkx5MEk0N0pvWVRHU1BKMXVBT0RVN25JVmpLR0tnbjRM?= =?utf-8?B?SnlXcmVXOEdiWUN1ZTUvUTkyR0hRWmJ0TEUvdWZYWXBMdGlaOEN1amNtaExL?= =?utf-8?B?dWwvSFJwTjhlVDgzZnc4T3BrRnMySjJpWUp3aUV3bDBoVENRN0M4VlZEZE0r?= =?utf-8?B?ZmdTbWZhRWJRTFI1TVBDdERuclZENmpaS3poSlExc0FreFUzR0h6cElIekZN?= =?utf-8?B?d3h4WmhHY28rakxBNVRDdkVPWDlkMDZVMWNSZGZpMUxSbktGLzYrdVhOQ2xH?= =?utf-8?B?TzNDZkpJTHR2LzNjei9KMXBxTHJyVnpIWksxT21FTk9zc25PbkJycTVWbTM2?= =?utf-8?B?aUh6Q2xLQ21JU2VZOXVGTjZEUUt3dWhnTTQ1OExkNEF5cTN3c2FYQnZjbDhT?= =?utf-8?B?aFE0bVFsZzBUTHhRWTl6YnRGV1hYUjVsbFEyN2dkUjRXMUF1VzE5OUhCMkNi?= =?utf-8?B?SGJXOXhERmVKNzZCdXA0Ykw1L1Y4YUl1bVBVM2lIKzdQZ3M1ZkpBbzVVOTk2?= =?utf-8?B?VzkxbTlNMWJ2MTVlcFJ2NDQ3UkQ5OVZGczRMZmYyZTVFN1NRUkhmb0xmUVdL?= =?utf-8?B?d2Q4T1FkOFpmbUNhakhuVC9KaFRETXlUWUdneTJIbWhhenRGTnJMNVJMbzlT?= =?utf-8?B?Z1dUZTdSN05HdldOckM0Ujgya2NsYlNuK28wb1VnaGNPZ0sxTXRiQWhocWZR?= =?utf-8?B?NjZYQ1lOWS9GQWxRU2hJRmhEMG1aWUVzVmJVakdaSlBybnVLUzZ1L3VoeTRx?= =?utf-8?B?cnI1VHZLaHJSc0tSS2FMTWt3cExUdjZ2elhIRy9vT2xJd1UzZlBaTlJ1enZn?= =?utf-8?B?V2RodWtmOC9CM3VDZFRvTG9IUG9JM0Z5V203SlQrdGFyR2xqcDhITTlQVjlx?= =?utf-8?B?aHR2RkVFKzFiK013K1FRREpvSUw3SWlkd3FQOFhGSnlRUStSeW9aczlYeC93?= =?utf-8?B?bm9ndFlpZlBCMWdiTVBWUitBMFhiRng4dzN5YzN2VDZkU3pnVlM2MDVveHZL?= =?utf-8?B?K0k5N0Z3RmpvdmYraFcyRnpkeUZUcUZaZWtPT3FKTDhLeUlzY2RjM0NuTFpT?= =?utf-8?Q?j0sc2s3iOIgmVIm42Bh4c/Evd?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 88a760b2-963a-44f4-0ccf-08dc6c3c9b5e X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2024 13:17:54.1216 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Myzq3/6MY/HfklO204D+tBTrg7YaOAS/vgCDdDbFCJdHIDCD0ERvNPhbgg//sC5GpTgalc5VpfcOuOy0J9z9lw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8633 From: Peng Fan Use scope based of_node_put() cleanup to simplify code. Signed-off-by: Peng Fan --- drivers/pinctrl/samsung/pinctrl-exynos.c | 16 ++++------------ drivers/pinctrl/samsung/pinctrl-samsung.c | 19 +++++-------------- 2 files changed, 9 insertions(+), 26 deletions(-) diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c b/drivers/pinctrl/sam= sung/pinctrl-exynos.c index 871c1eb46ddf..3775999536e2 100644 --- a/drivers/pinctrl/samsung/pinctrl-exynos.c +++ b/drivers/pinctrl/samsung/pinctrl-exynos.c @@ -582,7 +582,7 @@ static void exynos_irq_demux_eint16_31(struct irq_desc = *desc) __init int exynos_eint_wkup_init(struct samsung_pinctrl_drv_data *d) { struct device *dev =3D d->dev; - struct device_node *wkup_np =3D NULL; + struct device_node *wkup_np __free(device_node) =3D NULL; struct device_node *np; struct samsung_pin_bank *bank; struct exynos_weint_data *weint_data; @@ -612,17 +612,14 @@ __init int exynos_eint_wkup_init(struct samsung_pinct= rl_drv_data *d) =20 bank->irq_chip =3D devm_kmemdup(dev, irq_chip, sizeof(*irq_chip), GFP_KERNEL); - if (!bank->irq_chip) { - of_node_put(wkup_np); + if (!bank->irq_chip) return -ENOMEM; - } bank->irq_chip->chip.name =3D bank->name; =20 bank->irq_domain =3D irq_domain_create_linear(bank->fwnode, bank->nr_pins, &exynos_eint_irqd_ops, bank); if (!bank->irq_domain) { dev_err(dev, "wkup irq domain add failed\n"); - of_node_put(wkup_np); return -ENXIO; } =20 @@ -635,10 +632,8 @@ __init int exynos_eint_wkup_init(struct samsung_pinctr= l_drv_data *d) weint_data =3D devm_kcalloc(dev, bank->nr_pins, sizeof(*weint_data), GFP_KERNEL); - if (!weint_data) { - of_node_put(wkup_np); + if (!weint_data) return -ENOMEM; - } =20 for (idx =3D 0; idx < bank->nr_pins; ++idx) { irq =3D irq_of_parse_and_map(to_of_node(bank->fwnode), idx); @@ -655,13 +650,10 @@ __init int exynos_eint_wkup_init(struct samsung_pinct= rl_drv_data *d) } } =20 - if (!muxed_banks) { - of_node_put(wkup_np); + if (!muxed_banks) return 0; - } =20 irq =3D irq_of_parse_and_map(wkup_np, 0); - of_node_put(wkup_np); if (!irq) { dev_err(dev, "irq number for muxed EINTs not found\n"); return 0; diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/sa= msung/pinctrl-samsung.c index ed07e23e0912..0d4d7ebf7145 100644 --- a/drivers/pinctrl/samsung/pinctrl-samsung.c +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c @@ -250,7 +250,6 @@ static int samsung_dt_node_to_map(struct pinctrl_dev *p= ctldev, { struct samsung_pinctrl_drv_data *drvdata; unsigned reserved_maps; - struct device_node *np; int ret; =20 drvdata =3D pinctrl_dev_get_drvdata(pctldev); @@ -265,12 +264,11 @@ static int samsung_dt_node_to_map(struct pinctrl_dev = *pctldev, &reserved_maps, num_maps); =20 - for_each_child_of_node(np_config, np) { + for_each_child_of_node_scoped(np_config, np) { ret =3D samsung_dt_subnode_to_map(drvdata, pctldev->dev, np, map, &reserved_maps, num_maps); if (ret < 0) { samsung_dt_free_map(pctldev, *map, *num_maps); - of_node_put(np); return ret; } } @@ -791,16 +789,12 @@ static struct samsung_pmx_func *samsung_pinctrl_creat= e_functions( * and create pin groups and pin function lists. */ func_cnt =3D 0; - for_each_child_of_node(dev_np, cfg_np) { - struct device_node *func_np; - + for_each_child_of_node_scoped(dev_np, cfg_np) { if (!of_get_child_count(cfg_np)) { ret =3D samsung_pinctrl_create_function(dev, drvdata, cfg_np, func); - if (ret < 0) { - of_node_put(cfg_np); + if (ret < 0) return ERR_PTR(ret); - } if (ret > 0) { ++func; ++func_cnt; @@ -808,14 +802,11 @@ static struct samsung_pmx_func *samsung_pinctrl_creat= e_functions( continue; } =20 - for_each_child_of_node(cfg_np, func_np) { + for_each_child_of_node_scoped(cfg_np, func_np) { ret =3D samsung_pinctrl_create_function(dev, drvdata, func_np, func); - if (ret < 0) { - of_node_put(func_np); - of_node_put(cfg_np); + if (ret < 0) return ERR_PTR(ret); - } if (ret > 0) { ++func; ++func_cnt; --=20 2.37.1