From nobody Sun Feb 8 08:22:19 2026 Received: from out-181.mta1.migadu.com (out-181.mta1.migadu.com [95.215.58.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C79E15687B for ; Fri, 3 May 2024 16:41:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714754515; cv=none; b=DySqnJimA1XYVwPxH2l/QzOJIgjYllCq3NWeg4q+7YmUcuCqRvk/aVvYVtr+0qF4C5XmgmQUwZWCf0IeRTiKrmSnDcUGKNCRfOOzP9X+MZgfQOdX6S1vYBwgEdbPlPhyE6xSs8/mnv9NSoaHmh6kipSmdaurIUHEJZUj7x8FHQQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714754515; c=relaxed/simple; bh=9sGQ/fUDFoy61NK2pn9YmbNuBXduV1Gn0bpYAhs1TP4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=B1W3NvGzoIEygansRxRqpnGXf7J5+fj8KhVmQ2uCCsYNNNSwMR+AcN7IFRRxDGpFWi7hM7ymJZ5NR/W2rcJ2+OrSWfK9PzawfPe3BPAicwlDRqzHsncY8bbLRBad/aXTOXdgQQVlB9hC+S7eWjjD9FGcilDuPZHQTyYtYK+sCoo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=ehicEv4V; arc=none smtp.client-ip=95.215.58.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="ehicEv4V" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1714754512; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Yyy5fyLjc4szJD74rdcFLjNsUfkjdPQxKNTJGttYiLo=; b=ehicEv4VgCJtYTUgspFM2K9Z8IDFnv0D5QxMm9wF4EjE0TRLFqtYwNp3WRHDX046eKyDlu kMHLSl9qfPFfuH4xgOB2cksvJXSOKlWGKuUXhAoky/ZJ2DYym4+znRfKFWOuNmN8H8aLlA 1m+2uJBB5l1M0RDyHlQt41ZUJQxj6Qo= From: Sui Jingfeng To: Andrzej Hajda Cc: Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Sui Jingfeng Subject: [PATCH v5 07/10] drm/bridge: tfp410: Use fwnode APIs to acquire device properties Date: Sat, 4 May 2024 00:41:03 +0800 Message-Id: <20240503164106.1172650-8-sui.jingfeng@linux.dev> In-Reply-To: <20240503164106.1172650-1-sui.jingfeng@linux.dev> References: <20240503164106.1172650-1-sui.jingfeng@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" Make this driver less DT-dependent by calling the newly created helpers, also switch to use fwnode APIs to acquire additional device properties. No functional changes for DT-based systems. Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/bridge/ti-tfp410.c | 41 +++++++++++++++--------------- 1 file changed, 21 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti= -tfp410.c index c7bef5c23927..58dc7492844f 100644 --- a/drivers/gpu/drm/bridge/ti-tfp410.c +++ b/drivers/gpu/drm/bridge/ti-tfp410.c @@ -266,8 +266,9 @@ static const struct drm_bridge_timings tfp410_default_t= imings =3D { =20 static int tfp410_parse_timings(struct tfp410 *dvi, bool i2c) { + struct fwnode_handle *fwnode =3D dev_fwnode(dvi->dev); struct drm_bridge_timings *timings =3D &dvi->timings; - struct device_node *ep; + struct fwnode_handle *ep; u32 pclk_sample =3D 0; u32 bus_width =3D 24; u32 deskew =3D 0; @@ -288,14 +289,14 @@ static int tfp410_parse_timings(struct tfp410 *dvi, b= ool i2c) * and EDGE pins. They are specified in DT through endpoint properties * and vendor-specific properties. */ - ep =3D of_graph_get_endpoint_by_regs(dvi->dev->of_node, 0, 0); + ep =3D fwnode_graph_get_endpoint_by_id(fwnode, 0, 0, 0); if (!ep) return -EINVAL; =20 /* Get the sampling edge from the endpoint. */ - of_property_read_u32(ep, "pclk-sample", &pclk_sample); - of_property_read_u32(ep, "bus-width", &bus_width); - of_node_put(ep); + fwnode_property_read_u32(ep, "pclk-sample", &pclk_sample); + fwnode_property_read_u32(ep, "bus-width", &bus_width); + fwnode_handle_put(ep); =20 timings->input_bus_flags =3D DRM_BUS_FLAG_DE_HIGH; =20 @@ -324,7 +325,7 @@ static int tfp410_parse_timings(struct tfp410 *dvi, boo= l i2c) } =20 /* Get the setup and hold time from vendor-specific properties. */ - of_property_read_u32(dvi->dev->of_node, "ti,deskew", &deskew); + fwnode_property_read_u32(fwnode, "ti,deskew", &deskew); if (deskew > 7) return -EINVAL; =20 @@ -336,12 +337,12 @@ static int tfp410_parse_timings(struct tfp410 *dvi, b= ool i2c) =20 static int tfp410_init(struct device *dev, bool i2c) { - struct device_node *node; + struct fwnode_handle *fwnode =3D dev_fwnode(dev); struct tfp410 *dvi; int ret; =20 - if (!dev->of_node) { - dev_err(dev, "device-tree data is missing\n"); + if (!fwnode) { + dev_err(dev, "firmware data is missing\n"); return -ENXIO; } =20 @@ -352,8 +353,8 @@ static int tfp410_init(struct device *dev, bool i2c) dvi->dev =3D dev; dev_set_drvdata(dev, dvi); =20 + drm_bridge_set_node(&dvi->bridge, fwnode); dvi->bridge.funcs =3D &tfp410_bridge_funcs; - dvi->bridge.of_node =3D dev->of_node; dvi->bridge.timings =3D &dvi->timings; dvi->bridge.type =3D DRM_MODE_CONNECTOR_DVID; =20 @@ -362,15 +363,15 @@ static int tfp410_init(struct device *dev, bool i2c) return ret; =20 /* Get the next bridge, connected to port@1. */ - node =3D of_graph_get_remote_node(dev->of_node, 1, -1); - if (!node) - return -ENODEV; - - dvi->next_bridge =3D of_drm_find_bridge(node); - of_node_put(node); - - if (!dvi->next_bridge) + dvi->next_bridge =3D drm_bridge_find_next_bridge_by_fwnode(fwnode, 1); + if (IS_ERR(dvi->next_bridge)) { + ret =3D PTR_ERR(dvi->next_bridge); + dev_err(dev, "Error in founding the next bridge: %d\n", ret); + return ret; + } else if (!dvi->next_bridge) { + dev_dbg(dev, "Next bridge not found, deferring probe\n"); return -EPROBE_DEFER; + } =20 /* Get the powerdown GPIO. */ dvi->powerdown =3D devm_gpiod_get_optional(dev, "powerdown", @@ -422,10 +423,10 @@ static struct platform_driver tfp410_platform_driver = =3D { /* There is currently no i2c functionality. */ static int tfp410_i2c_probe(struct i2c_client *client) { + struct fwnode_handle *fwnode =3D dev_fwnode(&client->dev); int reg; =20 - if (!client->dev.of_node || - of_property_read_u32(client->dev.of_node, "reg", ®)) { + if (!fwnode || fwnode_property_read_u32(fwnode, "reg", ®)) { dev_err(&client->dev, "Can't get i2c reg property from device-tree\n"); return -ENXIO; --=20 2.34.1