From nobody Sun Feb 8 06:54:39 2026 Received: from out-186.mta1.migadu.com (out-186.mta1.migadu.com [95.215.58.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C02E156F44 for ; Fri, 3 May 2024 16:41:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.186 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714754510; cv=none; b=n94qDcrwVp8nGL+YcTnvhnZdX3BRAsCtI7e8bEe7yiMmHQdBw0RwtgM1NSzYCblY7hIFGPfzAhMnjkBFHR80dIfPXf0BGQG3MaHhYOa9lsuoFSdTwvf3kFu4ZQbYbStHoLVhor7Q3rngQbdL2s9H1JGGBeMvWSptw85K/svJLj0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714754510; c=relaxed/simple; bh=3MgDWKoELIKcGTOqxE99fqgTb2mq9wYz9cuuNrsxIgg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Q7yD3Del2R6Nk3CPfG4YnP6zK+n0X8doxIj1LzDu5txMsBu741VutH7qCERfdwK0ONJ1YsXyo4JayQL9ANU/g6T/zZCzxu5hJ8IY+d3FQub/YTHTCW1kFHdYhxWoeFTvOa4MgBcxXYS02TCk7lwPII6KEPH7WCgKdH9lEUOv804= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=tqJVhjtv; arc=none smtp.client-ip=95.215.58.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="tqJVhjtv" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1714754506; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JqKrHtcvPbMTS7w/5GNDGOIaEii78vZ2tLUZybKcI8w=; b=tqJVhjtvMyG9Xlts1eJPYCZTkYZxnav9EaU2pFlS1VVKxNOXHpU2ubV+E2aNMEtGRVEwXw HBT/57wRNdovsdEcZ9AbbV/Q83I6bv35zB2EosJ3iUkJ9wlLAyJrvo1dIhHkEFghjIVN8g rFBBtthHm3EELK33Vg/KX5lAKu7acMA= From: Sui Jingfeng To: Andrzej Hajda Cc: Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Sui Jingfeng Subject: [PATCH v5 06/10] drm-bridge: it66121: Use fwnode APIs to acquire device properties Date: Sat, 4 May 2024 00:41:02 +0800 Message-Id: <20240503164106.1172650-7-sui.jingfeng@linux.dev> In-Reply-To: <20240503164106.1172650-1-sui.jingfeng@linux.dev> References: <20240503164106.1172650-1-sui.jingfeng@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" Make this driver less DT-dependent by calling the newly created helpers, also switch to use fwnode APIs to acquire additional device properties. A side benifit is that boilerplates get reduced, no functional changes for DT-based systems. Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/bridge/ite-it66121.c | 57 +++++++++++++++++----------- 1 file changed, 35 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/= ite-it66121.c index 925e42f46cd8..688dc1830654 100644 --- a/drivers/gpu/drm/bridge/ite-it66121.c +++ b/drivers/gpu/drm/bridge/ite-it66121.c @@ -15,7 +15,6 @@ #include #include #include -#include #include #include #include @@ -1480,7 +1479,7 @@ static int it66121_audio_codec_init(struct it66121_ct= x *ctx, struct device *dev) =20 dev_dbg(dev, "%s\n", __func__); =20 - if (!of_property_read_bool(dev->of_node, "#sound-dai-cells")) { + if (!fwnode_property_present(dev_fwnode(dev), "#sound-dai-cells")) { dev_info(dev, "No \"#sound-dai-cells\", no audio\n"); return 0; } @@ -1503,13 +1502,36 @@ static const char * const it66121_supplies[] =3D { "vcn33", "vcn18", "vrf12" }; =20 +static int it66121_read_bus_width(struct fwnode_handle *fwnode, u32 *bus_w= idth) +{ + struct fwnode_handle *endpoint; + u32 val; + int ret; + + endpoint =3D fwnode_graph_get_endpoint_by_id(fwnode, 0, 0, 0); + if (!endpoint) + return -EINVAL; + + ret =3D fwnode_property_read_u32(endpoint, "bus-width", &val); + fwnode_handle_put(endpoint); + if (ret) + return ret; + + if (val !=3D 12 && val !=3D 24) + return -EINVAL; + + *bus_width =3D val; + + return 0; +} + static int it66121_probe(struct i2c_client *client) { u32 revision_id, vendor_ids[2] =3D { 0 }, device_ids[2] =3D { 0 }; - struct device_node *ep; int ret; struct it66121_ctx *ctx; struct device *dev =3D &client->dev; + struct fwnode_handle *fwnode =3D dev_fwnode(dev); =20 if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) { dev_err(dev, "I2C check functionality failed.\n"); @@ -1520,29 +1542,20 @@ static int it66121_probe(struct i2c_client *client) if (!ctx) return -ENOMEM; =20 - ep =3D of_graph_get_endpoint_by_regs(dev->of_node, 0, 0); - if (!ep) - return -EINVAL; - ctx->dev =3D dev; ctx->client =3D client; ctx->info =3D i2c_get_match_data(client); =20 - of_property_read_u32(ep, "bus-width", &ctx->bus_width); - of_node_put(ep); - - if (ctx->bus_width !=3D 12 && ctx->bus_width !=3D 24) - return -EINVAL; - - ep =3D of_graph_get_remote_node(dev->of_node, 1, -1); - if (!ep) { - dev_err(ctx->dev, "The endpoint is unconnected\n"); - return -EINVAL; - } + ret =3D it66121_read_bus_width(fwnode, &ctx->bus_width); + if (ret) + return ret; =20 - ctx->next_bridge =3D of_drm_find_bridge(ep); - of_node_put(ep); - if (!ctx->next_bridge) { + ctx->next_bridge =3D drm_bridge_find_next_bridge_by_fwnode(fwnode, 1); + if (IS_ERR(ctx->next_bridge)) { + ret =3D PTR_ERR(ctx->next_bridge); + dev_err(dev, "Error in founding the next bridge: %d\n", ret); + return ret; + } else if (!ctx->next_bridge) { dev_dbg(ctx->dev, "Next bridge not found, deferring probe\n"); return -EPROBE_DEFER; } @@ -1577,8 +1590,8 @@ static int it66121_probe(struct i2c_client *client) return -ENODEV; } =20 + drm_bridge_set_node(&ctx->bridge, fwnode); ctx->bridge.funcs =3D &it66121_bridge_funcs; - ctx->bridge.of_node =3D dev->of_node; ctx->bridge.type =3D DRM_MODE_CONNECTOR_HDMIA; ctx->bridge.ops =3D DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID; if (client->irq > 0) { --=20 2.34.1