From nobody Thu Sep 19 23:23:15 2024 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E684135A66 for ; Fri, 3 May 2024 21:37:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714772273; cv=none; b=iSNqaQRhPTKtwTco/02gOK0UPxgpV9IN/CpBEM7YbjPHDRgMlusNw+nPDfXn98uqFIMIbLEPGChRPoefUaLPZ/SSYDJfZhpZZzgJPPtUvOFWcDKGJfOXmYgXyZ2uZ0dVSdwI+K/N/RnwPUzqLTagfCxDqd7pi1S8T1kznkP24Bw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714772273; c=relaxed/simple; bh=Ag630NMyOKc2REE64wl78IRaThiGetixkU0G1oxt3RY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ntR1PlVNQ7Er9uJderY84VSSFMKO3gcLU8YfIGOl/X+9zzmIZM4Hqu+P+128l0Xi+f7/Gz+7IfRWApcA3p1jaybEMkXlNxhpY0cjlnTrLbCFakxYVIfq6huR2a938FmKqYbc8s9tTNe2bhl/tP+MtleXGa0Z3zEx4Vbvr1khwEM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=fQfOx7fR; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="fQfOx7fR" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1ec5387aed9so1022185ad.3 for ; Fri, 03 May 2024 14:37:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1714772271; x=1715377071; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rL+8TR+FVEOGHEmIclktS5Eo1OM2fp+pjfqU2SfLZsA=; b=fQfOx7fRQtlyYf2h1dOclH0+NCJy7FYl9MR3PJmxd7WBI0HvgudnXUtauABCd37p3K ThBeQUSbBNMKrz/54zWvNMHndEZmD6HbvzmFjpM79XladC6pYE3PdBzr+qEwZ5OH75id 3pYIAySvTKvsXm2CL1GalzHVecPxbkWaieyIY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714772271; x=1715377071; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rL+8TR+FVEOGHEmIclktS5Eo1OM2fp+pjfqU2SfLZsA=; b=RyXgEAwNdJcagkeN8+DiwD9p5NhR2B0Ix5QgoBBgmcUZI/mcJarTbnKfXIwrg09LKh SvTLPP+Gc8TNATAZMNaJTEtGUcEiygss9lnBxa0zhMjscTIUCaGVEWc93kfwXp98OK7X sPw6KCb1OkwUeiHiRQsxA22CprBXxj1Jx44cFzsq6M+Dig85K7Be9WcVCr5u961Fr2xK u6Gr67jBp0BySiRCGXhZyZ0zudIwWIiPSogAXzYC0Nj6A7oOimBGaVH+LrwOwyTHkujF Q3O+xxyvQNBoD/E0HvUH80//GkWnBLMmRbGRjCuu1VbuZYHRUxWil29NZaB5at5wQUCd zmxg== X-Forwarded-Encrypted: i=1; AJvYcCXIvlr3rMauJVCW81jSdIhU+900D+pITUq7cH5bvbP8sz7TA0tiea3r5wy0LoWgL/jgHk5N4/uhs2GfpKshiIg9zQ8/JPHVvpJ+DRbL X-Gm-Message-State: AOJu0Yx1uPEBu8SNjQEhTv6KBtQNA0ePrML0qho3aK7e3SG/017pl4to iZnFX2uJRLVK1YfrgQNzuXMO1cpt+wfqMwPkhGdzqHV467LMyK099CaaQupqVmAyh0koiyLGkYg 1aQ== X-Google-Smtp-Source: AGHT+IGqOILtOMpTQpdNPww4A4HTkoN+afOAFJGfdSt9UtYlGc1IDjYPsnnRSAg9cfQkss7IrOZqZQ== X-Received: by 2002:a17:902:b495:b0:1ea:f7d4:cf2b with SMTP id y21-20020a170902b49500b001eaf7d4cf2bmr3601945plr.17.1714772271011; Fri, 03 May 2024 14:37:51 -0700 (PDT) Received: from dianders.sjc.corp.google.com ([2620:15c:9d:2:fb6a:b54b:7580:64f3]) by smtp.gmail.com with ESMTPSA id j12-20020a170903024c00b001eb51a46f5bsm3729134plh.43.2024.05.03.14.37.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 May 2024 14:37:50 -0700 (PDT) From: Douglas Anderson To: dri-devel@lists.freedesktop.org, Maxime Ripard Cc: Linus Walleij , Chris Morgan , Yuran Pereira , Neil Armstrong , Douglas Anderson , Marco Franchi , Fabio Estevam , Laurentiu Palcu , Pengutronix Kernel Team , imx@lists.linux.dev, Daniel Vetter , David Airlie , Jessica Zhang , Maarten Lankhorst , Sam Ravnborg , Thomas Zimmermann , linux-kernel@vger.kernel.org Subject: [RFT PATCH v2 37/48] drm/panel: seiko-43wvf1g: Don't call disable at shutdown/remove Date: Fri, 3 May 2024 14:33:18 -0700 Message-ID: <20240503143327.RFT.v2.37.Ief712fb6720cb98bdf9ec8644362d028b6554f9b@changeid> X-Mailer: git-send-email 2.45.0.rc1.225.g2a3ae87e7f-goog In-Reply-To: <20240503213441.177109-1-dianders@chromium.org> References: <20240503213441.177109-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" It's the responsibility of a correctly written DRM modeset driver to call drm_atomic_helper_shutdown() at shutdown time and that should be disabling / unpreparing the panel if needed. Panel drivers shouldn't be calling these functions themselves. A recent effort was made to fix as many DRM modeset drivers as possible [1] [2] [3] and most drivers are fixed now. A grep through mainline for compatible strings used by this driver indicates that it is used by IMX boards. As far as I can tell, all IMX boards are now correctly calling drm_atomic_helper_shutdown() so we can remove the calls. [1] https://lore.kernel.org/r/20230901234015.566018-1-dianders@chromium.org [2] https://lore.kernel.org/r/20230901234202.566951-1-dianders@chromium.org [3] https://lore.kernel.org/r/20230921192749.1542462-1-dianders@chromium.org Cc: Marco Franchi Cc: Fabio Estevam Cc: Laurentiu Palcu Cc: Pengutronix Kernel Team Cc: imx@lists.linux.dev Signed-off-by: Douglas Anderson --- Changes in v2: - Only handle 1 panel per patch. - Split removal of prepared/enabled from handling of remove/shutdown. drivers/gpu/drm/panel/panel-seiko-43wvf1g.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-seiko-43wvf1g.c b/drivers/gpu/drm/= panel/panel-seiko-43wvf1g.c index 98480904126c..8a3fe531c641 100644 --- a/drivers/gpu/drm/panel/panel-seiko-43wvf1g.c +++ b/drivers/gpu/drm/panel/panel-seiko-43wvf1g.c @@ -243,14 +243,6 @@ static void seiko_panel_remove(struct platform_device = *pdev) struct seiko_panel *panel =3D platform_get_drvdata(pdev); =20 drm_panel_remove(&panel->base); - drm_panel_disable(&panel->base); -} - -static void seiko_panel_shutdown(struct platform_device *pdev) -{ - struct seiko_panel *panel =3D platform_get_drvdata(pdev); - - drm_panel_disable(&panel->base); } =20 static const struct display_timing seiko_43wvf1g_timing =3D { @@ -306,7 +298,6 @@ static struct platform_driver seiko_panel_platform_driv= er =3D { }, .probe =3D seiko_panel_platform_probe, .remove_new =3D seiko_panel_remove, - .shutdown =3D seiko_panel_shutdown, }; module_platform_driver(seiko_panel_platform_driver); =20 --=20 2.45.0.rc1.225.g2a3ae87e7f-goog