From nobody Thu Sep 19 23:08:41 2024 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 577A6134724 for ; Fri, 3 May 2024 21:37:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714772264; cv=none; b=ET/U88NzM5AuBoYg41CPfpzs0SCAy2HULstp07GzcnVqQTzQnBP5gV9DliwU1879FkX5sK1q0BUzrZo907A0HFGaAo7bGJy7QtYsZ5OJw/bco9i2nGuMyg17COHzRVmxMYLqTE/OF0n6c56ZeRuPT1siet5dfdg20KEvRoBGOwA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714772264; c=relaxed/simple; bh=EW9EHA19HYq7AAGYskgYbnLH9iMVmfN0mFfb448TwtQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=b7uKhzRBEaxc0gCIuOocMGSvqRyiuxi+khDJw08stqkYYeJlOPu1wEWCN2Jke0LIci/q9/AIrb6gN561JnI9aHtvvhJGj8DtA/6Od0RSb6rzQYALwRe7D3MUPLQzZH5ZfSIywXUgVTnY8d000HwsKFZTY11t11A8kG/zfRUNzRU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=gAOLYe0N; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="gAOLYe0N" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1ecc23e6c9dso730515ad.2 for ; Fri, 03 May 2024 14:37:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1714772260; x=1715377060; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=O/Sm++Egsx8q7rlUkwUyB5q6Cu7fnuL8sFgKBvzduqs=; b=gAOLYe0NaIFchFC93Jn5JiiBP4D7dKHJegy+bOBSHt6trTgrxevXj1sWZgyEDqOGBT O3RU26ktsfsZ59pGgmax/K08GkWnJWEmJMabx1ahQZ1MB3Dr2vLCEn46HSZkblDCj+9m pZ2EBoJF8gsIxFXRl2s4tXqinGWKSv+6Dzf/k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714772260; x=1715377060; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=O/Sm++Egsx8q7rlUkwUyB5q6Cu7fnuL8sFgKBvzduqs=; b=uhDoHRCOsCdtSRJfNG4bXrPgaFNmqhypC2fB8uF4wD7JzVKiuSI0Hgeq4M/SiNeost zzRI8xbfiK8xPKsdmF0+aQSX5qFNrUAjxMo9xdgJSZU6Vm1kGW2myFGaMUhCavt2zl9d JFBBm1CadUcuWPLqeBn0pzNPDVBrOT3LeNCvH1SMaCpBg8a7EaOH5rAdHikrm0z8Ok4w O5Gm3b61u8uLjglWb2GPr6jAoupyElNvjVQRXlh0yQAAIHJWLxJi3YsxndczhRHSD62N J2tt2iVokeGLLR8aSpLyTSUuod2i2FtvxlQlGYJgthZmc5w7+D5jAnFGbtpSGdS8ku/E 29GQ== X-Forwarded-Encrypted: i=1; AJvYcCUo5ZhErzRkOB31kRCqOIHJkuzle+/K25FBuIr0KJ6o1Y5B+XhMRFjgefuV4AcSAKP2dpZWRO87q7p/Cqp+SME7DlTjIvd0OCI0Q5ia X-Gm-Message-State: AOJu0Yw05voPWP/Ew28lDOwYRKEGppW7SMlXhK4cWEAFhHE2zipgH820 GFmbuH+/VwSr1h0hRoW5rWjbwwFdbQG7RAiBlunkAmGHy4GWbyycxbndGSboBg== X-Google-Smtp-Source: AGHT+IGCLyeRka7bEbj1rtJf7J0U2tyRPC1SfBgt3k9U7tPl56QaTyO/M7OMcuQw3XwRdMK87YcijA== X-Received: by 2002:a17:902:cec2:b0:1e4:47bf:6926 with SMTP id d2-20020a170902cec200b001e447bf6926mr5145949plg.4.1714772260615; Fri, 03 May 2024 14:37:40 -0700 (PDT) Received: from dianders.sjc.corp.google.com ([2620:15c:9d:2:fb6a:b54b:7580:64f3]) by smtp.gmail.com with ESMTPSA id j12-20020a170903024c00b001eb51a46f5bsm3729134plh.43.2024.05.03.14.37.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 May 2024 14:37:39 -0700 (PDT) From: Douglas Anderson To: dri-devel@lists.freedesktop.org, Maxime Ripard Cc: Linus Walleij , Chris Morgan , Yuran Pereira , Neil Armstrong , Douglas Anderson , Vinay Simha BN , Sumit Semwal , Daniel Vetter , David Airlie , Jessica Zhang , Maarten Lankhorst , Sam Ravnborg , Thomas Zimmermann , linux-kernel@vger.kernel.org Subject: [RFT PATCH v2 32/48] drm/panel: jdi-lt070me05000: Stop tracking prepared/enabled Date: Fri, 3 May 2024 14:33:13 -0700 Message-ID: <20240503143327.RFT.v2.32.I2e991044def6644c18ad8d7d686f4f3006f278de@changeid> X-Mailer: git-send-email 2.45.0.rc1.225.g2a3ae87e7f-goog In-Reply-To: <20240503213441.177109-1-dianders@chromium.org> References: <20240503213441.177109-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As talked about in commit d2aacaf07395 ("drm/panel: Check for already prepared/enabled in drm_panel"), we want to remove needless code from panel drivers that was storing and double-checking the prepared/enabled state. Even if someone was relying on the double-check before, that double-check is now in the core and not needed in individual drivers. NOTE: as part of this, transition the panel's direct calls to its disable function in shutdown/remove to call through DRM panel. Cc: Vinay Simha BN Cc: Sumit Semwal Signed-off-by: Douglas Anderson --- Note: since we are able to identify that this panel only appears to be used on Qualcomm boards and we have to touch the shutdown/remove path in this patch anyway, we could possibly squash this with the next patch that removes the disable call in shutdown/remove. For now I'm keeping them separate just to keep the concepts separate. Changes in v2: - Only handle 1 panel per patch. - Split removal of prepared/enabled from handling of remove/shutdown. .../gpu/drm/panel/panel-jdi-lt070me05000.c | 27 ++----------------- 1 file changed, 2 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c b/drivers/gpu/d= rm/panel/panel-jdi-lt070me05000.c index f9a69f347068..4ddddee6fa1e 100644 --- a/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c +++ b/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c @@ -37,9 +37,6 @@ struct jdi_panel { struct gpio_desc *dcdc_en_gpio; struct backlight_device *backlight; =20 - bool prepared; - bool enabled; - const struct drm_display_mode *mode; }; =20 @@ -176,13 +173,8 @@ static int jdi_panel_disable(struct drm_panel *panel) { struct jdi_panel *jdi =3D to_jdi_panel(panel); =20 - if (!jdi->enabled) - return 0; - backlight_disable(jdi->backlight); =20 - jdi->enabled =3D false; - return 0; } =20 @@ -192,9 +184,6 @@ static int jdi_panel_unprepare(struct drm_panel *panel) struct device *dev =3D &jdi->dsi->dev; int ret; =20 - if (!jdi->prepared) - return 0; - jdi_panel_off(jdi); =20 ret =3D regulator_bulk_disable(ARRAY_SIZE(jdi->supplies), jdi->supplies); @@ -207,8 +196,6 @@ static int jdi_panel_unprepare(struct drm_panel *panel) =20 gpiod_set_value(jdi->dcdc_en_gpio, 0); =20 - jdi->prepared =3D false; - return 0; } =20 @@ -218,9 +205,6 @@ static int jdi_panel_prepare(struct drm_panel *panel) struct device *dev =3D &jdi->dsi->dev; int ret; =20 - if (jdi->prepared) - return 0; - ret =3D regulator_bulk_enable(ARRAY_SIZE(jdi->supplies), jdi->supplies); if (ret < 0) { dev_err(dev, "regulator enable failed, %d\n", ret); @@ -250,8 +234,6 @@ static int jdi_panel_prepare(struct drm_panel *panel) goto poweroff; } =20 - jdi->prepared =3D true; - return 0; =20 poweroff: @@ -272,13 +254,8 @@ static int jdi_panel_enable(struct drm_panel *panel) { struct jdi_panel *jdi =3D to_jdi_panel(panel); =20 - if (jdi->enabled) - return 0; - backlight_enable(jdi->backlight); =20 - jdi->enabled =3D true; - return 0; } =20 @@ -475,7 +452,7 @@ static void jdi_panel_remove(struct mipi_dsi_device *ds= i) struct jdi_panel *jdi =3D mipi_dsi_get_drvdata(dsi); int ret; =20 - ret =3D jdi_panel_disable(&jdi->base); + ret =3D drm_panel_disable(&jdi->base); if (ret < 0) dev_err(&dsi->dev, "failed to disable panel: %d\n", ret); =20 @@ -491,7 +468,7 @@ static void jdi_panel_shutdown(struct mipi_dsi_device *= dsi) { struct jdi_panel *jdi =3D mipi_dsi_get_drvdata(dsi); =20 - jdi_panel_disable(&jdi->base); + drm_panel_disable(&jdi->base); } =20 static struct mipi_dsi_driver jdi_panel_driver =3D { --=20 2.45.0.rc1.225.g2a3ae87e7f-goog