From nobody Wed Dec 17 22:46:04 2025 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCA10165FD3 for ; Wed, 1 May 2024 21:57:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714600671; cv=none; b=t3WbCTxnbiVzBzTuOmfA+Yq+frymKx98li3vvo5z4F8+rmOJjQSnBX46S1qWJm3FQn7YHu2R0reDkwSwng2Vz5OltaJQcRC+5FXsKqjgylf5X2R4FRThPhLj7vZ7EXu9l1TaOd/4rICG9kV3avsVJWR6UD3rRVVEk4M9q9pC12w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714600671; c=relaxed/simple; bh=85q0tifsi/ZuyVB/GgI9ADumbYXEGf7MqN589kwsqLM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=PDFg+HJhmZeEeydXLPgDbQcUNea9mvPBiqAAIZ8XgHkxwYteZZNmtdm0EejmBpU0lta/MEtjj6EHxnOpXlHYLFucUYj769bAm9CUnwzEnZi0FYHYJUVi4PcVfffKSB6RFvJd4Btu74FvK5s4UFj5OJqLq9qRwnIdvgOdnZ3sTk4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=usp.br; spf=pass smtp.mailfrom=usp.br; dkim=pass (2048-bit key) header.d=usp.br header.i=@usp.br header.b=WJ0MDWcW; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=usp.br Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=usp.br Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=usp.br header.i=@usp.br header.b="WJ0MDWcW" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-60585faa69fso877979a12.1 for ; Wed, 01 May 2024 14:57:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp.br; s=usp-google; t=1714600668; x=1715205468; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=liA+N999r9bzQdbuy7djyarhfhemj80TYrbbaFh4LiE=; b=WJ0MDWcWb/i+3q/Kag3ECG2z5b7EoCCox20EeNjma0DOc8jQbQmM4dH2InDjzw+Kda Gbuhka0vwRJbNZwfTqrTAeZbQ07MkVJhM+IIpVOodL3ki4YMJTJQHPWc8CyJNhrR0IxB LT33M51MSHuOTyEKq+EoJ4uQ2TBReqmZKnRZ9gUIUXsHr81dWBHmc0eG0UGSAYQEVBlz QF7au4knrcyy4eTiaI6/6kTbJ4O1Fhqcvvz4DxF62gOlkQeOHLJL5kSpBf4o1NadJdVY +JEncIx+tlEBUbIKIzwvlGhk5P8GhLZ0Pcxbo1gAJf7nu4ySaQMtuFl8pQySjVcPuSwC trWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714600668; x=1715205468; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=liA+N999r9bzQdbuy7djyarhfhemj80TYrbbaFh4LiE=; b=WCdvzzTbDW/ZJagoCJr7fzsrijtBzWnHcek58dgfZN+hQHBp6f77nI1RhhoNJxzPYh HG4Z+SfIWx/AYry6Kf5e6pLEN8QrLhq+OA+qQYOVN+oUkGbCJ5KUMFtS6+7b695VLT3D EKY1wWwsLGNtAprZtjav86KK905HO60tVrZ0/sCQy4cWdN5pX9JtR/Z6jlGNWK79u9rZ it442JpiS/AP5mtwJQTDLRBfeuSpqTHVWxkG+9u1euGQLshyfmiEk18YO74vdUZ5smdo wEpKdw+530CqtS7mKfvR3WZSt01DyJIWJZ5XOHg7IS3ZigITRRFrYUnzx93E73f4jIGc iQ5g== X-Forwarded-Encrypted: i=1; AJvYcCW2EyPyU0FswXPP674j6Wh2ueIZTCei69eg2vstNu7Hm880+Zg0/0nqloUCPILNIU6XFExjaBdIqEIliglSyS46UPm1BUTRmnV4MEv6 X-Gm-Message-State: AOJu0YyZzdnUt0YmSbd+HUbinJH43vgbtkrZChLgfwQUnznCCeTyhkpQ LggwCtX50Ljs0qPJ138C4H7p3MVMKmhWeNVRQb1hjf2BfItjepaQ+Qd1NK8fzEoeatAI0bWT0iv VZhcxwg== X-Google-Smtp-Source: AGHT+IFAYI1TjC9m2O0A+NLCtQ7DkOKK944/vmZckq1Oir19NSXnSbP1R7+CwfYA09TFN+xseYv4Xw== X-Received: by 2002:a17:90b:1298:b0:2a5:5f9f:6733 with SMTP id fw24-20020a17090b129800b002a55f9f6733mr1240580pjb.20.1714600668154; Wed, 01 May 2024 14:57:48 -0700 (PDT) Received: from Rigel.pinscher-bonito.ts.net ([2804:14c:34:2097::6c7]) by smtp.gmail.com with ESMTPSA id y5-20020a63fa05000000b005cf450e91d2sm22919843pgh.52.2024.05.01.14.57.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 14:57:47 -0700 (PDT) From: Jorge Harrisonn To: jic23@kernel.org, lars@metafoo.de Cc: Jorge Harrisonn , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, laisnuto@usp.br Subject: [PATCH 1/2] iio: adc: ad7606: using claim_direct_scoped for code simplification Date: Wed, 1 May 2024 18:57:23 -0300 Message-Id: <20240501215724.26655-2-jorge.harrisonn@usp.br> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240501215724.26655-1-jorge.harrisonn@usp.br> References: <20240501215724.26655-1-jorge.harrisonn@usp.br> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using iio_device_claim_direct_scoped instead of calling `iio_device _claim_direct_modeand later callingiio_device_release_direct_mode` This should make code cleaner and error handling easier Co-authored-by: Lais Nuto Signed-off-by: Lais Nuto Signed-off-by: Jorge Harrisonn --- drivers/iio/adc/ad7606.c | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/drivers/iio/adc/ad7606.c b/drivers/iio/adc/ad7606.c index 1928d9ae5bcf..fa989e0d7e70 100644 --- a/drivers/iio/adc/ad7606.c +++ b/drivers/iio/adc/ad7606.c @@ -174,17 +174,14 @@ static int ad7606_read_raw(struct iio_dev *indio_dev, =20 switch (m) { case IIO_CHAN_INFO_RAW: - ret =3D iio_device_claim_direct_mode(indio_dev); - if (ret) - return ret; - - ret =3D ad7606_scan_direct(indio_dev, chan->address); - iio_device_release_direct_mode(indio_dev); - - if (ret < 0) - return ret; - *val =3D (short)ret; - return IIO_VAL_INT; + iio_device_claim_direct_scoped(return -EBUSY, indio_dev) { + ret =3D ad7606_scan_direct(indio_dev, chan->address); + if (ret < 0)=20 + return ret; + *val =3D (short) ret; + return IIO_VAL_INT; + } + unreachable(); case IIO_CHAN_INFO_SCALE: if (st->sw_mode_en) ch =3D chan->address; --=20 2.34.1 From nobody Wed Dec 17 22:46:04 2025 Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D007168AF7 for ; Wed, 1 May 2024 21:57:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714600673; cv=none; b=q3VNHXe4CBMbHeaHKA7nWWD6eeg+QmSQlORPQ7028iPYO08Rgv1dK0Qofvo2+Pck2uc9GAJzEJrg6GmkRbAjfruB/ye3AZDLyyGRDjyLtpP6H4d84p7mYlcIEOaNAwyFN8fkffnOmdAcoE3gLWPq+o46vwGYrtl4SQmmpOGJXAg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714600673; c=relaxed/simple; bh=xQBDyYq+q7mrO43UsmzsJAEVIv0sNrh7F1MXl1TVyhU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=eDedfeMO2uKKFM7xMXFzfcRDdvtFNP24jnfOsaKJpLj226B6p0/xEuYesUvzWPevOvzCwG0d1nz4EpMkM2SiNuAeKmPIiaRzCqDYHGiiCjc65OQTSC5aomgDgXPGe9oioltuzbOw7tSijOGOx0PPOYmQQtd2XfP8973HJWhSQBI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=usp.br; spf=pass smtp.mailfrom=usp.br; dkim=pass (2048-bit key) header.d=usp.br header.i=@usp.br header.b=KwBizn21; arc=none smtp.client-ip=209.85.166.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=usp.br Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=usp.br Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=usp.br header.i=@usp.br header.b="KwBizn21" Received: by mail-io1-f41.google.com with SMTP id ca18e2360f4ac-7de95c7851dso362507839f.3 for ; Wed, 01 May 2024 14:57:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp.br; s=usp-google; t=1714600671; x=1715205471; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lJ8W7jumY+a3Z7Yvkg0jJPfeRZ8DJgpTlOFfp0kNYS0=; b=KwBizn21coqS1sWuzU9/sbZbDflwj0HqI3tO9r+DmMZFKMR7d+FpFXNmLUWmVoucnL eu/4oQBbA0PnODSoYNZjn447rY1302gsLrqwe4SyVC83KzFRjPerWvST4lf/UPOGKoVc fOnLRtwBQ2+ouXfDfFbGWqbPE9TnE2pGUINVLvwa/R2iDa+Yljs+ePWftPhyXTP1bg29 vk2zoqZT0+sASw9CSwqcwHM2MG4FHJPaPJkiZXPqWjSl3Q5S97yNq2rzSfTLvQovMrJX n2OI6d7TmZ1YokBheQbQYeQynztfHB5fI+T+/Ngt3gRWzC2PNWS49yUE+6fIXdNZL7NA IzeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714600671; x=1715205471; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lJ8W7jumY+a3Z7Yvkg0jJPfeRZ8DJgpTlOFfp0kNYS0=; b=DfO8rFgf3wMGaJ/ZZb9RbWcgnydE+Z3bN6pEzgXLTNTKh4BpYzQpcNgvVskNKSPA1d mNsDuBWXcz3bmTvgFeOLcrmqdc5fmQxES7dVG/WikFi8HCyV5jxW8yuvaYbh8UVSSOSY xWxWHltGwRP0WHUtq6rrmJgmgrUhhDGAlmNmYasGhAM9J4KvOWhAbqM8R5l1P9e2xAmn C+EkmUwTNHAHgGJPegTenAB85uTaJt1qMoTM80MXaIFdi+XTuO9O8txBpJY+M41oYu57 gJw61tmb8cwHVBGL+1DghsgIz2g4bps0WR5iREQioX2NI4dA8tXzh7L6/Y06g/SNZ+C0 dVWw== X-Forwarded-Encrypted: i=1; AJvYcCVFUYeHcruxjHSCdzVfZiaega+cbRKa88P2w02wn6W+ERLUisxwSVr+IxzloFH56ozVs2LoM8c5aDQ6tD/jm9lQA9oTOEHb4xG2WOFb X-Gm-Message-State: AOJu0YwVJS+JW8m0gTJ7n7amuRWj91yZ6E4/CEcTEn2m73mua2247c6x YXqSMjU+Oc6KB7fu8x6cy5pLulxzfar0Ne4E9cW7rmRd9BwnMTcZQChH5B54v8c= X-Google-Smtp-Source: AGHT+IHqU/KfTKnIiExWiOo0mDLyusJfvwwGprsq5KSU4nxd303ePIGAGM323MyiBXfTrxpmawhTNA== X-Received: by 2002:a05:6e02:1c2a:b0:36c:5124:eb35 with SMTP id m10-20020a056e021c2a00b0036c5124eb35mr4551489ilh.3.1714600671159; Wed, 01 May 2024 14:57:51 -0700 (PDT) Received: from Rigel.pinscher-bonito.ts.net ([2804:14c:34:2097::6c7]) by smtp.gmail.com with ESMTPSA id y5-20020a63fa05000000b005cf450e91d2sm22919843pgh.52.2024.05.01.14.57.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 14:57:50 -0700 (PDT) From: Jorge Harrisonn To: jic23@kernel.org, lars@metafoo.de Cc: Jorge Harrisonn , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, laisnuto@usp.br Subject: [PATCH 2/2] iio: adc: ad7923: using claim_direct_scoped for code simplification Date: Wed, 1 May 2024 18:57:24 -0300 Message-Id: <20240501215724.26655-3-jorge.harrisonn@usp.br> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240501215724.26655-1-jorge.harrisonn@usp.br> References: <20240501215724.26655-1-jorge.harrisonn@usp.br> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using iio_device_claim_direct_scoped instead of calling `iio_device _claim_direct_modeand later callingiio_device_release_direct_mode` This should make code cleaner and error handling easier Co-authored-by: Lais Nuto Signed-off-by: Lais Nuto Signed-off-by: Jorge Harrisonn --- drivers/iio/adc/ad7923.c | 30 ++++++++++++++---------------- 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/drivers/iio/adc/ad7923.c b/drivers/iio/adc/ad7923.c index 9d6bf6d0927a..a646521b2ef3 100644 --- a/drivers/iio/adc/ad7923.c +++ b/drivers/iio/adc/ad7923.c @@ -260,22 +260,20 @@ static int ad7923_read_raw(struct iio_dev *indio_dev, =20 switch (m) { case IIO_CHAN_INFO_RAW: - ret =3D iio_device_claim_direct_mode(indio_dev); - if (ret) - return ret; - ret =3D ad7923_scan_direct(st, chan->address); - iio_device_release_direct_mode(indio_dev); - - if (ret < 0) - return ret; - - if (chan->address =3D=3D EXTRACT(ret, 12, 4)) - *val =3D EXTRACT(ret, chan->scan_type.shift, - chan->scan_type.realbits); - else - return -EIO; - - return IIO_VAL_INT; + iio_device_claim_direct_scoped(return -EBUSY, indio_dev) { =09 + ret =3D ad7923_scan_direct(st, chan->address);=20 + =09 + if (ret < 0) + return ret; + + if (chan->address =3D=3D EXTRACT(ret, 12, 4)) + *val =3D EXTRACT(ret, 0, 12); + else + return -EIO; + + return IIO_VAL_INT; + } + unreachable(); case IIO_CHAN_INFO_SCALE: ret =3D ad7923_get_range(st); if (ret < 0) --=20 2.34.1