From nobody Thu Dec 18 18:04:42 2025 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 809F2127B68 for ; Tue, 30 Apr 2024 09:17:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714468631; cv=none; b=M2zl4jMcyBQSXzw1lbOLOdmvvhDhn7NahU8zQw1fUhcImzAineNzAZ0tDDkOYDjHRPdLpzsjHfPlr3wJFa/r2sP42NKyVK2nUMOHudqYbRTNxMcA82cquGFgZuTakMi3fQaK61u3dksNIi2653goNYCoq8Zt57zbXyjJNysh+/I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714468631; c=relaxed/simple; bh=kbui8HAPtLFHoAihV2ljcEUIS+VOYj9eDPfH+oMl4OE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=pMjs3BXPTXZh0TwwwWKurlnCBFm/7MyBZKf6eGrILByjwaT7sCcZOC6VBx/bWu/6qC40nto7tmWI9EuSYzfrOm8ODnyhNhL4A+e+Yh8MoKQT4DeWBPa36a5c+bL5ZyWGSdiQlyVL0Mroz0LlfbfsnHExSxAZ1pcfegeMHYjWAf4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Oc2IVSfD; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Oc2IVSfD" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-41c7ac71996so9454215e9.3 for ; Tue, 30 Apr 2024 02:17:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1714468628; x=1715073428; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Y6uTqfKoynlVxjI21T7uYyBdXiDNj2CtWTfpf3yueTA=; b=Oc2IVSfD8ouli3xisE6+E+Mh80edYEPXMvWg3VzBtrjnKBcMuqSNNl9AO4Tc/XBcim JoZeZ2dr7BKkYQNyOrqXCu32oASvpfQmGsySXSt79x5bJ8sgpfOK6uwabY3HpiFngxtq Rr7z7vdTJTXIOnaO6DKBwqxEEXELaaT4ijA9f3BSqwcVts5OEc7TSpy1PI4Aqhfo03MY 1O9BZE5eB9nJLgf21M3SXLPlKb/A+WbMfwEUEGdlR2soYtvPmCq9gP7eYwT6RJtA7SmO yTi1thqPKi4kjcXvOBtEStRcgX/kxCnVzLXTnQdUUIQAPsHYz6COQVFJ6xeYAkqq3RYG Hppg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714468628; x=1715073428; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y6uTqfKoynlVxjI21T7uYyBdXiDNj2CtWTfpf3yueTA=; b=P8aj01b5QLy+WS8PXmyrRt5jLB0Zk77GNn0voIw2/Y/fNwL0f5Dxb/WcPZOuUiTkxw r1L9bY8s6Y8VquC/Zn3ba2w8P4+3Pjw81nKWrQV8mYKX+5veGx0k43ZuBzYZSeoCuNhq b8p6m/GLJqtSx1kLXNNCaXqFDypsjeLdmI3FMJbSe3k3jxtojNJo7EapO1XN1MJ2sE5O IEmPxKCPkD+ZWtptlbAQVXYj98tOxebWuovkO4dD2AOlc1/M5MnpZ2gR8aWff9Lo/PLm Ct7nQ/rogIjhJknXftayPgkInZMpQvFsxy6mxP0aKqi/Ox/eJi5OFuCt386aiawwCbeL QE+A== X-Gm-Message-State: AOJu0Yz02tqa+m9vJTWLiDLO6kDQaG1FfLhNomvLK6ZTtSf96Rgq0LTp IRjx9oSOg7zk1U/ygc3pyAMTD8PmGJkoEnUG06zYF5655jMMPhUUCyo6kpzX76E= X-Google-Smtp-Source: AGHT+IHS+kEpMsge5Lat4FHl3SzA9hj0fc9sA/LacPhgmWil245qKTdxCK5Cna1s9b2LsxDX+eQAXA== X-Received: by 2002:a05:600c:1c91:b0:41a:ff7d:2473 with SMTP id k17-20020a05600c1c9100b0041aff7d2473mr9514585wms.4.1714468627926; Tue, 30 Apr 2024 02:17:07 -0700 (PDT) Received: from localhost.localdomain ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id l6-20020a5d4106000000b0034d8b0b5329sm935513wrp.87.2024.04.30.02.17.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Apr 2024 02:17:06 -0700 (PDT) From: srinivas.kandagatla@linaro.org To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Viken Dadhaniya , Konrad Dybcio , Srinivas Kandagatla Subject: [RESEND PATCH 1/3] slimbus: qcom-ngd-ctrl: Reduce auto suspend delay Date: Tue, 30 Apr 2024 10:16:55 +0100 Message-Id: <20240430091657.35428-2-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240430091657.35428-1-srinivas.kandagatla@linaro.org> References: <20240430091657.35428-1-srinivas.kandagatla@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1312; i=srinivas.kandagatla@linaro.org; h=from:subject; bh=RFguBTYvrqxK+fOEwZrYRQmoHKkXcXeO9yaMOm+ScGw=; b=owEBbQGS/pANAwAKAXqh/VnHNFU3AcsmYgBmMLcFDiccHI2mEf0fLCFWeIjJ/nOeJGEyIe6SJ 3Hw8oYeu+GJATMEAAEKAB0WIQQi509axvzi9vce3Y16of1ZxzRVNwUCZjC3BQAKCRB6of1ZxzRV Nyo7B/9Yc+f/HLdPowfEFdgoiSDoutDH9IxcINc9mjzDfExtHWW9WPC898DdVoCQ0HyYSIH9YcV 1mjovBkITfZDKkyq29oFhEuyVzocfjzQFWgZAKXZtrA2tCyoegkCIuB1CYmaKifuqvmuLqKpvEo uFhyhn6DsSqez6c4lAKGB9125cuWPI01bJApmXWHJ9yVSlQfMUNDY8LUHqwsFb2CwQ1sLjnZ2DJ DLYnC8ANE83NZCXZ7tqwPnv/3nFKFOTM/Xc3/afHzh4F78rt0Ycx2Q9UPEGlbI/cW1T0zCFLVt+ EQ6Q+/XQARjGBFCooBMr1UjXhCfpOmbW/dsgxIkxKV1fI6Uy X-Developer-Key: i=srinivas.kandagatla@linaro.org; a=openpgp; fpr=ED6472765AB36EC43B3EF97AD77E3FC0562560D6 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Viken Dadhaniya Currently we have auto suspend delay of 1s which is very high and it takes long time to driver for runtime suspend after use case is done. Hence to optimize runtime PM ops, reduce auto suspend delay to 100ms. Signed-off-by: Viken Dadhaniya Acked-by: Konrad Dybcio Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/qcom-ngd-ctrl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctr= l.c index a09a26bf4988..ce28ac35b2b6 100644 --- a/drivers/slimbus/qcom-ngd-ctrl.c +++ b/drivers/slimbus/qcom-ngd-ctrl.c @@ -81,7 +81,6 @@ #define SLIM_USR_MC_DISCONNECT_PORT 0x2E #define SLIM_USR_MC_REPEAT_CHANGE_VALUE 0x0 =20 -#define QCOM_SLIM_NGD_AUTOSUSPEND MSEC_PER_SEC #define SLIM_RX_MSGQ_TIMEOUT_VAL 0x10000 =20 #define SLIM_LA_MGR 0xFF @@ -1575,7 +1574,7 @@ static int qcom_slim_ngd_probe(struct platform_device= *pdev) =20 platform_set_drvdata(pdev, ctrl); pm_runtime_use_autosuspend(dev); - pm_runtime_set_autosuspend_delay(dev, QCOM_SLIM_NGD_AUTOSUSPEND); + pm_runtime_set_autosuspend_delay(dev, 100); pm_runtime_set_suspended(dev); pm_runtime_enable(dev); pm_runtime_get_noresume(dev); --=20 2.25.1 From nobody Thu Dec 18 18:04:42 2025 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E22A312836D for ; Tue, 30 Apr 2024 09:17:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714468632; cv=none; b=bjjqjRtpjbf1f9yKiKvrbTD3drE9NkryWkzPKfKpWz+WNgP2QsvlMfTZT44tOTApNwklXUT/8eyOfABT23IwA8pRUgu0DUSP0fFZbTaIHoeTOfg9kn9yUpo9p6xCgFoAecJJOTIBaqhn/HzGKYVCj3wWaETxgYE4LFsoXfydRLA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714468632; c=relaxed/simple; bh=wPFKKVDsrPqDd+T/V+mKITht1vWLOHyocwhrp50aPA8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=tDjT7aSmNNQ63W7aYk+3Grs8aKYm+IbpbxweajpxZRGxu+euvOD1NC93GJBCN1yLGNRb1WkoWOBDgNLalihNZ7LgVeMmKyXBfyJUZbbILPRTGyiWXLTn6x2WPexJB7SZjczb7iv2yYR9S+EBIFcmsasbpeUm5Yz9UgUwW6oiqec= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=weDoUmBs; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="weDoUmBs" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-41ba1ba55ebso27226105e9.1 for ; Tue, 30 Apr 2024 02:17:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1714468629; x=1715073429; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BGFQI3/jkSXT/B0m8X2PcSHRlLdy4394SU1GEz5Fywc=; b=weDoUmBsBWdU/FHkZFpM5YoiW8NE2yZ9bIbrADkG79ib+rH3RJOcZz/OdTNoD6UMwo 14E1Eef4xrbvDMsqictzDUu4clP/HpKg4FzcmafD1+0g9pTft6QlGVxd7skvRHFnQrkc 58kEwWuJTLws1ZEfSSH7imeo2Suv5X9uTCA5q/q4iloHLKV0S+Opr2/ZVDNbiyDYIxqK l7dSWM7sluLPKhDfmqnVCu5lV1pu8cKgyGqwzj9yGql5vsFBkSnoZi7swN48jPqm2Y8z VopVwu/tzKpnIuM/H5mCq4XoVo2j+GXQtjnW40uMZjM9LVZoUqkt4DhHgDudIix1vT7a CCfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714468629; x=1715073429; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BGFQI3/jkSXT/B0m8X2PcSHRlLdy4394SU1GEz5Fywc=; b=dxvxwgMTUbUfV1FkPTzniAxQhbLTQV8/2Kbqg2zevdMV+FM0iv4w9G2kfYw6V2pQ8b botbsPewWmp62JPnknP/HjKhfLAjEZBQsy8GBUGvk1skLT7xvKE86uVX2vdAvdKP/3lE alZ5YG7K6xISKQUwdS/PNBRQwEJYRx+VUxAb8LANzwpJY4NPsHnBXcfWpjiUoag/r9qy u2XHJbeTesEA6EjbCvsIAzRx9G4l7sembipzMMbGjOv6V2VI/SI/o9CAhqX4jc0bUWz8 9QBKYiNdDN7obOvGbRcRtsCcpRSvFyqC9Cr2AW26piUnFDUMCI+o6NSJQHeEecoDOJW3 sDWw== X-Gm-Message-State: AOJu0YydzpJZkT/snwYwADYRAEWVnjE4ymdO+liTWhwRNRkRXRcJ+E3b zc8gBYhsCmBL4brqZ1ZsM/KcjFwHJvbLGgziSiIDVmHuHyjyaZpfYPjqFeKS+/w= X-Google-Smtp-Source: AGHT+IFlkac9vD+lwDTdAzfmiF+SPGtbUtAvb844gQwtiIu85XBlwOqie/1vX151fRr164e+2v8i9Q== X-Received: by 2002:a05:600c:3c8a:b0:41b:6b65:4b7e with SMTP id bg10-20020a05600c3c8a00b0041b6b654b7emr11073768wmb.16.1714468629330; Tue, 30 Apr 2024 02:17:09 -0700 (PDT) Received: from localhost.localdomain ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id l6-20020a5d4106000000b0034d8b0b5329sm935513wrp.87.2024.04.30.02.17.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Apr 2024 02:17:08 -0700 (PDT) From: srinivas.kandagatla@linaro.org To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Srinivas Kandagatla Subject: [RESEND PATCH 2/3] slimbus: Convert to platform remove callback returning void Date: Tue, 30 Apr 2024 10:16:56 +0100 Message-Id: <20240430091657.35428-3-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240430091657.35428-1-srinivas.kandagatla@linaro.org> References: <20240430091657.35428-1-srinivas.kandagatla@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=3655; i=srinivas.kandagatla@linaro.org; h=from:subject; bh=NtRyxovsgrVmHg1Qgua7ounfumaZm+SHHi4WhEOBppw=; b=owEBbQGS/pANAwAKAXqh/VnHNFU3AcsmYgBmMLcFWekchStwa9kuUmpz6if9Ogt09P2t1/6Fh pN/EvtmjVqJATMEAAEKAB0WIQQi509axvzi9vce3Y16of1ZxzRVNwUCZjC3BQAKCRB6of1ZxzRV N3weB/9NbafmUyA/sjRoMgAjRYjmWCaFXo/l1cMlMwG42NVwpAHmhF1Lu8YfHX8bQszrsKtXhce 0T7NkwvwkePN6jHFLpAp86Z7kh7R5AHYsCuqrcgaZHevICrlD6JW/UOMAOwiIIAs8xD7rOor8LQ NGB38h7KhstMaLurhSImqom4++i2K9kpp9Wi+iUAWJqu0WM8MB7piaABz3+5WaHxRRzz2Xo02Te 2y/lmjlULZj/qyKZfYx3slwHvpRGuDm+fYFupJ8oFT3QztU/k/5+5ICbtUqcLicx+w+mx9zjKLs DhaW9TpugJuXnAWo2sN6LtKrIue8Ld7GPdaiGg1kqCou19Kn X-Developer-Key: i=srinivas.kandagatla@linaro.org; a=openpgp; fpr=ED6472765AB36EC43B3EF97AD77E3FC0562560D6 Content-Transfer-Encoding: quoted-printable From: Uwe Kleine-K=C3=B6nig The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert the slimbus drivers from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/qcom-ctrl.c | 5 ++--- drivers/slimbus/qcom-ngd-ctrl.c | 11 ++++------- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/slimbus/qcom-ctrl.c b/drivers/slimbus/qcom-ctrl.c index 400b7b385a44..7d632fad1300 100644 --- a/drivers/slimbus/qcom-ctrl.c +++ b/drivers/slimbus/qcom-ctrl.c @@ -626,7 +626,7 @@ static int qcom_slim_probe(struct platform_device *pdev) return ret; } =20 -static int qcom_slim_remove(struct platform_device *pdev) +static void qcom_slim_remove(struct platform_device *pdev) { struct qcom_slim_ctrl *ctrl =3D platform_get_drvdata(pdev); =20 @@ -635,7 +635,6 @@ static int qcom_slim_remove(struct platform_device *pde= v) clk_disable_unprepare(ctrl->rclk); clk_disable_unprepare(ctrl->hclk); destroy_workqueue(ctrl->rxwq); - return 0; } =20 /* @@ -721,7 +720,7 @@ static const struct of_device_id qcom_slim_dt_match[] = =3D { =20 static struct platform_driver qcom_slim_driver =3D { .probe =3D qcom_slim_probe, - .remove =3D qcom_slim_remove, + .remove_new =3D qcom_slim_remove, .driver =3D { .name =3D "qcom_slim_ctrl", .of_match_table =3D qcom_slim_dt_match, diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctr= l.c index ce28ac35b2b6..e0b21f0f79c1 100644 --- a/drivers/slimbus/qcom-ngd-ctrl.c +++ b/drivers/slimbus/qcom-ngd-ctrl.c @@ -1678,14 +1678,12 @@ static int qcom_slim_ngd_ctrl_probe(struct platform= _device *pdev) return ret; } =20 -static int qcom_slim_ngd_ctrl_remove(struct platform_device *pdev) +static void qcom_slim_ngd_ctrl_remove(struct platform_device *pdev) { platform_driver_unregister(&qcom_slim_ngd_driver); - - return 0; } =20 -static int qcom_slim_ngd_remove(struct platform_device *pdev) +static void qcom_slim_ngd_remove(struct platform_device *pdev) { struct qcom_slim_ngd_ctrl *ctrl =3D platform_get_drvdata(pdev); =20 @@ -1700,7 +1698,6 @@ static int qcom_slim_ngd_remove(struct platform_devic= e *pdev) =20 kfree(ctrl->ngd); ctrl->ngd =3D NULL; - return 0; } =20 static int __maybe_unused qcom_slim_ngd_runtime_idle(struct device *dev) @@ -1743,7 +1740,7 @@ static const struct dev_pm_ops qcom_slim_ngd_dev_pm_o= ps =3D { =20 static struct platform_driver qcom_slim_ngd_ctrl_driver =3D { .probe =3D qcom_slim_ngd_ctrl_probe, - .remove =3D qcom_slim_ngd_ctrl_remove, + .remove_new =3D qcom_slim_ngd_ctrl_remove, .driver =3D { .name =3D "qcom,slim-ngd-ctrl", .of_match_table =3D qcom_slim_ngd_dt_match, @@ -1752,7 +1749,7 @@ static struct platform_driver qcom_slim_ngd_ctrl_driv= er =3D { =20 static struct platform_driver qcom_slim_ngd_driver =3D { .probe =3D qcom_slim_ngd_probe, - .remove =3D qcom_slim_ngd_remove, + .remove_new =3D qcom_slim_ngd_remove, .driver =3D { .name =3D QCOM_SLIM_NGD_DRV_NAME, .pm =3D &qcom_slim_ngd_dev_pm_ops, --=20 2.25.1 From nobody Thu Dec 18 18:04:42 2025 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED26E12882E for ; Tue, 30 Apr 2024 09:17:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714468633; cv=none; b=pqYTMkjLgwli7d1ylfER4JxrIck8gbOfGMfkX+FtL917j1CHfDI+TuYW4oXoYG7Hu0Cjk+VFrGxVK5xlWcTSiMms/EyTjPCnJWAthll8ZsO4l6npF0+RtmqugoCsAJCmywvFQrethrfo55EpP2aJLN8oWKW5EmVE7DHMlZ5bbdQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714468633; c=relaxed/simple; bh=xSuqn+fAdV6ZfMgT5I3ml+oWj/Uip126qL5y7BtCzmw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=R3O1QN7faur4lL7nQk0cwAWzGrUUFhUXiv9XDo2CVYYAOO/eiBvvG0brNRp5ov5/t/19dFC6r3sfJU+IKg3jux7IP4d3W77/RPKMJ9EHV6vj36IL2N7PL55qWY8EvzzsY1gJREh1y4TnjMLLw/KOz9bDPJHrXYjS7yCdvp0P0g0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=bVGNn3su; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bVGNn3su" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-346359c8785so4554537f8f.0 for ; Tue, 30 Apr 2024 02:17:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1714468630; x=1715073430; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cY0Co+9vIEATAbwt7lUoR8X2/jsfO0OxFg8e/tDXAxs=; b=bVGNn3suMWa1ytSd3KcHecL9qKZh/xJAceMIOoY/nesmU84S/VmKV8oQYXzYPORFvX Y7oagoCCsMuttnv0K0p6PJWGdaVO9kZJX5RLCKna1pHlo1rNbGs0CmgRo3Jrpi2Br1rn 3wjJuOmORwptu/ZK6/cnWaHHICpdP9gKZ1c1CN1h5CGEZug6flVqE1cJTCOmDExE4q48 USwXCwv/4AbGyAHcaEWJyJEfGpVHuNdLPFq6x0CxYy4Txl+SEVsga6oifAuzxWdiSxbC WsiaC2puBtq08mpihyuxDEvyw6spfU+1tSgH3dZ7Udod6GecEbVVbZz4GdNzr7JYtg+F X9Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714468630; x=1715073430; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cY0Co+9vIEATAbwt7lUoR8X2/jsfO0OxFg8e/tDXAxs=; b=VZFY7Y4usmeIvUQNF62M2eeyxSzr+tcG1YGNLQp24flOcO3VXxRDhxtOyZwyH/TZIk nlzrhNcOnt9iNa0vMwIvQ7zjj9T1Bnm1uNZIvCpcL9dBh4FuJTyUNCNe7HAcIdmQtaIw 9s1Bny277HmQ6gcyM3BIWPM27uT70z0R2J3vuMJGhDhDmE4/6jrFM0ObUAucOX9jLJ9d shdS8ngWIixHChjRu/KUAqNAG/zvhFPNwDCSG0UDVuVtI5BA0MRqwAMuv8RX96aJGQ0c /ik6ff8r7wfHGKgVH6BoV/4SKm5fuFbZf0kPSHvla2BrrfmBTVc+HH1RKj8rhLWjlBH7 QdoA== X-Gm-Message-State: AOJu0YwPueLO+yiZ8EyOq+orQ+MKvYaht/9dhphhoh/z8DH+k4uZ+a9y 2gyrTdkfV+jNikdUsKSIq6pgptVrxrCxTpgI/2VTr6UIeqm0miMgSBZd84UFCl0= X-Google-Smtp-Source: AGHT+IE2KqW4S2n0zJPxSxytdSJ6xpYs73ekx06LtJCbvR3P+V0z3sLdHifOlDX3VavyMb/BzLkc6A== X-Received: by 2002:a5d:64c7:0:b0:34d:6ca4:abf9 with SMTP id f7-20020a5d64c7000000b0034d6ca4abf9mr1610520wri.51.1714468630482; Tue, 30 Apr 2024 02:17:10 -0700 (PDT) Received: from localhost.localdomain ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id l6-20020a5d4106000000b0034d8b0b5329sm935513wrp.87.2024.04.30.02.17.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Apr 2024 02:17:09 -0700 (PDT) From: srinivas.kandagatla@linaro.org To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Srinivas Kandagatla Subject: [RESEND PATCH 3/3] slimbus: qcom-ctrl: fix module autoloading Date: Tue, 30 Apr 2024 10:16:57 +0100 Message-Id: <20240430091657.35428-4-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240430091657.35428-1-srinivas.kandagatla@linaro.org> References: <20240430091657.35428-1-srinivas.kandagatla@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=919; i=srinivas.kandagatla@linaro.org; h=from:subject; bh=rG20qCv5FBNA7GgvWtsI9lSWTsdEuNYA3h/4sPzdDys=; b=owEBbQGS/pANAwAKAXqh/VnHNFU3AcsmYgBmMLcFGVsIUw7kTQm0StdqyL/DNqMufxbkLPrZy 5JzCpuJed2JATMEAAEKAB0WIQQi509axvzi9vce3Y16of1ZxzRVNwUCZjC3BQAKCRB6of1ZxzRV NwjCB/9FdGhVY5xT29wjinfui8NOT+qRgtgzb5wQ8PCWET38B2iH2X73igAHaFVLhd/N3tyIxtO Bn62ljIdFPUmeu7A3Gdy3cDFrxuQtYBkzMe4Xmp5egvyXGYNNZXSNACMSlwSQ9XHz/aoy8iBgNk Om30a/8+bocnzIAiBGb6wnBTC+Biq8v6VPkuKjiNIIhUennkwJYumjVecE3Rs7v/Rv13raQ0tZV w8G+txcWvM5son+14cC+xXV6syHdPkT5HId1AtTjhedjwciUMPbIQRvseN65rWnce9cPEyfgFIQ IYPbVEi1/EUeUI4g3Ra/iUDwBFBdBnBxWEvrraWZnWVSYTF3 X-Developer-Key: i=srinivas.kandagatla@linaro.org; a=openpgp; fpr=ED6472765AB36EC43B3EF97AD77E3FC0562560D6 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Krzysztof Kozlowski Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded based on the alias from of_device_id table. Pin controllers are considered core components, so usually they are built-in, however these Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/qcom-ctrl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/slimbus/qcom-ctrl.c b/drivers/slimbus/qcom-ctrl.c index 7d632fad1300..0274bc285b60 100644 --- a/drivers/slimbus/qcom-ctrl.c +++ b/drivers/slimbus/qcom-ctrl.c @@ -717,6 +717,7 @@ static const struct of_device_id qcom_slim_dt_match[] = =3D { { .compatible =3D "qcom,slim", }, {} }; +MODULE_DEVICE_TABLE(of, qcom_slim_dt_match); =20 static struct platform_driver qcom_slim_driver =3D { .probe =3D qcom_slim_probe, --=20 2.25.1