From nobody Thu Dec 18 18:04:19 2025 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFE0F128366 for ; Tue, 30 Apr 2024 08:50:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714467015; cv=none; b=bfvenfTypc/Hq5hT6koo97Z6d3aCZ2i7e1SBRcaz9grsCqes7gbs8li9+gaukrJpBC66GahcWxNr03g06+9XeJ7klim0+eiSTwstk/gmqf44DNViP50N89nidXUoaSMD1mG7n2V2M4aBNbruqgfU8sf8mwZ8VnfniKn022afZz0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714467015; c=relaxed/simple; bh=7OkAqKieBSDhAhQDX4AtdgKVwzo06pSREmFyHqNCt8w=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=FK93mjKvt60FtTQhtzVGjJOXa7R0j4kqygu/MDAvowRNOuXyaO8VL/RbYoHAJWJLb/NkLU5yM6vaywwrMch3UuDVZ28BWub7hbwxRc8jQL9BdtwiK9Bvmu9BUohGITzJefFsJiwzBHxSxf7z9b+6o6okXJRrp5/lcXPqmrXqcaE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=kkxaOIpz; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kkxaOIpz" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-34da35cd01cso88874f8f.2 for ; Tue, 30 Apr 2024 01:50:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1714467012; x=1715071812; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/JIXMZ+tmEG/2vj3SvYBH4bXcI4VlX9A3+yAB/lRDd4=; b=kkxaOIpzm9zXiCGjEXlBpxoQ5aSMhOLGIAUPTHc2N98i5oUnJRKAK/clHU4CGjsqQW NvvoYOXQlXc3G5OWMi0g8FUXfWpSEnO+E13jwUTfjIpODYl7n5pqaPEn/fHsboQQAv6I 8oaUt3eE9hxbgugdQ8pnzOOBBlEtobfWGtDIg5fLp1kvi7AhaH/k3gpim+kZ3BJPbosL vLkKJIgvm8pk5O4c8Rr2CKUF3/fQDGzpI5f80peLw5+VL7mnNe4Jh6buDWV3htPYYIhC MxipxldVdSeuTeNuS8ru/T2i9Xl0Q+I4EwCoP/WB3B8lSf1AUYaFUB2N7IpJJK5HBmX8 RdOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714467012; x=1715071812; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/JIXMZ+tmEG/2vj3SvYBH4bXcI4VlX9A3+yAB/lRDd4=; b=fOsSH8YrqObl6U72YCVjhKDiyCBtrOgB+gOejogEZuhRDDWs4jJ5MgrMld36Rva5C2 HU/VGfRp+P76XyN2m+iE/JtvZCySG3CoDnIj5walnL8y80ujgcOPGbt9gtFPJo4RgNcH mbORAI/X0sWEderrPiVxez07jJ6B0FHPD76FW5kQNv83hmt7kpwYd2vpHZ2RYQ6OEyqS RpwyrDj819C37/Di6cnR2BNsnnihCVk9EqAqFXVGdYZBlweGZHzoYWfkmDQSJqvcNTKS bRjnCsmBhmhe5yeX5vab8xHnB5ltbnv5Kj9N/FgKhmQ/8aswDw3gBvAjpmB0xPy9uZAG 665Q== X-Gm-Message-State: AOJu0YyyKV5uP/YwnpJai7gWHvUpKo9oFrqVBm5FZwiGDejTGaMZX/U5 ZYuR18m5MYH0rmKkxbk8ZMuK2mIV7gplOS3UUS+7LWGa5GvBHwJjXQI4wbH8lyY= X-Google-Smtp-Source: AGHT+IEZyZMQEkt7Qnf6sUaatu/d9B49PDHIW6yC+nBl9iPDLV0sIdkIE5KjQhJdhA9ZaivYbrSF5w== X-Received: by 2002:adf:ffc3:0:b0:343:5cca:f7c7 with SMTP id x3-20020adfffc3000000b003435ccaf7c7mr11647674wrs.41.1714467012373; Tue, 30 Apr 2024 01:50:12 -0700 (PDT) Received: from localhost.localdomain ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id p18-20020a05600c1d9200b0041bab13cd60sm14590670wms.3.2024.04.30.01.50.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Apr 2024 01:50:11 -0700 (PDT) From: srinivas.kandagatla@linaro.org To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Viken Dadhaniya , stable@vger.kernel.org, Konrad Dybcio , Srinivas Kandagatla Subject: [PATCH 1/4] slimbus: qcom-ngd-ctrl: Add timeout for wait operation Date: Tue, 30 Apr 2024 09:50:04 +0100 Message-Id: <20240430085007.33607-2-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240430085007.33607-1-srinivas.kandagatla@linaro.org> References: <20240430085007.33607-1-srinivas.kandagatla@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1428; i=srinivas.kandagatla@linaro.org; h=from:subject; bh=nY3vC2NApvFywCNrd7bStLnbD2rZAm4vIaxy7vAQZe8=; b=owEBbQGS/pANAwAKAXqh/VnHNFU3AcsmYgBmMLC8SxSURhzONPVff35OPZek/+kuuoZAp69aR UmySsZApu6JATMEAAEKAB0WIQQi509axvzi9vce3Y16of1ZxzRVNwUCZjCwvAAKCRB6of1ZxzRV N3RVB/9+LfpdRucIlrq+JZtSTP2TjtKCnPXhPTQvLFsf3NK/9EU2mHVWKv4y+aBN83eoy2Ssg8Y /gkIlo6I4uxvVlXWnyJEfyZr3eJ2o3uFTOnWSjc/CzKJQBSfLhXfUjfuD+cMoSCpzgWE6O04Kw3 F6gQBP3lLrVVGXZpTGrTjsjOhJzxXXZElDJHI1W0wPkGTSPvLGiK4kIN0y5xOF1gEnYdIoxA6cr QTNRW6faVhXmscMIHC8UNEE1fRYlArKhkYFfHTt4L66oo03rWTKpKBPz/n0vcm9GjuxXjBoYtII BHMdCAnEZbnDpfHJcJSqhZHIRQHU2+QLuuiniI8hJMhJ0Syk X-Developer-Key: i=srinivas.kandagatla@linaro.org; a=openpgp; fpr=ED6472765AB36EC43B3EF97AD77E3FC0562560D6 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Viken Dadhaniya In current driver qcom_slim_ngd_up_worker() indefinitely waiting for ctrl->qmi_up completion object. This is resulting in workqueue lockup on Kthread. Added wait_for_completion_interruptible_timeout to allow the thread to wait for specific timeout period and bail out instead waiting infinitely. Fixes: a899d324863a ("slimbus: qcom-ngd-ctrl: add Sub System Restart suppor= t") Cc: stable@vger.kernel.org Reviewed-by: Konrad Dybcio Signed-off-by: Viken Dadhaniya Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/qcom-ngd-ctrl.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctr= l.c index efeba8275a66..a09a26bf4988 100644 --- a/drivers/slimbus/qcom-ngd-ctrl.c +++ b/drivers/slimbus/qcom-ngd-ctrl.c @@ -1451,7 +1451,11 @@ static void qcom_slim_ngd_up_worker(struct work_stru= ct *work) ctrl =3D container_of(work, struct qcom_slim_ngd_ctrl, ngd_up_work); =20 /* Make sure qmi service is up before continuing */ - wait_for_completion_interruptible(&ctrl->qmi_up); + if (!wait_for_completion_interruptible_timeout(&ctrl->qmi_up, + msecs_to_jiffies(MSEC_PER_SEC))) { + dev_err(ctrl->dev, "QMI wait timeout\n"); + return; + } =20 mutex_lock(&ctrl->ssr_lock); qcom_slim_ngd_enable(ctrl, true); --=20 2.25.1 From nobody Thu Dec 18 18:04:19 2025 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10921128382 for ; Tue, 30 Apr 2024 08:50:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714467016; cv=none; b=EmVD8WbgvNoVjcm2s1MShMePWzQxODy2QYJuc1XrwyGVABAMnTILMcQGkYC0Fs6FvMcBWb6ctgyIRqmoHDIUxrLh9Z7pS7OtT2oZ2Pi2BapgdfcaI1FOLTYsneA/lDNKbQD5i4v29MHPIcLVHajO8TA98pyXZm5R1cwpucFKJtY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714467016; c=relaxed/simple; bh=kbui8HAPtLFHoAihV2ljcEUIS+VOYj9eDPfH+oMl4OE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=FKwHx2ztDtKzpbwPzuiHgV8Bn38DI7jCTuxW/9URtF/nmXfFB1CWxRg+rWQceyllGUfQdSPdsXsPmot6umWQxLikYtbb45fFKTpp7p2ktpjKE8vqb91Z28EIOpFJNNc+sAZ2BdQSb9HPzv5jbKG544iOO4Kb0bXJ7pg4ZN+eUWU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Z14H+Gug; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Z14H+Gug" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-41b2119da94so43506205e9.0 for ; Tue, 30 Apr 2024 01:50:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1714467013; x=1715071813; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Y6uTqfKoynlVxjI21T7uYyBdXiDNj2CtWTfpf3yueTA=; b=Z14H+Gug3SjA8O9bSVcw8qU1ZiGMAN5z5t/7onkBGb1uIla89qRmxKFURXXI63pg7q 3DJ/l0DgzVf77Pa+35LJAUV/AEkzdHhDCeIGT0xeBsjdp0mue4sfvyJF//K8/Tmdlz3H Y88MvoPPGjawtCzMzhi61aKKGfJo1KT/Wayb+DaA8YS20aT3ywvmkTYc6ZHGxKBFlBLs CnPv020iyR3EJ5R+qd3aoXy1BE8dXZbOwJAB8TFUx5RQI94wYhbJfIR52BaVAipChAQ/ ih0O95dCxjihAj8DY9qXUQsbaV8VE3bTLPgBEUP4pUhGWvDO3saTO/HDWLvM1PcUQXS2 l4hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714467013; x=1715071813; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y6uTqfKoynlVxjI21T7uYyBdXiDNj2CtWTfpf3yueTA=; b=JbJSAQ1800slHBsnw9MahtioHdbtuTXQW84xoMd4AIfNnvazXG4QUgpUBEuJBq+vb8 sWlGLDyL+WPGccp4t1B79IxaF3R9AMhqdxkUapzKxE9qkr+KH54DMpqO/ASJtHbKcwRU OmNwE/7gYZ9J9pWxs4/CJkn7aKhBj9TPLmA9SwdJ4DaGY6bpXKrIWPSGU3RGutiaqPs5 lS+qSYOFvciJkMEMhuIuk0jun3qkQso6U3Yx8Dwwh+js5NEy2wzT5NsVyiCp2c+gOIwI /HA98GopRyw6Eb5vV7fk57sRM6zCdJdmzC2Okq7OJOofz2a74t/WR0eJ8gEIlWLDKWQN QTRg== X-Gm-Message-State: AOJu0Yy7xQcjJnsyKQlJu3CCuXCr9Oc/D58R8FCIFl0PaBkxbsIZBMF6 1FQD6KqPYtnTLcKIwK0Scz4OWA1Vh7XyFTlLCZkEitK4vfaukIYkxldzO309QbU= X-Google-Smtp-Source: AGHT+IFqvFfPU/bksTwoGs921EUcdtwmr8d6biVghNHbSXvEpY0oGctoOJ95eP/lNSsikiT2jb+whg== X-Received: by 2002:a05:600c:a05:b0:41b:e406:5ae6 with SMTP id z5-20020a05600c0a0500b0041be4065ae6mr1722711wmp.9.1714467013510; Tue, 30 Apr 2024 01:50:13 -0700 (PDT) Received: from localhost.localdomain ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id p18-20020a05600c1d9200b0041bab13cd60sm14590670wms.3.2024.04.30.01.50.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Apr 2024 01:50:12 -0700 (PDT) From: srinivas.kandagatla@linaro.org To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Viken Dadhaniya , Konrad Dybcio , Srinivas Kandagatla Subject: [PATCH 2/4] slimbus: qcom-ngd-ctrl: Reduce auto suspend delay Date: Tue, 30 Apr 2024 09:50:05 +0100 Message-Id: <20240430085007.33607-3-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240430085007.33607-1-srinivas.kandagatla@linaro.org> References: <20240430085007.33607-1-srinivas.kandagatla@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1312; i=srinivas.kandagatla@linaro.org; h=from:subject; bh=RFguBTYvrqxK+fOEwZrYRQmoHKkXcXeO9yaMOm+ScGw=; b=owEBbQGS/pANAwAKAXqh/VnHNFU3AcsmYgBmMLC8DiccHI2mEf0fLCFWeIjJ/nOeJGEyIe6SJ 3Hw8oYeu+GJATMEAAEKAB0WIQQi509axvzi9vce3Y16of1ZxzRVNwUCZjCwvAAKCRB6of1ZxzRV N2iuB/9cHmUeup36IAovs9Qp0L4Ij8VpokiFeHpRielS9+SokQp0aHgHaEuFlvt1AaVdrW6D9Gt p0mH8A4yKPhwe0lWyaqqACVIj8hNOtyYrwx+09Xvc8zdDqzonb60NB2MNpop62vaZp8K6ZgZDvW AG3qMKgbfzCconj9PnXUqfGyD4vY/GmBRMO/wYWFha18GJWyluBmhzLkeowm3CJbpGyBhNR9bHZ YGJ4Lp2OtQg84sJe4GXQxS39aGdF2q08+H8XkQ4nLfR5UaWa/B7GHghoeR/NVPxQ88WGiSBwR+/ shf9WFhwHKlcky79l87Gr38eP4sxsp/HG+xP5LL3Rst4L4Kl X-Developer-Key: i=srinivas.kandagatla@linaro.org; a=openpgp; fpr=ED6472765AB36EC43B3EF97AD77E3FC0562560D6 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Viken Dadhaniya Currently we have auto suspend delay of 1s which is very high and it takes long time to driver for runtime suspend after use case is done. Hence to optimize runtime PM ops, reduce auto suspend delay to 100ms. Signed-off-by: Viken Dadhaniya Acked-by: Konrad Dybcio Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/qcom-ngd-ctrl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctr= l.c index a09a26bf4988..ce28ac35b2b6 100644 --- a/drivers/slimbus/qcom-ngd-ctrl.c +++ b/drivers/slimbus/qcom-ngd-ctrl.c @@ -81,7 +81,6 @@ #define SLIM_USR_MC_DISCONNECT_PORT 0x2E #define SLIM_USR_MC_REPEAT_CHANGE_VALUE 0x0 =20 -#define QCOM_SLIM_NGD_AUTOSUSPEND MSEC_PER_SEC #define SLIM_RX_MSGQ_TIMEOUT_VAL 0x10000 =20 #define SLIM_LA_MGR 0xFF @@ -1575,7 +1574,7 @@ static int qcom_slim_ngd_probe(struct platform_device= *pdev) =20 platform_set_drvdata(pdev, ctrl); pm_runtime_use_autosuspend(dev); - pm_runtime_set_autosuspend_delay(dev, QCOM_SLIM_NGD_AUTOSUSPEND); + pm_runtime_set_autosuspend_delay(dev, 100); pm_runtime_set_suspended(dev); pm_runtime_enable(dev); pm_runtime_get_noresume(dev); --=20 2.25.1 From nobody Thu Dec 18 18:04:19 2025 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F71412883A for ; Tue, 30 Apr 2024 08:50:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714467018; cv=none; b=QMjKEsC4S8Z5QDGMO1sHxDZmfR9QemBJl6Z2kM1Sk3nG1JUVQS65m7posK93PROY03OAN5Z50KaJOJzfyDbpJRzhEfOV39VB6iqgWpYU54oNic+Zrni9W+H2wbglgR3a/lJIt78nDi39eYJtmU+DWwcvNRcYI9+FVXJhSDiFGcU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714467018; c=relaxed/simple; bh=wPFKKVDsrPqDd+T/V+mKITht1vWLOHyocwhrp50aPA8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=WdbfBA+ni05KeJ3/qD9xL5HHO5XSVpM6MHYrP+/zNyL+BR/2EExdiG+zSDQt9x42ldlijbKrT/t5XHZOIXR1jDrd2vMRk8jJz90x29vUFp2SIebADN+1icAoCo2BeB0fYRqBJZ7HXgMOBBRVfxEm8zcuX7syq73DbKpi55USEhY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=bKaVu19Q; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bKaVu19Q" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-41ba1ba55ebso27045025e9.1 for ; Tue, 30 Apr 2024 01:50:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1714467015; x=1715071815; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BGFQI3/jkSXT/B0m8X2PcSHRlLdy4394SU1GEz5Fywc=; b=bKaVu19QRYS+LA8Vp3tauE3dBWOPer3uP0574+osReHi8UfMhlHesfc6DLYaqtBmiA 1DiSWcPO4eHYvIZQJ4T3fZAv6jVB+fsvoIRX8UNcKhaxzB0V6XSJGrf9tg4K+xMdy23y fAi4hQX2QWFSb3gzK/6Cs9PmEgBxI/hSdmNWYEvf2no2asg5WaEHSnm8we/MRZfEyBsU 5iaiUVH+S90R41fZLhLdaaVRfXkWgdNc3yowO6vFS9Go0gGzXFMjsoFD+Ms6xBHW7m/u RW8moZam2AZ3JTRE9v9T7eGowPcThHWyE80zTlqrWJI+4BOy3/zzuLdG6CUZ+WpisxWE 6sbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714467015; x=1715071815; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BGFQI3/jkSXT/B0m8X2PcSHRlLdy4394SU1GEz5Fywc=; b=TTfO5ELJNOzG68SHEyoFhikX3R/HGUwmKm0jU5ybUv3Ie7dKRbUTAXTXTguXHt6JV+ nuLADDCxigQ4alzq/ALguENqdJ9HERoD+NuyORka3DRaqXPxJ36dbj7NulHEtEKuq0mD Zn9DmOsXMP1vkjXFEgU2VKBiV2F/94mJiMPqJVHy8xoC79vO18+rXoNpHJ+lIyqtWu0x Weo1kJn+IVTi+TbETSDnZQHzHqZ7MENxMUnuDB/ZnVq0Pi6SFVxSJt9xPtL7f5jeNYjm 6nghsPIbEor2mqdRAItnPqoje7MHJt/AqWV7I6Hwwe/6BmKrPkj9/wqAkownfzjVb3F+ Tj/Q== X-Gm-Message-State: AOJu0Yw7+Av4mcFvsz6BUIhB5GI3XCy2CL1Gg1RuXy1ZthhrPmZLhm9V dIR4WyMj5IKf616MIId7FdJTptRt47cfY0WfmH0Qpzeq0HMqHVhhnqHzDeDGVr+lBebA0ihSqGn Z X-Google-Smtp-Source: AGHT+IGd6F69jmhJhXQnKkSPXEEw+uvKSuc88dsnLcQPHFJs0xoce4npf0oN2KGLMfSKT6aPtxsHYQ== X-Received: by 2002:a05:600c:4f11:b0:419:87ab:f6db with SMTP id l17-20020a05600c4f1100b0041987abf6dbmr10027905wmq.23.1714467014810; Tue, 30 Apr 2024 01:50:14 -0700 (PDT) Received: from localhost.localdomain ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id p18-20020a05600c1d9200b0041bab13cd60sm14590670wms.3.2024.04.30.01.50.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Apr 2024 01:50:13 -0700 (PDT) From: srinivas.kandagatla@linaro.org To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Srinivas Kandagatla Subject: [PATCH 3/4] slimbus: Convert to platform remove callback returning void Date: Tue, 30 Apr 2024 09:50:06 +0100 Message-Id: <20240430085007.33607-4-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240430085007.33607-1-srinivas.kandagatla@linaro.org> References: <20240430085007.33607-1-srinivas.kandagatla@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=3655; i=srinivas.kandagatla@linaro.org; h=from:subject; bh=NtRyxovsgrVmHg1Qgua7ounfumaZm+SHHi4WhEOBppw=; b=owEBbQGS/pANAwAKAXqh/VnHNFU3AcsmYgBmMLC8WekchStwa9kuUmpz6if9Ogt09P2t1/6Fh pN/EvtmjVqJATMEAAEKAB0WIQQi509axvzi9vce3Y16of1ZxzRVNwUCZjCwvAAKCRB6of1ZxzRV N4tfB/9OIioNcRFORt7avq6dHqwi1GLwzbaPDmlBi0IXMTNe9paihsZrC97Iblgv2UO+mJUSUJo EwO/6WnRh9Lw/eLdnJrR8GJPzM3mSBq+n/Sl67ck5zwD8tW7nAcjVSq6iCdjSJuSKigvaZWXbTt 6+v3i0tHOG3dNtiTlzmTHZnfIvzgM5KXCjp1wGLwXu/SS83GqZJ+g8pz7zhHmuM+TBeL7qzg1g6 HXRCXJAFwu9BtoZ3e4pRPF03yNk8t7s/PYCkc06SwxWXGBXdVLQqKJmW+9l0hedLjL64p3gQghZ bzFzIcOi5k6jy67WPNXaMinDlHBI6tUR8Whfy3QBsqdXNQln X-Developer-Key: i=srinivas.kandagatla@linaro.org; a=openpgp; fpr=ED6472765AB36EC43B3EF97AD77E3FC0562560D6 Content-Transfer-Encoding: quoted-printable From: Uwe Kleine-K=C3=B6nig The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert the slimbus drivers from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/qcom-ctrl.c | 5 ++--- drivers/slimbus/qcom-ngd-ctrl.c | 11 ++++------- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/slimbus/qcom-ctrl.c b/drivers/slimbus/qcom-ctrl.c index 400b7b385a44..7d632fad1300 100644 --- a/drivers/slimbus/qcom-ctrl.c +++ b/drivers/slimbus/qcom-ctrl.c @@ -626,7 +626,7 @@ static int qcom_slim_probe(struct platform_device *pdev) return ret; } =20 -static int qcom_slim_remove(struct platform_device *pdev) +static void qcom_slim_remove(struct platform_device *pdev) { struct qcom_slim_ctrl *ctrl =3D platform_get_drvdata(pdev); =20 @@ -635,7 +635,6 @@ static int qcom_slim_remove(struct platform_device *pde= v) clk_disable_unprepare(ctrl->rclk); clk_disable_unprepare(ctrl->hclk); destroy_workqueue(ctrl->rxwq); - return 0; } =20 /* @@ -721,7 +720,7 @@ static const struct of_device_id qcom_slim_dt_match[] = =3D { =20 static struct platform_driver qcom_slim_driver =3D { .probe =3D qcom_slim_probe, - .remove =3D qcom_slim_remove, + .remove_new =3D qcom_slim_remove, .driver =3D { .name =3D "qcom_slim_ctrl", .of_match_table =3D qcom_slim_dt_match, diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctr= l.c index ce28ac35b2b6..e0b21f0f79c1 100644 --- a/drivers/slimbus/qcom-ngd-ctrl.c +++ b/drivers/slimbus/qcom-ngd-ctrl.c @@ -1678,14 +1678,12 @@ static int qcom_slim_ngd_ctrl_probe(struct platform= _device *pdev) return ret; } =20 -static int qcom_slim_ngd_ctrl_remove(struct platform_device *pdev) +static void qcom_slim_ngd_ctrl_remove(struct platform_device *pdev) { platform_driver_unregister(&qcom_slim_ngd_driver); - - return 0; } =20 -static int qcom_slim_ngd_remove(struct platform_device *pdev) +static void qcom_slim_ngd_remove(struct platform_device *pdev) { struct qcom_slim_ngd_ctrl *ctrl =3D platform_get_drvdata(pdev); =20 @@ -1700,7 +1698,6 @@ static int qcom_slim_ngd_remove(struct platform_devic= e *pdev) =20 kfree(ctrl->ngd); ctrl->ngd =3D NULL; - return 0; } =20 static int __maybe_unused qcom_slim_ngd_runtime_idle(struct device *dev) @@ -1743,7 +1740,7 @@ static const struct dev_pm_ops qcom_slim_ngd_dev_pm_o= ps =3D { =20 static struct platform_driver qcom_slim_ngd_ctrl_driver =3D { .probe =3D qcom_slim_ngd_ctrl_probe, - .remove =3D qcom_slim_ngd_ctrl_remove, + .remove_new =3D qcom_slim_ngd_ctrl_remove, .driver =3D { .name =3D "qcom,slim-ngd-ctrl", .of_match_table =3D qcom_slim_ngd_dt_match, @@ -1752,7 +1749,7 @@ static struct platform_driver qcom_slim_ngd_ctrl_driv= er =3D { =20 static struct platform_driver qcom_slim_ngd_driver =3D { .probe =3D qcom_slim_ngd_probe, - .remove =3D qcom_slim_ngd_remove, + .remove_new =3D qcom_slim_ngd_remove, .driver =3D { .name =3D QCOM_SLIM_NGD_DRV_NAME, .pm =3D &qcom_slim_ngd_dev_pm_ops, --=20 2.25.1 From nobody Thu Dec 18 18:04:19 2025 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA99B1A0AE3 for ; Tue, 30 Apr 2024 08:50:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714467020; cv=none; b=o07waup+BZXySZHHIowIFuTn3KJ+rHgvc+Ekjp3+18pIcjjVWrrnS+bSBBubHqtOhIKoBSluAqH3OSrLrYwd3exq0BJ54R52YAwBtfv/u2offwvxndaNgOwX30n53yn/a5wjO5ftkaP1rsygK1/ZHiRekxoSSUAblFxSlqUz32Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714467020; c=relaxed/simple; bh=xSuqn+fAdV6ZfMgT5I3ml+oWj/Uip126qL5y7BtCzmw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=P16hF/0ypEha2KDFc0sZxcpsV0RPPzkKZyjBbVpk8kYpHrYmygpsH+XB5OobxNudC/3/hkua2DVTiyUHJGKWy2dXtoobb79Y0xw/5w+0TKDhPyhU0ImdHgW7Wuv8Q2oE5w6hln4zf6DCD3jOG618CKcfYZunAanr6/XXzgSgAko= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Mj5PgLDk; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Mj5PgLDk" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-41a1d2a7b81so36540475e9.0 for ; Tue, 30 Apr 2024 01:50:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1714467017; x=1715071817; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cY0Co+9vIEATAbwt7lUoR8X2/jsfO0OxFg8e/tDXAxs=; b=Mj5PgLDkn8osWr1x2iDaRgIm1SUgTG1fcL+iM9cSCOf9aTUB7FCZehqFyeWqhj5EYZ RL1RA+B/FylFvkJQLQZbvYTJEQSTSKm9yWqzC8qQrMPv6RSFY8L4XnzjYpdadWftHVED 0GgSewqt7jv3K7VTSAY/IVlqtWfeHfycL7PZLMC/uvlZHc2A7zR8O4PADVsD4T9z1fr/ AWox4x/51xmFIZZ2QpzPggk2y7eLyHHZcyJlUszGi6aT7+DeCCF7DpjNVsURDaH/7Ltb PqKtGEiaCfoW7wLVO1HZyKM7C1naXbVfJMaoGOEQMDzY8lzVJEQkrUAUw6SDL5ZzHlX0 5blg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714467017; x=1715071817; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cY0Co+9vIEATAbwt7lUoR8X2/jsfO0OxFg8e/tDXAxs=; b=XUkEcyHU4ZpT615f4VVvXxgXRBZzr5qlAB6CiFvKAAJL0D5SKBZcCUX834q3INi6CT QY5ffhwmunIs3O/nFus/Tvtbb8uSsByfV77v72ERIVH1OSYgPgG0Dbo9G0QmWeCF3K8Z SZBMvanXYsoh5pTwQr66IBSRgFnNck0BI8VLjmYJsIAOc8fADQtaQwiPOd7dzPQNLD/0 4AQ7xBT2SdP6PIRDssS65OEwb0jO8iXiuaIAYQYFVSD+HDHx5xcDMbil5uaCFFpkmNbl 4J56I8MNot+fgQ7Dqbnhotc7/hpPgyGxHQf2dDBdEYMB2DEE3KY7o676TO6bPV6+J2pc FMJg== X-Gm-Message-State: AOJu0Yzy0VaA1eS04S2iLN+sH1ZvFkEa/Mhyow+XUN8EJdiogDF5WcGw lyvewePXumaM8ZzWCCNwIOaTtn8LoTWI+l4PcwH5/RWcRHiWLSDB5yyjbzQ1zzk= X-Google-Smtp-Source: AGHT+IGKbGw07S8JaIkgh3KpzXnLH3iJWm2R30gQelbBwPaRgdvxyr5hacnP2l6kyNW17TKlw8V5rA== X-Received: by 2002:a05:600c:4fc3:b0:418:3ea8:46c0 with SMTP id o3-20020a05600c4fc300b004183ea846c0mr1760114wmq.13.1714467017040; Tue, 30 Apr 2024 01:50:17 -0700 (PDT) Received: from localhost.localdomain ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id p18-20020a05600c1d9200b0041bab13cd60sm14590670wms.3.2024.04.30.01.50.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Apr 2024 01:50:15 -0700 (PDT) From: srinivas.kandagatla@linaro.org To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Srinivas Kandagatla Subject: [PATCH 4/4] slimbus: qcom-ctrl: fix module autoloading Date: Tue, 30 Apr 2024 09:50:07 +0100 Message-Id: <20240430085007.33607-5-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240430085007.33607-1-srinivas.kandagatla@linaro.org> References: <20240430085007.33607-1-srinivas.kandagatla@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=919; i=srinivas.kandagatla@linaro.org; h=from:subject; bh=rG20qCv5FBNA7GgvWtsI9lSWTsdEuNYA3h/4sPzdDys=; b=owEBbQGS/pANAwAKAXqh/VnHNFU3AcsmYgBmMLC8GVsIUw7kTQm0StdqyL/DNqMufxbkLPrZy 5JzCpuJed2JATMEAAEKAB0WIQQi509axvzi9vce3Y16of1ZxzRVNwUCZjCwvAAKCRB6of1ZxzRV NwYhB/907Guw0Fn6cOkc0FVEtR6XSRM6D+PdGe4SRP2VXh45aEHaSqxQyo9QkPEakn3IySDLr7e UYd1o3D3FIxaO28YVPs8muZ8bBbiMecMSx7pAEI2CQiAxNQVUNEsxf7gHUfW/GXnjamNySrm9+Q DWDaLHd22+igjvzJcXlMQThQCAW08kIJEzLiC9l7/hDQoc7/mhTHkdpGuCqIK42YmbEf6Bk6VCn DLMSrlDLGmPlRFAzWOLBXJ+0DjZi3F+wbuaMrZXKc5bmCfSwKEc6KseaQanrYxigw5WnGtH7cWC sk5XmyfihhLEYry5tgqlrL3Eb3cxy142bN5SCTVRwRA0DWjX X-Developer-Key: i=srinivas.kandagatla@linaro.org; a=openpgp; fpr=ED6472765AB36EC43B3EF97AD77E3FC0562560D6 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Krzysztof Kozlowski Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded based on the alias from of_device_id table. Pin controllers are considered core components, so usually they are built-in, however these Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/qcom-ctrl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/slimbus/qcom-ctrl.c b/drivers/slimbus/qcom-ctrl.c index 7d632fad1300..0274bc285b60 100644 --- a/drivers/slimbus/qcom-ctrl.c +++ b/drivers/slimbus/qcom-ctrl.c @@ -717,6 +717,7 @@ static const struct of_device_id qcom_slim_dt_match[] = =3D { { .compatible =3D "qcom,slim", }, {} }; +MODULE_DEVICE_TABLE(of, qcom_slim_dt_match); =20 static struct platform_driver qcom_slim_driver =3D { .probe =3D qcom_slim_probe, --=20 2.25.1