From nobody Thu Dec 18 18:00:22 2025 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 305F43F9E0 for ; Tue, 30 Apr 2024 07:51:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714463495; cv=none; b=V2Z9iGjYL6cxBe623fpTe2LJ/6QpCl1TKlGslH/BuC8uLGBH4j4t6wXh7lcG/PM+VKbMr/HwY88UDvmJGcj96OI65qyRykXa2OABuhWBRqTRrlyjxgOwtm6EAxdQvjh3r/w3/HTOw43aWaWfOyI7CF6Sw37wvqipt2iKSRHkhGU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714463495; c=relaxed/simple; bh=0jzk6sPYQEC59SApxornkivyRflmoI1pFn43nf2gouQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FSRfbqlKkYAFv9p1FjxzAaOLDQDgpFCckDC3cD80oLjAcdlJF+8w5yhSBCSMFYZOJzQoYPLHANwFLBhj/kI5wCBv7vl8x5Qvd/oYzysk7M8VHdSnSLKbp02CSORoxucKR2yUshig+ewF6NJc1ST1egYErkpDohiVnx8RhlYHrJo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Cz1p0bF0; arc=none smtp.client-ip=209.85.160.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Cz1p0bF0" Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-436ee76c3b8so42463571cf.1 for ; Tue, 30 Apr 2024 00:51:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1714463492; x=1715068292; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=R57CjkbkLkl8A/VUwKtkzF9x/otNALa5HeVqDryNHrA=; b=Cz1p0bF0cZvCsMjrTIPFVt1HLmBH2HIu0+NPp5S5+5XMPA6hq/jvHGd2sbCx3WW4Cw WayJuW+VPXpMjYTkZ8IckXhTb11K5TmkYfrZWHGhGHVrJ751HsA//31qXDOXEoijddfz fti++wGjM8MPX4Ysf9zMhlXke1d+6Mr1Urp7s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714463492; x=1715068292; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=R57CjkbkLkl8A/VUwKtkzF9x/otNALa5HeVqDryNHrA=; b=E3anGzaXMNfhjivBMgJcNJxtj8382uD7+MOlSpmpjcMQgSDeyzYyX9q4RQyt8WHW/h blQ6BfuriKD55tbOd8c5Cr6DvrTd8ct/lLHJFZAd/kWbWOmXNLMxMt+jjcI/evGOeEAi dcRmc3R4YbyTVDz6Tu24PH0mEg6Nk0c+jZAZVSoB2/r67ix7i3327kjBoZASukRAgoSr xKcQj4qcmNRalhtiZxAsQ24Y8jWJ91m5CuV08PVUUAHlk0lN4vhePski1FCeD1AL1rFd W9EeGni0iVc/NYMzt4gSkoz7BocY8jfkflEUQ/OlnbbQoKyAnKSkgp+jBIH03Vf5RYYs 6Qcw== X-Forwarded-Encrypted: i=1; AJvYcCUYWlAi5G5qzxnbdE0a0XtznzexxoKRyci6Yv4CoWuihFITQHRcNU6L7FHxtx+LwcuFlH5SgLm//EiZAxgpEPhSpatwDM/w/7PnyCVA X-Gm-Message-State: AOJu0YzbEliNXCoOnVRi4EQ/hinLRcS/ZYohhwPkO7xmh1urlnvGdOHX nLs873cWbCHG6LSDYYhhvsyoPIPgUFqLvUzpkXSUjnR2rxK0OsEP973QS+VONg== X-Google-Smtp-Source: AGHT+IFox+JJPaIDfnbJPXdvKCOIVMCsX59wRzBpWnMawbJcnJD3u85NhlKUJm+Q/1EmXzvmqcrFDg== X-Received: by 2002:a05:622a:1b86:b0:43b:dd6:82c0 with SMTP id bp6-20020a05622a1b8600b0043b0dd682c0mr3500422qtb.33.1714463492092; Tue, 30 Apr 2024 00:51:32 -0700 (PDT) Received: from denia.c.googlers.com (114.152.245.35.bc.googleusercontent.com. [35.245.152.114]) by smtp.gmail.com with ESMTPSA id z11-20020a05622a124b00b00437b4048972sm10634547qtx.18.2024.04.30.00.51.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Apr 2024 00:51:31 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 30 Apr 2024 07:51:26 +0000 Subject: [PATCH 1/3] media: bcm2835-unicam: Fix error handling for platform_get_irq Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240430-fix-broad-v1-1-cf3b81bf97ff@chromium.org> References: <20240430-fix-broad-v1-0-cf3b81bf97ff@chromium.org> In-Reply-To: <20240430-fix-broad-v1-0-cf3b81bf97ff@chromium.org> To: Mauro Carvalho Chehab , Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden Cc: linux-media@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Hans Verkuil , Ricardo Ribalda X-Mailer: b4 0.12.4 platform_get_irq() cannot return the value 0. If it returns -EPROBE_DEFER, we need to populate the error code upwards to retry probing once the irq handler is ready. Signed-off-by: Ricardo Ribalda --- drivers/media/platform/broadcom/bcm2835-unicam.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/broadcom/bcm2835-unicam.c b/drivers/med= ia/platform/broadcom/bcm2835-unicam.c index bd2bbb53070e..2a3a27ac70ba 100644 --- a/drivers/media/platform/broadcom/bcm2835-unicam.c +++ b/drivers/media/platform/broadcom/bcm2835-unicam.c @@ -2660,9 +2660,10 @@ static int unicam_probe(struct platform_device *pdev) } =20 ret =3D platform_get_irq(pdev, 0); - if (ret <=3D 0) { + if (ret < 0) { dev_err(&pdev->dev, "No IRQ resource\n"); - ret =3D -EINVAL; + if (ret !=3D -EPROBE_DEFER) + ret =3D -EINVAL; goto err_unicam_put; } =20 --=20 2.44.0.769.g3c40516874-goog From nobody Thu Dec 18 18:00:22 2025 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 620C6405F8 for ; Tue, 30 Apr 2024 07:51:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714463495; cv=none; b=SQ/tZN2e4R6w9P5iezySm0iV2hxHutKhIa1Qyc/m9zzsnc9W48+og9x6xE0zkCu+NYQKx9QTTT0eqS8jqd3YR52NYBoOqpkNHmLWShfk5ZZYLEcxgHENKqV0Nuc7BQEK0akDuxWUSX0BuTobqXEfiQAOFajNJWMCyciCty2ZT4Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714463495; c=relaxed/simple; bh=Klt3S7xZdueUFKS1wHESrOilkdR+oLUPuosQlgJLtQo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=I7a3lQNJWEzORuDVlpJfKFUClOXFjcdEd9uHOlB2Kbowhk19VpWZ+BTxAyzHxCKobmRZGCYSRON2rn+B4bqkM2oA6ulCR3hW2E9AhlFTVLgvGoTiNVVnB0GTEwHtNVuS29rIEvPZx7W+KHTbt23pMc5xp6It4euLw5g6tf9r+aY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=MS+/3cno; arc=none smtp.client-ip=209.85.160.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="MS+/3cno" Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-43ab8e0f435so7745171cf.1 for ; Tue, 30 Apr 2024 00:51:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1714463493; x=1715068293; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dyrqsw7hfapafht5q6ARwJmOBtyDG2HfDsUwyULf8rA=; b=MS+/3cno0/pf5WnMUBO7mL6WZuNvK3C/r4FwzdttZcebGs0rTXO1HI3DcSgYMgWG6g sbnGNHmkoxjfukAooBSOK0GgyCgTwJxNx5Lcn9b5No1A22LU4B5rLwfS5kQPXl0SZLpW bKbh40nAGBuYHktm1BBa0y1c4XNBvw/4Idgks= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714463493; x=1715068293; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dyrqsw7hfapafht5q6ARwJmOBtyDG2HfDsUwyULf8rA=; b=OHfhebk0IsB0PavNb3/FpBdgxKmrdLk8Hj+1A+n5IcHExJ9GtxAy1KxDKdO+b0T58h bs+Vc1kMwQ3Eg2s1+2t+FPAtZGPFLEKWW7nRSFkXvC2zvTomi/YCu/TV12wBOXgPzgZP /BtI001dxOwW+t0H9SM7Dc+dWxpVjpJKXrrg2ws+y5vR9VmTGp33UOEjd6608AFohQ9b CE1Q56hqYexlC29jSx0GO6Lc2WwTx5YtTHPsyjrHLlXcv1+wwnz2mUxKSdPtMq/xd6zW F0LQaQcXq6d7jy84dMJ5c4QEzKEJ6SzHdvymgfygXto6qKWL0QZHuTkQK/srma0LFfZQ Ebzw== X-Forwarded-Encrypted: i=1; AJvYcCWI3KQCwbQCLjBEO9UkuNZx3DTOGnZijgwB9qpAeOoZjscoQXNJyprrQOD/7DJ/7cycPAXTDd3v4vM7WQAyOdS5uYzTprfFAwWxxGq4 X-Gm-Message-State: AOJu0YzQ1IYB/OWC/4SW9Cw85HEzcTDFxdRgxmeEBwpTTP/66HXZAWoi Lp4vT2IPTElGFrBTjBp6HJHGKrZyTnKRRV+1Q5PGXsPFjo70eO3NZhV1vvWHLg== X-Google-Smtp-Source: AGHT+IECfMNRuKAOBTGNP1xzyMsseRJw3Hkb0lRny7MABhW2k54/n2V9s46e7u1H3Xer9VaXIy6adA== X-Received: by 2002:a05:622a:4d2:b0:43b:c4:4188 with SMTP id q18-20020a05622a04d200b0043b00c44188mr4041838qtx.41.1714463493327; Tue, 30 Apr 2024 00:51:33 -0700 (PDT) Received: from denia.c.googlers.com (114.152.245.35.bc.googleusercontent.com. [35.245.152.114]) by smtp.gmail.com with ESMTPSA id z11-20020a05622a124b00b00437b4048972sm10634547qtx.18.2024.04.30.00.51.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Apr 2024 00:51:32 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 30 Apr 2024 07:51:27 +0000 Subject: [PATCH 2/3] media: bcm2835-unicam: Do not print error when irq not found Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240430-fix-broad-v1-2-cf3b81bf97ff@chromium.org> References: <20240430-fix-broad-v1-0-cf3b81bf97ff@chromium.org> In-Reply-To: <20240430-fix-broad-v1-0-cf3b81bf97ff@chromium.org> To: Mauro Carvalho Chehab , Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden Cc: linux-media@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Hans Verkuil , Ricardo Ribalda X-Mailer: b4 0.12.4 platform_get_irq() already prints an error for us. Fixes cocci: drivers/media/platform/broadcom/bcm2835-unicam.c:2664:2-9: line 2664 is red= undant because platform_get_irq() already prints an error Signed-off-by: Ricardo Ribalda Reviewed-by: Laurent Pinchart --- drivers/media/platform/broadcom/bcm2835-unicam.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/platform/broadcom/bcm2835-unicam.c b/drivers/med= ia/platform/broadcom/bcm2835-unicam.c index 2a3a27ac70ba..b2b23d24da19 100644 --- a/drivers/media/platform/broadcom/bcm2835-unicam.c +++ b/drivers/media/platform/broadcom/bcm2835-unicam.c @@ -2661,7 +2661,6 @@ static int unicam_probe(struct platform_device *pdev) =20 ret =3D platform_get_irq(pdev, 0); if (ret < 0) { - dev_err(&pdev->dev, "No IRQ resource\n"); if (ret !=3D -EPROBE_DEFER) ret =3D -EINVAL; goto err_unicam_put; --=20 2.44.0.769.g3c40516874-goog From nobody Thu Dec 18 18:00:22 2025 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7ECBD45BE8 for ; Tue, 30 Apr 2024 07:51:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714463496; cv=none; b=ogvuvlfimFz59QJNE/lvqhvWbXewPrKx48YrRupCI7J8bW4ReQISr6vZxRjA8zIyfs4D9U5NskVPmPR4mNZC5P7yvfKkvPi/rGQiKIDvlLpje9HDOnO2WnLf2S4k4U8axHL9hPIxcbobgCZgiGEeBb4skXJ2jyVNVj2M1zEXNlw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714463496; c=relaxed/simple; bh=tZr2bao3WLdMwTCauupdLvKoK/nOZz2ObARGCJxQaCc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YBeQQWGl+/4dYdebrwkEDCLB569s7zFhAKw7kLICyP/TwtFNrlKFxVsbDMZyVJvX/2TTnNKqzc2zjwNsq/HQezPQQOEkplPUcl6nHC78rJiaTK0rpn9hAVHrLZE9R9krXPD5vWShblsB8nS1Q/se3osjhMoBMfcng5dhARaMpjM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=NTk6PAD8; arc=none smtp.client-ip=209.85.160.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="NTk6PAD8" Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-43716ff5494so57188971cf.0 for ; Tue, 30 Apr 2024 00:51:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1714463494; x=1715068294; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=4cXQjmuyZkvWHadrmTQe5KOC06n35bYtQrARXW4y+Vw=; b=NTk6PAD8bP1NbEspcS8TzdIrpDY5MbqefDtzOarY0OyA/HZR/vBHcqtomVk30wi1mj RHAasUNfPH/wYJOksReH/wO/HDnLei2f5FI6YlPakKhllVHnRtkGWw49GQqgiONVZ53l lYDrXgI6G9VWf7UENAGm29bCDZPcpYOxogMq0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714463494; x=1715068294; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4cXQjmuyZkvWHadrmTQe5KOC06n35bYtQrARXW4y+Vw=; b=G8YxmYVrQCGVnKYPM+30Xzjy+wIhJ1QtXikDM5EwGtOC7OrJvGualAdayUDrIvg7UP AVcVhWp8DGcOdMew1if1BdwVruUUcijaoc2gDEWnGFuZ3/NidgCOwW/0YBO+ho9xi54y QDa1tISIqZpnlKvGKY3esbk2CM3AB5r7IWHvv5TaZeO3fLwr5zuBPj/Jfd02JtHCU9W/ dWz9eoes1uysHkrZA8OIURXHWydhAdmvW4x6a/3SVJN1DFqZ9gK0Fl95T/5SsfUCR7kB U0qbfii1lbq55Jox2EfFzdvGgkNXO0BfxNkaJfGaj640sp0VoIIsxVt17BtLdJVCORLX ngrA== X-Forwarded-Encrypted: i=1; AJvYcCWGGPuZyYP52ou8+iZ24aJ8VaSjOjMkf5dQFthXPqnRJLoF9+HwBZ4n+vlvRv/jaAVbRjALk+BO2FpM1P6ibULcnrrW5AI9uwNut5Fp X-Gm-Message-State: AOJu0YzjqojtLwsLA8zB56Boe6fA0SFcaT4yNPvNFy+pjPldQEakkHs2 bm8DH3RaUFfaeCPP8Bp94rIJZMe0ogixwD3qAZ2wTbC5lBxAwHUSz01YVb7Skg== X-Google-Smtp-Source: AGHT+IHJbt+AhqT6dvcQLRTeZ4YlJCvCSrE+7BncIk5ueTVJMqXmIFfvv1LVEly8aKIAOwJjytQtBA== X-Received: by 2002:a05:622a:1895:b0:43a:c90b:34e5 with SMTP id v21-20020a05622a189500b0043ac90b34e5mr3440108qtc.34.1714463494446; Tue, 30 Apr 2024 00:51:34 -0700 (PDT) Received: from denia.c.googlers.com (114.152.245.35.bc.googleusercontent.com. [35.245.152.114]) by smtp.gmail.com with ESMTPSA id z11-20020a05622a124b00b00437b4048972sm10634547qtx.18.2024.04.30.00.51.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Apr 2024 00:51:33 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 30 Apr 2024 07:51:28 +0000 Subject: [PATCH 3/3] media: bcm2835-unicam: Do not replace IRQ retcode during probe Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240430-fix-broad-v1-3-cf3b81bf97ff@chromium.org> References: <20240430-fix-broad-v1-0-cf3b81bf97ff@chromium.org> In-Reply-To: <20240430-fix-broad-v1-0-cf3b81bf97ff@chromium.org> To: Mauro Carvalho Chehab , Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden Cc: linux-media@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Hans Verkuil , Ricardo Ribalda X-Mailer: b4 0.12.4 Use the error code generated by platform_get_irq() and devm_request_irq() as the error code of probe(). It will give a more accurate reason of why it failed. Signed-off-by: Ricardo Ribalda --- drivers/media/platform/broadcom/bcm2835-unicam.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/media/platform/broadcom/bcm2835-unicam.c b/drivers/med= ia/platform/broadcom/bcm2835-unicam.c index b2b23d24da19..0b2729bf4a36 100644 --- a/drivers/media/platform/broadcom/bcm2835-unicam.c +++ b/drivers/media/platform/broadcom/bcm2835-unicam.c @@ -2660,17 +2660,13 @@ static int unicam_probe(struct platform_device *pde= v) } =20 ret =3D platform_get_irq(pdev, 0); - if (ret < 0) { - if (ret !=3D -EPROBE_DEFER) - ret =3D -EINVAL; + if (ret < 0) goto err_unicam_put; - } =20 ret =3D devm_request_irq(&pdev->dev, ret, unicam_isr, 0, "unicam_capture0", unicam); if (ret) { dev_err(&pdev->dev, "Unable to request interrupt\n"); - ret =3D -EINVAL; goto err_unicam_put; } =20 --=20 2.44.0.769.g3c40516874-goog