From nobody Sun Feb 8 01:52:26 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31F57768EF for ; Mon, 29 Apr 2024 13:01:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714395718; cv=none; b=rrsmb1NqSw6ptjczGU2F3VPnlg36EBlrKnMObZ1nTNdygwQovl2XtFFYaNKwafVj6/Fm7Ck9phD/9ahAbSrhHIATxwv1XSInCA9K+GVUn9uZhnBvgz5Wn0S62cc2J0ysJH+cXVGTZ4f4pwC40amud3MlPBUwlB1AVLqT2/2lz/c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714395718; c=relaxed/simple; bh=NfZcypoD1CZ34fuMUBVKQlaVjj4H35Y4xSOcxQL65lQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cQXqB9nYqo2XYGdND0CcdUhyF/0Wa/+SPuLO4JxQMPVYXUPDppmubiSG5xonz8kyNN0VOZGx0P1NBKASrp+8VzlWwTTD8aqtYI0YBIWKmIho/dp6KMXeeaKR0JcQoCnO1Y/KY+oHFxm1W44+GjTS/e1xKO9FuFyLVkUDbmsX1/M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=O8apVw3Q; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="O8apVw3Q" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714395717; x=1745931717; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=NfZcypoD1CZ34fuMUBVKQlaVjj4H35Y4xSOcxQL65lQ=; b=O8apVw3Qo9RPJJm7sNr/5/0LJcvqtrSeDqdSG1zGlj+MueggdLOtyVvT medO8iZQ3PHgq9xf4niKorJEg7IsdX85M1ZhZrjJTzM+orKjs1nreB1aw 8sy7nmnfSH/kKYizWomERBTWaeSUCmEjgIkppvneqaNvFEpc4O0u8g5Bx A1SnxKKTE0L5cGz2zlEyHqSU0JbvYo3PNA65u0EZRb7ogVAyLw4ukq+Xb AocD1xSsCmAwGXGCzl80ElyDCV5B3TrLuQLI0XE3UvZW3k4onHK9s1u/y k7wGEy6gmL7VFUEzv4lsK/C3tTkeKQ0VKbol0RTG+hZXySzxQh+PRXk5P A==; X-CSE-ConnectionGUID: I8dmqWhWSCifDXvg2nGTIQ== X-CSE-MsgGUID: s2lWpEFGSJ2skGjfCFJ9fA== X-IronPort-AV: E=McAfee;i="6600,9927,11057"; a="12986892" X-IronPort-AV: E=Sophos;i="6.07,239,1708416000"; d="scan'208";a="12986892" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2024 06:01:56 -0700 X-CSE-ConnectionGUID: xho7eiCgR3uwaHCBL6rwXQ== X-CSE-MsgGUID: ljapeiPYR+6ztpyeJkJ3EQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,239,1708416000"; d="scan'208";a="26507087" Received: from black.fi.intel.com (HELO black.fi.intel.com.) ([10.237.72.28]) by orviesa006.jf.intel.com with ESMTP; 29 Apr 2024 06:01:54 -0700 From: Alexander Shishkin To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Li Zhijian , Alexander Shishkin , Andy Shevchenko Subject: [PATCH v1 07/15] intel_th: Convert sprintf/snprintf to sysfs_emit Date: Mon, 29 Apr 2024 16:01:11 +0300 Message-ID: <20240429130119.1518073-8-alexander.shishkin@linux.intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240429130119.1518073-1-alexander.shishkin@linux.intel.com> References: <20240429130119.1518073-1-alexander.shishkin@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Li Zhijian Per filesystems/sysfs.rst, show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. coccinelle complains that there are still a couple of functions that use snprintf(). Convert them to sysfs_emit(). sprintf() will be converted as weel if they have. Generally, this patch is generated by make coccicheck M=3D MODE=3Dpatch \ COCCI=3Dscripts/coccinelle/api/device_attr_show.cocci No functional change intended Signed-off-by: Li Zhijian Signed-off-by: Alexander Shishkin Reviewed-by: Andy Shevchenko --- drivers/hwtracing/intel_th/gth.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/hwtracing/intel_th/gth.c b/drivers/hwtracing/intel_th/= gth.c index b3308934a687..3883f99fd5d5 100644 --- a/drivers/hwtracing/intel_th/gth.c +++ b/drivers/hwtracing/intel_th/gth.c @@ -154,9 +154,9 @@ static ssize_t master_attr_show(struct device *dev, spin_unlock(>h->gth_lock); =20 if (port >=3D 0) - count =3D snprintf(buf, PAGE_SIZE, "%x\n", port); + count =3D sysfs_emit(buf, "%x\n", port); else - count =3D snprintf(buf, PAGE_SIZE, "disabled\n"); + count =3D sysfs_emit(buf, "disabled\n"); =20 return count; } @@ -332,8 +332,8 @@ static ssize_t output_attr_show(struct device *dev, pm_runtime_get_sync(dev); =20 spin_lock(>h->gth_lock); - count =3D snprintf(buf, PAGE_SIZE, "%x\n", - gth_output_parm_get(gth, oa->port, oa->parm)); + count =3D sysfs_emit(buf, "%x\n", + gth_output_parm_get(gth, oa->port, oa->parm)); spin_unlock(>h->gth_lock); =20 pm_runtime_put(dev); --=20 2.43.0