From nobody Fri Dec 19 10:39:31 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EEFC54919 for ; Mon, 29 Apr 2024 12:09:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.19 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714392568; cv=none; b=aEiajFyDwpcxyZwa1jZinIHoSHA4uXqD7vCLziuX3vCHO9CtRkk22dPycoynvlw32AAOJQxedTudJYwGLifwUszR/+MWpZTiSyTyArGtzFwNdPlBJFPIR7husU11uzJAbkYfeVQexQdD/KCYFG9AN0STcSHJNzsXwVpCDklAtxs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714392568; c=relaxed/simple; bh=NfZcypoD1CZ34fuMUBVKQlaVjj4H35Y4xSOcxQL65lQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Lv9iBMjKCkPh1N4b1rJiQ6PqEEatc4sAvVZK29luI4WDG96PtTTWKK+WsZIMcyDqA44+gD2pM6rJnFQzUKrFp9URhQPZJsVYkMwuLLkSuIwh0Lx1wOGL1a2h1AAYv1cx0KgzlAzH/cXS95qj4jUMmdoLwM/aWGKgjZxev0888WA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=U4/0xUXY; arc=none smtp.client-ip=198.175.65.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="U4/0xUXY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714392568; x=1745928568; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=NfZcypoD1CZ34fuMUBVKQlaVjj4H35Y4xSOcxQL65lQ=; b=U4/0xUXYLiXM7tNClTzaDxPtFeskchT9N6RhKnyac69XFnlY+UHug5uC LNkN/7wn+X4NgBXcvccKWTbbrRpGI/GHKDdNRmzYSDJ+BmAJoJSvbLZeY TjnxSu++GQVOJuW+IsdivWlv41XMlURlvKHzTrNNkXHZODIrlvpBDhwYv Bq9n5/VqpcRuWPl/qQ+ZGciDzH/95X54axJ5JDW1np28qAA2zhalz9yLU 5eE84w03H3lq+yxmEOshTOJwhBa/t7iAE/do1TGkgRblboCyE1BkoWI91 RGcgrxXQBPVkxt5x+jinnjSmyoRPUN53Er7iW/DxNSxmeaoVGNg0OLBaU g==; X-CSE-ConnectionGUID: EcZN3ZbzTg2eaxRl6hf3tw== X-CSE-MsgGUID: Glqko+JXSh+dIZBPspGETw== X-IronPort-AV: E=McAfee;i="6600,9927,11057"; a="9908249" X-IronPort-AV: E=Sophos;i="6.07,239,1708416000"; d="scan'208";a="9908249" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2024 05:09:27 -0700 X-CSE-ConnectionGUID: jGbHB7zUSOm2Cra/AexmAQ== X-CSE-MsgGUID: d4ABijVXQX+IkYWI/rcQBA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,239,1708416000"; d="scan'208";a="26166625" Received: from black.fi.intel.com (HELO black.fi.intel.com.) ([10.237.72.28]) by fmviesa010.fm.intel.com with ESMTP; 29 Apr 2024 05:09:25 -0700 From: Alexander Shishkin To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Li Zhijian , Alexander Shishkin , Andy Shevchenko Subject: [PATCH 06/14] intel_th: Convert sprintf/snprintf to sysfs_emit Date: Mon, 29 Apr 2024 15:09:00 +0300 Message-ID: <20240429120908.3723458-7-alexander.shishkin@linux.intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240429120908.3723458-1-alexander.shishkin@linux.intel.com> References: <20240429120908.3723458-1-alexander.shishkin@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Li Zhijian Per filesystems/sysfs.rst, show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. coccinelle complains that there are still a couple of functions that use snprintf(). Convert them to sysfs_emit(). sprintf() will be converted as weel if they have. Generally, this patch is generated by make coccicheck M=3D MODE=3Dpatch \ COCCI=3Dscripts/coccinelle/api/device_attr_show.cocci No functional change intended Signed-off-by: Li Zhijian Signed-off-by: Alexander Shishkin Reviewed-by: Andy Shevchenko --- drivers/hwtracing/intel_th/gth.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/hwtracing/intel_th/gth.c b/drivers/hwtracing/intel_th/= gth.c index b3308934a687..3883f99fd5d5 100644 --- a/drivers/hwtracing/intel_th/gth.c +++ b/drivers/hwtracing/intel_th/gth.c @@ -154,9 +154,9 @@ static ssize_t master_attr_show(struct device *dev, spin_unlock(>h->gth_lock); =20 if (port >=3D 0) - count =3D snprintf(buf, PAGE_SIZE, "%x\n", port); + count =3D sysfs_emit(buf, "%x\n", port); else - count =3D snprintf(buf, PAGE_SIZE, "disabled\n"); + count =3D sysfs_emit(buf, "disabled\n"); =20 return count; } @@ -332,8 +332,8 @@ static ssize_t output_attr_show(struct device *dev, pm_runtime_get_sync(dev); =20 spin_lock(>h->gth_lock); - count =3D snprintf(buf, PAGE_SIZE, "%x\n", - gth_output_parm_get(gth, oa->port, oa->parm)); + count =3D sysfs_emit(buf, "%x\n", + gth_output_parm_get(gth, oa->port, oa->parm)); spin_unlock(>h->gth_lock); =20 pm_runtime_put(dev); --=20 2.43.0