From nobody Thu Sep 19 23:22:04 2024 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4571F129A6B for ; Mon, 29 Apr 2024 15:05:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714403121; cv=none; b=S5OvDaqMNGkrdNyKAFuqNKp2Oqhz7sTCnSF1A6F0sk3fbTv465OurWEZ1b6x0qOyqAiYdKjQ4w3bRDcFamvFgjfA/9ekOtE3sQgkZpT+Mv8DlrMp8baZN3ZAJTm3nbs9yrp146z3YMNnKbGIxDystKSRvsBLA2mmPo4QoLB9vYY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714403121; c=relaxed/simple; bh=o6W/vqiRX5/Lnl4n/KralCP6cqo+hBRj8ijp3AUHwA0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=o9FV9TMLKs5WZbm9Gx7wdKvrf4xoOIJN0RRF/sJYF1/WnuIWzEgh57WMISpAz+2Iq6b2tIQ2VaCwhz/d8p2w+rD3rEKystuBFHS5AcqBTBLDafjlEDW7rftZm3PM9Hy83IBrjunnnsx5L9wzgBSBGOcUS3JKEKg8f3g05iGiLmw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=W+V1pyMU; arc=none smtp.client-ip=209.85.222.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="W+V1pyMU" Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-79100a90868so29725085a.2 for ; Mon, 29 Apr 2024 08:05:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1714403111; x=1715007911; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=vmuUSFnHzqjHSVO6x2xCi4IdU77yIJvh23Ivq0XCHvQ=; b=W+V1pyMU/pnRfJkgi4LCSV4mUqTbVT83LYrZeCJb938fWxHKuhrCsccd3CuhlwQfPP 226aTPb53vFC3gPaJDYBQuuhcj1A+/gA4dyma6X/eD8XCNOiapVAfUEj58Y2QXbfnHxx diuNjYqFLxnmUJqwX3fLr6k7vrMivTqUlBfgA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714403111; x=1715007911; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vmuUSFnHzqjHSVO6x2xCi4IdU77yIJvh23Ivq0XCHvQ=; b=bMlBb1xWl8NtDwu0L0bjZpju1XHvzWgc7pATk6onU2je2aYLM0gd3eUAIbm533Pe1X WxnpaqSn/iYujFBRXSia0KhnTm5Y3HaVObaMc6DtnCoBrybbxFWRqo92pRQ7MEJ9kLsK AJ/uRIGx0RQC/ihhXWE3/JkDShLsQN0F5eHLS53kmbVw25PxBR2kaU6LeiINh6e2eXp9 JN1VHN08q+xOpfKIBOpzaz+q1lSFZ062qSO3Y33jGzbBdvPVDsTmVTpSGwwieFCHIDP4 imz8swsYV3CVtk4u4ZdGZHEOlKffkv0wsq+FHBDwjVXyRQmT+cgUb8KQrU50KVeVeJ3/ F2hQ== X-Forwarded-Encrypted: i=1; AJvYcCXlUImXBiYjG8YpnyE4BEOLmkyXFfP8lS6QLookj6SlMaVKuHVzcayf80zlL0ZFrmgRYEUM6a11i6AAADiLjsuK+P8Y8OdZHnN3/ftN X-Gm-Message-State: AOJu0Yze+YaaeYJRtfCcnNIIaeacGb4nVXQE0kNTklilzCaO+qTL6Bul Ll3Cec1pmp1+ycrHJIOO40vlEhVEOoVvCRGqOuJRO9ut/zkokAcg2JcHXhLXcA== X-Google-Smtp-Source: AGHT+IH9sz0tcRc5gxc3Hn2yH4aEBZFdiRiwY4P/N3aVh4I90x1YrGS0c1n2StA1reM2wgrnpB/ryg== X-Received: by 2002:a05:620a:1665:b0:790:9e62:787f with SMTP id d5-20020a05620a166500b007909e62787fmr11023549qko.28.1714403110567; Mon, 29 Apr 2024 08:05:10 -0700 (PDT) Received: from denia.c.googlers.com (114.152.245.35.bc.googleusercontent.com. [35.245.152.114]) by smtp.gmail.com with ESMTPSA id p7-20020a05620a056700b0078d3b9139edsm10568591qkp.97.2024.04.29.08.05.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Apr 2024 08:05:10 -0700 (PDT) From: Ricardo Ribalda Date: Mon, 29 Apr 2024 15:05:04 +0000 Subject: [PATCH v3 25/26] media: dvb-frontends: tda10048: Fix integer overflow Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240429-fix-cocci-v3-25-3c4865f5a4b0@chromium.org> References: <20240429-fix-cocci-v3-0-3c4865f5a4b0@chromium.org> In-Reply-To: <20240429-fix-cocci-v3-0-3c4865f5a4b0@chromium.org> To: Martin Tuma , Mauro Carvalho Chehab , Laurent Pinchart , Hugues Fruchet , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Paul Kocialkowski , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Sergey Kozlov , Abylay Ospan , Ezequiel Garcia , Dmitry Osipenko , Benjamin Mugnier , Sylvain Petinot , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda , Dan Carpenter X-Mailer: b4 0.12.4 state->xtal_hz can be up to 16M, so it can overflow a 32 bit integer when multiplied by pll_mfactor. Create a new 64 bit variable to hold the calculations. Reported-by: Dan Carpenter Signed-off-by: Ricardo Ribalda --- drivers/media/dvb-frontends/tda10048.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/media/dvb-frontends/tda10048.c b/drivers/media/dvb-fro= ntends/tda10048.c index 5d5e4e9e4422..3e725cdcc66b 100644 --- a/drivers/media/dvb-frontends/tda10048.c +++ b/drivers/media/dvb-frontends/tda10048.c @@ -410,6 +410,7 @@ static int tda10048_set_if(struct dvb_frontend *fe, u32= bw) struct tda10048_config *config =3D &state->config; int i; u32 if_freq_khz; + u64 sample_freq; =20 dprintk(1, "%s(bw =3D %d)\n", __func__, bw); =20 @@ -451,9 +452,11 @@ static int tda10048_set_if(struct dvb_frontend *fe, u3= 2 bw) dprintk(1, "- pll_pfactor =3D %d\n", state->pll_pfactor); =20 /* Calculate the sample frequency */ - state->sample_freq =3D state->xtal_hz * (state->pll_mfactor + 45); - state->sample_freq /=3D (state->pll_nfactor + 1); - state->sample_freq /=3D (state->pll_pfactor + 4); + sample_freq =3D state->xtal_hz; + sample_freq *=3D state->pll_mfactor + 45; + do_div(sample_freq, state->pll_nfactor + 1); + do_div(sample_freq, state->pll_pfactor + 4); + state->sample_freq =3D sample_freq; dprintk(1, "- sample_freq =3D %d\n", state->sample_freq); =20 /* Update the I/F */ --=20 2.44.0.769.g3c40516874-goog