From nobody Fri Dec 19 12:31:32 2025 Received: from out-177.mta0.migadu.com (out-177.mta0.migadu.com [91.218.175.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59E0D146583 for ; Sat, 27 Apr 2024 20:37:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714250228; cv=none; b=X5RE7bnsZ0kLufQfk7gaVMO4O2VgTfCg2AsKA5ioDcS2/hLWLyDDExAfcgkuJRx8KqQklFDQvfgvHGbIAw3xYXFLHGUx9C9u2BUGkU2FyRVXsCy6mpIHc3J8AB7hD5fJJzvxdi2cCkMUlxBjr5tww7loXNNlqJTk9swLXPqbF48= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714250228; c=relaxed/simple; bh=84vNZ3nmzMiKLywUCaQxMOTyHtj96UqMDq9BjY9biKM=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=tqSs2uXocF83G/LwglncaY/KgCfzZ1u9nB1MzhZOWtOZGPJGM1GqAavwVGHun5j6xv9B+pviWA1luK2gjOy7DWFU0sprsHgi5zqOUGsb30urWcj4Ha1EXTY7OpxAl1vuG2FRt+5hUu9kroUZ0GOIGiMNuHsYIVoYksiovXfwSLU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=fDPRGa20; arc=none smtp.client-ip=91.218.175.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="fDPRGa20" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1714250224; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=89hBKLXcLRSTgQwaDLYQQNky8U7DVywScwGQ66L4gss=; b=fDPRGa20xofVpruZB625R2dpAIcxLgCl9awbjtM1HUfw0QFK/ACYmv9nhUFlyMgdwc0L4U RyrmD6QxHRO7v45wBWrM7Enfm1AMycU6E9HlejPHCGMuJzR786sLc32zlnr2om6BNq88pM FqKc/vIBrT1kw0JYKWDXAuzinkv2H0E= From: Sui Jingfeng To: Andy Shevchenko Cc: linux-acpi@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Sui Jingfeng , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J. Wysocki" Subject: [PATCH v3] software node: Implement device_get_match_data fwnode callback Date: Sun, 28 Apr 2024 04:36:50 +0800 Message-Id: <20240427203650.582989-1-sui.jingfeng@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" Because the software node backend of the fwnode API framework lacks an implementation for the .device_get_match_data function callback. This makes it difficult to use(and/or test) a few drivers that originates from DT world on the non-DT platform. Implement the .device_get_match_data fwnode callback, which helps to keep the three backends of the fwnode API aligned as much as possible. This is also a fundamental step to make a few drivers OF-independent truely possible. Device drivers or platform setup codes are expected to provide a software node string property, named as "compatible". At this moment, the value of this string property is being used to match against the compatible entries in the of_device_id table. It can be extended in the future though. Fixes: ffb42e64561e ("drm/tiny/repaper: Make driver OF-independent") Fixes: 5703d6ae9573 ("drm/tiny/st7735r: Make driver OF-independent") Signed-off-by: Sui Jingfeng --- Cc: Andy Shevchenko Cc: Daniel Scally Cc: Heikki Krogerus Cc: Sakari Ailus Cc: Greg Kroah-Hartman Cc: "Rafael J. Wysocki" --- v1 -> v2: Update commit message v2 -> v3: Move a loop invariant conditional out of while clause --- drivers/base/swnode.c | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c index eb6eb25b343b..b6f40715c4f8 100644 --- a/drivers/base/swnode.c +++ b/drivers/base/swnode.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include #include @@ -390,6 +391,33 @@ static void software_node_put(struct fwnode_handle *fw= node) kobject_put(&swnode->kobj); } =20 +static const void * +software_node_get_match_data(const struct fwnode_handle *fwnode, + const struct device *dev) +{ + struct swnode *swnode =3D to_swnode(fwnode); + const struct of_device_id *matches =3D dev->driver->of_match_table; + const char *val =3D NULL; + int ret; + + ret =3D property_entry_read_string_array(swnode->node->properties, + "compatible", &val, 1); + if (ret < 0 || !val) + return NULL; + + if (!matches) + return NULL; + + while (matches->compatible[0]) { + if (!strcmp(matches->compatible, val)) + return matches->data; + + ++matches; + } + + return NULL; +} + static bool software_node_property_present(const struct fwnode_handle *fwn= ode, const char *propname) { @@ -676,6 +704,7 @@ software_node_graph_parse_endpoint(const struct fwnode_= handle *fwnode, static const struct fwnode_operations software_node_ops =3D { .get =3D software_node_get, .put =3D software_node_put, + .device_get_match_data =3D software_node_get_match_data, .property_present =3D software_node_property_present, .property_read_int_array =3D software_node_read_int_array, .property_read_string_array =3D software_node_read_string_array, --=20 2.34.1