From nobody Mon Feb 9 09:10:21 2026 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B30E175A5 for ; Thu, 25 Apr 2024 22:34:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714084460; cv=none; b=tye5c2dnpd12sJ++wnUnc0FDpQvsxU/0lYJjKsCRC3QASvLu41dnXZk0WPapIoOl4D+Z+1OsWwGQisvbrDGvkXYBZHnnAGSw+k3S34UDqXexEDJSmI5kY9oTocE62X6qESmel25P5Z0J1XAMn6hOmwBsNMKY95ZqhpVctwdsB3Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714084460; c=relaxed/simple; bh=dphi9qBP63ALc85YmSjwCdzNIVpfkRQLHJHQrbhmr1k=; h=Date:In-Reply-To:Message-Id:Mime-Version:References:Subject:From: To:Content-Type; b=lRQw6qYawkahuEryNosd3f4KJTHXWJF09Kr/EWDSb959WKYS/z5wnYDawjPk2O7VRfRvWUv0zsYWBC/XGlzTBtTec3XlIh7UhrPvKjRIw57R0AAQMKQpkttWG+JN6o18r3dMmfOp4UrYlHkH5zfjB+nHlX2XfzCwye0CYL1VU9c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=2amSNHXc; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="2amSNHXc" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-dcdc3db67f0so3457295276.1 for ; Thu, 25 Apr 2024 15:34:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1714084457; x=1714689257; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=PRyB6ZTPXeEQyqvBeQnDzSQ3aoVG6ArsSOU0946h4+I=; b=2amSNHXcRHIuqrk5p78qfYCdZuvrfmWEnVxzH037tSXvS7iyCUKXnuuJmw8br7kZqS vIQgqLW+oYNsN/v7YmgCkfGJN5C12yNuWyUWHZcVQg/Rdc4A8tJZJkR4w6DBDgcsaVlY vtJJmezZKTKGO4zhcvwLupF0uwW/GHzcMp9yT888fSsfQd9nA7nwJ964WYaRr4drS5HT +8pYrJkbr1jXoah5ZxQFePrlFP20oMgl4KAQtmanYUPXg1jvuMHIXOMBPKM9/osACd7V 5PQnk2ZZFt6E2poZp4qIzv/9MqjO8enI8pVfPniATMI4LOZ4WryceomMy2wTII/gVaKl rhQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714084457; x=1714689257; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PRyB6ZTPXeEQyqvBeQnDzSQ3aoVG6ArsSOU0946h4+I=; b=tewJWBfJo42Q6T+Lik4/+JTG9oXset3YZObDi8hGtg9c/5tnb+yHWxmMJVxMcGV+GV cBVJh47Mi8y9jelDsxODgDKvo9Mcklf0lCvODLwaDXy3a4DXRSNsVAXvDtAwkFX9v97N BKsggG6GtNIpNblTSADAkbVe0JjQr3G/qyE2ASRCAID7UAEggZQmGVg+4U78kjH/EgpN ozJjJlShUtQeOKZOtngtAXOwE9M7/nTkOt2ws+Q7DcD9YhrNtsQIrbeOEarlQ9tdYm6f szdcMJ6VagxpJdNZRG95M2cg7ToS1nK22+IGwPHo29QaoL0IZQXCc5xOQ0U6aAXU+qFH 6DGA== X-Forwarded-Encrypted: i=1; AJvYcCVAmYe5wjotKIQz7ekCUIFnXPOT+xBMl40ph/a1oEaV5cg/nQ/5Nso3O8ZQ2qcXBzhT3cglTWzRBgvew6FtjxN4C4YsfuRowZmeDxrN X-Gm-Message-State: AOJu0YzLdukg7Q8uLLMu9NvFV8N+enDpzm1b87+fH35LGskoXOvvAVJX My8cBv+4LA8yETbiykLoC/BX5M27E+5eJyfMJEkcria0Tz80nxIZY0wzRYFH1wxhQWZ+6CEpmb7 Yi2Cf4g== X-Google-Smtp-Source: AGHT+IEQ/sIEgXuPsq1khlWSJrM0X0hALhujw4KeoPWU3mHHONJFz2LIsLabZBngG/PF7TMXMHovH8xNLJZ4 X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:8708:517d:aade:8c87]) (user=irogers job=sendgmr) by 2002:a05:6902:c04:b0:dd9:2782:d1c6 with SMTP id fs4-20020a0569020c0400b00dd92782d1c6mr339697ybb.1.1714084457578; Thu, 25 Apr 2024 15:34:17 -0700 (PDT) Date: Thu, 25 Apr 2024 15:34:04 -0700 In-Reply-To: <20240425223406.471120-1-irogers@google.com> Message-Id: <20240425223406.471120-2-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240425223406.471120-1-irogers@google.com> X-Mailer: git-send-email 2.44.0.769.g3c40516874-goog Subject: [RFC PATCH v1 1/3] perf evsel: Don't open tool events From: Ian Rogers To: weilin.wang@intel.com, Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Ze Gao , Leo Yan , Ravi Bangoria , Dmitrii Dolgov <9erthalion6@gmail.com>, Song Liu , James Clark , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Tool events are set up as software dummy events. Don't open them to save some work and a file descriptor. The evsel's fds are initialized to -1, so it suffices to just early return. --- tools/perf/util/evsel.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index 3536404e9447..2743d40665ff 100644 --- a/tools/perf/util/evsel.c +++ b/tools/perf/util/evsel.c @@ -2005,6 +2005,11 @@ static int evsel__open_cpu(struct evsel *evsel, stru= ct perf_cpu_map *cpus, int pid =3D -1, err, old_errno; enum rlimit_action set_rlimit =3D NO_CHANGE; =20 + if (evsel__is_tool(evsel)) { + /* Tool events are set up as dummy but don't need opening. */ + return 0; + } + err =3D __evsel__prepare_open(evsel, cpus, threads); if (err) return err; --=20 2.44.0.769.g3c40516874-goog