From nobody Sat Jul 11 14:54:25 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C066A149E12 for ; Thu, 25 Apr 2024 14:27:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714055235; cv=none; b=icFASeGvgGWJHZTqe92BNuXQh/IjIsewRTpmGmenlp2qw9C/Omj/+IT3fPpdyIM2KeoC5VA/nEvPmK7p4jsjghOm5iUsU4IUaPH3WQpaHZ9urvaOwZY/3GV2DQQrLT42og9fidmltNnVLVzZR5uPBR6g/9leIrlSS88i7T9Awis= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714055235; c=relaxed/simple; bh=yCTUM4VsZP0XLCbKY2nqBkSXSRXgEYSN4aDZAwo5Ukk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MPKMMjXoUHt84L63UiZ2HPIY3YL7rwu/dp9jptXu8tJ/kMJIbC24aRkdDhMUrGfIoxsHPouR7jpZdoLy2uDPVdS3D9Gi8r9ZJBS9gD1XZD0LRSQAKOtxby4dhi5asELWvUEu9X4TE4XDGMZgl5C7DtT21JGFU7wg4h67ckB8Jl0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=fFCHFRuo; arc=none smtp.client-ip=192.198.163.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="fFCHFRuo" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714055234; x=1745591234; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=yCTUM4VsZP0XLCbKY2nqBkSXSRXgEYSN4aDZAwo5Ukk=; b=fFCHFRuoXN5hpvjNy9aRVjZP19yNF7/ZY9Ab8qIDPp1+BiJMYkeqXjSi VJ1EaAdfAEAImOTAnKOTxGsIK1nt8JUaGf0004Q17bOEez86pjYDGNAPv r6WRYl91TQI7Fc49zk94UlU1vUxZbhmV5Ls7VA3N9rPVSK16/1a0bnLX0 0ckdGlpnPBrV3jMixgi1ZakWOuIDtSyN2LdVq2qWCMJcU8JvKYJvQI7Bv rJx4wkL+F0NiXYju8UDrTeJj9F3+JVkWWQeXe9ayHNmjrSZcTgGSy6Gth KIxvq6gUoPsQjksqoXkW7bjrFMN7jo0rNmUB1EYa2+KCWEItscRF3nosu g==; X-CSE-ConnectionGUID: xXlaOA3xSW64g3NUvwe2Tg== X-CSE-MsgGUID: bdkyfbmaQGi7uxUE0NAfKA== X-IronPort-AV: E=McAfee;i="6600,9927,11055"; a="10281349" X-IronPort-AV: E=Sophos;i="6.07,229,1708416000"; d="scan'208";a="10281349" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2024 07:27:11 -0700 X-CSE-ConnectionGUID: TtSjRNFfSuaq2PIeMrhhNA== X-CSE-MsgGUID: QIpqLtBDQr+fLUQUN0w7mw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,229,1708416000"; d="scan'208";a="29555176" Received: from black.fi.intel.com ([10.237.72.28]) by fmviesa003.fm.intel.com with ESMTP; 25 Apr 2024 07:27:08 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 0BCD3F4; Thu, 25 Apr 2024 17:27:06 +0300 (EEST) From: Andy Shevchenko To: Neil Armstrong , Randy Dunlap , Andy Shevchenko , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter Subject: [PATCH v1 1/3] drm/panel: ili9341: Correct use of device property APIs Date: Thu, 25 Apr 2024 17:26:17 +0300 Message-ID: <20240425142706.2440113-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1336.g36b5255a03ac In-Reply-To: <20240425142706.2440113-1-andriy.shevchenko@linux.intel.com> References: <20240425142706.2440113-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" It seems driver missed the point of proper use of device property APIs. Correct this by updating headers and calls respectively. Fixes: 5a04227326b0 ("drm/panel: Add ilitek ili9341 panel driver") Signed-off-by: Andy Shevchenko Reviewed-by: Dmitry Baryshkov Reviewed-by: Neil Armstrong --- drivers/gpu/drm/panel/Kconfig | 2 +- drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index e54f6f5604ed..2d4515555820 100644 --- a/drivers/gpu/drm/panel/Kconfig +++ b/drivers/gpu/drm/panel/Kconfig @@ -177,7 +177,7 @@ config DRM_PANEL_ILITEK_IL9322 =20 config DRM_PANEL_ILITEK_ILI9341 tristate "Ilitek ILI9341 240x320 QVGA panels" - depends on OF && SPI + depends on SPI select DRM_KMS_HELPER select DRM_GEM_DMA_HELPER depends on BACKLIGHT_CLASS_DEVICE diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm= /panel/panel-ilitek-ili9341.c index 3574681891e8..7584ddb0e441 100644 --- a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c @@ -22,8 +22,9 @@ #include #include #include +#include #include -#include +#include #include #include =20 @@ -691,7 +692,7 @@ static int ili9341_dpi_probe(struct spi_device *spi, st= ruct gpio_desc *dc, * Every new incarnation of this display must have a unique * data entry for the system in this driver. */ - ili->conf =3D of_device_get_match_data(dev); + ili->conf =3D device_get_match_data(dev); if (!ili->conf) { dev_err(dev, "missing device configuration\n"); return -ENODEV; --=20 2.43.0.rc1.1336.g36b5255a03ac From nobody Sat Jul 11 14:54:25 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3051D149DE6 for ; Thu, 25 Apr 2024 14:27:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714055233; cv=none; b=uwgex3VmhpKX24TrdylxiuViAMi5S1P8H15LeyDQAMtZvTcjmBNXVfYC2KddGLjoDHKEdGExOwW9kZ4Z1YduKEF65p+ru8PKHPRV4QsVO1dsXJg3FIbLbzA8CUdXXuLgBET7p7BJQE5riU43Cmh+Oirh7P83QhG1wiwF/E5sfqM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714055233; c=relaxed/simple; bh=gxYu0C20vsruH6KE+KGqY9pjeOljO8yEKIpRfI6XilA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=av+ywS61xb1EhCDj9mmti1JSkjyz5dJlgyKkyF8rrvop9rxbipZD7vn6yLmZVleJCC0UrNzD1rr+/oW/AmcDN4NZ4y9RNvll93rUIn0hEwnxuDZ3GhfSLBE19S8Ot15AnoNP9Nsay4+mqCn+6WY5A/DyGDjKuk8+ZxGTXYoUnJs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=GMgLITST; arc=none smtp.client-ip=192.198.163.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="GMgLITST" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714055232; x=1745591232; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=gxYu0C20vsruH6KE+KGqY9pjeOljO8yEKIpRfI6XilA=; b=GMgLITSTkyShaM7vETLq8V40CCgrj4bTEvcG41TibxWbA9e2coxAuKKG fsdLXX0ISnPxSJK5CXzwHRn7cqIRHO6KBHhArOyUerQSytvJEIqvm5nQe T4Pi/VHqnG/WwwunQw7a/mhB9Q9LKBeP9jH9gMrvhyzJECQR68NVHrRl9 nzNwlaoUAsK9eYuqvcVPuc91JNhegtjzHdeggz3f4ipXSoBf9XMran0SB aqke3/0tUIhE+1sTb4BuS9emAQg10JOrBtXkl/cGLMGj8haefXo/tSCAv Rg6dzFtuQf6thxC182AhBF+to0EcEkMC5Vd/+mvVNJMY4wkEVbjYX6V0k Q==; X-CSE-ConnectionGUID: HwyjHCJUR0exGooOTM46sw== X-CSE-MsgGUID: HiCpKd1vSfibFSL9Ql8eyQ== X-IronPort-AV: E=McAfee;i="6600,9927,11055"; a="10281339" X-IronPort-AV: E=Sophos;i="6.07,229,1708416000"; d="scan'208";a="10281339" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2024 07:27:11 -0700 X-CSE-ConnectionGUID: csIbbWLGSHKzrTne17MmPg== X-CSE-MsgGUID: UEcpJTBwQpqCWYq4MAO2JQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,229,1708416000"; d="scan'208";a="29555175" Received: from black.fi.intel.com ([10.237.72.28]) by fmviesa003.fm.intel.com with ESMTP; 25 Apr 2024 07:27:08 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 11A04586; Thu, 25 Apr 2024 17:27:07 +0300 (EEST) From: Andy Shevchenko To: Neil Armstrong , Randy Dunlap , Andy Shevchenko , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter Subject: [PATCH v1 2/3] drm/panel: ili9341: Respect deferred probe Date: Thu, 25 Apr 2024 17:26:18 +0300 Message-ID: <20240425142706.2440113-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1336.g36b5255a03ac In-Reply-To: <20240425142706.2440113-1-andriy.shevchenko@linux.intel.com> References: <20240425142706.2440113-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" GPIO controller might not be available when driver is being probed. There are plenty of reasons why, one of which is deferred probe. Since GPIOs are optional, return any error code we got to the upper layer, including deferred probe. With that in mind, use dev_err_probe() in order to avoid spamming the logs. Fixes: 5a04227326b0 ("drm/panel: Add ilitek ili9341 panel driver") Signed-off-by: Andy Shevchenko Reviewed-by: Dmitry Baryshkov Reviewed-by: Neil Armstrong Reviewed-by: Sui Jingfeng --- drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm= /panel/panel-ilitek-ili9341.c index 7584ddb0e441..24c74c56e564 100644 --- a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c @@ -715,11 +715,11 @@ static int ili9341_probe(struct spi_device *spi) =20 reset =3D devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); if (IS_ERR(reset)) - dev_err(dev, "Failed to get gpio 'reset'\n"); + return dev_err_probe(dev, PTR_ERR(reset), "Failed to get gpio 'reset'\n"= ); =20 dc =3D devm_gpiod_get_optional(dev, "dc", GPIOD_OUT_LOW); if (IS_ERR(dc)) - dev_err(dev, "Failed to get gpio 'dc'\n"); + return dev_err_probe(dev, PTR_ERR(dc), "Failed to get gpio 'dc'\n"); =20 if (!strcmp(id->name, "sf-tc240t-9370-t")) return ili9341_dpi_probe(spi, dc, reset); --=20 2.43.0.rc1.1336.g36b5255a03ac From nobody Sat Jul 11 14:54:25 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C44A14A09A for ; Thu, 25 Apr 2024 14:27:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714055235; cv=none; b=N9NdhIhdwr4LSXOhLkVfRx5A0iOBzjMtep9iYBd3L+IU4wrOgZJ09dGzhAx9Q04H8yLJlkFqkD+fcOYgReVu/ricHIsO2KwmX6W/fykiD6UC37n9qC1IO3GiicAIzuaYSvxL4f6km54p7/7YkCeojbeKbO/Y7YXBXBFjOJ2SUqw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714055235; c=relaxed/simple; bh=Wqkixd+I8NnZZhvtO5vNvN0lkMlJWXalpNMQ17i+pvY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FGFYHVJkrX5FlupRMB2uooNOqJsE1jzfOxz26ZS41htfv8hkVmUnrpjMhc4uZZdQsksdoutiHCni2a56TlGbqRBNCB0qdU4uHau+I8pT7Jbp2PvCjbcoTHxN+clJkDFwg/YdTskCQfuLpkU7fxAH4M+52M267zWkwELOA3meekQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=dKWg8Ru6; arc=none smtp.client-ip=192.198.163.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="dKWg8Ru6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714055234; x=1745591234; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Wqkixd+I8NnZZhvtO5vNvN0lkMlJWXalpNMQ17i+pvY=; b=dKWg8Ru66myzIbdtJuEDhSdDiDjLBlfxfni8rgpov2N7efnXdCjrO2gO SjtMh5c8/QiBwBNTFIxpn20b+95NMmJgBooqTAELkgF1cJ95vc3kDibQs PvpdjiPraf/QYFqhR93vgBv7yIoG+456lYEriCJbRUsmadpiiHEqtNpAp RpSCoyHrz8qFcCJP1GBfaTFdRmFV1j/4imtA3YoimODr+YaBPOsJ/HWHp 4RDz6Fzr8mLSHn0XLTitIf2rusQxD/CUm8ZvHaSmqOXDEyWlNYu1HzDo+ PJAgnckrXjt9QoUHR088VQd0zx1GU7ZTgbx5GXH/N4RQc7UAszcXdcRIE A==; X-CSE-ConnectionGUID: xEIUaNQMREa1qEOq3K2t1A== X-CSE-MsgGUID: V/rD0k+8TGygrnN8cpGxSw== X-IronPort-AV: E=McAfee;i="6600,9927,11055"; a="10281363" X-IronPort-AV: E=Sophos;i="6.07,229,1708416000"; d="scan'208";a="10281363" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2024 07:27:11 -0700 X-CSE-ConnectionGUID: l5RaI+T3Q36ko0vgLIA/hA== X-CSE-MsgGUID: b22RoA9cQ1CL9Ir+2tJIjg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,229,1708416000"; d="scan'208";a="56027430" Received: from black.fi.intel.com ([10.237.72.28]) by orviesa002.jf.intel.com with ESMTP; 25 Apr 2024 07:27:08 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 1C3E079F; Thu, 25 Apr 2024 17:27:07 +0300 (EEST) From: Andy Shevchenko To: Neil Armstrong , Randy Dunlap , Andy Shevchenko , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter Subject: [PATCH v1 3/3] drm/panel: ili9341: Use predefined error codes Date: Thu, 25 Apr 2024 17:26:19 +0300 Message-ID: <20240425142706.2440113-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1336.g36b5255a03ac In-Reply-To: <20240425142706.2440113-1-andriy.shevchenko@linux.intel.com> References: <20240425142706.2440113-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In one case the -1 is returned which is quite confusing code for the wrong device ID, in another the ret is returning instead of plain 0 that also confusing as readed may ask the possible meaning of positive codes, which are never the case there. Convert both to use explicit predefined error codes to make it clear what's going on there. Fixes: 5a04227326b0 ("drm/panel: Add ilitek ili9341 panel driver") Signed-off-by: Andy Shevchenko Reviewed-by: Neil Armstrong Reviewed-by: Sui Jingfeng --- drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm= /panel/panel-ilitek-ili9341.c index 24c74c56e564..b933380b7eb7 100644 --- a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c @@ -422,7 +422,7 @@ static int ili9341_dpi_prepare(struct drm_panel *panel) =20 ili9341_dpi_init(ili); =20 - return ret; + return 0; } =20 static int ili9341_dpi_enable(struct drm_panel *panel) @@ -726,7 +726,7 @@ static int ili9341_probe(struct spi_device *spi) else if (!strcmp(id->name, "yx240qv29")) return ili9341_dbi_probe(spi, dc, reset); =20 - return -1; + return -ENODEV; } =20 static void ili9341_remove(struct spi_device *spi) --=20 2.43.0.rc1.1336.g36b5255a03ac