From nobody Sat Jul 11 14:56:03 2026 Received: from mail-oa1-f51.google.com (mail-oa1-f51.google.com [209.85.160.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C96F514A605 for ; Thu, 25 Apr 2024 15:03:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714057419; cv=none; b=jcUzDOsiez871OFyTBnzWffkvEbCZKZr1ApydPgsiNM9WlFXM4yzg2QY8YWTFoM+THaFpllAWcSZQBj1ro124AYZqJfezw0t5Q9uin0LCDLsjj1AJszM9S/QKUostkLUiDEG0sQfwBqZ6x/N0t7oBjKsIdIhGbmsvVSLaP0T0/w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714057419; c=relaxed/simple; bh=Tsa8/Wzig6FNUfuFlRIUELjsQKPsOH3Pulp9FrfGw6Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=vAQ7c3uoCL/ZbMzH9juII4ubt0tWhwbF5lZy3Z/h3tcmyOwLioAPUqp2/Dp5hRFYSxgB6aiIPuop1dQ6j/9YGxDNmvnSex2tiwTNOvb0c/XU0pahtU9nL9RPzjIYoJaXHvR+OnBW7/Qwu/PmbUbH+eTPNpPKDCrX+F3iAReUhlA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=SmiKmF2S; arc=none smtp.client-ip=209.85.160.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="SmiKmF2S" Received: by mail-oa1-f51.google.com with SMTP id 586e51a60fabf-233e41de0caso600262fac.0 for ; Thu, 25 Apr 2024 08:03:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1714057415; x=1714662215; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GHHT3V3NAkn80zT3ZwzVgbMDW8DV/51JYCXCI4YMBAU=; b=SmiKmF2SkD/BZUvZPccQMXBK9J0xIYh+u5CHbb32k7yqi7ZmCoj2/LHiJEqVra2gps 7BQWKXF3v7ADpENGe8PPrsop4Z2PnzphPt1pKsQaJcEgY/aJxhzY5AIwfiMD95XFuBdc t4Mf/VWCw9yANI2ZEsVHuQCdp1mAuPPnzxJ4eB3T2VszzpbrxdCqHuShQ6Ssa3G1BBGi PMleiFcNjz9CL137aYOGJeULxmwHxRWWphSyi1ZfFV4SjoGTXxTFnWSH9045L5FOD82k QJG943vaJemk0Br/BrEKYNifCtjZ6FOpMTW0SrhN2j4aUK5yPYKs0jb7ta5k6FV7/mE3 KvIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714057415; x=1714662215; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GHHT3V3NAkn80zT3ZwzVgbMDW8DV/51JYCXCI4YMBAU=; b=VyXCmQZ/3AIKjkOrOGdHzjl4C3ZvUgFWtLzzg6sHlmv2tCAp8ZYGa7r+vTR7RrHmtQ b2xGXsb0JE53aFFXmRM31J3oFePaCH/q3MsGnIlAvypyPpQ0I9xUT3oLf5oYrFXYDnlJ 549UEgg7x8rIT668piHTUvyYACCgoct/X+XOMgcAht+JEsHc+zpgFQlRrEL9uyTySaRk A3sRPaXS4hd4fGvfm0oVIzcYvtXkRikTGz3XQi6P6/lF68iws+PvccX5+7NlLIrgqJoi Mquh5bxWhKQereTWJZ9yk2H4qjE1oJdX9A8umD3bgicqD9v3+w4CQcYzgtOIPouF6GhJ ckDw== X-Forwarded-Encrypted: i=1; AJvYcCVp8185OxC8ejX+nweciCrDlEk2hh6W9OXQeZ6wYhTOmtANRnwRmzr0jC6mD+BpBi/bpM4gZ3FvC9iiKsvRytimE0GrzuVwsPfCjA9w X-Gm-Message-State: AOJu0YwRagCFa7DdACYnCcQtSez9Y6chvnwRG8PmV5R86OgWMfz3yS9a jNLNMjotuwJ/oPBZkoMD7D89OBwgIk4dQjIoalC/aoSjZ+cTxE2pYfjLlLZ7HNw= X-Google-Smtp-Source: AGHT+IGKUzbiZmA4xkuzW4Obu31RHZOeYQIUKpUb81CCZ1vyHCvuVjk+AQ/mnzT8PDS0gPeY3MKOiA== X-Received: by 2002:a05:6871:b13:b0:22e:c787:5fa2 with SMTP id fq19-20020a0568710b1300b0022ec7875fa2mr6465784oab.58.1714057414871; Thu, 25 Apr 2024 08:03:34 -0700 (PDT) Received: from freyr.lechnology.com (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id mp2-20020a056871328200b0023b6d4723edsm166739oac.14.2024.04.25.08.03.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Apr 2024 08:03:34 -0700 (PDT) From: David Lechner To: Jonathan Cameron Cc: David Lechner , Lars-Peter Clausen , Michael Hennerich , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/3] iio: adc: ad7266: don't set masklength Date: Thu, 25 Apr 2024 10:03:27 -0500 Message-ID: <20240425-b4-iio-masklength-cleanup-v1-1-d3d16318274d@baylibre.com> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240425-b4-iio-masklength-cleanup-v1-0-d3d16318274d@baylibre.com> References: <20240425-b4-iio-masklength-cleanup-v1-0-d3d16318274d@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Mailer: b4 0.12.4 Content-Transfer-Encoding: quoted-printable The masklength field is marked as [INTERN] and should not be set by drivers, so remove the assignment in the ad7266 driver. __iio_device_register() will populate this field with the correct value. Signed-off-by: David Lechner --- drivers/iio/adc/ad7266.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/iio/adc/ad7266.c b/drivers/iio/adc/ad7266.c index 468c2656d2be..353a97f9c086 100644 --- a/drivers/iio/adc/ad7266.c +++ b/drivers/iio/adc/ad7266.c @@ -371,7 +371,6 @@ static void ad7266_init_channels(struct iio_dev *indio_= dev) indio_dev->channels =3D chan_info->channels; indio_dev->num_channels =3D chan_info->num_channels; indio_dev->available_scan_masks =3D chan_info->scan_masks; - indio_dev->masklength =3D chan_info->num_channels - 1; } =20 static const char * const ad7266_gpio_labels[] =3D { --=20 2.43.2 From nobody Sat Jul 11 14:56:03 2026 Received: from mail-oa1-f42.google.com (mail-oa1-f42.google.com [209.85.160.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5484A14A604 for ; Thu, 25 Apr 2024 15:03:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714057419; cv=none; b=DfKoi2r6MBHzkjHMgdWqOnfGRTbSLvKmRKE2y3m2RvCm3TTYjFMFGVhVknBj7IcIwft7N30IGCQNJMnwO+09e1qOUQcFt3r/6QJDDJrYEHdh1la0xQQXdMMcP9sUsggaoSJ8f0iaD/4/bJhEkmvqcKIQRFyJwRvZgSid1Y0LLI0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714057419; c=relaxed/simple; bh=c0UVqkjMuNtarShlxI0bIDMYPsBOuAUJ6QeQyiAWEuY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=FqmWsIdowrCxo/cWB521GdhTjmlgmM7Cxo2sHAz2xUoL2c4GtXiN3+Aqq+3j8lEqgKNyS9JDNI9rr19fvl/7S+c4rokObQ6/qTXLyJZa6zlzc1YehiS/t47URPtLyyoDrx65THyKeZ0/Q2gwiDVUymnfW/Jy/kQxol/p+LI/Els= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=lYm5AtCr; arc=none smtp.client-ip=209.85.160.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="lYm5AtCr" Received: by mail-oa1-f42.google.com with SMTP id 586e51a60fabf-22fa7e4b0beso474301fac.1 for ; Thu, 25 Apr 2024 08:03:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1714057416; x=1714662216; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FuUgN+eqDnD1TSwHoUcLirGapuP4idukeuGNZ2DNfLI=; b=lYm5AtCr7ClXsH4zVnZ7RefhauWfTi6b3MRzk5sA9543gVL5jRqOaiUiUffW0Tcstt /dciL2CXA9/9BOvD3xvt9/ODK+pyoK6MSI/I0jaCQ8BhDBiVHAwR3oM71QiHVEPU11Kj 61XRfoylO6ui1TM8dl+dCj6U+nPQqm+NgnmxD+O98aKihv65YvXji0oJHRweIy3ugACJ oC+sWjqiXHxQpE7WreUN10iv6LZ3Iv9FDIqrkqjcQzBstPS/VaWykDWt+G7fmx7cYDjl rzM9icX9Oka5gT0ugLLIZV3pnf64nuWWxO8U15BqSF7by2iWlod9mcyTrkWbZMZi3JKw k0Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714057416; x=1714662216; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FuUgN+eqDnD1TSwHoUcLirGapuP4idukeuGNZ2DNfLI=; b=JV1OCQF/OIZm/cOImPDNNaI1yeRNZ9s/4uSIyGBOefBRlVMo5OfuCWxqPlknao/0mO bzVzkyG2q2XD62606HK6IoAtxdhmJP7qx9GjzWVvwU1e8rSCoc2dvnwj/edZXfVjStw5 K3Y4FZ39lH/ueegrr+jAQikIXs0cclCzE2F58aaWdoJcBGTKMlB/dVrZqspzLPIOL+qO hbtLCxa7QqtSjBjQnHqQy+waoHY9Me6c6YJoM/97SO93tSl9xdDlCOQi9mZdA7JhGkES JeeoeqpbSsiWnxNN//83ouBx2dN6xbCYXNkZGeo2c2YdP2YXVhkkyjj0eO4GwcY7clH/ w/JA== X-Forwarded-Encrypted: i=1; AJvYcCUY3Mh6t5mLbpQhpgtVvNHZfjCbAB4gX6QpzVfnDuDatUlxTtyKtTka2fJn+Huti617eizwE2yHqMcPnhlSpjkJEKqDLsLRrG9CVo/g X-Gm-Message-State: AOJu0YwnGtxN+tcTs0i4TA7yni7ue5nTNGWBRCH9f/u1i5PRE0Y1aVnO JjgZcOBf7LSpfX4+OSjbPhJrIaU7OK8tZXaM6hceAZfZAy6ecZr1SI6ATPW79H4= X-Google-Smtp-Source: AGHT+IFvAtaidOO7h0zkTLuuS0Zuix9lqDgu9+DKxThfm0jLTYtjgYSEE2bX05vg7lHkXPUfguF9Bw== X-Received: by 2002:a05:6870:9f86:b0:22e:de21:e084 with SMTP id xm6-20020a0568709f8600b0022ede21e084mr7083274oab.9.1714057415874; Thu, 25 Apr 2024 08:03:35 -0700 (PDT) Received: from freyr.lechnology.com (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id mp2-20020a056871328200b0023b6d4723edsm166739oac.14.2024.04.25.08.03.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Apr 2024 08:03:35 -0700 (PDT) From: David Lechner To: Jonathan Cameron Cc: David Lechner , Lars-Peter Clausen , Michael Hennerich , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/3] iio: adc: mxs-lradc-adc: don't set masklength Date: Thu, 25 Apr 2024 10:03:28 -0500 Message-ID: <20240425-b4-iio-masklength-cleanup-v1-2-d3d16318274d@baylibre.com> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240425-b4-iio-masklength-cleanup-v1-0-d3d16318274d@baylibre.com> References: <20240425-b4-iio-masklength-cleanup-v1-0-d3d16318274d@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Mailer: b4 0.12.4 Content-Transfer-Encoding: quoted-printable The masklength field is marked as [INTERN] and should not be set by drivers, so remove the assignment in the mxs-lradc-adc driver. __iio_device_register() will populate this field with the correct value. Signed-off-by: David Lechner --- drivers/iio/adc/mxs-lradc-adc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/iio/adc/mxs-lradc-adc.c b/drivers/iio/adc/mxs-lradc-ad= c.c index 2e60c10ee4ff..8c7b64e78dbb 100644 --- a/drivers/iio/adc/mxs-lradc-adc.c +++ b/drivers/iio/adc/mxs-lradc-adc.c @@ -724,7 +724,6 @@ static int mxs_lradc_adc_probe(struct platform_device *= pdev) iio->dev.of_node =3D dev->parent->of_node; iio->info =3D &mxs_lradc_adc_iio_info; iio->modes =3D INDIO_DIRECT_MODE; - iio->masklength =3D LRADC_MAX_TOTAL_CHANS; =20 if (lradc->soc =3D=3D IMX23_LRADC) { iio->channels =3D mx23_lradc_chan_spec; --=20 2.43.2 From nobody Sat Jul 11 14:56:03 2026 Received: from mail-oa1-f49.google.com (mail-oa1-f49.google.com [209.85.160.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1D9E14A603 for ; Thu, 25 Apr 2024 15:03:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714057419; cv=none; b=KckDQv9cBNot9l7kLhjr4lO4keyIvpwMPZjVOgkneHPBluLgZAvcsONX4VuYdt4oaPVboViERUwhqueFf/seB3QATGwAY2ypa9FxxcA41llgIga7CgRuAaV+j44DxBgutugBnOC5KDW+C379Ic0qBQNfGjl5q87GOX720+AB89w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714057419; c=relaxed/simple; bh=InEifnlaJ03rA8QgNLlhw6s+Q05Y2oXvccfChwmxIgw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Olmdw8aJM1qwwpgK8LGNWHzaSoMzMhoFrbVzF1sFvbCDpfNKh+81MW/uaZ24BpZlffVLF+ar1E9o7ZjMUmzNCrmUqouM27nipdQmW1q3vHDsd4QyQ4zD4og8hx3LyZiEwSgCYbyBFmp/S9lyjwzJ4lvxGQq98+ar6mpIoHvZbMQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=TIpy5pPs; arc=none smtp.client-ip=209.85.160.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="TIpy5pPs" Received: by mail-oa1-f49.google.com with SMTP id 586e51a60fabf-22edbef3b4eso386342fac.3 for ; Thu, 25 Apr 2024 08:03:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1714057417; x=1714662217; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ALDEBHn1/H2TDQekY233nOtWpDkhb+DBBbFG5htxIm8=; b=TIpy5pPseRhnmR9FLqscjBFlJRI02XbEEfKOTANAFpAwSn6p5pHfYOVnIiUP4/lVR0 SCKs5RJgvLEh3rRb0B81op9pcu46ZfsUXwvYnuS/MC5NRTuIvi0+tQ6XV9UL/J1LXUyz aWgVBNUa7mk1f9YLIeCFlhmG9O7et2EdzgopMH5N6yIib3QkFUp+2cAWo5GrSVDJkfW9 xEHr32rfuW2DbAQj9sh2djMryNRaUOhRwCptyrPdiVnzNK7xIdemr8RwDenECAQVIwp9 AYMicp9POLOtRaLRBcTCcgxqMNXjL86AXoWRMsEe+5/QwdH8VBM5fBvfzA6BY7RHhl0f 3bKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714057417; x=1714662217; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ALDEBHn1/H2TDQekY233nOtWpDkhb+DBBbFG5htxIm8=; b=RFLOqcTC9sIReDBGzxRCeIbUFPWzTNfx6y0Gztw4gvOAgbVnkuktIN+1R0+q1vqtLs KSCAuIQj8f9P9sQCZC7pnNVJMFsAP7mzasHI8/jtSnryQaTknoYBrhNOfidQ39qiIzBB AauyRfk5jPd6/ETKQ44/3nDmsVvBx795G0nzCu6rFzMow1nG9H1VqIPkRA1mwKs9lX4w mglt0fNeNuUXhx1xL4I+WohOOZMSsNYD8KjdBQB9VCRXHdfQ/nQBj5/J3qr9risIvhsg JgH79kiogtpgtEOXQjrIrTWj0aYnmJlEMl/mkDhrbEdFP81KKw2Dq3h9v6Pbibkk+lSl KMMQ== X-Forwarded-Encrypted: i=1; AJvYcCV6PKVR1bXtqs8Ug7RQXliQfR4GQFGTr0apXgnVco77OsbATpkPop0PKcOAsHxVDuBzOiri7b6TGuGGqzfeyxHs+XiWpM+h1q6/urpI X-Gm-Message-State: AOJu0YyNV2ckp2dsWN4bgVrdLO0FAby3NPVoPPdZMuvxP4EETCo2Xyy9 LO2ntAu4o3t8BlE3fh2CzwG+MRCTFToMMs9lt16eXLfZKgUHLu8XLrJr/ncSTrk= X-Google-Smtp-Source: AGHT+IF+ytB1gMG5gdlzfQf5qI8kdu3jxsrVIZyaQCoI1mcDdWPMWQNB0NwCuMDh4O5EGMwTLzBV2A== X-Received: by 2002:a05:6870:c394:b0:23b:8a59:f5b4 with SMTP id g20-20020a056870c39400b0023b8a59f5b4mr702248oao.2.1714057416777; Thu, 25 Apr 2024 08:03:36 -0700 (PDT) Received: from freyr.lechnology.com (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id mp2-20020a056871328200b0023b6d4723edsm166739oac.14.2024.04.25.08.03.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Apr 2024 08:03:36 -0700 (PDT) From: David Lechner To: Jonathan Cameron Cc: David Lechner , Lars-Peter Clausen , Michael Hennerich , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: [PATCH 3/3] iio: buffer: initialize masklength accumulator to 0 Date: Thu, 25 Apr 2024 10:03:29 -0500 Message-ID: <20240425-b4-iio-masklength-cleanup-v1-3-d3d16318274d@baylibre.com> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240425-b4-iio-masklength-cleanup-v1-0-d3d16318274d@baylibre.com> References: <20240425-b4-iio-masklength-cleanup-v1-0-d3d16318274d@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Mailer: b4 0.12.4 Content-Transfer-Encoding: quoted-printable Since masklength is marked as [INTERN], no drivers should assign it and the value will always be 0. Therefore, the local ml accumulator variable in iio_buffers_alloc_sysfs_and_mask() will always start out as 0. This changes the code to explicitly set ml to 0 to make it clear that drivers should not be trying to override the masklength field. Signed-off-by: David Lechner --- drivers/iio/industrialio-buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-b= uffer.c index 1d950a3e153b..cec58a604d73 100644 --- a/drivers/iio/industrialio-buffer.c +++ b/drivers/iio/industrialio-buffer.c @@ -1744,7 +1744,7 @@ int iio_buffers_alloc_sysfs_and_mask(struct iio_dev *= indio_dev) =20 channels =3D indio_dev->channels; if (channels) { - int ml =3D indio_dev->masklength; + int ml =3D 0; =20 for (i =3D 0; i < indio_dev->num_channels; i++) ml =3D max(ml, channels[i].scan_index + 1); --=20 2.43.2