From nobody Sat May 18 10:48:37 2024 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57B3115ECFA; Wed, 24 Apr 2024 15:07:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713971239; cv=none; b=sHilMXYfrbEI815H9mc8W8eFZ4FuvEyINEH3rSyDhhpUTMCmmMFgs30uhFhvry7out664p6Sc5yOJKA/fn8xIB551U+2XEZJmspfDMGQkICy/8HDdvVsS5uBdvTkxWZE429QUkzjY1apBrHZfm9sEhe5Gty0/A1vdM+mVSLXmV4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713971239; c=relaxed/simple; bh=K1UkPr+qwrl0AxN89XM75ZcSZhSG0ZNbLMmfwU7qP70=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PfVuKr2taIpVftAXSkx3w7L9AB7GmoHVsywNNU1uVa92C38a31bbIMjNGB0k7X9eLi2JSAFmfgJ5VKSLpPfGniBqIvgtpGwlLakXsm9b7tOR+KWkEza0yJR0EClH4635AaZgwSsewyHMA260oaSVqt/Bzo8ldsXgAEO0LasCHwE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MlWdgoJE; arc=none smtp.client-ip=209.85.167.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MlWdgoJE" Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-516d1ecaf25so9110562e87.2; Wed, 24 Apr 2024 08:07:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713971236; x=1714576036; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YkIadt0nAZR1d0O39/7H5hjsJWBN2vmdJ6bdv/9nuZs=; b=MlWdgoJEB/yTUESiLLIdjQ+QH/AlJinjpw4qfExO/1XNXCnYUa/Z4pCHTGbSWFxOGr reOPfZl4mBkbOITHRm9S8b7fGLikxebb0C6vm/ybKcxZU/pLJ7hMjRi6gI+4jwPy5NQO qvyUILN6Hdv3UMvpUMshV0305GH/u5G3gdvdpPBbaaTmzkNk30klJbGa0q0pnUvvhjpW TgAAUIWrOcZ2pGTH9HioiZ6ZgKadsFY2hI9h2j6EWQGr2++qHoz11QeqpL7VQMyW4v4g 8SkXdaQNBukew10s3Eb0BVFYOEpJs1UciJaRooRWLDD5BpmvadtGEdsViYRPJ1X7+jOC uaEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713971236; x=1714576036; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YkIadt0nAZR1d0O39/7H5hjsJWBN2vmdJ6bdv/9nuZs=; b=XJY3ljeDP6m64YPQKo7rkoo2Dp7xhsSG0Ke0Q1Vkq5wPaKQZXtP6iJdKHy7VjHKDLP cSFUDX/u0UCNadlJHg/rSRuW2YNZNMX6lrZV4xiWs8aOhMHB8uNqrHO6ceddOtGXqfLB l8PJG0+7JPVRPNwzZB6bMaWXenJqq6Dqv2VBTUKpuYNAkjNw1wnLiwl9/OKd5EHMr4E6 CrsuVqQrnxOs3R7M5xVTXhDy27DKqSZ0Y3/ybJAo3CeaYGqcL2E2iD3P0XwxUWpPdCsj UfyO4g/I9aDT8k7DH/oTaw6ovDDSBYqwfk1Q+KWWyLb0mzfd22AQnjd63sZ2g5ndyKrY mlaQ== X-Forwarded-Encrypted: i=1; AJvYcCVO0IYkGVrhvPwGhaVrLOBIYGVYr6DZDkwbqDEliXGEGQ4GxddPoth+qfZ00gafiDSPNmoulIqmEAo55jtXgS3M2yEKfuwPDik/lFMw167mAUJeLenYYwit0Ijz4dfLak0ge0A103hn X-Gm-Message-State: AOJu0Yy0hK+XtFBNviHzjgqP4BwmF0eoir7fd0mGEmbMNj3UePQje3Pn iyJzYlzSRFXYfxbyFvqjdN1PyeLWihu84ZWxywIIvgdUZrx0lvFX X-Google-Smtp-Source: AGHT+IFKR3aIMaG4k6RQKdu1uyQ9JThl3xv6DWlgYkNU2HNj7EBr834s94d2fI8WSxe0rvMURCdQZw== X-Received: by 2002:a19:ee19:0:b0:51b:79b7:8322 with SMTP id g25-20020a19ee19000000b0051b79b78322mr1935006lfb.52.1713971236220; Wed, 24 Apr 2024 08:07:16 -0700 (PDT) Received: from localhost ([178.176.56.174]) by smtp.gmail.com with ESMTPSA id v28-20020a056512049c00b00519558f5d83sm2432171lfq.289.2024.04.24.08.07.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 08:07:15 -0700 (PDT) From: Serge Semin To: Serge Semin , Mark Brown , Andy Shevchenko Cc: Andy Shevchenko , Andy Shevchenko , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND v4 1/4] spi: dw: Convert to using BITS_TO_BYTES() macro Date: Wed, 24 Apr 2024 18:06:42 +0300 Message-ID: <20240424150657.9678-2-fancer.lancer@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240424150657.9678-1-fancer.lancer@gmail.com> References: <20240424150657.9678-1-fancer.lancer@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Since commit dd3e7cba1627 ("ocfs2/dlm: move BITS_TO_BYTES() to bitops.h for wider use") there is a generic helper available to calculate a number of bytes needed to accommodate the specified number of bits. Let's use it instead of the hard-coded DIV_ROUND_UP() macro function. Signed-off-by: Serge Semin Reviewed-by: Andy Shevchenko Reviewed-by: Andy Shevchenko --- drivers/spi/spi-dw-core.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-dw-core.c b/drivers/spi/spi-dw-core.c index 0274c9295514..722b5eb1f709 100644 --- a/drivers/spi/spi-dw-core.c +++ b/drivers/spi/spi-dw-core.c @@ -6,6 +6,7 @@ */ =20 #include +#include #include #include #include @@ -421,10 +422,7 @@ static int dw_spi_transfer_one(struct spi_controller *= host, int ret; =20 dws->dma_mapped =3D 0; - dws->n_bytes =3D - roundup_pow_of_two(DIV_ROUND_UP(transfer->bits_per_word, - BITS_PER_BYTE)); - + dws->n_bytes =3D roundup_pow_of_two(BITS_TO_BYTES(transfer->bits_per_word= )); dws->tx =3D (void *)transfer->tx_buf; dws->tx_len =3D transfer->len / dws->n_bytes; dws->rx =3D transfer->rx_buf; --=20 2.43.0 From nobody Sat May 18 10:48:37 2024 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F093815F30A; Wed, 24 Apr 2024 15:07:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713971241; cv=none; b=CM9Pb6BSVbuPTOroHUxyQM+FGuaezcrfSJs427r52AvNBEgMyuDb7vqpQ0Sn4PISDN8b7cHJOTDRN6SEmWw19FsMVQhnqPv0WSdks4porCrdJizb4lFiozDgw0+9EZyVGCbHwcJN5pxxrWtIwVWFyiqb8vf8y+FEsRjQxlZuudU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713971241; c=relaxed/simple; bh=wn6duOFR0By1a9rcZwmatu6QiLy3rmMNGIJzk+ktlD4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pyBOvlGc6cnMDg+QSS3uWD7oYBXAplwhLDoy8y0ietqNqqvGFrc4jwW7OJd9eD0YZ9q1O3DffY3RsTYfhXnDeoxQFYdqWJUmfzimGMoup1/qZxforQ5kliy9Hb8zZ/NLswaXvPEW/NUBcqq+PEURmdJzf0OAW7NWPKcBcaJp/n4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KJG39ONf; arc=none smtp.client-ip=209.85.167.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KJG39ONf" Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-518a56cdc03so8637144e87.1; Wed, 24 Apr 2024 08:07:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713971238; x=1714576038; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IXtT3vdT1DlOmZWPolm6flA8JD62wpxOz2LSc4zAwz4=; b=KJG39ONf9sTFwvT5TICSgm6lsdUp+4fOkb7jszoaOv6Wb7ts4ckhNbauRH+6/QZH0S jpDAxzvdlMgdeqzVezAs9h7W2+OEMRyI9w1G7RS5J2axBodX0sPzhXgw6vniF5o4V1fU x36JWyOCgsSnI+BWYxDo76vzG3XNpML3A2dud9y3R4zw+PXlwZV4+rbFW2qxcruXPEZn D8DJElxlpRZrfNFBZLZlABiDdKJ8nHpI+BTgTwp39FgOIsLOEN0DHUn6o+L19gQ+WHBh f6Wlp9NvIHJXscbFLbDVJLIv2/JGPp7+OAfwfnpPkmc9LG5gkI8QW0QI63djeSe/r9mf Ya5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713971238; x=1714576038; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IXtT3vdT1DlOmZWPolm6flA8JD62wpxOz2LSc4zAwz4=; b=QRhAE+YiFoJEppvAmLoPeDiGvQ0VcnKit66RdVefdxVEFUXzZQUx/2AgAygO2Pg2fD deWK7Qrn8+HZqu0/IYBjMPu6pS0uonUOP54mflbsBOpv4suA0KYqRp70PNC3phtNgV3o YejeZ+37ZTHVJccpQnQSm976irG3m/FcHxmPR4cpgwgt6MHU+FVHQxLfMphyHUFoq7cZ nJyegjuGqNI00c6+qvrqwUrvlecOZUuo23CFmZymTuCSRwPxCQOxcjjG7Hw3yggUuIKD oFCDdeLufkiSg051y0wjL9onWhSQAelH3a0AGUHAbBFohXZX7OBKx8aSoy8TVASImREU zRig== X-Forwarded-Encrypted: i=1; AJvYcCVUFGhyTI33E2/Ed82qvS6GUCexJ/8myD2uf0+l9pMQEvEJPkd948SysJpCrEdh4MQ5TyC3aurkQNIvFnmhNl58b/TFo3YUIEv54yn5+PUYbojs91K/HekKgZQ5wU4Bmk8ClxXVjTvw X-Gm-Message-State: AOJu0Yyw7kOTJRtHCm4dpCc7+2Kpf40eP9S9nUZ0XOeOsKrBjd7LR0kW 67OWY9vx9bMohz4bB3y9zXtuP0Y8tr9ylWy2pDvOOR/YM/a4ZFPUJ9+oVQ== X-Google-Smtp-Source: AGHT+IFOZI5q6xCtCYfNHga3s7Hp5kGMUXV1xn1xC1b6C6pnnPy2Hr/jNBvnCEF0Vfu9C8weJF7UEw== X-Received: by 2002:ac2:4889:0:b0:51b:6296:8d1a with SMTP id x9-20020ac24889000000b0051b62968d1amr1803161lfc.29.1713971238032; Wed, 24 Apr 2024 08:07:18 -0700 (PDT) Received: from localhost ([178.176.56.174]) by smtp.gmail.com with ESMTPSA id o9-20020a05651238a900b00515c8ff6f52sm2440664lft.229.2024.04.24.08.07.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 08:07:17 -0700 (PDT) From: Serge Semin To: Serge Semin , Mark Brown , Andy Shevchenko Cc: Andy Shevchenko , Andy Shevchenko , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND v4 2/4] spi: dw: Add a number of native CS auto-detection Date: Wed, 24 Apr 2024 18:06:43 +0300 Message-ID: <20240424150657.9678-3-fancer.lancer@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240424150657.9678-1-fancer.lancer@gmail.com> References: <20240424150657.9678-1-fancer.lancer@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Aside with the FIFO depth and DFS field size it's possible to auto-detect a number of native chip-select synthesized in the DW APB/AHB SSI IP-core. It can be done just by writing ones to the SER register. The number of writable flags in the register is limited by the SSI_NUM_SLAVES IP-core synthesize parameter. All the upper flags are read-only and wired to zero. Based on that let's add the number of native CS auto-detection procedure so the low-level platform drivers wouldn't need to manually set it up unless it's required to set a constraint due to platform-specific reasons (for instance, due to a hardware bug). Signed-off-by: Serge Semin Reviewed-by: Andy Shevchenko --- drivers/spi/spi-dw-core.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/spi/spi-dw-core.c b/drivers/spi/spi-dw-core.c index 722b5eb1f709..ddfdb903047a 100644 --- a/drivers/spi/spi-dw-core.c +++ b/drivers/spi/spi-dw-core.c @@ -834,6 +834,20 @@ static void dw_spi_hw_init(struct device *dev, struct = dw_spi *dws) DW_SPI_GET_BYTE(dws->ver, 1)); } =20 + /* + * Try to detect the number of native chip-selects if the platform + * driver didn't set it up. There can be up to 16 lines configured. + */ + if (!dws->num_cs) { + u32 ser; + + dw_writel(dws, DW_SPI_SER, 0xffff); + ser =3D dw_readl(dws, DW_SPI_SER); + dw_writel(dws, DW_SPI_SER, 0); + + dws->num_cs =3D hweight16(ser); + } + /* * Try to detect the FIFO depth if not set by interface driver, * the depth could be from 2 to 256 from HW spec --=20 2.43.0 From nobody Sat May 18 10:48:37 2024 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3BC315FA6C; Wed, 24 Apr 2024 15:07:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713971243; cv=none; b=p5OINEqTKH6Tb6ksrxekN6JYr75HnRSjz4OEQPKTqGoqOYjhHTx5Y36m+ZY9I16mwoCMcDLB1VaffJ1BDiR/1mUctvoUhxshv7+H9YR/7KwSt0nlr5aNh50aWYX5ZShHwDI23+fGvA/rWVCR4mQoPsPoFUsdIv5aXm1omtC16A8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713971243; c=relaxed/simple; bh=UGWxHmZrSPG8/xRqYnebAtoN4G8LcvIkIQJroY+v/X4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=azcfP5YEgY8DAqxqeKNlLhk35PQMITA2x5vHKXaHerCddYP9m6ObHiIH3D7F7U/PClHmvRs/kV2zFD/UGJALGeek6yBDW2EZoQD7xkD1GFrhhzvP4Ly1astBn9Rw+jU5I0VHk5YykWaIjPKKw4HLbYg6y99H7HMolS4Q466aaxg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TLNgThCM; arc=none smtp.client-ip=209.85.208.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TLNgThCM" Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2d88a869ce6so97872651fa.3; Wed, 24 Apr 2024 08:07:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713971240; x=1714576040; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HGFEeAw7g7SRdmEPZBJXDlgsScugDV25Y9+Iq5aXYYE=; b=TLNgThCMlQoL3ZRNS2U8qxuhzNWveQ1ygbV+12lZroF4rQuMWJL78seCYE1bFisQKV 5rFSlm1A8PyCQdpHpWWdw+n1NMRAbww6eKp2UsFNe9wItwWdAwMGBYJw4hJzrEjuGZDC 12shhuR1NkVHDeyFoM2ebLF9aB1Jdyfuy7G8usIZXENeIfEdKxnT0tsEL4iyeSnJP5Su J9IqAS31gbDBJTzl7fFqhf15V12385unp/UMe0M790Thf/cp93wYRLHUe8CsWulR/r8X foQJDhE9QFvSAVtDMeATsQZJOi5tvmNNyqNQ+2jUpASebNYsvTlBLcDHliyIiOhtZDtw IEhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713971240; x=1714576040; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HGFEeAw7g7SRdmEPZBJXDlgsScugDV25Y9+Iq5aXYYE=; b=LkeFMCSh8+r4aPBKzJfmHSIQAYsFgpr73kImlqGmo8Jhjd7fUJm6otrCQKuDlhJNV+ r66tlPg4WPQLRUg0Qzj0ZgLTWu0r4p1yR3TvlhyEclxgE6MLLzNn8vh+SKMSJiCn4N7k aatFa+8W4WJaBIzx5KS/Dox38Q9Iupi2RSAIG6dKdRrNSrpy3gAWeUfm3IhY+P+ZCRMq Ye5ZN2R+lBFyYv4/VaZHfV+BsjX44WmhakHmYtrC15Y/1JxZFR0Y/xe+Ia+y2PEsKG5k pImdjE7yqUSm3HZJgU1ZVCwXklFlm3CiN8/wshMdBTyj5RZiFmhWiRV7r3krx51uYr02 txOA== X-Forwarded-Encrypted: i=1; AJvYcCVJrQUnn17sc0edSQ/OQ3Ym27gKKzDSWaCcJmmyyOHS0bBxvCleRpnDXjocSQY3Y5AXPBg0gFrLnOvxjBsM3muMFsq3M/yNpmcvbY2bklEsGW/tEyl6nM9zG+LWDzIRMI7MUFGcvBoU X-Gm-Message-State: AOJu0YwluJyl7ALX+w8v2nCoXNWq7Ne5Qnr5OTcoZOAhejz0YP/6x7F8 U8LyCtG4prEqa9AgaiUGLEtiHFU/UoVawL2sdUNDUe7QTlfgOlSTjCMupQ== X-Google-Smtp-Source: AGHT+IGh6P9/jGPmZsaaKejTncr4C3FmUZ48Pp4QBCoWQcVIVrcCpb320zF2eFeI5o4F3q4MUhCN+w== X-Received: by 2002:a2e:81c2:0:b0:2da:736d:3cf5 with SMTP id s2-20020a2e81c2000000b002da736d3cf5mr1779681ljg.41.1713971239749; Wed, 24 Apr 2024 08:07:19 -0700 (PDT) Received: from localhost ([178.176.56.174]) by smtp.gmail.com with ESMTPSA id b39-20020a05651c0b2700b002dd1f5c8fb7sm1281148ljr.82.2024.04.24.08.07.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 08:07:19 -0700 (PDT) From: Serge Semin To: Serge Semin , Mark Brown , Andy Shevchenko Cc: Andy Shevchenko , Andy Shevchenko , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND v4 3/4] spi: dw: Convert dw_spi::num_cs to u32 Date: Wed, 24 Apr 2024 18:06:44 +0300 Message-ID: <20240424150657.9678-4-fancer.lancer@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240424150657.9678-1-fancer.lancer@gmail.com> References: <20240424150657.9678-1-fancer.lancer@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Number of native chip-select lines is either retrieved from the "num-cs" DT-property or auto-detected in the generic DW APB/AHB SSI probe method. In the former case the property is supposed to be of the "u32" size. Convert the field type to being u32 then to be able to drop the temporary variable afterwards. Signed-off-by: Serge Semin Reviewed-by: Andy Shevchenko --- Changelog v2: - Just added. --- drivers/spi/spi-dw.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-dw.h b/drivers/spi/spi-dw.h index 6cafeee8ee2a..fc267c6437ae 100644 --- a/drivers/spi/spi-dw.h +++ b/drivers/spi/spi-dw.h @@ -164,8 +164,8 @@ struct dw_spi { u32 max_freq; /* max bus freq supported */ =20 u32 reg_io_width; /* DR I/O width in bytes */ + u32 num_cs; /* chip select lines */ u16 bus_num; - u16 num_cs; /* supported slave numbers */ void (*set_cs)(struct spi_device *spi, bool enable); =20 /* Current message transfer state info */ --=20 2.43.0 From nobody Sat May 18 10:48:37 2024 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BA0F15FCE1; Wed, 24 Apr 2024 15:07:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713971244; cv=none; b=XWyD9FF7vFdommE5SwM69utO2O8MuGhGyFeCcSdPjA3b8j9fORSnYCKH+NsziNCcXIgOsLf1N88PMDaSr198/sqvN3vq+jnpzv/n0rxu5WXrtDhBefyV71KxfcJ7zo6LH16sWe/KC1yR1mDqfPAXpDSH0ck6zAXZejt25hLQK60= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713971244; c=relaxed/simple; bh=0PBo9Of6CNy3BPbkd/tZVfSeHDs2kDzIZaMPAx/MRPk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XzTCMdlYMUtKW59VjBdVqMTssxrPfBrtx66DytIVXxyA3FZ2AskzroinFKsjq4YZFjGahgxFfTIakZ26bKJyOyXneooJ24cigxCcv/sDta9oGTKxrQcso66Ys3YIdct9MgQ37i02ZRE4FT57YHRKwq73sJtoEkg1dRIbayjKFZ0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OPspMI3f; arc=none smtp.client-ip=209.85.208.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OPspMI3f" Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2d895e2c6efso104758991fa.0; Wed, 24 Apr 2024 08:07:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713971241; x=1714576041; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dckUSl5z4UaY1zLi6ZaUm7FPVPOD+pWKaRJKmeXicSI=; b=OPspMI3fI7edIm7uN2XEaEpJd+l6xqf8iloUE3La6xqjJaiZZgXaxi3jNa+bkAJqBd S5yNeKK2KYQCrzWSqGWxlxqTTLkGWQaZJIoZjil4nASfXExYyROAmfXp/wSvWaqjoWiB NGM8FAPvUUWTHdzX8bMr/RGGkgzgXNqiw//1p0Ls2dAH0JVztDblGuZrFMNBC/+K3gI0 Zrm2uCLBJmESXGhZQFu3tWeG3BqqxuuClQI26lg2eQVvUBRuz5gTO+VmJJlABEwkJyNI ihMPN8oYn0yGDA/zl/QJ9U07XQbbisvW80S5mzb5Kin6swSXDkezwEBX0WIOYpatmjnB UEyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713971241; x=1714576041; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dckUSl5z4UaY1zLi6ZaUm7FPVPOD+pWKaRJKmeXicSI=; b=sFyqgd9JmdVfmg4uaSS1ZCcmMakG2W2vcPicRi13ltNC1AsBZH6CX76puE4u9K5yss xlkx4VZw9Wk3HWBBP1QeMGOwy5QUXzZySt0F5xWZ1Ky//iU8wig+Z/yF4D0uMEai1QmZ opodPifb4zZCao4M4D8Y0BbcqkT3v87BTttRy6Ljsn7+O9/2WqL3ln9/hii54p6lCJb9 ZSD0tQ5Ecd10eLDjt5eT9/QGrcuMpWPaoEn5tC07MTFHkktj0UQ7FUh94m3ujcsRASxh zLWKjaD2K7T64LrpBBXwMBG8+ZGPtazz6cdupJ0SG3tP/KyqIGK0CPOIJLGYce8m+UOl Tmxg== X-Forwarded-Encrypted: i=1; AJvYcCVzmdBVEO7Ajp07Nm+wpLtcuTff04Gpr+udQHTfCDk9j4uLIjVWCc3/45MJav+XExDIHjZ4EFHenYP6k+GTTIJQ2lPYy1+QTmM6l4vRY9M416cJWnk9M+9S/uTW+/IWIebfEIMMqH+0 X-Gm-Message-State: AOJu0YynbuSNwCqr52CxnWYa4A7jJbU/r/n2WOfRNkD0MNKjZdEQ76mE he/7goNzLU1G4BNGBgWvqaRUkmJGYXmkzNqbjN+lWHSqCCfFfUK6 X-Google-Smtp-Source: AGHT+IEE4EQyH+7OCx2jiJMXA2ZH8Vw1BDpJTqHiVv49d1ENUeSiB03CIDrUDitizpKbCjVxyKOH+w== X-Received: by 2002:a2e:9855:0:b0:2d8:144e:c464 with SMTP id e21-20020a2e9855000000b002d8144ec464mr1685917ljj.36.1713971241416; Wed, 24 Apr 2024 08:07:21 -0700 (PDT) Received: from localhost ([178.176.56.174]) by smtp.gmail.com with ESMTPSA id y18-20020a05651c221200b002de02f28ba1sm533935ljq.94.2024.04.24.08.07.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 08:07:21 -0700 (PDT) From: Serge Semin To: Serge Semin , Mark Brown , Andy Shevchenko Cc: Andy Shevchenko , Andy Shevchenko , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND v4 4/4] spi: dw: Drop default number of CS setting Date: Wed, 24 Apr 2024 18:06:45 +0300 Message-ID: <20240424150657.9678-5-fancer.lancer@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240424150657.9678-1-fancer.lancer@gmail.com> References: <20240424150657.9678-1-fancer.lancer@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" DW APB/AHB SSI core now supports the procedure automatically detecting the number of native chip-select lines. Thus there is no longer point in defaulting to four CS if the platform doesn't specify the real number especially seeing the default number didn't correspond to any original DW APB/AHB databook. Signed-off-by: Serge Semin Reviewed-by: Andy Shevchenko --- Changelog v2: - Drop temporal variable and pass dws_spi::num_cs directly. --- drivers/spi/spi-dw-mmio.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/spi/spi-dw-mmio.c b/drivers/spi/spi-dw-mmio.c index cc74cbe03431..c56de35eca98 100644 --- a/drivers/spi/spi-dw-mmio.c +++ b/drivers/spi/spi-dw-mmio.c @@ -320,7 +320,6 @@ static int dw_spi_mmio_probe(struct platform_device *pd= ev) struct resource *mem; struct dw_spi *dws; int ret; - int num_cs; =20 dwsmmio =3D devm_kzalloc(&pdev->dev, sizeof(struct dw_spi_mmio), GFP_KERNEL); @@ -364,11 +363,8 @@ static int dw_spi_mmio_probe(struct platform_device *p= dev) &dws->reg_io_width)) dws->reg_io_width =3D 4; =20 - num_cs =3D 4; - - device_property_read_u32(&pdev->dev, "num-cs", &num_cs); - - dws->num_cs =3D num_cs; + /* Rely on the auto-detection if no property specified */ + device_property_read_u32(&pdev->dev, "num-cs", &dws->num_cs); =20 init_func =3D device_get_match_data(&pdev->dev); if (init_func) { --=20 2.43.0