From nobody Sat May 18 05:53:12 2024 Received: from smtpbgbr1.qq.com (smtpbgbr1.qq.com [54.207.19.206]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50423142E8A; Wed, 24 Apr 2024 02:56:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=54.207.19.206 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713927409; cv=none; b=UfoBdgJmWYsGwxMxMm719EeovRzaz2JmoVN7zvZFDpCanwxQ9JuSJwhxbkLXpHKDQV5dQ+NPlKJ2WEUihrU7VvhkLsZAjUS95QJMxc/g2TA8R8P9v0h9HgDdrPkpj4uqz2SKG2MWZde05gWZDifQGwS1f2AFj0jAxW/vOCRtd2g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713927409; c=relaxed/simple; bh=eGgBQtvqHszHLZjEaVNOzyrzgGeymXRzgL/zYDf5Cj0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=KNQy4N9Dn3a4oj10A5Em/wwhqPNBJ7pm0fA2muHGonHN83//qHLx5d6oq8dOdQUQK0Qx2oICgz6VZLPVI8O0NjW/5438YFYtnRfz8M9ounedx7J4Qf+n92yeSNwBSnNhTxYLy6Sl6wI0ZRexRr04Rm0h2RBmx+e0drX2IJ3pj3Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=shingroup.cn; spf=pass smtp.mailfrom=shingroup.cn; arc=none smtp.client-ip=54.207.19.206 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=shingroup.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=shingroup.cn X-QQ-mid: bizesmtpsz11t1713927362tuq3f5 X-QQ-Originating-IP: r4SzD00NWbLMn6CzY4bmfQwvShdm3liWPDr3PAhKA8A= Received: from localhost ( [112.0.147.129]) by bizesmtp.qq.com (ESMTP) with id ; Wed, 24 Apr 2024 10:56:00 +0800 (CST) X-QQ-SSF: 01400000000000903000000A0000000 X-QQ-FEAT: KdN0SWBFoH4pfnOT4RnGCvcbVf07FHD8cWXeImdce+6Iq6YSHyIsvsSoD9y27 KsCp8ccVwDj4QBYvvGKjf2vJo47SQ71YVQg6KR9FhTDlnqPerN9/7ootNfd27xVFJ7cvdRx 2UUjtH9BGHDlTiNkxS2IahGAstKxKzxunZslIzg78B8RA7AuptFCH3hALQG716tHPqUNRwW JpGE5jooPD+tao1IM1lufWUHtfP04D1+7ipsmORCb38Qv/PtsFa2WYWNW5ha5nTfPByBkOd Bgo5kMP6eTUtHWH/NfCpMSIKsrjnPAk8OzhpWnVoI3o26rY3ShOeBfVHHRHT5ta4K5Noctu D2BbhREYfzRh0J4/X8hutImW2ZK/eQ5Qqo134AujtK9Xtre+ZrvZ3yK/6d96+KjbX29MJwl mliS/JVPpFFGmun6FL8YYQ== X-QQ-GoodBg: 2 X-BIZMAIL-ID: 17482992141322820079 From: Dawei Li To: davem@davemloft.net, andreas@gaisler.com Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, sam@ravnborg.org, Dawei Li Subject: [PATCH v4 1/5] sparc/srmmu: Remove on-stack cpumask var Date: Wed, 24 Apr 2024 10:55:44 +0800 Message-Id: <20240424025548.3765250-2-dawei.li@shingroup.cn> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20240424025548.3765250-1-dawei.li@shingroup.cn> References: <20240424025548.3765250-1-dawei.li@shingroup.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtpsz:shingroup.cn:qybglogicsvrgz:qybglogicsvrgz5a-1 Content-Type: text/plain; charset="utf-8" In general it's preferable to avoid placing cpumasks on the stack, as for large values of NR_CPUS these can consume significant amounts of stack space and make stack overflows more likely. Use cpumask_any_but() to avoid the need for a temporary cpumask on the stack and simplify code. Reviewed-by: Sam Ravnborg Signed-off-by: Dawei Li Reviewed-by: Andreas Larsson Tested-by: Andreas Larsson --- arch/sparc/mm/srmmu.c | 40 ++++++++++++---------------------------- 1 file changed, 12 insertions(+), 28 deletions(-) diff --git a/arch/sparc/mm/srmmu.c b/arch/sparc/mm/srmmu.c index 852085ada368..9df51a62333d 100644 --- a/arch/sparc/mm/srmmu.c +++ b/arch/sparc/mm/srmmu.c @@ -1653,13 +1653,15 @@ static void smp_flush_tlb_all(void) local_ops->tlb_all(); } =20 +static bool any_other_mm_cpus(struct mm_struct *mm) +{ + return cpumask_any_but(mm_cpumask(mm), smp_processor_id()) < nr_cpu_ids; +} + static void smp_flush_cache_mm(struct mm_struct *mm) { if (mm->context !=3D NO_CONTEXT) { - cpumask_t cpu_mask; - cpumask_copy(&cpu_mask, mm_cpumask(mm)); - cpumask_clear_cpu(smp_processor_id(), &cpu_mask); - if (!cpumask_empty(&cpu_mask)) + if (any_other_mm_cpus(mm)) xc1(local_ops->cache_mm, (unsigned long)mm); local_ops->cache_mm(mm); } @@ -1668,10 +1670,7 @@ static void smp_flush_cache_mm(struct mm_struct *mm) static void smp_flush_tlb_mm(struct mm_struct *mm) { if (mm->context !=3D NO_CONTEXT) { - cpumask_t cpu_mask; - cpumask_copy(&cpu_mask, mm_cpumask(mm)); - cpumask_clear_cpu(smp_processor_id(), &cpu_mask); - if (!cpumask_empty(&cpu_mask)) { + if (any_other_mm_cpus(mm)) { xc1(local_ops->tlb_mm, (unsigned long)mm); if (atomic_read(&mm->mm_users) =3D=3D 1 && current->active_mm =3D=3D mm) cpumask_copy(mm_cpumask(mm), @@ -1688,10 +1687,7 @@ static void smp_flush_cache_range(struct vm_area_str= uct *vma, struct mm_struct *mm =3D vma->vm_mm; =20 if (mm->context !=3D NO_CONTEXT) { - cpumask_t cpu_mask; - cpumask_copy(&cpu_mask, mm_cpumask(mm)); - cpumask_clear_cpu(smp_processor_id(), &cpu_mask); - if (!cpumask_empty(&cpu_mask)) + if (any_other_mm_cpus(mm)) xc3(local_ops->cache_range, (unsigned long)vma, start, end); local_ops->cache_range(vma, start, end); @@ -1705,10 +1701,7 @@ static void smp_flush_tlb_range(struct vm_area_struc= t *vma, struct mm_struct *mm =3D vma->vm_mm; =20 if (mm->context !=3D NO_CONTEXT) { - cpumask_t cpu_mask; - cpumask_copy(&cpu_mask, mm_cpumask(mm)); - cpumask_clear_cpu(smp_processor_id(), &cpu_mask); - if (!cpumask_empty(&cpu_mask)) + if (any_other_mm_cpus(mm)) xc3(local_ops->tlb_range, (unsigned long)vma, start, end); local_ops->tlb_range(vma, start, end); @@ -1720,10 +1713,7 @@ static void smp_flush_cache_page(struct vm_area_stru= ct *vma, unsigned long page) struct mm_struct *mm =3D vma->vm_mm; =20 if (mm->context !=3D NO_CONTEXT) { - cpumask_t cpu_mask; - cpumask_copy(&cpu_mask, mm_cpumask(mm)); - cpumask_clear_cpu(smp_processor_id(), &cpu_mask); - if (!cpumask_empty(&cpu_mask)) + if (any_other_mm_cpus(mm)) xc2(local_ops->cache_page, (unsigned long)vma, page); local_ops->cache_page(vma, page); } @@ -1734,10 +1724,7 @@ static void smp_flush_tlb_page(struct vm_area_struct= *vma, unsigned long page) struct mm_struct *mm =3D vma->vm_mm; =20 if (mm->context !=3D NO_CONTEXT) { - cpumask_t cpu_mask; - cpumask_copy(&cpu_mask, mm_cpumask(mm)); - cpumask_clear_cpu(smp_processor_id(), &cpu_mask); - if (!cpumask_empty(&cpu_mask)) + if (any_other_mm_cpus(mm)) xc2(local_ops->tlb_page, (unsigned long)vma, page); local_ops->tlb_page(vma, page); } @@ -1759,10 +1746,7 @@ static void smp_flush_page_to_ram(unsigned long page) =20 static void smp_flush_sig_insns(struct mm_struct *mm, unsigned long insn_a= ddr) { - cpumask_t cpu_mask; - cpumask_copy(&cpu_mask, mm_cpumask(mm)); - cpumask_clear_cpu(smp_processor_id(), &cpu_mask); - if (!cpumask_empty(&cpu_mask)) + if (any_other_mm_cpus(mm)) xc2(local_ops->sig_insns, (unsigned long)mm, insn_addr); local_ops->sig_insns(mm, insn_addr); } --=20 2.27.0 From nobody Sat May 18 05:53:12 2024 Received: from smtpbgau2.qq.com (smtpbgau2.qq.com [54.206.34.216]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5436A83CD6; Wed, 24 Apr 2024 02:56:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=54.206.34.216 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713927396; cv=none; b=eBsuxbB3dSihpNHPpH5bbMeD0rlGZ1PK0NlgoRJRF6984SfuQxPRb0AwnGWAUhrqnQnGNp0Dl6v+wWqY3K+IeVDzhUEM7hr3EzvI8jjKRMizJRlpM9+6xiIkGf0RtjlYkSj57QvhrnZbi9OFBt/v0zxLhr1VwiW8l2X8L9bQU3M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713927396; c=relaxed/simple; bh=N6XTfdxhJpxdxT4fVSZa/iMWuusbHZ+zYGBsuw2wehU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=RcFys5OkvNooH02opqoBKl0HzMYJe84lM/RkQUzOGuNpFUPEQxeVAFFU0WxmtXeznE1YQ4qExNhCokzIA2D1wlrBsYgx1PWhfxDUbBCSDSar6xPdEfA7+XAwuQ8GrT0du3HMJE3Bj23f0lxATnlSK7u2ei5kxBVKwzjt7FP0XN4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=shingroup.cn; spf=pass smtp.mailfrom=shingroup.cn; arc=none smtp.client-ip=54.206.34.216 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=shingroup.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=shingroup.cn X-QQ-mid: bizesmtp82t1713927368tef5l9jp X-QQ-Originating-IP: vQmXng/c3dGqL6fSQ4IxNGeevQoaOnnsVqltFEHgBq4= Received: from localhost ( [112.0.147.129]) by bizesmtp.qq.com (ESMTP) with id ; Wed, 24 Apr 2024 10:56:06 +0800 (CST) X-QQ-SSF: 01400000000000903000000A0000000 X-QQ-FEAT: xo0edGM1fUg8OrjGWNCZct+YyvqES/JAHSbFFKFnwFlgur39ypV4UskcVQyYP my9UL+zR8lm+96oqM4Iez/ISdHGwwW6dLM65UV+wSB5NDzjH5Id1DhhMi6/fPe0GxJfmQyu DNGqR2JeKx9TBeNMMZWlVTOlKk2B0JXCyHzvyMn/PGgFHhtCLaWVOmBArTKpzuRklSuecJZ O5lowNPUopa1JQUpq+mWuoSA4tfng6Oq25+HOJrHgPyIDQS0OsUaDG+Fk9LVv4xahfUi+ej rebCGQXKbsD1vjwF+CZgHPN02Lf09kTzmZ7QcSGdpyKDhbic9GjP/KQ0abj0H0VS2WJ5H7A wauoaOfWOTvz+NqKf6niy4S/RiGgIra3PnsaMtI/osZqIle5QS7XKMWC9DEWdg9P8XQDUEg n2cZ1D4jsNxfsWO2LHa+Uw== X-QQ-GoodBg: 2 X-BIZMAIL-ID: 14914195552382651279 From: Dawei Li To: davem@davemloft.net, andreas@gaisler.com Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, sam@ravnborg.org, Dawei Li Subject: [PATCH v4 2/5] sparc/irq: Remove on-stack cpumask var Date: Wed, 24 Apr 2024 10:55:45 +0800 Message-Id: <20240424025548.3765250-3-dawei.li@shingroup.cn> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20240424025548.3765250-1-dawei.li@shingroup.cn> References: <20240424025548.3765250-1-dawei.li@shingroup.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:shingroup.cn:qybglogicsvrgz:qybglogicsvrgz5a-1 Content-Type: text/plain; charset="utf-8" In general it's preferable to avoid placing cpumasks on the stack, as for large values of NR_CPUS these can consume significant amounts of stack space and make stack overflows more likely. - Both 2 arguments of cpumask_equal() is constant and free of change, no need to allocate extra cpumask variables. - Merge cpumask_and(), cpumask_first() and cpumask_empty() into cpumask_first_and(). Reviewed-by: Sam Ravnborg Signed-off-by: Dawei Li Reviewed-by: Andreas Larsson --- arch/sparc/kernel/irq_64.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/arch/sparc/kernel/irq_64.c b/arch/sparc/kernel/irq_64.c index 5280e325d4d6..01ee800efde3 100644 --- a/arch/sparc/kernel/irq_64.c +++ b/arch/sparc/kernel/irq_64.c @@ -349,17 +349,13 @@ static unsigned int sun4u_compute_tid(unsigned long i= map, unsigned long cpuid) #ifdef CONFIG_SMP static int irq_choose_cpu(unsigned int irq, const struct cpumask *affinity) { - cpumask_t mask; int cpuid; =20 - cpumask_copy(&mask, affinity); - if (cpumask_equal(&mask, cpu_online_mask)) { + if (cpumask_equal(affinity, cpu_online_mask)) { cpuid =3D map_to_cpu(irq); } else { - cpumask_t tmp; - - cpumask_and(&tmp, cpu_online_mask, &mask); - cpuid =3D cpumask_empty(&tmp) ? map_to_cpu(irq) : cpumask_first(&tmp); + cpuid =3D cpumask_first_and(affinity, cpu_online_mask); + cpuid =3D cpuid < nr_cpu_ids ? cpuid : map_to_cpu(irq); } =20 return cpuid; --=20 2.27.0 From nobody Sat May 18 05:53:12 2024 Received: from smtpbguseast2.qq.com (smtpbguseast2.qq.com [54.204.34.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 857F285274; Wed, 24 Apr 2024 02:56:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=54.204.34.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713927418; cv=none; b=RxZqT6wmoVLavsPSXUVlltUeDQlN8ePkLzhbTYN7C1FrdLO4tW+c8hCVQf70S4EhJMUkHbDw6U73RhWi4UpicFVc3PL/qhlQS1R7wtTMKkUp/waWTYRpqPK/Sk8kzhWnIWk3dYplyWBb77ofhbPlkOd3pT5CGNbldwwEnITRQFY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713927418; c=relaxed/simple; bh=3q4wkwdzr6bsl7CdF20gWvsb13iPgTuP0auF/wmr1+U=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=BZPZfaRLxKfE/2cKRQKJe7FbARgOKNNaDMNpgbE2YA4vZyEvrQQH7Kh1tlrxhByLqPfgc3HJT+iQlx6IxrKBYwO0cnXZ/TUSDyJPrCPXBtSNeKPGxIGOYVv+GP1GgxI4+IfTd4U+8MDz3Cu5qY1bChN+klToeFwP+Cyot2NcKM8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=shingroup.cn; spf=pass smtp.mailfrom=shingroup.cn; arc=none smtp.client-ip=54.204.34.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=shingroup.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=shingroup.cn X-QQ-mid: bizesmtp84t1713927373txeesovm X-QQ-Originating-IP: RafR794jN92WUzpCABktLdB8zk7MggSEa+h1HLA4pRk= Received: from localhost ( [112.0.147.129]) by bizesmtp.qq.com (ESMTP) with id ; Wed, 24 Apr 2024 10:56:12 +0800 (CST) X-QQ-SSF: 01400000000000903000000A0000000 X-QQ-FEAT: 6MxOmYknsnlk+EvuqNPJydCUebOjjfGQngzxgv3iiMZC/5aK751EwP9r+F8i+ bH9DoKtFsUp/87eM/1WVZzyRE2NN4/1YfQsuiOJUXMdwDslas0+TN0BjT+VlUpBiIqTGE6m /dq6tlAV8/cwazZ7Arvv2NsDoxeFDiADlngWQdLr5U5RgI/MpVehjBcakGq0sviZke76/uQ VhpWfut99UyslE/Kp2uvK0JNZhC8VPtHnUYrmB4nQ0k0vDQjCF50z0BRII1fyp0zQVNTurk PumEGM4FTgnOicwjqBqWFntmiZUVPAf5U7kq51MvgBwz91jX/Ge/3Pr27yOSbRlmLZQAvmO XOnBPEhDEKWngvq+vVGMamH1OOO3sbUsz1W5/FCt0VccXivhBgtSDKNnjHSXv8vHTG+/pMU xXYaKM56jpkqMm/eMwrf+iZeSOUCT06u X-QQ-GoodBg: 2 X-BIZMAIL-ID: 8021827342633474305 From: Dawei Li To: davem@davemloft.net, andreas@gaisler.com Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, sam@ravnborg.org, Dawei Li Subject: [PATCH v4 3/5] sparc/of: Remove on-stack cpumask var Date: Wed, 24 Apr 2024 10:55:46 +0800 Message-Id: <20240424025548.3765250-4-dawei.li@shingroup.cn> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20240424025548.3765250-1-dawei.li@shingroup.cn> References: <20240424025548.3765250-1-dawei.li@shingroup.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:shingroup.cn:qybglogicsvrgz:qybglogicsvrgz5a-1 Content-Type: text/plain; charset="utf-8" In general it's preferable to avoid placing cpumasks on the stack, as for large values of NR_CPUS these can consume significant amounts of stack space and make stack overflows more likely. @cpumask of irq_set_affinity() is read-only and free of change, drop unneeded cpumask var. Reviewed-by: Sam Ravnborg Signed-off-by: Dawei Li Reviewed-by: Andreas Larsson --- arch/sparc/kernel/of_device_64.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/arch/sparc/kernel/of_device_64.c b/arch/sparc/kernel/of_device= _64.c index c350c58c7f69..f98c2901f335 100644 --- a/arch/sparc/kernel/of_device_64.c +++ b/arch/sparc/kernel/of_device_64.c @@ -624,10 +624,7 @@ static unsigned int __init build_one_device_irq(struct= platform_device *op, out: nid =3D of_node_to_nid(dp); if (nid !=3D -1) { - cpumask_t numa_mask; - - cpumask_copy(&numa_mask, cpumask_of_node(nid)); - irq_set_affinity(irq, &numa_mask); + irq_set_affinity(irq, cpumask_of_node(nid)); } =20 return irq; --=20 2.27.0 From nobody Sat May 18 05:53:12 2024 Received: from smtpbgsg1.qq.com (smtpbgsg1.qq.com [54.254.200.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C31AF142E9D; Wed, 24 Apr 2024 02:56:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=54.254.200.92 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713927408; cv=none; b=QbSlL/94YhD/RAk0CKA7qpkeRJ3ae7WqFlQPc0wNSSdPZ8zSEARNi7/viVQ3bvQrH/4X1/+GlEFrXBcVPLgDPYyajruuVWTnAY1Ksrm3EkIkEo4itfVqd3ubV9KhGKxNZvUE0JPmMxgHYgW+3U260Yq9mWuvFP1MFwN43p8ZEKI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713927408; c=relaxed/simple; bh=j26qiSSL/SsQJ3RIDKCP/7AkspKH1HFq2LoNpDQ+AE0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=X8wdWOfqWebo06HCTqsDu5Jh5S/aOyP4FKsFx4lh52M7Z1FzYo4k3YhpHzSRvuoYwJGUK1L1pz7guqZ+plZFOzP20q9Kfb/W1X4GbOS10eBZzAN6jmxDFlCF68h7PYGs4CVnsQ3GrkpwGmOkuNZP6wAjPPJ+r17idgBLJEJpN8s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=shingroup.cn; spf=pass smtp.mailfrom=shingroup.cn; arc=none smtp.client-ip=54.254.200.92 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=shingroup.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=shingroup.cn X-QQ-mid: bizesmtpsz5t1713927379tfy09bc X-QQ-Originating-IP: 2Y46ZsfS8TiAWhD15nAchyw47WXrXxioXt00IGlBVCE= Received: from localhost ( [112.0.147.129]) by bizesmtp.qq.com (ESMTP) with id ; Wed, 24 Apr 2024 10:56:17 +0800 (CST) X-QQ-SSF: 01400000000000903000000A0000000 X-QQ-FEAT: fm3u6yrcHUttQI+skDEKiZYLMDN8WIG5UvAUyFEu1vT01wH8FXRlNDBWALWja 7TR7LrgwZktkn2IpxneBpS5ysyXVQOjEurCYQCKoPei9H0EHmUq4iATC/5/zb5i8pjgMZE1 VhCJQBrXh1pqrhcKlGCqi4AWNnYJci7fd1YtFDRYB8ZWOp0M4IvdzSUCgaATAw7rK+ddTY3 GONiDRfOApPTuLaDTwYK4iLGir4fsQYUZbnGb99eYWpJC5qyltOdNx2ffoOj+uCOf6Io1ro PTalqFx8vXyESbXPUWKhNxYTuPPYSh48J6mH8IZmaiQB6509hw6GZIXbDqi+084MfZLytEd JVprMiqW8VfXyMXMh7sZrKINJXrUTRtfqYaKs7ArV3h0FAnbqMGD8PfgvnO8+N39aFg76Cd f40Exugzedg= X-QQ-GoodBg: 2 X-BIZMAIL-ID: 4302958687084006626 From: Dawei Li To: davem@davemloft.net, andreas@gaisler.com Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, sam@ravnborg.org, Dawei Li Subject: [PATCH v4 4/5] sparc/pci_msi: Remove on-stack cpumask var Date: Wed, 24 Apr 2024 10:55:47 +0800 Message-Id: <20240424025548.3765250-5-dawei.li@shingroup.cn> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20240424025548.3765250-1-dawei.li@shingroup.cn> References: <20240424025548.3765250-1-dawei.li@shingroup.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtpsz:shingroup.cn:qybglogicsvrgz:qybglogicsvrgz5a-1 Content-Type: text/plain; charset="utf-8" In general it's preferable to avoid placing cpumasks on the stack, as for large values of NR_CPUS these can consume significant amounts of stack space and make stack overflows more likely. @cpumask of irq_set_affinity() is read-only and free of change, drop unneeded cpumask var. Reviewed-by: Sam Ravnborg Signed-off-by: Dawei Li Reviewed-by: Andreas Larsson --- arch/sparc/kernel/pci_msi.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/arch/sparc/kernel/pci_msi.c b/arch/sparc/kernel/pci_msi.c index fc7402948b7b..acb2f83a1d5c 100644 --- a/arch/sparc/kernel/pci_msi.c +++ b/arch/sparc/kernel/pci_msi.c @@ -287,10 +287,7 @@ static int bringup_one_msi_queue(struct pci_pbm_info *= pbm, =20 nid =3D pbm->numa_node; if (nid !=3D -1) { - cpumask_t numa_mask; - - cpumask_copy(&numa_mask, cpumask_of_node(nid)); - irq_set_affinity(irq, &numa_mask); + irq_set_affinity(irq, cpumask_of_node(nid)); } err =3D request_irq(irq, sparc64_msiq_interrupt, 0, "MSIQ", --=20 2.27.0 From nobody Sat May 18 05:53:12 2024 Received: from smtpbgeu2.qq.com (smtpbgeu2.qq.com [18.194.254.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0A4D13048C; Wed, 24 Apr 2024 02:56:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=18.194.254.142 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713927419; cv=none; b=B2BRgIdM6odMh1Xhe5+tlKL7yoZpWmgvC8mP2ZMaKknW0Wq7qyi2qN3FFNWYhxsjnjzM6sou2n35P2RUkVtcJB91J9hl96bKinp34Ep3UDZQioNol+rECXaqxW7gB1/b9HA7MsqNqhvEUfERSH9LE2skJpgjQ1OkT6wxUpFeYcA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713927419; c=relaxed/simple; bh=DpRE7d0qbgrqp8GpN4Vpf85og/19uGFkdh9xUEEgvXY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=cpzy3w97zW6OQ9tKwgNXgG7RGObCTU4virY0NQk+pwhQB/TPC6HTYdiiRDDMqT537AoOj9hUaJBVvcU7xVIo1Kr3czSQ50MVd+Vd/zMz+avZOtxjg5kez6XtslRewC6C87VAhV1nJAbG5wsj6WKTpC4YuDO1s8wNZy6CZt5eAYk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=shingroup.cn; spf=pass smtp.mailfrom=shingroup.cn; arc=none smtp.client-ip=18.194.254.142 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=shingroup.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=shingroup.cn X-QQ-mid: bizesmtpsz8t1713927385t6ckiom X-QQ-Originating-IP: ShAjM5kLOVI6wdrEVKrX7oeOucxUtrnz1cdbZovp/n8= Received: from localhost ( [112.0.147.129]) by bizesmtp.qq.com (ESMTP) with id ; Wed, 24 Apr 2024 10:56:24 +0800 (CST) X-QQ-SSF: 01400000000000903000000A0000000 X-QQ-FEAT: 3M0okmaRx3hadG4MSLwqFSCH4XKhrSS9faZakU2v5lNcTIqY5jkbdZnwwOb0K S20X3O7uHmejtrGwPN5aaoOdOSxiGew4mYGYfUl/UaOz14XBXiiYZEHXCCfeMQdiLTfPrtf uzwJloQp9shmCs8CQ+T+rA90vCaZaz6Fn/oiXsrzFoXn1D5ISi5C7aF+gpW2Bm4LV2WBjNx 0VRSAf4qucWnoM7xQccSBrHtAG5cSl+p2xW4w99UY5/lTnR2Tsor4z3mNr9/t4cbWlsb0D0 4IF8U15Tb+wCl8MLS/JRTmEOv0Qu1Jrf8n4bP36bz2ksYXTIkQZZyhWkqvNWr6WMKppb1y/ O6Lz+RZMkmFlHOlocOmUbmbmexZ6j+BRzWSnbL2/y5iZOlOAv7pGfnN71FZRgVUjw4ZzEWF fs0KMO9hnvhRwCt8DHkMig== X-QQ-GoodBg: 2 X-BIZMAIL-ID: 12935631000440679921 From: Dawei Li To: davem@davemloft.net, andreas@gaisler.com Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, sam@ravnborg.org, Dawei Li Subject: [PATCH v4 5/5] sparc/leon: Remove on-stack cpumask var Date: Wed, 24 Apr 2024 10:55:48 +0800 Message-Id: <20240424025548.3765250-6-dawei.li@shingroup.cn> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20240424025548.3765250-1-dawei.li@shingroup.cn> References: <20240424025548.3765250-1-dawei.li@shingroup.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtpsz:shingroup.cn:qybglogicsvrgz:qybglogicsvrgz5a-1 Content-Type: text/plain; charset="utf-8" In general it's preferable to avoid placing cpumasks on the stack, as for large values of NR_CPUS these can consume significant amounts of stack space and make stack overflows more likely. Use cpumask_subset() and cpumask_first_and() to avoid the need for a temporary cpumask on the stack. Reviewed-by: Sam Ravnborg Signed-off-by: Dawei Li Reviewed-by: Andreas Larsson Tested-by: Andreas Larsson --- arch/sparc/kernel/leon_kernel.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/arch/sparc/kernel/leon_kernel.c b/arch/sparc/kernel/leon_kerne= l.c index 4c61da491fee..a43cf794bb1e 100644 --- a/arch/sparc/kernel/leon_kernel.c +++ b/arch/sparc/kernel/leon_kernel.c @@ -106,13 +106,12 @@ unsigned long leon_get_irqmask(unsigned int irq) #ifdef CONFIG_SMP static int irq_choose_cpu(const struct cpumask *affinity) { - cpumask_t mask; + unsigned int cpu =3D cpumask_first_and(affinity, cpu_online_mask); =20 - cpumask_and(&mask, cpu_online_mask, affinity); - if (cpumask_equal(&mask, cpu_online_mask) || cpumask_empty(&mask)) + if (cpumask_subset(cpu_online_mask, affinity) || cpu >=3D nr_cpu_ids) return boot_cpu_id; else - return cpumask_first(&mask); + return cpu; } #else #define irq_choose_cpu(affinity) boot_cpu_id --=20 2.27.0